swink-agent-adapters 0.9.0

LLM provider adapters for swink-agent
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
use std::sync::Arc;

#[cfg(feature = "gemini")]
use swink_agent::ApiVersion;
use swink_agent::{CatalogPreset, ModelConnection, ProviderKind, StreamFn, model_catalog};
use thiserror::Error;

#[cfg(feature = "anthropic")]
use crate::AnthropicStreamFn;
#[cfg(feature = "bedrock")]
use crate::BedrockStreamFn;
#[cfg(feature = "gemini")]
use crate::GeminiStreamFn;
#[cfg(feature = "mistral")]
use crate::MistralStreamFn;
#[cfg(feature = "openai")]
use crate::OpenAiStreamFn;
#[cfg(feature = "xai")]
use crate::XAiStreamFn;
#[cfg(feature = "azure")]
use crate::{AzureAuth, AzureStreamFn};

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct RemotePresetKey {
    pub provider_key: &'static str,
    pub preset_id: &'static str,
}

impl RemotePresetKey {
    #[must_use]
    pub const fn new(provider_key: &'static str, preset_id: &'static str) -> Self {
        Self {
            provider_key,
            preset_id,
        }
    }
}

#[derive(Debug, Error, PartialEq, Eq)]
pub enum RemoteModelConnectionError {
    #[error("Unknown remote preset {provider_key}.{preset_id}")]
    UnknownPreset {
        provider_key: &'static str,
        preset_id: &'static str,
    },
    #[error("No remote preset found for model_id \"{model_id}\"")]
    UnknownModelId { model_id: String },
    #[error("{provider_key}.{preset_id} is not a remote preset")]
    NotRemotePreset {
        provider_key: String,
        preset_id: String,
    },
    #[error(
        "Missing {env_var} for {preset}. Set it in your environment or .env before launching the example."
    )]
    MissingCredential { preset: String, env_var: String },
    #[error(
        "Missing {env_var} for {preset}. Set it in your environment or .env before launching the example."
    )]
    MissingBaseUrl { preset: String, env_var: String },
    #[error(
        "Missing {env_var} for {preset}. Set it in your environment or .env before launching the example."
    )]
    MissingRegion { preset: String, env_var: String },
    #[error(
        "Missing AWS_ACCESS_KEY_ID or AWS_SECRET_ACCESS_KEY for {preset}. Set AWS credentials in your environment or .env before launching the example."
    )]
    MissingAwsCredentials { preset: String },
    #[error("Unsupported provider \"{provider_key}\" — no adapter feature enabled")]
    UnsupportedProvider { provider_key: String },
}

/// Returns `true` if the adapter for the given provider key is compiled in.
///
/// Uses `#[cfg(feature = "...")]` checks so the answer is a compile-time
/// constant for each provider. Provider keys that don't map to any adapter
/// feature (e.g. `"local"`) always return `false`.
#[must_use]
#[allow(clippy::match_like_matches_macro)] // arms evaluate different cfg! flags, not a set membership check
pub fn is_provider_compiled(provider_key: &str) -> bool {
    match provider_key {
        "anthropic" => cfg!(feature = "anthropic"),
        "openai" => cfg!(feature = "openai"),
        "google" => cfg!(feature = "gemini"),
        "azure" => cfg!(feature = "azure"),
        "xai" => cfg!(feature = "xai"),
        "mistral" => cfg!(feature = "mistral"),
        "bedrock" => cfg!(feature = "bedrock"),
        _ => false,
    }
}

/// Returns remote presets filtered to only those whose provider adapter is
/// compiled in. Use [`all_remote_presets`] to enumerate the full catalog
/// regardless of compiled adapter support.
#[must_use]
pub fn remote_presets(provider_key: Option<&str>) -> Vec<CatalogPreset> {
    all_remote_presets(provider_key)
        .into_iter()
        .filter(|p| is_provider_compiled(&p.provider_key))
        .collect()
}

/// Returns all remote presets from the catalog, regardless of feature flags.
///
/// Useful for discovery UIs that want to show available models even when the
/// corresponding adapter is not compiled in.
#[must_use]
pub fn all_remote_presets(provider_key: Option<&str>) -> Vec<CatalogPreset> {
    let catalog = model_catalog();
    catalog
        .providers
        .iter()
        .filter(|provider| provider.kind == ProviderKind::Remote)
        .filter(|provider| provider_key.is_none_or(|key| provider.key == key))
        .flat_map(|provider| {
            provider
                .presets
                .iter()
                .filter_map(|preset| catalog.preset(&provider.key, &preset.id))
        })
        .collect()
}

pub fn build_remote_connection(
    key: RemotePresetKey,
) -> Result<ModelConnection, RemoteModelConnectionError> {
    let preset = required_catalog_preset(key)?;
    build_connection_from_preset(
        &preset,
        preset
            .credential_env_var
            .as_deref()
            .and_then(|env_var| std::env::var(env_var).ok()),
        preset
            .base_url_env_var
            .as_deref()
            .and_then(|env_var| std::env::var(env_var).ok())
            .as_deref(),
    )
}

/// Builds a [`ModelConnection`] for a preset key using an explicitly provided
/// credential instead of reading it from the process environment.
///
/// This is useful for embedders that manage secrets in an external store and
/// want to avoid process-global environment mutation.
pub fn build_remote_connection_with_credential(
    key: RemotePresetKey,
    api_key: Option<String>,
    base_url: Option<&str>,
) -> Result<ModelConnection, RemoteModelConnectionError> {
    let preset = required_catalog_preset(key)?;
    build_connection_from_preset(&preset, api_key, base_url)
}

#[allow(unreachable_code, unused_variables)]
pub fn build_connection_from_preset(
    preset: &CatalogPreset,
    api_key: Option<String>,
    base_url: Option<&str>,
) -> Result<ModelConnection, RemoteModelConnectionError> {
    if preset.provider_kind != ProviderKind::Remote {
        return Err(RemoteModelConnectionError::NotRemotePreset {
            provider_key: preset.provider_key.clone(),
            preset_id: preset.preset_id.clone(),
        });
    }

    let provider_key = preset.provider_key.as_str();

    let api_key = if provider_key == "bedrock" {
        String::new()
    } else {
        let env_var = preset.credential_env_var.clone().ok_or_else(|| {
            RemoteModelConnectionError::UnsupportedProvider {
                provider_key: provider_key.to_string(),
            }
        })?;
        match api_key {
            Some(value) if !value.trim().is_empty() => value,
            _ => {
                return Err(RemoteModelConnectionError::MissingCredential {
                    preset: preset.display_name.clone(),
                    env_var,
                });
            }
        }
    };

    let resolved_base_url = || {
        base_url
            .map(str::to_string)
            .or_else(|| preset.default_base_url.clone())
            .ok_or_else(|| RemoteModelConnectionError::MissingBaseUrl {
                preset: preset.display_name.clone(),
                env_var: preset
                    .base_url_env_var
                    .clone()
                    .unwrap_or_else(|| "BASE_URL".to_string()),
            })
    };
    let stream_fn: Arc<dyn StreamFn> = match provider_key {
        #[cfg(feature = "anthropic")]
        "anthropic" => Arc::new(AnthropicStreamFn::new(resolved_base_url()?, &api_key)),
        #[cfg(feature = "openai")]
        "openai" => Arc::new(OpenAiStreamFn::new(resolved_base_url()?, &api_key)),
        #[cfg(feature = "gemini")]
        "google" => Arc::new(GeminiStreamFn::new(
            resolved_base_url()?,
            &api_key,
            preset.api_version.clone().unwrap_or(ApiVersion::V1beta),
        )),
        #[cfg(feature = "azure")]
        #[allow(clippy::redundant_clone)]
        // Clone needed when multiple adapter features enabled
        "azure" => Arc::new(AzureStreamFn::new(
            resolved_base_url()?,
            AzureAuth::ApiKey(api_key.clone()),
        )),
        #[cfg(feature = "xai")]
        "xai" => Arc::new(XAiStreamFn::new(resolved_base_url()?, &api_key)),
        #[cfg(feature = "mistral")]
        "mistral" => Arc::new(MistralStreamFn::new(resolved_base_url()?, &api_key)),
        #[cfg(feature = "bedrock")]
        "bedrock" => {
            let region_env_var = preset
                .region_env_var
                .clone()
                .unwrap_or_else(|| "AWS_REGION".to_string());
            let region = std::env::var(&region_env_var).map_err(|_| {
                RemoteModelConnectionError::MissingRegion {
                    preset: preset.display_name.clone(),
                    env_var: region_env_var,
                }
            })?;
            let access_key_id = std::env::var("AWS_ACCESS_KEY_ID").map_err(|_| {
                RemoteModelConnectionError::MissingAwsCredentials {
                    preset: preset.display_name.clone(),
                }
            })?;
            let secret_access_key = std::env::var("AWS_SECRET_ACCESS_KEY").map_err(|_| {
                RemoteModelConnectionError::MissingAwsCredentials {
                    preset: preset.display_name.clone(),
                }
            })?;
            let session_token = std::env::var("AWS_SESSION_TOKEN").ok();
            Arc::new(BedrockStreamFn::new(
                region,
                access_key_id,
                secret_access_key,
                session_token,
            ))
        }
        _ => {
            return Err(RemoteModelConnectionError::UnsupportedProvider {
                provider_key: provider_key.to_string(),
            });
        }
    };
    Ok(ModelConnection::new(preset.model_spec(), stream_fn))
}

/// Looks up a remote preset by its `model_id` (e.g. `"claude-sonnet-4-6"`).
///
/// This is the primary entry point for finding a preset — callers write
/// `preset("claude-sonnet-4-6")` instead of constructing a `RemotePresetKey`
/// and looking up the catalog manually.
#[must_use]
pub fn preset(model_id: &str) -> Option<CatalogPreset> {
    remote_presets(None)
        .into_iter()
        .find(|p| p.model_id == model_id)
}

/// Builds a [`ModelConnection`] for a model identified by its `model_id`
/// (e.g. `"claude-sonnet-4-6"`, `"gpt-5.4"`).
///
/// This is the simplest way to get a connection — it resolves the preset from
/// the catalog by `model_id`, reads credentials from the environment, and
/// constructs the appropriate provider-specific `StreamFn`.
///
/// # Errors
///
/// Returns [`RemoteModelConnectionError`] if the model is not found, is not a
/// remote preset, or required credentials are missing from the environment.
pub fn build_remote_connection_for_model(
    model_id: &str,
) -> Result<ModelConnection, RemoteModelConnectionError> {
    let catalog_preset =
        preset(model_id).ok_or_else(|| RemoteModelConnectionError::UnknownModelId {
            model_id: model_id.to_string(),
        })?;
    build_connection_from_preset(
        &catalog_preset,
        catalog_preset
            .credential_env_var
            .as_deref()
            .and_then(|env_var| std::env::var(env_var).ok()),
        catalog_preset
            .base_url_env_var
            .as_deref()
            .and_then(|env_var| std::env::var(env_var).ok())
            .as_deref(),
    )
}

fn required_catalog_preset(
    key: RemotePresetKey,
) -> Result<CatalogPreset, RemoteModelConnectionError> {
    model_catalog()
        .preset(key.provider_key, key.preset_id)
        .ok_or(RemoteModelConnectionError::UnknownPreset {
            provider_key: key.provider_key,
            preset_id: key.preset_id,
        })
}

#[cfg(test)]
mod tests {
    use super::*;

    // ── all_remote_presets (unfiltered) ──────────────────────────────────

    #[test]
    fn all_remote_presets_are_loaded_from_catalog() {
        let all = all_remote_presets(None);
        assert!(!all.is_empty(), "catalog should have remote presets");
    }

    #[test]
    fn every_remote_provider_has_at_least_one_unfiltered_preset() {
        let catalog = model_catalog();
        for provider in &catalog.providers {
            if provider.kind == ProviderKind::Remote {
                let presets = all_remote_presets(Some(&provider.key));
                assert!(
                    !presets.is_empty(),
                    "remote provider '{}' should have presets in the catalog",
                    provider.key
                );
            }
        }
    }

    #[test]
    fn all_catalog_remote_presets_resolvable_by_provider_and_preset_id() {
        let catalog = model_catalog();
        for p in all_remote_presets(None) {
            let found = catalog
                .preset(&p.provider_key, &p.preset_id)
                .unwrap_or_else(|| {
                    panic!(
                        "catalog.preset('{}', '{}') must resolve for model_id '{}'",
                        p.provider_key, p.preset_id, p.model_id
                    )
                });
            assert_eq!(found.model_id, p.model_id);
        }
    }

    // ── is_provider_compiled ────────────────────────────────────────────

    #[test]
    fn is_provider_compiled_returns_false_for_unknown_provider() {
        assert!(!is_provider_compiled("nonexistent"));
        assert!(!is_provider_compiled("local"));
        assert!(!is_provider_compiled(""));
    }

    #[test]
    fn is_provider_compiled_matches_feature_gates() {
        // Each assertion matches the compile-time cfg for the corresponding feature.
        assert_eq!(
            is_provider_compiled("anthropic"),
            cfg!(feature = "anthropic")
        );
        assert_eq!(is_provider_compiled("openai"), cfg!(feature = "openai"));
        assert_eq!(is_provider_compiled("google"), cfg!(feature = "gemini"));
        assert_eq!(is_provider_compiled("azure"), cfg!(feature = "azure"));
        assert_eq!(is_provider_compiled("xai"), cfg!(feature = "xai"));
        assert_eq!(is_provider_compiled("mistral"), cfg!(feature = "mistral"));
        assert_eq!(is_provider_compiled("bedrock"), cfg!(feature = "bedrock"));
    }

    // ── remote_presets (filtered) ───────────────────────────────────────

    #[test]
    fn remote_presets_only_contains_compiled_providers() {
        for p in remote_presets(None) {
            assert!(
                is_provider_compiled(&p.provider_key),
                "remote_presets() returned preset '{}' for provider '{}' which is not compiled",
                p.preset_id,
                p.provider_key
            );
        }
    }

    #[test]
    fn remote_presets_subset_of_all_remote_presets() {
        let filtered = remote_presets(None);
        let all = all_remote_presets(None);
        assert!(
            filtered.len() <= all.len(),
            "filtered ({}) must be <= all ({})",
            filtered.len(),
            all.len()
        );
        // Every filtered preset must also appear in the unfiltered list.
        for p in &filtered {
            assert!(
                all.iter()
                    .any(|a| a.model_id == p.model_id && a.provider_key == p.provider_key),
                "filtered preset '{}.{}' not found in all_remote_presets",
                p.provider_key,
                p.preset_id
            );
        }
    }

    #[cfg(not(any(
        feature = "anthropic",
        feature = "openai",
        feature = "gemini",
        feature = "azure",
        feature = "xai",
        feature = "mistral",
        feature = "bedrock",
    )))]
    #[test]
    fn remote_presets_empty_when_no_adapters_compiled() {
        let presets = remote_presets(None);
        assert!(
            presets.is_empty(),
            "remote_presets() should be empty with no adapter features, got {} presets",
            presets.len()
        );
    }

    #[cfg(all(feature = "xai", not(feature = "openai")))]
    #[test]
    fn xai_feature_does_not_mark_openai_as_compiled() {
        assert!(is_provider_compiled("xai"));
        assert!(!is_provider_compiled("openai"));
        assert!(
            remote_presets(None)
                .into_iter()
                .all(|preset| preset.provider_key != "openai"),
            "xai-only builds must not expose OpenAI presets as compiled",
        );
    }

    // ── preset() (filtered) ────────────────────────────────────────────

    #[test]
    fn preset_only_finds_compiled_providers() {
        // Take every model_id from the full catalog and verify that preset()
        // only returns it when the provider is compiled.
        for p in all_remote_presets(None) {
            let result = preset(&p.model_id);
            if is_provider_compiled(&p.provider_key) {
                // May still be None if an earlier provider claimed this model_id.
                // That's fine — we just verify it doesn't return an uncompiled one.
                if let Some(found) = &result {
                    assert!(
                        is_provider_compiled(&found.provider_key),
                        "preset('{}') returned uncompiled provider '{}'",
                        p.model_id,
                        found.provider_key
                    );
                }
            }
        }
    }

    #[test]
    fn preset_returns_none_for_nonexistent_model() {
        assert!(preset("nonexistent-model-xyz").is_none());
    }

    // ── preset key resolution ──────────────────────────────────────────

    #[test]
    fn preset_key_resolves_via_catalog() {
        let key = RemotePresetKey::new("anthropic", "sonnet_46");
        let catalog_preset = required_catalog_preset(key).unwrap();
        assert_eq!(catalog_preset.model_id, "claude-sonnet-4-6");
    }

    // ── feature-gated connection tests ──────────────────────────────────

    #[cfg(feature = "anthropic")]
    #[test]
    fn preset_finds_anthropic_when_compiled() {
        let sonnet = preset("claude-sonnet-4-6").expect("sonnet preset should exist");
        assert_eq!(sonnet.provider_key, "anthropic");
        assert_eq!(sonnet.preset_id, "sonnet_46");
    }

    #[cfg(feature = "openai")]
    #[test]
    fn preset_finds_openai_when_compiled() {
        let gpt = preset("gpt-5.4").expect("gpt-5.4 preset should exist");
        assert_eq!(gpt.provider_key, "openai");
    }

    #[cfg(feature = "anthropic")]
    #[test]
    fn remote_connection_uses_catalog_model_spec() {
        let key = RemotePresetKey::new("anthropic", "sonnet_46");
        let preset = required_catalog_preset(key).unwrap();
        let connection =
            build_connection_from_preset(&preset, Some("test-key".to_string()), None).unwrap();
        assert_eq!(connection.model_spec(), &preset.model_spec());
    }

    #[cfg(feature = "openai")]
    #[test]
    fn remote_preset_requires_key() {
        let preset = preset("gpt-5.4").unwrap();
        let err = match build_connection_from_preset(&preset, None, None) {
            Ok(_) => panic!("expected missing credential error"),
            Err(err) => err,
        };
        assert_eq!(
            err,
            RemoteModelConnectionError::MissingCredential {
                preset: "OpenAI GPT-5.4".to_string(),
                env_var: "OPENAI_API_KEY".to_string(),
            }
        );
    }

    #[cfg(feature = "anthropic")]
    #[test]
    fn explicit_credential_builds_remote_connection_without_env_lookup() {
        let key = RemotePresetKey::new("anthropic", "sonnet_46");
        let connection =
            build_remote_connection_with_credential(key, Some("test-key".to_string()), None)
                .unwrap();
        assert_eq!(connection.model_spec().provider, "anthropic");
        assert_eq!(connection.model_spec().model_id, "claude-sonnet-4-6");
    }

    #[cfg(feature = "anthropic")]
    #[test]
    fn explicit_credential_reports_missing_key() {
        let key = RemotePresetKey::new("anthropic", "sonnet_46");
        let err = match build_remote_connection_with_credential(key, None, None) {
            Ok(_) => panic!("expected missing credential error"),
            Err(err) => err,
        };
        assert_eq!(
            err,
            RemoteModelConnectionError::MissingCredential {
                preset: "Anthropic Sonnet 4.6".to_string(),
                env_var: "ANTHROPIC_API_KEY".to_string(),
            }
        );
    }

    #[cfg(feature = "bedrock")]
    #[test]
    fn bedrock_explicit_credential_path_does_not_require_api_key() {
        let key = RemotePresetKey::new("bedrock", "anthropic_claude_sonnet_45");
        let err = match build_remote_connection_with_credential(key, None, None) {
            Ok(_) => panic!("expected missing region or AWS credentials"),
            Err(err) => err,
        };
        assert!(
            matches!(
                err,
                RemoteModelConnectionError::MissingRegion { .. }
                    | RemoteModelConnectionError::MissingAwsCredentials { .. }
            ),
            "bedrock should skip API-key validation, got {err:?}",
        );
    }

    // Explicit-but-empty credential must be rejected the same way `None` is.
    // `Some("")` and `Some("   ")` can sneak past a naive `is_some()` check,
    // so pin the contract: trimmed-empty explicit keys error as MissingCredential.
    #[cfg(feature = "anthropic")]
    #[test]
    fn build_with_credential_rejects_explicit_empty_string() {
        let key = RemotePresetKey::new("anthropic", "sonnet_46");
        for candidate in [String::new(), "   ".to_string(), "\t\n".to_string()] {
            let err = match build_remote_connection_with_credential(key, Some(candidate), None) {
                Ok(_) => panic!("empty/whitespace explicit credential must error"),
                Err(err) => err,
            };
            assert!(
                matches!(err, RemoteModelConnectionError::MissingCredential { .. }),
                "expected MissingCredential, got {err:?}"
            );
        }
    }

    // Unknown preset must short-circuit with UnknownPreset before any credential
    // or env-var work happens — protects callers from misleading MissingCredential
    // errors when the real problem is a bad preset key.
    #[test]
    fn build_with_credential_rejects_unknown_preset() {
        let key = RemotePresetKey::new("anthropic", "nonexistent_preset_xyz");
        let err =
            match build_remote_connection_with_credential(key, Some("irrelevant".into()), None) {
                Ok(_) => panic!("unknown preset must error"),
                Err(err) => err,
            };
        assert_eq!(
            err,
            RemoteModelConnectionError::UnknownPreset {
                provider_key: "anthropic",
                preset_id: "nonexistent_preset_xyz",
            }
        );
    }

    // Bedrock uses SigV4, not a bearer token — `Some("")` must still route
    // through the bedrock branch (which reads AWS env) and never return
    // MissingCredential. Complements the `None` test above.
    #[cfg(feature = "bedrock")]
    #[test]
    fn bedrock_ignores_explicit_empty_api_key() {
        let key = RemotePresetKey::new("bedrock", "anthropic_claude_sonnet_45");
        if let Err(err) = build_remote_connection_with_credential(key, Some(String::new()), None) {
            assert!(
                !matches!(err, RemoteModelConnectionError::MissingCredential { .. }),
                "bedrock must not surface MissingCredential when api_key is Some(\"\"); got {err:?}"
            );
        }
    }

    #[test]
    fn build_remote_connection_for_model_rejects_unknown() {
        let result = build_remote_connection_for_model("nonexistent-xyz");
        assert!(result.is_err());
        let err = result.err().unwrap();
        assert_eq!(
            err,
            RemoteModelConnectionError::UnknownModelId {
                model_id: "nonexistent-xyz".to_string(),
            }
        );
    }

    #[test]
    fn preset_by_model_id_returns_a_match_for_every_filtered_model_id() {
        let mut seen = std::collections::HashSet::new();
        for p in remote_presets(None) {
            if seen.insert(p.model_id.clone()) {
                assert!(
                    preset(&p.model_id).is_some(),
                    "preset('{}') must return Some for a compiled catalog model_id",
                    p.model_id
                );
            }
        }
    }

    #[cfg(feature = "anthropic")]
    #[test]
    fn preset_finds_representative_anthropic_model() {
        let p = preset("claude-sonnet-4-6").expect("anthropic preset should exist");
        assert_eq!(p.provider_key, "anthropic");
    }

    #[cfg(feature = "openai")]
    #[test]
    fn preset_finds_representative_openai_model() {
        let p = preset("gpt-5.4").expect("openai preset should exist");
        assert_eq!(p.provider_key, "openai");
    }

    #[cfg(feature = "gemini")]
    #[test]
    fn preset_finds_representative_gemini_model() {
        let p = preset("gemini-3-flash-preview").expect("gemini preset should exist");
        assert_eq!(p.provider_key, "google");
    }

    #[cfg(feature = "mistral")]
    #[test]
    fn preset_finds_representative_mistral_model() {
        let p = preset("mistral-large-latest").expect("mistral preset should exist");
        assert_eq!(p.provider_key, "mistral");
    }
}