swamp-code-gen 0.2.27

generates swamp-vm opcodes
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
/*
 * Copyright (c) Peter Bjorklund. All rights reserved. https://github.com/swamp/swamp
 * Licensed under the MIT License. See LICENSE in the project root for license information.
 */
use crate::FlagStateKind;
use crate::code_bld::CodeBuilder;
use crate::ctx::Context;
use crate::transformer::{Collection, Transformer, TransformerResult};
use source_map_node::Node;
use swamp_semantic::{Expression, VariableRef};
use swamp_vm_isa::{InstructionPosition, MemoryOffset};
use swamp_vm_types::types::{
    BasicTypeKind, BasicTypeRef, Place, TypedRegister, VmType, pointer_type, u8_type, u32_type,
};
use swamp_vm_types::{MemoryLocation, PatchPosition};
use tracing::error;

impl CodeBuilder<'_> {
    /// Generates code to iterate over a collection using a transformer (e.g., map, filter, `filter_map`)
    /// and a lambda expression. Handles creation of result vectors, iterator setup, lambda invocation,
    /// early exit logic, and result collection.
    ///
    /// Steps:
    /// 1. (Optional) Initialize a target vector for the result, if the transformer produces one.
    /// 2. Initialize the iterator for the collection.
    /// 3. Generate code to fetch the next element from the iterator.
    /// 4. Spill lambda variables to protect them from being clobbered by function calls
    /// 5. Inline the lambda code for the current element.
    /// 6. Restore lambda variables from stack after lambda execution
    /// 7. If the transformer supports early exit (e.g., filter, find), set the P flag based on the lambda result.
    /// 8. Conditionally skip result insertion if early exit is triggered.
    /// 9. (Optional) If applicable, insert the (possibly unwrapped) result into the target vector.
    /// 10. Loop back to fetch the next element.
    /// 11. Finalize iteration, handling any post-processing (e.g., normalizing boolean results).
    ///
    /// # Parameters
    /// - `node`: The AST node for error reporting and code location.
    /// - `collection_type`: The type of collection being iterated.
    /// - `transformer`: The transformer operation (map, filter, find, fold, etc.).
    /// - `collection_self_region`: Memory region of the collection.
    /// - `lambda_expression`: The lambda expression to apply.
    /// - `ctx`: Code generation context. Contains the result target.
    ///
    /// # Returns
    /// - `Ok(())` on success, or an error if code generation fails.
    ///
    /// # Errors
    /// // TODO:
    /// # Panics
    /// - If the lambda expression or its kind is not as expected (internal error).
    #[allow(clippy::too_many_lines)]
    #[allow(clippy::too_many_arguments)]
    pub fn emit_iterate_over_collection_with_lambda(
        &mut self,
        target_destination: &Place,
        node: &Node,
        source_collection_type: Collection,
        transformer: Transformer,
        source_collection_reg: &TypedRegister,
        lambda_tuple: (Vec<VariableRef>, &Expression),
        ctx: &Context,
    ) {
        let (lambda_variables, lambda_expr) = lambda_tuple;
        let maybe_primary_element_gen_type = source_collection_reg.ty.basic_type.element();

        let target_variables: Vec<_> = lambda_variables
            .iter()
            .map(|x| {
                self.variable_registers
                    .get(&x.unique_id_within_function)
                    .unwrap()
                    .clone()
            })
            .collect();

        // Primary is the right most variable
        let primary_variable = &target_variables[target_variables.len() - 1];

        let hwm = self.temp_registers.save_mark();

        let temp_index_reg_for_mut_source = match transformer.return_type() {
            TransformerResult::VecMutateSourceCollection => {
                let temp_reg = self.temp_registers.allocate(
                    VmType::new_contained_in_register(u32_type()),
                    "mutate index",
                );
                self.builder.add_mov_32_immediate_value(
                    temp_reg.register(),
                    0,
                    node,
                    "initialize index register to zero",
                );
                Some(temp_reg.register().clone())
            }
            _ => None,
        };

        // 1. Initialize the target collection if needed and compute collection pointer
        let maybe_target_collection_pointer = match transformer.return_type() {
            TransformerResult::VecFromSourceCollection | TransformerResult::VecWithLambdaResult => {
                // For transformers that create collections (filter, map, filterMap),
                // we need to initialize the target vector before adding elements
                let target_memory_location = target_destination.memory_location_or_pointer_reg();

                self.emit_initialize_memory_for_any_type(
                    &target_memory_location,
                    node,
                    "initialize target collection for transformer",
                );

                // For VecFromSourceCollection, compute the collection pointer now to avoid
                // it being clobbered during lambda execution
                if matches!(
                    transformer.return_type(),
                    TransformerResult::VecFromSourceCollection
                ) {
                    let computed_pointer = self.emit_compute_effective_address_to_register(
                        target_destination,
                        node,
                        "get pointer to collection (before lambda execution)",
                    );

                    Some(computed_pointer)
                } else {
                    None
                }
            }
            _ => {
                // Other transformers don't need target initialization
                None
            }
        };

        // 2. Initialize the iterator and generate code to fetch the next element.
        let (continue_iteration_label, iteration_complete_patch_position) = self
            .emit_iter_init_and_next(
                node,
                source_collection_type,
                maybe_primary_element_gen_type,
                source_collection_reg,
                &target_variables,
            );

        // 3. Inline the lambda code for the current element(s).
        let lambda_result = self.emit_scalar_rvalue(lambda_expr, ctx);

        // 4. If the transformer supports early exit, set the P flag based on the lambda result.
        let transformer_t_flag_state = self.check_if_transformer_sets_t_flag(transformer);

        // 5. Conditionally skip result insertion if early exit is triggered.
        let maybe_skip_early = if self.check_if_transformer_can_skip_early(transformer)
            && matches!(
                transformer_t_flag_state,
                FlagStateKind::TFlagIsTrueWhenSet | FlagStateKind::TFlagIsTrueWhenClear
            ) {
            let skip_early = match transformer.return_type() {
                TransformerResult::WrappedValueFromSourceCollection => {
                    let skip_over_some_section = self.builder.add_jmp_if_not_true_placeholder(
                        &lambda_result,
                        node,
                        "skip over setting Some section",
                    );

                    let destination_type = target_destination.ty();
                    let BasicTypeKind::Optional(tagged_union) = &destination_type.kind else {
                        panic!("expected optional {destination_type:?}");
                    };

                    let tag_some_value_reg = self.temp_registers.allocate(
                        VmType::new_unknown_placement(u8_type()),
                        "iterate over collection target",
                    );

                    self.builder.add_mov8_immediate(
                        tag_some_value_reg.register(),
                        1,
                        node,
                        "mark tag as Some",
                    );

                    let result_location = target_destination.memory_location_or_pointer_reg();

                    self.builder.add_st8_using_ptr_with_offset(
                        &result_location.unsafe_add_offset(tagged_union.tag_offset),
                        tag_some_value_reg.register(),
                        node,
                        "store Tag value of (1) into memory",
                    );

                    // TODO: let payload_memory_location = result_location.unsafe_add_offset(tagged_union.payload_offset);
                    let payload_memory_location =
                        result_location.unsafe_add_offset(MemoryOffset(4));
                    let payload_destination = Place::Memory(payload_memory_location);

                    let source_location = Place::Register(primary_variable.clone());

                    self.emit_store_value_to_memory_place(
                        &payload_destination,
                        &source_location,
                        node,
                        "copy result in place",
                    );

                    // The P flag is set so we can act on it
                    let skip_early = self.builder.add_jump_placeholder(node, "skip early");

                    self.builder.patch_jump_here(skip_over_some_section);

                    skip_early
                }
                _ => {
                    // The P flag is set so we can act on it
                    self.builder.add_jmp_if_not_equal_polarity_placeholder(
                        &lambda_result,
                        &transformer_t_flag_state.polarity(),
                        node,
                        "skip early",
                    )
                }
            };

            Some(skip_early)
        } else {
            // P flag is not set, we have to iterate through the whole collection
            None
        };

        // 6. If applicable, insert the (possibly unwrapped) result into the target vector.

        match transformer.return_type() {
            TransformerResult::Unit => {

                // Only alternative is that it is a bool return, so no need to take any action here
            }
            TransformerResult::Bool => {
                // Only alternative is that it is a bool return, so no need to take any action here
            }
            TransformerResult::WrappedValueFromSourceCollection => {
                // Handled elsewhere
            }
            TransformerResult::VecWithLambdaResult => {
                self.transformer_add_to_collection(
                    &lambda_result,
                    transformer.needs_tag_removed(),
                    source_collection_type,
                    target_destination.register().unwrap(),
                    node,
                );
            }
            TransformerResult::VecFromSourceCollection => {
                let skip_if_false_patch_position = self.builder.add_jmp_if_not_true_placeholder(
                    &lambda_result,
                    node,
                    "skip the result if it is false",
                );

                let absolute_pointer = maybe_target_collection_pointer
                    .as_ref()
                    .expect("collection pointer should have been computed before lambda execution");

                self.add_to_collection(
                    node,
                    source_collection_type,
                    absolute_pointer,
                    primary_variable,
                );

                self.builder.patch_jump_here(skip_if_false_patch_position);
            }

            TransformerResult::VecMutateSourceCollection => {
                let skip_if_false_patch_position = self.builder.add_jmp_if_not_true_placeholder(
                    &lambda_result,
                    node,
                    "skip the result if it is false",
                );

                // TODO: have a subscript index and overwrite
                let index_reg = temp_index_reg_for_mut_source.unwrap();
                let pointer_to_entry_reg = self.temp_registers.allocate(
                    VmType::new_contained_in_register(pointer_type()),
                    "holds pointer to vec entry",
                );
                self.builder.add_vec_subscript(
                    pointer_to_entry_reg.register(),
                    source_collection_reg,
                    &index_reg,
                    node,
                    "get pointer to element",
                );

                self.builder.patch_jump_here(skip_if_false_patch_position);
            }
        }

        // 7. Loop back to fetch the next element.
        self.builder.add_jmp(
            continue_iteration_label,
            &lambda_expr.debug_last_expression().node,
            "jump to iter_next",
        );

        self.builder
            .patch_jump_here(iteration_complete_patch_position);

        if let Some(found_skip_early) = maybe_skip_early {
            self.builder.patch_jump_here(found_skip_early);
        }

        self.temp_registers.restore_to_mark(hwm);
    }

    #[allow(clippy::unnecessary_wraps)]
    #[allow(clippy::too_many_lines)]
    fn emit_iter_init_and_next(
        &mut self,
        node: &Node,
        collection_type: Collection,
        maybe_element_type: Option<BasicTypeRef>,
        collection_self_addr: &TypedRegister,
        target_variables: &[TypedRegister],
    ) -> (InstructionPosition, PatchPosition) {
        let iterator_gen_type = collection_type.iterator_gen_type();

        let target_iterator_header_reg = self.allocate_frame_space_and_return_absolute_pointer_reg(
            &iterator_gen_type,
            false,
            node,
            "allocate iterator header space",
        );

        let primary_register = if target_variables.len() == 2 {
            &target_variables[1]
        } else {
            &target_variables[0]
        };

        let iter_next_position = InstructionPosition(self.builder.position().0 + 1);
        let placeholder = match collection_type {
            Collection::Range => {
                self.builder.add_range_iter_init(
                    &target_iterator_header_reg,
                    collection_self_addr,
                    node,
                    "range init",
                );

                assert_eq!(target_variables.len(), 1);
                self.builder.add_range_iter_next_placeholder(
                    &target_iterator_header_reg,
                    &target_variables[0],
                    node,
                    "range iter next single",
                )
            }

            Collection::Map => {
                // For maps, we need to handle both key and value potentially being scalars
                // Map iteration returns pointers to both key and value, so we need to load scalar values
                // TODO: Clean this up a bit to be more easy to read
                // TODO: Also, scalar values that are mutated should be stored back to the value register
                // Keys are by design not allowed to be mutated in iteration.
                let (temp_registers, target_variables_to_use) = if target_variables.len() == 2 {
                    // Map iteration with key-value pairs
                    let key_register = &target_variables[0];
                    let value_register = &target_variables[1];

                    let (key_is_scalar, value_is_scalar) =
                        match &collection_self_addr.ty.basic_type.kind {
                            BasicTypeKind::MapStorage {
                                key_type,
                                value_type,
                                ..
                            } => (key_type.is_scalar(), value_type.is_scalar()),
                            BasicTypeKind::DynamicLengthMapView(key_item, value_item) => {
                                (key_item.ty.is_scalar(), value_item.ty.is_scalar())
                            }
                            _ => (false, false),
                        };

                    let mut temp_regs = Vec::new();
                    let mut target_vars = Vec::new();

                    // Handle key
                    if key_is_scalar {
                        let temp_key_addr = self
                            .temp_registers
                            .allocate(key_register.ty.clone(), "temp address for key");
                        temp_regs.push((temp_key_addr.register().clone(), key_register.clone()));
                        target_vars.push(temp_key_addr.register);
                    } else {
                        target_vars.push(key_register.clone());
                    }

                    // Handle value
                    if value_is_scalar {
                        let temp_value_addr = self
                            .temp_registers
                            .allocate(value_register.ty.clone(), "temp address for value");
                        temp_regs
                            .push((temp_value_addr.register().clone(), value_register.clone()));
                        target_vars.push(temp_value_addr.register);
                    } else {
                        target_vars.push(value_register.clone());
                    }

                    (Some(temp_regs), target_vars)
                } else {
                    // Single value iteration (values only)
                    let value_register = &target_variables[0];
                    let value_is_scalar = match &collection_self_addr.ty.basic_type.kind {
                        BasicTypeKind::MapStorage { value_type, .. } => value_type.is_scalar(),
                        BasicTypeKind::DynamicLengthMapView(_, value_item) => {
                            value_item.ty.is_scalar()
                        }
                        _ => false,
                    };

                    if value_is_scalar {
                        let temp_value_addr = self
                            .temp_registers
                            .allocate(value_register.ty.clone(), "temp address for value");
                        (
                            Some(vec![(
                                temp_value_addr.register().clone(),
                                value_register.clone(),
                            )]),
                            vec![temp_value_addr.register.clone()],
                        )
                    } else {
                        (None, target_variables.to_vec())
                    }
                };

                let patch_position = self.emit_iter_init_and_next_to_memory(
                    &target_iterator_header_reg,
                    node,
                    collection_type,
                    maybe_element_type,
                    collection_self_addr,
                    &target_variables_to_use,
                );

                // Load scalar values from the addresses returned by the map iterator
                if let Some(temp_regs) = temp_registers {
                    for (temp_addr_reg, target_scalar_reg) in temp_regs {
                        let source_memory_location =
                            MemoryLocation::new_copy_over_whole_type_with_zero_offset(
                                temp_addr_reg,
                            );
                        self.emit_load_value_from_memory_source(
                            &target_scalar_reg,
                            &source_memory_location,
                            node,
                            "load scalar value from map iterator address",
                        );
                    }
                }

                patch_position
            }
            _ => {
                let (temp_registers, target_variables_to_use) =
                    if primary_register.ty.basic_type.is_scalar() {
                        // For primitives, create temp register to hold the address, since they do not want
                        // the address
                        let temp_addr = self.temp_registers.allocate(
                            VmType::new_contained_in_register(pointer_type()),
                            "temp address for value",
                        );

                        if target_variables.len() == 2 {
                            (
                                Some(temp_addr.register().clone()),
                                vec![target_variables[0].clone(), temp_addr.register.clone()],
                            )
                        } else {
                            (
                                Some(temp_addr.register().clone()),
                                vec![temp_addr.register.clone()],
                            )
                        }
                    } else {
                        (None, target_variables.to_vec())
                    };

                let patch_position = self.emit_iter_init_and_next_to_memory(
                    &target_iterator_header_reg,
                    node,
                    collection_type,
                    maybe_element_type,
                    collection_self_addr,
                    &target_variables_to_use,
                );

                if let Some(temp_regs) = temp_registers {
                    if collection_type == Collection::String {
                        self.builder.add_mov_reg(
                            primary_register,
                            &temp_regs,
                            node,
                            "copy from temporary to primary scalar register",
                        );
                        //self.emit_copy_register(&temp_regs, primary_register, node, "comment");
                    } else {
                        let source_memory_location =
                            MemoryLocation::new_copy_over_whole_type_with_zero_offset(temp_regs);
                        self.emit_load_value_from_memory_source(
                            primary_register,
                            &source_memory_location,
                            node,
                            "load primitive from element address",
                        );
                    }
                }

                patch_position
            }
        };

        (iter_next_position, placeholder)
    }

    fn emit_iter_init_and_next_to_memory(
        &mut self,
        target_iterator_header_reg: &TypedRegister,
        node: &Node,
        collection_type: Collection,
        maybe_element_type: Option<BasicTypeRef>,
        collection_self_addr: &TypedRegister,
        target_variables: &[TypedRegister],
    ) -> PatchPosition {
        let primary_register = if target_variables.len() == 2 {
            &target_variables[1]
        } else {
            &target_variables[0]
        };
        let is_pair = target_variables.len() == 2;
        match collection_type {
            // Low  prio
            Collection::String => {
                if maybe_element_type.is_none() {
                    error!(
                        ?collection_self_addr,
                        "can no start iterating with this strange vec collection"
                    );
                }

                self.builder.add_string_iter_init(
                    target_iterator_header_reg,
                    collection_self_addr,
                    maybe_element_type.unwrap().total_size,
                    node,
                    "vec iter init",
                );

                let is_pair = target_variables.len() == 2;

                if is_pair {
                    // For non-primitives, use target directly
                    self.builder.add_string_iter_next_pair_placeholder(
                        target_iterator_header_reg,
                        &target_variables[0],
                        &target_variables[1],
                        node,
                        "vec iter next pair",
                    )
                } else {
                    // For non-primitives, use target directly
                    self.builder.add_string_iter_next_placeholder(
                        target_iterator_header_reg,
                        primary_register,
                        node,
                        "vec iter next single",
                    )
                }
            }
            Collection::Vec => {
                if maybe_element_type.is_none() {
                    error!(
                        ?collection_self_addr,
                        "can no start iterating with this strange vec collection"
                    );
                }

                self.builder.add_vec_iter_init(
                    target_iterator_header_reg,
                    collection_self_addr,
                    node,
                    "vec iter init",
                );

                let is_pair = target_variables.len() == 2;

                if is_pair {
                    // For non-primitives, use target directly
                    self.builder.add_vec_iter_next_pair_placeholder(
                        target_iterator_header_reg,
                        &target_variables[0],
                        &target_variables[1],
                        node,
                        "vec iter next pair",
                    )
                } else {
                    // For non-primitives, use target directly
                    self.builder.add_vec_iter_next_placeholder(
                        target_iterator_header_reg,
                        primary_register,
                        node,
                        "vec iter next single",
                    )
                }
            }
            Collection::Sparse => {
                self.builder.add_sparse_iter_init(
                    target_iterator_header_reg,
                    collection_self_addr,
                    node,
                    "sparse init",
                );

                if is_pair {
                    self.builder.add_sparse_iter_next_pair_placeholder(
                        target_iterator_header_reg,
                        &target_variables[0],
                        &target_variables[1],
                        node,
                        "sparse next_pair",
                    )
                } else {
                    self.builder.add_sparse_iter_next_placeholder(
                        target_iterator_header_reg,
                        primary_register,
                        node,
                        "sparse next_single",
                    )
                }
            }

            Collection::Map => {
                self.builder.add_map_iter_init(
                    target_iterator_header_reg,
                    collection_self_addr,
                    node,
                    "map init",
                );

                if target_variables.len() == 2 {
                    self.builder.add_map_iter_next_pair_placeholder(
                        target_iterator_header_reg,
                        &target_variables[0],
                        &target_variables[1],
                        node,
                        "map next_pair",
                    )
                } else {
                    self.builder.add_map_iter_next_placeholder(
                        target_iterator_header_reg,
                        &target_variables[0],
                        node,
                        "map next_single",
                    )
                }
            }
            Collection::Grid => todo!(),
            _ => panic!("unknown collection"),
        }
    }

    const fn check_if_transformer_sets_t_flag(
        &mut self,
        transformer: Transformer,
    ) -> FlagStateKind {
        match transformer {
            Transformer::For => FlagStateKind::TFlagIsIndeterminate,
            Transformer::While => FlagStateKind::TFlagIsTrueWhenSet,
            Transformer::Filter => {
                // TODO: Bring this back //assert_eq!(in_value.size().0, 1); // bool
                FlagStateKind::TFlagIsTrueWhenSet
            }
            Transformer::FilterMut => {
                // TODO: Bring this back //assert_eq!(in_value.size().0, 1); // bool
                FlagStateKind::TFlagIsTrueWhenSet
            }
            Transformer::Find => {
                // TODO: Bring this back //assert_eq!(in_value.size().0, 1); // bool
                FlagStateKind::TFlagIsTrueWhenClear
            }
            Transformer::Map => FlagStateKind::TFlagIsIndeterminate,
            Transformer::Any => FlagStateKind::TFlagIsTrueWhenClear,
            Transformer::All => FlagStateKind::TFlagIsTrueWhenSet,
            Transformer::FilterMap => FlagStateKind::TFlagIsTrueWhenSet,
        }
    }

    fn add_to_collection(
        &mut self,
        node: &Node,
        collection: Collection,
        mut_collection: &TypedRegister,
        value: &TypedRegister,
    ) {
        match collection {
            Collection::Vec => {
                let target_element_addr_reg = self.temp_registers.allocate(
                    VmType::new_contained_in_register(u32_type()),
                    "address for the element entry",
                );

                self.builder.add_vec_push_addr(
                    target_element_addr_reg.register(),
                    mut_collection,
                    node,
                    "add_to_collection for transformer",
                );

                let vec_entry_destination =
                    Place::Memory(MemoryLocation::new_copy_over_whole_type_with_zero_offset(
                        target_element_addr_reg.register().clone(),
                    ));

                // Initialize the allocated space first (like variable definition)
                if value.ty.basic_type.is_aggregate() {
                    self.emit_initialize_memory_for_any_type(
                        vec_entry_destination.grab_memory_location(),
                        node,
                        "initialize vec.push allocated space for transformer",
                    );
                }

                let source_destination = if value.ty.is_scalar() {
                    Place::Register(value.clone())
                } else {
                    Place::Memory(MemoryLocation::new_copy_over_whole_type_with_zero_offset(
                        value.clone(),
                    ))
                };

                self.emit_store_value_to_memory_place(
                    &vec_entry_destination,
                    &source_destination,
                    node,
                    "store value in the new vec entry slot",
                );
            }
            Collection::Sparse => panic!("not supported by sparse"),
            Collection::Map => todo!(),
            Collection::Grid => todo!(),
            Collection::String => todo!(),
            Collection::Range => todo!(),
        }
    }

    fn transformer_add_to_collection(
        &mut self,
        in_value: &TypedRegister,
        should_unwrap_value: bool,
        collection_type: Collection,
        mut_collection: &TypedRegister,
        node: &Node,
    ) {
        let (register_to_be_inserted_in_collection, _maybe_temp) = if should_unwrap_value {
            let tagged_union = in_value.underlying().optional_info().unwrap().clone();
            let some_variant = tagged_union.get_variant_by_index(1);
            let payload_vm_type = VmType::new_unknown_placement(some_variant.ty.clone());
            let temp_reg = self
                .temp_registers
                .allocate(payload_vm_type, "transform add to collection");
            let (_tag_offset, _tag_size, _payload_offset, _) =
                in_value.underlying().unwrap_info().unwrap();

            /*
            in_value.unsafe_add_offset(payload_offset);

            self.emit_load_from_memory_internal(
                temp_reg.register(),
                in_value,
                payload_offset,
                &payload_vm_type,
                node,
                "transformer add to collection",
            );

             */
            (temp_reg.register.clone(), Some(temp_reg))
        } else {
            (in_value.clone(), None)
        };

        self.add_to_collection(
            node,
            collection_type,
            mut_collection,
            &register_to_be_inserted_in_collection,
        );
    }

    const fn check_if_transformer_can_skip_early(&self, transformer: Transformer) -> bool {
        match transformer {
            Transformer::For => false,
            Transformer::Filter => false,
            Transformer::FilterMut => false,
            Transformer::Find => true,
            Transformer::While => true,
            Transformer::Map => false,
            Transformer::Any => true,
            Transformer::All => true,
            Transformer::FilterMap => false,
        }
    }
}