1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
use crate::config::ConfigOption;
use crate::linter::{Rule, RuleResult};
use sv_parser::{ForInitialization, NodeEvent, RefNode, SyntaxTree};
#[derive(Default)]
pub struct LoopVariableDeclaration;
impl Rule for LoopVariableDeclaration {
fn check(
&mut self,
_syntax_tree: &SyntaxTree,
event: &NodeEvent,
_option: &ConfigOption,
) -> RuleResult {
let node = match event {
NodeEvent::Enter(x) => x,
NodeEvent::Leave(_) => {
return RuleResult::Pass;
}
};
match node {
RefNode::ForInitialization(ForInitialization::ListOfVariableAssignments(_)) => {
RuleResult::Fail
}
_ => RuleResult::Pass,
}
}
fn name(&self) -> String {
String::from("loop_variable_declaration")
}
fn hint(&self, _option: &ConfigOption) -> String {
String::from("Declare the loop variable within the loop, i.e. `for (int i`.")
}
fn reason(&self) -> String {
String::from("Minimizing the variable's scope avoids common coding errors.")
}
}