superposition_core 0.115.4

//! Tests for TOML format implementation

use serde_json::{Map, Value};
use std::collections::BTreeMap;
use superposition_types::{
    Config, DefaultConfigInfo, DefaultConfigsWithSchema, DetailedConfig,
};

use crate::format::FormatError;
use crate::{ConfigFormat, TomlFormat};

/// Helper function to convert Config to DetailedConfig by inferring schema from value.
fn config_to_detailed(config: &Config) -> DetailedConfig {
    let default_configs: BTreeMap<String, DefaultConfigInfo> = config
        .default_configs
        .iter()
        .map(|(key, value)| {
            let schema = match value {
                Value::String(_) => serde_json::json!({ "type": "string" }),
                Value::Number(n) => {
                    if n.is_i64() {
                        serde_json::json!({ "type": "integer" })
                    } else {
                        serde_json::json!({ "type": "number" })
                    }
                }
                Value::Bool(_) => serde_json::json!({ "type": "boolean" }),
                Value::Array(_) => serde_json::json!({ "type": "array" }),
                Value::Object(_) => serde_json::json!({ "type": "object" }),
                Value::Null => serde_json::json!({ "type": "null" }),
            };
            (
                key.clone(),
                DefaultConfigInfo {
                    value: value.clone(),
                    schema,
                    description: key.clone(),
                },
            )
        })
        .collect();

    DetailedConfig {
        contexts: config.contexts.clone(),
        overrides: config.overrides.clone(),
        default_configs: DefaultConfigsWithSchema::from(default_configs),
        dimensions: config.dimensions.clone(),
    }
}

#[test]
fn test_toml_round_trip_simple() {
    let original_toml = r#"
[default-configs]
"time.out" = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { "type" = "string" } }

[[overrides]]
_context_ = { os = "linux" }
"time.out" = 60
"#;

    let config = TomlFormat::parse_config(original_toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();
    let reparsed = TomlFormat::parse_config(&serialized).unwrap();

    assert_eq!(config.default_configs, reparsed.default_configs);
    assert_eq!(config.dimensions.len(), reparsed.dimensions.len());
    assert_eq!(config.contexts.len(), reparsed.contexts.len());
}

#[test]
fn test_toml_description_exported_and_round_trips() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" }, description = "request timeout" }

[dimensions]
os = { position = 1, schema = { type = "string" }, description = "operating system" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let detailed = TomlFormat::parse_into_detailed(toml).unwrap();
    assert_eq!(
        detailed.dimensions.get("os").unwrap().description,
        "operating system"
    );
    assert_eq!(
        detailed.default_configs.get("timeout").unwrap().description,
        "request timeout"
    );

    let serialized = TomlFormat::serialize(detailed).unwrap();
    assert!(serialized.contains(r#"description = "operating system""#));
    assert!(serialized.contains(r#"description = "request timeout""#));

    // Description survives a full round-trip.
    let reparsed = TomlFormat::parse_into_detailed(&serialized).unwrap();
    assert_eq!(
        reparsed.dimensions.get("os").unwrap().description,
        "operating system"
    );
    assert_eq!(
        reparsed.default_configs.get("timeout").unwrap().description,
        "request timeout"
    );
}

#[test]
fn test_toml_description_falls_back_to_name_when_missing() {
    // Neither the dimension nor the default config declare a description.
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let detailed = TomlFormat::parse_into_detailed(toml).unwrap();
    // Missing description falls back to the key / dimension name.
    assert_eq!(detailed.dimensions.get("os").unwrap().description, "os");
    assert_eq!(
        detailed.default_configs.get("timeout").unwrap().description,
        "timeout"
    );

    // Export is mandatory: the fallback value is emitted in the file.
    let serialized = TomlFormat::serialize(detailed).unwrap();
    assert!(serialized.contains(r#"description = "os""#));
    assert!(serialized.contains(r#"description = "timeout""#));
}

#[test]
fn test_toml_serialize_sorts_keys() {
    // Keys are intentionally declared out of alphabetical order, including a
    // nested object value, to verify the serializer emits them sorted.
    let toml = r#"
[default-configs]
zebra = { value = 1, schema = { type = "integer" } }
alpha = { value = 2, schema = { type = "integer" } }
nested = { value = { zoo = 1, ant = 2 }, schema = { type = "object" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
zebra = 10
alpha = 20
nested = { zoo = 100, ant = 200 }
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();

    let overrides_section = serialized.split("[[overrides]]").nth(1).unwrap();
    let alpha = overrides_section.find("\nalpha = ").unwrap();
    let zebra = overrides_section.find("\nzebra = ").unwrap();
    assert!(
        alpha < zebra,
        "override keys not sorted:\n{overrides_section}"
    );

    // Nested object keys within an override value should also be sorted.
    let nested = overrides_section.find("nested = {").unwrap();
    let ant = overrides_section[nested..].find("ant").unwrap();
    let zoo = overrides_section[nested..].find("zoo").unwrap();
    assert!(
        ant < zoo,
        "nested object keys not sorted:\n{overrides_section}"
    );
}

#[test]
fn test_dimension_type_local_cohort() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 2, schema = { type = "string" } }
os_cohort = { position = 1, type = "LOCAL_COHORT:os", schema = { type = "string", enum = ["linux", "windows", "otherwise"], definitions = { linux = "rule_for_linux", windows = "rule_for_windows" } } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();

    assert!(serialized.contains(r#"type = "LOCAL_COHORT:os""#));
}

#[test]
fn test_undeclared_dimension() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { region = "us-east" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
}

#[test]
fn test_priority_calculation() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
region = { position = 2, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60

[[overrides]]
_context_ = { os = "linux", region = "us-east" }
timeout = 90
"#;

    let parsed = TomlFormat::parse_config(toml).unwrap();
    assert_eq!(parsed.contexts[0].priority, 0);
    assert_eq!(parsed.contexts[1].priority, 1);
}

#[test]
fn test_resolution_with_local_cohorts() {
    let toml = r#"
[default-configs]
config = { value = { host = "localhost", port = 8080 }, schema = { type = "object" } }
max_count = { value = 10, schema = { type = "number", minimum = 0, maximum = 100 } }

[dimensions]
os = { position = 2, schema = { type = "string", enum = ["linux", "windows", "macos"] } }
os_cohort = { position = 1, schema = { enum = ["unix", "otherwise"], type = "string", definitions = { unix = { in = [{ var = "os" }, ["linux", "macos"]] } } }, type = "LOCAL_COHORT:os" }

[[overrides]]
_context_ = { os = "linux" }
config = { host = "prod.example.com", port = 443 }

[[overrides]]
_context_ = { os_cohort = "unix" }
config = { host = "prod.unix.com", port = 8443 }
max_count = 95
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let mut dims = Map::new();
    dims.insert("os".to_string(), Value::String("linux".to_string()));

    let result = crate::eval_config(
        (*config.default_configs).clone(),
        &config.contexts,
        &config.overrides,
        &config.dimensions,
        &dims,
        crate::MergeStrategy::MERGE,
        None,
    )
    .unwrap();

    assert_eq!(
        result.get("max_count"),
        Some(&Value::Number(serde_json::Number::from(95)))
    );
}

#[test]
fn test_toml_round_trip_empty_config() {
    let toml_str = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let config = TomlFormat::parse_config(toml_str).unwrap();
    assert_eq!(config.default_configs.len(), 1);
    assert_eq!(config.contexts.len(), 1);
    assert_eq!(config.overrides.len(), 1);
}

#[test]
fn test_missing_overrides_section() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_ok());
    let parsed = result.unwrap();
    assert_eq!(parsed.default_configs.len(), 1);
    assert_eq!(parsed.dimensions.len(), 1);
    assert!(parsed.contexts.is_empty());
    assert!(parsed.overrides.is_empty());
}

#[test]
fn test_dimension_type_regular() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" }, type = "REGULAR" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();
    let reparsed = TomlFormat::parse_config(&serialized).unwrap();

    assert!(serialized.contains(r#"type = "REGULAR""#));
    assert_eq!(config.dimensions.len(), reparsed.dimensions.len());
}

#[test]
fn test_dimension_type_local_cohort_invalid_reference() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os_cohort = { position = 1, schema = { type = "string" }, type = "LOCAL_COHORT:nonexistent" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("does not exist") || err.contains("not found"),
        "Expected error about nonexistent dimension, got: {err}"
    );
}

#[test]
fn test_dimension_type_local_cohort_empty_name() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
os_cohort = { position = 2, schema = { type = "string" }, type = "LOCAL_COHORT:" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("does not exist") || err.contains("not found"),
        "Expected error about empty cohort name, got: {err}"
    );
}

#[test]
fn test_dimension_type_remote_cohort() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 2, schema = { type = "string" } }
os_cohort = { position = 1, type = "REMOTE_COHORT:os", schema = { type = "string", enum = ["linux", "windows", "macos"] } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();
    let reparsed = TomlFormat::parse_config(&serialized).unwrap();

    assert!(serialized.contains(r#"type = "REMOTE_COHORT:os""#));
    assert_eq!(config.dimensions.len(), reparsed.dimensions.len());
}

#[test]
fn test_dimension_type_remote_cohort_invalid_reference() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os_cohort = { position = 1, schema = { type = "string" }, type = "REMOTE_COHORT:nonexistent" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("does not exist") || err.contains("not found"),
        "Expected error about nonexistent dimension, got: {err}"
    );
}

#[test]
fn test_dimension_type_remote_cohort_empty_name() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
os_cohort = { position = 2, schema = { type = "string" }, type = "REMOTE_COHORT:" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("does not exist") || err.contains("not found"),
        "Expected error about empty cohort name, got: {err}"
    );
}

#[test]
fn test_dimension_type_remote_cohort_invalid_schema() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
os_cohort = { position = 2, type = "REMOTE_COHORT:os", schema = { type = "invalid_type" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(result
        .unwrap_err()
        .to_string()
        .contains("Schema validation failed"));
}

#[test]
fn test_dimension_type_default_regular() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let config = TomlFormat::parse_config(toml).unwrap();
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();
    let reparsed = TomlFormat::parse_config(&serialized).unwrap();

    assert!(serialized.contains(r#"type = "REGULAR""#));
    assert_eq!(config.dimensions.len(), reparsed.dimensions.len());
}

#[test]
fn test_dimension_type_invalid_format() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" }, type = "local_cohort" }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(result.unwrap_err().to_string().contains("local_cohort"));
}

#[test]
fn test_valid_toml_parsing() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }
enabled = { value = true, schema = { type = "boolean" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_ok());
    let parsed = result.unwrap();
    assert_eq!(parsed.default_configs.len(), 2);
    assert_eq!(parsed.dimensions.len(), 1);
    assert_eq!(parsed.contexts.len(), 1);
    assert_eq!(parsed.overrides.len(), 1);
}

#[test]
fn test_missing_section_error() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(result
        .unwrap_err()
        .to_string()
        .contains("missing field `dimensions`"));
}

#[test]
fn test_missing_value_field() {
    let toml = r#"
[default-configs]
timeout = { schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

context = []
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(result
        .unwrap_err()
        .to_string()
        .contains("missing field `value`"));
}

#[test]
fn test_invalid_override_key() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
port = 8080
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(matches!(
        result,
        Err(FormatError::InvalidOverrideKey { .. })
    ));
}

#[test]
fn test_duplicate_position_error() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }
region = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(matches!(
        result,
        Err(FormatError::DuplicatePosition {
            position,
            dimensions
        }) if position == 1 && dimensions.len() == 2
    ));
}

#[test]
fn test_validation_valid_default_config() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }
enabled = { value = true, schema = { type = "boolean" } }
name = { value = "test", schema = { type = "string" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_ok());
}

#[test]
fn test_validation_invalid_default_config_type_mismatch() {
    let toml = r#"
[default-configs]
timeout = { value = "not_an_integer", schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(matches!(result, Err(FormatError::ValidationError { .. })));
    let err = result.unwrap_err();
    assert!(err.to_string().contains("timeout"));
}

#[test]
fn test_validation_valid_context_override() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = 60
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_ok());
}

#[test]
fn test_validation_invalid_context_override_type_mismatch() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }

[dimensions]
os = { position = 1, schema = { type = "string" } }

[[overrides]]
_context_ = { os = "linux" }
timeout = "not_an_integer"
"#;

    let result = TomlFormat::parse_config(toml);
    assert!(result.is_err());
    assert!(matches!(result, Err(FormatError::ValidationError { .. })));
    let err = result.unwrap_err();
    assert!(err.to_string().contains("context[0].timeout"));
}

#[test]
fn test_validation_valid_dimension_value_in_context() {
    let toml = r#"
[default-configs]
timeout = { value = 30, schema = { type = "integer" } }
config = { value = { host = "localhost", port = 8080 }, schema = { type = "object" } }

[dimensions]
os = { position = 2, schema = { type = "string", enum = ["linux", "windows", "macos"] } }
os_cohort = { position = 1, schema = { enum = ["unix", "otherwise"], type = "string", definitions = { unix = { in = [{ var = "os" }, ["linux", "macos"]] } } }, type = "LOCAL_COHORT:os" }

[[overrides]]
_context_ = { os = "linux" }
config = { host = "prod.example.com", port = 443 }

[[overrides]]
_context_ = { os_cohort = "unix" }
config = { host = "prod.unix.com", port = 8443 }
"#;

    let config = TomlFormat::parse_config(toml).unwrap();

    // Verify default config object was parsed correctly
    let default_config_value = config.default_configs.get("config").unwrap();
    assert_eq!(
        default_config_value.get("host"),
        Some(&Value::String("localhost".to_string()))
    );
    assert_eq!(
        default_config_value.get("port"),
        Some(&Value::Number(serde_json::Number::from(8080)))
    );

    // Serialize Config -> TOML
    let serialized = TomlFormat::serialize(config_to_detailed(&config)).unwrap();

    // Parse again
    let reparsed = TomlFormat::parse_config(&serialized).unwrap();

    // Configs should be functionally equivalent
    assert_eq!(config.default_configs, reparsed.default_configs);
    assert_eq!(config.contexts.len(), reparsed.contexts.len());

    // Collect override hosts from both contexts (order may vary)
    let mut override_hosts: Vec<String> = config
        .contexts
        .iter()
        .map(|ctx| {
            let override_key = ctx.override_with_keys.get_key();
            let overrides = config.overrides.get(override_key).unwrap();
            let override_config = overrides.get("config").unwrap();
            override_config
                .get("host")
                .unwrap()
                .as_str()
                .unwrap()
                .to_string()
        })
        .collect();
    override_hosts.sort();
    assert_eq!(
        override_hosts,
        vec!["prod.example.com".to_string(), "prod.unix.com".to_string()]
    );
}