subx-cli 1.7.4

AI subtitle processing CLI tool, which automatically matches, renames, and converts subtitle files.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
# AI Provider Integration Guide

Adding a new AI provider to SubX-CLI spans five layers: the provider client
itself, configuration and validation, factory registration, tests, and
documentation. This guide walks through each step, using the OpenRouter
integration as the reference implementation.

Throughout this guide, placeholders follow a consistent convention:

- `{Provider}` — Rust type name, e.g., `OpenRouter`
- `{provider}` — module name and config value, e.g., `openrouter`
- `{PROVIDER}` — environment variable prefix, e.g., `OPENROUTER`

## Prerequisites

You need familiarity with Rust async programming and the SubX-CLI codebase
structure. Have the target provider's API documentation and an API key ready
before starting.

## Current Provider Landscape

The configuration layer accepts five provider names: `openai`, `openrouter`,
`azure-openai`, `anthropic`, and `local`
(see `src/config/field_validator.rs:30-35`). However, only three have
runtime implementations with client code and factory support: **openai**,
**openrouter**, and **azure-openai**
(see `src/core/factory.rs:189-210`). When adding a new provider, you are
building both the config acceptance path and the runtime implementation.

## Step-by-Step Integration

### Step 1. Create the Provider Client

**File:** `src/services/ai/{provider}.rs` (new)

Create a module that implements the `AIProvider` trait. The trait lives in
`src/services/ai/mod.rs` and requires two async methods:
`analyze_content` and `verify_match`.

```rust
use crate::Result;
use crate::cli::display_ai_usage;
use crate::error::SubXError;
use crate::services::ai::AiUsageStats;
use crate::services::ai::{
    AIProvider, AnalysisRequest, ConfidenceScore, MatchResult, VerificationRequest,
};
use crate::services::ai::prompts::{PromptBuilder, ResponseParser};
use crate::services::ai::retry::HttpRetryClient;
use async_trait::async_trait;
use reqwest::Client;
use serde_json::{Value, json};
use std::time::Duration;

/// {Provider} client implementation.
#[derive(Debug)]
pub struct {Provider}Client {
    client: Client,
    api_key: String,
    model: String,
    temperature: f32,
    max_tokens: u32,
    retry_attempts: u32,
    retry_delay_ms: u64,
    base_url: String,
    request_timeout_seconds: u64,
}

impl {Provider}Client {
    /// Create a new client from the AI configuration section.
    pub fn from_config(config: &crate::config::AIConfig) -> crate::Result<Self> {
        // Validate inputs, build reqwest::Client with timeout, return Self
    }

    /// Validate that the base URL is well-formed.
    fn validate_base_url(url: &str) -> crate::Result<()> {
        // URL validation logic
    }

    /// Send a chat completion request to the provider API.
    async fn chat_completion(&self, messages: Vec<Value>) -> Result<String> {
        // Build request, call make_request_with_retry, parse response,
        // emit usage stats via display_ai_usage
    }
}

#[async_trait]
impl AIProvider for {Provider}Client {
    async fn analyze_content(&self, request: AnalysisRequest) -> Result<MatchResult> {
        // Build prompt via PromptBuilder, call chat_completion,
        // parse response via ResponseParser
    }

    async fn verify_match(&self, request: VerificationRequest) -> Result<ConfidenceScore> {
        // Similar flow for match verification
    }
}
```

The existing providers (`src/services/ai/openai.rs`,
`src/services/ai/openrouter.rs`) serve as concrete references. Each one
uses `PromptBuilder` and `ResponseParser` from `src/services/ai/prompts.rs`
to construct and parse AI messages, and `HttpRetryClient` from
`src/services/ai/retry.rs` for exponential backoff. Follow the same
pattern — reuse the shared prompt and retry infrastructure rather than
reimplementing it.

Every provider must call `display_ai_usage` (from `src/cli/`) after
receiving an API response. Parse token counts from the response and build
an `AiUsageStats` struct to pass to this function.

### Step 2. Register the Module

**File:** `src/services/ai/mod.rs`

Add the module declaration:

```rust
/// {Provider} AI service provider client implementation.
pub mod {provider};
```

### Step 3. Add to Field Validation

**File:** `src/config/field_validator.rs`

Add the new provider slug to the `validate_enum` call at line 32:

```rust
"ai.provider" => {
    validate_non_empty_string(value, "AI provider")?;
    validate_enum(
        value,
        &["openai", "anthropic", "local", "openrouter", "azure-openai", "{provider}"],
    )?;
}
```

Add a test case confirming the new value is accepted:

```rust
assert!(validate_field("ai.provider", "{provider}").is_ok());
```

### Step 4. Add Provider-Specific Validation

**File:** `src/config/validator.rs`

Add a match arm in `validate_ai_config` for the new provider. Each provider
validates its own required fields — at minimum: non-empty API key, valid
model name, temperature in range, positive max_tokens, and valid base URL.

```rust
"{provider}" => {
    if let Some(api_key) = &ai_config.api_key {
        if !api_key.is_empty() {
            validate_api_key(api_key)?;
        }
    }
    validate_ai_model(&ai_config.model)?;
    validate_temperature(ai_config.temperature)?;
    validate_positive_number(ai_config.max_tokens as f64)?;

    if !ai_config.base_url.is_empty() {
        validate_url_format(&ai_config.base_url)?;
    }
}
```

Update the fallthrough error message to list all supported providers. Add a
test that constructs an `AIConfig` with the new provider and verifies
`validate_ai_config` succeeds.

> **Note on HTTP vs HTTPS endpoints.** SubX treats hosted providers
> (`openai`, `openrouter`, `azure-openai`) and the `local` provider
> differently:
>
> - **Hosted providers** require an `https://` `base_url` if the user
>   overrides the default. `validate_ai_config` rejects an `http://`
>   `base_url` for these providers and points the user at
>   `ai.provider = "local"`.
> - **The `local` provider** accepts either `http://` or `https://` and any
>   reachable host (loopback, RFC1918 LAN, VPN/tailnet, public). Plaintext
>   HTTP against a non-loopback host with an API key set logs an advisory
>   warning (see `src/services/ai/security.rs`) but does not block the
>   request.
>
> A new hosted provider added by following this guide should reuse the
> shared HTTPS-required validator branch; a new local-style endpoint-agnostic
> provider should opt out of it explicitly.

### Step 5. Handle Environment Variables

**File:** `src/config/service.rs`

The config service has a dedicated block for each provider's environment
variables (around line 255–297). Add a similar block for the new provider:

```rust
if let Some(api_key) = self.env_provider.get_var("{PROVIDER}_API_KEY") {
    debug!("ProductionConfigService: Found {PROVIDER}_API_KEY environment variable");
    app_config.ai.provider = "{provider}".to_string();
    app_config.ai.api_key = Some(api_key);
}
```

When the env var is set, the service automatically switches the active
provider and injects the key. If your provider needs additional env vars
(like a custom endpoint), add those as well.

Write a test using `TestEnvironmentProvider` to verify the env var is loaded
correctly:

```rust
#[test]
fn test_production_config_service_{provider}_api_key_loading() {
    let mut env_provider = TestEnvironmentProvider::new();
    env_provider.set_var("{PROVIDER}_API_KEY", "test-api-key");
    env_provider.set_var("SUBX_CONFIG_PATH", "/tmp/test_config_{provider}.toml");

    let service = ProductionConfigService::with_env_provider(Arc::new(env_provider))
        .expect("Failed to create config service");
    let config = service.get_config().expect("Failed to get config");

    assert_eq!(config.ai.api_key, Some("test-api-key".to_string()));
}
```

### Step 6. Add Test Configuration Support

**File:** `src/config/test_service.rs`

Add a test verifying that `TestConfigService::with_ai_settings_and_key`
works with the new provider:

```rust
#[test]
fn test_config_service_with_ai_settings_and_key_{provider}() {
    let service = TestConfigService::with_ai_settings_and_key(
        "{provider}", "provider-model", "test-api-key",
    );
    let config = service.get_config().unwrap();
    assert_eq!(config.ai.provider, "{provider}");
    assert_eq!(config.ai.model, "provider-model");
    assert_eq!(config.ai.api_key, Some("test-api-key".to_string()));
}
```

### Step 7. Add Builder Tests

**File:** `src/config/builder.rs`

Add a test confirming the `TestConfigBuilder` fluent API produces a valid
config for the new provider:

```rust
#[test]
fn test_builder_ai_configuration_{provider}() {
    let config = TestConfigBuilder::new()
        .with_ai_provider("{provider}")
        .with_ai_model("provider-model")
        .with_ai_api_key("test-api-key")
        .build_config();
    assert_eq!(config.ai.provider, "{provider}");
    assert_eq!(config.ai.model, "provider-model");
    assert_eq!(config.ai.api_key, Some("test-api-key".to_string()));
}
```

### Step 8. Register in the Factory

**File:** `src/core/factory.rs`

Import the new client and add a match arm in `create_ai_provider`:

```rust
use crate::services::ai::{provider}::{Provider}Client;

// Inside create_ai_provider match:
"{provider}" => {
    validate_ai_config(ai_config)?;
    let client = {Provider}Client::from_config(ai_config)?;
    Ok(Box::new(client))
}
```

Update the fallthrough error message to include the new provider. Add a
factory test:

```rust
#[test]
fn test_create_ai_provider_{provider}_success() {
    let config_service = TestConfigService::default();
    config_service.set_ai_settings_and_key(
        "{provider}", "provider-model", "test-api-key",
    );
    let factory = ComponentFactory::new(&config_service).unwrap();
    let result = factory.create_ai_provider();
    assert!(result.is_ok());
}
```

### Step 9. Update CLI Documentation

**File:** `src/cli/config_args.rs`

Add the new provider to the rustdoc examples in the config args module so
that `subx-cli config set ai.provider {provider}` appears in the help text.

### Step 10. Update Validation Tests

**File:** `src/config/validation.rs`

Add the new provider to any `validate_enum` test arrays that list accepted
providers.

### Step 11. Create Integration Tests

**File:** `tests/{provider}_integration_tests.rs` (new)

Write integration tests covering both success and failure paths:

```rust
use subx_cli::config::TestConfigService;
use subx_cli::core::ComponentFactory;

#[tokio::test]
async fn test_{provider}_client_creation() {
    let config_service = TestConfigService::default();
    config_service.set_ai_settings_and_key(
        "{provider}", "provider-model", "test-key",
    );
    let factory = ComponentFactory::new(&config_service).unwrap();
    assert!(factory.create_ai_provider().is_ok());
}

#[tokio::test]
async fn test_{provider}_empty_api_key_rejected() {
    let config_service = TestConfigService::default();
    config_service.set_ai_settings_and_key("{provider}", "provider-model", "");
    let factory = ComponentFactory::new(&config_service).unwrap();
    let result = factory.create_ai_provider();
    assert!(result.is_err());
}
```

### Step 12. Update Documentation

Three documentation files need updates:

- **`docs/configuration-guide.md`** — Add a TOML configuration example for
  the new provider, including all relevant fields.
- **`README.md`** — Add quick-start setup instructions (env var export +
  `config set` commands).
- **`README.zh-TW.md`** — Add the same instructions in Traditional Chinese.

## Azure OpenAI: Provider-Specific Deviations

Azure OpenAI diverges from the generic pattern in several ways. When
implementing a provider that has similar platform-specific behavior, use
Azure as a reference (see `src/services/ai/azure_openai.rs`).

The `ai.model` field serves as the Azure deployment name rather than a model
identifier. The `ai.api_version` field (an `Option<String>` on `AIConfig`)
is required, with a default of `2025-04-01-preview`. The API endpoint URL
format differs from standard OpenAI.

Azure loads five environment variables in `src/config/service.rs`:
`AZURE_OPENAI_API_KEY`, `AZURE_OPENAI_ENDPOINT`,
`AZURE_OPENAI_API_VERSION`, and `AZURE_OPENAI_DEPLOYMENT_ID` (which
overrides `ai.model`). If your provider has similar multi-field
configuration, follow the same pattern of dedicated env var blocks.

## Local / OpenAI-Compatible Runtimes

The `local` provider (alias `ollama`, normalized at config write time)
targets any OpenAI-compatible chat-completions endpoint. It is implemented
by `LocalLLMClient` in `src/services/ai/local.rs` and registered in
`ComponentFactory::create_ai_provider` via the canonical value `local`.

### Wire protocol

`LocalLLMClient` issues `POST {base_url}/chat/completions` with the
OpenAI-canonical body fields only:

```json
{
  "model": "<ai.model>",
  "messages": [...],
  "temperature": <ai.temperature>,
  "max_tokens": <ai.max_tokens>
}
```

`Authorization: Bearer <api_key>` is sent only when `ai.api_key` is
`Some(non_empty)`. The URL is joined so exactly one `/` separates
`base_url` from `chat/completions` whether or not `base_url` carries a
trailing slash.

### Shared infrastructure reuse

`LocalLLMClient` reuses the same shared traits as `OpenAIClient` and
`OpenRouterClient`:

- `PromptBuilder` from `src/services/ai/prompts.rs` for `analyze_content`
  and `verify_match` prompt construction.
- `ResponseParser` (same module) for parsing the OpenAI-canonical response
  envelope into `MatchResult` / `ConfidenceScore`.
- `HttpRetryClient` from `src/services/ai/retry.rs` for exponential-backoff
  retries driven by `ai.retry_attempts` and `ai.retry_delay_ms`.

This means the local provider participates in the same retry, prompt, and
response contracts as hosted providers without bespoke logic.

### Privacy posture

When the canonical `ai.provider` is `local`, the configuration layer
deliberately skips all hosted-provider environment variables
(`OPENAI_API_KEY`, `OPENAI_BASE_URL`, `OPENROUTER_API_KEY`, all
`AZURE_OPENAI_*`). `LocalLLMClient` issues requests only to the configured
`base_url` and never falls back to a hosted endpoint. There is no
telemetry. The optional `LOCAL_LLM_BASE_URL` and `LOCAL_LLM_API_KEY` env
vars are honored only when `ai.provider = "local"`.

The provider is endpoint-agnostic: loopback (`http://localhost:11434/v1`),
LAN (`http://192.168.x.x:port/v1`), VPN / tailnet
(`https://host.tailnet.ts.net/v1`), and remote OpenAI-compatible servers
are all valid. Both `http://` and `https://` schemes are accepted; SubX
emits an advisory (non-blocking) warning when an API key would be sent
over plain HTTP to a non-loopback host.

### Known compatibility limits

- **Strict-JSON parsing.** `analyze_content` and `verify_match` require
  the model to emit a strict JSON envelope. Smaller models (≤7B
  parameters, low-quantization GGUFs) sometimes drift into prose or wrap
  the JSON in code fences and trigger a parse failure. Prefer
  instruction-tuned models or raise the model size if you see repeated
  parse errors.
- **Sampling parameters.** Some runtimes silently ignore `temperature` or
  `max_tokens` (or apply server-side caps). The request still succeeds
  but the parameters in `[ai]` may not have the expected effect.
- **`verify_match` accuracy.** Verification quality is bounded by the
  underlying model. Weaker local models may approve weak matches.
- **Per-runtime quirks.** A few self-hosted gateways return HTTP 200 with a
  non-OpenAI-canonical body on error paths; `LocalLLMClient` surfaces this
  as `local LLM response was not OpenAI-compatible JSON` rather than a
  generic transport error.

### Error-message reference

`LocalLLMClient` maps low-level failures into `SubXError::AiService`
messages with stable, greppable prefixes. Sanitized variants of the body
and `base_url` (userinfo, query strings, and fragments stripped) are
embedded for diagnostics:

| Prefix | Trigger |
|---|---|
| `local LLM endpoint unreachable` | Connection refused / DNS failure / network unreachable |
| `local LLM endpoint timed out after Ns` | Request exceeded `ai.request_timeout_seconds` |
| `local LLM endpoint returned HTTP {status}` | Non-2xx response (body sanitized via `error_sanitizer`) |
| `local LLM model not found` | HTTP 404 / runtime-specific "model not loaded" body |
| `local LLM response was not OpenAI-compatible JSON` | HTTP 200 with body that does not parse into the canonical envelope |

### Hosted-provider hint

The hosted-provider clients (`openai`, `openrouter`, `azure-openai`) detect
three failure patterns that strongly suggest the user pointed them at a
local/LAN OpenAI-compatible endpoint:

1. Configuration rejected because `ai.base_url` is not `https://`.
2. Connection refused / DNS failure to a private host (loopback,
   RFC1918, RFC4193, link-local).
3. HTTP 200 with a body that parses but is missing OpenAI-canonical
   fields.

In those cases the clients append the canonical advisory string returned
by `local_provider_hint()` (in `src/services/ai/security.rs`) to the
emitted `SubXError::AiService` message via the existing `error_sanitizer`
pipeline:

> If you intended to call an OpenAI-compatible local or LAN endpoint, set
> `ai.provider = "local"` (or `ollama`) and configure `ai.base_url` to your
> endpoint.

The hint is **advisory only** — it never auto-switches the provider — and
the same wording is reused by `validate_ai_config` so the advice stays in
lockstep across validation and runtime emission sites.

## File Change Summary

Every integration touches files across multiple layers. Use this table as a
checklist before opening a pull request.

| Layer | File | Change |
|---|---|---|
| **Client** | `src/services/ai/{provider}.rs` | New: provider implementation |
| **Client** | `src/services/ai/mod.rs` | Add module declaration |
| **Factory** | `src/core/factory.rs` | Add match arm + import |
| **Validation** | `src/config/field_validator.rs` | Add to enum list |
| **Validation** | `src/config/validator.rs` | Add validation block |
| **Config** | `src/config/service.rs` | Add env var handling |
| **Config** | `src/config/test_service.rs` | Add provider test |
| **Config** | `src/config/builder.rs` | Add builder test |
| **Config** | `src/config/validation.rs` | Update enum test arrays |
| **CLI** | `src/cli/config_args.rs` | Add doc examples |
| **Tests** | `tests/{provider}_integration_tests.rs` | New: integration tests |
| **Docs** | `docs/configuration-guide.md` | Add config section |
| **Docs** | `README.md` | Add setup instructions |
| **Docs** | `README.zh-TW.md` | Add setup instructions (Chinese) |

## Testing

A complete provider integration requires tests at three levels:

**Unit tests** live inside the provider module and the configuration files.
They cover config validation, client construction, and error handling for
invalid inputs.

**Factory tests** in `src/core/factory.rs` verify that the factory
dispatches to the correct client and rejects invalid configurations.

**Integration tests** in `tests/{provider}_integration_tests.rs` exercise
the full path from config to client creation. For tests that call the actual
API, use wiremock mocks (see `tests/common/mock_openai_helper.rs` for the
pattern).

Run the following commands to validate:

```bash
# All tests
cargo nextest run || true

# Provider-specific integration tests
cargo nextest run --test {provider}_integration_tests

# Configuration-related tests
cargo nextest run config

# Full quality check
scripts/quality_check.sh
```

## Best Practices

Validate API keys on client construction, not at request time. An empty key
should produce a clear error immediately. If the provider uses a
recognizable key format (like OpenAI's `sk-` prefix), add format validation
as well, but keep it lenient — providers change key formats over time.

Reuse the shared `HttpRetryClient` from `src/services/ai/retry.rs` for
retry logic. It implements exponential backoff with configurable attempts
and delay. Timeout values come from `AIConfig.request_timeout_seconds`.
Handle timeout and network errors by returning `SubXError::AiService` with
a descriptive message.

Call `display_ai_usage` after every successful API response. Parse the token
counts (prompt tokens, completion tokens, total tokens) from the provider's
response format and pass them as `AiUsageStats`.

Never log or print API keys. The config system handles keys through
`Option<String>` fields and environment variables. Follow the same pattern
for any additional secrets your provider requires.

Test both the success path and the failure path. At minimum, verify that a
valid config produces a working client, an empty API key is rejected, and
an invalid base URL is rejected. If the provider has unique error responses,
add tests for those as well.