sublime_pkg_tools 0.0.27

Package and version management toolkit for Node.js projects with changeset support
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
//! # Version Resolution Integration Tests
//!
//! **What**: Comprehensive end-to-end integration tests for the version resolution system.
//! This module tests the complete workflow from changeset creation to version application,
//! including dependency propagation, circular dependency detection, and various versioning
//! strategies.
//!
//! **How**: Creates real filesystem structures using temporary directories, simulates
//! complete monorepo and single-package scenarios, and validates the entire version
//! resolution pipeline including dry-run and actual application modes.
//!
//! **Why**: To ensure the version resolution system works correctly in real-world scenarios
//! with complex dependency graphs, multiple packages, and various edge cases. These tests
//! validate the integration of all version module components working together.

#![allow(clippy::expect_used)]
#![allow(clippy::panic)]

use std::path::PathBuf;
use sublime_pkg_tools::config::PackageToolsConfig;
use sublime_pkg_tools::types::{Changeset, UpdateReason, VersionBump, VersioningStrategy};
use sublime_pkg_tools::version::VersionResolver;

mod common;

// ============================================================================
// Test Fixtures - Complex Scenarios
// ============================================================================

/// Creates a complex monorepo with various dependency patterns
async fn create_complex_monorepo() -> (tempfile::TempDir, PathBuf) {
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    // Root package.json
    let root_package = r#"{
        "name": "monorepo-root",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*", "tools/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_package)
        .await
        .expect("Failed to write root package.json");

    // Create package-lock.json to ensure NPM workspace detection
    let package_lock = r#"{
        "name": "monorepo-root",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    // Create packages directory
    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages dir");

    // Create tools directory
    tokio::fs::create_dir_all(root.join("tools")).await.expect("Failed to create tools dir");

    // Package A - No dependencies
    let pkg_a_dir = root.join("packages").join("pkg-a");
    tokio::fs::create_dir_all(&pkg_a_dir).await.expect("Failed to create pkg-a dir");
    let pkg_a = r#"{
        "name": "@test/pkg-a",
        "version": "1.0.0",
        "description": "Package A"
    }"#;
    tokio::fs::write(pkg_a_dir.join("package.json"), pkg_a)
        .await
        .expect("Failed to write pkg-a package.json");

    // Package B - Depends on A
    let pkg_b_dir = root.join("packages").join("pkg-b");
    tokio::fs::create_dir_all(&pkg_b_dir).await.expect("Failed to create pkg-b dir");
    let pkg_b = r#"{
        "name": "@test/pkg-b",
        "version": "1.0.0",
        "dependencies": {
            "@test/pkg-a": "^1.0.0",
            "lodash": "^4.17.21"
        }
    }"#;
    tokio::fs::write(pkg_b_dir.join("package.json"), pkg_b)
        .await
        .expect("Failed to write pkg-b package.json");

    // Package C - Depends on B (transitive to A)
    let pkg_c_dir = root.join("packages").join("pkg-c");
    tokio::fs::create_dir_all(&pkg_c_dir).await.expect("Failed to create pkg-c dir");
    let pkg_c = r#"{
        "name": "@test/pkg-c",
        "version": "2.0.0",
        "dependencies": {
            "@test/pkg-b": "^1.0.0"
        },
        "devDependencies": {
            "@test/pkg-a": "^1.0.0"
        }
    }"#;
    tokio::fs::write(pkg_c_dir.join("package.json"), pkg_c)
        .await
        .expect("Failed to write pkg-c package.json");

    // Package D - Independent
    let pkg_d_dir = root.join("packages").join("pkg-d");
    tokio::fs::create_dir_all(&pkg_d_dir).await.expect("Failed to create pkg-d dir");
    let pkg_d = r#"{
        "name": "@test/pkg-d",
        "version": "0.5.0",
        "dependencies": {
            "react": "^18.0.0"
        }
    }"#;
    tokio::fs::write(pkg_d_dir.join("package.json"), pkg_d)
        .await
        .expect("Failed to write pkg-d package.json");

    // Tool package with workspace protocol
    let tool_dir = root.join("tools").join("build-tool");
    tokio::fs::create_dir_all(&tool_dir).await.expect("Failed to create build-tool dir");
    let tool = r#"{
        "name": "@test/build-tool",
        "version": "1.0.0",
        "dependencies": {
            "@test/pkg-a": "workspace:*",
            "@test/pkg-b": "workspace:^"
        }
    }"#;
    tokio::fs::write(tool_dir.join("package.json"), tool)
        .await
        .expect("Failed to write build-tool package.json");

    (temp_dir, root)
}

/// Creates a monorepo with circular dependencies
async fn create_circular_monorepo() -> (tempfile::TempDir, PathBuf) {
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let root_package = r#"{
        "name": "circular-root",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_package)
        .await
        .expect("Failed to write root package.json");

    // Create package-lock.json for NPM workspace detection
    let package_lock = r#"{
        "name": "circular-root",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages dir");

    // Package A depends on B
    let pkg_a_dir = root.join("packages").join("pkg-a");
    tokio::fs::create_dir_all(&pkg_a_dir).await.expect("Failed to create pkg-a dir");
    let pkg_a = r#"{
        "name": "@circular/pkg-a",
        "version": "1.0.0",
        "dependencies": {
            "@circular/pkg-b": "^1.0.0"
        }
    }"#;
    tokio::fs::write(pkg_a_dir.join("package.json"), pkg_a)
        .await
        .expect("Failed to write pkg-a package.json");

    // Package B depends on A (creates cycle)
    let pkg_b_dir = root.join("packages").join("pkg-b");
    tokio::fs::create_dir_all(&pkg_b_dir).await.expect("Failed to create pkg-b dir");
    let pkg_b = r#"{
        "name": "@circular/pkg-b",
        "version": "1.0.0",
        "dependencies": {
            "@circular/pkg-a": "^1.0.0"
        }
    }"#;
    tokio::fs::write(pkg_b_dir.join("package.json"), pkg_b)
        .await
        .expect("Failed to write pkg-b package.json");

    (temp_dir, root)
}

/// Creates a deep dependency chain monorepo
async fn create_deep_chain_monorepo(depth: usize) -> (tempfile::TempDir, PathBuf) {
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let root_package = r#"{
        "name": "deep-chain-root",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_package)
        .await
        .expect("Failed to write root package.json");

    // Create package-lock.json for NPM workspace detection
    let package_lock = r#"{
        "name": "deep-chain-root",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages dir");

    // Create chain: pkg-0 -> pkg-1 -> pkg-2 -> ... -> pkg-N
    for i in 0..depth {
        let pkg_dir = root.join("packages").join(format!("pkg-{}", i));
        tokio::fs::create_dir_all(&pkg_dir).await.expect("Failed to create package dir");

        let pkg_json = if i == 0 {
            // First package has no dependencies
            format!(
                r#"{{
                "name": "@chain/pkg-{}",
                "version": "1.0.0"
            }}"#,
                i
            )
        } else {
            // Each package depends on the previous one
            format!(
                r#"{{
                "name": "@chain/pkg-{}",
                "version": "1.0.0",
                "dependencies": {{
                    "@chain/pkg-{}": "^1.0.0"
                }}
            }}"#,
                i,
                i - 1
            )
        };

        tokio::fs::write(pkg_dir.join("package.json"), pkg_json)
            .await
            .expect("Failed to write package.json");
    }

    (temp_dir, root)
}

/// Creates a single package project
async fn create_single_package() -> (tempfile::TempDir, PathBuf) {
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let package = r#"{
        "name": "single-package",
        "version": "1.5.0",
        "description": "A single package project",
        "dependencies": {
            "lodash": "^4.17.21",
            "axios": "^1.0.0"
        },
        "devDependencies": {
            "jest": "^29.0.0",
            "typescript": "^5.0.0"
        }
    }"#;
    tokio::fs::write(root.join("package.json"), package)
        .await
        .expect("Failed to write package.json");

    (temp_dir, root)
}

// ============================================================================
// Integration Tests - Complete Workflows
// ============================================================================

#[tokio::test]
async fn test_integration_complete_resolution_workflow_independent() {
    // Setup: Create complex monorepo
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    assert!(resolver.is_monorepo(), "Should detect monorepo");

    // Create changeset with Package A getting a minor bump
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Step 1: Resolve versions (includes propagation)
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Verify resolution - pkg-a direct + pkg-b and pkg-c propagated
    assert_eq!(resolution.updates.len(), 3, "Should update pkg-a, pkg-b, and pkg-c");

    // Find pkg-a update
    let pkg_a_update = resolution
        .updates
        .iter()
        .find(|u| u.name == "@test/pkg-a")
        .expect("Should find pkg-a update");
    assert_eq!(pkg_a_update.current_version.to_string(), "1.0.0");
    assert_eq!(pkg_a_update.next_version.to_string(), "1.1.0");
    assert!(!pkg_a_update.is_propagated(), "pkg-a is direct change");

    // Find pkg-b update (propagated)
    let pkg_b_update = resolution
        .updates
        .iter()
        .find(|u| u.name == "@test/pkg-b")
        .expect("Should find pkg-b update");
    assert_eq!(pkg_b_update.current_version.to_string(), "1.0.0");
    assert_eq!(pkg_b_update.next_version.to_string(), "1.0.1");
    assert!(pkg_b_update.is_propagated(), "pkg-b should be propagated");

    // Step 2: Apply versions with dry run
    let dry_result =
        resolver.apply_versions(&changeset, true).await.expect("Failed to apply dry run");

    assert!(dry_result.dry_run, "Should be dry run");
    assert_eq!(dry_result.modified_files.len(), 0, "Should not modify files in dry run");
    assert_eq!(dry_result.summary.packages_updated, 3);
    assert_eq!(dry_result.summary.direct_updates, 1);
    assert_eq!(dry_result.summary.propagated_updates, 2);

    // Step 3: Apply versions for real
    let apply_result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert!(!apply_result.dry_run, "Should not be dry run");
    assert_eq!(apply_result.modified_files.len(), 3, "Should modify 3 package.json files");
    assert_eq!(apply_result.summary.packages_updated, 3);

    // Step 4: Verify file contents
    let pkg_a_content = tokio::fs::read_to_string(root.join("packages/pkg-a/package.json"))
        .await
        .expect("Failed to read pkg-a");
    assert!(pkg_a_content.contains(r#""version": "1.1.0""#), "pkg-a version should be updated");

    let pkg_b_content = tokio::fs::read_to_string(root.join("packages/pkg-b/package.json"))
        .await
        .expect("Failed to read pkg-b");
    assert!(pkg_b_content.contains(r#""version": "1.0.1""#), "pkg-b version should be updated");
    assert!(
        pkg_b_content.contains(r#""@test/pkg-a": "^1.1.0""#),
        "pkg-b dependency should be updated"
    );

    let pkg_c_content = tokio::fs::read_to_string(root.join("packages/pkg-c/package.json"))
        .await
        .expect("Failed to read pkg-c");
    assert!(pkg_c_content.contains(r#""version": "2.0.1""#), "pkg-c version should be updated");
    assert!(
        pkg_c_content.contains(r#""@test/pkg-b": "^1.0.1""#),
        "pkg-c dependency should be updated"
    );
}

#[tokio::test]
async fn test_integration_unified_strategy_workflow() {
    // Setup: Create complex monorepo with unified strategy
    let (_temp, root) = create_complex_monorepo().await;
    let mut config = PackageToolsConfig::default();
    config.version.strategy = VersioningStrategy::Unified;

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Create changeset with multiple packages
    let mut changeset =
        Changeset::new("release/v2", VersionBump::Major, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");
    changeset.add_package("@test/pkg-b");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // In unified strategy, all packages should get the same version
    let major_versions: Vec<_> =
        resolution.updates.iter().filter(|u| u.next_version.major() >= 2).collect();

    assert!(!major_versions.is_empty(), "Should have major version updates");

    // Apply versions
    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert!(!result.dry_run);
    assert!(result.summary.packages_updated > 0);

    // Verify all packages have unified version
    // In unified strategy, all packages get the highest version bumped
    // pkg-c has 2.0.0 (highest), Major bump -> 3.0.0, all packages get 3.0.0
    let pkg_a_content = tokio::fs::read_to_string(root.join("packages/pkg-a/package.json"))
        .await
        .expect("Failed to read pkg-a");
    assert!(
        pkg_a_content.contains(r#""version": "3.0.0""#),
        "pkg-a should have unified version 3.0.0"
    );

    // Verify other packages also have the same unified version
    let pkg_c_content = tokio::fs::read_to_string(root.join("packages/pkg-c/package.json"))
        .await
        .expect("Failed to read pkg-c");
    assert!(
        pkg_c_content.contains(r#""version": "3.0.0""#),
        "pkg-c should have unified version 3.0.0"
    );

    // All packages in the updates should have the same next version
    let first_version = resolution.updates[0].next_version.clone();
    for update in &resolution.updates {
        assert_eq!(
            update.next_version, first_version,
            "All packages should have the same version in unified strategy"
        );
    }
}

#[tokio::test]
async fn test_integration_circular_dependency_detection() {
    // Setup: Create monorepo with circular dependencies
    let (_temp, root) = create_circular_monorepo().await;
    let config = PackageToolsConfig::default();

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Create changeset
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@circular/pkg-a");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Should detect circular dependency
    assert!(!resolution.circular_dependencies.is_empty(), "Should detect circular dependencies");
    assert_eq!(resolution.circular_dependencies.len(), 1);

    let cycle = &resolution.circular_dependencies[0];
    assert!(cycle.cycle.contains(&"@circular/pkg-a".to_string()));
    assert!(cycle.cycle.contains(&"@circular/pkg-b".to_string()));
}

#[tokio::test]
async fn test_integration_max_depth_propagation() {
    // Setup: Create deep chain
    let depth = 10;
    let (_temp, root) = create_deep_chain_monorepo(depth).await;

    // Configure with max depth = 3
    let mut config = PackageToolsConfig::default();
    config.dependency.max_depth = 3;

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Create changeset for first package
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@chain/pkg-0");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Should only propagate to depth 3 (pkg-0, pkg-1, pkg-2, pkg-3)
    assert!(
        resolution.updates.len() <= 4,
        "Should respect max depth of 3, got {} updates",
        resolution.updates.len()
    );

    // Verify depth in updates
    for update in &resolution.updates {
        if let UpdateReason::DependencyPropagation { depth, .. } = &update.reason {
            assert!(depth <= &3, "Propagation depth should not exceed 3");
        }
    }
}

#[tokio::test]
async fn test_integration_workspace_protocol_preservation() {
    // Setup: Create complex monorepo
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Create changeset for pkg-a
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Apply versions
    let _result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    // Verify workspace protocol is preserved in build-tool
    let tool_content = tokio::fs::read_to_string(root.join("tools/build-tool/package.json"))
        .await
        .expect("Failed to read build-tool");

    assert!(
        tool_content.contains(r#""@test/pkg-a": "workspace:*""#),
        "workspace:* protocol should be preserved"
    );
    assert!(
        tool_content.contains(r#""@test/pkg-b": "workspace:^""#),
        "workspace:^ protocol should be preserved"
    );
}

#[tokio::test]
async fn test_integration_single_package_workflow() {
    // Setup: Create single package
    let (_temp, root) = create_single_package().await;
    let config = PackageToolsConfig::default();

    // Initialize resolver
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    assert!(!resolver.is_monorepo(), "Should not detect as monorepo");

    // Create changeset
    let mut changeset =
        Changeset::new("release/v2", VersionBump::Major, vec!["production".to_string()]);
    changeset.add_package("single-package");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    assert_eq!(resolution.updates.len(), 1);
    let update = &resolution.updates[0];
    assert_eq!(update.current_version.to_string(), "1.5.0");
    assert_eq!(update.next_version.to_string(), "2.0.0");

    // Apply versions
    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert_eq!(result.modified_files.len(), 1);
    assert_eq!(result.summary.packages_updated, 1);
    assert_eq!(result.summary.direct_updates, 1);
    assert_eq!(result.summary.propagated_updates, 0);

    // Verify file content
    let content = tokio::fs::read_to_string(root.join("package.json"))
        .await
        .expect("Failed to read package.json");
    assert!(content.contains(r#""version": "2.0.0""#));
}

#[tokio::test]
async fn test_integration_dry_run_then_apply() {
    // Setup
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Patch, vec!["staging".to_string()]);
    changeset.add_package("@test/pkg-d");

    // First: Dry run
    let dry_result =
        resolver.apply_versions(&changeset, true).await.expect("Failed to apply dry run");

    assert!(dry_result.dry_run);
    assert_eq!(dry_result.modified_files.len(), 0);
    let dry_summary = dry_result.summary;

    // Verify no files were modified
    let original_content = tokio::fs::read_to_string(root.join("packages/pkg-d/package.json"))
        .await
        .expect("Failed to read pkg-d");
    assert!(original_content.contains(r#""version": "0.5.0""#));

    // Then: Actual apply
    let apply_result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert!(!apply_result.dry_run);
    assert_eq!(apply_result.modified_files.len(), 1);

    // Verify summaries match
    assert_eq!(dry_summary.packages_updated, apply_result.summary.packages_updated);
    assert_eq!(dry_summary.direct_updates, apply_result.summary.direct_updates);

    // Verify file was modified
    let updated_content = tokio::fs::read_to_string(root.join("packages/pkg-d/package.json"))
        .await
        .expect("Failed to read pkg-d");
    assert!(updated_content.contains(r#""version": "0.5.1""#));
}

#[tokio::test]
async fn test_integration_no_propagation_config() {
    // Setup: Create complex monorepo with no propagation
    let (_temp, root) = create_complex_monorepo().await;
    let mut config = PackageToolsConfig::default();
    config.dependency.propagation_bump = "none".to_string(); // Disable propagation

    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Should only update pkg-a, not propagate
    assert_eq!(resolution.updates.len(), 1);
    assert_eq!(resolution.updates[0].name, "@test/pkg-a");
    assert!(!resolution.updates[0].is_propagated());
}

#[tokio::test]
async fn test_integration_dev_dependencies_propagation() {
    // Setup
    let (_temp, root) = create_complex_monorepo().await;
    let mut config = PackageToolsConfig::default();
    config.dependency.propagate_dev_dependencies = true; // Enable dev deps propagation

    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // pkg-c has pkg-a as devDependency, should be updated
    let pkg_c_update = resolution.updates.iter().find(|u| u.name == "@test/pkg-c");

    assert!(pkg_c_update.is_some(), "pkg-c should be updated due to devDependency");

    // Apply and verify
    let _result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    let pkg_c_content = tokio::fs::read_to_string(root.join("packages/pkg-c/package.json"))
        .await
        .expect("Failed to read pkg-c");

    // Check devDependencies section
    let pkg_c_json: serde_json::Value =
        serde_json::from_str(&pkg_c_content).expect("Failed to parse JSON");
    let dev_deps = pkg_c_json["devDependencies"].as_object().expect("Should have devDependencies");
    let pkg_a_version = dev_deps["@test/pkg-a"].as_str().expect("Should have @test/pkg-a");

    assert!(pkg_a_version.contains("1.1.0"), "devDependency should be updated to 1.1.0");
}

#[tokio::test]
async fn test_integration_empty_changeset() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    // Create changeset with no packages
    let changeset =
        Changeset::new("feature/empty", VersionBump::Minor, vec!["production".to_string()]);

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    assert_eq!(resolution.updates.len(), 0);
    assert_eq!(resolution.circular_dependencies.len(), 0);
}

#[tokio::test]
async fn test_integration_nonexistent_package_error() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    // Create changeset with non-existent package
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/nonexistent");

    // Should return error
    let result = resolver.resolve_versions(&changeset).await;
    assert!(result.is_err(), "Should error on non-existent package");
}

#[tokio::test]
async fn test_integration_multiple_packages_independent_bumps() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Create changeset with multiple packages with different explicit versions
    let mut changeset =
        Changeset::new("release/multi", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");
    changeset.add_package("@test/pkg-d");

    // Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Should update both directly affected packages plus propagated ones
    assert!(resolution.updates.len() >= 2);

    // Find direct updates
    let direct_updates: Vec<_> = resolution.updates.iter().filter(|u| !u.is_propagated()).collect();

    assert_eq!(direct_updates.len(), 2);

    // Apply versions
    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert_eq!(result.summary.direct_updates, 2);
}

#[tokio::test]
async fn test_integration_all_version_bumps() {
    let (_temp, root) = create_single_package().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    // Test Major bump
    let mut major_changeset =
        Changeset::new("release/v2", VersionBump::Major, vec!["production".to_string()]);
    major_changeset.add_package("single-package");

    let major_resolution =
        resolver.resolve_versions(&major_changeset).await.expect("Failed to resolve major");
    assert_eq!(major_resolution.updates[0].next_version.to_string(), "2.0.0");

    // Test Minor bump (reset to 1.5.0)
    let mut minor_changeset =
        Changeset::new("feature/new", VersionBump::Minor, vec!["production".to_string()]);
    minor_changeset.add_package("single-package");

    let minor_resolution =
        resolver.resolve_versions(&minor_changeset).await.expect("Failed to resolve minor");
    assert_eq!(minor_resolution.updates[0].next_version.to_string(), "1.6.0");

    // Test Patch bump
    let mut patch_changeset =
        Changeset::new("fix/bug", VersionBump::Patch, vec!["production".to_string()]);
    patch_changeset.add_package("single-package");

    let patch_resolution =
        resolver.resolve_versions(&patch_changeset).await.expect("Failed to resolve patch");
    assert_eq!(patch_resolution.updates[0].next_version.to_string(), "1.5.1");
}

#[tokio::test]
async fn test_integration_json_formatting_preservation() {
    // Create a package with specific formatting
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let formatted_package = r#"{
  "name": "formatted-package",
  "version": "1.0.0",
  "description": "Test formatting",
  "dependencies": {
    "lodash": "^4.17.21"
  }
}"#;
    tokio::fs::write(root.join("package.json"), formatted_package)
        .await
        .expect("Failed to write package.json");

    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("formatted-package");

    // Apply versions
    let _result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    // Read and verify formatting is preserved (2-space indentation)
    let content = tokio::fs::read_to_string(root.join("package.json"))
        .await
        .expect("Failed to read package.json");

    assert!(content.contains(r#""version": "1.1.0""#));
    // Check that indentation is preserved (2 spaces)
    assert!(content.contains("  \"name\""));
    assert!(content.contains("  \"version\""));
}

#[tokio::test]
async fn test_integration_discover_packages() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    // Discover all packages
    let packages = resolver.discover_packages().await.expect("Failed to discover packages");

    // Should find 5 packages (pkg-a, pkg-b, pkg-c, pkg-d, build-tool)
    assert_eq!(packages.len(), 5, "Should discover all 5 packages");

    // Verify package names
    let names: Vec<String> = packages.iter().map(|p| p.name().to_string()).collect();
    assert!(names.contains(&"@test/pkg-a".to_string()));
    assert!(names.contains(&"@test/pkg-b".to_string()));
    assert!(names.contains(&"@test/pkg-c".to_string()));
    assert!(names.contains(&"@test/pkg-d".to_string()));
    assert!(names.contains(&"@test/build-tool".to_string()));
}

// ============================================================================
// Edge Cases and Error Scenarios
// ============================================================================

#[tokio::test]
async fn test_integration_edge_case_all_packages_independent() {
    // Create monorepo where no packages depend on each other
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let root_package = r#"{
        "name": "independent-root",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_package).await.expect("Failed to write root");

    // Create package-lock.json for NPM workspace detection
    let package_lock = r#"{
        "name": "independent-root",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages");

    for i in 1..=3 {
        let pkg_dir = root.join("packages").join(format!("pkg-{}", i));
        tokio::fs::create_dir_all(&pkg_dir).await.expect("Failed to create pkg dir");
        let pkg = format!(
            r#"{{
            "name": "@independent/pkg-{}",
            "version": "1.0.0",
            "dependencies": {{
                "external-lib": "^1.0.0"
            }}
        }}"#,
            i
        );
        tokio::fs::write(pkg_dir.join("package.json"), pkg).await.expect("Failed to write package");
    }

    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@independent/pkg-1");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Should only update pkg-1, no propagation
    assert_eq!(resolution.updates.len(), 1);
    assert_eq!(resolution.updates[0].name, "@independent/pkg-1");
}

#[tokio::test]
async fn test_integration_edge_case_version_none_bump() {
    let (_temp, root) = create_single_package().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("chore/update", VersionBump::None, vec!["production".to_string()]);
    changeset.add_package("single-package");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Version should remain the same
    assert_eq!(resolution.updates.len(), 1);
    assert_eq!(resolution.updates[0].current_version, resolution.updates[0].next_version);
}

#[tokio::test]
async fn test_integration_stress_large_monorepo() {
    // Create a large monorepo with many packages
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let root_package = r#"{
        "name": "large-monorepo",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_package).await.expect("Failed to write root");

    // Create package-lock.json for NPM workspace detection
    let package_lock = r#"{
        "name": "large-monorepo",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages");

    // Create 50 packages
    for i in 0..50 {
        let pkg_dir = root.join("packages").join(format!("pkg-{}", i));
        tokio::fs::create_dir_all(&pkg_dir).await.expect("Failed to create pkg dir");

        // Each package depends on the previous one (except first)
        let deps = if i > 0 {
            format!(
                r#","dependencies": {{
                "@large/pkg-{}": "^1.0.0"
            }}"#,
                i - 1
            )
        } else {
            String::new()
        };

        let pkg = format!(
            r#"{{
            "name": "@large/pkg-{}",
            "version": "1.0.0"{}
        }}"#,
            i, deps
        );
        tokio::fs::write(pkg_dir.join("package.json"), pkg).await.expect("Failed to write package");
    }

    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    // Should discover all packages
    let packages = resolver.discover_packages().await.expect("Failed to discover packages");
    assert_eq!(packages.len(), 50);

    // Update first package should propagate through chain
    let mut changeset =
        Changeset::new("feature/test", VersionBump::Patch, vec!["production".to_string()]);
    changeset.add_package("@large/pkg-0");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // All packages in chain should be updated
    assert!(resolution.updates.len() > 1, "Should propagate updates");
}

// ============================================================================
// Performance and Stress Tests
// ============================================================================

#[tokio::test]
async fn test_integration_performance_resolution_speed() {
    // Create a medium-sized monorepo
    let (_temp, root) = create_deep_chain_monorepo(20).await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@chain/pkg-0");

    // Measure resolution time
    let start = std::time::Instant::now();
    let _resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");
    let duration = start.elapsed();

    // Resolution should complete in reasonable time (< 1 second for 20 packages)
    assert!(duration.as_secs() < 1, "Resolution took too long: {:?}", duration);
}

#[tokio::test]
async fn test_integration_performance_apply_speed() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Measure apply time
    let start = std::time::Instant::now();
    let _result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");
    let duration = start.elapsed();

    // Apply should complete quickly (< 500ms for small monorepo)
    assert!(duration.as_millis() < 500, "Apply took too long: {:?}", duration);
}

#[tokio::test]
async fn test_integration_concurrent_resolution() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    // Create multiple changesets
    let mut changeset1 =
        Changeset::new("feature/1", VersionBump::Minor, vec!["production".to_string()]);
    changeset1.add_package("@test/pkg-a");

    let mut changeset2 =
        Changeset::new("feature/2", VersionBump::Patch, vec!["staging".to_string()]);
    changeset2.add_package("@test/pkg-d");

    // Resolve concurrently
    let resolver_clone = resolver.clone();
    let handle1 = tokio::spawn(async move { resolver_clone.resolve_versions(&changeset1).await });

    let resolver_clone2 = resolver.clone();
    let handle2 = tokio::spawn(async move { resolver_clone2.resolve_versions(&changeset2).await });

    // Both should succeed
    let result1 = handle1.await.expect("Task panicked").expect("Resolution 1 failed");
    let result2 = handle2.await.expect("Task panicked").expect("Resolution 2 failed");

    assert!(!result1.updates.is_empty());
    assert!(!result2.updates.is_empty());
}

// ============================================================================
// Cross-Platform Path Tests
// ============================================================================

#[tokio::test]
async fn test_integration_cross_platform_paths() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let packages = resolver.discover_packages().await.expect("Failed to discover packages");

    // Verify all paths use platform-appropriate separators
    for package in packages {
        let path = package.path();
        assert!(path.is_absolute() || path.starts_with("packages") || path.starts_with("tools"));

        // Path should be valid for current platform
        assert!(path.components().count() > 0, "Path should have components");
    }
}

#[tokio::test]
async fn test_integration_normalized_paths_in_resolution() {
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    // All modified file paths should be normalized
    for path in &result.modified_files {
        // Should not contain mixed separators or redundant separators
        let path_str = path.to_string_lossy();

        // On Windows, \\?\ prefix is valid for extended-length paths, so skip this check
        // if the path starts with that prefix
        let has_extended_prefix = cfg!(windows) && path_str.starts_with(r"\\?\");

        if !has_extended_prefix {
            assert!(!path_str.contains("//"), "Path should not have double slashes: {}", path_str);
            assert!(
                !path_str.contains("\\\\"),
                "Path should not have double backslashes: {}",
                path_str
            );
        }

        // Verify the path is absolute and exists
        assert!(path.is_absolute(), "Path should be absolute: {:?}", path);
    }
}

// ============================================================================
// Configuration Validation Tests
// ============================================================================

#[tokio::test]
async fn test_integration_custom_config_propagation_bump() {
    let (_temp, root) = create_complex_monorepo().await;
    let mut config = PackageToolsConfig::default();
    config.dependency.propagation_bump = "minor".to_string(); // Propagate with minor bump

    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Major, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Find propagated updates
    let propagated: Vec<_> = resolution.updates.iter().filter(|u| u.is_propagated()).collect();

    // Propagated packages should get minor bump instead of patch
    for update in propagated {
        // Check that version bumped by at least minor
        assert!(
            update.next_version.minor() > update.current_version.minor()
                || update.next_version.major() > update.current_version.major(),
            "Propagated update should have at least minor bump"
        );
    }
}

#[tokio::test]
async fn test_integration_skip_protocols_config() {
    let (_temp, root) = create_complex_monorepo().await;
    let mut config = PackageToolsConfig::default();
    config.dependency.skip_workspace_protocol = true;
    config.dependency.skip_file_protocol = true;
    config.dependency.skip_link_protocol = true;

    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    let _result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    // Verify workspace protocols are preserved (tested in earlier test)
    // This test ensures config is properly applied
}

// ============================================================================
// Real-World Scenario Tests
// ============================================================================

#[tokio::test]
async fn test_integration_scenario_hotfix_release() {
    // Scenario: Hotfix release - patch bump on production package
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("hotfix/critical-bug", VersionBump::Patch, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-b");

    // Resolve and apply
    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert_eq!(result.summary.direct_updates, 1);

    // Verify version
    let pkg_b_content = tokio::fs::read_to_string(root.join("packages/pkg-b/package.json"))
        .await
        .expect("Failed to read pkg-b");
    assert!(pkg_b_content.contains(r#""version": "1.0.1""#));
}

#[tokio::test]
async fn test_integration_scenario_major_breaking_change() {
    // Scenario: Major breaking change affecting dependent packages
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver =
        VersionResolver::new(root.clone(), config).await.expect("Failed to create resolver");

    let mut changeset = Changeset::new(
        "feat/breaking-api-change",
        VersionBump::Major,
        vec!["production".to_string()],
    );
    changeset.add_package("@test/pkg-a");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // Direct package gets major bump
    let pkg_a =
        resolution.updates.iter().find(|u| u.name == "@test/pkg-a").expect("Should find pkg-a");
    assert_eq!(pkg_a.next_version.major(), 2);

    // Dependent packages get patch bump (propagation)
    let pkg_b =
        resolution.updates.iter().find(|u| u.name == "@test/pkg-b").expect("Should find pkg-b");
    assert!(pkg_b.is_propagated());
}

#[tokio::test]
async fn test_integration_scenario_feature_release_multiple_packages() {
    // Scenario: Feature release affecting multiple packages
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset = Changeset::new(
        "feat/new-feature",
        VersionBump::Minor,
        vec!["production".to_string(), "staging".to_string()],
    );
    changeset.add_package("@test/pkg-a");
    changeset.add_package("@test/pkg-b");
    changeset.add_package("@test/pkg-c");

    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    // All three packages should get minor bump
    assert!(resolution.updates.len() >= 3);

    let direct_updates = resolution.updates.iter().filter(|u| !u.is_propagated()).count();
    assert_eq!(direct_updates, 3, "Should have 3 direct updates");
}

#[tokio::test]
async fn test_integration_scenario_preview_before_release() {
    // Scenario: Preview changes before actual release
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("release/v2.0", VersionBump::Major, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Step 1: Preview (dry run)
    let preview = resolver.apply_versions(&changeset, true).await.expect("Failed to preview");

    assert!(preview.dry_run);
    println!("Preview: {} packages will be updated", preview.summary.packages_updated);

    // Step 2: Review and apply
    if preview.resolution.circular_dependencies.is_empty() {
        let actual = resolver.apply_versions(&changeset, false).await.expect("Failed to apply");

        assert!(!actual.dry_run);
        assert_eq!(preview.summary.packages_updated, actual.summary.packages_updated);
    }
}

// ============================================================================
// Regression Tests
// ============================================================================

#[tokio::test]
async fn test_integration_regression_empty_dependencies() {
    // Regression: Handle packages with empty dependency objects
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let package = r#"{
        "name": "empty-deps",
        "version": "1.0.0",
        "dependencies": {},
        "devDependencies": {}
    }"#;
    tokio::fs::write(root.join("package.json"), package)
        .await
        .expect("Failed to write package.json");

    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let mut changeset =
        Changeset::new("feature/test", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("empty-deps");

    let result = resolver.resolve_versions(&changeset).await;
    assert!(result.is_ok(), "Should handle empty dependency objects");
}

#[tokio::test]
async fn test_integration_regression_missing_version_field() {
    // Regression: Handle package.json without version field
    // Note: package.json without version is technically valid (for private packages)
    // but should error when trying to resolve versions
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let package = r#"{
        "name": "no-version",
        "private": true
    }"#;
    tokio::fs::write(root.join("package.json"), package)
        .await
        .expect("Failed to write package.json");

    let config = PackageToolsConfig::default();

    // VersionResolver creation might succeed for private packages without version
    // but should fail when trying to actually resolve versions
    let resolver = VersionResolver::new(root, config).await;

    if let Ok(resolver) = resolver {
        // If resolver was created, it should fail when discovering packages or resolving
        let packages_result = resolver.discover_packages().await;

        // Either discover fails or we get packages without valid versions
        if let Ok(packages) = packages_result {
            // Packages without version should fail when trying to resolve
            assert!(
                packages.is_empty() || packages[0].version().to_string() == "0.0.0",
                "Package without explicit version should default or be empty"
            );
        }
        // Test passes if either resolver creation, discovery, or version parsing fails appropriately
    }
}

#[tokio::test]
async fn test_integration_regression_special_characters_in_names() {
    // Regression: Handle special characters in package names
    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
    let root = temp_dir.path().to_path_buf();

    let root_pkg = r#"{
        "name": "special-root",
        "version": "1.0.0",
        "private": true,
        "workspaces": ["packages/*"]
    }"#;
    tokio::fs::write(root.join("package.json"), root_pkg).await.expect("Failed to write root");

    // Create package-lock.json for NPM workspace detection
    let package_lock = r#"{
        "name": "special-root",
        "version": "1.0.0",
        "lockfileVersion": 3,
        "requires": true,
        "packages": {}
    }"#;
    tokio::fs::write(root.join("package-lock.json"), package_lock)
        .await
        .expect("Failed to write package-lock.json");

    tokio::fs::create_dir_all(root.join("packages")).await.expect("Failed to create packages");

    let pkg_dir = root.join("packages").join("special-pkg");
    tokio::fs::create_dir_all(&pkg_dir).await.expect("Failed to create pkg dir");
    let pkg = r#"{
        "name": "@scope/package-with-dashes_and_underscores.dots",
        "version": "1.0.0"
    }"#;
    tokio::fs::write(pkg_dir.join("package.json"), pkg).await.expect("Failed to write package");

    let config = PackageToolsConfig::default();
    let resolver = VersionResolver::new(root, config).await.expect("Failed to create resolver");

    let packages = resolver.discover_packages().await.expect("Failed to discover packages");
    assert_eq!(packages.len(), 1);
    assert_eq!(packages[0].name(), "@scope/package-with-dashes_and_underscores.dots");
}

// ============================================================================
// Summary Test - Full Integration
// ============================================================================

#[tokio::test]
async fn test_integration_full_workflow_end_to_end() {
    // This test validates the complete end-to-end workflow
    let (_temp, root) = create_complex_monorepo().await;
    let config = PackageToolsConfig::default();

    // Step 1: Initialize resolver
    let resolver = VersionResolver::new(root.clone(), config.clone())
        .await
        .expect("Failed to initialize resolver");

    assert!(resolver.is_monorepo());
    assert_eq!(resolver.strategy(), VersioningStrategy::Independent);
    assert_eq!(resolver.workspace_root(), &root);

    // Step 2: Discover packages
    let packages = resolver.discover_packages().await.expect("Failed to discover packages");
    assert_eq!(packages.len(), 5);

    // Step 3: Create changeset
    let mut changeset =
        Changeset::new("release/v1.1", VersionBump::Minor, vec!["production".to_string()]);
    changeset.add_package("@test/pkg-a");

    // Step 4: Resolve versions
    let resolution =
        resolver.resolve_versions(&changeset).await.expect("Failed to resolve versions");

    assert!(!resolution.updates.is_empty());
    assert_eq!(resolution.circular_dependencies.len(), 0);

    // Step 5: Preview (dry run)
    let preview = resolver.apply_versions(&changeset, true).await.expect("Failed to preview");

    assert!(preview.dry_run);
    assert_eq!(preview.modified_files.len(), 0);
    assert!(preview.summary.packages_updated > 0);

    // Step 6: Apply changes
    let result =
        resolver.apply_versions(&changeset, false).await.expect("Failed to apply versions");

    assert!(!result.dry_run);
    assert!(!result.modified_files.is_empty());
    assert_eq!(result.summary.packages_updated, preview.summary.packages_updated);

    // Step 7: Verify file system changes
    for path in &result.modified_files {
        assert!(tokio::fs::metadata(path).await.is_ok(), "Modified file should exist: {:?}", path);
    }

    // Step 8: Re-read and verify versions
    let updated_packages =
        resolver.discover_packages().await.expect("Failed to re-discover packages");

    let pkg_a =
        updated_packages.iter().find(|p| p.name() == "@test/pkg-a").expect("Should find pkg-a");

    assert_eq!(pkg_a.version().to_string(), "1.1.0", "Version should be updated");

    println!("✅ Full end-to-end workflow completed successfully");
    println!("   - Packages updated: {}", result.summary.packages_updated);
    println!("   - Direct updates: {}", result.summary.direct_updates);
    println!("   - Propagated updates: {}", result.summary.propagated_updates);
    println!("   - Files modified: {}", result.modified_files.len());
}