subc-control 0.42.2

Client-facing subc control-plane wire shapes.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
//! Opt-in config-gate client wire. Plans never commit until `config.apply` is
//! approved; a terminal's claim to have displayed a diff grants no authority.

use serde::{Deserialize, Serialize};
use std::collections::BTreeMap;
pub use subc_config::{ApprovalChannel, Digest, Generation, Plan};
pub use subc_protocol::config::ConfigDeclarationPending;

pub const CONFIG_GATE_CAPABILITY: &str = "config.gate";
pub const CONFIG_SETTINGS_CAPABILITY: &str = "config.settings/v1";

/// One approved-layer patch. Workspace and project edits currently produce
/// `layer_not_served`; daemon settings cannot be edited through this operation.
#[derive(Clone, Debug, PartialEq, Serialize)]
pub struct ConfigEdit {
    pub module_id: String,
    pub layer: String,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub workspace_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub project_id: Option<String>,
    pub path: String,
    #[serde(flatten)]
    pub action: ConfigEditAction,
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(untagged)]
pub enum ConfigEditAction {
    Set { set: serde_json::Value },
    Remove { remove: bool },
}

impl<'de> Deserialize<'de> for ConfigEdit {
    fn deserialize<D: serde::Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        #[derive(Deserialize)]
        #[serde(deny_unknown_fields)]
        struct Wire {
            module_id: String,
            layer: String,
            workspace_id: Option<String>,
            project_id: Option<String>,
            path: String,
            #[serde(default, deserialize_with = "present_value")]
            set: Option<serde_json::Value>,
            remove: Option<bool>,
        }
        fn present_value<'de, D: serde::Deserializer<'de>>(
            deserializer: D,
        ) -> Result<Option<serde_json::Value>, D::Error> {
            serde_json::Value::deserialize(deserializer).map(Some)
        }
        let wire = Wire::deserialize(deserializer)?;
        let action = match (wire.set, wire.remove) {
            (Some(set), None) => ConfigEditAction::Set { set },
            (None, Some(true)) => ConfigEditAction::Remove { remove: true },
            _ => return Err(serde::de::Error::custom("expected set or remove: true")),
        };
        Ok(Self {
            module_id: wire.module_id,
            layer: wire.layer,
            workspace_id: wire.workspace_id,
            project_id: wire.project_id,
            path: wire.path,
            action,
        })
    }
}

/// A field refusal is displayed verbatim and prevents applying the whole plan.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub struct ConfigPlanRefusal {
    pub module_id: String,
    pub path: String,
    pub code: String,
    pub message: String,
}

/// Standalone bodies keep additions out of the legacy exhaustive control enum.
/// Unknown request fields are refused, including caller-authored review claims.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(tag = "op", deny_unknown_fields)]
#[non_exhaustive]
pub enum ConfigControlRequest {
    #[serde(rename = "config.status")]
    Status {},
    #[serde(rename = "config.modules")]
    Modules {},
    #[serde(rename = "config.schema")]
    Schema { module_id: String },
    #[serde(rename = "config.show")]
    Show {
        module_id: String,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        project_id: Option<String>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        through: Option<ConfigThrough>,
    },
    #[serde(rename = "config.watch")]
    Watch {
        #[serde(default, skip_serializing_if = "Option::is_none")]
        modules: Option<Vec<String>>,
    },
    #[serde(rename = "config.plan")]
    Plan {
        #[serde(default, skip_serializing_if = "Option::is_none")]
        base_generations: Option<BTreeMap<String, u64>>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        edits: Option<Vec<ConfigEdit>>,
    },
    #[serde(rename = "config.plan_get")]
    PlanGet { digest: Digest },
    #[serde(rename = "config.plan_discard")]
    PlanDiscard { digest: Digest },
    #[serde(rename = "config.apply")]
    Apply { digest: Digest },
    #[serde(rename = "config.stamp")]
    Stamp {},
    #[serde(rename = "config.unstamp")]
    Unstamp {},
    #[serde(rename = "config.history")]
    History {},
    #[serde(rename = "config.rollback")]
    Rollback { generation: u64 },
    #[serde(rename = "config.place_program")]
    PlaceProgram {
        module_id: String,
        path: String,
        sha256: Digest,
        /// Offline manifest reported by the placement tool, not executed by the daemon.
        #[serde(default, skip_serializing_if = "Option::is_none")]
        manifest: Option<serde_json::Value>,
    },
}

impl ConfigControlRequest {
    pub fn op(&self) -> &'static str {
        match self {
            Self::Status {} => "config.status",
            Self::Modules {} => "config.modules",
            Self::Schema { .. } => "config.schema",
            Self::Show { .. } => "config.show",
            Self::Watch { .. } => "config.watch",
            Self::Plan { .. } => "config.plan",
            Self::PlanGet { .. } => "config.plan_get",
            Self::PlanDiscard { .. } => "config.plan_discard",
            Self::Apply { .. } => "config.apply",
            Self::Stamp {} => "config.stamp",
            Self::Unstamp {} => "config.unstamp",
            Self::History {} => "config.history",
            Self::Rollback { .. } => "config.rollback",
            Self::PlaceProgram { .. } => "config.place_program",
        }
    }
}

/// An inclusive upper bound on the layers merged by `config.show`.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ConfigThrough {
    Default,
    User,
    Workspace,
}

/// A user-file observation failure, separate from the approved settings status.
#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigFileError {
    pub code: String,
    pub message: String,
}

impl ConfigFileError {
    pub fn new(code: impl Into<String>, message: impl Into<String>) -> Self {
        Self {
            code: code.into(),
            message: message.into(),
        }
    }
}

/// Status strings are open: clients display an unfamiliar status as raw text.
#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigModule {
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub declaration_pending: Option<ConfigDeclarationPending>,
    pub module_id: String,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub display_name: Option<String>,
    pub gated: bool,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub schema_digest: Option<Digest>,
    pub status: String,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub status_reason: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub file_error: Option<ConfigFileError>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub approved_generation: Option<u64>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub active_generation: Option<u64>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub pending_plan: Option<Digest>,
}

/// Parsed layer documents, never file paths, raw bytes, or proposal values.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigSettingsLayer {
    pub layer: subc_config::Layer,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub workspace_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub project_id: Option<String>,
    pub document: serde_json::Value,
}

impl ConfigSettingsLayer {
    pub fn new(layer: subc_config::Layer, document: serde_json::Value) -> Self {
        Self {
            layer,
            workspace_id: None,
            project_id: None,
            document,
        }
    }
}

/// A watch always begins with a full resync, including after reconnecting.
/// A resync may arrive at any time and replaces the reader's entire state.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(tag = "event", rename_all = "snake_case")]
#[non_exhaustive]
pub enum ConfigWatchEvent {
    Resync {
        modules: Vec<ConfigModule>,
        stamped: bool,
    },
    Change {
        module_id: String,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        declaration_pending: Option<ConfigDeclarationPending>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        approved_generation: Option<u64>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        active_generation: Option<u64>,
        status: String,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        status_reason: Option<String>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        file_error: Option<ConfigFileError>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        schema_digest: Option<Digest>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        pending_plan: Option<Digest>,
    },
}

impl ConfigWatchEvent {
    pub fn change(row: &ConfigModule) -> Self {
        Self::Change {
            module_id: row.module_id.clone(),
            declaration_pending: row.declaration_pending.clone(),
            approved_generation: row.approved_generation,
            active_generation: row.active_generation,
            status: row.status.clone(),
            status_reason: row.status_reason.clone(),
            file_error: row.file_error.clone(),
            schema_digest: row.schema_digest.clone(),
            pending_plan: row.pending_plan.clone(),
        }
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigWatchResponse {
    op: ConfigWatchOp,
    #[serde(flatten)]
    pub event: ConfigWatchEvent,
}

impl ConfigWatchResponse {
    pub fn new(event: ConfigWatchEvent) -> Self {
        Self {
            op: ConfigWatchOp::Watch,
            event,
        }
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
enum ConfigWatchOp {
    #[serde(rename = "config.watch")]
    Watch,
}

/// The trusted surface renders the entire plan, not just the digest.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigPlanView {
    pub digest: Digest,
    pub base_revision: u64,
    pub plan: Plan,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub refusals: Vec<ConfigPlanRefusal>,
}

impl ConfigPlanView {
    pub fn new(plan: Plan) -> Result<Self, subc_config::CanonicalError> {
        Ok(Self {
            digest: plan.digest()?,
            base_revision: plan.base_revision,
            plan,
            refusals: Vec::new(),
        })
    }
}

/// The durable review channel for a retained or pruned generation.
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigApprovalRecord {
    pub generation: u64,
    pub channel: ApprovalChannel,
}

impl ConfigApprovalRecord {
    pub fn new(generation: u64, channel: ApprovalChannel) -> Self {
        Self {
            generation,
            channel,
        }
    }
}

/// Diagnostic strings are extensible; they never grant approval authority.
#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
pub struct ConfigStatus {
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub declaration_pending: BTreeMap<String, ConfigDeclarationPending>,
    pub approval_channels: Vec<ConfigApprovalRecord>,
    pub state: String,
    pub integrity: String,
    pub revision: u64,
    pub base_revision: u64,
    pub pending_proposals: u64,
    pub anchor_pending: bool,
    pub ungated_modules: Vec<String>,
    pub ungated_inputs: Vec<String>,
    pub gated_modules: Vec<String>,
    pub interpreter_only_covered: Vec<String>,
    pub approved_but_inactive: Vec<serde_json::Value>,
    pub development_switches: Vec<String>,
    pub missing_approval_surfaces: Vec<String>,
    pub warnings: Vec<String>,
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(tag = "op")]
#[non_exhaustive]
pub enum ConfigControlResponse {
    #[serde(rename = "config.status")]
    Status { status: ConfigStatus },
    #[serde(rename = "config.modules")]
    Modules {
        modules: Vec<ConfigModule>,
        stamped: bool,
    },
    #[serde(rename = "config.schema")]
    Schema {
        module_id: String,
        schema_digest: Digest,
        schema: serde_json::Value,
    },
    #[serde(rename = "config.show")]
    Show {
        module_id: String,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        project_id: Option<String>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        through: Option<ConfigThrough>,
        stamped: bool,
        base_generation: u64,
        effective: serde_json::Value,
        sources: std::collections::BTreeMap<String, subc_config::Layer>,
        layers: Vec<ConfigSettingsLayer>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        file_error: Option<ConfigFileError>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        pending_plan: Option<Digest>,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        declaration_pending: Option<ConfigDeclarationPending>,
    },
    #[serde(rename = "config.plan")]
    Plan { view: ConfigPlanView },
    #[serde(rename = "config.plan_get")]
    PlanGet { view: ConfigPlanView },
    #[serde(rename = "config.plan_discard")]
    PlanDiscard {},
    #[serde(rename = "config.stamp")]
    Stamp { view: ConfigPlanView },
    #[serde(rename = "config.unstamp")]
    Unstamp { view: ConfigPlanView },
    #[serde(rename = "config.rollback")]
    Rollback { view: ConfigPlanView },
    #[serde(rename = "config.apply")]
    Applied {
        generation: u64,
        #[serde(default)]
        restart_required: bool,
    },
    #[serde(rename = "config.history")]
    History {
        generations: Vec<Generation>,
        pruned: Vec<serde_json::Value>,
    },
    #[serde(rename = "config.place_program")]
    ProgramPlaced {
        #[serde(default, skip_serializing_if = "Option::is_none")]
        generation: Option<u64>,
    },
}

#[cfg(test)]
mod tests {
    #[test]
    fn config_wire_declaration_pending_reaches_settings_watch() {
        use super::*;
        let row = ConfigModule {
            module_id: "sample".into(),
            declaration_pending: Some(ConfigDeclarationPending::default()),
            ..ConfigModule::default()
        };
        let event = ConfigWatchResponse::new(ConfigWatchEvent::change(&row));
        let mut wire = serde_json::to_value(&event).unwrap();
        assert_eq!(wire["declaration_pending"], serde_json::json!({}));
        wire["declaration_pending"]["future_member"] = serde_json::json!(true);
        assert_eq!(
            serde_json::from_value::<ConfigWatchResponse>(wire).unwrap(),
            event
        );
    }
    #[test]
    fn config_wire_existing_bodies_remain_byte_identical() {
        use super::*;
        assert_eq!(
            serde_json::to_vec(&ConfigControlRequest::Plan {
                base_generations: None,
                edits: None,
            })
            .unwrap(),
            br#"{"op":"config.plan"}"#
        );
        assert_eq!(
            serde_json::to_vec(&ConfigControlRequest::Status {}).unwrap(),
            br#"{"op":"config.status"}"#
        );
        assert_eq!(
            serde_json::to_vec(&ConfigControlRequest::History {}).unwrap(),
            br#"{"op":"config.history"}"#
        );
        assert_eq!(
            serde_json::to_vec(&ConfigControlResponse::History {
                generations: vec![],
                pruned: vec![]
            })
            .unwrap(),
            br#"{"op":"config.history","generations":[],"pruned":[]}"#
        );
        assert_eq!(serde_json::to_vec(&ConfigControlResponse::Status { status: ConfigStatus::default() }).unwrap(), br#"{"op":"config.status","status":{"approval_channels":[],"state":"","integrity":"","revision":0,"base_revision":0,"pending_proposals":0,"anchor_pending":false,"ungated_modules":[],"ungated_inputs":[],"gated_modules":[],"interpreter_only_covered":[],"approved_but_inactive":[],"development_switches":[],"missing_approval_surfaces":[],"warnings":[]}}"#);
    }

    #[test]
    fn config_wire_settings_status_is_open_and_selectors_are_strict() {
        use super::*;
        let module: ConfigModule = serde_json::from_value(
            serde_json::json!({"module_id":"sample","gated":true,"status":"future_status"}),
        )
        .unwrap();
        assert_eq!(module.status, "future_status");
        assert!(serde_json::from_value::<ConfigControlRequest>(
            serde_json::json!({"op":"config.show","module_id":"sample","through":"project"})
        )
        .is_err());
        let event = ConfigWatchResponse::new(ConfigWatchEvent::Resync {
            modules: vec![module],
            stamped: false,
        });
        assert_eq!(
            serde_json::from_slice::<ConfigWatchResponse>(&serde_json::to_vec(&event).unwrap())
                .unwrap(),
            event
        );
    }

    #[test]
    fn config_wire_file_errors_are_optional_and_tolerate_extensions() {
        let legacy = json!({"module_id":"sample","gated":true,"status":"adopted"});
        let mut row: ConfigModule = serde_json::from_value(legacy).unwrap();
        assert!(row.file_error.is_none());
        let error = ConfigFileError::new("value_invalid", "invalid settings");
        row.file_error = Some(error.clone());
        let change = ConfigWatchResponse::new(ConfigWatchEvent::change(&row));
        let mut wire = serde_json::to_value(&change).unwrap();
        assert_eq!(
            wire["file_error"],
            json!({"code":"value_invalid","message":"invalid settings"})
        );
        wire["file_error"]["future"] = json!(true);
        assert_eq!(
            serde_json::from_value::<ConfigWatchResponse>(wire).unwrap(),
            change
        );
        let mut shown = json!({"op":"config.show","module_id":"sample","stamped":true,"base_generation":1,"effective":{},"sources":{},"layers":[]});
        assert!(matches!(
            serde_json::from_value::<ConfigControlResponse>(shown.clone()).unwrap(),
            ConfigControlResponse::Show {
                file_error: None,
                ..
            }
        ));
        shown["file_error"] = serde_json::to_value(&error).unwrap();
        assert!(
            matches!(serde_json::from_value::<ConfigControlResponse>(shown).unwrap(), ConfigControlResponse::Show {file_error:Some(found), ..} if found == error)
        );
    }

    #[test]
    fn config_wire_program_placement_names_and_optional_generation() {
        use super::*;
        let body = serde_json::json!({"op":"config.place_program","module_id":"demo","path":"/bin/demo","sha256":format!("sha256:{}", "a".repeat(64))});
        let request: ConfigControlRequest = serde_json::from_value(body.clone()).unwrap();
        assert_eq!(request.op(), "config.place_program");
        assert_eq!(serde_json::to_value(request).unwrap(), body);
        assert!(matches!(
            serde_json::from_value::<ConfigControlResponse>(
                serde_json::json!({"op":"config.place_program"})
            )
            .unwrap(),
            ConfigControlResponse::ProgramPlaced { generation: None }
        ));
        let response = ConfigControlResponse::ProgramPlaced {
            generation: Some(3),
        };
        assert_eq!(
            serde_json::to_value(response).unwrap(),
            serde_json::json!({"op":"config.place_program","generation":3})
        );
    }
    #[test]
    fn config_wire_applied_reports_restart_required_and_defaults_absent_to_false() {
        use super::*;
        let response = ConfigControlResponse::Applied {
            generation: 7,
            restart_required: true,
        };
        assert_eq!(
            serde_json::to_value(response).unwrap(),
            serde_json::json!({"op":"config.apply", "generation":7, "restart_required":true})
        );
        assert_eq!(
            serde_json::from_value::<ConfigControlResponse>(
                serde_json::json!({"op":"config.apply", "generation":7})
            )
            .unwrap(),
            ConfigControlResponse::Applied {
                generation: 7,
                restart_required: false,
            }
        );
        assert_eq!(
            serde_json::to_value(ConfigControlResponse::Applied {
                generation: 7,
                restart_required: false,
            })
            .unwrap()["restart_required"],
            false
        );
    }

    #[test]
    fn config_wire_status_and_history_preserve_unverified_approval_channel() {
        use super::*;
        let channel = ApprovalChannel::UnverifiedDevelopmentDesktop;
        let mut status = ConfigStatus::default();
        status
            .approval_channels
            .push(ConfigApprovalRecord::new(1, channel));
        let generation = Generation::new(
            1,
            channel,
            subc_config::raw_digest(b"plan"),
            subc_config::InputVector::default(),
            subc_config::Changeset::new(),
        );
        for response in [
            ConfigControlResponse::Status { status },
            ConfigControlResponse::History {
                generations: vec![generation],
                pruned: vec![],
            },
        ] {
            let encoded = serde_json::to_string(&response).unwrap();
            assert!(encoded.contains("unverified_development_desktop"));
            assert_eq!(
                serde_json::from_str::<ConfigControlResponse>(&encoded).unwrap(),
                response
            );
        }
    }
    use super::*;
    use serde_json::json;

    #[test]
    fn config_wire_requests_are_strict_and_round_trip() {
        for body in [
            json!({"op":"config.status"}),
            json!({"op":"config.modules"}),
            json!({"op":"config.schema","module_id":"sample-reader"}),
            json!({"op":"config.show","module_id":"sample-reader"}),
            json!({"op":"config.show","module_id":"sample-reader","project_id":"sample-project","through":"workspace"}),
            json!({"op":"config.watch"}),
            json!({"op":"config.watch","modules":["sample-reader"]}),
            json!({"op":"config.plan"}),
            json!({"op":"config.plan_get", "digest":subc_config::raw_digest(b"plan")}),
            json!({"op":"config.plan_discard", "digest":subc_config::raw_digest(b"plan")}),
            json!({"op":"config.apply", "digest":subc_config::raw_digest(b"plan")}),
            json!({"op":"config.stamp"}),
            json!({"op":"config.unstamp"}),
            json!({"op":"config.history"}),
            json!({"op":"config.rollback", "generation":4}),
        ] {
            let request: ConfigControlRequest = serde_json::from_value(body.clone()).unwrap();
            assert_eq!(body["op"], request.op());
            assert_eq!(serde_json::to_value(&request).unwrap(), body);
            let mut claimed = body;
            claimed["reviewed"] = json!(true);
            assert!(serde_json::from_value::<ConfigControlRequest>(claimed).is_err());
        }
        assert!(
            serde_json::from_value::<ConfigControlRequest>(json!({"op":"config.apply"})).is_err()
        );
    }

    #[test]
    fn config_wire_plan_view_and_status_tolerate_reply_extensions() {
        let plan = Plan::new(7, 3, "daemon", Default::default(), Default::default());
        let view = ConfigPlanView::new(plan.clone()).unwrap();
        assert_eq!(view.digest, plan.digest().unwrap());
        let response = ConfigControlResponse::Stamp { view };
        let mut body = serde_json::to_value(&response).unwrap();
        body["future"] = json!(true);
        assert_eq!(
            serde_json::from_value::<ConfigControlResponse>(body).unwrap(),
            response
        );
        let status = ConfigControlResponse::Status {
            status: ConfigStatus::default(),
        };
        assert_eq!(
            serde_json::from_value::<ConfigControlResponse>(serde_json::to_value(&status).unwrap())
                .unwrap(),
            status
        );
    }

    #[test]
    fn config_wire_edit_actions_are_exclusive_and_null_is_not_absence() {
        let base = json!({"module_id":"demo","layer":"user","path":"/limit"});
        for action in [
            json!({"set":0}),
            json!({"set":false}),
            json!({"set":null}),
            json!({"remove":true}),
        ] {
            let mut value = base.clone();
            value
                .as_object_mut()
                .unwrap()
                .extend(action.as_object().unwrap().clone());
            let edit: ConfigEdit = serde_json::from_value(value.clone()).unwrap();
            assert_eq!(serde_json::to_value(edit).unwrap(), value);
        }
        for action in [
            json!({}),
            json!({"set":1,"remove":true}),
            json!({"remove":false}),
            json!({"remove":true,"extra":1}),
        ] {
            let mut value = base.clone();
            value
                .as_object_mut()
                .unwrap()
                .extend(action.as_object().unwrap().clone());
            assert!(serde_json::from_value::<ConfigEdit>(value).is_err());
        }
        let request: ConfigControlRequest =
            serde_json::from_value(json!({"op":"config.plan"})).unwrap();
        assert_eq!(
            serde_json::to_vec(&request).unwrap(),
            br#"{"op":"config.plan"}"#
        );
    }

    #[test]
    fn config_wire_empty_refusals_preserve_legacy_view_bytes() {
        let plan = Plan::new(7, 3, "daemon", Default::default(), Default::default());
        let view = ConfigPlanView::new(plan.clone()).unwrap();
        let legacy = json!({"digest":plan.digest().unwrap(),"base_revision":7,"plan":plan});
        assert_eq!(serde_json::to_value(&view).unwrap(), legacy);
        assert_eq!(
            serde_json::from_value::<ConfigPlanView>(legacy).unwrap(),
            view
        );
        assert_eq!(
            serde_json::to_string(&ConfigControlResponse::PlanDiscard {}).unwrap(),
            r#"{"op":"config.plan_discard"}"#
        );
    }
}