1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
use crate::cpu_kernel::{CpuKernel, ScalarKernel};
use core::convert::TryInto;
use core::marker::PhantomData;
/// Pre-computed mask table: `BIT_MASK[n]` equals the lower `n` bits set,
/// i.e. `(1u64 << n) - 1` for `n` in `0..=64`. Kept for the tests that verify
/// mask values directly; `mask_lower_bits` computes the mask instead of
/// loading it.
#[cfg(test)]
const BIT_MASK: [u64; 65] = {
let mut table = [0u64; 65];
let mut i: u32 = 1;
while i < 64 {
table[i as usize] = (1u64 << i) - 1;
i += 1;
}
table[64] = u64::MAX;
table
};
/// Zstandard encodes some types of data in a way that the data must be read
/// back to front to decode it properly. `BitReaderReversed` provides a
/// convenient interface to do that.
pub struct BitReaderReversed<'s, K: CpuKernel = ScalarKernel> {
/// Start offset (in bytes) of the 8-byte source window currently
/// loaded into `bit_container`. Decreases monotonically as bytes
/// are consumed: `refill` walks it backward toward 0 by
/// `bits_consumed / 8`, and `bits_remaining()` uses
/// `index * 8 + (64 - bits_consumed)` to compute how many stream
/// bits remain. The byte at `source[index]` is the LSB of the
/// `from_le_bytes` u64 in `bit_container`; the byte at
/// `source[index + 7]` is the MSB (= the next stream bit at
/// position 63 of `bit_container`, before any consumption).
///
/// `pub(crate)` so the HUF 4-stream burst hot loop in
/// `decoding::literals_section_decoder` can run upstream zstd's
/// `ip[s] -= nb_bytes; bits[s] = MEM_read64(ip[s]) | 1` reload
/// pattern directly against the byte stream — see
/// [`Self::bits_consumed`] for the broader rationale.
pub(crate) index: usize,
/// How many bits have been consumed from `bit_container`.
///
/// `pub(crate)` so the HUF 4-stream hot loop in
/// `decoding::literals_section_decoder` can lift the reader state
/// into a local `bits[4]` register layout (upstream zstd parity with
/// `huf_decompress.c:HUF_decompress4X1_usingDTable_internal_fast_c_loop`):
/// inside the burst, all symbol-decode work happens against a
/// `bits[s]` u64 that fuses the decoder state with pending input
/// bits, and the field is written back only at the burst boundary.
/// Outside the burst the field is treated as opaque internal state.
pub(crate) bits_consumed: u8,
/// How many bits have been consumed past the end of the input. Will be zero until all the input
/// has been read.
extra_bits: usize,
/// The source data to read from.
///
/// `pub(crate)` — paired with [`Self::index`], the HUF 4-stream
/// burst hot loop needs direct slice access for the per-iter
/// upstream zstd-pattern reload (`MEM_read64(source[ip..ip+8])`).
pub(crate) source: &'s [u8],
/// The reader doesn't read directly from the source, it reads bits from here, and the container
/// is "refilled" as it's emptied.
///
/// `pub(crate)` — see [`Self::bits_consumed`] for the rationale.
pub(crate) bit_container: u64,
/// Phantom marker for the CPU kernel type parameter `K`. Zero-sized;
/// drives monomorphisation of methods that route through `K::mask_lower_bits`
/// without forcing the struct itself to carry runtime kernel state.
_kernel: PhantomData<K>,
}
impl<'s, K: CpuKernel> BitReaderReversed<'s, K> {
/// How many bits are left to read by the reader.
pub fn bits_remaining(&self) -> isize {
self.index as isize * 8 + (64 - self.bits_consumed as isize) - self.extra_bits as isize
}
pub fn new(source: &'s [u8]) -> BitReaderReversed<'s, K> {
BitReaderReversed {
index: source.len(),
bits_consumed: 64,
source,
bit_container: 0,
extra_bits: 0,
_kernel: PhantomData,
}
}
/// Refill the bit container with up to 64 fresh bits from `source`.
///
/// Hot path (mid-stream, `self.index >= bytes_consumed`) is `#[inline(always)]`
/// and folds into every caller — three operations: subtract index, mask
/// off byte-aligned bit count, load 8 bytes. The pre-PR version wore a
/// blanket `#[cold]` annotation which actively penalised the hot path
/// (refill fires roughly every 2 sequences during sequence decode, so
/// it is NOT cold). The rare edge cases — running out of source, going
/// past the start of the stream, exhausting all useful bits — branch
/// out to `refill_slow` which keeps the `#[cold] #[inline(never)]`
/// treatment they actually deserve.
#[inline(always)]
fn refill(&mut self) {
let bytes_consumed = self.bits_consumed as usize / 8;
if bytes_consumed == 0 {
return;
}
if self.index >= bytes_consumed {
// We can safely move the window contained in `bit_container` down by `bytes_consumed`
// If the reader wasn't byte aligned, the byte that was partially read is now in the highest order bits in the `bit_container`
self.index -= bytes_consumed;
// Some bits of the `bits_container` might have been consumed already because we read the window byte aligned
self.bits_consumed &= 7;
self.bit_container =
u64::from_le_bytes((&self.source[self.index..][..8]).try_into().unwrap());
} else {
self.refill_slow();
}
// Assert that at least `56 = 64 - 8` bits are available to read.
debug_assert!(self.bits_consumed < 8);
}
/// End-of-stream refill paths — runs when the next 8-byte window would
/// underflow the source buffer. Kept `#[cold] #[inline(never)]` so the
/// hot mid-stream path in [`refill`] folds into call sites without
/// dragging these branches along.
#[cold]
#[inline(never)]
fn refill_slow(&mut self) {
if self.index > 0 {
// Read the last portion of source into the `bit_container`
if self.source.len() >= 8 {
self.bit_container = u64::from_le_bytes((&self.source[..8]).try_into().unwrap());
} else {
let mut value = [0; 8];
value[..self.source.len()].copy_from_slice(self.source);
self.bit_container = u64::from_le_bytes(value);
}
self.bits_consumed -= 8 * self.index as u8;
self.index = 0;
self.bit_container <<= self.bits_consumed;
self.extra_bits += self.bits_consumed as usize;
self.bits_consumed = 0;
} else if self.bits_consumed < 64 {
// Shift out already used bits and fill up with zeroes
self.bit_container <<= self.bits_consumed;
self.extra_bits += self.bits_consumed as usize;
self.bits_consumed = 0;
} else {
// All useful bits have already been read and more than 64 bits have been consumed, all we now do is return zeroes
self.extra_bits += self.bits_consumed as usize;
self.bits_consumed = 0;
self.bit_container = 0;
}
}
/// Read `n` number of bits from the source. Will read at most 56 bits.
/// If there are no more bits to be read from the source zero bits will be returned instead.
#[inline(always)]
pub fn get_bits(&mut self, n: u8) -> u64 {
if self.bits_consumed + n > 64 {
self.refill();
}
let value = self.peek_bits(n);
self.consume(n);
value
}
/// Ensure at least `n` bits are available for subsequent unchecked reads.
/// After calling this, it is safe to call [`get_bits_unchecked`](Self::get_bits_unchecked)
/// for a combined total of up to `n` bits without individual refill checks.
///
/// `n` must be at most 56.
#[inline(always)]
pub fn ensure_bits(&mut self, n: u8) {
debug_assert!(n <= 56);
if self.bits_consumed + n > 64 {
self.refill();
}
}
/// Read `n` bits from the source **without** checking whether a refill is
/// needed. The caller **must** guarantee enough bits are available (e.g. via
/// a prior [`ensure_bits`](Self::ensure_bits) call).
#[inline(always)]
pub fn get_bits_unchecked(&mut self, n: u8) -> u64 {
debug_assert!(n <= 56);
debug_assert!(
self.bits_consumed + n <= 64,
"get_bits_unchecked: not enough bits (consumed={}, requested={})",
self.bits_consumed,
n
);
let value = self.peek_bits(n);
self.consume(n);
value
}
/// Get the next `n` bits from the source without consuming them.
/// Caller is responsible for making sure that `n` many bits have been refilled.
///
/// Branchless: when `n == 0` the mask is zero so the result is zero
/// without a dedicated check. `wrapping_shr` avoids a debug-mode
/// panic when the computed shift equals 64 (which happens legitimately
/// when `bits_consumed == 0` and `n == 0`).
#[inline(always)]
pub fn peek_bits(&mut self, n: u8) -> u64 {
// n == 0 is valid (branchless no-op); otherwise the caller must
// guarantee bits_consumed + n <= 64 via ensure_bits / get_bits.
debug_assert!(
n == 0 || self.bits_consumed + n <= 64,
"peek_bits: not enough bits (consumed={}, requested={})",
self.bits_consumed,
n
);
let shift_by = (64u8 - self.bits_consumed).wrapping_sub(n);
K::mask_lower_bits(self.bit_container.wrapping_shr(shift_by as u32), n)
}
/// Get the next `n1` `n2` and `n3` bits from the source without consuming them.
/// Caller is responsible for making sure that `sum` many bits have been refilled.
///
/// # Contract
/// `sum` **must** equal `n1 + n2 + n3`. This is enforced by `debug_assert`
/// but not checked in release builds for performance.
///
/// Branchless: when all widths are zero the masks are zero, producing (0, 0, 0).
#[inline(always)]
pub fn peek_bits_triple(&mut self, sum: u8, n1: u8, n2: u8, n3: u8) -> (u64, u64, u64) {
debug_assert_eq!(
u16::from(sum),
u16::from(n1) + u16::from(n2) + u16::from(n3),
"peek_bits_triple: sum ({}) must equal n1+n2+n3 ({}+{}+{})",
sum,
n1,
n2,
n3
);
debug_assert!(
sum == 0 || self.bits_consumed + sum <= 64,
"peek_bits_triple: not enough bits (consumed={}, requested={})",
self.bits_consumed,
sum
);
// all_three contains bits like this: |XXXX..XXX111122223333|
// Where XXX are already consumed bytes, 1/2/3 are bits of the respective value
// Lower bits are to the right
let shift_by = (64u8 - self.bits_consumed).wrapping_sub(sum);
let all_three = self.bit_container.wrapping_shr(shift_by as u32);
// The kernel was chosen where this decode was dispatched, so the split
// is the monomorph's own instruction sequence. The reader used to carry
// the choice as a flag and branch on it here, once per sequence.
K::extract_triple(all_three, n1, n2, n3)
}
/// BMI2-scoped variant of [`peek_bits`]. The whole body executes
/// in `#[target_feature(enable = "bmi2")]` scope, so `_bzhi_u64`
/// inlines as a single `bzhi` instruction at the caller site
/// instead of crossing the `mask_lower_bits_bmi2_impl` CALL
/// boundary (the issue documented in #279 round 3).
///
/// Use from any caller that is itself `#[target_feature(bmi2)]`-
/// scoped and has verified the runtime CPU supports BMI2.
///
/// # Safety
/// Caller MUST ensure BMI2 is available on the running CPU. The
/// `bzhi` instruction faults with #UD on hardware that does not
/// advertise BMI2.
#[cfg(target_arch = "x86_64")]
#[target_feature(enable = "bmi2")]
#[inline]
#[allow(dead_code)]
pub(crate) unsafe fn peek_bits_bmi2(&mut self, n: u8) -> u64 {
debug_assert!(
n == 0 || self.bits_consumed + n <= 64,
"peek_bits_bmi2: not enough bits (consumed={}, requested={})",
self.bits_consumed,
n
);
let shift_by = (64u8 - self.bits_consumed).wrapping_sub(n);
core::arch::x86_64::_bzhi_u64(self.bit_container.wrapping_shr(shift_by as u32), n as u32)
}
/// Consume `n` bits from the source.
#[inline(always)]
pub fn consume(&mut self, n: u8) {
self.bits_consumed += n;
debug_assert!(self.bits_consumed <= 64);
}
/// Same as calling get_bits three times but slightly more performant.
///
/// Uses a single conditional refill (via [`ensure_bits`](Self::ensure_bits))
/// instead of unconditionally refilling, avoiding redundant work when the
/// bit container already holds enough bits.
#[inline(always)]
pub fn get_bits_triple(&mut self, n1: u8, n2: u8, n3: u8) -> (u64, u64, u64) {
// Compute in u16 to avoid u8 overflow (max realistic sum is ~26,
// but the type system allows up to 3×255).
let sum_wide = u16::from(n1) + u16::from(n2) + u16::from(n3);
if sum_wide <= 56 {
let sum = sum_wide as u8;
self.ensure_bits(sum);
let triple = self.peek_bits_triple(sum, n1, n2, n3);
self.consume(sum);
return triple;
}
(self.get_bits(n1), self.get_bits(n2), self.get_bits(n3))
}
}
#[cfg(test)]
mod tests;