strided-view 0.7.2

Device-agnostic strided view types and metadata operations (ported from Julia StridedViews.jl).
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
use super::*;

#[test]
fn empty_views_use_dangling_base_pointers_for_extreme_offsets() {
    let dims = [0usize];
    let strides = [1isize];
    let data: [f64; 0] = [];
    let view = StridedView::<f64>::new(&data, &dims, &strides, isize::MAX).unwrap();
    assert_eq!(view.ptr(), empty_const_ptr());

    let mut data: [f64; 0] = [];
    let view = StridedViewMut::new(&mut data, &dims, &strides, isize::MAX).unwrap();
    assert_eq!(view.ptr(), empty_const_ptr());
    assert_eq!(view.as_mut_ptr(), empty_mut_ptr());

    let array = StridedArray::<f64>::from_parts(Vec::new(), &dims, &strides, isize::MAX).unwrap();
    assert_eq!(array.view().ptr(), empty_const_ptr());

    let mut array =
        StridedArray::<f64>::from_parts(Vec::new(), &dims, &strides, isize::MAX).unwrap();
    let view = array.view_mut();
    assert_eq!(view.ptr(), empty_const_ptr());
    assert_eq!(view.as_mut_ptr(), empty_mut_ptr());
}
use num_complex::Complex64;

#[test]
fn test_col_major_strides() {
    assert_eq!(col_major_strides(&[3, 4]).as_slice(), &[1, 3]);
    assert_eq!(col_major_strides(&[2, 3, 4]).as_slice(), &[1, 2, 6]);
}

#[test]
fn test_row_major_strides() {
    assert_eq!(row_major_strides(&[3, 4]).as_slice(), &[4, 1]);
    assert_eq!(row_major_strides(&[2, 3, 4]).as_slice(), &[12, 4, 1]);
}

#[test]
fn test_strided_view_new() {
    let data = vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0];
    let view = StridedView::<f64>::new(&data, &[2, 3], &[3, 1], 0).unwrap();
    assert_eq!(view.ndim(), 2);
    assert_eq!(view.dims(), &[2, 3]);
    assert_eq!(view.strides(), &[3, 1]);
    assert_eq!(view.len(), 6);
}

#[test]
fn test_strided_view_get() {
    let data = vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0];
    let view = StridedView::<f64>::new(&data, &[2, 3], &[3, 1], 0).unwrap();
    assert_eq!(view.get(&[0, 0]), 1.0);
    assert_eq!(view.get(&[0, 1]), 2.0);
    assert_eq!(view.get(&[0, 2]), 3.0);
    assert_eq!(view.get(&[1, 0]), 4.0);
    assert_eq!(view.get(&[1, 2]), 6.0);
}

#[test]
fn test_strided_view_col_major() {
    // Column-major: strides [1, 2] for 2x3
    let data = vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0];
    let view = StridedView::<f64>::new(&data, &[2, 3], &[1, 2], 0).unwrap();
    assert_eq!(view.get(&[0, 0]), 1.0); // data[0]
    assert_eq!(view.get(&[1, 0]), 2.0); // data[1]
    assert_eq!(view.get(&[0, 1]), 3.0); // data[2]
    assert_eq!(view.get(&[1, 1]), 4.0); // data[3]
    assert_eq!(view.get(&[0, 2]), 5.0); // data[4]
    assert_eq!(view.get(&[1, 2]), 6.0); // data[5]
}

#[test]
fn test_strided_view_permute() {
    let data = vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0];
    let view = StridedView::<f64>::new(&data, &[2, 3], &[3, 1], 0).unwrap();
    let perm = view.permute(&[1, 0]).unwrap();
    assert_eq!(perm.dims(), &[3, 2]);
    assert_eq!(perm.strides(), &[1, 3]);
    assert_eq!(perm.get(&[0, 0]), 1.0);
    assert_eq!(perm.get(&[1, 0]), 2.0);
    assert_eq!(perm.get(&[0, 1]), 4.0);
}

#[test]
fn test_strided_view_transpose_2d() {
    let data = vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0];
    let view = StridedView::<f64>::new(&data, &[2, 3], &[3, 1], 0).unwrap();
    let t = view.transpose_2d().unwrap();
    assert_eq!(t.dims(), &[3, 2]);
    assert_eq!(t.get(&[0, 0]), 1.0);
    assert_eq!(t.get(&[1, 0]), 2.0);
    assert_eq!(t.get(&[0, 1]), 4.0);
}

#[test]
fn test_strided_view_conj() {
    let data = vec![Complex64::new(1.0, 2.0), Complex64::new(3.0, 4.0)];
    let view = StridedView::<Complex64>::new(&data, &[2], &[1], 0).unwrap();
    let c = view.conj();
    assert_eq!(c.get(&[0]), Complex64::new(1.0, -2.0));
    assert_eq!(c.get(&[1]), Complex64::new(3.0, -4.0));
}

#[test]
fn test_strided_view_adjoint_2d() {
    let data = vec![
        Complex64::new(1.0, 2.0),
        Complex64::new(3.0, 4.0),
        Complex64::new(5.0, 6.0),
        Complex64::new(7.0, 8.0),
    ];
    // 2x2 row-major
    let view = StridedView::<Complex64>::new(&data, &[2, 2], &[2, 1], 0).unwrap();
    let adj = view.adjoint_2d().unwrap();
    assert_eq!(adj.dims(), &[2, 2]);
    // Adjoint: conj + transpose
    assert_eq!(adj.get(&[0, 0]), Complex64::new(1.0, -2.0));
    assert_eq!(adj.get(&[1, 0]), Complex64::new(3.0, -4.0));
    assert_eq!(adj.get(&[0, 1]), Complex64::new(5.0, -6.0));
}

#[test]
fn test_strided_view_broadcast() {
    let data = vec![1.0, 2.0, 3.0];
    let view = StridedView::<f64>::new(&data, &[1, 3], &[3, 1], 0).unwrap();
    let broad = view.broadcast(&[4, 3]).unwrap();
    assert_eq!(broad.dims(), &[4, 3]);
    for i in 0..4 {
        assert_eq!(broad.get(&[i, 0]), 1.0);
        assert_eq!(broad.get(&[i, 1]), 2.0);
        assert_eq!(broad.get(&[i, 2]), 3.0);
    }
}

#[test]
fn test_strided_view_mut() {
    let mut data = vec![0.0; 6];
    {
        let mut view = StridedViewMut::<f64>::new(&mut data, &[2, 3], &[3, 1], 0).unwrap();
        view.set(&[0, 0], 1.0);
        view.set(&[1, 2], 6.0);
    }
    assert_eq!(data[0], 1.0);
    assert_eq!(data[5], 6.0);
}

#[test]
fn test_strided_view_mut_as_view() {
    let mut data = vec![1.0, 2.0, 3.0];
    let vm = StridedViewMut::<f64>::new(&mut data, &[3], &[1], 0).unwrap();
    let v = vm.as_view();
    assert_eq!(v.get(&[0]), 1.0);
    assert_eq!(v.get(&[2]), 3.0);
}

#[test]
fn test_strided_tensor_col_major() {
    let t = StridedArray::<f64>::from_fn_col_major(&[2, 3], |idx| (idx[0] * 3 + idx[1]) as f64);
    assert_eq!(t.dims(), &[2, 3]);
    assert_eq!(t.strides(), &[1, 2]); // column-major
    assert_eq!(t.get(&[0, 0]), 0.0);
    assert_eq!(t.get(&[1, 0]), 3.0);
    assert_eq!(t.get(&[0, 1]), 1.0);
    assert_eq!(t.get(&[1, 2]), 5.0);
}

#[test]
fn test_strided_tensor_row_major() {
    let t = StridedArray::<f64>::from_fn_row_major(&[2, 3], |idx| (idx[0] * 3 + idx[1]) as f64);
    assert_eq!(t.dims(), &[2, 3]);
    assert_eq!(t.strides(), &[3, 1]); // row-major
    assert_eq!(t.get(&[0, 0]), 0.0);
    assert_eq!(t.get(&[0, 1]), 1.0);
    assert_eq!(t.get(&[1, 0]), 3.0);
    assert_eq!(t.get(&[1, 2]), 5.0);
}

#[test]
fn test_strided_tensor_view() {
    let t = StridedArray::<f64>::from_fn_col_major(&[2, 3], |idx| (idx[0] * 10 + idx[1]) as f64);
    let v = t.view();
    assert_eq!(v.get(&[0, 0]), 0.0);
    assert_eq!(v.get(&[1, 0]), 10.0);
    assert_eq!(v.get(&[0, 2]), 2.0);
}

#[test]
fn test_strided_tensor_view_mut() {
    let mut t = StridedArray::<f64>::col_major(&[2, 3]);
    {
        let mut vm = t.view_mut();
        vm.set(&[1, 2], 42.0);
    }
    assert_eq!(t.get(&[1, 2]), 42.0);
}

#[test]
fn test_strided_tensor_index() {
    let t = StridedArray::<f64>::from_fn_row_major(&[3, 4], |idx| (idx[0] * 10 + idx[1]) as f64);
    assert_eq!(t[&[0usize, 0] as &[usize]], 0.0);
    assert_eq!(t[&[2usize, 3] as &[usize]], 23.0);
}

#[test]
fn test_strided_tensor_index_mut() {
    let mut t = StridedArray::<f64>::row_major(&[2, 3]);
    t[&[1usize, 2] as &[usize]] = 99.0;
    assert_eq!(t.get(&[1, 2]), 99.0);
}

#[test]
fn test_validate_bounds_ok() {
    assert!(validate_bounds(6, &[2, 3], &[3, 1], 0).is_ok());
    assert!(validate_bounds(6, &[2, 3], &[1, 2], 0).is_ok());
}

#[test]
fn test_validate_bounds_out_of_range() {
    assert!(validate_bounds(5, &[2, 3], &[3, 1], 0).is_err());
}

#[test]
fn test_validate_bounds_empty() {
    assert!(validate_bounds(0, &[0, 3], &[3, 1], 0).is_ok());
}

#[test]
fn test_validate_bounds_with_offset() {
    assert!(validate_bounds(7, &[2, 3], &[3, 1], 1).is_ok());
    assert!(validate_bounds(6, &[2, 3], &[3, 1], 1).is_err());
}

#[test]
fn test_strided_tensor_3d() {
    let t = StridedArray::<f64>::from_fn_col_major(&[2, 3, 4], |idx| {
        (idx[0] * 100 + idx[1] * 10 + idx[2]) as f64
    });
    assert_eq!(t.ndim(), 3);
    assert_eq!(t.strides(), &[1, 2, 6]); // column-major
    assert_eq!(t.get(&[0, 0, 0]), 0.0);
    assert_eq!(t.get(&[1, 0, 0]), 100.0);
    assert_eq!(t.get(&[0, 1, 0]), 10.0);
    assert_eq!(t.get(&[0, 0, 1]), 1.0);
    assert_eq!(t.get(&[1, 2, 3]), 123.0);
}

// tensor4all/strided-rs#205: shape products and dense strides are checked.
const HUGE: usize = 1 << 62;

fn assert_overflow<T: std::fmt::Debug>(result: Result<T>) {
    assert!(
        matches!(result, Err(StridedError::OffsetOverflow)),
        "{result:?}"
    );
}

#[test]
fn test_try_constructors_reject_overflowing_shapes() {
    // [1 << 62, 4] wraps to 0 elements unchecked; [1 << 62, 2] overflows
    // only isize; the single extent above isize::MAX overflows the
    // stride conversion.
    for dims in [
        &[HUGE, 4][..],
        &[HUGE, 2],
        &[2, HUGE],
        &[isize::MAX as usize + 2, 1],
        &[usize::MAX, usize::MAX],
    ] {
        assert_overflow(StridedArray::<f64>::try_col_major(dims));
        assert_overflow(StridedArray::<f64>::try_row_major(dims));
        assert_overflow(StridedArray::<f64>::try_from_fn_col_major(dims, |_| {
            unreachable!("f is not called on error")
        }));
        assert_overflow(StridedArray::<f64>::try_from_fn_row_major(dims, |_| {
            unreachable!("f is not called on error")
        }));
        assert_overflow(StridedArray::<f64>::try_col_major_from_buffer(
            vec![1.0; 3],
            dims,
        ));
        assert_overflow(unsafe { StridedArray::<f64>::try_col_major_uninit(dims) });
        assert_overflow(unsafe {
            StridedArray::<f64>::try_col_major_from_buffer_uninit(vec![1.0; 3], dims)
        });
    }
}

#[test]
fn test_try_constructors_accept_valid_and_empty_shapes() {
    let a = StridedArray::<f64>::try_col_major(&[2, 3]).unwrap();
    assert_eq!((a.strides(), a.len()), (&[1isize, 2][..], 6));
    let a = StridedArray::<f64>::try_row_major(&[2, 3]).unwrap();
    assert_eq!(a.strides(), &[3, 1]);
    let a = StridedArray::<usize>::try_from_fn_row_major(&[2, 3], |i| 10 * i[0] + i[1]).unwrap();
    assert_eq!(a.get(&[1, 2]), 12);
    // A zero extent makes the array empty whatever the other extents.
    for dims in [&[HUGE, 4, 0][..], &[0, usize::MAX, usize::MAX]] {
        let a = StridedArray::<f64>::try_col_major(dims).unwrap();
        assert_eq!((a.len(), a.data().len()), (0, 0));
        assert!(a.is_empty());
        let a = StridedArray::<f64>::try_row_major(dims).unwrap();
        assert_eq!(a.len(), 0);
    }
}

#[test]
#[should_panic(expected = "col_major: shape overflows isize")]
fn test_col_major_panics_instead_of_wrapping() {
    // Unchecked, release builds wrapped the product to 0 and returned an
    // empty buffer behind a [1 << 62, 4] view.
    let _ = StridedArray::<f64>::col_major(&[HUGE, 4]);
}

#[test]
#[should_panic(expected = "column-major strides overflow isize")]
fn test_col_major_strides_panic_on_overflow() {
    let _ = col_major_strides(&[HUGE, 4]);
}

#[test]
fn test_dense_strides_of_an_empty_shape_do_not_panic() {
    assert_eq!(col_major_strides(&[3, 0, 5]).as_slice(), &[1, 3, 0]);
    assert_eq!(row_major_strides(&[3, 0, 5]).as_slice(), &[0, 5, 1]);
    // The overflowing step of an empty shape saturates.
    assert_eq!(
        col_major_strides(&[HUGE, 4, 0]).as_slice(),
        &[1, HUGE as isize, isize::MAX]
    );
    assert_eq!(
        row_major_strides(&[0, 4, HUGE]).as_slice(),
        &[isize::MAX, HUGE as isize, 1]
    );
}

#[test]
fn test_len_of_a_zero_sized_broadcast_view_is_zero() {
    // A zero extent wins before the product of the others.
    let data = [0.0f64; 1];
    let view = StridedView::<f64>::new(&data, &[usize::MAX, 2, 0], &[0, 0, 0], 0).unwrap();
    assert_eq!(view.len(), 0);
}

#[test]
#[should_panic(expected = "element count overflows usize")]
fn test_len_of_an_overflowing_broadcast_view_panics() {
    let data = [0.0f64; 1];
    let view = StridedView::<f64>::new(&data, &[HUGE, 4], &[0, 0], 0).unwrap();
    let _ = view.len();
}

#[test]
fn test_diagonal_view_2d() {
    // A[i,i] shape=[3,3] row-major strides=[3,1]
    // diagonal: shape=[3] strides=[4] (3+1)
    let data: Vec<f64> = (0..9).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[3, 3], &[3, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 1)]).unwrap();
    assert_eq!(diag.dims(), &[3]);
    assert_eq!(diag.strides(), &[4]);
    assert_eq!(diag.get(&[0]), 0.0); // A[0,0]
    assert_eq!(diag.get(&[1]), 4.0); // A[1,1]
    assert_eq!(diag.get(&[2]), 8.0); // A[2,2]
}

#[test]
fn test_diagonal_view_3d_adjacent() {
    // A[i,i,j] shape=[2,2,3] row-major strides=[6,3,1]
    // diagonal over (0,1): shape=[2,3] strides=[9,1] (6+3)
    let data: Vec<f64> = (0..12).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 2, 3], &[6, 3, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 1)]).unwrap();
    assert_eq!(diag.dims(), &[2, 3]);
    assert_eq!(diag.strides(), &[9, 1]);
    assert_eq!(diag.get(&[0, 0]), 0.0);
    assert_eq!(diag.get(&[0, 2]), 2.0);
    assert_eq!(diag.get(&[1, 0]), 9.0);
}

#[test]
fn test_diagonal_view_3d_non_adjacent() {
    // A[i,j,i] shape=[2,3,2] row-major strides=[6,2,1]
    // diagonal over (0,2): shape=[2,3] strides=[7,2] (6+1)
    let data: Vec<f64> = (0..12).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 3, 2], &[6, 2, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 2)]).unwrap();
    assert_eq!(diag.dims(), &[2, 3]);
    assert_eq!(diag.strides(), &[7, 2]);
    assert_eq!(diag.get(&[0, 0]), 0.0);
    assert_eq!(diag.get(&[0, 1]), 2.0);
    assert_eq!(diag.get(&[1, 0]), 7.0);
    assert_eq!(diag.get(&[1, 2]), 11.0);
}

#[test]
fn test_diagonal_view_two_pairs() {
    // A[i,j,i,j] shape=[2,3,2,3] -> A_diag[i,j] shape=[2,3]
    let data: Vec<f64> = (0..36).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 3, 2, 3], &[18, 6, 3, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 2), (1, 3)]).unwrap();
    assert_eq!(diag.dims(), &[2, 3]);
    assert_eq!(diag.strides(), &[21, 7]);
    assert_eq!(diag.get(&[0, 0]), 0.0);
    assert_eq!(diag.get(&[1, 1]), 28.0);
}

#[test]
fn test_diagonal_view_pairs_sharing_a_high_axis_fuse_all_three() {
    // Axis 2 is tied to both axis 0 and axis 1, so all three axes are one
    // diagonal: A[i,i,i] with stride 4 + 2 + 1. Folding axis 2 into both
    // survivors separately would reach offset 8 of a length-8 backing.
    let data: Vec<f64> = (0..8).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 2, 2], &[4, 2, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 2), (1, 2)]).unwrap();
    assert_eq!(diag.dims(), &[2]);
    assert_eq!(diag.strides(), &[7]);
    assert_eq!(diag.get(&[1]), 7.0);
}

#[test]
fn test_diagonal_view_repeated_pair_is_idempotent() {
    // Tying the same two axes twice is the same constraint as once; the
    // stride contribution must not be counted twice.
    let data: Vec<f64> = (0..8).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 2, 2], &[4, 2, 1], 0).unwrap();
    let once = view.diagonal_view(&[(0, 1)]).unwrap();
    let twice = view.diagonal_view(&[(0, 1), (1, 0)]).unwrap();
    assert_eq!(twice.dims(), once.dims());
    assert_eq!(twice.strides(), once.strides());
    assert_eq!(twice.strides(), &[6, 1]);
}

#[test]
fn test_diagonal_view_chained_pairs_are_order_independent() {
    // tensor4all/strided-rs#329: [(0, 1), (1, 2)] and [(1, 2), (0, 1)]
    // both describe A[i,i,i]. The second pair's low axis is the first
    // pair's removed axis, and its contribution must still reach axis 0.
    let data: Vec<f64> = (0..27).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[3, 3, 3], &[1, 3, 9], 0).unwrap();
    for pairs in [
        [(0, 1), (1, 2)],
        [(1, 2), (0, 1)],
        [(2, 1), (1, 0)],
        [(0, 2), (2, 1)],
    ] {
        let diag = view.diagonal_view(&pairs).unwrap();
        assert_eq!(diag.dims(), &[3], "{pairs:?}");
        assert_eq!(diag.strides(), &[13], "{pairs:?}");
        assert_eq!(diag.get(&[2]), 26.0, "{pairs:?}");
    }
}

#[test]
fn test_diagonal_view_chained_pairs_keep_free_axes_in_order() {
    // A[i,j,i,i] with a chain through axis 2: the free axis j stays second
    // and the fused dim is the minimum over the whole class.
    let dims = [3usize, 4, 2, 3];
    let strides = [1isize, 3, 12, 24];
    let data: Vec<f64> = (0..72).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &dims, &strides, 0).unwrap();
    let a = view.diagonal_view(&[(2, 3), (0, 2)]).unwrap();
    let b = view.diagonal_view(&[(0, 2), (2, 3)]).unwrap();
    for diag in [a, b] {
        assert_eq!(diag.dims(), &[2, 4]);
        assert_eq!(diag.strides(), &[37, 3]);
        assert_eq!(diag.get(&[1, 2]), 43.0);
    }
}

#[test]
fn test_diagonal_view_fuses_a_shared_low_axis_in_bounds() {
    // A[i,i,i] is [(0, 1), (0, 2)]: axis 0 carries both fused strides and
    // the result stays inside the backing.
    let data: Vec<f64> = (0..8).map(|x| x as f64).collect();
    let view = StridedView::<f64>::new(&data, &[2, 2, 2], &[4, 2, 1], 0).unwrap();
    let diag = view.diagonal_view(&[(0, 1), (0, 2)]).unwrap();
    assert_eq!(diag.dims(), &[2]);
    assert_eq!(diag.strides(), &[7]);
    assert_eq!(diag.get(&[0]), 0.0);
    assert_eq!(diag.get(&[1]), 7.0);
}

#[test]
fn test_custom_type_without_element_op_apply() {
    // Custom Copy type that does NOT implement ElementOpApply.
    // Should work with Identity views (StridedView<T> default).
    #[derive(Debug, Clone, Copy, PartialEq)]
    struct MyScalar(f64);

    impl Default for MyScalar {
        fn default() -> Self {
            MyScalar(0.0)
        }
    }

    // Create array with custom type
    let data = vec![MyScalar(1.0), MyScalar(2.0), MyScalar(3.0), MyScalar(4.0)];
    let arr = StridedArray::from_parts(data, &[2, 2], &[2, 1], 0).unwrap();

    // Access via Identity view (default)
    assert_eq!(arr.get(&[0, 0]), MyScalar(1.0));
    assert_eq!(arr.get(&[1, 0]), MyScalar(3.0));

    // Create view and access elements
    let view: StridedView<MyScalar> = arr.view();
    assert_eq!(view.get(&[0, 1]), MyScalar(2.0));

    // Permute view (metadata-only, no ElementOpApply needed)
    let perm = view.permute(&[1, 0]).unwrap();
    assert_eq!(perm.get(&[0, 0]), MyScalar(1.0));
    assert_eq!(perm.get(&[0, 1]), MyScalar(3.0)); // transposed
}

#[test]
#[should_panic(expected = "wrong number of indices")]
fn test_index_rejects_a_short_index() {
    let arr = StridedArray::from_parts(vec![0.0f64; 4], &[2, 2], &[2, 1], 0).unwrap();
    // Without the rank check this reads an element the index does not name.
    let _ = arr[&[1][..]];
}

#[test]
#[should_panic(expected = "wrong number of indices")]
fn test_view_get_rejects_a_short_index() {
    let data = vec![0.0f64; 4];
    let view = StridedView::<f64>::new(&data, &[2, 2], &[2, 1], 0).unwrap();
    let _ = view.get(&[1]);
}

#[test]
#[should_panic(expected = "out of bounds")]
fn test_view_set_rejects_an_out_of_bounds_index() {
    let mut data = vec![0.0f64; 4];
    let mut view = StridedViewMut::<f64>::new(&mut data, &[2, 2], &[2, 1], 0).unwrap();
    view.set(&[2, 0], 1.0);
}