store-io-engine 0.6.0

The store-io engine: volumes, regions, barriers with flush sharing, receipts, provisioning and A/B slot objects over any store-io platform.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
//! Raw ordered scans: the recovery read path.
//!
//! A scan reads a region from a block-aligned offset to the end of its data
//! area and hands every byte to the caller in order, as [`ScanItem::Data`].
//! It keeps several large reads in flight (direct I/O, never the page cache)
//! and delivers them strictly in order.
//!
//! A caller's visitor never runs while the scan holds a shared lane, which
//! every other call on the store may wait for: a visitor that calls the
//! store would wait on itself (one lane), or on a thread waiting for that
//! lane under the metadata lock. On a parallel lane (D-096), which no one
//! waits for, reads are delivered as they arrive; on a shared lane, the
//! scan collects every read in flight and puts the lane back before it
//! delivers them, and a bisection's items are held back until it has. The
//! store's own visitors (a read's pipeline and its bad-sector search),
//! which never call the store, are delivered as reads arrive on any lane.
//!
//! A scan never stops at bad data. A read the device cannot complete is
//! bisected down to single sectors (the device's logical block where the
//! probe knows it and direct I/O allows reads that small; else the store
//! block); every sector that still fails is reported as
//! [`ScanItem::Unreadable`] (adjacent ones merged), and the scan carries on
//! after it. Only the caller decides where valid data ends, by returning
//! [`ControlFlow::Break`] from its visitor.
//!
//! A background scan (a caller's `region.scan`, a copy's reader: R5.4)
//! reads in `background_io` pieces into buffers under the pool's
//! background cap, and admits each read through its call's issuer record
//! before it is submitted; the read's charge rides in its ring slot and is
//! released the moment its completion is collected. A read refused with
//! reads of the scan's own in flight reaps them first; with none in flight
//! it waits for the call's piece on another thread (a refusal is never
//! `QueueFull`, and never a wait on the scan's own reads). A visitor is
//! handed a drain hook: it collects every read of the scan in flight, so a
//! visitor that must block (a copy's reader on its full feed) blocks
//! holding none of the call's pieces.

use std::ops::ControlFlow;

use store_io_core::errno::is_media_error;
use store_io_core::error::{Error, ErrorContext, NotWrittenCause, Op, OsError};
use store_io_core::observe::Counter;
use store_io_platform::{IoBuf, IoOp, Platform, Queue, RawResult};

use crate::exec::{Lane, LaneGuard, Ran, run};
use crate::io::{ctx_range, not_written};
use crate::pace::Pace;
use crate::store::{LiveRegion, Store};

/// Reads kept in flight by a scan.
const DEPTH: usize = 8;

/// One step of a scan, in region order.
#[derive(Debug, PartialEq, Eq)]
pub enum ScanItem<'a> {
    /// Bytes read from the region, starting at region offset `offset`.
    Data {
        /// Region offset of `bytes[0]`.
        offset: u64,
        /// The bytes, exactly as the device returned them.
        bytes: &'a [u8],
    },
    /// The device could not read `[start, end)` (whole sectors: the
    /// device's logical blocks where known, else store blocks). The scan
    /// continues after it; the range is not "end of data".
    Unreadable {
        /// First unreadable byte.
        start: u64,
        /// One past the last unreadable byte.
        end: u64,
    },
}

/// How a scan ended.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
pub struct ScanSummary {
    /// One past the last byte delivered, as data or as unreadable.
    pub end: u64,
    /// Bytes reported unreadable.
    pub unreadable: u64,
    /// The visitor stopped the scan.
    pub stopped: bool,
}

/// Delivers items to the visitor in order, merging adjacent unreadable
/// ranges, and keeps the summary.
struct Emitter<F> {
    visit: F,
    bad: Option<(u64, u64)>,
    sum: ScanSummary,
    /// Items held back (copied) while a shared lane is held, replayed in
    /// order by [`Self::release`].
    held: Option<Vec<Held>>,
}

/// An item held back by [`Emitter::hold`].
enum Held {
    Data(u64, Vec<u8>),
    Unreadable(u64, u64),
}

/// A scan's visitor is handed each item and the drain hook, which collects
/// every read of the scan in flight (`false` if one could not be: the scan
/// then fails with the queue's error once the visitor returns).
impl<F: FnMut(ScanItem<'_>, &mut dyn FnMut() -> bool) -> ControlFlow<()>> Emitter<F> {
    /// Holds back every item until [`Self::release`].
    fn hold(&mut self) {
        let _held = self.held.get_or_insert_with(Vec::new);
    }

    /// Delivers the items held back, in order.
    fn release(&mut self) {
        // Delivered with the lane put back and nothing in flight.
        for item in self.held.take().unwrap_or_default() {
            match item {
                Held::Data(offset, bytes) => self.data(offset, &bytes, &mut || true),
                Held::Unreadable(start, end) => self.unreadable(start, end, &mut || true),
            }
        }
    }

    fn flush_bad(&mut self, drain: &mut dyn FnMut() -> bool) {
        if let Some((start, end)) = self.bad.take() {
            if (self.visit)(ScanItem::Unreadable { start, end }, drain).is_break() {
                self.sum.stopped = true;
            }
        }
    }

    fn data(&mut self, offset: u64, bytes: &[u8], drain: &mut dyn FnMut() -> bool) {
        if let Some(held) = &mut self.held {
            held.push(Held::Data(offset, bytes.to_vec()));
            return;
        }
        if self.sum.stopped {
            return;
        }
        self.flush_bad(drain);
        if self.sum.stopped || bytes.is_empty() {
            return;
        }
        self.sum.end = offset + bytes.len() as u64;
        if (self.visit)(ScanItem::Data { offset, bytes }, drain).is_break() {
            self.sum.stopped = true;
        }
    }

    fn unreadable(&mut self, start: u64, end: u64, drain: &mut dyn FnMut() -> bool) {
        if let Some(held) = &mut self.held {
            held.push(Held::Unreadable(start, end));
            return;
        }
        if self.sum.stopped || start >= end {
            return;
        }
        self.sum.unreadable += end - start;
        self.sum.end = end;
        match &mut self.bad {
            Some((_, e)) if *e == start => *e = end,
            _ => {
                self.flush_bad(drain);
                self.bad = Some((start, end));
            }
        }
    }

    /// The summary, the last unreadable range delivered (nothing is in
    /// flight by now).
    fn finish(mut self) -> ScanSummary {
        if !self.sum.stopped {
            self.flush_bad(&mut || true);
        }
        self.sum
    }
}

/// A read in flight, and its completion once it arrives.
struct Pending {
    start: u64,
    len: usize,
    done: Option<(RawResult<usize>, Option<IoBuf>)>,
    /// A background scan's charge for the read: released when its
    /// completion is collected (or the scan is abandoned).
    charge: Option<crate::pace::Held>,
}

fn read_error(raw: OsError, c: ErrorContext) -> Error {
    Error::Io {
        op: Op::Read,
        raw,
        ctx: c,
    }
}

impl<P: Platform> Store<P>
where
    P::Queue: Send,
{
    /// Scans `r` from `from` to `to` (clamped to the data area).
    /// A scan whose unreadable ranges are reported to the caller: each is
    /// counted once as a media error (internal rescans are not counted).
    pub(crate) fn scan_reported<F>(
        &self,
        r: &LiveRegion,
        from: u64,
        to: u64,
        mut visit: F,
    ) -> Result<ScanSummary, Error>
    where
        F: FnMut(ScanItem<'_>) -> ControlFlow<()>,
    {
        let obs = &self.inner.observer;
        // A caller's scan is a background call of its own (R5.4).
        let pace = self.inner.domain.new_pace();
        self.scan_region(r, from, to, true, pace.as_ref(), |item, _drain| {
            if matches!(item, ScanItem::Unreadable { .. }) {
                obs.add(Counter::MediaErrors, 1);
            }
            visit(item)
        })
    }

    /// Scans `r` from `from` to `to` (clamped to the data area). `calls_store`:
    /// the visitor may call the store (a caller's), so it never runs while a
    /// shared lane is held (the module's docs). `pace`: a background scan's
    /// call (the module's docs); `None` reads unpaced (a read's own search
    /// for its bad sectors, class `Read`).
    pub(crate) fn scan_region<F>(
        &self,
        r: &LiveRegion,
        from: u64,
        to: u64,
        calls_store: bool,
        pace: Option<&Pace>,
        visit: F,
    ) -> Result<ScanSummary, Error>
    where
        F: FnMut(ScanItem<'_>, &mut dyn FnMut() -> bool) -> ControlFlow<()>,
    {
        let block = self.block();
        let to = to.min(r.map.len());
        let c = ctx_range(r, from, to);
        if from % block != 0 {
            return Err(not_written(NotWrittenCause::Misaligned, c));
        }
        if from > to {
            return Err(not_written(NotWrittenCause::OutOfBounds, c));
        }
        let mut out = Emitter {
            visit,
            bad: None,
            held: None,
            sum: ScanSummary {
                end: from,
                ..ScanSummary::default()
            },
        };
        if from == to {
            return Ok(out.finish());
        }
        // A background scan's reads are always split at its piece (R5.4),
        // their buffers under the pool's background cap: with fewer than
        // `DEPTH` it runs shallower, as with fewer buffers of any kind.
        let chunk = pace.map_or(self.chunk(), |p| p.piece().min(self.chunk()));
        // From the class that holds a piece: a piece is any multiple of
        // 4 KiB (`background_io`), a class a power of two.
        let class = self.inner.pool.class_len(chunk).unwrap_or(chunk);
        let mut free: Vec<IoBuf> = (0..DEPTH)
            .map_while(|_| match pace {
                Some(_) => self.inner.pool.take_capped(chunk, class).ok(),
                None => self.inner.pool.take_within(chunk, chunk).ok(),
            })
            .collect();
        if free.is_empty() {
            return Err(not_written(NotWrittenCause::PoolExhausted, c));
        }
        let depth = free.len();
        let mut ring: Vec<Option<Pending>> = (0..depth).map(|_| None).collect();
        // Several reads in flight: a parallel lane (D-096). A range of one
        // buffer in one run, or a pipeline of one, is a single read: the
        // caller's lane.
        let several = to - from > chunk as u64 || r.map.run_end(from) < to;
        let take = || {
            if several && depth > 1 {
                self.par_lane(r, Op::Read)
            } else {
                self.lane(r, Op::Read)
            }
        };
        let first = take()?;
        // For a visitor that may call the store, on a shared lane every read
        // in flight is collected and the lane put back before anything is
        // delivered (the module's docs); each batch takes a lane again, a
        // parallel one if it can.
        let mut deferred = calls_store && first.is_shared();
        let mut lane: Option<LaneGuard<'_, P::Queue>> = Some(first);
        let file = &self.inner.file;
        let (mut submitted, mut delivered) = (0u64, 0u64);
        let mut next = from;
        let mut in_flight = 0usize;
        let mut failure: Option<Error> = None;
        // A drain hook's failure (the queue's), reported once the visitor
        // returns.
        let mut drained: Option<OsError> = None;
        loop {
            let progress = (submitted, delivered);
            // Keep the pipeline full.
            while failure.is_none() && !out.sum.stopped && next < to && !free.is_empty() {
                if lane.is_none() {
                    match take() {
                        Ok(l) => {
                            deferred = calls_store && l.is_shared();
                            lane = Some(l);
                        }
                        Err(e) => {
                            failure = Some(e);
                            break;
                        }
                    }
                }
                let Some(lane) = &mut lane else { break };
                let Some(mut buf) = free.pop() else { break };
                // Never across a run's end (one device operation each).
                let len = (to - next).min(chunk as u64).min(r.map.run_left(next)) as usize;
                // A background read is admitted before it is submitted.
                // Refused with reads of its own in flight, the scan reaps
                // them (below) and tries again; with none, the cap is held
                // by the call's piece on another thread, which completes.
                let charge = match pace {
                    None => None,
                    Some(p) => match p.try_charge() {
                        Some(ch) => Some(ch),
                        None if in_flight > 0 => {
                            free.push(buf);
                            break;
                        }
                        None => match p.wait_charge() {
                            Some(ch) => Some(ch),
                            None => {
                                free.push(buf);
                                failure = Some(not_written(NotWrittenCause::Interrupted, c));
                                break;
                            }
                        },
                    },
                };
                // `len ≤ chunk ≤ capacity`.
                let _fits = buf.set_len(len);
                let op = IoOp::Read {
                    file,
                    offset: r.map.locate(next, len as u64),
                    buf,
                };
                match lane.submit(op, submitted) {
                    Ok(()) => {
                        ring[(submitted % depth as u64) as usize] = Some(Pending {
                            start: next,
                            len,
                            done: None,
                            charge,
                        });
                        submitted += 1;
                        next += len as u64;
                        in_flight += 1;
                    }
                    Err(rejected) => {
                        if let Some(b) = rejected.buf {
                            free.push(b);
                        }
                        match rejected.raw {
                            None if in_flight > 0 => break,
                            None => failure = Some(not_written(NotWrittenCause::QueueFull, c)),
                            Some(raw) => failure = Some(read_error(raw, c)),
                        }
                    }
                }
            }
            if deferred {
                if let Some(l) = &mut lane {
                    if let Err(e) = collect(l, &mut ring, depth, &mut in_flight) {
                        // As below: the reads in flight keep their buffers.
                        return Err(read_error(e, c));
                    }
                }
                lane = None;
            }
            // Deliver everything that has arrived, in order.
            while delivered < submitted {
                let idx = (delivered % depth as u64) as usize;
                if ring[idx].as_ref().is_none_or(|p| p.done.is_none()) {
                    break;
                }
                let Some(Pending {
                    start,
                    len,
                    done: Some((result, buf)),
                    ..
                }) = ring[idx].take()
                else {
                    break;
                };
                delivered += 1;
                let mut buf = buf;
                debug_assert!(
                    buf.is_some() || result.is_err(),
                    "a read succeeded without its buffer (platform contract 1)"
                );
                // Counted as every read is: completed, with the bytes it
                // returned.
                if let (Ok(n), Some(_)) = (&result, &buf) {
                    self.inner.observer.add(Counter::Reads, 1);
                    self.inner
                        .observer
                        .add(Counter::ReadBytes, (*n).min(len) as u64);
                }
                if failure.is_none() && !out.sum.stopped {
                    match result {
                        Ok(n) => match &buf {
                            Some(b) => {
                                let n = n.min(len);
                                let mut drain = drainer(
                                    &mut lane,
                                    &mut ring,
                                    depth,
                                    &mut in_flight,
                                    &mut drained,
                                );
                                out.data(start, &b.as_slice()[..n], &mut drain);
                                // A short read inside the container: the
                                // rest could not be read.
                                out.unreadable(start + n as u64, start + len as u64, &mut drain);
                                drop(drain);
                                if let Some(e) = drained.take() {
                                    // As below: the reads in flight keep
                                    // their buffers.
                                    return Err(read_error(e, c));
                                }
                            }
                            // No bytes came back (a backend breaking
                            // platform contract 1): the scan stops, never
                            // reporting the range as unreadable media.
                            None => {
                                failure = Some(not_written(NotWrittenCause::Interrupted, c));
                            }
                        },
                        Err(raw) if is_media_error(raw) => {
                            // Bisect on an idle queue: first collect every
                            // read still in flight (they are delivered later,
                            // in order), then split the failed range.
                            if let Some(l) = &mut lane {
                                if let Err(e) = collect(l, &mut ring, depth, &mut in_flight) {
                                    return Err(read_error(e, c));
                                }
                            }
                            match buf.take() {
                                // On a lane kept (a parallel one, or any for the
                                // store's own visitors), delivering as it goes.
                                Some(b) if !deferred => {
                                    let bisected = match &mut lane {
                                        Some(l) => self
                                            .bisect(l, r, start, len as u64, b, &mut out, c, pace),
                                        None => Err(not_written(NotWrittenCause::Interrupted, c)),
                                    };
                                    match bisected {
                                        Ok(b) => buf = Some(b),
                                        Err(e) => failure = Some(e),
                                    }
                                }
                                // On a shared lane taken again, holding its
                                // items back until the lane is put back.
                                Some(b) => match self.lane(r, Op::Read) {
                                    Ok(mut l) => {
                                        out.hold();
                                        let bisected = self.bisect(
                                            &mut l, r, start, len as u64, b, &mut out, c, pace,
                                        );
                                        drop(l);
                                        out.release();
                                        match bisected {
                                            Ok(b) => buf = Some(b),
                                            // The visitor stopped inside the
                                            // held items: what failed after
                                            // was never asked for.
                                            Err(_) if out.sum.stopped => {}
                                            Err(e) => failure = Some(e),
                                        }
                                    }
                                    Err(e) => failure = Some(e),
                                },
                                // No buffer to bisect with (withheld by a
                                // backend that lost track of its kernel,
                                // platform contract 1): stop, never drop the range.
                                None => {
                                    failure = Some(not_written(NotWrittenCause::Interrupted, c));
                                }
                            }
                        }
                        Err(raw) => failure = Some(read_error(raw, c)),
                    }
                }
                if let Some(b) = buf {
                    free.push(b);
                }
            }
            if in_flight == 0 && (next >= to || out.sum.stopped || failure.is_some()) {
                break;
            }
            // Nothing in flight and nothing done this round: nothing ever
            // will be (a backstop: the scan fails, never spins).
            if in_flight == 0 && (submitted, delivered) == progress {
                return Err(not_written(NotWrittenCause::Interrupted, c));
            }
            if in_flight > 0 {
                // Only a lane kept (not deferred) has reads in flight here.
                let Some(l) = &mut lane else {
                    return Err(not_written(NotWrittenCause::Interrupted, c));
                };
                if let Err(e) = collect_one(l, &mut ring, depth, &mut in_flight) {
                    // The reads in flight still own their buffers; the queue
                    // keeps them. Nothing else is safe.
                    return Err(read_error(e, c));
                }
            }
        }
        match failure {
            Some(e) => Err(e),
            None => Ok(out.finish()),
        }
    }

    /// Reads `[start, start + len)` again in halves on an idle lane until each
    /// failing piece is one sector ([`Store::sector`]), delivering in order.
    /// Returns the buffer. A background scan's reads here are pieces of its
    /// call, one at a time (nothing of the scan's is in flight: the lane is
    /// idle), each charged until it completes.
    #[allow(clippy::too_many_arguments)]
    fn bisect<F>(
        &self,
        lane: &mut Lane<P::Queue>,
        r: &LiveRegion,
        start: u64,
        len: u64,
        mut buf: IoBuf,
        out: &mut Emitter<F>,
        c: ErrorContext,
        pace: Option<&Pace>,
    ) -> Result<IoBuf, Error>
    where
        F: FnMut(ScanItem<'_>, &mut dyn FnMut() -> bool) -> ControlFlow<()>,
    {
        if out.sum.stopped {
            return Ok(buf);
        }
        let sector = self.sector();
        // `len ≤ chunk ≤ capacity`.
        let _fits = buf.set_len(len as usize);
        let piece = pace.map(Pace::admit).transpose()?;
        let done = run(
            lane,
            IoOp::Read {
                file: &self.inner.file,
                offset: r.map.locate(start, len),
                buf,
            },
        );
        // Completed (or abandoned): its charge goes with it, before
        // anything is delivered.
        drop(piece);
        let (result, back) = match done {
            Ok(Ran::Done { buf, result }) => (result, buf),
            Ok(Ran::Abandoned(raw)) => return Err(read_error(raw, c)),
            Err((_refused, Some(raw))) => return Err(read_error(raw, c)),
            Err((_refused, None)) => return Err(not_written(NotWrittenCause::QueueFull, c)),
        };
        let Some(buf) = back else {
            // No buffer came back (a backend breaking platform contract 1;
            // an abandoned read is `Ran::Abandoned` above).
            return Err(match result {
                Err(raw) => read_error(raw, c),
                Ok(_) => not_written(NotWrittenCause::Interrupted, c),
            });
        };
        match result {
            Ok(n) => {
                let n = (n as u64).min(len);
                self.inner.observer.add(Counter::Reads, 1);
                self.inner.observer.add(Counter::ReadBytes, n);
                out.data(start, &buf.as_slice()[..n as usize], &mut || true);
                out.unreadable(start + n, start + len, &mut || true);
                Ok(buf)
            }
            Err(raw) if is_media_error(raw) => {
                if len <= sector {
                    out.unreadable(start, start + len, &mut || true);
                    return Ok(buf);
                }
                // Whole blocks while the piece spans several, so every read
                // of a block or more stays block-aligned; sectors only
                // inside one block.
                let block = self.block();
                let unit = if len > block { block } else { sector };
                let half = (len / unit).div_ceil(2) * unit;
                let buf = self.bisect(lane, r, start, half, buf, out, c, pace)?;
                self.bisect(lane, r, start + half, len - half, buf, out, c, pace)
            }
            // Below the store block the device refused the smaller read
            // (alignment) rather than failing on the media: this piece lies
            // in a block that failed with a media error, so it is reported
            // unreadable and the scan goes on.
            Err(_) if len < self.block() => {
                out.unreadable(start, start + len, &mut || true);
                Ok(buf)
            }
            Err(raw) => Err(read_error(raw, c)),
        }
    }
}

/// Waits for at least one completion and files it under its read.
fn collect_one<Q: Queue>(
    lane: &mut Lane<Q>,
    ring: &mut [Option<Pending>],
    depth: usize,
    in_flight: &mut usize,
) -> Result<(), OsError> {
    let _added = lane.wait(1)?;
    for comp in lane.done.drain() {
        *in_flight = in_flight.saturating_sub(1);
        if let Some(p) = ring[(comp.tag % depth as u64) as usize].as_mut() {
            p.done = Some((comp.result, comp.buf));
            // Completed: its piece is no longer in flight.
            p.charge = None;
        }
    }
    Ok(())
}

/// The drain hook a visitor is handed: collects every read of the scan in
/// flight (each charge released as its completion is collected) and says
/// whether none is left; a failed wait is kept in `err` for the scan.
fn drainer<'x, Q: Queue>(
    lane: &'x mut Option<LaneGuard<'_, Q>>,
    ring: &'x mut [Option<Pending>],
    depth: usize,
    in_flight: &'x mut usize,
    err: &'x mut Option<OsError>,
) -> impl FnMut() -> bool + 'x {
    move || {
        if err.is_none() {
            if let Some(l) = lane.as_mut() {
                if let Err(e) = collect(l, &mut *ring, depth, &mut *in_flight) {
                    *err = Some(e);
                }
            }
        }
        *in_flight == 0
    }
}

/// Waits for every read in flight.
fn collect<Q: Queue>(
    lane: &mut Lane<Q>,
    ring: &mut [Option<Pending>],
    depth: usize,
    in_flight: &mut usize,
) -> Result<(), OsError> {
    while *in_flight > 0 {
        collect_one(lane, ring, depth, in_flight)?;
    }
    Ok(())
}