stmo-cli 0.11.0

Turn Claude Code into a data analyst on sql.telemetry.mozilla.org
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
#![allow(clippy::missing_errors_doc)]

use crate::api::RedashClient;
use crate::models::{Query, QueryMetadata, Visualization, VisualizationMetadata};
use anyhow::{Context, Result, bail};
use std::collections::{HashMap, HashSet};
use std::fs;
use std::path::Path;
use std::sync::Arc;
use tokio::sync::Semaphore;
use tokio::task::JoinSet;

fn slugify(s: &str) -> String {
    s.to_lowercase()
        .chars()
        .map(|c| if c.is_alphanumeric() { c } else { '-' })
        .collect::<String>()
        .split('-')
        .filter(|s| !s.is_empty())
        .collect::<Vec<_>>()
        .join("-")
}

fn validate_enum_options(metadata: &crate::models::QueryMetadata, yaml_path: &str) -> Result<()> {
    for param in &metadata.options.parameters {
        if let Some(enum_opts) = &param.enum_options
            && enum_opts.contains("\\n")
        {
            bail!(
                "In {yaml_path}: parameter '{}' has enumOptions with escaped newlines. \
                Use YAML multiline format instead:\n\n\
                enumOptions: |-\n  option1\n  option2",
                param.name
            );
        }
    }
    Ok(())
}

// A local visualization with no `id` is an unsaved one the user is asking to
// create — it always counts as "different" regardless of what's on the
// server.
pub(crate) fn visualizations_differ(
    local: &[VisualizationMetadata],
    server: &[Visualization],
) -> bool {
    if local.len() != server.len() {
        return true;
    }

    for viz in local {
        let Some(id) = viz.id else {
            return true;
        };
        let Some(server_viz) = server.iter().find(|sv| sv.id == id) else {
            return true;
        };
        if viz.name != server_viz.name
            || viz.viz_type != server_viz.viz_type
            || viz.options != server_viz.options
            || viz.description != server_viz.description
        {
            return true;
        }
    }

    false
}

// Shared by `deploy` (deciding what to push) and `execute` (deciding whether
// to sync before running) — compares everything `deploy_one` actually pushes
// to Redash against what's already there, so "changed" means "differs from
// the server", not "differs from git's working tree".
pub(crate) fn tracked_query_differs(
    local_sql: &str,
    local_metadata: &QueryMetadata,
    server: &Query,
) -> bool {
    local_sql != server.sql
        || local_metadata.name != server.name
        || local_metadata.description != server.description
        || local_metadata.data_source_id != server.data_source_id
        || local_metadata.schedule != server.schedule
        || local_metadata.tags != server.tags
        || serde_json::to_value(&local_metadata.options).ok()
            != serde_json::to_value(&server.options).ok()
        || visualizations_differ(&local_metadata.visualizations, &server.visualizations)
}

fn read_local_query(id: u64, name: &str) -> Result<(String, QueryMetadata)> {
    let slug = slugify(name);
    let sql_path = format!("queries/{id}-{slug}.sql");
    let yaml_path = format!("queries/{id}-{slug}.yaml");

    let sql = fs::read_to_string(&sql_path).context(format!("Failed to read {sql_path}"))?;
    let metadata_content =
        fs::read_to_string(&yaml_path).context(format!("Failed to read {yaml_path}"))?;
    let metadata: QueryMetadata =
        serde_yaml::from_str(&metadata_content).context(format!("Failed to parse {yaml_path}"))?;

    Ok((sql, metadata))
}

async fn query_changed(client: &RedashClient, id: u64, name: &str) -> Result<bool> {
    let (sql, metadata) = read_local_query(id, name)?;
    let server = client
        .get_query(id)
        .await
        .context(format!("Failed to fetch query {id} from Redash"))?;
    Ok(tracked_query_differs(&sql, &metadata, &server))
}

const MAX_CONCURRENT_COMPARISONS: usize = 8;

// Compares every tracked query (except `id == 0`, which has nothing on the
// server yet and is always deployed) against its server copy, up to
// `MAX_CONCURRENT_COMPARISONS` GETs in flight at once. A query that fails to
// compare (deleted or archived server-side, unreadable local files, ...) is
// skipped with a warning rather than aborting the whole run.
async fn find_changed_queries(
    client: &RedashClient,
    all_queries: &[(u64, String)],
) -> HashSet<u64> {
    let total = all_queries.len();
    let semaphore = Arc::new(Semaphore::new(MAX_CONCURRENT_COMPARISONS));
    let mut join_set = JoinSet::new();
    let mut changed_ids = HashSet::new();

    for (id, name) in all_queries {
        let id = *id;
        if id == 0 {
            changed_ids.insert(id);
            continue;
        }

        let name = name.clone();
        let client = client.clone();
        let semaphore = Arc::clone(&semaphore);
        join_set.spawn(async move {
            let _permit = semaphore
                .acquire()
                .await
                .expect("semaphore is never closed");
            (id, query_changed(&client, id, &name).await)
        });
    }

    eprintln!("Comparing {total} tracked queries against Redash...");
    let mut compared = 0;

    while let Some(result) = join_set.join_next().await {
        compared += 1;
        match result {
            Ok((id, Ok(true))) => {
                changed_ids.insert(id);
            }
            Ok((_id, Ok(false))) => {}
            Ok((id, Err(e))) => {
                eprintln!("  ⚠ Skipping query {id}: {e}");
            }
            Err(join_err) => {
                eprintln!("  ⚠ A deploy comparison task failed unexpectedly: {join_err}");
            }
        }
        eprintln!("Compared {compared} / {total} queries...");
    }

    changed_ids
}

fn get_all_query_metadata_from_path(queries_dir: &Path) -> Result<Vec<(u64, String)>> {
    if !queries_dir.exists() {
        bail!("queries directory not found. Run 'stmo-cli fetch' first.");
    }

    let mut queries = Vec::new();
    let mut paths_by_id: HashMap<u64, Vec<String>> = HashMap::new();

    for entry in fs::read_dir(queries_dir).context("Failed to read queries directory")? {
        let entry = entry.context("Failed to read directory entry")?;
        let path = entry.path();

        if path.extension().is_some_and(|ext| ext == "yaml") {
            let metadata_content =
                fs::read_to_string(&path).context(format!("Failed to read {}", path.display()))?;

            let metadata: crate::models::QueryMetadata = serde_yaml::from_str(&metadata_content)
                .context(format!("Failed to parse {}", path.display()))?;

            paths_by_id
                .entry(metadata.id)
                .or_default()
                .push(path.display().to_string());
            queries.push((metadata.id, metadata.name));
        }
    }

    bail_on_duplicate_ids(&paths_by_id)?;

    queries.sort_by_key(|(id, _)| *id);

    Ok(queries)
}

fn bail_on_duplicate_ids(paths_by_id: &HashMap<u64, Vec<String>>) -> Result<()> {
    let mut conflicts: Vec<_> = paths_by_id
        .iter()
        .filter(|(_, paths)| paths.len() > 1)
        .collect();

    if conflicts.is_empty() {
        return Ok(());
    }

    conflicts.sort_by_key(|(id, _)| **id);
    let details: Vec<String> = conflicts
        .into_iter()
        .map(|(id, paths)| {
            let mut paths = paths.clone();
            paths.sort();
            format!("  id {id}: {}", paths.join(", "))
        })
        .collect();

    bail!(
        "Multiple local files claim the same id — resolve the conflict before deploying:\n{}",
        details.join("\n")
    );
}

fn get_all_query_metadata() -> Result<Vec<(u64, String)>> {
    get_all_query_metadata_from_path(Path::new("queries"))
}

async fn deploy_visualizations(
    client: &RedashClient,
    query_id: u64,
    visualizations: &[crate::models::VisualizationMetadata],
    server_visualizations: &[crate::models::Visualization],
) -> Result<()> {
    let mut matched_server_ids: HashSet<u64> = HashSet::new();
    for viz in visualizations {
        if let Some(id) = viz.id {
            matched_server_ids.insert(id);
            let viz_to_update = crate::models::Visualization {
                id,
                name: viz.name.clone(),
                viz_type: viz.viz_type.clone(),
                options: viz.options.clone(),
                description: viz.description.clone(),
            };
            client.update_visualization(&viz_to_update).await?;
            println!("    ✓ Updated visualization: {} (ID: {id})", viz.name);
        } else {
            let server_match = server_visualizations
                .iter()
                .find(|sv| sv.viz_type == viz.viz_type && !matched_server_ids.contains(&sv.id));
            if let Some(server_viz) = server_match {
                matched_server_ids.insert(server_viz.id);
                let viz_to_update = crate::models::Visualization {
                    id: server_viz.id,
                    name: viz.name.clone(),
                    viz_type: viz.viz_type.clone(),
                    options: viz.options.clone(),
                    description: viz.description.clone(),
                };
                client.update_visualization(&viz_to_update).await?;
                println!(
                    "    ✓ Updated visualization: {} (ID: {})",
                    viz_to_update.name, server_viz.id
                );
            } else {
                let viz_to_create = crate::models::CreateVisualization {
                    query_id,
                    name: viz.name.clone(),
                    viz_type: viz.viz_type.clone(),
                    options: viz.options.clone(),
                    description: viz.description.clone(),
                };
                let created = client
                    .create_visualization(query_id, &viz_to_create)
                    .await?;
                println!(
                    "    ✓ Created visualization: {} (ID: {})",
                    created.name, created.id
                );
            }
        }
    }
    Ok(())
}

#[allow(clippy::too_many_lines)]
pub async fn deploy_one(client: &RedashClient, id: u64, name: &str) -> Result<Query> {
    let slug = slugify(name);
    let sql_path = format!("queries/{id}-{slug}.sql");
    let yaml_path = format!("queries/{id}-{slug}.yaml");

    if !Path::new(&sql_path).exists() {
        bail!("Query SQL file not found: {sql_path}");
    }
    if !Path::new(&yaml_path).exists() {
        bail!("Query metadata file not found: {yaml_path}");
    }

    let sql = fs::read_to_string(&sql_path).context(format!("Failed to read {sql_path}"))?;

    let metadata_content =
        fs::read_to_string(&yaml_path).context(format!("Failed to read {yaml_path}"))?;

    let metadata: crate::models::QueryMetadata =
        serde_yaml::from_str(&metadata_content).context(format!("Failed to parse {yaml_path}"))?;

    validate_enum_options(&metadata, &yaml_path)?;

    let result_query = if id == 0 {
        let create_query = crate::models::CreateQuery {
            name: metadata.name.clone(),
            description: metadata.description.clone(),
            sql,
            data_source_id: metadata.data_source_id,
            schedule: metadata.schedule.clone(),
            options: Some(metadata.options.clone()),
            tags: metadata.tags.clone(),
            is_archived: false,
            is_draft: false,
        };
        let created = client.create_query(&create_query).await?;
        let fetched = client.get_query(created.id).await?;
        let new_slug = slugify(&fetched.name);
        let new_base = format!("queries/{}-{new_slug}", fetched.id);
        fs::write(format!("{new_base}.sql"), &fetched.sql)
            .context(format!("Failed to write {new_base}.sql"))?;
        let mut new_visualizations: Vec<crate::models::VisualizationMetadata> = fetched
            .visualizations
            .iter()
            .map(crate::models::VisualizationMetadata::from)
            .collect();
        new_visualizations.sort_by_key(|v| v.id);
        let new_metadata = crate::models::QueryMetadata {
            id: fetched.id,
            name: fetched.name.clone(),
            description: fetched.description.clone(),
            data_source_id: fetched.data_source_id,
            user_id: fetched.user.as_ref().map(|u| u.id),
            schedule: fetched.schedule.clone(),
            options: fetched.options.clone(),
            visualizations: new_visualizations,
            tags: fetched.tags.clone(),
        };
        let yaml_content =
            serde_yaml::to_string(&new_metadata).context("Failed to serialize query metadata")?;
        fs::write(format!("{new_base}.yaml"), yaml_content)
            .context(format!("Failed to write {new_base}.yaml"))?;
        fs::remove_file(&sql_path).context(format!("Failed to delete {sql_path}"))?;
        fs::remove_file(&yaml_path).context(format!("Failed to delete {yaml_path}"))?;
        println!("  ✓ Created new query: {} - {name}", fetched.id);
        println!("    Renamed: 0-{slug}.* → {}-{new_slug}.*", fetched.id);
        fetched
    } else {
        let query = Query {
            id: metadata.id,
            name: metadata.name.clone(),
            description: metadata.description.clone(),
            sql,
            data_source_id: metadata.data_source_id,
            user: None,
            schedule: metadata.schedule.clone(),
            options: metadata.options.clone(),
            visualizations: vec![],
            tags: metadata.tags.clone(),
            is_archived: false,
            is_draft: false,
            updated_at: String::new(),
            created_at: String::new(),
        };
        let result = client.create_or_update_query(&query).await?;
        let fetched = client.get_query(id).await?;
        let mut updated_visualizations: Vec<crate::models::VisualizationMetadata> = fetched
            .visualizations
            .iter()
            .map(crate::models::VisualizationMetadata::from)
            .collect();
        updated_visualizations.sort_by_key(|v| v.id);
        let updated_metadata = crate::models::QueryMetadata {
            id: fetched.id,
            name: fetched.name.clone(),
            description: fetched.description.clone(),
            data_source_id: fetched.data_source_id,
            user_id: fetched.user.as_ref().map(|u| u.id),
            schedule: fetched.schedule.clone(),
            options: fetched.options.clone(),
            visualizations: updated_visualizations,
            tags: fetched.tags.clone(),
        };
        let yaml_content = serde_yaml::to_string(&updated_metadata)
            .context("Failed to serialize query metadata")?;
        fs::write(&yaml_path, yaml_content).context(format!("Failed to write {yaml_path}"))?;
        println!("{id} - {name}");
        result
    };

    deploy_visualizations(
        client,
        result_query.id,
        &metadata.visualizations,
        &result_query.visualizations,
    )
    .await?;

    Ok(result_query)
}

pub async fn deploy(client: &RedashClient, query_ids: Vec<u64>, all: bool) -> Result<()> {
    let all_queries = get_all_query_metadata()?;

    let queries_to_deploy = if !query_ids.is_empty() {
        let ids_set: HashSet<_> = query_ids.iter().copied().collect();
        let filtered: Vec<_> = all_queries
            .into_iter()
            .filter(|(id, _)| ids_set.contains(id))
            .collect();

        if filtered.is_empty() {
            bail!("None of the specified query IDs were found in queries/ directory");
        }

        println!("Deploying {} specific queries...", filtered.len());
        for (id, name) in &filtered {
            println!("{id} - {name}");
        }
        println!();

        filtered
    } else if all {
        println!("Deploying all {} queries...\n", all_queries.len());
        all_queries
    } else {
        let changed_ids = find_changed_queries(client, &all_queries).await;

        if changed_ids.is_empty() {
            println!("No changed queries detected.");
            println!("Tip: Use --all to deploy all queries regardless of differences.");
            return Ok(());
        }

        let filtered: Vec<_> = all_queries
            .into_iter()
            .filter(|(id, _)| changed_ids.contains(id))
            .collect();

        println!("Deploying {} changed queries...", filtered.len());
        for (id, name) in &filtered {
            println!("{id} - {name}");
        }
        println!();

        filtered
    };

    for (id, name) in &queries_to_deploy {
        deploy_one(client, *id, name).await?;
    }

    println!("\n✓ All resources deployed successfully");

    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_validate_enum_options_rejects_escaped_newlines() {
        let metadata = crate::models::QueryMetadata {
            id: 1,
            name: "Test Query".to_string(),
            description: None,
            data_source_id: 1,
            user_id: None,
            schedule: None,
            options: crate::models::QueryOptions {
                parameters: vec![crate::models::Parameter {
                    name: "test_param".to_string(),
                    title: "Test Param".to_string(),
                    param_type: "enum".to_string(),
                    enum_options: Some("option1\\noption2\\noption3".to_string()),
                    query_id: Some(1),
                    value: None,
                    multi_values_options: None,
                }],
            },
            visualizations: vec![],
            tags: None,
        };

        let result = validate_enum_options(&metadata, "test.yaml");
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(err_msg.contains("escaped newlines"));
        assert!(err_msg.contains("test_param"));
        assert!(err_msg.contains("YAML multiline format"));
    }

    #[test]
    fn test_validate_enum_options_accepts_multiline() {
        let metadata = crate::models::QueryMetadata {
            id: 1,
            name: "Test Query".to_string(),
            description: None,
            data_source_id: 1,
            user_id: None,
            schedule: None,
            options: crate::models::QueryOptions {
                parameters: vec![crate::models::Parameter {
                    name: "test_param".to_string(),
                    title: "Test Param".to_string(),
                    param_type: "enum".to_string(),
                    enum_options: Some("option1\noption2\noption3".to_string()),
                    query_id: Some(1),
                    value: None,
                    multi_values_options: None,
                }],
            },
            visualizations: vec![],
            tags: None,
        };

        let result = validate_enum_options(&metadata, "test.yaml");
        assert!(result.is_ok());
    }

    #[test]
    fn test_validate_enum_options_accepts_no_enum() {
        let metadata = crate::models::QueryMetadata {
            id: 1,
            name: "Test Query".to_string(),
            description: None,
            data_source_id: 1,
            user_id: None,
            schedule: None,
            options: crate::models::QueryOptions {
                parameters: vec![crate::models::Parameter {
                    name: "test_param".to_string(),
                    title: "Test Param".to_string(),
                    param_type: "text".to_string(),
                    enum_options: None,
                    query_id: Some(1),
                    value: None,
                    multi_values_options: None,
                }],
            },
            visualizations: vec![],
            tags: None,
        };

        let result = validate_enum_options(&metadata, "test.yaml");
        assert!(result.is_ok());
    }

    fn make_query_metadata(name: &str, data_source_id: u64) -> QueryMetadata {
        QueryMetadata {
            id: 1,
            name: name.to_string(),
            description: None,
            data_source_id,
            user_id: None,
            schedule: None,
            options: crate::models::QueryOptions { parameters: vec![] },
            visualizations: vec![],
            tags: None,
        }
    }

    fn make_server_query(sql: &str, name: &str, data_source_id: u64) -> Query {
        Query {
            id: 1,
            name: name.to_string(),
            description: None,
            sql: sql.to_string(),
            data_source_id,
            user: None,
            schedule: None,
            options: crate::models::QueryOptions { parameters: vec![] },
            visualizations: vec![],
            tags: None,
            is_archived: false,
            is_draft: false,
            updated_at: String::new(),
            created_at: String::new(),
        }
    }

    #[test]
    fn test_tracked_query_differs_false_when_identical() {
        let metadata = make_query_metadata("Q", 1);
        let server = make_server_query("SELECT 1", "Q", 1);
        assert!(!tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_sql_differs() {
        let metadata = make_query_metadata("Q", 1);
        let server = make_server_query("SELECT 1", "Q", 1);
        assert!(tracked_query_differs("SELECT 2", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_name_differs() {
        let metadata = make_query_metadata("Local Name", 1);
        let server = make_server_query("SELECT 1", "Server Name", 1);
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_data_source_id_differs() {
        let metadata = make_query_metadata("Q", 1);
        let server = make_server_query("SELECT 1", "Q", 2);
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_parameters_differ() {
        let mut metadata = make_query_metadata("Q", 1);
        metadata.options.parameters.push(crate::models::Parameter {
            name: "p".to_string(),
            title: "P".to_string(),
            param_type: "text".to_string(),
            value: None,
            enum_options: None,
            query_id: None,
            multi_values_options: None,
        });
        let server = make_server_query("SELECT 1", "Q", 1);
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_description_differs() {
        let mut metadata = make_query_metadata("Q", 1);
        metadata.description = Some("local".to_string());
        let mut server = make_server_query("SELECT 1", "Q", 1);
        server.description = Some("server".to_string());
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_schedule_differs() {
        let mut metadata = make_query_metadata("Q", 1);
        metadata.schedule = Some(crate::models::Schedule {
            interval: Some(3600),
            time: None,
            day_of_week: None,
            until: None,
        });
        let server = make_server_query("SELECT 1", "Q", 1);
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_tags_differ() {
        let mut metadata = make_query_metadata("Q", 1);
        metadata.tags = Some(vec!["a".to_string()]);
        let server = make_server_query("SELECT 1", "Q", 1);
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    fn make_visualization(id: u64, name: &str) -> Visualization {
        Visualization {
            id,
            name: name.to_string(),
            viz_type: "CHART".to_string(),
            options: serde_json::json!({}),
            description: None,
        }
    }

    fn make_visualization_metadata(id: Option<u64>, name: &str) -> VisualizationMetadata {
        VisualizationMetadata {
            id,
            name: name.to_string(),
            viz_type: "CHART".to_string(),
            options: serde_json::json!({}),
            description: None,
        }
    }

    #[test]
    fn test_visualizations_differ_false_when_identical() {
        let local = vec![make_visualization_metadata(Some(1), "Chart")];
        let server = vec![make_visualization(1, "Chart")];
        assert!(!visualizations_differ(&local, &server));
    }

    #[test]
    fn test_visualizations_differ_true_when_name_differs() {
        let local = vec![make_visualization_metadata(Some(1), "New name")];
        let server = vec![make_visualization(1, "Chart")];
        assert!(visualizations_differ(&local, &server));
    }

    #[test]
    fn test_visualizations_differ_true_when_local_has_no_id() {
        // No id means "create new" — always counts as a difference, even
        // though a same-named viz happens to already exist server-side.
        let local = vec![make_visualization_metadata(None, "Chart")];
        let server = vec![make_visualization(1, "Chart")];
        assert!(visualizations_differ(&local, &server));
    }

    #[test]
    fn test_visualizations_differ_true_when_counts_differ() {
        let local = vec![make_visualization_metadata(Some(1), "Chart")];
        let server = vec![];
        assert!(visualizations_differ(&local, &server));
    }

    #[test]
    fn test_visualizations_differ_true_when_referenced_id_missing_server_side() {
        let local = vec![make_visualization_metadata(Some(99), "Chart")];
        let server = vec![make_visualization(1, "Chart")];
        assert!(visualizations_differ(&local, &server));
    }

    #[test]
    fn test_tracked_query_differs_true_when_visualization_only_change() {
        let mut metadata = make_query_metadata("Q", 1);
        metadata.visualizations = vec![make_visualization_metadata(Some(1), "New name")];
        let mut server = make_server_query("SELECT 1", "Q", 1);
        server.visualizations = vec![make_visualization(1, "Chart")];
        assert!(tracked_query_differs("SELECT 1", &metadata, &server));
    }

    const MINIMAL_QUERY_METADATA_YAML: &str =
        "data_source_id: 1\noptions:\n  parameters: []\nvisualizations: []\n";

    #[test]
    fn test_get_all_query_metadata_from_path_basic() {
        let temp_dir = tempfile::TempDir::new().unwrap();
        let dir = temp_dir.path();

        fs::write(
            dir.join("42-my-query.yaml"),
            format!("id: 42\nname: my-query\n{MINIMAL_QUERY_METADATA_YAML}"),
        )
        .unwrap();

        let metadata = get_all_query_metadata_from_path(dir).unwrap();
        assert_eq!(metadata, vec![(42, "my-query".to_string())]);
    }

    #[test]
    fn test_get_all_query_metadata_from_path_missing_directory_errors() {
        let temp_dir = tempfile::TempDir::new().unwrap();
        let missing = temp_dir.path().join("does-not-exist");

        let result = get_all_query_metadata_from_path(&missing);
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("queries directory not found")
        );
    }

    #[test]
    fn test_get_all_query_metadata_from_path_rejects_duplicate_ids() {
        let temp_dir = tempfile::TempDir::new().unwrap();
        let dir = temp_dir.path();

        fs::write(
            dir.join("120506-claude-code-direct-reports-model-mix.yaml"),
            format!(
                "id: 120506\nname: claude-code-direct-reports-model-mix\n{MINIMAL_QUERY_METADATA_YAML}"
            ),
        )
        .unwrap();
        fs::write(
            dir.join("120506-claude-code-user-model-mix.yaml"),
            format!("id: 120506\nname: claude-code-user-model-mix\n{MINIMAL_QUERY_METADATA_YAML}"),
        )
        .unwrap();

        let result = get_all_query_metadata_from_path(dir);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(err_msg.contains("Multiple local files claim the same id"));
        assert!(err_msg.contains("id 120506"));
        assert!(err_msg.contains("claude-code-direct-reports-model-mix.yaml"));
        assert!(err_msg.contains("claude-code-user-model-mix.yaml"));
    }
}