stator_jse 0.2.3

//! WebAssembly JS API built-in objects.
//!
//! This module implements the [WebAssembly JavaScript API] as a set of pure-Rust
//! functions that operate on the engine's [`JsValue`] type.  The public entry
//! point is [`make_webassembly_object`], which constructs the `WebAssembly`
//! namespace object that should be installed as a global.
//!
//! # Implemented API surface
//!
//! | JavaScript                               | Rust function            |
//! |------------------------------------------|--------------------------|
//! | `WebAssembly.validate(bytes)`            | [`wasm_validate`]        |
//! | `WebAssembly.compile(bytes)`             | [`wasm_compile`]         |
//! | `WebAssembly.instantiate(src, imports?)` | [`wasm_instantiate`]     |
//! | `new WebAssembly.Module(bytes)`          | [`wasm_module_ctor`]     |
//! | `new WebAssembly.Instance(mod, imp?)`    | [`wasm_instance_ctor`]   |
//! | `new WebAssembly.Memory({initial, …})`   | [`wasm_memory_ctor`]     |
//! | `new WebAssembly.Table({element, …})`    | [`wasm_table_ctor`]      |
//! | `new WebAssembly.Global({value, …}, v?)` | [`wasm_global_ctor`]     |
//!
//! # Byte input format
//!
//! Because this engine has no `Uint8Array` or `ArrayBuffer`, Wasm byte inputs
//! are accepted in two forms:
//!
//! - **`JsValue::Array` of `Smi`/`HeapNumber` values (0–255)** — raw binary.
//! - **`JsValue::String`** — WebAssembly Text Format (WAT); compiled via
//!   Wasmtime's built-in WAT parser.
//!
//! # Object representation
//!
//! Wasm host objects are represented as [`JsValue::PlainObject`] values with a
//! discriminating `"__wasm_type__"` string property:
//!
//! | `__wasm_type__`          | additional properties                        |
//! |--------------------------|----------------------------------------------|
//! | `"WebAssembly.Module"`   | `exports` (Array of descriptors), `__wasm_bytes__` |
//! | `"WebAssembly.Instance"` | `exports` (PlainObject of callable exports)  |
//! | `"WebAssembly.Memory"`   | `buffer` (Undefined), `grow` (NativeFunction) |
//! | `"WebAssembly.Table"`    | `length`, `get`, `set`, `grow`               |
//! | `"WebAssembly.Global"`   | `value`, `valueOf`                           |
//!
//! [WebAssembly JavaScript API]: https://webassembly.github.io/spec/js-api/

use std::cell::RefCell;
use std::rc::Rc;

use crate::error::{StatorError, StatorResult};
use crate::objects::property_map::PropertyMap;
use crate::objects::value::{JsValue, NativeFn};
use crate::wasm::{
    WasmEngine, WasmInstance, WasmModule, js_value_to_wasm_val, wasm_val_to_js_value,
};

// ─────────────────────────────────────────────────────────────────────────────
// Internal helpers
// ─────────────────────────────────────────────────────────────────────────────

/// Return `true` if `bytes` look like WAT (WebAssembly Text Format) rather
/// than a binary Wasm module.
///
/// Heuristic: a valid Wasm binary always starts with the magic bytes
/// `\0asm` (0x00 0x61 0x73 0x6d).  Everything else is treated as WAT.
fn is_wat(bytes: &[u8]) -> bool {
    !bytes.starts_with(b"\0asm")
}

/// Extract a `Vec<u8>` from a [`JsValue`].
///
/// - `JsValue::Array` of `Smi`/`HeapNumber` → raw bytes (each value clamped to
///   0–255).
/// - `JsValue::String` → UTF-8 encoding of the string (treated as WAT source).
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] if `val` is neither an array nor a string,
/// or if an array element is not a number in `[0, 255]`.
fn bytes_from_js_value(val: &JsValue) -> StatorResult<Vec<u8>> {
    match val {
        JsValue::Array(items) => {
            let mut bytes = Vec::with_capacity(items.borrow().len());
            for (i, item) in items.borrow().iter().enumerate() {
                let n = match item {
                    JsValue::Smi(n) => *n,
                    JsValue::HeapNumber(f) => *f as i32,
                    other => {
                        return Err(StatorError::TypeError(format!(
                            "WebAssembly bytes[{i}]: expected number, got {other:?}"
                        )));
                    }
                };
                if !(0..=255).contains(&n) {
                    return Err(StatorError::TypeError(format!(
                        "WebAssembly bytes[{i}]: value {n} is out of range 0..=255"
                    )));
                }
                bytes.push(n as u8);
            }
            Ok(bytes)
        }
        JsValue::String(s) => Ok(s.as_bytes().to_vec()),
        other => Err(StatorError::TypeError(format!(
            "WebAssembly source must be an Array of bytes or a WAT string, got {other:?}"
        ))),
    }
}

/// Compile `bytes` to a [`WasmModule`], auto-detecting binary vs. WAT.
fn compile_bytes(engine: &WasmEngine, bytes: &[u8]) -> StatorResult<WasmModule> {
    if is_wat(bytes) {
        let text = std::str::from_utf8(bytes)
            .map_err(|e| StatorError::WasmError(format!("invalid UTF-8 in WAT source: {e}")))?;
        WasmModule::from_wat(engine, text)
    } else {
        WasmModule::from_bytes(engine, bytes)
    }
}

/// Build a `WebAssembly.Module` [`JsValue::PlainObject`] from a compiled module.
///
/// The returned object has:
/// - `__wasm_type__` → `"WebAssembly.Module"`
/// - `__wasm_bytes__` → `Array` of `Smi` (byte values 0–255)
/// - `exports` → `Array` of export descriptor objects `{name, kind}`
fn make_module_object(module: &WasmModule, bytes: Vec<u8>) -> JsValue {
    let map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));

    // Tag the object type for later detection.
    map.borrow_mut().insert(
        "__wasm_type__".to_string(),
        JsValue::String("WebAssembly.Module".to_string().into()),
    );

    // Store the original bytes so we can re-compile when instantiating.
    let js_bytes: Vec<JsValue> = bytes.iter().map(|&b| JsValue::Smi(i32::from(b))).collect();
    map.borrow_mut()
        .insert("__wasm_bytes__".to_string(), JsValue::new_array(js_bytes));

    // Build the exports descriptor array (`WebAssembly.Module.exports(mod)`).
    let export_descs: Vec<JsValue> = module
        .inner()
        .exports()
        .map(|exp| {
            let desc: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
            desc.borrow_mut().insert(
                "name".to_string(),
                JsValue::String(exp.name().to_string().into()),
            );
            let kind = match exp.ty() {
                wasmtime::ExternType::Func(_) => "function",
                wasmtime::ExternType::Memory(_) => "memory",
                wasmtime::ExternType::Table(_) => "table",
                wasmtime::ExternType::Global(_) => "global",
                _ => "other",
            };
            desc.borrow_mut()
                .insert("kind".to_string(), JsValue::String(kind.to_string().into()));
            JsValue::PlainObject(desc)
        })
        .collect();
    map.borrow_mut()
        .insert("exports".to_string(), JsValue::new_array(export_descs));

    JsValue::PlainObject(map)
}

/// Extract the raw bytes stored inside a `WebAssembly.Module` object.
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] when `module_obj` is not a
/// `WebAssembly.Module` [`JsValue::PlainObject`].
fn extract_bytes_from_module(module_obj: &JsValue) -> StatorResult<Vec<u8>> {
    let map = match module_obj {
        JsValue::PlainObject(m) => m,
        _ => {
            return Err(StatorError::TypeError(
                "expected a WebAssembly.Module object".to_string(),
            ));
        }
    };

    let wasm_type = map.borrow().get("__wasm_type__").cloned();
    match &wasm_type {
        Some(JsValue::String(s)) if &**s == "WebAssembly.Module" => {}
        _ => {
            return Err(StatorError::TypeError(
                "not a WebAssembly.Module object".to_string(),
            ));
        }
    }

    match map.borrow().get("__wasm_bytes__").cloned() {
        Some(JsValue::Array(arr)) => arr
            .borrow()
            .iter()
            .enumerate()
            .map(|(i, v)| match v {
                JsValue::Smi(n) => Ok(*n as u8),
                _ => Err(StatorError::WasmError(format!(
                    "__wasm_bytes__[{i}] is not a Smi"
                ))),
            })
            .collect(),
        _ => Err(StatorError::WasmError(
            "missing __wasm_bytes__ in WebAssembly.Module object".to_string(),
        )),
    }
}

/// Instantiate a compiled [`WasmModule`] and wrap the live instance in a
/// `WebAssembly.Instance` [`JsValue::PlainObject`].
///
/// The `exports` property of the returned object is a [`JsValue::PlainObject`]
/// where each exported *function* name is mapped to a
/// [`JsValue::NativeFunction`] that, when called, invokes that export on the
/// live Wasmtime instance.
///
/// Non-function exports (memories, tables, globals) are currently omitted from
/// the `exports` map.
///
/// # Errors
///
/// Returns [`StatorError::WasmError`] if instantiation fails.
fn make_instance_object(module: &WasmModule, engine: &WasmEngine) -> StatorResult<JsValue> {
    // Collect (name, is_func) pairs *before* consuming `module` in
    // WasmInstance::new, so that the borrow checker is happy.
    let export_info: Vec<(String, bool)> = module
        .inner()
        .exports()
        .map(|exp| {
            let is_func = matches!(exp.ty(), wasmtime::ExternType::Func(_));
            (exp.name().to_string(), is_func)
        })
        .collect();

    let instance_rc: Rc<RefCell<WasmInstance>> =
        Rc::new(RefCell::new(WasmInstance::new(engine, module)?));

    // Build the exports map with one NativeFunction per exported function.
    let exports_map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
    for (name, is_func) in export_info {
        if is_func {
            let inst_ref = Rc::clone(&instance_rc);
            let fn_name = name.clone();
            let f: NativeFn = Rc::new(move |args: Vec<JsValue>| {
                let mut inst = inst_ref.borrow_mut();
                // Convert JS arguments to Wasm values.
                let wasm_args: Vec<wasmtime::Val> = args
                    .iter()
                    .map(js_value_to_wasm_val)
                    .collect::<StatorResult<Vec<_>>>()?;
                let results = inst.call(&fn_name, &wasm_args)?;
                if results.is_empty() {
                    Ok(JsValue::Undefined)
                } else {
                    wasm_val_to_js_value(&results[0])
                }
            });
            exports_map
                .borrow_mut()
                .insert(name, JsValue::NativeFunction(f));
        }
        // Non-function exports (memory, table, global) are not yet exposed.
    }

    let instance_map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
    instance_map.borrow_mut().insert(
        "__wasm_type__".to_string(),
        JsValue::String("WebAssembly.Instance".to_string().into()),
    );
    instance_map
        .borrow_mut()
        .insert("exports".to_string(), JsValue::PlainObject(exports_map));

    Ok(JsValue::PlainObject(instance_map))
}

// ─────────────────────────────────────────────────────────────────────────────
// Public API functions
// ─────────────────────────────────────────────────────────────────────────────

/// `WebAssembly.validate(bytes)` — ECMAScript WebAssembly API §7.1.
///
/// Returns `true` if `bytes` represent a valid WebAssembly module, `false`
/// otherwise.  Never throws.
///
/// `bytes` may be:
/// - a [`JsValue::Array`] of byte values (0–255), or
/// - a [`JsValue::String`] containing WAT source.
///
/// # Examples
///
/// ```
/// use stator_jse::builtins::wasm::wasm_validate;
/// use stator_jse::objects::value::JsValue;
///
/// // Minimal Wasm binary (magic + version).
/// let bytes: Vec<JsValue> = vec![0x00, 0x61, 0x73, 0x6d, 0x01, 0x00, 0x00, 0x00]
///     .into_iter()
///     .map(|b: u8| JsValue::Smi(b as i32))
///     .collect();
/// let result = wasm_validate(vec![JsValue::new_array(bytes)]).unwrap();
/// assert_eq!(result, JsValue::Boolean(true));
/// ```
pub fn wasm_validate(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let source = args.into_iter().next().unwrap_or(JsValue::Undefined);
    let bytes = match bytes_from_js_value(&source) {
        Ok(b) => b,
        Err(_) => return Ok(JsValue::Boolean(false)),
    };
    let engine = WasmEngine::new();
    let valid = compile_bytes(&engine, &bytes).is_ok();
    Ok(JsValue::Boolean(valid))
}

/// `WebAssembly.compile(bytes)` — ECMAScript WebAssembly API §7.2.
///
/// In the browser API this returns a `Promise<WebAssembly.Module>`; here it
/// compiles synchronously and returns the module object directly.
///
/// # Errors
///
/// Returns [`StatorError::WasmError`] if the bytes are not a valid Wasm module.
///
/// # Examples
///
/// ```
/// use stator_jse::builtins::wasm::wasm_compile;
/// use stator_jse::objects::value::JsValue;
///
/// let wat = JsValue::String(r#"(module)"#.to_string().into());
/// let module = wasm_compile(vec![wat]).unwrap();
/// assert!(matches!(module, JsValue::PlainObject(_)));
/// ```
pub fn wasm_compile(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let source = args.into_iter().next().unwrap_or(JsValue::Undefined);
    let bytes = bytes_from_js_value(&source)?;
    let engine = WasmEngine::new();
    let module = compile_bytes(&engine, &bytes)?;
    Ok(make_module_object(&module, bytes))
}

/// `WebAssembly.instantiate(source, importObject?)` — ECMAScript WebAssembly API §7.3.
///
/// In the browser API this returns a `Promise`; here it executes synchronously.
///
/// - When `source` is a **byte array or WAT string**: compiles and instantiates,
///   returning a [`JsValue::PlainObject`] `{module, instance}`.
/// - When `source` is an **existing `WebAssembly.Module` object**: instantiates
///   directly and returns just the [`JsValue::PlainObject`] instance.
///
/// `importObject` is accepted but currently ignored.
///
/// # Errors
///
/// Returns [`StatorError::WasmError`] on compilation or instantiation failure,
/// or [`StatorError::TypeError`] for invalid arguments.
pub fn wasm_instantiate(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let mut iter = args.into_iter();
    let source = iter.next().unwrap_or(JsValue::Undefined);
    // importObject is accepted for spec-compliance but not yet implemented.
    let _import_object = iter.next();

    let engine = WasmEngine::new();

    // Determine whether `source` is already a compiled Module object.
    let is_module_obj = if let JsValue::PlainObject(ref m) = source {
        matches!(
            m.borrow().get("__wasm_type__").cloned(),
            Some(JsValue::String(ref s)) if &**s == "WebAssembly.Module"
        )
    } else {
        false
    };

    if is_module_obj {
        // source is a Module → return just the Instance.
        let bytes = extract_bytes_from_module(&source)?;
        let module = compile_bytes(&engine, &bytes)?;
        make_instance_object(&module, &engine)
    } else {
        // source is bytes → return {module, instance}.
        let bytes = bytes_from_js_value(&source)?;
        let module = compile_bytes(&engine, &bytes)?;
        let module_obj = make_module_object(&module, bytes);
        let instance_obj = make_instance_object(&module, &engine)?;

        let result: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
        result.borrow_mut().insert("module".to_string(), module_obj);
        result
            .borrow_mut()
            .insert("instance".to_string(), instance_obj);
        Ok(JsValue::PlainObject(result))
    }
}

/// `new WebAssembly.Module(bytes)` — ECMAScript WebAssembly API §5.
///
/// Compiles `bytes` synchronously and returns a `WebAssembly.Module` object.
///
/// # Errors
///
/// Returns [`StatorError::WasmError`] on compilation failure or
/// [`StatorError::TypeError`] for invalid input.
///
/// # Examples
///
/// ```
/// use stator_jse::builtins::wasm::wasm_module_ctor;
/// use stator_jse::objects::value::JsValue;
///
/// let wat = JsValue::String("(module)".to_string().into());
/// let m = wasm_module_ctor(vec![wat]).unwrap();
/// assert!(matches!(m, JsValue::PlainObject(_)));
/// ```
pub fn wasm_module_ctor(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let source = args.into_iter().next().unwrap_or(JsValue::Undefined);
    let bytes = bytes_from_js_value(&source)?;
    let engine = WasmEngine::new();
    let module = compile_bytes(&engine, &bytes)?;
    Ok(make_module_object(&module, bytes))
}

/// `new WebAssembly.Instance(module, importObject?)` — ECMAScript WebAssembly API §6.
///
/// Instantiates an existing `WebAssembly.Module` object.
///
/// `importObject` is accepted for spec-compliance but not yet implemented.
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] if `module` is not a `WebAssembly.Module`
/// object, or [`StatorError::WasmError`] on instantiation failure.
pub fn wasm_instance_ctor(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let mut iter = args.into_iter();
    let module_obj = iter.next().unwrap_or(JsValue::Undefined);
    let _import_object = iter.next();

    let bytes = extract_bytes_from_module(&module_obj)?;
    let engine = WasmEngine::new();
    let module = compile_bytes(&engine, &bytes)?;
    make_instance_object(&module, &engine)
}

/// `new WebAssembly.Memory({initial, maximum?})` — ECMAScript WebAssembly API §9.
///
/// Creates a `WebAssembly.Memory` object representing a resizable linear memory.
///
/// - `descriptor.initial` (required) — initial size in 64 KiB pages.
/// - `descriptor.maximum` (optional) — ignored in this implementation.
///
/// The returned object exposes:
/// - `grow(delta)` — grows by `delta` pages; returns the previous page count
///   or `-1` if the growth would exceed 65 536 pages.
/// - `buffer` — `Undefined` (no `ArrayBuffer` in this engine).
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] when the descriptor is missing or
/// `initial` is absent / not a number.
///
/// # Examples
///
/// ```
/// use stator_jse::objects::property_map::PropertyMap;
/// use std::cell::RefCell;
/// use std::rc::Rc;
/// use stator_jse::builtins::wasm::wasm_memory_ctor;
/// use stator_jse::objects::value::JsValue;
///
/// let desc: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
/// desc.borrow_mut().insert("initial".to_string(), JsValue::Smi(1));
/// let mem = wasm_memory_ctor(vec![JsValue::PlainObject(desc)]).unwrap();
/// assert!(matches!(mem, JsValue::PlainObject(_)));
/// ```
pub fn wasm_memory_ctor(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let descriptor = args.into_iter().next().unwrap_or(JsValue::Undefined);
    let initial_pages = match &descriptor {
        JsValue::PlainObject(map) => match map.borrow().get("initial").cloned() {
            Some(JsValue::Smi(n)) => n as u32,
            Some(JsValue::HeapNumber(f)) => f as u32,
            _ => {
                return Err(StatorError::TypeError(
                    "WebAssembly.Memory: 'initial' property is required and must be a number"
                        .to_string(),
                ));
            }
        },
        _ => {
            return Err(StatorError::TypeError(
                "WebAssembly.Memory: descriptor must be an object".to_string(),
            ));
        }
    };

    // Shared page counter so that `grow()` updates it.
    let pages: Rc<RefCell<u32>> = Rc::new(RefCell::new(initial_pages));
    let pages_for_grow = Rc::clone(&pages);
    const MAX_PAGES: u32 = 65_536; // 2^16

    let grow_fn: NativeFn = Rc::new(move |args: Vec<JsValue>| {
        let delta: u32 = match args.first() {
            Some(JsValue::Smi(n)) => *n as u32,
            Some(JsValue::HeapNumber(f)) => *f as u32,
            _ => {
                return Err(StatorError::TypeError(
                    "Memory.grow: expected a numeric delta".to_string(),
                ));
            }
        };
        let current = *pages_for_grow.borrow();
        let new_pages = current.checked_add(delta).filter(|&p| p <= MAX_PAGES);
        match new_pages {
            Some(np) => {
                *pages_for_grow.borrow_mut() = np;
                Ok(JsValue::Smi(current as i32))
            }
            None => Ok(JsValue::Smi(-1)),
        }
    });

    let memory_map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
    memory_map.borrow_mut().insert(
        "__wasm_type__".to_string(),
        JsValue::String("WebAssembly.Memory".to_string().into()),
    );
    memory_map
        .borrow_mut()
        .insert("grow".to_string(), JsValue::NativeFunction(grow_fn));
    // `buffer` is Undefined: this engine has no ArrayBuffer.
    memory_map
        .borrow_mut()
        .insert("buffer".to_string(), JsValue::Undefined);

    Ok(JsValue::PlainObject(memory_map))
}

/// `new WebAssembly.Table({element, initial, maximum?})` — ECMAScript WebAssembly API §11.
///
/// Creates a `WebAssembly.Table` object backed by an in-engine `Vec`.
///
/// - `descriptor.element` (required) — element type string, e.g. `"anyfunc"`.
/// - `descriptor.initial` (required) — initial capacity (number of slots).
/// - `descriptor.maximum` (optional) — ignored in this implementation.
///
/// The returned object exposes:
/// - `length` — number of slots (updated by `grow`).
/// - `get(index)` → stored value (or `null` if uninitialised).
/// - `set(index, value)` → `undefined`; raises `RangeError` out-of-bounds.
/// - `grow(delta, initValue?)` → previous length; extends the table.
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] when the descriptor or required properties
/// are missing / of the wrong type.
pub fn wasm_table_ctor(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let descriptor = args.into_iter().next().unwrap_or(JsValue::Undefined);
    let (initial, _element_type) =
        match &descriptor {
            JsValue::PlainObject(map) => {
                let initial: u32 = match map.borrow().get("initial").cloned() {
                    Some(JsValue::Smi(n)) => n as u32,
                    Some(JsValue::HeapNumber(f)) => f as u32,
                    _ => return Err(StatorError::TypeError(
                        "WebAssembly.Table: 'initial' property is required and must be a number"
                            .to_string(),
                    )),
                };
                let element: String = match map.borrow().get("element").cloned() {
                    Some(JsValue::String(s)) => s.to_string(),
                    _ => return Err(StatorError::TypeError(
                        "WebAssembly.Table: 'element' property is required and must be a string"
                            .to_string(),
                    )),
                };
                (initial, element)
            }
            _ => {
                return Err(StatorError::TypeError(
                    "WebAssembly.Table: descriptor must be an object".to_string(),
                ));
            }
        };

    let entries: Rc<RefCell<Vec<JsValue>>> =
        Rc::new(RefCell::new(vec![JsValue::Null; initial as usize]));
    let entries_get = Rc::clone(&entries);
    let entries_set = Rc::clone(&entries);
    let entries_grow = Rc::clone(&entries);

    // `table_map` is built after the closures but shared with `grow_fn` so that
    // grow() can update the `length` property to reflect the new size.
    let table_map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
    let table_map_for_grow = Rc::clone(&table_map);

    let get_fn: NativeFn = Rc::new(move |args: Vec<JsValue>| {
        let idx: usize = match args.first() {
            Some(JsValue::Smi(n)) => (*n).max(0) as usize,
            Some(JsValue::HeapNumber(f)) => crate::builtins::util::clamped_f64_to_usize(*f),
            _ => {
                return Err(StatorError::TypeError(
                    "Table.get: expected a numeric index".to_string(),
                ));
            }
        };
        Ok(entries_get
            .borrow()
            .get(idx)
            .cloned()
            .unwrap_or(JsValue::Null))
    });

    let set_fn: NativeFn = Rc::new(move |args: Vec<JsValue>| {
        let mut it = args.into_iter();
        let idx: usize = match it.next() {
            Some(JsValue::Smi(n)) => n.max(0) as usize,
            Some(JsValue::HeapNumber(f)) => crate::builtins::util::clamped_f64_to_usize(f),
            _ => {
                return Err(StatorError::TypeError(
                    "Table.set: expected a numeric index".to_string(),
                ));
            }
        };
        let val = it.next().unwrap_or(JsValue::Null);
        let mut tbl = entries_set.borrow_mut();
        if idx < tbl.len() {
            tbl[idx] = val;
            Ok(JsValue::Undefined)
        } else {
            Err(StatorError::RangeError(format!(
                "Table.set: index {idx} out of bounds (length {})",
                tbl.len()
            )))
        }
    });

    let grow_fn: NativeFn = Rc::new(move |args: Vec<JsValue>| {
        let mut it = args.into_iter();
        let delta: usize = match it.next() {
            Some(JsValue::Smi(n)) => n.max(0) as usize,
            Some(JsValue::HeapNumber(f)) => crate::builtins::util::clamped_f64_to_usize(f),
            _ => {
                return Err(StatorError::TypeError(
                    "Table.grow: expected a numeric delta".to_string(),
                ));
            }
        };
        let init_val = it.next().unwrap_or(JsValue::Null);
        let mut tbl = entries_grow.borrow_mut();
        let prev_len = tbl.len() as i32;
        tbl.extend(std::iter::repeat_n(init_val, delta));
        let new_len = tbl.len() as i32;
        // Update the `length` property on the table object.
        table_map_for_grow
            .borrow_mut()
            .insert("length".to_string(), JsValue::Smi(new_len));
        Ok(JsValue::Smi(prev_len))
    });
    table_map.borrow_mut().insert(
        "__wasm_type__".to_string(),
        JsValue::String("WebAssembly.Table".to_string().into()),
    );
    table_map
        .borrow_mut()
        .insert("length".to_string(), JsValue::Smi(initial as i32));
    table_map
        .borrow_mut()
        .insert("get".to_string(), JsValue::NativeFunction(get_fn));
    table_map
        .borrow_mut()
        .insert("set".to_string(), JsValue::NativeFunction(set_fn));
    table_map
        .borrow_mut()
        .insert("grow".to_string(), JsValue::NativeFunction(grow_fn));

    Ok(JsValue::PlainObject(table_map))
}

/// `new WebAssembly.Global({value, mutable?}, initValue?)` — ECMAScript WebAssembly API §12.
///
/// Creates a `WebAssembly.Global` object wrapping a single mutable or immutable
/// value.
///
/// - `descriptor.value` (required) — value type string, e.g. `"i32"`, `"f64"`.
/// - `descriptor.mutable` (optional, default `false`) — whether the value can
///   be updated via the `value` setter.
/// - `initValue` (optional, default `0`) — initial value.
///
/// The returned object exposes:
/// - `value` — the current value (read only in this implementation).
/// - `valueOf()` — returns the current value.
///
/// # Errors
///
/// Returns [`StatorError::TypeError`] when the descriptor is missing or `value`
/// type is absent.
///
/// # Examples
///
/// ```
/// use stator_jse::objects::property_map::PropertyMap;
/// use std::cell::RefCell;
/// use std::rc::Rc;
/// use stator_jse::builtins::wasm::wasm_global_ctor;
/// use stator_jse::objects::value::JsValue;
///
/// let desc: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
/// desc.borrow_mut().insert("value".to_string(), JsValue::String("i32".to_string().into()));
/// desc.borrow_mut().insert("mutable".to_string(), JsValue::Boolean(true));
/// let global = wasm_global_ctor(vec![JsValue::PlainObject(desc), JsValue::Smi(42)]).unwrap();
/// assert!(matches!(global, JsValue::PlainObject(_)));
/// ```
pub fn wasm_global_ctor(args: Vec<JsValue>) -> StatorResult<JsValue> {
    let mut iter = args.into_iter();
    let descriptor = iter.next().unwrap_or(JsValue::Undefined);
    let init_value = iter.next().unwrap_or(JsValue::Smi(0));

    match &descriptor {
        JsValue::PlainObject(map) => {
            match map.borrow().get("value").cloned() {
                Some(JsValue::String(_)) => {} // value type string is present
                _ => {
                    return Err(StatorError::TypeError(
                        "WebAssembly.Global: 'value' type string is required".to_string(),
                    ));
                }
            }
        }
        _ => {
            return Err(StatorError::TypeError(
                "WebAssembly.Global: descriptor must be an object".to_string(),
            ));
        }
    }

    let current_val: Rc<RefCell<JsValue>> = Rc::new(RefCell::new(init_value.clone()));
    let current_for_valueof = Rc::clone(&current_val);

    let valueof_fn: NativeFn =
        Rc::new(move |_args: Vec<JsValue>| Ok(current_for_valueof.borrow().clone()));

    let global_map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
    global_map.borrow_mut().insert(
        "__wasm_type__".to_string(),
        JsValue::String("WebAssembly.Global".to_string().into()),
    );
    // Expose the initial value directly; callers should use valueOf() for reads.
    global_map
        .borrow_mut()
        .insert("value".to_string(), init_value);
    global_map
        .borrow_mut()
        .insert("valueOf".to_string(), JsValue::NativeFunction(valueof_fn));

    Ok(JsValue::PlainObject(global_map))
}

// ─────────────────────────────────────────────────────────────────────────────
// Namespace factory
// ─────────────────────────────────────────────────────────────────────────────

/// Build the `WebAssembly` global namespace object.
///
/// Returns a [`JsValue::PlainObject`] with the following properties, each a
/// [`JsValue::NativeFunction`]:
///
/// - `validate` → [`wasm_validate`]
/// - `compile` → [`wasm_compile`]
/// - `instantiate` → [`wasm_instantiate`]
/// - `Module` → [`wasm_module_ctor`]
/// - `Instance` → [`wasm_instance_ctor`]
/// - `Memory` → [`wasm_memory_ctor`]
/// - `Table` → [`wasm_table_ctor`]
/// - `Global` → [`wasm_global_ctor`]
///
/// Install this value as the `"WebAssembly"` key in the interpreter's global
/// environment to expose the full WebAssembly JS API to executing scripts.
///
/// # Examples
///
/// ```
/// use stator_jse::builtins::wasm::make_webassembly_object;
/// use stator_jse::objects::value::JsValue;
///
/// let wasm_obj = make_webassembly_object();
/// assert!(matches!(wasm_obj, JsValue::PlainObject(_)));
/// ```
pub fn make_webassembly_object() -> JsValue {
    let map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));

    map.borrow_mut().insert(
        "validate".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_validate)),
    );
    map.borrow_mut().insert(
        "compile".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_compile)),
    );
    map.borrow_mut().insert(
        "instantiate".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_instantiate)),
    );
    map.borrow_mut().insert(
        "Module".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_module_ctor)),
    );
    map.borrow_mut().insert(
        "Instance".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_instance_ctor)),
    );
    map.borrow_mut().insert(
        "Memory".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_memory_ctor)),
    );
    map.borrow_mut().insert(
        "Table".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_table_ctor)),
    );
    map.borrow_mut().insert(
        "Global".to_string(),
        JsValue::NativeFunction(Rc::new(wasm_global_ctor)),
    );

    JsValue::PlainObject(map)
}

// ─────────────────────────────────────────────────────────────────────────────
// Tests
// ─────────────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use std::cell::RefCell;
    use std::rc::Rc;

    use super::*;
    use crate::objects::property_map::PropertyMap;

    // ── WAT helpers ──────────────────────────────────────────────────────────

    /// Minimal empty module in WAT.
    const EMPTY_WAT: &str = "(module)";

    /// Module that exports a single `add(i32, i32) → i32` function.
    const ADD_WAT: &str = r#"
        (module
            (func $add (export "add") (param i32 i32) (result i32)
                local.get 0
                local.get 1
                i32.add))
    "#;

    /// Module that exports a single `double(i32) → i32` function.
    const DOUBLE_WAT: &str = r#"
        (module
            (func $double (export "double") (param i32) (result i32)
                local.get 0
                i32.const 2
                i32.mul))
    "#;

    /// Module with two exported functions.
    const MULTI_EXPORT_WAT: &str = r#"
        (module
            (func $noop (export "noop"))
            (func $identity (export "identity") (param i32) (result i32)
                local.get 0))
    "#;

    /// Helper: convert a WAT string to a `JsValue::String`.
    fn wat_val(wat: &str) -> JsValue {
        JsValue::String(wat.to_string().into())
    }

    /// Helper: minimal valid Wasm binary (empty module magic + version).
    fn empty_wasm_binary_val() -> JsValue {
        let bytes: Vec<JsValue> = [0x00u8, 0x61, 0x73, 0x6d, 0x01, 0x00, 0x00, 0x00]
            .iter()
            .map(|&b| JsValue::Smi(i32::from(b)))
            .collect();
        JsValue::new_array(bytes)
    }

    /// Helper: plain descriptor object `{key: value}`.
    fn descriptor(pairs: &[(&str, JsValue)]) -> JsValue {
        let map: Rc<RefCell<PropertyMap>> = Rc::new(RefCell::new(PropertyMap::new()));
        for (k, v) in pairs {
            map.borrow_mut().insert(k.to_string(), v.clone());
        }
        JsValue::PlainObject(map)
    }

    // ── bytes_from_js_value ───────────────────────────────────────────────────

    #[test]
    fn test_bytes_from_array_of_smis() {
        let arr = JsValue::new_array(vec![JsValue::Smi(0), JsValue::Smi(255)]);
        let bytes = bytes_from_js_value(&arr).unwrap();
        assert_eq!(bytes, vec![0u8, 255u8]);
    }

    #[test]
    fn test_bytes_from_heap_number() {
        let arr = JsValue::new_array(vec![JsValue::HeapNumber(1.0)]);
        let bytes = bytes_from_js_value(&arr).unwrap();
        assert_eq!(bytes, vec![1u8]);
    }

    #[test]
    fn test_bytes_from_string() {
        let s = JsValue::String("(module)".to_string().into());
        let bytes = bytes_from_js_value(&s).unwrap();
        assert_eq!(bytes, b"(module)");
    }

    #[test]
    fn test_bytes_from_invalid_type_returns_error() {
        let err = bytes_from_js_value(&JsValue::Smi(42)).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    #[test]
    fn test_bytes_out_of_range_returns_error() {
        let arr = JsValue::new_array(vec![JsValue::Smi(256)]);
        let err = bytes_from_js_value(&arr).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── is_wat ───────────────────────────────────────────────────────────────

    #[test]
    fn test_is_wat_for_text_module() {
        assert!(is_wat(b"(module)"));
    }

    #[test]
    fn test_is_wat_false_for_wasm_magic() {
        assert!(!is_wat(b"\0asm\x01\0\0\0"));
    }

    // ── wasm_validate ─────────────────────────────────────────────────────────

    #[test]
    fn test_validate_empty_module_wat() {
        let result = wasm_validate(vec![wat_val(EMPTY_WAT)]).unwrap();
        assert_eq!(result, JsValue::Boolean(true));
    }

    #[test]
    fn test_validate_valid_binary() {
        let result = wasm_validate(vec![empty_wasm_binary_val()]).unwrap();
        assert_eq!(result, JsValue::Boolean(true));
    }

    #[test]
    fn test_validate_invalid_bytes_returns_false() {
        let bad = JsValue::new_array(vec![JsValue::Smi(0x00), JsValue::Smi(0x00)]);
        let result = wasm_validate(vec![bad]).unwrap();
        assert_eq!(result, JsValue::Boolean(false));
    }

    #[test]
    fn test_validate_invalid_wat_returns_false() {
        let result =
            wasm_validate(vec![JsValue::String("not wasm at all".to_string().into())]).unwrap();
        assert_eq!(result, JsValue::Boolean(false));
    }

    #[test]
    fn test_validate_no_args_returns_false() {
        let result = wasm_validate(vec![]).unwrap();
        assert_eq!(result, JsValue::Boolean(false));
    }

    #[test]
    fn test_validate_wrong_type_returns_false() {
        let result = wasm_validate(vec![JsValue::Smi(42)]).unwrap();
        assert_eq!(result, JsValue::Boolean(false));
    }

    // ── wasm_compile ──────────────────────────────────────────────────────────

    #[test]
    fn test_compile_empty_wat_returns_plain_object() {
        let m = wasm_compile(vec![wat_val(EMPTY_WAT)]).unwrap();
        assert!(matches!(m, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_compile_sets_wasm_type() {
        let m = wasm_compile(vec![wat_val(EMPTY_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            let ty = map.borrow().get("__wasm_type__").cloned();
            assert_eq!(
                ty,
                Some(JsValue::String("WebAssembly.Module".to_string().into()))
            );
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_compile_exports_is_array() {
        let m = wasm_compile(vec![wat_val(ADD_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            let exports = map.borrow().get("exports").cloned();
            assert!(matches!(exports, Some(JsValue::Array(_))));
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_compile_export_descriptor_has_name_and_kind() {
        let m = wasm_compile(vec![wat_val(ADD_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            let exports = map.borrow().get("exports").cloned().unwrap();
            if let JsValue::Array(arr) = exports {
                assert_eq!(arr.borrow().len(), 1);
                if let JsValue::PlainObject(desc) = &arr.borrow()[0] {
                    let name = desc.borrow().get("name").cloned();
                    let kind = desc.borrow().get("kind").cloned();
                    assert_eq!(name, Some(JsValue::String("add".to_string().into())));
                    assert_eq!(kind, Some(JsValue::String("function".to_string().into())));
                } else {
                    panic!("expected PlainObject descriptor");
                }
            } else {
                panic!("expected Array exports");
            }
        } else {
            panic!("expected PlainObject module");
        }
    }

    #[test]
    fn test_compile_invalid_wat_returns_error() {
        let err = wasm_compile(vec![JsValue::String("bad wat".to_string().into())]).unwrap_err();
        assert!(matches!(err, StatorError::WasmError(_)));
    }

    #[test]
    fn test_compile_binary_wasm() {
        let m = wasm_compile(vec![empty_wasm_binary_val()]).unwrap();
        assert!(matches!(m, JsValue::PlainObject(_)));
    }

    // ── wasm_module_ctor ──────────────────────────────────────────────────────

    #[test]
    fn test_module_ctor_returns_module_object() {
        let m = wasm_module_ctor(vec![wat_val(EMPTY_WAT)]).unwrap();
        assert!(matches!(m, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_module_ctor_wasm_bytes_stored() {
        let m = wasm_module_ctor(vec![wat_val(EMPTY_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            let bytes = map.borrow().get("__wasm_bytes__").cloned();
            assert!(matches!(bytes, Some(JsValue::Array(_))));
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_module_ctor_add_exports_descriptor() {
        let m = wasm_module_ctor(vec![wat_val(ADD_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            if let Some(JsValue::Array(arr)) = map.borrow().get("exports").cloned() {
                assert_eq!(arr.borrow().len(), 1);
            } else {
                panic!("expected exports array with one entry");
            }
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_module_ctor_multi_export_descriptor() {
        let m = wasm_module_ctor(vec![wat_val(MULTI_EXPORT_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = m {
            if let Some(JsValue::Array(arr)) = map.borrow().get("exports").cloned() {
                assert_eq!(arr.borrow().len(), 2);
            } else {
                panic!("expected exports array with two entries");
            }
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_module_ctor_invalid_returns_error() {
        let err =
            wasm_module_ctor(vec![JsValue::String("nonsense".to_string().into())]).unwrap_err();
        assert!(matches!(err, StatorError::WasmError(_)));
    }

    #[test]
    fn test_module_ctor_type_error_on_bad_input() {
        let err = wasm_module_ctor(vec![JsValue::Smi(0)]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── wasm_instance_ctor ────────────────────────────────────────────────────

    #[test]
    fn test_instance_ctor_from_empty_module() {
        let module = wasm_module_ctor(vec![wat_val(EMPTY_WAT)]).unwrap();
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        assert!(matches!(inst, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_instance_ctor_has_exports_property() {
        let module = wasm_module_ctor(vec![wat_val(EMPTY_WAT)]).unwrap();
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        if let JsValue::PlainObject(map) = inst {
            assert!(map.borrow().contains_key("exports"));
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_instance_ctor_exports_contains_native_function() {
        let module = wasm_module_ctor(vec![wat_val(ADD_WAT)]).unwrap();
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        if let JsValue::PlainObject(imap) = inst {
            if let Some(JsValue::PlainObject(exp)) = imap.borrow().get("exports").cloned() {
                let add = exp.borrow().get("add").cloned();
                assert!(matches!(add, Some(JsValue::NativeFunction(_))));
            } else {
                panic!("expected exports PlainObject");
            }
        } else {
            panic!("expected instance PlainObject");
        }
    }

    #[test]
    fn test_instance_ctor_exported_function_callable() {
        let module = wasm_module_ctor(vec![wat_val(ADD_WAT)]).unwrap();
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        if let JsValue::PlainObject(imap) = inst {
            if let Some(JsValue::PlainObject(exp)) = imap.borrow().get("exports").cloned() {
                if let Some(JsValue::NativeFunction(add_fn)) = exp.borrow().get("add").cloned() {
                    let result = add_fn(vec![JsValue::Smi(3), JsValue::Smi(4)]).unwrap();
                    assert_eq!(result, JsValue::Smi(7));
                } else {
                    panic!("expected NativeFunction for 'add'");
                }
            } else {
                panic!("expected exports PlainObject");
            }
        } else {
            panic!("expected instance PlainObject");
        }
    }

    #[test]
    fn test_instance_ctor_double_function() {
        let module = wasm_module_ctor(vec![wat_val(DOUBLE_WAT)]).unwrap();
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        if let JsValue::PlainObject(imap) = inst {
            if let Some(JsValue::PlainObject(exp)) = imap.borrow().get("exports").cloned() {
                if let Some(JsValue::NativeFunction(f)) = exp.borrow().get("double").cloned() {
                    let result = f(vec![JsValue::Smi(6)]).unwrap();
                    assert_eq!(result, JsValue::Smi(12));
                } else {
                    panic!("expected NativeFunction for 'double'");
                }
            } else {
                panic!("expected exports PlainObject");
            }
        } else {
            panic!("expected instance PlainObject");
        }
    }

    #[test]
    fn test_instance_ctor_type_error_on_non_module() {
        let err = wasm_instance_ctor(vec![JsValue::Smi(0)]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── wasm_instantiate ──────────────────────────────────────────────────────

    #[test]
    fn test_instantiate_from_bytes_returns_module_and_instance() {
        let result = wasm_instantiate(vec![wat_val(ADD_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = result {
            assert!(map.borrow().contains_key("module"));
            assert!(map.borrow().contains_key("instance"));
        } else {
            panic!("expected PlainObject {{module, instance}}");
        }
    }

    #[test]
    fn test_instantiate_from_module_returns_instance_directly() {
        let module = wasm_module_ctor(vec![wat_val(ADD_WAT)]).unwrap();
        let inst = wasm_instantiate(vec![module]).unwrap();
        if let JsValue::PlainObject(map) = &inst {
            let ty = map.borrow().get("__wasm_type__").cloned();
            assert_eq!(
                ty,
                Some(JsValue::String("WebAssembly.Instance".to_string().into()))
            );
        } else {
            panic!("expected instance PlainObject");
        }
    }

    #[test]
    fn test_instantiate_from_bytes_exports_callable() {
        let result = wasm_instantiate(vec![wat_val(ADD_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = result {
            if let Some(JsValue::PlainObject(inst_map)) = map.borrow().get("instance").cloned() {
                if let Some(JsValue::PlainObject(exp)) = inst_map.borrow().get("exports").cloned() {
                    if let Some(JsValue::NativeFunction(add_fn)) = exp.borrow().get("add").cloned()
                    {
                        let r = add_fn(vec![JsValue::Smi(10), JsValue::Smi(20)]).unwrap();
                        assert_eq!(r, JsValue::Smi(30));
                        return;
                    }
                }
            }
        }
        panic!("could not reach add export through instantiate result");
    }

    #[test]
    fn test_instantiate_type_error_on_bad_source() {
        let err = wasm_instantiate(vec![JsValue::Smi(0)]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── wasm_memory_ctor ──────────────────────────────────────────────────────

    #[test]
    fn test_memory_ctor_returns_plain_object() {
        let desc = descriptor(&[("initial", JsValue::Smi(1))]);
        let mem = wasm_memory_ctor(vec![desc]).unwrap();
        assert!(matches!(mem, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_memory_ctor_has_grow_and_buffer() {
        let desc = descriptor(&[("initial", JsValue::Smi(1))]);
        let mem = wasm_memory_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = mem {
            assert!(matches!(
                map.borrow().get("grow"),
                Some(JsValue::NativeFunction(_))
            ));
            assert!(map.borrow().contains_key("buffer"));
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_memory_grow_returns_previous_page_count() {
        let desc = descriptor(&[("initial", JsValue::Smi(2))]);
        let mem = wasm_memory_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = mem {
            if let Some(JsValue::NativeFunction(grow)) = map.borrow().get("grow").cloned() {
                let prev = grow(vec![JsValue::Smi(3)]).unwrap();
                assert_eq!(prev, JsValue::Smi(2)); // was 2 pages
            }
        }
    }

    #[test]
    fn test_memory_grow_negative_one_on_overflow() {
        let desc = descriptor(&[("initial", JsValue::Smi(65_536))]);
        let mem = wasm_memory_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = mem {
            if let Some(JsValue::NativeFunction(grow)) = map.borrow().get("grow").cloned() {
                let result = grow(vec![JsValue::Smi(1)]).unwrap();
                assert_eq!(result, JsValue::Smi(-1));
            }
        }
    }

    #[test]
    fn test_memory_ctor_missing_initial_returns_error() {
        let desc = descriptor(&[]);
        let err = wasm_memory_ctor(vec![desc]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    #[test]
    fn test_memory_ctor_non_object_returns_error() {
        let err = wasm_memory_ctor(vec![JsValue::Smi(1)]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── wasm_table_ctor ───────────────────────────────────────────────────────

    #[test]
    fn test_table_ctor_returns_plain_object() {
        let desc = descriptor(&[
            ("element", JsValue::String("anyfunc".to_string().into())),
            ("initial", JsValue::Smi(4)),
        ]);
        let tbl = wasm_table_ctor(vec![desc]).unwrap();
        assert!(matches!(tbl, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_table_ctor_has_get_set_grow_length() {
        let desc = descriptor(&[
            ("element", JsValue::String("anyfunc".to_string().into())),
            ("initial", JsValue::Smi(4)),
        ]);
        let tbl = wasm_table_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = tbl {
            assert!(matches!(
                map.borrow().get("get"),
                Some(JsValue::NativeFunction(_))
            ));
            assert!(matches!(
                map.borrow().get("set"),
                Some(JsValue::NativeFunction(_))
            ));
            assert!(matches!(
                map.borrow().get("grow"),
                Some(JsValue::NativeFunction(_))
            ));
            assert_eq!(map.borrow().get("length").cloned(), Some(JsValue::Smi(4)));
        }
    }

    #[test]
    fn test_table_get_set_roundtrip() {
        let desc = descriptor(&[
            ("element", JsValue::String("anyfunc".to_string().into())),
            ("initial", JsValue::Smi(4)),
        ]);
        let tbl = wasm_table_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = tbl {
            let get_fn = match map.borrow().get("get").cloned() {
                Some(JsValue::NativeFunction(f)) => f,
                _ => panic!("expected get NativeFunction"),
            };
            let set_fn = match map.borrow().get("set").cloned() {
                Some(JsValue::NativeFunction(f)) => f,
                _ => panic!("expected set NativeFunction"),
            };
            // Slot 0 starts null.
            assert_eq!(get_fn(vec![JsValue::Smi(0)]).unwrap(), JsValue::Null);
            // Set slot 2.
            set_fn(vec![JsValue::Smi(2), JsValue::Smi(99)]).unwrap();
            assert_eq!(get_fn(vec![JsValue::Smi(2)]).unwrap(), JsValue::Smi(99));
        }
    }

    #[test]
    fn test_table_set_out_of_bounds_error() {
        let desc = descriptor(&[
            ("element", JsValue::String("anyfunc".to_string().into())),
            ("initial", JsValue::Smi(2)),
        ]);
        let tbl = wasm_table_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = tbl {
            if let Some(JsValue::NativeFunction(set_fn)) = map.borrow().get("set").cloned() {
                let err = set_fn(vec![JsValue::Smi(5), JsValue::Smi(1)]).unwrap_err();
                assert!(matches!(err, StatorError::RangeError(_)));
            }
        }
    }

    #[test]
    fn test_table_grow_extends_length() {
        let desc = descriptor(&[
            ("element", JsValue::String("anyfunc".to_string().into())),
            ("initial", JsValue::Smi(2)),
        ]);
        let tbl = wasm_table_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = tbl {
            let grow_fn = match map.borrow().get("grow").cloned() {
                Some(JsValue::NativeFunction(f)) => f,
                _ => panic!("expected grow NativeFunction"),
            };
            let get_fn = match map.borrow().get("get").cloned() {
                Some(JsValue::NativeFunction(f)) => f,
                _ => panic!("expected get NativeFunction"),
            };
            let prev = grow_fn(vec![JsValue::Smi(3)]).unwrap();
            assert_eq!(prev, JsValue::Smi(2)); // previous length
            // New slot 4 should be accessible and null.
            assert_eq!(get_fn(vec![JsValue::Smi(4)]).unwrap(), JsValue::Null);
            // `length` property on the table object must be updated to 5.
            assert_eq!(map.borrow().get("length").cloned(), Some(JsValue::Smi(5)));
        }
    }

    #[test]
    fn test_table_ctor_missing_element_returns_error() {
        let desc = descriptor(&[("initial", JsValue::Smi(1))]);
        let err = wasm_table_ctor(vec![desc]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    #[test]
    fn test_table_ctor_missing_initial_returns_error() {
        let desc = descriptor(&[("element", JsValue::String("anyfunc".to_string().into()))]);
        let err = wasm_table_ctor(vec![desc]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── wasm_global_ctor ──────────────────────────────────────────────────────

    #[test]
    fn test_global_ctor_returns_plain_object() {
        let desc = descriptor(&[("value", JsValue::String("i32".to_string().into()))]);
        let g = wasm_global_ctor(vec![desc, JsValue::Smi(42)]).unwrap();
        assert!(matches!(g, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_global_ctor_value_property() {
        let desc = descriptor(&[("value", JsValue::String("i32".to_string().into()))]);
        let g = wasm_global_ctor(vec![desc, JsValue::Smi(42)]).unwrap();
        if let JsValue::PlainObject(map) = g {
            assert_eq!(map.borrow().get("value").cloned(), Some(JsValue::Smi(42)));
        }
    }

    #[test]
    fn test_global_valueof_returns_init() {
        let desc = descriptor(&[("value", JsValue::String("f64".to_string().into()))]);
        let g = wasm_global_ctor(vec![desc, JsValue::HeapNumber(3.14)]).unwrap();
        if let JsValue::PlainObject(map) = g {
            if let Some(JsValue::NativeFunction(valueof)) = map.borrow().get("valueOf").cloned() {
                let v = valueof(vec![]).unwrap();
                assert_eq!(v, JsValue::HeapNumber(3.14));
            }
        }
    }

    #[test]
    fn test_global_default_init_is_zero() {
        let desc = descriptor(&[("value", JsValue::String("i32".to_string().into()))]);
        let g = wasm_global_ctor(vec![desc]).unwrap();
        if let JsValue::PlainObject(map) = g {
            assert_eq!(map.borrow().get("value").cloned(), Some(JsValue::Smi(0)));
        }
    }

    #[test]
    fn test_global_ctor_missing_value_type_error() {
        let desc = descriptor(&[]);
        let err = wasm_global_ctor(vec![desc]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    #[test]
    fn test_global_ctor_non_object_descriptor_error() {
        let err = wasm_global_ctor(vec![JsValue::Smi(1)]).unwrap_err();
        assert!(matches!(err, StatorError::TypeError(_)));
    }

    // ── make_webassembly_object ───────────────────────────────────────────────

    #[test]
    fn test_make_webassembly_object_returns_plain_object() {
        let wasm = make_webassembly_object();
        assert!(matches!(wasm, JsValue::PlainObject(_)));
    }

    #[test]
    fn test_make_webassembly_object_has_all_api_keys() {
        let wasm = make_webassembly_object();
        if let JsValue::PlainObject(map) = wasm {
            let keys: Vec<&str> = [
                "validate",
                "compile",
                "instantiate",
                "Module",
                "Instance",
                "Memory",
                "Table",
                "Global",
            ]
            .as_slice()
            .iter()
            .copied()
            .collect();
            for key in keys {
                assert!(map.borrow().contains_key(key), "missing key: {key}");
            }
        } else {
            panic!("expected PlainObject");
        }
    }

    #[test]
    fn test_make_webassembly_object_all_values_are_native_functions() {
        let wasm = make_webassembly_object();
        if let JsValue::PlainObject(map) = wasm {
            for (key, val) in map.borrow().iter() {
                assert!(
                    matches!(val, JsValue::NativeFunction(_)),
                    "WebAssembly.{key} is not a NativeFunction"
                );
            }
        }
    }

    // ── full integration: compile + instantiate + call ────────────────────────

    #[test]
    fn test_full_api_compile_then_instance_then_call() {
        // 1. Compile
        let module = wasm_module_ctor(vec![wat_val(ADD_WAT)]).unwrap();
        // 2. Instantiate
        let inst = wasm_instance_ctor(vec![module]).unwrap();
        // 3. Call
        if let JsValue::PlainObject(imap) = inst {
            if let Some(JsValue::PlainObject(exp)) = imap.borrow().get("exports").cloned() {
                if let Some(JsValue::NativeFunction(add)) = exp.borrow().get("add").cloned() {
                    let r = add(vec![JsValue::Smi(100), JsValue::Smi(200)]).unwrap();
                    assert_eq!(r, JsValue::Smi(300));
                    return;
                }
            }
        }
        panic!("integration test failed");
    }

    #[test]
    fn test_full_api_instantiate_from_bytes() {
        let result = wasm_instantiate(vec![wat_val(DOUBLE_WAT)]).unwrap();
        if let JsValue::PlainObject(map) = result {
            if let Some(JsValue::PlainObject(inst_map)) = map.borrow().get("instance").cloned() {
                if let Some(JsValue::PlainObject(exp)) = inst_map.borrow().get("exports").cloned() {
                    if let Some(JsValue::NativeFunction(f)) = exp.borrow().get("double").cloned() {
                        let r = f(vec![JsValue::Smi(7)]).unwrap();
                        assert_eq!(r, JsValue::Smi(14));
                        return;
                    }
                }
            }
        }
        panic!("full instantiate from bytes failed");
    }

    #[test]
    fn test_validate_and_compile_consistency() {
        // If validate says true, compile must succeed (and vice versa).
        let valid_result = wasm_validate(vec![wat_val(ADD_WAT)]).unwrap();
        let compile_result = wasm_compile(vec![wat_val(ADD_WAT)]);
        assert_eq!(valid_result, JsValue::Boolean(true));
        assert!(compile_result.is_ok());

        let invalid = JsValue::String("not wasm".to_string().into());
        let invalid_result = wasm_validate(vec![invalid.clone()]).unwrap();
        let compile_err = wasm_compile(vec![invalid]);
        assert_eq!(invalid_result, JsValue::Boolean(false));
        assert!(compile_err.is_err());
    }
}