sqlite-diff-rs 0.16.0

Build SQLite changeset and patchset binary formats programmatically, without SQLite
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
//! SQL parser for changeset/patchset operations.

use core::hash::Hash;

use crate::{
    DiffSetBuilder, PatchsetFormat, SchemaWithPK, Value, builders::operation::Operation,
    schema::NamedColumns,
};
use alloc::borrow::Cow;
use alloc::string::String;
use alloc::vec;
use alloc::vec::Vec;

use super::lexer::{Lexer, LexerError, Token, TokenKind};

/// SQL parser errors.
#[non_exhaustive]
#[derive(Debug, Clone, PartialEq, thiserror::Error)]
pub enum ParseError<'a> {
    /// Lexer error.
    #[error("Lexer error: {0}")]
    Lexer(#[from] LexerError),
    /// Unexpected token.
    #[error("Unexpected token {found:?} at position {pos}, expected {expected}")]
    UnexpectedToken {
        /// What was expected.
        expected: &'static str,
        /// What was found.
        found: TokenKind<'a>,
        /// Position in input.
        pos: usize,
    },
    /// Unexpected end of input.
    #[error("Unexpected end of input, expected {expected}")]
    UnexpectedEof {
        /// What was expected.
        expected: &'static str,
    },
    /// Empty column list.
    #[error("Empty column list in CREATE TABLE")]
    EmptyColumnList,
    /// Duplicate column name.
    #[error("Duplicate column name: {0}")]
    DuplicateColumn(String),
    /// Unknown column in PRIMARY KEY constraint.
    #[error("Unknown column '{column}' in PRIMARY KEY constraint")]
    UnknownPKColumn {
        /// The unknown column name.
        column: String,
    },
    /// Unknown table name in statement.
    #[error("Unknown table name: {0}")]
    UnknownTable(&'a str),
    /// Unknown column name in statement.
    #[error("Unknown column name: {0}")]
    UnknownColumn(&'a str),
    /// Missing WHERE clause in UPDATE or DELETE.
    #[error("Missing WHERE clause in {statement}")]
    MissingWhere {
        /// The statement type.
        statement: &'static str,
    },
    /// Where constraint on non-PK column.
    #[error("WHERE clause on non-primary key column '{column}'")]
    WhereNonPKColumn {
        /// The column name.
        column: &'a str,
    },
    /// Explicit column list has more entries than the VALUES list.
    #[error("column list names {expected} columns but VALUES has {found}")]
    ValuesLengthMismatch {
        /// Number of columns in the explicit column list.
        expected: usize,
        /// Number of values provided in the VALUES clause.
        found: usize,
    },
    /// OR is not supported in a WHERE clause.
    #[error("OR is not supported in WHERE. Use separate statements for multiple rows")]
    OrInWhere,
    /// WHERE clause does not pin every primary key column.
    #[error("WHERE must name all {expected} primary key columns, but only {found} were provided")]
    IncompleteWhereKey {
        /// Total number of primary key columns.
        expected: usize,
        /// How many were actually provided.
        found: usize,
    },
    /// `UPDATE ... SET` gives a primary key column a value other than the one its `WHERE` names.
    #[error(
        "UPDATE changes primary key column '{column}', which SQLite records as a DELETE and an INSERT of the whole row"
    )]
    PrimaryKeyUpdate {
        /// The primary key column.
        column: &'a str,
    },
    /// `INSERT` gives the rowid alias column a value SQLite cannot store as an integer.
    #[error(
        "datatype mismatch: column {column} of table '{table}' aliases the rowid and holds only integers"
    )]
    DatatypeMismatch {
        /// The table name.
        table: &'a str,
        /// Index of the rowid alias column.
        column: usize,
    },
    /// `INSERT` leaves the rowid alias column `NULL` or out, so SQLite assigns
    /// a rowid the statement does not state.
    #[error(
        "column {column} of table '{table}' aliases the rowid and needs a value, because SQLite would assign one"
    )]
    MissingRowid {
        /// The table name.
        table: &'a str,
        /// Index of the rowid alias column.
        column: usize,
    },
}

/// SQL parser. Collects operations into a pending list without applying
/// them to the builder, enabling all-or-nothing application via `into_pending`.
pub(crate) struct Parser<'input, 'builder, T: SchemaWithPK, S> {
    lexer: Lexer<'input>,
    /// Read-only access for schema lookups.
    builder: &'builder DiffSetBuilder<PatchsetFormat, T, S, Vec<u8>>,
    /// Parsed operations waiting to be applied.
    pending: Vec<PendingOp<T, S>>,
}

/// A parsed operation waiting to be applied: the table, its primary key values, and the
/// operation itself. Nothing is applied to the builder until every statement has parsed.
type PendingOp<T, S> = (
    T,
    Vec<Value<S, Vec<u8>>>,
    Operation<PatchsetFormat, S, Vec<u8>>,
);

impl<'input, 'builder, T: NamedColumns, S: Clone + Hash + Eq + AsRef<str> + for<'a> From<&'a str>>
    Parser<'input, 'builder, T, S>
{
    /// Create a new parser for the given input.
    #[must_use]
    pub(crate) fn new(
        input: &'input str,
        builder: &'builder DiffSetBuilder<PatchsetFormat, T, S, Vec<u8>>,
    ) -> Self {
        Self {
            lexer: Lexer::new(input),
            builder,
            pending: Vec::new(),
        }
    }

    /// Consume the parser and return all collected operations.
    pub(crate) fn into_pending(self) -> Vec<PendingOp<T, S>> {
        self.pending
    }

    /// Parse all statements from the input.
    ///
    /// # Errors
    ///
    /// Returns an error if parsing fails.
    pub(crate) fn digest_all(&mut self) -> Result<(), ParseError<'input>> {
        loop {
            // Skip any semicolons (leading, trailing, between statements)
            while self.lexer.peek()?.kind == TokenKind::Semicolon {
                self.lexer.next()?;
            }

            if self.lexer.peek()?.kind == TokenKind::Eof {
                break;
            }

            self.digest_statement()?;

            let next = self.lexer.peek()?;
            if !matches!(next.kind, TokenKind::Semicolon | TokenKind::Eof) {
                return Err(ParseError::UnexpectedToken {
                    expected: "; or end of input",
                    found: next.kind.clone(),
                    pos: next.pos,
                });
            }
        }

        Ok(())
    }

    /// Parse a single statement.
    fn digest_statement(&mut self) -> Result<(), ParseError<'input>> {
        let token = self.lexer.peek()?;
        match &token.kind {
            TokenKind::Insert => self.digest_insert(),
            TokenKind::Update => self.digest_update(),
            TokenKind::Delete => self.digest_delete(),
            other => Err(ParseError::UnexpectedToken {
                expected: "INSERT, UPDATE, or DELETE",
                found: other.clone(),
                pos: token.pos,
            }),
        }
    }

    /// Parse an INSERT statement.
    fn digest_insert(&mut self) -> Result<(), ParseError<'input>> {
        self.expect(&TokenKind::Insert)?;
        self.expect(&TokenKind::Into)?;

        let (table, table_name) = self.expect_table()?;

        // Column identifiers for the explicit list, empty means positional.
        // u16 is enough: SQLite's default column limit is 2000, and even with
        // SQLITE_MAX_COLUMN it cannot exceed i16::MAX.
        let mut column_identifiers: Vec<u16> = Vec::new();
        if self.lexer.peek()?.kind == TokenKind::LParen {
            self.lexer.next()?;

            loop {
                column_identifiers.push(self.expect_column(&table)?.0);
                if self.lexer.peek()?.kind != TokenKind::Comma {
                    break;
                }
                self.lexer.next()?;
            }

            self.expect(&TokenKind::RParen)?;
        }

        self.expect(&TokenKind::Values)?;
        self.expect(&TokenKind::LParen)?;

        let mut values = vec![Value::Null; table.number_of_columns()];
        let mut pks = vec![Value::Null; table.number_of_primary_keys()];

        if column_identifiers.is_empty() {
            // Positional form: values map to all columns in order.
            for (col_idx, value_ref) in values.iter_mut().enumerate() {
                if col_idx > 0 {
                    self.expect(&TokenKind::Comma)?;
                }
                *value_ref = Self::with_affinity(&table, col_idx, self.parse_value()?);
                if let Some(pk_idx) = table.primary_key_index(col_idx) {
                    pks[pk_idx] = (*value_ref).clone();
                }
            }
        } else {
            // Explicit column list: exactly one value per listed column.
            let expected = column_identifiers.len();
            let mut parsed = 0usize;
            for &column_index in &column_identifiers {
                let column_index = usize::from(column_index);
                values[column_index] =
                    Self::with_affinity(&table, column_index, self.parse_value()?);
                if let Some(primary_key_index) = table.primary_key_index(column_index) {
                    pks[primary_key_index] = values[column_index].clone();
                }
                parsed += 1;
                if self.lexer.peek()?.kind != TokenKind::Comma {
                    break;
                }
                self.lexer.next()?;
            }
            if parsed != expected {
                return Err(ParseError::ValuesLengthMismatch {
                    expected,
                    found: parsed,
                });
            }
        }

        self.expect(&TokenKind::RParen)?;

        if let Some(alias) = table.rowid_alias() {
            match values[alias] {
                Value::Integer(_) => {}
                Value::Null => {
                    return Err(ParseError::MissingRowid {
                        table: table_name,
                        column: alias,
                    });
                }
                Value::Text(_) | Value::Real(_) | Value::Blob(_) => {
                    return Err(ParseError::DatatypeMismatch {
                        table: table_name,
                        column: alias,
                    });
                }
            }
        }

        self.pending.push((
            table,
            pks,
            Operation::Insert {
                values,
                indirect: false,
            },
        ));

        Ok(())
    }

    /// Parse an UPDATE statement.
    fn digest_update(&mut self) -> Result<(), ParseError<'input>> {
        self.expect(&TokenKind::Update)?;

        let (table, _) = self.expect_table()?;
        self.expect(&TokenKind::Set)?;

        let mut new_values = vec![((), None); table.number_of_columns()];
        let mut key_sets: Vec<(usize, usize, &'input str)> = Vec::new();

        loop {
            let (col_idx, col_name) = self.expect_column(&table)?;
            let col_idx = usize::from(col_idx);
            self.expect(&TokenKind::Equals)?;
            let val = Self::with_affinity(&table, col_idx, self.parse_value()?);
            if let Some(primary_key_index) = table.primary_key_index(col_idx) {
                key_sets.push((col_idx, primary_key_index, col_name));
            }
            new_values[col_idx] = ((), Some(val));

            if self.lexer.peek()?.kind != TokenKind::Comma {
                break;
            }
            self.lexer.next()?;
        }

        if self.lexer.peek()?.kind != TokenKind::Where {
            return Err(ParseError::MissingWhere {
                statement: "UPDATE",
            });
        }

        let n_pk = table.number_of_primary_keys();
        let mut pk = vec![Value::Null; n_pk];
        let mut pk_seen = vec![false; n_pk];

        let can_match = self.digest_where(&table, |col_idx, col_name, val| {
            if let Some(primary_key_index) = table.primary_key_index(usize::from(col_idx)) {
                pk[primary_key_index] = val.clone();
                pk_seen[primary_key_index] = true;
                Ok(())
            } else {
                Err(ParseError::WhereNonPKColumn { column: col_name })
            }
        })?;

        let found = pk_seen.iter().filter(|&&s| s).count();
        if found != n_pk {
            return Err(ParseError::IncompleteWhereKey {
                expected: n_pk,
                found,
            });
        }
        if !can_match {
            return Ok(());
        }

        // A session records a key change as a DELETE plus a full-row INSERT, which SQL text cannot supply.
        if let Some(&(_, _, column)) = key_sets.iter().find(|&&(col_idx, primary_key_index, _)| {
            new_values[col_idx].1.as_ref() != Some(&pk[primary_key_index])
        }) {
            return Err(ParseError::PrimaryKeyUpdate { column });
        }

        self.pending.push((
            table,
            pk,
            Operation::Update {
                values: new_values,
                indirect: false,
            },
        ));

        Ok(())
    }

    /// Parse a DELETE statement.
    fn digest_delete(&mut self) -> Result<(), ParseError<'input>> {
        self.expect(&TokenKind::Delete)?;
        self.expect(&TokenKind::From)?;

        let (table, _) = self.expect_table()?;

        if self.lexer.peek()?.kind != TokenKind::Where {
            return Err(ParseError::MissingWhere {
                statement: "DELETE",
            });
        }

        let n_pk = table.number_of_primary_keys();
        let mut pks = vec![Value::Null; n_pk];
        let mut pk_seen = vec![false; n_pk];

        let can_match = self.digest_where(&table, |col_idx, col_name, val| {
            if let Some(primary_key_index) = table.primary_key_index(usize::from(col_idx)) {
                pks[primary_key_index] = val.clone();
                pk_seen[primary_key_index] = true;
                Ok(())
            } else {
                Err(ParseError::WhereNonPKColumn { column: col_name })
            }
        })?;

        let found = pk_seen.iter().filter(|&&s| s).count();
        if found != n_pk {
            return Err(ParseError::IncompleteWhereKey {
                expected: n_pk,
                found,
            });
        }
        if !can_match {
            return Ok(());
        }

        self.pending.push((
            table,
            pks,
            Operation::Delete {
                data: (),
                indirect: false,
            },
        ));

        Ok(())
    }

    /// Parse a WHERE clause, calling `digestor` for each `col = val` predicate
    /// with the literal converted by the column's affinity, as SQLite compares it.
    /// Fails with `OrInWhere` if `OR` appears after a predicate.
    ///
    /// Returns whether a row can satisfy every predicate. A predicate cannot
    /// hold when its value is `NULL`, or is not an integer on a rowid alias.
    fn digest_where<D>(&mut self, table: &T, mut digestor: D) -> Result<bool, ParseError<'input>>
    where
        D: FnMut(u16, &'input str, Value<S, Vec<u8>>) -> Result<(), ParseError<'input>>,
    {
        self.expect(&TokenKind::Where)?;

        let mut can_match = true;
        loop {
            let (col_idx, col_name) = self.expect_column(table)?;
            self.expect(&TokenKind::Equals)?;
            let val = Self::with_affinity(table, usize::from(col_idx), self.parse_value()?);
            can_match &= match val {
                Value::Null => false,
                Value::Integer(_) => true,
                Value::Real(_) | Value::Text(_) | Value::Blob(_) => {
                    table.rowid_alias() != Some(usize::from(col_idx))
                }
            };
            digestor(col_idx, col_name, val)?;

            if self.lexer.peek()?.kind != TokenKind::And {
                if self.lexer.peek()?.kind == TokenKind::Or {
                    return Err(ParseError::OrInWhere);
                }
                break;
            }
            self.lexer.next()?;
        }

        Ok(can_match)
    }

    /// `value` as SQLite stores or compares it in column `col_idx` of `table`.
    fn with_affinity(table: &T, col_idx: usize, value: Value<S, Vec<u8>>) -> Value<S, Vec<u8>> {
        match table.column_affinity(col_idx) {
            Some(affinity) => affinity.apply(value),
            None => value,
        }
    }

    /// Parse a value literal.
    fn parse_value(&mut self) -> Result<Value<S, Vec<u8>>, ParseError<'input>> {
        let token = self.lexer.next()?;
        match token.kind {
            TokenKind::Null => Ok(Value::Null),
            // The lexer caps integers at 2^63, the one integer literal past i64::MAX.
            TokenKind::IntegerLiteral(v) => {
                Ok(i64::try_from(v).map_or(Value::Real(TWO_POW_63), Value::Integer))
            }
            TokenKind::RealLiteral(v) => Ok(Value::Real(v)),
            TokenKind::StringLiteral(s) => {
                let text: S = match s {
                    Cow::Borrowed(b) => S::from(b),
                    Cow::Owned(o) => S::from(o.as_str()),
                };
                Ok(Value::Text(text))
            }
            TokenKind::BlobLiteral(b) => Ok(Value::Blob(b)),
            TokenKind::Minus => {
                let next = self.lexer.next()?;
                match next.kind {
                    TokenKind::IntegerLiteral(v) => {
                        debug_assert!(v <= 1 << 63, "the lexer caps integers at 2^63");
                        Ok(Value::Integer(
                            0_i64.checked_sub_unsigned(v).unwrap_or(i64::MIN),
                        ))
                    }
                    TokenKind::RealLiteral(v) => Ok(Value::Real(-v)),
                    other => Err(ParseError::UnexpectedToken {
                        expected: "number after minus",
                        found: other,
                        pos: next.pos,
                    }),
                }
            }
            other => Err(ParseError::UnexpectedToken {
                expected: "value (NULL, number, string, or blob)",
                found: other,
                pos: token.pos,
            }),
        }
    }

    /// Expect a specific token kind.
    fn expect(
        &mut self,
        expected: &TokenKind<'input>,
    ) -> Result<Token<'input>, ParseError<'input>> {
        let token = self.lexer.next()?;
        if core::mem::discriminant(&token.kind) == core::mem::discriminant(expected) {
            Ok(token)
        } else {
            Err(ParseError::UnexpectedToken {
                expected: expected.static_name(),
                found: token.kind,
                pos: token.pos,
            })
        }
    }

    /// Expects a column identifier and returns the corresponding column index in the table schema.
    fn expect_column(&mut self, table: &T) -> Result<(u16, &'input str), ParseError<'input>> {
        let column_name = self.expect_identifier()?;
        #[allow(clippy::cast_possible_truncation)]
        table
            .column_index(column_name)
            .map(|idx| (idx as u16, column_name))
            .ok_or(ParseError::UnknownColumn(column_name))
    }

    /// Expects a table existing in the builder's schema and returns a clone and its name.
    fn expect_table(&mut self) -> Result<(T, &'input str), ParseError<'input>> {
        let table_name = self.expect_identifier()?;
        self.builder
            .table(table_name)
            .cloned()
            .map(|table| (table, table_name))
            .ok_or(ParseError::UnknownTable(table_name))
    }

    /// Expect an identifier and return its name.
    fn expect_identifier(&mut self) -> Result<&'input str, ParseError<'input>> {
        let token = self.lexer.next()?;
        match token.kind {
            TokenKind::Identifier(name) => Ok(name),
            // Also accept keywords as identifiers (common in SQL)
            TokenKind::Insert => Ok("INSERT"),
            TokenKind::Into => Ok("INTO"),
            TokenKind::Values => Ok("VALUES"),
            TokenKind::Update => Ok("UPDATE"),
            TokenKind::Set => Ok("SET"),
            TokenKind::Delete => Ok("DELETE"),
            TokenKind::From => Ok("FROM"),
            TokenKind::Where => Ok("WHERE"),
            TokenKind::And => Ok("AND"),
            TokenKind::Or => Ok("OR"),
            TokenKind::Primary => Ok("PRIMARY"),
            TokenKind::Key => Ok("KEY"),
            TokenKind::Null => Ok("NULL"),
            TokenKind::Integer => Ok("INTEGER"),
            TokenKind::Int => Ok("INT"),
            TokenKind::Real => Ok("REAL"),
            TokenKind::Text => Ok("TEXT"),
            TokenKind::Blob => Ok("BLOB"),
            TokenKind::Not => Ok("NOT"),
            other => Err(ParseError::UnexpectedToken {
                expected: "identifier",
                found: other,
                pos: token.pos,
            }),
        }
    }
}

/// `9223372036854775808`, which SQLite reads as a real unless negated.
const TWO_POW_63: f64 = 9_223_372_036_854_775_808.0;

#[cfg(test)]
mod tests {
    use alloc::string::String;
    use alloc::vec::Vec;

    use crate::schema::SimpleTable;
    use crate::{DiffSetBuilder, PatchsetFormat};

    fn make_builder(
        tables: &[SimpleTable],
    ) -> DiffSetBuilder<PatchsetFormat, SimpleTable, String, Vec<u8>> {
        let mut builder = DiffSetBuilder::default();
        for t in tables {
            builder.add_table(t);
        }
        builder
    }

    #[test]
    fn test_digest_insert() {
        let users =
            SimpleTable::with_rowid_alias("users", &[("id", "INTEGER"), ("name", "TEXT")], 0);
        let mut builder = make_builder(&[users]);
        builder
            .digest_sql("INSERT INTO users (id, name) VALUES (1, 'Alice')")
            .unwrap();
        assert_eq!(builder.len(), 1);
        assert_ne!(builder.build(), [] as [u8; 0]);
    }

    #[test]
    fn test_digest_insert_positional() {
        let users =
            SimpleTable::with_rowid_alias("users", &[("id", "INTEGER"), ("name", "TEXT")], 0);
        let mut builder = make_builder(&[users]);
        builder
            .digest_sql("INSERT INTO users VALUES (1, 'Alice')")
            .unwrap();
        assert_eq!(builder.len(), 1);
    }

    #[test]
    fn test_digest_update() {
        let users =
            SimpleTable::with_rowid_alias("users", &[("id", "INTEGER"), ("name", "TEXT")], 0);
        let mut builder = make_builder(&[users]);
        builder
            .digest_sql("UPDATE users SET name = 'Bob' WHERE id = 1")
            .unwrap();
        assert_eq!(builder.len(), 1);
        assert_ne!(builder.build(), [] as [u8; 0]);
    }

    #[test]
    fn test_digest_delete() {
        let users =
            SimpleTable::with_rowid_alias("users", &[("id", "INTEGER"), ("name", "TEXT")], 0);
        let mut builder = make_builder(&[users]);
        builder
            .digest_sql("DELETE FROM users WHERE id = 1")
            .unwrap();
        assert_eq!(builder.len(), 1);
        assert_ne!(builder.build(), [] as [u8; 0]);
    }

    #[test]
    fn test_digest_delete_rejects_non_pk_in_where() {
        let users = SimpleTable::with_rowid_alias(
            "users",
            &[("id", "INTEGER"), ("name", "TEXT"), ("status", "TEXT")],
            0,
        );
        let mut builder = make_builder(&[users]);
        let result = builder.digest_sql("DELETE FROM users WHERE id = 1 AND status = 'active'");
        assert!(result.is_err());
    }

    #[test]
    fn test_digest_multiple_dml() {
        let users =
            SimpleTable::with_rowid_alias("users", &[("id", "INTEGER"), ("name", "TEXT")], 0);
        let mut builder = make_builder(&[users]);
        builder
            .digest_sql(
                "INSERT INTO users (id, name) VALUES (1, 'Alice');\
                 INSERT INTO users (id, name) VALUES (2, 'Bob');\
                 DELETE FROM users WHERE id = 1;",
            )
            .unwrap();
        // INSERT(1) + INSERT(2) + DELETE(1) leaves only INSERT(2)
        assert_eq!(builder.len(), 1);
        assert_ne!(builder.build(), [] as [u8; 0]);
    }

    #[test]
    fn test_digest_create_table_rejected() {
        let mut builder: DiffSetBuilder<PatchsetFormat, SimpleTable, String, Vec<u8>> =
            DiffSetBuilder::default();
        let result = builder.digest_sql("CREATE TABLE users (id INTEGER PRIMARY KEY, name TEXT)");
        assert!(result.is_err());
    }

    #[test]
    fn test_digest_blob_value() {
        let t = SimpleTable::new("t", &[("data", "BLOB")], &[0]);
        let mut builder = make_builder(&[t]);
        builder
            .digest_sql("INSERT INTO t (data) VALUES (X'DEADBEEF')")
            .unwrap();
        assert_eq!(builder.len(), 1);
    }

    #[test]
    fn test_digest_null_value() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        builder
            .digest_sql("INSERT INTO t (id, v) VALUES (1, NULL)")
            .unwrap();
        assert_eq!(builder.len(), 1);
    }

    #[test]
    fn test_digest_negative_numbers() {
        let t = SimpleTable::new("t", &[("a", "INTEGER"), ("b", "REAL")], &[0]);
        let mut builder = make_builder(&[t]);
        builder
            .digest_sql("INSERT INTO t (a, b) VALUES (-42, -3.14)")
            .unwrap();
        assert_eq!(builder.len(), 1);
    }

    #[test]
    fn test_digest_keyword_column_names() {
        // Each reserved keyword is a column name. This forces expect_identifier
        // to take every keyword arm. The names registered on the schema match
        // the uppercase constants the parser returns for those arms.
        let cols: [(&str, &str); 18] = [
            ("INSERT", "INTEGER"),
            ("INTO", "INTEGER"),
            ("VALUES", "INTEGER"),
            ("UPDATE", "INTEGER"),
            ("SET", "INTEGER"),
            ("DELETE", "INTEGER"),
            ("FROM", "INTEGER"),
            ("WHERE", "INTEGER"),
            ("AND", "INTEGER"),
            ("PRIMARY", "INTEGER"),
            ("KEY", "INTEGER"),
            ("NULL", "INTEGER"),
            ("INTEGER", "INTEGER"),
            ("INT", "INTEGER"),
            ("REAL", "INTEGER"),
            ("TEXT", "INTEGER"),
            ("BLOB", "INTEGER"),
            ("NOT", "INTEGER"),
        ];
        let t = SimpleTable::new("kwords", &cols, &[0]);
        let mut builder = make_builder(&[t]);
        builder
            .digest_sql(
                "INSERT INTO kwords (insert, into, values, update, set, delete, from, where, and, primary, key, null, integer, int, real, text, blob, not) \
                 VALUES (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18)",
            )
            .unwrap();
        assert_eq!(builder.len(), 1);
    }

    // ---- ParseError variant tests ----

    use crate::builders::sql::ParseError;

    #[test]
    fn test_digest_insert_missing_into() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder.digest_sql("INSERT FROM t").unwrap_err();
        assert!(matches!(err, ParseError::UnexpectedToken { .. }));
    }

    #[test]
    fn test_digest_insert_unknown_table() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder
            .digest_sql("INSERT INTO unknown_table VALUES (1)")
            .unwrap_err();
        assert!(matches!(err, ParseError::UnknownTable("unknown_table")));
    }

    #[test]
    fn test_digest_update_missing_where() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder.digest_sql("UPDATE t SET v = 1").unwrap_err();
        assert!(matches!(
            err,
            ParseError::MissingWhere {
                statement: "UPDATE"
            }
        ));
    }

    #[test]
    fn test_digest_delete_missing_where() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder.digest_sql("DELETE FROM t").unwrap_err();
        assert!(matches!(
            err,
            ParseError::MissingWhere {
                statement: "DELETE"
            }
        ));
    }

    #[test]
    fn test_digest_update_where_non_pk_column() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder
            .digest_sql("UPDATE t SET v = 2 WHERE v = 1")
            .unwrap_err();
        assert!(matches!(err, ParseError::WhereNonPKColumn { column: "v" }));
    }

    #[test]
    fn test_digest_unexpected_top_level_token() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder.digest_sql("SELECT 1").unwrap_err();
        assert!(matches!(err, ParseError::UnexpectedToken { .. }));
    }

    #[test]
    fn test_digest_expect_identifier_rejects_value_token() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        // Integer literal where a table name is expected.
        let err = builder.digest_sql("INSERT INTO 42 VALUES (1)").unwrap_err();
        assert!(matches!(err, ParseError::UnexpectedToken { .. }));
    }

    #[test]
    fn test_digest_update_changing_key_refused() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        builder.digest_sql("INSERT INTO t VALUES (5, 1)").unwrap();
        let before = builder.build();
        let err = builder
            .digest_sql("UPDATE t SET id = 7 WHERE id = 5")
            .unwrap_err();
        assert_eq!(err, ParseError::PrimaryKeyUpdate { column: "id" });
        assert_eq!(builder.build(), before);
    }

    #[test]
    fn test_digest_update_changing_one_composite_key_column_refused() {
        let t = SimpleTable::new(
            "t",
            &[("a", "INTEGER"), ("b", "INTEGER"), ("v", "INTEGER")],
            &[0, 1],
        );
        let mut builder = make_builder(&[t]);
        let err = builder
            .digest_sql("UPDATE t SET v = 0, b = 9 WHERE a = 1 AND b = 2")
            .unwrap_err();
        assert_eq!(err, ParseError::PrimaryKeyUpdate { column: "b" });
        assert!(builder.is_empty());
    }

    #[test]
    fn test_digest_unterminated_comment_swallows_closing_paren() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder
            .digest_sql("INSERT INTO t VALUES (1, 2 /* never closed)")
            .unwrap_err();
        assert!(matches!(err, ParseError::UnexpectedToken { .. }), "{err:?}");
        assert!(builder.is_empty());
    }
    #[test]
    fn test_digest_update_and_delete_reject_bare_trailing_block_comment() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        for sql in [
            "UPDATE t SET v = 3 WHERE id = 1 /*",
            "DELETE FROM t WHERE id = 1 /*",
        ] {
            let mut builder = make_builder(core::slice::from_ref(&t));
            builder.digest_sql("INSERT INTO t VALUES (5, 6)").unwrap();
            let before = builder.build();
            let err = builder.digest_sql(sql).unwrap_err();
            assert!(
                matches!(
                    err,
                    ParseError::Lexer(super::super::lexer::LexerError::UnexpectedChar {
                        char: '/',
                        pos
                    }) if pos == sql.len() - 2
                ),
                "{sql}: {err:?}"
            );
            assert_eq!(builder.build(), before, "{sql}");
        }
    }

    #[test]
    fn test_digest_bare_trailing_block_comment_rolls_back_batch() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "INTEGER")], 0);
        let mut builder = make_builder(&[t]);
        builder.digest_sql("INSERT INTO t VALUES (5, 6)").unwrap();
        let before = builder.build();
        let sql = "INSERT INTO t VALUES (1, 2); INSERT INTO t VALUES (3, 4)/*";
        assert!(matches!(
            builder.digest_sql(sql),
            Err(ParseError::Lexer(
                super::super::lexer::LexerError::UnexpectedChar { char: '/', .. }
            ))
        ));
        assert_eq!(builder.build(), before);
    }

    #[test]
    fn test_digest_statements_need_a_separator() {
        let t = SimpleTable::with_rowid_alias("t", &[("id", "INTEGER"), ("v", "")], 0);
        let mut builder = make_builder(&[t]);
        let err = builder
            .digest_sql("INSERT INTO t VALUES (1, 2) INSERT INTO t VALUES (3, 4)")
            .unwrap_err();
        assert!(matches!(err, ParseError::UnexpectedToken { .. }), "{err:?}");
        assert!(builder.is_empty());
        builder
            .digest_sql("INSERT INTO t VALUES (1, 2);INSERT INTO t VALUES (3, 4);")
            .unwrap();
        assert_eq!(builder.len(), 2);
    }

    #[test]
    fn test_digest_rowid_alias_refuses_non_integer_key() {
        let k = SimpleTable::with_rowid_alias("k", &[("v", ""), ("id", "INTEGER")], 1);
        let mut builder = make_builder(&[k]);
        builder.digest_sql("INSERT INTO k VALUES (1, 1)").unwrap();
        let before = builder.build();
        for sql in [
            "INSERT INTO k VALUES (1, 'abc')",
            "INSERT INTO k (id, v) VALUES (7.5, 1)",
            "INSERT INTO k VALUES (1, X'07')",
            "INSERT INTO k VALUES (2, 2); INSERT INTO k VALUES (1, '7a')",
        ] {
            let err = builder.digest_sql(sql).unwrap_err();
            assert_eq!(
                err,
                ParseError::DatatypeMismatch {
                    table: "k",
                    column: 1
                },
                "{sql}"
            );
            assert_eq!(builder.build(), before, "{sql}");
        }
    }

    #[test]
    fn test_digest_rowid_alias_refuses_null_or_omitted_key() {
        let k = SimpleTable::with_rowid_alias("k", &[("v", ""), ("id", "INTEGER")], 1);
        let mut builder = make_builder(&[k]);
        builder.digest_sql("INSERT INTO k VALUES (1, 1)").unwrap();
        let before = builder.build();
        for sql in [
            "INSERT INTO k VALUES (1, NULL)",
            "INSERT INTO k (v) VALUES (1)",
        ] {
            let err = builder.digest_sql(sql).unwrap_err();
            assert_eq!(
                err,
                ParseError::MissingRowid {
                    table: "k",
                    column: 1
                },
                "{sql}"
            );
            assert_eq!(builder.build(), before, "{sql}");
        }
    }
}