sql_query_analyzer 0.5.2

Static analysis tool for SQL queries with 20 built-in rules for performance, security, and style
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
//! Application logic for the SQL Query Analyzer CLI.
//!
//! This module contains the core application logic separated from the main
//! entry point to enable testing. It orchestrates CLI command execution,
//! configuration handling, and analysis pipeline coordination.
//!
//! # Module Structure
//!
//! The application logic is organized into focused submodules:
//!
//! - `types`: Core data structures for command parameters and results
//! - `convert`: Type conversion between CLI and internal representations
//! - `helpers`: Utility functions for common operations
//! - `analyze`: SQL analysis execution logic
//!
//! # Architecture
//!
//! The CLI application follows a layered architecture:
//!
//! ```text
//! ┌─────────────────────────────────────────┐
//! │                 main.rs                 │
//! │         (Entry point, CLI parsing)      │
//! └─────────────────┬───────────────────────┘
//!//! ┌─────────────────▼───────────────────────┐
//! │              app/mod.rs                 │
//! │     (Command execution, orchestration)  │
//! └─────────────────┬───────────────────────┘
//!//! ┌─────────────────▼───────────────────────┐
//! │            app/analyze.rs               │
//! │       (Analysis pipeline logic)         │
//! └─────────────────┬───────────────────────┘
//!//! ┌─────────────────▼───────────────────────┐
//! │   schema, query, rules, llm, output     │
//! │          (Domain modules)               │
//! └─────────────────────────────────────────┘
//! ```
//!
//! # Example
//!
//! ```no_run
//! use sql_query_analyzer::{
//!     app::{CommandOutput, execute_command},
//!     cli::Commands,
//!     config::Config
//! };
//!
//! # async fn example() -> Result<(), Box<dyn std::error::Error>> {
//! // Parse CLI arguments and execute the command
//! let command = Commands::Analyze {
//!     schema:        "schema.sql".into(),
//!     queries:       "queries.sql".into(),
//!     provider:      sql_query_analyzer::cli::Provider::Ollama,
//!     api_key:       None,
//!     model:         None,
//!     ollama_url:    "http://localhost:11434".to_string(),
//!     dialect:       sql_query_analyzer::cli::Dialect::Generic,
//!     output_format: sql_query_analyzer::cli::Format::Text,
//!     verbose:       false,
//!     dry_run:       false,
//!     no_color:      false
//! };
//!
//! let config = Config::default();
//! let output = execute_command(command, config).await?;
//! println!("Exit code: {}", output.exit_code);
//! # Ok(())
//! # }
//! ```

mod analyze;
mod convert;
mod helpers;
mod types;

#[allow(unused_imports)]
pub use analyze::run_analyze;
#[allow(unused_imports)]
pub use convert::{convert_dialect, convert_format};
#[allow(unused_imports)]
pub use helpers::{
    build_llm_provider, calculate_exit_code, create_output_options, get_effective_model,
    get_effective_ollama_url, has_llm_access, parse_queries_cached, read_queries_input
};
#[allow(unused_imports)]
pub use types::{AnalyzeParams, AnalyzeResult, CommandOutput, DryRunInfo};

use crate::{cli::Commands, config::Config, error::AppResult};

/// Executes a CLI command and produces output ready for display.
///
/// This is the main entry point for command execution after CLI parsing.
/// It dispatches to the appropriate handler based on the command variant
/// and formats the results for terminal output.
///
/// # Arguments
///
/// * `command` - The parsed CLI command to execute
/// * `config` - Application configuration loaded from file or defaults
///
/// # Returns
///
/// A `CommandOutput` containing:
/// - `exit_code`: Process exit code (0=success, 1=warnings, 2=errors)
/// - `stdout`: Lines to be printed to standard output
///
/// # Errors
///
/// Returns an error if:
/// - Schema or query files cannot be read
/// - SQL parsing fails
/// - LLM API call fails (when LLM analysis is enabled)
///
/// # Exit Codes
///
/// The function returns different exit codes based on analysis results:
///
/// | Code | Meaning |
/// |------|---------|
/// | 0 | Success - no violations or info only |
/// | 1 | Warnings detected |
/// | 2 | Errors detected |
///
/// # Example
///
/// ```no_run
/// use std::path::PathBuf;
///
/// use sql_query_analyzer::{
///     app::{CommandOutput, execute_command},
///     cli::{Commands, Dialect, Format, Provider},
///     config::Config
/// };
///
/// # async fn example() -> Result<(), Box<dyn std::error::Error>> {
/// let command = Commands::Analyze {
///     schema:        PathBuf::from("schema.sql"),
///     queries:       PathBuf::from("queries.sql"),
///     provider:      Provider::Ollama,
///     api_key:       None,
///     model:         None,
///     ollama_url:    "http://localhost:11434".to_string(),
///     dialect:       Dialect::Generic,
///     output_format: Format::Text,
///     verbose:       false,
///     dry_run:       false,
///     no_color:      false
/// };
///
/// let config = Config::default();
/// let output = execute_command(command, config).await?;
///
/// for line in &output.stdout {
///     println!("{}", line);
/// }
///
/// std::process::exit(output.exit_code);
/// # Ok(())
/// # }
/// ```
pub async fn execute_command(command: Commands, config: Config) -> AppResult<CommandOutput> {
    match command {
        Commands::Analyze {
            schema,
            queries,
            provider,
            api_key,
            model,
            ollama_url,
            dialect,
            output_format,
            verbose,
            dry_run,
            no_color
        } => {
            let params = AnalyzeParams {
                schema_path: schema.display().to_string(),
                queries_path: if queries.to_str() == Some("-") {
                    "-".to_string()
                } else {
                    queries.display().to_string()
                },
                provider,
                api_key,
                model,
                ollama_url,
                dialect,
                output_format,
                verbose,
                dry_run,
                no_color
            };

            let result = run_analyze(params, config).await?;
            let mut stdout = vec![result.static_output];

            if let Some(dry_run_info) = result.dry_run_info {
                stdout.push("=== DRY RUN - Would send to LLM ===\n".to_string());
                stdout.push(format!(
                    "Schema Summary:\n{}\n",
                    dry_run_info.schema_summary
                ));
                stdout.push(format!(
                    "Queries Summary:\n{}",
                    dry_run_info.queries_summary
                ));
            } else if result.llm_output.is_none() && !dry_run {
                stdout.push(
                    "Note: Set LLM_API_KEY for additional AI-powered analysis\n".to_string()
                );
            }

            if let Some(llm_output) = result.llm_output {
                stdout.push(llm_output);
            }

            Ok(CommandOutput {
                exit_code: result.exit_code,
                stdout
            })
        }
    }
}

#[cfg(test)]
mod tests {
    use std::{io::Write, path::PathBuf};

    use tempfile::NamedTempFile;

    use super::*;
    use crate::cli::{Dialect, Format, Provider};

    #[tokio::test]
    async fn test_execute_command_success() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE users (id INT PRIMARY KEY);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM users;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert_eq!(result.exit_code, 0);
        assert!(!result.stdout.is_empty());
    }

    #[tokio::test]
    async fn test_execute_command_dry_run() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE test (id INT);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM test;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       true,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        let output = result.stdout.join("\n");
        assert!(output.contains("DRY RUN"));
        assert!(output.contains("Schema Summary"));
        assert!(output.contains("Queries Summary"));
    }

    #[tokio::test]
    async fn test_execute_command_file_not_found() {
        let command = Commands::Analyze {
            schema:        PathBuf::from("/nonexistent/schema.sql"),
            queries:       PathBuf::from("/nonexistent/queries.sql"),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await;
        assert!(result.is_err());
    }

    #[tokio::test]
    async fn test_execute_command_with_violations() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE orders (id INT);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT * FROM orders;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert!(result.exit_code >= 0);
    }

    #[tokio::test]
    async fn test_execute_command_json_format() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE items (id INT PRIMARY KEY);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM items;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Json,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        let output = result.stdout.join("");
        assert!(output.contains("{") || output.contains("queries_analyzed"));
    }

    #[tokio::test]
    async fn test_execute_command_verbose() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE logs (id INT);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM logs;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       true,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert!(!result.stdout.is_empty());
    }

    #[tokio::test]
    async fn test_execute_command_yaml_format() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE events (id INT);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM events;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Yaml,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert!(!result.stdout.is_empty());
    }

    #[tokio::test]
    async fn test_execute_command_sarif_format() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE metrics (id INT);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM metrics;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Sarif,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        let output = result.stdout.join("");
        assert!(output.contains("sarif") || output.contains("$schema"));
    }

    #[tokio::test]
    async fn test_execute_command_stdin_path() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE stdin_test (id INT);").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       PathBuf::from("-"),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Generic,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       true,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await;
        assert!(result.is_err() || result.is_ok());
    }

    #[tokio::test]
    async fn test_execute_command_mysql_dialect() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE t (id INT PRIMARY KEY);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM t;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Mysql,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert_eq!(result.exit_code, 0);
    }

    #[tokio::test]
    async fn test_execute_command_postgresql_dialect() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE t (id INT PRIMARY KEY);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM t;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Postgresql,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert_eq!(result.exit_code, 0);
    }

    #[tokio::test]
    async fn test_execute_command_sqlite_dialect() {
        let mut schema_file = NamedTempFile::new().unwrap();
        writeln!(schema_file, "CREATE TABLE t (id INTEGER PRIMARY KEY);").unwrap();

        let mut queries_file = NamedTempFile::new().unwrap();
        writeln!(queries_file, "SELECT id FROM t;").unwrap();

        let command = Commands::Analyze {
            schema:        schema_file.path().to_path_buf(),
            queries:       queries_file.path().to_path_buf(),
            provider:      Provider::OpenAI,
            api_key:       None,
            model:         None,
            ollama_url:    "http://localhost:11434".to_string(),
            dialect:       Dialect::Sqlite,
            output_format: Format::Text,
            verbose:       false,
            dry_run:       false,
            no_color:      true
        };

        let config = Config::default();
        let result = execute_command(command, config).await.unwrap();
        assert_eq!(result.exit_code, 0);
    }
}