sql-splitter 1.8.0

High-performance CLI tool for splitting large SQL dump files into individual table files
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
//! Integration tests for the validate command
//!
//! Tests cover:
//! - Basic validation (valid dump, missing table, duplicate PK, FK violations)
//! - Configuration options (max rows, no-fk-checks, strict mode)
//! - Multi-dialect handling (MySQL, PostgreSQL, SQLite)
//! - Split→Merge→Validate roundtrip tests
//! - Test data generator fixtures for realistic multi-table scenarios

use sql_splitter::merger::Merger;
use sql_splitter::parser::SqlDialect;
use sql_splitter::splitter::Splitter;
use sql_splitter::validate::{ValidateOptions, ValidationSummary, Validator};
use std::io::Write;
use tempfile::{NamedTempFile, TempDir};
use test_data_gen::{Generator, RenderConfig, Renderer, Scale};

fn create_temp_sql(content: &str) -> NamedTempFile {
    let mut file = NamedTempFile::new().unwrap();
    file.write_all(content.as_bytes()).unwrap();
    file.flush().unwrap();
    file
}

fn validate_sql(content: &str, fk_checks: bool) -> ValidationSummary {
    validate_sql_with_dialect(content, SqlDialect::MySql, fk_checks)
}

fn validate_sql_with_dialect(content: &str, dialect: SqlDialect, fk_checks: bool) -> ValidationSummary {
    let file = create_temp_sql(content);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(dialect),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 1_000_000,
        fk_checks_enabled: fk_checks,
    };
    let validator = Validator::new(options);
    validator.validate().unwrap()
}

fn validate_file(path: &std::path::Path, dialect: SqlDialect, fk_checks: bool) -> ValidationSummary {
    let options = ValidateOptions {
        path: path.to_path_buf(),
        dialect: Some(dialect),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 1_000_000,
        fk_checks_enabled: fk_checks,
    };
    let validator = Validator::new(options);
    validator.validate().unwrap()
}

/// Generate a MySQL dump with test_data_gen
fn generate_mysql_dump(seed: u64, scale: Scale) -> NamedTempFile {
    let mut gen = Generator::new(seed, scale);
    let data = gen.generate();
    let renderer = Renderer::new(RenderConfig::mysql());
    let output = renderer.render_to_string(&data).unwrap();
    create_temp_sql(&output)
}

/// Generate a PostgreSQL dump with test_data_gen
fn generate_postgres_dump_file(seed: u64, scale: Scale) -> NamedTempFile {
    let mut gen = Generator::new(seed, scale);
    let data = gen.generate();
    let renderer = Renderer::new(RenderConfig::postgres());
    let output = renderer.render_to_string(&data).unwrap();
    create_temp_sql(&output)
}

/// Generate a SQLite dump with test_data_gen
fn generate_sqlite_dump_file(seed: u64, scale: Scale) -> NamedTempFile {
    let mut gen = Generator::new(seed, scale);
    let data = gen.generate();
    let renderer = Renderer::new(RenderConfig::sqlite());
    let output = renderer.render_to_string(&data).unwrap();
    create_temp_sql(&output)
}

#[test]
fn test_validate_valid_dump() {
    let sql = r#"
        CREATE TABLE `users` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        INSERT INTO `users` VALUES (1, 'Alice'), (2, 'Bob');
    "#;

    let summary = validate_sql(sql, true);
    assert_eq!(summary.summary.errors, 0);
    assert_eq!(summary.summary.warnings, 0);
    assert_eq!(summary.summary.tables_scanned, 1);
}

#[test]
fn test_validate_missing_table() {
    let sql = r#"
        INSERT INTO `nonexistent_table` VALUES (1, 'test');
    "#;

    let summary = validate_sql(sql, false);
    assert_eq!(summary.summary.errors, 1);
    
    let issue = &summary.issues[0];
    assert_eq!(issue.code, "DDL_MISSING_TABLE");
    assert!(issue.message.contains("nonexistent_table"));
}

#[test]
fn test_validate_duplicate_pk() {
    let sql = r#"
        CREATE TABLE `users` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        INSERT INTO `users` VALUES (1, 'Alice');
        INSERT INTO `users` VALUES (2, 'Bob');
        INSERT INTO `users` VALUES (1, 'Charlie');
    "#;

    let summary = validate_sql(sql, true);
    assert_eq!(summary.summary.errors, 1);
    
    let pk_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "DUPLICATE_PK").collect();
    assert_eq!(pk_issues.len(), 1);
    assert!(pk_issues[0].message.contains("users"));
}

#[test]
fn test_validate_fk_missing_parent() {
    let sql = r#"
        CREATE TABLE `departments` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        CREATE TABLE `employees` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255),
            `department_id` INT,
            CONSTRAINT `fk_dept` FOREIGN KEY (`department_id`) REFERENCES `departments` (`id`)
        );
        INSERT INTO `departments` VALUES (1, 'Engineering');
        INSERT INTO `employees` VALUES (1, 'Alice', 1);
        INSERT INTO `employees` VALUES (2, 'Bob', 99);
    "#;

    let summary = validate_sql(sql, true);
    assert_eq!(summary.summary.errors, 1);
    
    let fk_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "FK_MISSING_PARENT").collect();
    assert_eq!(fk_issues.len(), 1);
    assert!(fk_issues[0].message.contains("departments"));
}

#[test]
fn test_validate_no_fk_checks() {
    let sql = r#"
        CREATE TABLE `users` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        INSERT INTO `users` VALUES (1, 'Alice');
        INSERT INTO `users` VALUES (1, 'Bob');
    "#;

    // With FK checks disabled, we shouldn't detect duplicate PK
    let summary = validate_sql(sql, false);
    
    let pk_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "DUPLICATE_PK").collect();
    assert_eq!(pk_issues.len(), 0);
}

#[test]
fn test_validate_encoding_issue() {
    let mut file = NamedTempFile::new().unwrap();
    
    // Write some valid SQL first
    file.write_all(b"CREATE TABLE `test` (`id` INT);\n").unwrap();
    // Write invalid UTF-8 bytes
    file.write_all(&[0xFF, 0xFE, 0x00, 0x01]).unwrap();
    file.flush().unwrap();

    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::MySql),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 1_000_000,
        fk_checks_enabled: false,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    // Should have encoding warning
    let encoding_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "ENCODING").collect();
    assert!(!encoding_issues.is_empty() || summary.summary.errors > 0);
}

#[test]
fn test_validate_postgres_skips_fk_checks() {
    let sql = r#"
        CREATE TABLE users (
            id SERIAL PRIMARY KEY,
            name VARCHAR(255)
        );
        INSERT INTO users VALUES (1, 'Alice');
    "#;

    let file = create_temp_sql(sql);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::Postgres),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 1_000_000,
        fk_checks_enabled: true,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    // Should have info about FK checks being skipped
    let info_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "FK_CHECK_UNSUPPORTED").collect();
    assert_eq!(info_issues.len(), 1);
}

#[test]
fn test_validate_max_rows_per_table() {
    let sql = r#"
        CREATE TABLE `users` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        INSERT INTO `users` VALUES (1, 'A'), (2, 'B'), (3, 'C'), (4, 'D'), (5, 'E');
    "#;

    let file = create_temp_sql(sql);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::MySql),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 3, // Small limit to trigger skip
        fk_checks_enabled: true,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    // Should have warning about skipping checks
    let skip_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "PK_CHECK_SKIPPED").collect();
    assert_eq!(skip_issues.len(), 1);
}

#[test]
fn test_validate_composite_pk() {
    let sql = r#"
        CREATE TABLE `order_items` (
            `order_id` INT,
            `item_id` INT,
            `quantity` INT,
            PRIMARY KEY (`order_id`, `item_id`)
        );
        INSERT INTO `order_items` VALUES (1, 1, 5), (1, 2, 3), (2, 1, 1);
        INSERT INTO `order_items` VALUES (1, 1, 10);
    "#;

    let summary = validate_sql(sql, true);
    
    let pk_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "DUPLICATE_PK").collect();
    assert_eq!(pk_issues.len(), 1);
    assert!(pk_issues[0].message.contains("order_items"));
}

#[test]
fn test_validate_null_fk_allowed() {
    let sql = r#"
        CREATE TABLE `departments` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        CREATE TABLE `employees` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255),
            `department_id` INT,
            CONSTRAINT `fk_dept` FOREIGN KEY (`department_id`) REFERENCES `departments` (`id`)
        );
        INSERT INTO `departments` VALUES (1, 'Engineering');
        INSERT INTO `employees` VALUES (1, 'Alice', 1);
        INSERT INTO `employees` VALUES (2, 'Bob', NULL);
    "#;

    let summary = validate_sql(sql, true);
    
    // NULL FK should be allowed - no FK violation
    let fk_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "FK_MISSING_PARENT").collect();
    assert_eq!(fk_issues.len(), 0);
}

#[test]
fn test_validate_multiple_tables() {
    let sql = r#"
        CREATE TABLE `a` (`id` INT PRIMARY KEY);
        CREATE TABLE `b` (`id` INT PRIMARY KEY);
        CREATE TABLE `c` (`id` INT PRIMARY KEY);
        INSERT INTO `a` VALUES (1), (2), (3);
        INSERT INTO `b` VALUES (1), (2);
        INSERT INTO `c` VALUES (1);
        INSERT INTO `nonexistent` VALUES (1);
    "#;

    let summary = validate_sql(sql, true);
    assert_eq!(summary.summary.tables_scanned, 3);
    
    let missing_issues: Vec<_> = summary.issues.iter().filter(|i| i.code == "DDL_MISSING_TABLE").collect();
    assert_eq!(missing_issues.len(), 1);
}

#[test]
fn test_validate_has_errors() {
    let sql = r#"
        INSERT INTO `missing` VALUES (1);
    "#;

    let summary = validate_sql(sql, false);
    assert!(summary.has_errors());
    assert!(!summary.has_warnings());
}

#[test]
fn test_validate_has_warnings() {
    let sql = r#"
        CREATE TABLE `users` (`id` INT PRIMARY KEY);
        INSERT INTO `users` VALUES (1), (2), (3), (4), (5);
    "#;

    let file = create_temp_sql(sql);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::MySql),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 3,
        fk_checks_enabled: true,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    assert!(summary.has_warnings());
}

// =============================================================================
// Tests with test_data_gen fixtures
// =============================================================================

#[test]
fn test_validate_generated_mysql_dump() {
    let dump = generate_mysql_dump(42, Scale::Small);
    let summary = validate_file(dump.path(), SqlDialect::MySql, true);
    
    // Generated data should be valid (no errors)
    assert_eq!(summary.summary.errors, 0, "Generated MySQL dump should have no errors");
    assert!(summary.summary.tables_scanned > 0, "Should have scanned tables");
    assert!(summary.summary.statements_scanned > 0, "Should have scanned statements");
}

#[test]
fn test_validate_generated_postgres_dump() {
    let dump = generate_postgres_dump_file(42, Scale::Small);
    let summary = validate_file(dump.path(), SqlDialect::Postgres, false);
    
    // PostgreSQL dumps should parse without errors (FK checks skipped)
    assert_eq!(summary.summary.errors, 0, "Generated PostgreSQL dump should have no errors");
    assert!(summary.summary.tables_scanned > 0, "Should have scanned tables");
}

#[test]
fn test_validate_generated_sqlite_dump() {
    let dump = generate_sqlite_dump_file(42, Scale::Small);
    let summary = validate_file(dump.path(), SqlDialect::Sqlite, false);
    
    // SQLite dumps should parse without errors
    assert_eq!(summary.summary.errors, 0, "Generated SQLite dump should have no errors");
    assert!(summary.summary.tables_scanned > 0, "Should have scanned tables");
}

#[test]
fn test_validate_generated_with_fk_checks() {
    let dump = generate_mysql_dump(123, Scale::Small);
    let summary = validate_file(dump.path(), SqlDialect::MySql, true);
    
    // Generated data has FK-consistent data, so no FK violations
    let fk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "FK_MISSING_PARENT")
        .collect();
    assert!(fk_issues.is_empty(), "Generated data should have no FK violations");
}

#[test]
fn test_validate_generated_multiple_seeds() {
    // Validate with different seeds to ensure robustness
    for seed in [1, 42, 100, 999] {
        let dump = generate_mysql_dump(seed, Scale::Small);
        let summary = validate_file(dump.path(), SqlDialect::MySql, false);
        assert_eq!(
            summary.summary.errors, 0,
            "Seed {} should produce valid dump",
            seed
        );
    }
}

// =============================================================================
// Split → Merge → Validate Roundtrip Tests
// =============================================================================

#[test]
fn test_validate_split_merge_roundtrip_mysql() {
    let dump = generate_mysql_dump(42, Scale::Small);
    let split_dir = TempDir::new().unwrap();
    let merged_file = NamedTempFile::new().unwrap();
    
    // Split
    let splitter = Splitter::new(dump.path().to_path_buf(), split_dir.path().to_path_buf())
        .with_dialect(SqlDialect::MySql);
    let split_stats = splitter.split().unwrap();
    assert!(split_stats.tables_found > 0, "Should have split tables");
    
    // Merge
    let merger = Merger::new(split_dir.path().to_path_buf(), Some(merged_file.path().to_path_buf()))
        .with_dialect(SqlDialect::MySql)
        .with_header(false);
    let merge_stats = merger.merge().unwrap();
    assert_eq!(
        split_stats.tables_found,
        merge_stats.tables_merged,
        "All split tables should be merged"
    );
    
    // Validate merged output
    let summary = validate_file(merged_file.path(), SqlDialect::MySql, false);
    assert_eq!(
        summary.summary.errors, 0,
        "Merged output should have no errors"
    );
    assert_eq!(
        summary.summary.tables_scanned,
        split_stats.tables_found,
        "Should validate same number of tables"
    );
}

#[test]
fn test_validate_split_merge_roundtrip_postgres() {
    let dump = generate_postgres_dump_file(42, Scale::Small);
    let split_dir = TempDir::new().unwrap();
    let merged_file = NamedTempFile::new().unwrap();
    
    // Split
    let splitter = Splitter::new(dump.path().to_path_buf(), split_dir.path().to_path_buf())
        .with_dialect(SqlDialect::Postgres);
    let split_stats = splitter.split().unwrap();
    assert!(split_stats.tables_found > 0, "Should have split tables");
    
    // Merge
    let merger = Merger::new(split_dir.path().to_path_buf(), Some(merged_file.path().to_path_buf()))
        .with_dialect(SqlDialect::Postgres)
        .with_header(false);
    let merge_stats = merger.merge().unwrap();
    assert_eq!(
        split_stats.tables_found,
        merge_stats.tables_merged,
        "All split tables should be merged"
    );
    
    // Validate merged output (no FK checks for Postgres)
    let summary = validate_file(merged_file.path(), SqlDialect::Postgres, false);
    assert_eq!(
        summary.summary.errors, 0,
        "Merged PostgreSQL output should have no errors"
    );
}

#[test]
fn test_validate_split_merge_roundtrip_sqlite() {
    let dump = generate_sqlite_dump_file(42, Scale::Small);
    let split_dir = TempDir::new().unwrap();
    let merged_file = NamedTempFile::new().unwrap();
    
    // Split
    let splitter = Splitter::new(dump.path().to_path_buf(), split_dir.path().to_path_buf())
        .with_dialect(SqlDialect::Sqlite);
    let split_stats = splitter.split().unwrap();
    assert!(split_stats.tables_found > 0, "Should have split tables");
    
    // Merge
    let merger = Merger::new(split_dir.path().to_path_buf(), Some(merged_file.path().to_path_buf()))
        .with_dialect(SqlDialect::Sqlite)
        .with_header(false);
    let merge_stats = merger.merge().unwrap();
    assert_eq!(
        split_stats.tables_found,
        merge_stats.tables_merged,
        "All split tables should be merged"
    );
    
    // Validate merged output
    let summary = validate_file(merged_file.path(), SqlDialect::Sqlite, false);
    assert_eq!(
        summary.summary.errors, 0,
        "Merged SQLite output should have no errors"
    );
}

// =============================================================================
// Edge Case Tests
// =============================================================================

#[test]
fn test_validate_empty_file() {
    let summary = validate_sql("", false);
    assert_eq!(summary.summary.errors, 0);
    assert_eq!(summary.summary.tables_scanned, 0);
    assert_eq!(summary.summary.statements_scanned, 0);
}

#[test]
fn test_validate_comments_only() {
    let sql = r#"
        -- This is a comment
        /* Another comment */
        # MySQL comment
    "#;
    let summary = validate_sql(sql, false);
    assert_eq!(summary.summary.errors, 0);
}

#[test]
fn test_validate_schema_only() {
    let sql = r#"
        CREATE TABLE `users` (`id` INT PRIMARY KEY, `name` VARCHAR(255));
        CREATE TABLE `posts` (`id` INT PRIMARY KEY, `user_id` INT);
        CREATE INDEX `idx_user` ON `posts` (`user_id`);
    "#;
    let summary = validate_sql(sql, false);
    assert_eq!(summary.summary.errors, 0);
    assert_eq!(summary.summary.tables_scanned, 2);
}

#[test]
fn test_validate_multiple_fk_violations() {
    let sql = r#"
        CREATE TABLE `categories` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        CREATE TABLE `products` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255),
            `category_id` INT,
            CONSTRAINT `fk_cat` FOREIGN KEY (`category_id`) REFERENCES `categories` (`id`)
        );
        INSERT INTO `categories` VALUES (1, 'Electronics');
        INSERT INTO `products` VALUES (1, 'Phone', 1);
        INSERT INTO `products` VALUES (2, 'Laptop', 99);
        INSERT INTO `products` VALUES (3, 'Tablet', 100);
        INSERT INTO `products` VALUES (4, 'Watch', 101);
    "#;
    
    let summary = validate_sql(sql, true);
    
    // Should detect multiple FK violations (up to 5 reported per table)
    let fk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "FK_MISSING_PARENT")
        .collect();
    assert!(fk_issues.len() >= 1, "Should detect FK violations");
}

#[test]
fn test_validate_string_pk() {
    let sql = r#"
        CREATE TABLE `users` (
            `username` VARCHAR(50) PRIMARY KEY,
            `email` VARCHAR(255)
        );
        INSERT INTO `users` VALUES ('alice', 'alice@example.com');
        INSERT INTO `users` VALUES ('bob', 'bob@example.com');
        INSERT INTO `users` VALUES ('alice', 'alice2@example.com');
    "#;
    
    let summary = validate_sql(sql, true);
    
    let pk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "DUPLICATE_PK")
        .collect();
    assert_eq!(pk_issues.len(), 1, "Should detect string PK duplicate");
}

#[test]
fn test_validate_self_referential_fk() {
    let sql = r#"
        CREATE TABLE `employees` (
            `id` INT PRIMARY KEY,
            `name` VARCHAR(255),
            `manager_id` INT,
            CONSTRAINT `fk_manager` FOREIGN KEY (`manager_id`) REFERENCES `employees` (`id`)
        );
        INSERT INTO `employees` VALUES (1, 'CEO', NULL);
        INSERT INTO `employees` VALUES (2, 'Manager', 1);
        INSERT INTO `employees` VALUES (3, 'Employee', 2);
        INSERT INTO `employees` VALUES (4, 'Orphan', 999);
    "#;
    
    let summary = validate_sql(sql, true);
    
    // Should detect the orphan reference
    let fk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "FK_MISSING_PARENT")
        .collect();
    assert_eq!(fk_issues.len(), 1, "Should detect self-ref FK violation");
}

#[test]
fn test_validate_large_rows_warning() {
    // Create a table with many rows to trigger the max_rows warning
    let mut sql = String::from("CREATE TABLE `items` (`id` INT PRIMARY KEY);\n");
    for i in 1..=100 {
        sql.push_str(&format!("INSERT INTO `items` VALUES ({});\n", i));
    }
    
    let file = create_temp_sql(&sql);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::MySql),
        progress: false,
        strict: false,
        json: false,
        max_rows_per_table: 50, // Trigger warning
        fk_checks_enabled: true,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    let skip_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "PK_CHECK_SKIPPED")
        .collect();
    assert_eq!(skip_issues.len(), 1, "Should warn about skipping checks");
}

#[test]
fn test_validate_json_output_format() {
    let sql = r#"
        CREATE TABLE `test` (`id` INT PRIMARY KEY);
        INSERT INTO `test` VALUES (1);
    "#;
    
    let file = create_temp_sql(sql);
    let options = ValidateOptions {
        path: file.path().to_path_buf(),
        dialect: Some(SqlDialect::MySql),
        progress: false,
        strict: false,
        json: true, // JSON mode
        max_rows_per_table: 1_000_000,
        fk_checks_enabled: true,
    };
    let validator = Validator::new(options);
    let summary = validator.validate().unwrap();
    
    // Verify summary can be serialized to JSON
    let json = serde_json::to_string(&summary).unwrap();
    assert!(json.contains("\"dialect\""));
    assert!(json.contains("\"issues\""));
    assert!(json.contains("\"summary\""));
}

#[test]
fn test_validate_multi_row_insert() {
    let sql = r#"
        CREATE TABLE `users` (`id` INT PRIMARY KEY, `name` VARCHAR(255));
        INSERT INTO `users` VALUES (1, 'Alice'), (2, 'Bob'), (3, 'Charlie');
        INSERT INTO `users` VALUES (4, 'Dave'), (5, 'Eve');
    "#;
    
    let summary = validate_sql(sql, true);
    assert_eq!(summary.summary.errors, 0);
}

#[test]
fn test_validate_bigint_pk() {
    let sql = r#"
        CREATE TABLE `events` (
            `id` BIGINT PRIMARY KEY,
            `name` VARCHAR(255)
        );
        INSERT INTO `events` VALUES (9223372036854775807, 'Max BigInt');
        INSERT INTO `events` VALUES (1, 'First');
        INSERT INTO `events` VALUES (9223372036854775807, 'Duplicate');
    "#;
    
    let summary = validate_sql(sql, true);
    
    let pk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "DUPLICATE_PK")
        .collect();
    assert_eq!(pk_issues.len(), 1, "Should detect BIGINT PK duplicate");
}

#[test]
fn test_validate_composite_fk() {
    let sql = r#"
        CREATE TABLE `orders` (
            `tenant_id` INT,
            `order_id` INT,
            `name` VARCHAR(255),
            PRIMARY KEY (`tenant_id`, `order_id`)
        );
        CREATE TABLE `order_items` (
            `id` INT PRIMARY KEY,
            `tenant_id` INT,
            `order_id` INT,
            `product` VARCHAR(255),
            CONSTRAINT `fk_order` FOREIGN KEY (`tenant_id`, `order_id`) 
                REFERENCES `orders` (`tenant_id`, `order_id`)
        );
        INSERT INTO `orders` VALUES (1, 100, 'Order A'), (1, 101, 'Order B');
        INSERT INTO `order_items` VALUES (1, 1, 100, 'Widget');
        INSERT INTO `order_items` VALUES (2, 1, 999, 'Invalid');
    "#;
    
    let summary = validate_sql(sql, true);
    
    let fk_issues: Vec<_> = summary.issues.iter()
        .filter(|i| i.code == "FK_MISSING_PARENT")
        .collect();
    assert_eq!(fk_issues.len(), 1, "Should detect composite FK violation");
}