sqc 0.4.13

Software Code Quality - CERT C compliance checker
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83

//! WIN01-C: Do not forcibly terminate execution of threads
//!
//! TerminateThread() forcibly kills a thread without cleanup - unsafe.
//! Use cooperative signaling instead.
//!
//! ## Examples:
//!
//! **Non-compliant:**
//! ```c
//! TerminateThread(hThread, 0xFF);  // VIOLATION: forced termination
//! ```
//!
//! **Compliant:**
//! ```c
//! InterlockedExchange(&ShouldThreadExit, 1);  // Signal thread to exit
//! ```

use super::super::{CertRule, RuleViolation};
use crate::manifest::{RuleCategory, Severity};
use crate::utility::cert_c::ast_utils::get_node_text;
use tree_sitter::Node;

pub struct Win01C;

impl CertRule for Win01C {
    fn rule_id(&self) -> &'static str {
        "WIN01-C"
    }

    fn description(&self) -> &'static str {
        "Do not forcibly terminate execution of threads"
    }

    fn severity(&self) -> Severity {
        Severity::High
    }

    fn category(&self) -> RuleCategory {
        RuleCategory::Rule
    }

    fn cert_id(&self) -> &'static str {
        "WIN01-C"
    }

    fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
        let mut violations = Vec::new();
        self.check_node(node, source, &mut violations);
        violations
    }
}

impl Win01C {
    fn check_node(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
        if node.kind() == "call_expression" {
            if let Some(function) = node.child_by_field_name("function") {
                let func_name = get_node_text(&function, source);

                if func_name == "TerminateThread" {
                    violations.push(RuleViolation {
                        rule_id: self.rule_id().to_string(),
                        severity: Severity::High,
                        message: "TerminateThread() called - forcibly terminates thread without cleanup".to_string(),
                        file_path: String::new(),
                        line: node.start_position().row + 1,
                        column: node.start_position().column + 1,
                        suggestion: Some(
                            "Use cooperative signaling (e.g., InterlockedExchange) to request thread exit instead of forcing termination".to_string()
                        ),
                        ..Default::default()
                    });
                }
            }
        }

        // Recurse
        for i in 0..node.child_count() {
            if let Some(child) = node.child(i) {
                self.check_node(&child, source, violations);
            }
        }
    }
}