sqc 0.4.13

Software Code Quality - CERT C compliance checker
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108

//! POS04-C: Avoid using PTHREAD_MUTEX_NORMAL type mutex locks
//!
//! This rule detects usage of PTHREAD_MUTEX_NORMAL or PTHREAD_MUTEX_DEFAULT
//! mutex types, which have undefined behavior in certain scenarios.
//!
//! VIOLATIONS:
//! - pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_NORMAL)
//! - pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_DEFAULT)
//!
//! COMPLIANT:
//! - pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ERRORCHECK)
//! - pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE)

use super::super::{CertRule, RuleViolation};
use crate::manifest::{RuleCategory, Severity};
use crate::utility::cert_c::ast_utils::get_node_text;
use tree_sitter::Node;

pub struct Pos04C;

// Unsafe mutex types that should be avoided
const UNSAFE_MUTEX_TYPES: &[&str] = &["PTHREAD_MUTEX_NORMAL", "PTHREAD_MUTEX_DEFAULT"];

impl CertRule for Pos04C {
    fn rule_id(&self) -> &'static str {
        "POS04-C"
    }

    fn description(&self) -> &'static str {
        "Avoid using PTHREAD_MUTEX_NORMAL type mutex locks"
    }

    fn severity(&self) -> Severity {
        Severity::Low
    }

    fn category(&self) -> RuleCategory {
        RuleCategory::Recommendation
    }

    fn cert_id(&self) -> &'static str {
        "POS04-C"
    }

    fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
        let mut violations = Vec::new();
        self.check_node(node, source, &mut violations);
        violations
    }
}

impl Pos04C {
    fn check_node(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
        // Look for pthread_mutexattr_settype calls
        if node.kind() == "call_expression" {
            self.check_mutex_settype(node, source, violations);
        }

        // Recurse
        for i in 0..node.child_count() {
            if let Some(child) = node.child(i) {
                self.check_node(&child, source, violations);
            }
        }
    }

    fn check_mutex_settype(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
        if let Some(func) = node.child_by_field_name("function") {
            let func_name = get_node_text(&func, source);
            if func_name == "pthread_mutexattr_settype" {
                // Get the second argument (mutex type)
                if let Some(args) = node.child_by_field_name("arguments") {
                    let mut arg_idx = 0;
                    for j in 0..args.child_count() {
                        if let Some(arg) = args.child(j) {
                            let arg_kind = arg.kind();
                            if arg_kind != "(" && arg_kind != ")" && arg_kind != "," {
                                arg_idx += 1;
                                if arg_idx == 2 {
                                    // This is the mutex type argument
                                    let type_text = get_node_text(&arg, source);
                                    if UNSAFE_MUTEX_TYPES.contains(&type_text) {
                                        let pos = node.start_position();
                                        violations.push(RuleViolation {
                                            rule_id: self.rule_id().to_string(),
                                            severity: Severity::Low,
                                            message: format!(
                                                "Use of {} mutex type has undefined behavior; use PTHREAD_MUTEX_ERRORCHECK or PTHREAD_MUTEX_RECURSIVE instead",
                                                type_text
                                            ),
                                            file_path: String::new(),
                                            line: pos.row + 1,
                                            column: pos.column + 1,
                                            suggestion: Some(
                                                "Replace with PTHREAD_MUTEX_ERRORCHECK or PTHREAD_MUTEX_RECURSIVE".to_string()
                                            ),
                                            ..Default::default()
                                        });
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}