sqc 0.4.13

Software Code Quality - CERT C compliance checker
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87

use crate::manifest::{RuleCategory, Severity};
use crate::prelude::RuleViolation;
use crate::rules::cert_c::CertRule;
use crate::utility::cert_c::ast_utils::get_node_text;
use tree_sitter::Node;

pub struct DCL21C;

impl CertRule for DCL21C {
    fn rule_id(&self) -> &'static str {
        "DCL21-C"
    }

    fn cert_id(&self) -> &'static str {
        "DCL21"
    }

    fn description(&self) -> &'static str {
        "Understand the storage of compound literals"
    }

    fn severity(&self) -> Severity {
        Severity::Low
    }

    fn category(&self) -> RuleCategory {
        RuleCategory::Rule
    }

    fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
        let mut violations = Vec::new();

        // Recursively check all nodes
        self.check_node(node, source, &mut violations);

        violations
    }
}

impl DCL21C {
    fn check_node(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
        // Look for & operator (pointer_expression with &)
        if node.kind() == "pointer_expression" {
            let text = get_node_text(node, source);
            if text.starts_with('&') {
                // Check if the operand is a cast or type initialization (compound literal pattern)
                let mut cursor = node.walk();
                for child in node.children(&mut cursor) {
                    if child.kind() == "cast_expression"
                        || child.kind() == "compound_literal_expression"
                    {
                        // Check if inside a loop
                        if self.is_inside_loop(node) {
                            let start = node.start_position();
                            violations.push(RuleViolation {
                                rule_id: self.rule_id().to_string(),
                                file_path: String::new(),
                                message: "Address of compound literal taken inside a loop. Compound literals have automatic storage duration that ends at the end of the enclosing block, potentially creating dangling pointers.".to_string(),
                                line: start.row + 1,
                                column: start.column + 1,
                                severity: self.severity(),
                                suggestion: Some("Avoid taking the address of compound literals. Use a regular variable or array instead.".to_string()),
                                requires_manual_review: Some(false),
                            });
                        }
                    }
                }
            }
        }

        // Recurse into children
        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            self.check_node(&child, source, violations);
        }
    }
    fn is_inside_loop(&self, node: &Node) -> bool {
        let mut current = node.parent();
        while let Some(parent) = current {
            match parent.kind() {
                "for_statement" | "while_statement" | "do_statement" => return true,
                _ => current = parent.parent(),
            }
        }
        false
    }
}