1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
//! MEM03-C: Clear sensitive information stored in reusable resources
//!
//! This rule detects free() or realloc() calls on memory that may contain
//! sensitive data without first clearing the memory with memset/memset_s.
//!
//! VIOLATIONS:
//! - free(ptr) without prior memset/memset_s/explicit_bzero to clear memory
//! - realloc(ptr, size) - old memory may not be cleared before being freed
//!
//! COMPLIANT:
//! - memset/memset_s/explicit_bzero called before free()
//! - Using calloc() for new allocations (initializes to zero)
use super::super::{CertRule, RuleViolation};
use crate::manifest::{RuleCategory, Severity};
use crate::utility::cert_c::ast_utils::get_node_text;
use std::collections::HashSet;
use tree_sitter::Node;
pub struct Mem03C;
const CLEAR_FUNCS: &[&str] = &[
"memset",
"memset_s",
"explicit_bzero",
"bzero",
"SecureZeroMemory",
];
impl CertRule for Mem03C {
fn rule_id(&self) -> &'static str {
"MEM03-C"
}
fn description(&self) -> &'static str {
"Clear sensitive information stored in reusable resources"
}
fn severity(&self) -> Severity {
Severity::Medium
}
fn category(&self) -> RuleCategory {
RuleCategory::Recommendation
}
fn cert_id(&self) -> &'static str {
"MEM03-C"
}
fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
let mut violations = Vec::new();
self.check_node(node, source, &mut violations);
violations
}
}
impl Mem03C {
fn check_node(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
// Check function definitions for free/realloc patterns
if node.kind() == "function_definition" {
self.check_function(node, source, violations);
}
// Recurse
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
self.check_node(&child, source, violations);
}
}
}
fn check_function(&self, node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
// Get compound statement (function body)
if let Some(body) = node.child_by_field_name("body") {
// Track which pointers have been cleared
let mut cleared_ptrs: HashSet<String> = HashSet::new();
self.analyze_block(&body, source, violations, &mut cleared_ptrs);
// CWE-226: check for sensitive data buffers not cleared before function exit
self.check_sensitive_data_cleanup(&body, source, violations);
}
}
fn analyze_block(
&self,
node: &Node,
source: &str,
violations: &mut Vec<RuleViolation>,
cleared_ptrs: &mut HashSet<String>,
) {
// Process statements in order
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
self.process_statement(&child, source, violations, cleared_ptrs);
}
}
}
fn process_statement(
&self,
node: &Node,
source: &str,
violations: &mut Vec<RuleViolation>,
cleared_ptrs: &mut HashSet<String>,
) {
let kind = node.kind();
// Check for memset/memset_s calls (clear operations)
if kind == "expression_statement" {
if let Some(ptr) = self.get_clear_call_ptr(node, source) {
cleared_ptrs.insert(ptr);
}
}
// Check for free() calls without prior clearing
if kind == "expression_statement" {
if let Some(ptr) = self.get_free_ptr(node, source) {
if !cleared_ptrs.contains(&ptr) {
let pos = node.start_position();
violations.push(RuleViolation {
rule_id: self.rule_id().to_string(),
severity: Severity::Medium,
message: format!(
"Pointer '{}' freed without clearing sensitive data first",
ptr
),
file_path: String::new(),
line: pos.row + 1,
column: pos.column + 1,
suggestion: Some(format!(
"Add 'memset({}, 0, size);' before free({}) to clear sensitive data",
ptr, ptr
)),
..Default::default()
});
}
}
}
// Check for realloc() calls (always a potential issue)
if kind == "expression_statement" || kind == "declaration" || kind == "init_declarator" {
if let Some(ptr) = self.get_realloc_ptr(node, source) {
if !cleared_ptrs.contains(&ptr) {
let pos = node.start_position();
violations.push(RuleViolation {
rule_id: self.rule_id().to_string(),
severity: Severity::Medium,
message: format!(
"realloc() on '{}' may leak sensitive data from old memory",
ptr
),
file_path: String::new(),
line: pos.row + 1,
column: pos.column + 1,
suggestion: Some(
"Consider allocating new memory, copying, clearing old, then freeing"
.to_string(),
),
..Default::default()
});
}
}
}
// Recurse into nested blocks
if kind == "compound_statement" {
self.analyze_block(node, source, violations, cleared_ptrs);
} else if kind == "if_statement" || kind == "while_statement" || kind == "for_statement" {
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
if child.kind() == "compound_statement" {
// Create a copy for nested scope
let mut nested_cleared = cleared_ptrs.clone();
self.analyze_block(&child, source, violations, &mut nested_cleared);
}
}
}
}
}
fn get_clear_call_ptr(&self, node: &Node, source: &str) -> Option<String> {
// Look for memset/memset_s/explicit_bzero calls
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
if child.kind() == "call_expression" {
if let Some(func) = child.child_by_field_name("function") {
let func_name = get_node_text(&func, source);
if CLEAR_FUNCS.contains(&func_name) {
// Get the first argument (pointer being cleared)
if let Some(args) = child.child_by_field_name("arguments") {
for j in 0..args.child_count() {
if let Some(arg) = args.child(j) {
let arg_kind = arg.kind();
if arg_kind != "(" && arg_kind != ")" && arg_kind != "," {
// Extract the base pointer from the argument
return Some(self.extract_base_ptr(&arg, source));
}
}
}
}
}
}
}
}
}
None
}
fn extract_base_ptr(&self, node: &Node, source: &str) -> String {
// Handle cast_expression like (volatile char *)ptr
if node.kind() == "cast_expression" {
// Find the value being cast (typically the last child that's not type_descriptor)
for i in (0..node.child_count()).rev() {
if let Some(child) = node.child(i) {
let kind = child.kind();
if kind != "type_descriptor" && kind != "(" && kind != ")" {
return self.extract_base_ptr(&child, source);
}
}
}
}
// Base case: identifier or other expression
get_node_text(node, source).to_string()
}
fn get_free_ptr(&self, node: &Node, source: &str) -> Option<String> {
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
if child.kind() == "call_expression" {
if let Some(func) = child.child_by_field_name("function") {
let func_name = get_node_text(&func, source);
if func_name == "free" {
if let Some(args) = child.child_by_field_name("arguments") {
for j in 0..args.child_count() {
if let Some(arg) = args.child(j) {
if arg.kind() != "("
&& arg.kind() != ")"
&& arg.kind() != ","
{
return Some(get_node_text(&arg, source).to_string());
}
}
}
}
}
}
}
}
}
None
}
fn get_realloc_ptr(&self, node: &Node, source: &str) -> Option<String> {
// Find realloc call and return the pointer being reallocated
self.find_realloc_in_node(node, source)
}
fn find_realloc_in_node(&self, node: &Node, source: &str) -> Option<String> {
if node.kind() == "call_expression" {
if let Some(func) = node.child_by_field_name("function") {
let func_name = get_node_text(&func, source);
if func_name == "realloc" {
// Get first argument (pointer being reallocated)
if let Some(args) = node.child_by_field_name("arguments") {
for j in 0..args.child_count() {
if let Some(arg) = args.child(j) {
if arg.kind() != "(" && arg.kind() != ")" && arg.kind() != "," {
return Some(get_node_text(&arg, source).to_string());
}
}
}
}
}
}
}
// Recurse
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
if let Some(ptr) = self.find_realloc_in_node(&child, source) {
return Some(ptr);
}
}
}
None
}
// ── CWE-226: Sensitive data not cleared before release ──────────────────
const SENSITIVE_NAMES: &'static [&'static str] =
&["password", "passwd", "secret", "credential", "passphrase"];
/// Check if sensitive-named buffers are cleared before function exit
fn check_sensitive_data_cleanup(
&self,
body: &Node,
source: &str,
violations: &mut Vec<RuleViolation>,
) {
let mut sensitive_vars: Vec<(String, usize, usize)> = Vec::new();
let mut cleared_vars: HashSet<String> = HashSet::new();
self.scan_sensitive_vars_and_clears(body, source, &mut sensitive_vars, &mut cleared_vars);
for (var_name, line, col) in &sensitive_vars {
if !cleared_vars.contains(var_name) {
violations.push(RuleViolation {
rule_id: self.rule_id().to_string(),
severity: Severity::Medium,
message: format!(
"Sensitive buffer '{}' not cleared before function exit",
var_name
),
file_path: String::new(),
line: *line,
column: *col,
suggestion: Some(format!(
"Call SecureZeroMemory({0}, size) or memset({0}, 0, size) before the buffer goes out of scope",
var_name
)),
..Default::default()
});
}
}
}
fn scan_sensitive_vars_and_clears(
&self,
node: &Node,
source: &str,
sensitive_vars: &mut Vec<(String, usize, usize)>,
cleared_vars: &mut HashSet<String>,
) {
match node.kind() {
"declaration" => {
// Check for sensitive-named pointer/array declarations (buffers only)
let decl_text = get_node_text(node, source);
let decl_lower = decl_text.to_lowercase();
// Must be a buffer type (pointer or array), not a scalar like size_t
let is_buffer = decl_text.contains('*') || decl_text.contains('[');
if is_buffer {
for name in Self::SENSITIVE_NAMES {
if decl_lower.contains(name) {
if let Some(var_name) = self.extract_decl_var_name(node, source) {
let lower = var_name.to_lowercase();
if Self::SENSITIVE_NAMES.iter().any(|n| lower.contains(n)) {
sensitive_vars.push((
var_name,
node.start_position().row + 1,
node.start_position().column + 1,
));
}
}
break;
}
}
}
}
"call_expression" => {
// Check for clearing functions
if let Some(func) = node.child_by_field_name("function") {
let func_name = get_node_text(&func, source);
if CLEAR_FUNCS.contains(&func_name) {
if let Some(args) = node.child_by_field_name("arguments") {
for j in 0..args.child_count() {
if let Some(arg) = args.child(j) {
let kind = arg.kind();
if kind != "(" && kind != ")" && kind != "," {
let ptr = self.extract_base_ptr(&arg, source);
cleared_vars.insert(ptr);
break;
}
}
}
}
}
}
}
_ => {}
}
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
self.scan_sensitive_vars_and_clears(&child, source, sensitive_vars, cleared_vars);
}
}
}
fn extract_decl_var_name(&self, decl: &Node, source: &str) -> Option<String> {
for i in 0..decl.child_count() {
if let Some(child) = decl.child(i) {
match child.kind() {
"init_declarator" => {
if let Some(declarator) = child.child_by_field_name("declarator") {
return self.find_identifier_in(&declarator, source);
}
}
"pointer_declarator" | "array_declarator" | "identifier" => {
return self.find_identifier_in(&child, source);
}
_ => {}
}
}
}
None
}
fn find_identifier_in(&self, node: &Node, source: &str) -> Option<String> {
if node.kind() == "identifier" {
return Some(get_node_text(node, source).to_string());
}
for i in 0..node.child_count() {
if let Some(child) = node.child(i) {
if let Some(name) = self.find_identifier_in(&child, source) {
return Some(name);
}
}
}
None
}
}