sqc 0.4.13

Software Code Quality - CERT C compliance checker
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114

use super::super::{CertRule, RuleViolation};
use crate::manifest::{RuleCategory, Severity};
use crate::utility::cert_c::ast_utils::get_node_text;
use tree_sitter::Node;

pub struct Exp13C;

impl CertRule for Exp13C {
    fn rule_id(&self) -> &'static str {
        "EXP13-C"
    }

    fn description(&self) -> &'static str {
        "Treat relational and equality operators as if they were nonassociative"
    }

    fn severity(&self) -> Severity {
        Severity::Low
    }

    fn category(&self) -> RuleCategory {
        RuleCategory::Recommendation
    }

    fn cert_id(&self) -> &'static str {
        "EXP13-C"
    }

    fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
        let mut violations = Vec::new();

        // Check for binary expressions with relational or equality operators
        if node.kind() == "binary_expression" {
            if let Some(operator_node) = node.child_by_field_name("operator") {
                let operator = get_node_text(&operator_node, source);

                // Check if this is a relational or equality operator
                if is_relational_or_equality_operator(operator) {
                    // Check if either operand contains another relational/equality operator
                    // This would indicate chaining like a < b < c
                    if let Some(left) = node.child_by_field_name("left") {
                        if contains_relational_or_equality(&left, source) {
                            report_violation(node, source, &mut violations);
                        }
                    }
                    if let Some(right) = node.child_by_field_name("right") {
                        if contains_relational_or_equality(&right, source) {
                            report_violation(node, source, &mut violations);
                        }
                    }
                }
            }
        }

        // Recursively check child nodes
        for i in 0..node.child_count() {
            if let Some(child) = node.child(i) {
                violations.extend(self.check(&child, source));
            }
        }

        violations
    }
}

/// Check if an operator is a relational or equality operator
fn is_relational_or_equality_operator(op: &str) -> bool {
    matches!(op, "<" | ">" | "<=" | ">=" | "==" | "!=")
}

/// Check if a node or its children contain relational or equality operators
/// without parentheses (indicating direct chaining)
fn contains_relational_or_equality(node: &Node, source: &str) -> bool {
    match node.kind() {
        "binary_expression" => {
            // Check if this binary expression uses a relational/equality operator
            if let Some(operator_node) = node.child_by_field_name("operator") {
                let operator = get_node_text(&operator_node, source);
                // If this is a relational/equality operator, we found chaining
                is_relational_or_equality_operator(operator)
            } else {
                false
            }
        }
        "parenthesized_expression" => {
            // Parentheses break the chaining, so this is safe
            false
        }
        _ => false,
    }
}

/// Report a violation for chained relational/equality operators
fn report_violation(node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
    let start_point = node.start_position();
    let node_text = get_node_text(node, source);

    violations.push(RuleViolation {
        rule_id: "EXP13-C".to_string(),
        severity: Severity::Low,
        message: format!(
            "Chained relational or equality operators should use explicit logical operators: '{}'",
            node_text
        ),
        file_path: String::new(),
        line: start_point.row + 1,
        column: start_point.column + 1,
        suggestion: Some(
            "Use explicit logical operators (&&, ||) to clarify intent: e.g., (a < b) && (b < c)"
                .to_string(),
        ),
        ..Default::default()
    });
}