splice 2.6.4

Span-safe refactoring kernel for 7 languages with Magellan code graph integration
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
//! SHA-256 checksums for proof integrity validation.
//!
//! This module provides cryptographic checksums for refactoring proofs
//! to ensure audit trail integrity. Each proof includes checksums for:
//! - Before snapshot hash
//! - After snapshot hash
//! Overall proof hash (for tamper detection)

use crate::error::{Result, SpliceError};
use crate::proof::data_structures::{GraphSnapshot, ProofChecksums, RefactoringProof};
use sha2::{Digest, Sha256};
use std::path::Path;

/// Compute SHA-256 hash of a graph snapshot.
///
/// Serializes the snapshot to JSON and computes the SHA-256 hash
/// for integrity verification.
pub fn compute_snapshot_hash(snapshot: &GraphSnapshot) -> Result<String> {
    // Serialize snapshot to canonical JSON (sorted keys for consistency)
    let json = serde_json::to_string(snapshot)
        .map_err(|e| SpliceError::Other(format!("Failed to serialize snapshot: {}", e)))?;

    // Compute SHA-256 hash
    let mut hasher = Sha256::new();
    hasher.update(json.as_bytes());
    let hash = hasher.finalize();

    // Convert to hex string
    Ok(format!("{:x}", hash))
}

/// Compute checksums for a refactoring proof.
///
/// This function computes:
/// - SHA-256 hash of the before snapshot
/// - SHA-256 hash of the after snapshot
/// - SHA-256 hash of the combined proof (metadata + invariants)
///
/// The overall proof hash is computed from the metadata and invariants
/// only (not including the snapshots themselves, which have their own hashes).
pub fn compute_proof_checksums(proof: &RefactoringProof) -> Result<ProofChecksums> {
    // Compute before snapshot hash
    let before_hash = compute_snapshot_hash(&proof.before)?;

    // Compute after snapshot hash
    let after_hash = compute_snapshot_hash(&proof.after)?;

    // Compute proof hash from metadata + invariants (not snapshots)
    let proof_hash_input = format!(
        "{}:{}:{}",
        serde_json::to_string(&proof.metadata)
            .map_err(|e| SpliceError::Other(format!("Failed to serialize metadata: {}", e)))?,
        serde_json::to_string(&proof.invariants)
            .map_err(|e| SpliceError::Other(format!("Failed to serialize invariants: {}", e)))?,
        proof.before.timestamp // Include before timestamp for ordering
    );

    let mut hasher = Sha256::new();
    hasher.update(proof_hash_input.as_bytes());
    let proof_hash = format!("{:x}", hasher.finalize());

    Ok(ProofChecksums {
        before_hash,
        after_hash,
        proof_hash,
    })
}

/// Validate proof checksums.
///
/// Verifies that:
/// - The stored before hash matches the computed before hash
/// - The stored after hash matches the computed after hash
/// - The stored proof hash matches the computed proof hash
///
/// Returns Ok(true) if all checksums are valid, Ok(false) if checksums
/// are missing, and Err if any checksum is invalid.
pub fn validate_proof_checksums(proof: &RefactoringProof) -> Result<bool> {
    let checksums = match &proof.checksums {
        Some(c) => c,
        None => return Ok(false), // No checksums to validate
    };

    // Compute current checksums
    let current = compute_proof_checksums(proof)?;

    // Validate before hash
    if checksums.before_hash != current.before_hash {
        return Err(SpliceError::Other(format!(
            "Before snapshot hash mismatch: expected {}, got {}",
            checksums.before_hash, current.before_hash
        )));
    }

    // Validate after hash
    if checksums.after_hash != current.after_hash {
        return Err(SpliceError::Other(format!(
            "After snapshot hash mismatch: expected {}, got {}",
            checksums.after_hash, current.after_hash
        )));
    }

    // Validate proof hash
    if checksums.proof_hash != current.proof_hash {
        return Err(SpliceError::Other(format!(
            "Proof hash mismatch: expected {}, got {}",
            checksums.proof_hash, current.proof_hash
        )));
    }

    Ok(true)
}

/// Validate a proof file on disk.
///
/// Reads a proof JSON file, deserializes it, and validates its checksums.
///
/// # Arguments
/// * `proof_path` - Path to the proof JSON file
///
/// # Returns
/// * Ok(true) if checksums are valid
/// * Ok(false) if checksums are missing
/// * Err if proof is invalid or cannot be read
pub fn validate_proof_file(proof_path: &Path) -> Result<bool> {
    // Read proof file
    let json = std::fs::read_to_string(proof_path).map_err(|e| SpliceError::Io {
        path: proof_path.to_path_buf(),
        source: e,
    })?;

    // Deserialize proof
    let proof: RefactoringProof = serde_json::from_str(&json)
        .map_err(|e| SpliceError::Other(format!("Failed to deserialize proof: {}", e)))?;

    // Validate checksums
    validate_proof_checksums(&proof)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::proof::data_structures::{GraphStats, ProofMetadata};
    use std::collections::HashMap;
    use std::path::PathBuf;

    #[test]
    fn test_compute_snapshot_hash() {
        let snapshot = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let hash = compute_snapshot_hash(&snapshot).unwrap();
        assert_eq!(hash.len(), 64); // SHA-256 is 64 hex chars
        assert!(hash.chars().all(|c| c.is_ascii_hexdigit()));
    }

    #[test]
    fn test_snapshot_hash_consistency() {
        let snapshot = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let hash1 = compute_snapshot_hash(&snapshot).unwrap();
        let hash2 = compute_snapshot_hash(&snapshot).unwrap();

        // Same snapshot should produce same hash
        assert_eq!(hash1, hash2);
    }

    #[test]
    fn test_snapshot_hash_uniqueness() {
        let snapshot1 = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let snapshot2 = GraphSnapshot {
            timestamp: 1234567891, // Different timestamp
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let hash1 = compute_snapshot_hash(&snapshot1).unwrap();
        let hash2 = compute_snapshot_hash(&snapshot2).unwrap();

        // Different snapshots should produce different hashes
        assert_ne!(hash1, hash2);
    }

    #[test]
    fn test_compute_proof_checksums() {
        let metadata = ProofMetadata {
            operation: "test".to_string(),
            user: None,
            timestamp: 1234567890,
            git_commit: None,
            splice_version: "2.2.4".to_string(),
            database_path: PathBuf::from("/test/db"),
        };

        let before = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let after = GraphSnapshot {
            timestamp: 1234567891,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let proof = RefactoringProof {
            metadata,
            before,
            after,
            invariants: vec![],
            checksums: None,
        };

        let checksums = compute_proof_checksums(&proof).unwrap();

        // Verify all hashes are present and 64 chars (SHA-256 hex)
        assert_eq!(checksums.before_hash.len(), 64);
        assert_eq!(checksums.after_hash.len(), 64);
        assert_eq!(checksums.proof_hash.len(), 64);

        // Verify all hashes are hex
        assert!(checksums.before_hash.chars().all(|c| c.is_ascii_hexdigit()));
        assert!(checksums.after_hash.chars().all(|c| c.is_ascii_hexdigit()));
        assert!(checksums.proof_hash.chars().all(|c| c.is_ascii_hexdigit()));
    }

    #[test]
    fn test_validate_proof_checksums_missing() {
        let proof = RefactoringProof {
            metadata: ProofMetadata {
                operation: "test".to_string(),
                user: None,
                timestamp: 1234567890,
                git_commit: None,
                splice_version: "2.2.4".to_string(),
                database_path: PathBuf::from("/test/db"),
            },
            before: GraphSnapshot {
                timestamp: 1234567890,
                symbols: HashMap::new(),
                edges: HashMap::new(),
                entry_points: vec![],
                stats: GraphStats {
                    total_symbols: 0,
                    total_edges: 0,
                    entry_point_count: 0,
                    max_complexity: None,
                },
            },
            after: GraphSnapshot {
                timestamp: 1234567891,
                symbols: HashMap::new(),
                edges: HashMap::new(),
                entry_points: vec![],
                stats: GraphStats {
                    total_symbols: 0,
                    total_edges: 0,
                    entry_point_count: 0,
                    max_complexity: None,
                },
            },
            invariants: vec![],
            checksums: None,
        };

        let result = validate_proof_checksums(&proof).unwrap();
        assert!(!result); // No checksums to validate
    }

    #[test]
    fn test_validate_proof_checksums_valid() {
        let metadata = ProofMetadata {
            operation: "test".to_string(),
            user: None,
            timestamp: 1234567890,
            git_commit: None,
            splice_version: "2.2.4".to_string(),
            database_path: PathBuf::from("/test/db"),
        };

        let before = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let after = GraphSnapshot {
            timestamp: 1234567891,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let mut proof = RefactoringProof {
            metadata,
            before,
            after,
            invariants: vec![],
            checksums: None,
        };

        // Compute and set checksums
        proof.checksums = Some(compute_proof_checksums(&proof).unwrap());

        // Validate - should pass
        let result = validate_proof_checksums(&proof).unwrap();
        assert!(result);
    }

    #[test]
    fn test_validate_proof_checksums_invalid() {
        let metadata = ProofMetadata {
            operation: "test".to_string(),
            user: None,
            timestamp: 1234567890,
            git_commit: None,
            splice_version: "2.2.4".to_string(),
            database_path: PathBuf::from("/test/db"),
        };

        let before = GraphSnapshot {
            timestamp: 1234567890,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let after = GraphSnapshot {
            timestamp: 1234567891,
            symbols: HashMap::new(),
            edges: HashMap::new(),
            entry_points: vec![],
            stats: GraphStats {
                total_symbols: 0,
                total_edges: 0,
                entry_point_count: 0,
                max_complexity: None,
            },
        };

        let mut proof = RefactoringProof {
            metadata,
            before,
            after,
            invariants: vec![],
            checksums: None,
        };

        // Compute checksums
        let checksums = compute_proof_checksums(&proof).unwrap();

        // Tamper with before hash
        let tampered_checksums = ProofChecksums {
            before_hash: "0".repeat(64), // Invalid hash
            after_hash: checksums.after_hash,
            proof_hash: checksums.proof_hash,
        };

        proof.checksums = Some(tampered_checksums);

        // Validate - should fail
        let result = validate_proof_checksums(&proof);
        assert!(result.is_err());
    }
}