splice 2.6.2

//! Deterministic symbol resolution with ambiguity detection.
//!
//! This module provides file-aware, deterministic symbol resolution.
//! Name-only resolution is forbidden unless uniquely provable.
//! Supports multi-language code analysis.
//! Provides enhanced symbol lookup with "did you mean" functionality.
//!
//! # Symbol Resolution API
//!
//! This module provides file-aware, deterministic symbol resolution with
//! ambiguity detection and fuzzy matching suggestions.
//!
//! ## Which function should I use?
//!
//! | Function | Use Case | Returns | Suggestions |
//! |----------|----------|---------|-------------|
//! | [`resolve_symbol`] | **Primary API** - Programmatic resolution | `ResolvedSpan` | No |
//! | [`find_symbol_or_suggest`] | User-facing commands | `NodeId` | Yes |
//! | [`resolve_symbol_with_rust_kind`] | **Deprecated** - Use resolve_symbol | `ResolvedSpan` | No |
//!
//! ## Quick Examples
//!
//! ### Basic resolution (with file context)
//! ```no_run
//! use splice::resolve::resolve_symbol;
//! use splice::graph::CodeGraph;
//!
//! let graph = CodeGraph::open(std::path::Path::new("splice.db"))?;
//! let symbol = resolve_symbol(
//!     &graph,
//!     Some(std::path::Path::new("src/main.rs")),  // file context
//!     Some("function"),                            // kind filter
//!     "main"                                       // symbol name
//! )?;
//! # Ok::<(), splice::SpliceError>(())
//! ```
//!
//! ### User-friendly lookup with suggestions
//! ```ignore
//! use splice::resolve::find_symbol_or_suggest;
//! use splice::graph::CodeGraph;
//!
//! // Returns helpful suggestions if symbol name is misspelled
//! let graph = CodeGraph::open(".magellan/splice.db").unwrap();
//! match find_symbol_or_suggest(&graph, "my_functoin", None) {
//!     Ok(id) => println!("Found: {:?}", id),
//!     Err(e) => eprintln!("{}", e), // "Did you mean: my_function?"
//! }
//! ```

pub mod cross_file;
pub mod module_resolver;
pub mod references;

use crate::error::{Result, SpliceError};
use crate::graph::CodeGraph;
use serde::Serialize;
use sqlitegraph::{NodeId, SnapshotId};
use std::path::{Path, PathBuf};

/// Normalize a user-provided path for database lookup.
///
/// Magellan stores canonical absolute paths for existing files.
/// This helper converts relative paths to absolute so lookups succeed.
/// Normalize a path for consistent graph database lookups.
///
/// Tries `std::fs::canonicalize` first (for existing files), then falls back to
/// making the path absolute relative to the current directory. This ensures
/// that symbols stored and looked up in the graph use the same path format.
pub fn normalize_lookup_path(path: &Path) -> PathBuf {
    // Try canonicalize first (works for existing files, resolves symlinks)
    if let Ok(canonical) = std::fs::canonicalize(path) {
        canonical
    } else {
        // Fallback for non-existent paths: make absolute relative to current dir
        std::env::current_dir()
            .unwrap_or_else(|_| PathBuf::from("."))
            .join(path)
    }
}

/// A resolved symbol with complete location information.
#[derive(Debug, Clone, PartialEq, Serialize)]
pub struct ResolvedSpan {
    /// Graph node ID for this symbol.
    #[serde(skip_serializing)]
    pub node_id: NodeId,

    /// Unique ID for this resolution attempt (generated once per resolve call).
    pub match_id: String,

    /// Symbol name.
    pub name: String,

    /// Symbol kind (function, struct, etc.) as language-agnostic string.
    pub kind: String,

    /// Programming language (rust, python, etc.).
    pub language: Option<String>,

    /// File containing this symbol.
    pub file_path: String,

    /// Start byte offset.
    pub byte_start: usize,

    /// End byte offset.
    pub byte_end: usize,

    /// Start line (1-based).
    pub line_start: usize,

    /// End line (1-based).
    pub line_end: usize,

    /// Start column (0-based, in bytes).
    pub col_start: usize,

    /// End column (0-based, in bytes).
    pub col_end: usize,
}

/// Resolve a symbol to its span with file-aware disambiguation.
///
/// This is the PRIMARY symbol resolution API. Use this for:
/// - Programmatic symbol lookup
/// - Resolving symbols with file context
/// - Resolving symbols with kind filtering
///
/// For user-facing commands where you want "did you mean" suggestions,
/// consider `find_symbol_or_suggest` instead.
///
/// # Arguments
/// * `graph` - The code graph database
/// * `file` - Optional file path to disambiguate symbols with same name
/// * `kind` - Optional symbol kind filter (function, struct, class, etc.)
/// * `name` - Symbol name to resolve
///
/// # Resolution Rules
/// 1. If `file` is Some, resolves the symbol within that specific file
/// 2. If `file` is None AND multiple matches exist across files → returns AmbiguousSymbol error
/// 3. If `file` is None AND exactly one match exists globally → returns that symbol
///
/// # Examples
///
/// ```no_run
/// use splice::resolve::resolve_symbol;
/// use splice::graph::CodeGraph;
/// use std::path::Path;
///
/// let graph = CodeGraph::open(Path::new("splice.db"))?;
///
/// // Resolve with file context
/// let symbol = resolve_symbol(&graph, Some(Path::new("src/main.rs")), None, "main")?;
///
/// // Resolve globally (requires unique symbol name)
/// let symbol = resolve_symbol(&graph, None, Some("function"), "my_function")?;
/// # Ok::<(), splice::SpliceError>(())
/// ```
///
/// # Errors
/// - `AmbiguousSymbol` - When name-only resolution finds multiple matches across files
/// - `SymbolNotFound` - When no symbol matches the query
pub fn resolve_symbol(
    graph: &CodeGraph,
    file: Option<&Path>,
    kind: Option<&str>,
    name: &str,
) -> Result<ResolvedSpan> {
    use uuid::Uuid;

    // Generate match_id for this resolution attempt
    let match_id = Uuid::new_v4().to_string();

    // Build cache key for lookup
    let _cache_key = if let Some(file_path) = file {
        let file_str = file_path
            .to_str()
            .ok_or_else(|| SpliceError::Other(format!("Invalid UTF-8 in path: {:?}", file_path)))?;
        format!("{}::{}", file_str, name)
    } else {
        name.to_string()
    };

    // For file-specific resolution, normalize path then use cache directly
    if let Some(file_path) = file {
        let normalized = normalize_lookup_path(file_path);
        return resolve_symbol_in_file(graph, &normalized, kind, name, &match_id);
    }

    // Name-only resolution: check for ambiguity
    let all_matches = graph.find_symbols_by_name(name);

    if all_matches.is_empty() {
        // Symbol not found - try to provide suggestions
        let all_symbols = graph.all_symbol_names();
        let suggestions = crate::suggestions::suggest_similar_symbols(name, &all_symbols, 3);

        let hint = if suggestions.is_empty() {
            format!(
                "Symbol '{}' not found. Run `splice ingest` to index the codebase.",
                name
            )
        } else {
            format!("Did you mean: {}?", suggestions.join(", "))
        };

        return Err(SpliceError::SymbolNotFound {
            message: format!("Symbol '{}' not found", name),
            symbol: name.to_string(),
            file: None,
            hint,
        });
    }

    if all_matches.len() > 1 {
        // Multiple matches → ambiguous
        let files: Vec<String> = all_matches
            .into_iter()
            .filter_map(|(_id, path)| path)
            .collect();

        return Err(SpliceError::AmbiguousSymbol {
            name: name.to_string(),
            files,
        });
    }

    // Exactly one match → safe to return
    let (node_id, file_path) = all_matches.into_iter().next().unwrap();
    let file_path_str =
        file_path.ok_or_else(|| SpliceError::Other("Symbol node missing file_path".to_string()))?;

    // Get node data from graph - use SnapshotId(0) for latest state (sqlitegraph v1.2.7+ API)
    let backend = graph.inner()?;
    let node = backend.get_node(SnapshotId(0), node_id.as_i64())?;

    // Extract span data
    let byte_start = node
        .data
        .get("byte_start")
        .and_then(|v| v.as_u64())
        .ok_or_else(|| SpliceError::Other("Missing byte_start property".to_string()))?
        as usize;

    let byte_end = node
        .data
        .get("byte_end")
        .and_then(|v| v.as_u64())
        .ok_or_else(|| SpliceError::Other("Missing byte_end property".to_string()))?
        as usize;

    // Extract kind (language-agnostic string)
    let kind_str = node
        .data
        .get("kind")
        .and_then(|v| v.as_str())
        .ok_or_else(|| SpliceError::Other("Missing kind property".to_string()))?
        .to_string();

    // Extract language (optional)
    let language = node
        .data
        .get("language")
        .and_then(|v| v.as_str())
        .map(|s| s.to_string());

    // Retrieve line/col from graph (Magellan uses start_line/end_line, not line_start/line_end)
    let line_start = node
        .data
        .get("start_line")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let line_end = node
        .data
        .get("end_line")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let col_start = node
        .data
        .get("start_col")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let col_end = node
        .data
        .get("end_col")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;

    Ok(ResolvedSpan {
        node_id,
        match_id,
        name: name.to_string(),
        kind: kind_str,
        language,
        file_path: file_path_str,
        byte_start,
        byte_end,
        line_start,
        line_end,
        col_start,
        col_end,
    })
}

/// Resolve a symbol within a specific file.
fn resolve_symbol_in_file(
    graph: &CodeGraph,
    file_path: &Path,
    kind: Option<&str>,
    name: &str,
    match_id: &str,
) -> Result<ResolvedSpan> {
    let file_str = file_path
        .to_str()
        .ok_or_else(|| SpliceError::Other(format!("Invalid UTF-8 in path: {:?}", file_path)))?;

    // Use the cache-based lookup from CodeGraph
    let node_id = match graph.find_symbol_in_file(file_str, name) {
        Some(id) => id,
        None => {
            // Symbol not found - try to provide suggestions
            let all_symbols = graph.all_symbol_names();
            let suggestions = crate::suggestions::suggest_similar_symbols(name, &all_symbols, 3);

            let hint = if suggestions.is_empty() {
                format!(
                    "Symbol '{}' not found in {}. Run `splice ingest` to index the codebase.",
                    name, file_str
                )
            } else {
                format!("Did you mean: {}?", suggestions.join(", "))
            };

            return Err(SpliceError::SymbolNotFound {
                message: format!("Symbol '{}' not found in {}", name, file_str),
                symbol: name.to_string(),
                file: Some(file_path.to_path_buf()),
                hint,
            });
        }
    };

    // Get node data from graph - use SnapshotId(0) for latest state (sqlitegraph v1.2.7+ API)
    let backend = graph.inner()?;
    let node = backend.get_node(SnapshotId(0), node_id.as_i64())?;

    // Extract span data
    let byte_start = node
        .data
        .get("byte_start")
        .and_then(|v| v.as_u64())
        .ok_or_else(|| SpliceError::Other("Missing byte_start property".to_string()))?
        as usize;

    let byte_end = node
        .data
        .get("byte_end")
        .and_then(|v| v.as_u64())
        .ok_or_else(|| SpliceError::Other("Missing byte_end property".to_string()))?
        as usize;

    // Extract kind (language-agnostic string)
    let kind_str = node
        .data
        .get("kind")
        .and_then(|v| v.as_str())
        .ok_or_else(|| SpliceError::Other("Missing kind property".to_string()))?
        .to_string();

    // Extract language (optional)
    let language = node
        .data
        .get("language")
        .and_then(|v| v.as_str())
        .map(|s| s.to_string());

    // Filter by kind if specified
    if let Some(k) = kind {
        if kind_str != k {
            return Err(SpliceError::SymbolNotFound {
                message: format!(
                    "Symbol '{}' of kind '{}' not found in {}",
                    name, k, file_str
                ),
                symbol: name.to_string(),
                file: Some(file_path.to_path_buf()),
                hint: format!(
                    "Symbol '{}' exists but is a '{}', not '{}'. Try adjusting the --kind flag.",
                    name, kind_str, k
                ),
            });
        }
    }

    // Get file path from node (in Magellan, file_path is in node.file_path, not node.data)
    let node_file_path = node
        .file_path
        .as_deref()
        .ok_or_else(|| SpliceError::Other("Missing file_path in node".to_string()))?
        .to_string();

    // Retrieve line/col from graph (stored by ingest modules)
    let line_start = node
        .data
        .get("line_start")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let line_end = node
        .data
        .get("line_end")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let col_start = node
        .data
        .get("col_start")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;
    let col_end = node
        .data
        .get("col_end")
        .and_then(|v| v.as_u64())
        .unwrap_or(0) as usize;

    Ok(ResolvedSpan {
        node_id,
        match_id: match_id.to_string(),
        name: name.to_string(),
        kind: kind_str,
        language,
        file_path: node_file_path,
        byte_start,
        byte_end,
        line_start,
        line_end,
        col_start,
        col_end,
    })
}

/// Backward compatibility: Resolve with Rust-specific symbol kind.
///
/// # Deprecated
///
/// **This function is DEPRECATED and will be removed in a future version.**
///
/// Use `resolve_symbol` with `Option<&str>` for the kind parameter instead:
///
/// ```ignore
/// // Old (deprecated):
/// // resolve_symbol_with_rust_kind(graph, file, Some(RustSymbolKind::Function), "foo")?
///
/// // New (preferred):
/// resolve_symbol(graph, file, Some("function"), "foo")?
/// ```
///
/// The string-based kind in `resolve_symbol` is:
/// - More flexible (works with all languages, not just Rust)
/// - Simpler (no enum conversion needed)
/// - The future direction of the API
///
/// # Migration Guide
///
/// Replace `RustSymbolKind` values with their string equivalents:
/// - `RustSymbolKind::Function` -> `"function"`
/// - `RustSymbolKind::Struct` -> `"struct"`
/// - `RustSymbolKind::Enum` -> `"enum"`
/// - `RustSymbolKind::Trait` -> `"trait"`
/// - etc.
#[deprecated(
    since = "2.2.0",
    note = "Use resolve_symbol with Option<&str> kind instead. This function will be removed in v3.0."
)]
pub fn resolve_symbol_with_rust_kind(
    graph: &CodeGraph,
    file: Option<&Path>,
    kind: Option<crate::ingest::rust::RustSymbolKind>,
    name: &str,
) -> Result<ResolvedSpan> {
    let kind_str = kind.map(|k| k.as_str().to_string());
    resolve_symbol(graph, file, kind_str.as_deref(), name)
}

/// Find a symbol, providing suggestions if not found.
///
/// This is the preferred method for **user-facing commands** (CLI, API endpoints)
/// because it provides helpful "did you mean" suggestions when a symbol
/// name is misspelled or doesn't exist.
///
/// # When to use this vs resolve_symbol
///
/// Use `find_symbol_or_suggest` when:
/// - Building user-facing features (CLI, web UI, API)
/// - You want fuzzy matching and suggestions for typos
/// - You only need the NodeId, not full span information
///
/// Use `resolve_symbol` when:
/// - Building internal programmatic features
/// - You need full span information (ResolvingSpan)
/// - You need kind filtering or file-scoped resolution
///
/// # Arguments
/// * `graph` - The code graph to search
/// * `name` - The symbol name to find
/// * `file` - Optional file path to scope the search
///
/// # Returns
/// * `Ok(NodeId)` if symbol is found
/// * `Err(SpliceError::SymbolNotFound)` with suggestions if not found
///
/// # Examples
///
/// ```no_run
/// use splice::resolve::find_symbol_or_suggest;
/// use splice::graph::CodeGraph;
///
/// let graph = CodeGraph::open(std::path::Path::new("splice.db"))?;
///
/// // Will suggest "my_function" if "my_functoin" is not found
/// match find_symbol_or_suggest(&graph, "my_functoin", None) {
///     Ok(id) => println!("Found: {:?}", id),
///     Err(e) => println!("{}", e), // "Did you mean: my_function?"
/// }
/// # Ok::<(), splice::SpliceError>(())
/// ```
pub fn find_symbol_or_suggest(
    graph: &CodeGraph,
    name: &str,
    file: Option<&Path>,
) -> Result<NodeId> {
    // Try to find the symbol in the specified file
    if let Some(file_path) = file {
        let normalized = normalize_lookup_path(file_path);
        if let Some(file_str) = normalized.to_str() {
            if let Some(node_id) = graph.find_symbol_in_file(file_str, name) {
                return Ok(node_id);
            }
        }
    }

    // Check if symbol exists in any file
    let all_matches = graph.find_symbols_by_name(name);
    if !all_matches.is_empty() {
        if let Some((node_id, _)) = all_matches.first() {
            return Ok(*node_id);
        }
    }

    // Symbol not found - get suggestions
    let all_symbols = graph.all_symbol_names();
    let suggestions = crate::suggestions::suggest_similar_symbols(name, &all_symbols, 3);

    let hint = if suggestions.is_empty() {
        format!(
            "Symbol '{}' not found. Run `splice ingest` to index the codebase.",
            name
        )
    } else {
        format!("Did you mean: {}?", suggestions.join(", "))
    };

    Err(SpliceError::SymbolNotFound {
        message: format!("Symbol '{}' not found", name),
        symbol: name.to_string(),
        file: file.map(|p| p.to_path_buf()),
        hint,
    })
}