spillover-bio 0.1.3

Genomics-focused disk-spilling sort pipeline for FASTQ/FASTA sequence records
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
//! Genomics-specific sort keys, sort orders, and the sorter builder.
//!
//! Sort keys extract the value to sort by from a [`SeqRecord`].
//! Sort orders bundle a sort key with a compatible dryice record
//! key and a merge strategy, preventing invalid combinations.
//!
//! The primary sort strategy for genomic data is sequence-first
//! with quality as the tiebreaker, expressed as a tuple key
//! `(&[u8], &[u8])` whose [`Ord`] implementation compares
//! sequence first, then quality lexicographically.
//!
//! The [`Builder`] is the main entry point for creating a sorter.

use dryice::{
    NameCodec, QualityCodec, RawAsciiCodec, RawNameCodec, RawQualityCodec, RecordKey, SequenceCodec,
};
use spillover::{
    chunk::{ChunkSorter, Sequential},
    compare::{Compare, Natural},
    dedup::{AdjacentDedup, Dedup, Identity},
    key::SortKey,
    merge::MergeConfig,
};

use crate::{
    codec::{DryIceCodec, KeyedDryIceCodec},
    key::PackedSequenceKey,
    radix::RadixThenRefine,
    record::SeqRecord,
};

/// Sort key that extracts sequence and quality as a tuple.
///
/// The tuple `(&[u8], &[u8])` implements [`Ord`] lexicographically,
/// so sequence is compared first and quality serves as the
/// tiebreaker — no custom comparator needed.
#[derive(Debug, Clone, Copy, Default)]
pub struct SequenceQualityKey;

impl SortKey<SeqRecord> for SequenceQualityKey {
    type Key<'a> = (&'a [u8], &'a [u8]);

    fn key<'a>(&self, item: &'a SeqRecord) -> (&'a [u8], &'a [u8]) {
        (item.sequence(), item.quality())
    }
}

/// Sort key that extracts the record name/identifier.
#[derive(Debug, Clone, Copy, Default)]
pub struct NameKey;

impl SortKey<SeqRecord> for NameKey {
    type Key<'a> = &'a [u8];

    fn key<'a>(&self, item: &'a SeqRecord) -> &'a [u8] {
        item.name()
    }
}

/// Sort key that extracts the sequence length as a `u64`.
#[derive(Debug, Clone, Copy, Default)]
pub struct LengthKey;

impl SortKey<SeqRecord> for LengthKey {
    type Key<'a> = u64;

    #[allow(clippy::cast_possible_truncation)]
    fn key(&self, item: &SeqRecord) -> u64 {
        item.sequence().len() as u64
    }
}

// ── Sort order traits (sealed) ────────────────────────────

mod sealed {
    pub trait Sealed {}

    /// Resolves codec type-state to a concrete [`crate::codec::DryIceCodec`].
    /// `NeedsCodec` yields the raw (no-encoding) default;
    /// `HasCodec` passes through the user's choice.
    pub trait ResolveCodec {
        type S: dryice::SequenceCodec + Copy + 'static;
        type Q: dryice::QualityCodec + Copy + 'static;
        type N: dryice::NameCodec + Copy + 'static;

        fn resolve(self) -> crate::codec::DryIceCodec<Self::S, Self::Q, Self::N>;
    }

    /// Resolves flush type-state to a concrete [`super::FlushConfig`].
    /// `NeedsFlush` yields a 1 GiB measured budget;
    /// `HasFlush` passes through the user's choice.
    pub trait ResolveFlush {
        fn resolve(self) -> super::FlushConfig;
    }
}

/// Defines a complete sort order: what to sort by, how to
/// compare, and what merge strategy to use. Sealed — only
/// spillover-bio's built-in orders implement this.
pub trait SortOrder: sealed::Sealed + Copy {
    /// The sort key for extracting the comparison value.
    type SortKey: SortKey<SeqRecord> + Copy + Send + Sync + 'static;

    /// The comparator for key comparison. Must implement
    /// `Compare<Key>` for whatever key type the `SortKey` produces.
    type Compare: Copy + Send + Sync + 'static;

    /// The merge strategy marker: [`Basic`] or [`Keyed`].
    type Strategy;

    /// The sort key extractor.
    fn sort_key(&self) -> Self::SortKey;

    /// The comparator.
    fn compare(&self) -> Self::Compare;
}

/// Extension for sort orders that use record keys for merge
/// acceleration. Only available when `Strategy = Keyed`.
pub trait KeyedSortOrder: SortOrder<Strategy = Keyed> {
    /// The dryice record key type.
    type RecordKey: dryice::RecordKey + Clone + Copy;

    /// Derive a record key from a record.
    fn record_key(&self, record: &SeqRecord) -> Self::RecordKey;

    /// A function pointer for key derivation, suitable for
    /// embedding in the codec.
    fn record_key_fn(&self) -> fn(&SeqRecord) -> Self::RecordKey;
}

/// Marker: base merge path (no record keys).
pub struct Basic;

/// Marker: keyed merge path (record keys for merge acceleration).
pub struct Keyed;

// ── Keyed sort orders ────────────────────────────────────

/// Sort by nucleotide sequence with quality tiebreaker,
/// using a 2-bit packed key of width N bytes (N×4 bases).
///
/// For most users, the convenience aliases are easier:
/// [`ILLUMINA_ORDER`], [`PAIRED_END_ORDER`], [`LONG_READ_ORDER`].
#[derive(Debug, Clone, Copy)]
pub struct SequenceOrder<const N: usize>;

impl<const N: usize> sealed::Sealed for SequenceOrder<N> {}

impl<const N: usize> SortOrder for SequenceOrder<N> {
    type SortKey = SequenceQualityKey;
    type Compare = Natural;
    type Strategy = Keyed;

    fn sort_key(&self) -> SequenceQualityKey {
        SequenceQualityKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

impl<const N: usize> KeyedSortOrder for SequenceOrder<N> {
    type RecordKey = PackedSequenceKey<N>;

    fn record_key(&self, record: &SeqRecord) -> PackedSequenceKey<N> {
        PackedSequenceKey::from_sequence(record.sequence())
    }

    fn record_key_fn(&self) -> fn(&SeqRecord) -> PackedSequenceKey<N> {
        |rec| PackedSequenceKey::from_sequence(rec.sequence())
    }
}

impl<const N: usize> SequenceOrder<N> {
    /// Opt out of record key acceleration, using the base
    /// merge path with full record deserialization.
    #[must_use]
    pub fn unkeyed(self) -> UnkeyedSequenceOrder {
        UnkeyedSequenceOrder
    }
}

/// Sort by record name, using a 16-byte name prefix as the
/// record key.
#[derive(Debug, Clone, Copy)]
pub struct NameOrder;

impl sealed::Sealed for NameOrder {}

impl SortOrder for NameOrder {
    type SortKey = NameKey;
    type Compare = Natural;
    type Strategy = Keyed;

    fn sort_key(&self) -> NameKey {
        NameKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

fn derive_name_key(record: &SeqRecord) -> dryice::Bytes16Key {
    let mut key = [0u8; 16];
    let len = record.name().len().min(16);
    key[..len].copy_from_slice(&record.name()[..len]);
    dryice::Bytes16Key(key)
}

impl KeyedSortOrder for NameOrder {
    type RecordKey = dryice::Bytes16Key;

    fn record_key(&self, record: &SeqRecord) -> dryice::Bytes16Key {
        derive_name_key(record)
    }

    fn record_key_fn(&self) -> fn(&SeqRecord) -> dryice::Bytes16Key {
        derive_name_key
    }
}

impl NameOrder {
    /// Opt out of record key acceleration.
    #[must_use]
    pub fn unkeyed(self) -> UnkeyedNameOrder {
        UnkeyedNameOrder
    }
}

/// Sort by sequence length, using an 8-byte big-endian u64
/// as the record key.
#[derive(Debug, Clone, Copy)]
pub struct LengthOrder;

impl sealed::Sealed for LengthOrder {}

impl SortOrder for LengthOrder {
    type SortKey = LengthKey;
    type Compare = Natural;
    type Strategy = Keyed;

    fn sort_key(&self) -> LengthKey {
        LengthKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

#[allow(clippy::cast_possible_truncation)]
fn derive_length_key(record: &SeqRecord) -> dryice::Bytes8Key {
    dryice::Bytes8Key((record.sequence().len() as u64).to_be_bytes())
}

impl KeyedSortOrder for LengthOrder {
    type RecordKey = dryice::Bytes8Key;

    fn record_key(&self, record: &SeqRecord) -> dryice::Bytes8Key {
        derive_length_key(record)
    }

    fn record_key_fn(&self) -> fn(&SeqRecord) -> dryice::Bytes8Key {
        derive_length_key
    }
}

impl LengthOrder {
    /// Opt out of record key acceleration.
    #[must_use]
    pub fn unkeyed(self) -> UnkeyedLengthOrder {
        UnkeyedLengthOrder
    }
}

// ── Unkeyed sort orders ──────────────────────────────────

/// Sort by sequence without record key acceleration.
#[derive(Debug, Clone, Copy)]
pub struct UnkeyedSequenceOrder;

impl sealed::Sealed for UnkeyedSequenceOrder {}

impl SortOrder for UnkeyedSequenceOrder {
    type SortKey = SequenceQualityKey;
    type Compare = Natural;
    type Strategy = Basic;

    fn sort_key(&self) -> SequenceQualityKey {
        SequenceQualityKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

/// Sort by name without record key acceleration.
#[derive(Debug, Clone, Copy)]
pub struct UnkeyedNameOrder;

impl sealed::Sealed for UnkeyedNameOrder {}

impl SortOrder for UnkeyedNameOrder {
    type SortKey = NameKey;
    type Compare = Natural;
    type Strategy = Basic;

    fn sort_key(&self) -> NameKey {
        NameKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

/// Sort by length without record key acceleration.
#[derive(Debug, Clone, Copy)]
pub struct UnkeyedLengthOrder;

impl sealed::Sealed for UnkeyedLengthOrder {}

impl SortOrder for UnkeyedLengthOrder {
    type SortKey = LengthKey;
    type Compare = Natural;
    type Strategy = Basic;

    fn sort_key(&self) -> LengthKey {
        LengthKey
    }

    fn compare(&self) -> Natural {
        Natural
    }
}

// ── Reverse wrapper ──────────────────────────────────────

/// Reverse any sort order. Flips the comparison direction
/// but keeps the same key pairing and merge strategy.
///
/// ```ignore
/// .sort_by(Reverse(ILLUMINA_ORDER))   // Z→A
/// .sort_by(Reverse(LengthOrder))     // longest first
/// ```
#[derive(Debug, Clone, Copy)]
pub struct Reverse<O>(pub O);

impl<O: sealed::Sealed> sealed::Sealed for Reverse<O> {}

impl<O: SortOrder> SortOrder for Reverse<O> {
    type SortKey = O::SortKey;
    type Compare = spillover::compare::Reverse<O::Compare>;
    type Strategy = O::Strategy;

    fn sort_key(&self) -> Self::SortKey {
        self.0.sort_key()
    }

    fn compare(&self) -> spillover::compare::Reverse<O::Compare> {
        spillover::compare::Reverse(self.0.compare())
    }
}

impl<O: KeyedSortOrder> KeyedSortOrder for Reverse<O> {
    type RecordKey = O::RecordKey;

    fn record_key(&self, record: &SeqRecord) -> Self::RecordKey {
        self.0.record_key(record)
    }

    fn record_key_fn(&self) -> fn(&SeqRecord) -> Self::RecordKey {
        self.0.record_key_fn()
    }
}

// ── Convenience aliases ──────────────────────────────────

/// Sequence sort with 38-byte key (152 bases, covers 150bp Illumina).
pub const ILLUMINA_ORDER: SequenceOrder<38> = SequenceOrder;

/// Sequence sort with 64-byte key (256 bases, covers 250bp paired-end).
pub const PAIRED_END_ORDER: SequenceOrder<64> = SequenceOrder;

/// Sequence sort with 128-byte key (512 bases, prefix for long reads).
pub const LONG_READ_ORDER: SequenceOrder<128> = SequenceOrder;

/// Name sort with 16-byte prefix key.
pub const NAME_ORDER: NameOrder = NameOrder;

/// Length sort with 8-byte big-endian key.
pub const LENGTH_ORDER: LengthOrder = LengthOrder;

// ── Builder ──────────────────────────────────────────────

/// Dedup strategy that compares adjacent [`SeqRecord`]s by a
/// function pointer. Used by the convenience dedup methods.
type RecordDedup = AdjacentDedup<fn(&SeqRecord, &SeqRecord) -> bool>;

/// Builder marker: no sort order chosen yet.
pub struct NeedsOrder;
/// Builder marker: keyed sort order has been chosen.
pub struct HasKeyedOrder<O>(O);
/// Builder marker: unkeyed sort order has been chosen.
pub struct HasUnkeyedOrder<O>(O);

/// Builder marker: no codec chosen yet.
pub struct NeedsCodec;
/// Builder marker: codec has been chosen.
pub struct HasCodec<S, Q, N>(DryIceCodec<S, Q, N>);

/// Builder marker: no flush strategy chosen yet.
pub struct NeedsFlush;
/// Builder marker: flush strategy has been chosen.
pub struct HasFlush(FlushConfig);

// pub visibility required because `sealed::ResolveFlush`
// returns it. The sealed module prevents external impls.
#[doc(hidden)]
pub enum FlushConfig {
    MeasuredBudget(usize),
    MaxItems(usize),
}

/// Default memory budget when `.measured_budget()` is not called:
/// 1 GiB.
const DEFAULT_BUDGET: usize = 1 << 30;

// ── Sealed trait impls for default resolution ────────────

impl sealed::ResolveCodec for NeedsCodec {
    type S = RawAsciiCodec;
    type Q = RawQualityCodec;
    type N = RawNameCodec;

    fn resolve(self) -> DryIceCodec {
        DryIceCodec::new()
    }
}

impl<S, Q, N> sealed::ResolveCodec for HasCodec<S, Q, N>
where
    S: SequenceCodec + Copy + 'static,
    Q: QualityCodec + Copy + 'static,
    N: NameCodec + Copy + 'static,
{
    type S = S;
    type Q = Q;
    type N = N;

    fn resolve(self) -> DryIceCodec<S, Q, N> {
        self.0
    }
}

impl sealed::ResolveFlush for NeedsFlush {
    fn resolve(self) -> FlushConfig {
        FlushConfig::MeasuredBudget(DEFAULT_BUDGET)
    }
}

impl sealed::ResolveFlush for HasFlush {
    fn resolve(self) -> FlushConfig {
        self.0
    }
}

/// Builder for configuring a genomics-oriented external sorter.
///
/// Only a sort order is required — everything else has sensible
/// defaults:
///
/// ```ignore
/// let mut sorter = Builder::new()
///     .sort_by_illumina()
///     .build();
/// ```
///
/// Defaults: raw (uncompressed) dryice codec, 1 GiB memory budget,
/// radix sort for sequence orders, sequential comparison sort for
/// name/length orders.
///
/// Override any default with the corresponding builder method:
///
/// ```ignore
/// let mut sorter = Builder::new()
///     .sort_by_paired_end()
///     .codec(DryIceCodec::new().two_bit_exact().binned_quality())
///     .measured_budget(4 * 1024 * 1024 * 1024)
///     .sort_with_sequential()
///     .dedup_by_sequence()
///     .build();
/// ```
///
/// For high-duplicate datasets, consider using an external bloom
/// filter in your ingest path to skip likely-duplicate records
/// before they enter the sort pipeline. This can reduce memory
/// usage, disk I/O, and merge work:
///
/// ```ignore
/// let mut bloom = fastbloom::BloomFilter::with_false_pos(0.001)
///     .expected_items(10_000_000);
///
/// for record in records {
///     if !bloom.contains(record.sequence()) {
///         bloom.insert(record.sequence());
///         sorter.push(record)?;
///     }
/// }
/// ```
pub struct Builder<O = NeedsOrder, C = NeedsCodec, F = NeedsFlush, D = Identity, CS = Sequential> {
    order: O,
    codec: C,
    flush: F,
    dedup: D,
    chunk_sort: CS,
    merge_config: MergeConfig,
}

impl Builder {
    /// Start building a new sorter.
    #[must_use]
    pub fn new() -> Self {
        Builder {
            order: NeedsOrder,
            codec: NeedsCodec,
            flush: NeedsFlush,
            dedup: Identity,
            chunk_sort: Sequential,
            merge_config: MergeConfig::default(),
        }
    }
}

impl Default for Builder {
    fn default() -> Self {
        Self::new()
    }
}

// Sort order selection.

impl<C, F, D, CS> Builder<NeedsOrder, C, F, D, CS> {
    /// Set a keyed sort order (merge compares record keys).
    #[must_use]
    pub fn sort_by<O: KeyedSortOrder>(self, order: O) -> Builder<HasKeyedOrder<O>, C, F, D, CS> {
        Builder {
            order: HasKeyedOrder(order),
            codec: self.codec,
            flush: self.flush,
            dedup: self.dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }

    /// Set an unkeyed sort order (merge deserializes full records).
    #[must_use]
    pub fn sort_by_unkeyed<O: SortOrder<Strategy = Basic>>(
        self,
        order: O,
    ) -> Builder<HasUnkeyedOrder<O>, C, F, D, CS> {
        Builder {
            order: HasUnkeyedOrder(order),
            codec: self.codec,
            flush: self.flush,
            dedup: self.dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }

    /// Sort by sequence (Illumina 150bp, 38-byte packed key).
    /// Defaults to radix sort for the chunk sorting engine.
    #[must_use]
    pub fn sort_by_illumina(
        self,
    ) -> Builder<HasKeyedOrder<SequenceOrder<38>>, C, F, D, RadixThenRefine<38>> {
        self.sort_by(ILLUMINA_ORDER)
            .chunk_sort(RadixThenRefine::<38>)
    }

    /// Sort by sequence (250bp paired-end, 64-byte packed key).
    /// Defaults to radix sort for the chunk sorting engine.
    #[must_use]
    pub fn sort_by_paired_end(
        self,
    ) -> Builder<HasKeyedOrder<SequenceOrder<64>>, C, F, D, RadixThenRefine<64>> {
        self.sort_by(PAIRED_END_ORDER)
            .chunk_sort(RadixThenRefine::<64>)
    }

    /// Sort by sequence (long reads, 128-byte prefix key).
    /// Defaults to radix sort for the chunk sorting engine.
    #[must_use]
    pub fn sort_by_long_read(
        self,
    ) -> Builder<HasKeyedOrder<SequenceOrder<128>>, C, F, D, RadixThenRefine<128>> {
        self.sort_by(LONG_READ_ORDER)
            .chunk_sort(RadixThenRefine::<128>)
    }

    /// Sort by record name.
    #[must_use]
    pub fn sort_by_name(self) -> Builder<HasKeyedOrder<NameOrder>, C, F, D, CS> {
        self.sort_by(NAME_ORDER)
    }

    /// Sort by sequence length.
    #[must_use]
    pub fn sort_by_length(self) -> Builder<HasKeyedOrder<LengthOrder>, C, F, D, CS> {
        self.sort_by(LENGTH_ORDER)
    }
}

// Codec selection.

impl<O, F, D, CS> Builder<O, NeedsCodec, F, D, CS> {
    /// Set the dryice codec for temporary file encoding.
    #[must_use]
    pub fn codec<S, Q, N>(
        self,
        codec: DryIceCodec<S, Q, N>,
    ) -> Builder<O, HasCodec<S, Q, N>, F, D, CS> {
        Builder {
            order: self.order,
            codec: HasCodec(codec),
            flush: self.flush,
            dedup: self.dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }
}

// Flush strategy selection.

impl<O, C, D, CS> Builder<O, C, NeedsFlush, D, CS> {
    /// Flush when estimated memory usage exceeds `budget` bytes.
    /// Requires [`SeqRecord`] to implement `GetSize`.
    #[must_use]
    pub fn measured_budget(self, budget: usize) -> Builder<O, C, HasFlush, D, CS> {
        Builder {
            order: self.order,
            codec: self.codec,
            flush: HasFlush(FlushConfig::MeasuredBudget(budget)),
            dedup: self.dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }

    /// Flush when the buffer reaches `max_items` records.
    #[must_use]
    pub fn max_buffer_items(self, max_items: usize) -> Builder<O, C, HasFlush, D, CS> {
        Builder {
            order: self.order,
            codec: self.codec,
            flush: HasFlush(FlushConfig::MaxItems(max_items)),
            dedup: self.dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }
}

// Optional configuration.

impl<O, C, F, D, CS> Builder<O, C, F, D, CS> {
    /// Set a custom deduplication strategy. Defaults to
    /// [`Identity`] (no dedup).
    #[must_use]
    pub fn dedup<D2>(self, dedup: D2) -> Builder<O, C, F, D2, CS> {
        Builder {
            order: self.order,
            codec: self.codec,
            flush: self.flush,
            dedup,
            chunk_sort: self.chunk_sort,
            merge_config: self.merge_config,
        }
    }

    /// Set a custom chunk sorting strategy. Defaults to
    /// [`Sequential`].
    #[must_use]
    pub fn chunk_sort<CS2>(self, chunk_sort: CS2) -> Builder<O, C, F, D, CS2> {
        Builder {
            order: self.order,
            codec: self.codec,
            flush: self.flush,
            dedup: self.dedup,
            chunk_sort,
            merge_config: self.merge_config,
        }
    }

    /// Override the merge configuration.
    #[must_use]
    pub fn merge_config(mut self, config: MergeConfig) -> Self {
        self.merge_config = config;
        self
    }

    /// Deduplicate adjacent records with identical names.
    #[must_use]
    pub fn dedup_by_name(self) -> Builder<O, C, F, RecordDedup, CS> {
        self.dedup(AdjacentDedup::new(
            (|a: &SeqRecord, b: &SeqRecord| a.name() == b.name())
                as fn(&SeqRecord, &SeqRecord) -> bool,
        ))
    }

    /// Deduplicate adjacent records with identical sequences.
    #[must_use]
    pub fn dedup_by_sequence(self) -> Builder<O, C, F, RecordDedup, CS> {
        self.dedup(AdjacentDedup::new(
            (|a: &SeqRecord, b: &SeqRecord| a.sequence() == b.sequence())
                as fn(&SeqRecord, &SeqRecord) -> bool,
        ))
    }

    /// Deduplicate adjacent records with identical quality scores.
    #[must_use]
    pub fn dedup_by_quality(self) -> Builder<O, C, F, RecordDedup, CS> {
        self.dedup(AdjacentDedup::new(
            (|a: &SeqRecord, b: &SeqRecord| a.quality() == b.quality())
                as fn(&SeqRecord, &SeqRecord) -> bool,
        ))
    }

    /// Deduplicate adjacent records with identical sequence and
    /// quality.
    #[must_use]
    pub fn dedup_by_sequence_and_quality(self) -> Builder<O, C, F, RecordDedup, CS> {
        self.dedup(AdjacentDedup::new(
            (|a: &SeqRecord, b: &SeqRecord| {
                a.sequence() == b.sequence() && a.quality() == b.quality()
            }) as fn(&SeqRecord, &SeqRecord) -> bool,
        ))
    }

    /// Use single-threaded comparison sort for in-memory chunks.
    ///
    /// This overrides the default sort engine (which is radix sort
    /// for sequence orders, and sequential for everything else).
    #[must_use]
    pub fn sort_with_sequential(self) -> Builder<O, C, F, D, Sequential> {
        self.chunk_sort(Sequential)
    }

    /// Use rayon parallel sort for in-memory chunks.
    ///
    /// This overrides the default sort engine. Requires the `rayon`
    /// feature to be enabled on spillover.
    #[cfg(feature = "rayon")]
    #[must_use]
    pub fn sort_with_parallel(self) -> Builder<O, C, F, D, spillover::chunk::Parallel> {
        self.chunk_sort(spillover::chunk::Parallel)
    }
}

// build() for keyed sort orders.
//
// The `ResolveCodec` and `ResolveFlush` traits handle defaults:
// `NeedsCodec` → raw DryIceCodec, `NeedsFlush` → 1 GiB budget.
// This single impl covers all four combinations of has/needs.

impl<O, C, F, D, CS> Builder<HasKeyedOrder<O>, C, F, D, CS>
where
    O: KeyedSortOrder,
    O::SortKey: Send + Sync + 'static,
    O::Compare: for<'a> Compare<<O::SortKey as SortKey<SeqRecord>>::Key<'a>>
        + Compare<O::RecordKey>
        + Send
        + Sync
        + 'static,
    O::RecordKey: RecordKey + Clone + 'static,
    C: sealed::ResolveCodec,
    F: sealed::ResolveFlush,
    D: Dedup<SeqRecord, spillover::merge::MergeError<dryice::DryIceError>>,
    CS: ChunkSorter<SeqRecord>,
{
    /// Build the sorter (keyed merge path).
    ///
    /// If `.codec()` was not called, defaults to raw (uncompressed)
    /// dryice encoding. If `.measured_budget()` / `.max_buffer_items()`
    /// was not called, defaults to a 1 GiB measured memory budget.
    #[allow(clippy::type_complexity)]
    #[must_use]
    pub fn build(
        self,
    ) -> spillover::sorter::Sorter<
        SeqRecord,
        O::SortKey,
        KeyedDryIceCodec<C::S, C::Q, C::N, O::RecordKey>,
        O::Compare,
        D,
        CS,
        spillover::sorter::Keyed,
    > {
        let order = self.order.0;
        let codec = self.codec.resolve();
        let keyed_codec = codec.with_record_key(order.record_key_fn());
        let flush = self.flush.resolve();

        let builder = spillover::sorter::Builder::new()
            .key(order.sort_key())
            .compare(order.compare())
            .keyed_codec(keyed_codec)
            .dedup(self.dedup)
            .chunk_sort(self.chunk_sort)
            .merge_config(self.merge_config);

        match flush {
            FlushConfig::MeasuredBudget(budget) => {
                builder.measured_budget::<SeqRecord>(budget).build()
            }
            FlushConfig::MaxItems(max_items) => {
                builder.max_buffer_items::<SeqRecord>(max_items).build()
            }
        }
    }
}

// build() for unkeyed sort orders.

impl<O, C, F, D, CS> Builder<HasUnkeyedOrder<O>, C, F, D, CS>
where
    O: SortOrder<Strategy = Basic>,
    O::SortKey: Send + Sync + 'static,
    O::Compare:
        for<'a> Compare<<O::SortKey as SortKey<SeqRecord>>::Key<'a>> + Send + Sync + 'static,
    C: sealed::ResolveCodec,
    F: sealed::ResolveFlush,
    D: Dedup<SeqRecord, spillover::merge::MergeError<dryice::DryIceError>>,
    CS: ChunkSorter<SeqRecord>,
{
    /// Build the sorter (basic merge path, no record keys).
    ///
    /// If `.codec()` was not called, defaults to raw (uncompressed)
    /// dryice encoding. If `.measured_budget()` / `.max_buffer_items()`
    /// was not called, defaults to a 1 GiB measured memory budget.
    #[allow(clippy::type_complexity)]
    #[must_use]
    pub fn build(
        self,
    ) -> spillover::sorter::Sorter<
        SeqRecord,
        O::SortKey,
        DryIceCodec<C::S, C::Q, C::N>,
        O::Compare,
        D,
        CS,
        spillover::sorter::Basic,
    > {
        let order = self.order.0;
        let codec = self.codec.resolve();
        let flush = self.flush.resolve();

        let builder = spillover::sorter::Builder::new()
            .key(order.sort_key())
            .compare(order.compare())
            .codec(codec)
            .dedup(self.dedup)
            .chunk_sort(self.chunk_sort)
            .merge_config(self.merge_config);

        match flush {
            FlushConfig::MeasuredBudget(budget) => {
                builder.measured_budget::<SeqRecord>(budget).build()
            }
            FlushConfig::MaxItems(max_items) => {
                builder.max_buffer_items::<SeqRecord>(max_items).build()
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use std::cmp::Ordering;

    use spillover::compare::{Compare, Natural};
    use spillover::key::SortKey;

    use super::*;

    fn make_record(name: &[u8], seq: &[u8], qual: &[u8]) -> SeqRecord {
        SeqRecord::new(name.to_vec(), seq.to_vec(), qual.to_vec())
    }

    // ── Sort key tests ───────────────────────────────────

    #[test]
    fn sequence_quality_key_extracts_tuple() {
        let rec = make_record(b"r1", b"ACGT", b"!!!!");
        let (seq, qual) = SequenceQualityKey.key(&rec);
        assert_eq!(seq, b"ACGT");
        assert_eq!(qual, b"!!!!");
    }

    #[test]
    fn sequence_quality_key_sorts_by_sequence_first() {
        let a = make_record(b"r1", b"AAAA", b"IIII");
        let b = make_record(b"r2", b"CCCC", b"!!!!");

        let cmp = SequenceQualityKey.item_cmp(&Natural);
        assert_eq!(
            cmp(&a, &b),
            Ordering::Less,
            "AAAA < CCCC regardless of quality"
        );
    }

    #[test]
    fn sequence_quality_key_tiebreaks_by_quality() {
        let a = make_record(b"r1", b"ACGT", b"IIII");
        let b = make_record(b"r2", b"ACGT", b"!!!!");

        let cmp = SequenceQualityKey.item_cmp(&Natural);
        assert_eq!(
            cmp(&a, &b),
            Ordering::Greater,
            "same sequence, IIII > !!!! in ASCII"
        );
    }

    #[test]
    fn sequence_quality_key_equal_when_both_match() {
        let a = make_record(b"r1", b"ACGT", b"!!!!");
        let b = make_record(b"r2", b"ACGT", b"!!!!");

        let cmp = SequenceQualityKey.item_cmp(&Natural);
        assert_eq!(
            cmp(&a, &b),
            Ordering::Equal,
            "same sequence and quality should be equal regardless of name"
        );
    }

    #[test]
    fn sequence_quality_key_can_sort_records() {
        let mut records = [
            make_record(b"r1", b"ACGT", b"!!!!"),
            make_record(b"r2", b"ACGT", b"IIII"),
            make_record(b"r3", b"AAAA", b"!!!!"),
        ];

        let cmp = SequenceQualityKey.item_cmp(&Natural);
        records.sort_by(cmp);

        assert_eq!(records[0].sequence(), b"AAAA");
        assert_eq!(records[1].quality(), b"!!!!");
        assert_eq!(records[2].quality(), b"IIII");
    }

    #[test]
    fn name_key_extracts_name() {
        let rec = make_record(b"read_001", b"ACGT", b"!!!!");
        assert_eq!(NameKey.key(&rec), b"read_001");
    }

    #[test]
    fn name_key_sorts_lexicographically() {
        let a = make_record(b"aaa", b"ACGT", b"!!!!");
        let b = make_record(b"bbb", b"ACGT", b"!!!!");

        let cmp = NameKey.item_cmp(&Natural);
        assert_eq!(cmp(&a, &b), Ordering::Less);
    }

    #[test]
    fn length_key_extracts_length() {
        let rec = make_record(b"r1", b"ACGTACGT", b"!!!!!!!!");
        assert_eq!(LengthKey.key(&rec), 8);
    }

    #[test]
    fn length_key_empty_sequence() {
        let rec = make_record(b"r1", b"", b"");
        assert_eq!(LengthKey.key(&rec), 0);
    }

    #[test]
    fn length_key_sorts_by_length() {
        let short = make_record(b"r1", b"AC", b"!!");
        let long = make_record(b"r2", b"ACGTACGT", b"!!!!!!!!");

        let cmp = LengthKey.item_cmp(&Natural);
        assert_eq!(cmp(&short, &long), Ordering::Less);
    }

    #[test]
    fn sort_keys_are_copy() {
        fn assert_copy<T: Copy>() {}
        assert_copy::<SequenceQualityKey>();
        assert_copy::<NameKey>();
        assert_copy::<LengthKey>();
    }

    // ── Sort order tests ─────────────────────────────────

    #[test]
    fn illumina_order_produces_correct_key() {
        let rec = make_record(b"r1", b"ACGT", b"!!!!");
        let key = ILLUMINA_ORDER.record_key(&rec);
        let expected = crate::key::PackedSequenceKey::<38>::from_sequence(b"ACGT");
        assert_eq!(key, expected);
    }

    #[test]
    fn name_order_produces_correct_key() {
        let rec = make_record(b"read_001", b"ACGT", b"!!!!");
        let key = NameOrder.record_key(&rec);
        let mut expected = [0u8; 16];
        expected[..8].copy_from_slice(b"read_001");
        assert_eq!(key, dryice::Bytes16Key(expected));
    }

    #[test]
    fn name_order_truncates_long_names() {
        let rec = make_record(b"a_very_long_name_that_exceeds_16_bytes", b"ACGT", b"!!!!");
        let key = NameOrder.record_key(&rec);
        assert_eq!(&key.0, b"a_very_long_name");
    }

    #[test]
    fn length_order_produces_correct_key() {
        let rec = make_record(b"r1", b"ACGTACGT", b"!!!!!!!!");
        let key = LengthOrder.record_key(&rec);
        assert_eq!(key, dryice::Bytes8Key(8u64.to_be_bytes()));
    }

    #[test]
    fn length_order_big_endian_preserves_ord() {
        let short = make_record(b"r1", b"AC", b"!!");
        let long = make_record(b"r2", b"ACGTACGT", b"!!!!!!!!");
        let key_short = LengthOrder.record_key(&short);
        let key_long = LengthOrder.record_key(&long);
        assert!(
            key_short < key_long,
            "big-endian u64 should preserve ordering"
        );
    }

    #[test]
    fn sequence_order_uses_tuple_key_with_tiebreaker() {
        let order = ILLUMINA_ORDER;
        let sk = order.sort_key();
        let cmp = order.compare();

        let a = make_record(b"r1", b"ACGT", b"IIII");
        let b = make_record(b"r2", b"ACGT", b"!!!!");

        let ka = sk.key(&a);
        let kb = sk.key(&b);

        assert_eq!(
            cmp.compare(&ka, &kb),
            Ordering::Greater,
            "same sequence, IIII > !!!! via tuple Ord"
        );
    }

    #[test]
    fn reverse_flips_key_ordering() {
        let order = Reverse(ILLUMINA_ORDER);
        let sk = order.sort_key();
        let cmp = order.compare();

        let a = make_record(b"r1", b"AAAA", b"!!!!");
        let b = make_record(b"r2", b"TTTT", b"!!!!");

        let ka = sk.key(&a);
        let kb = sk.key(&b);

        assert_eq!(
            cmp.compare(&ka, &kb),
            Ordering::Greater,
            "reversed: AAAA key should be greater than TTTT key"
        );
    }

    #[test]
    fn reverse_preserves_record_key() {
        let rec = make_record(b"r1", b"ACGT", b"!!!!");
        let forward_key = ILLUMINA_ORDER.record_key(&rec);
        let reverse_key = Reverse(ILLUMINA_ORDER).record_key(&rec);
        assert_eq!(
            forward_key, reverse_key,
            "reverse should not change the record key"
        );
    }

    #[test]
    fn unkeyed_sequence_order_has_basic_strategy() {
        fn assert_basic<O: SortOrder<Strategy = Basic>>() {}
        assert_basic::<UnkeyedSequenceOrder>();
    }

    #[test]
    fn keyed_sequence_order_has_keyed_strategy() {
        fn assert_keyed<O: SortOrder<Strategy = Keyed>>() {}
        assert_keyed::<SequenceOrder<38>>();
    }

    #[test]
    fn all_orders_are_copy() {
        fn assert_copy<T: Copy>() {}
        assert_copy::<SequenceOrder<38>>();
        assert_copy::<SequenceOrder<64>>();
        assert_copy::<SequenceOrder<128>>();
        assert_copy::<NameOrder>();
        assert_copy::<LengthOrder>();
        assert_copy::<UnkeyedSequenceOrder>();
        assert_copy::<UnkeyedNameOrder>();
        assert_copy::<UnkeyedLengthOrder>();
        assert_copy::<Reverse<SequenceOrder<38>>>();
    }

    #[test]
    fn unkeyed_from_keyed() {
        fn assert_basic<O: SortOrder<Strategy = Basic>>() {}

        let _unkeyed = ILLUMINA_ORDER.unkeyed();
        assert_basic::<UnkeyedSequenceOrder>();

        let _unkeyed = NameOrder.unkeyed();
        assert_basic::<UnkeyedNameOrder>();

        let _unkeyed = LengthOrder.unkeyed();
        assert_basic::<UnkeyedLengthOrder>();
    }
}