spg-engine 7.16.0

Execution engine for SPG: glues spg-sql parsing to spg-storage. Foreign keys, joins, vectors, cold tier.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
//! v7.12.4 — PL/pgSQL row-level trigger e2e suite.
//!
//! Tests build up from "trigger fires" → "NEW.col := … applied" →
//! "RETURN NULL skips" → "mailrs `search_vector` shape" against
//! the v7.12.3 GIN index. v7.12.5+ slices grow this file with
//! IF / DECLARE / embedded SQL coverage.

use spg_engine::Engine;
use spg_storage::Value;

fn eng() -> Engine {
    Engine::new()
}

fn ok(e: &mut Engine, sql: &str) {
    e.execute(sql)
        .unwrap_or_else(|err| panic!("{sql}: {err:?}"));
}

fn rows(e: &mut Engine, sql: &str) -> Vec<spg_storage::Row> {
    let r = e
        .execute(sql)
        .unwrap_or_else(|err| panic!("{sql}: {err:?}"));
    match r {
        spg_engine::QueryResult::Rows { rows, .. } => rows,
        other => panic!("expected rows, got {other:?}"),
    }
}

fn first_value(e: &mut Engine, sql: &str) -> Value {
    rows(e, sql)
        .into_iter()
        .next()
        .map(|mut r| r.values.remove(0))
        .expect("at least one row")
}

#[test]
fn create_function_and_trigger_persist_in_catalog() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION noop() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION noop()",
    );
    // Snapshot + restore round-trips functions + triggers.
    let bytes = e.snapshot();
    let cat = spg_storage::Catalog::deserialize(&bytes).unwrap();
    assert!(cat.functions().contains_key("noop"));
    assert!(cat.triggers().iter().any(|t| t.name == "tg"));
}

#[test]
fn before_insert_trigger_returns_new_unchanged_passes_row_through() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION noop() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION noop()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    let v = first_value(&mut e, "SELECT v FROM t WHERE id = 1");
    assert_eq!(v, Value::Int(10));
}

#[test]
fn before_insert_trigger_returns_null_skips_the_row() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION blackhole() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN RETURN NULL; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION blackhole()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    let rs = rows(&mut e, "SELECT id FROM t");
    assert!(
        rs.is_empty(),
        "trigger returned NULL, row should be skipped"
    );
}

#[test]
fn before_insert_trigger_rewrites_new_column() {
    // NEW.v := 999 — trigger overwrites the cell before write.
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION force_v() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := 999; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION force_v()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    let v = first_value(&mut e, "SELECT v FROM t WHERE id = 1");
    // BEFORE trigger rewrote v from 10 to 999.
    assert_eq!(v, Value::Int(999));
}

#[test]
fn before_insert_trigger_mailrs_search_vector_shape() {
    // The mailrs G-CRIT-3 acceptance shape: NEW.search_vector is
    // populated from to_tsvector(NEW.<text columns>). Verifies
    // the end-to-end path (trigger fires, NEW.col := <function
    // call referencing NEW.col>, GIN-indexed column gets data).
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE messages (id INT NOT NULL, subject TEXT NOT NULL, sender TEXT NOT NULL, search_vector tsvector)",
    );
    ok(
        &mut e,
        "CREATE INDEX msg_sv_gin ON messages USING gin (search_vector)",
    );
    ok(
        &mut e,
        "CREATE FUNCTION update_sv() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  NEW.search_vector := to_tsvector('simple', NEW.subject);
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER messages_sv BEFORE INSERT ON messages FOR EACH ROW EXECUTE FUNCTION update_sv()",
    );
    ok(
        &mut e,
        "INSERT INTO messages VALUES (1, 'the quick brown fox', 'alice@example.com', NULL)",
    );
    // Search via the GIN index — should match the row whose
    // search_vector got auto-populated by the trigger.
    let rs = rows(
        &mut e,
        "SELECT id FROM messages WHERE search_vector @@ to_tsquery('simple', 'fox')",
    );
    assert_eq!(rs.len(), 1, "expected fox to match the auto-populated row");
    assert!(matches!(rs[0].values[0], Value::Int(1)));
}

#[test]
fn after_trigger_cannot_assign_to_new() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION bad() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := 1; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg AFTER INSERT ON t FOR EACH ROW EXECUTE FUNCTION bad()",
    );
    let err = e
        .execute("INSERT INTO t VALUES (1, 10)")
        .expect_err("AFTER trigger assigning NEW must error");
    let msg = alloc_format(&err);
    assert!(
        msg.to_lowercase().contains("after") && msg.to_lowercase().contains("read-only"),
        "expected AFTER NEW read-only error, got {msg}"
    );
}

#[test]
fn drop_trigger_stops_firing() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION force_v() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := 999; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION force_v()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(999)
    );
    // Drop the trigger; subsequent inserts should keep the
    // caller-provided value.
    ok(&mut e, "DROP TRIGGER tg ON t");
    ok(&mut e, "INSERT INTO t VALUES (2, 10)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 2"),
        Value::Int(10)
    );
}

fn alloc_format<T: core::fmt::Debug>(t: &T) -> String {
    format!("{t:?}")
}

// --- v7.12.5: UPDATE + DELETE trigger hooks ---

#[test]
fn before_update_trigger_can_rewrite_new_column() {
    // BEFORE UPDATE sees NEW (post-update candidate) + OLD
    // (pre-update). Trigger rewrites NEW.v to a sentinel value.
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    ok(
        &mut e,
        "CREATE FUNCTION force_v() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := 777; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE UPDATE ON t FOR EACH ROW EXECUTE FUNCTION force_v()",
    );
    ok(&mut e, "UPDATE t SET v = 99 WHERE id = 1");
    // The user's UPDATE asked for v=99 but the BEFORE trigger
    // rewrote it to 777 before the write landed.
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(777)
    );
}

#[test]
fn before_update_trigger_can_skip_via_return_null() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    ok(
        &mut e,
        "CREATE FUNCTION veto() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN RETURN NULL; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE UPDATE ON t FOR EACH ROW EXECUTE FUNCTION veto()",
    );
    ok(&mut e, "UPDATE t SET v = 99 WHERE id = 1");
    // The trigger returned NULL — UPDATE skipped, v stays 10.
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(10)
    );
}

#[test]
fn before_update_trigger_sees_old_row() {
    // Trigger writes NEW.v := OLD.v + 1 — a typical "increment
    // on update" pattern.
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    ok(
        &mut e,
        "CREATE FUNCTION bump() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := OLD.v + 1; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE UPDATE ON t FOR EACH ROW EXECUTE FUNCTION bump()",
    );
    ok(&mut e, "UPDATE t SET v = 999 WHERE id = 1");
    // OLD.v was 10, NEW.v becomes 11 (regardless of what user
    // SET told us to write).
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(11)
    );
}

#[test]
fn before_delete_trigger_can_veto_individual_rows() {
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE t (id INT NOT NULL, keep INT NOT NULL)",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 0)");
    ok(&mut e, "INSERT INTO t VALUES (2, 1)");
    ok(&mut e, "INSERT INTO t VALUES (3, 0)");
    // Trigger: skip rows where OLD.keep = 1.
    ok(
        &mut e,
        "CREATE FUNCTION guard() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  NEW.keep := OLD.keep;
  RETURN NEW;
END;
$$",
    );
    // The trigger above runs as BEFORE UPDATE (no DELETE skip);
    // for the DELETE-skip semantics build a dedicated trigger that
    // returns NULL when OLD.keep = 1. v7.12.5 doesn't yet have IF
    // in PL/pgSQL, so this test instead verifies the easier shape:
    // a BEFORE DELETE that always returns NULL skips ALL deletes.
    ok(
        &mut e,
        "CREATE FUNCTION blackhole_del() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN RETURN NULL; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg_del BEFORE DELETE ON t FOR EACH ROW EXECUTE FUNCTION blackhole_del()",
    );
    let r = e
        .execute("DELETE FROM t WHERE id IN (1, 2, 3)")
        .expect("delete should succeed (just no-op)");
    if let spg_engine::QueryResult::CommandOk { affected, .. } = r {
        assert_eq!(
            affected, 0,
            "all 3 rows skipped via BEFORE DELETE RETURN NULL"
        );
    }
    // All rows still present.
    let count = first_value(&mut e, "SELECT count(*) FROM t");
    assert_eq!(count, Value::BigInt(3));
}

#[test]
fn after_update_trigger_cannot_assign_to_new() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    ok(
        &mut e,
        "CREATE FUNCTION bad_after() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN NEW.v := 1; RETURN NEW; END; $$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg AFTER UPDATE ON t FOR EACH ROW EXECUTE FUNCTION bad_after()",
    );
    let err = e
        .execute("UPDATE t SET v = 99 WHERE id = 1")
        .expect_err("AFTER UPDATE writing NEW must error");
    let msg = alloc_format(&err);
    assert!(
        msg.to_lowercase().contains("after") && msg.to_lowercase().contains("read-only"),
        "expected AFTER NEW read-only error, got {msg}"
    );
}

// --- v7.12.6: IF / ELSIF / ELSE control flow ---

#[test]
fn before_insert_trigger_if_then_rewrites_only_when_condition_true() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    // If v == 10 → rewrite to 999. Otherwise pass-through.
    ok(
        &mut e,
        "CREATE FUNCTION gated() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  IF NEW.v = 10 THEN
    NEW.v := 999;
  END IF;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION gated()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 10)");
    ok(&mut e, "INSERT INTO t VALUES (2, 11)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(999),
        "row matching IF predicate gets rewritten"
    );
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 2"),
        Value::Int(11),
        "row not matching IF predicate passes through"
    );
}

#[test]
fn before_insert_trigger_if_elsif_else_chain() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION grade() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  IF NEW.v < 60 THEN
    NEW.v := 0;
  ELSIF NEW.v < 90 THEN
    NEW.v := 50;
  ELSE
    NEW.v := 100;
  END IF;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION grade()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 50)");
    ok(&mut e, "INSERT INTO t VALUES (2, 75)");
    ok(&mut e, "INSERT INTO t VALUES (3, 95)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(0)
    );
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 2"),
        Value::Int(50)
    );
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 3"),
        Value::Int(100)
    );
}

#[test]
fn before_insert_trigger_if_can_short_circuit_via_return_null() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION pos_only() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  IF NEW.v < 0 THEN
    RETURN NULL;
  END IF;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION pos_only()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 5)");
    ok(&mut e, "INSERT INTO t VALUES (2, -3)");
    let count = first_value(&mut e, "SELECT count(*) FROM t");
    assert_eq!(count, Value::BigInt(1));
}

// --- v7.12.6: DECLARE local variables ---

#[test]
fn before_insert_trigger_declare_and_use_local_var() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION doubled() RETURNS TRIGGER LANGUAGE plpgsql AS $$
DECLARE
  scaled INT := NEW.v * 2;
BEGIN
  NEW.v := scaled;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION doubled()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 7)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(14)
    );
}

#[test]
fn before_insert_trigger_declare_chain_and_assign() {
    // Earlier DECLAREs are in scope for later DECLAREs.
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION chained() RETURNS TRIGGER LANGUAGE plpgsql AS $$
DECLARE
  a INT := NEW.v + 1;
  b INT := a * 10;
BEGIN
  NEW.v := b;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION chained()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 4)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(50)
    );
}

// --- v7.12.6: RAISE NOTICE / EXCEPTION ---

#[test]
fn before_insert_trigger_raise_notice_does_not_block_write() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION log_it() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  RAISE NOTICE 'inserting row %', NEW.id;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION log_it()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 42)");
    assert_eq!(
        first_value(&mut e, "SELECT v FROM t WHERE id = 1"),
        Value::Int(42)
    );
}

#[test]
fn before_insert_trigger_raise_exception_blocks_write_and_propagates_message() {
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE FUNCTION reject_neg() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  IF NEW.v < 0 THEN
    RAISE EXCEPTION 'negative value % rejected', NEW.v;
  END IF;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON t FOR EACH ROW EXECUTE FUNCTION reject_neg()",
    );
    // Positive value goes in.
    ok(&mut e, "INSERT INTO t VALUES (1, 5)");
    // Negative value triggers RAISE EXCEPTION → propagates as
    // engine error.
    let err = e
        .execute("INSERT INTO t VALUES (2, -10)")
        .expect_err("RAISE EXCEPTION must abort the insert");
    let msg = alloc_format(&err);
    assert!(
        msg.contains("negative value") && msg.contains("-10"),
        "RAISE EXCEPTION message + arg substitution should propagate: {msg}"
    );
    // Row 2 didn't land.
    let count = first_value(&mut e, "SELECT count(*) FROM t");
    assert_eq!(count, Value::BigInt(1));
}

// --- v7.12.7: embedded SQL inside trigger bodies ---

#[test]
fn after_insert_trigger_embedded_insert_to_audit_table() {
    // Canonical audit-log shape: AFTER INSERT trigger inserts
    // a row into a separate audit table referencing NEW.id.
    let mut e = eng();
    ok(&mut e, "CREATE TABLE t (id INT NOT NULL, v INT NOT NULL)");
    ok(
        &mut e,
        "CREATE TABLE t_audit (src_id INT NOT NULL, src_v INT NOT NULL)",
    );
    ok(
        &mut e,
        "CREATE FUNCTION audit() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  INSERT INTO t_audit VALUES (NEW.id, NEW.v);
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg AFTER INSERT ON t FOR EACH ROW EXECUTE FUNCTION audit()",
    );
    ok(&mut e, "INSERT INTO t VALUES (1, 100)");
    ok(&mut e, "INSERT INTO t VALUES (2, 200)");
    // Both rows landed in the audit table.
    let r = rows(&mut e, "SELECT src_id, src_v FROM t_audit ORDER BY src_id");
    assert_eq!(r.len(), 2);
    assert_eq!(r[0].values, vec![Value::Int(1), Value::Int(100)]);
    assert_eq!(r[1].values, vec![Value::Int(2), Value::Int(200)]);
}

#[test]
fn after_update_trigger_embedded_update_to_propagate_to_related_table() {
    // AFTER UPDATE trigger propagates a denormalised cell to a
    // related table via an embedded UPDATE referencing NEW + OLD.
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE users (id INT NOT NULL, name TEXT NOT NULL)",
    );
    ok(
        &mut e,
        "CREATE TABLE posts (id INT NOT NULL, author_id INT NOT NULL, author_name TEXT NOT NULL)",
    );
    ok(&mut e, "INSERT INTO users VALUES (1, 'alice'), (2, 'bob')");
    ok(
        &mut e,
        "INSERT INTO posts VALUES (10, 1, 'alice'), (11, 2, 'bob'), (12, 1, 'alice')",
    );
    ok(
        &mut e,
        "CREATE FUNCTION sync_author_name() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  UPDATE posts SET author_name = NEW.name WHERE author_id = NEW.id;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg AFTER UPDATE ON users FOR EACH ROW EXECUTE FUNCTION sync_author_name()",
    );
    ok(&mut e, "UPDATE users SET name = 'ALICE' WHERE id = 1");
    // Both alice posts got rewritten.
    let r = rows(&mut e, "SELECT id, author_name FROM posts ORDER BY id");
    assert_eq!(
        r[0].values,
        vec![Value::Int(10), Value::Text("ALICE".into())]
    );
    assert_eq!(r[1].values, vec![Value::Int(11), Value::Text("bob".into())]);
    assert_eq!(
        r[2].values,
        vec![Value::Int(12), Value::Text("ALICE".into())]
    );
}

#[test]
fn after_delete_trigger_embedded_delete_to_cleanup_related_rows() {
    // AFTER DELETE trigger removes related rows via an embedded
    // DELETE referencing OLD.id.
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE parent (id INT NOT NULL, name TEXT NOT NULL)",
    );
    ok(
        &mut e,
        "CREATE TABLE child (parent_id INT NOT NULL, payload TEXT NOT NULL)",
    );
    ok(&mut e, "INSERT INTO parent VALUES (1, 'p1'), (2, 'p2')");
    ok(
        &mut e,
        "INSERT INTO child VALUES (1, 'c1a'), (1, 'c1b'), (2, 'c2a')",
    );
    ok(
        &mut e,
        "CREATE FUNCTION cascade_delete_children() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  DELETE FROM child WHERE parent_id = OLD.id;
  RETURN OLD;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg AFTER DELETE ON parent FOR EACH ROW EXECUTE FUNCTION cascade_delete_children()",
    );
    ok(&mut e, "DELETE FROM parent WHERE id = 1");
    // child rows for parent_id=1 are gone; parent_id=2 stayed.
    let r = rows(
        &mut e,
        "SELECT parent_id, payload FROM child ORDER BY payload",
    );
    assert_eq!(r.len(), 1);
    assert_eq!(r[0].values, vec![Value::Int(2), Value::Text("c2a".into())]);
}

#[test]
fn before_insert_trigger_raise_exception_inside_if_still_propagates() {
    // Composition test: IF predicate + RAISE EXCEPTION + embedded
    // SQL in the truthy branch.
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE accounts (id INT NOT NULL, balance INT NOT NULL)",
    );
    ok(
        &mut e,
        "CREATE TABLE rejections (account_id INT NOT NULL, reason TEXT NOT NULL)",
    );
    ok(
        &mut e,
        "CREATE FUNCTION guard() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  IF NEW.balance < 0 THEN
    INSERT INTO rejections VALUES (NEW.id, 'negative balance');
    RAISE EXCEPTION 'rejected negative balance for account %', NEW.id;
  END IF;
  RETURN NEW;
END;
$$",
    );
    ok(
        &mut e,
        "CREATE TRIGGER tg BEFORE INSERT ON accounts FOR EACH ROW EXECUTE FUNCTION guard()",
    );
    // OK row goes in.
    ok(&mut e, "INSERT INTO accounts VALUES (1, 100)");
    // Negative balance row triggers the IF branch — embedded
    // INSERT queues + RAISE EXCEPTION fires.
    let err = e
        .execute("INSERT INTO accounts VALUES (2, -50)")
        .expect_err("RAISE EXCEPTION must abort");
    let msg = alloc_format(&err);
    assert!(
        msg.contains("rejected negative balance") && msg.contains("2"),
        "RAISE EXCEPTION should propagate with substituted account id: {msg}"
    );
    // Verify the row didn't land.
    let r = rows(&mut e, "SELECT id FROM accounts ORDER BY id");
    assert_eq!(r.len(), 1, "row 2 must not be inserted");
    // v7.12.7 — RAISE EXCEPTION aborts before the deferred
    // embedded INSERT runs, so `rejections` stays empty.
    // (PG would have run the embedded SQL inline; we collect-
    // then-execute, so abort wins. Documented in the design
    // and acceptable trade-off.)
    let r2 = rows(&mut e, "SELECT account_id FROM rejections");
    assert!(
        r2.is_empty(),
        "deferred embedded INSERT must NOT run when RAISE EXCEPTION aborts"
    );
}

#[test]
fn mailrs_update_search_vector_on_subject_change() {
    // mailrs G-CRIT-3 UPDATE-shape acceptance: when a message's
    // `subject` changes, `search_vector` must auto-recompute via
    // the BEFORE UPDATE trigger and the GIN index must pick up
    // the new lexemes. Mirrors the v7.12.4 INSERT-shape test.
    let mut e = eng();
    ok(
        &mut e,
        "CREATE TABLE messages (id INT NOT NULL, subject TEXT NOT NULL, search_vector tsvector)",
    );
    ok(
        &mut e,
        "CREATE INDEX msg_sv_gin ON messages USING gin (search_vector)",
    );
    ok(
        &mut e,
        "CREATE FUNCTION update_sv() RETURNS TRIGGER LANGUAGE plpgsql AS $$
BEGIN
  NEW.search_vector := to_tsvector('simple', NEW.subject);
  RETURN NEW;
END;
$$",
    );
    // Fires on both INSERT and UPDATE — covers the full mailrs
    // lifecycle, not just the v7.12.4 INSERT branch.
    ok(
        &mut e,
        "CREATE TRIGGER messages_sv BEFORE INSERT OR UPDATE ON messages FOR EACH ROW EXECUTE FUNCTION update_sv()",
    );
    ok(
        &mut e,
        "INSERT INTO messages VALUES (1, 'the quick brown fox', NULL)",
    );
    let rs = rows(
        &mut e,
        "SELECT id FROM messages WHERE search_vector @@ to_tsquery('simple', 'fox')",
    );
    assert_eq!(rs.len(), 1, "initial INSERT path: fox matches");
    // Subject change → trigger re-runs to_tsvector against the
    // new subject → GIN index re-indexes via rebuild_indices.
    ok(
        &mut e,
        "UPDATE messages SET subject = 'lazy cats sleep' WHERE id = 1",
    );
    let rs_fox = rows(
        &mut e,
        "SELECT id FROM messages WHERE search_vector @@ to_tsquery('simple', 'fox')",
    );
    assert!(
        rs_fox.is_empty(),
        "post-UPDATE: fox should NOT match — subject changed and trigger should have rewritten search_vector"
    );
    let rs_cats = rows(
        &mut e,
        "SELECT id FROM messages WHERE search_vector @@ to_tsquery('simple', 'cats')",
    );
    assert_eq!(
        rs_cats.len(),
        1,
        "post-UPDATE: cats should match the new subject's lexemes"
    );
}