speech-prep 0.1.4

Speech-focused audio preprocessing — VAD, WAV decoding, format detection, noise reduction, chunking
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
use std::time::Duration;

use super::*;
use crate::time::{AudioDuration, AudioTimestamp};

const EPSILON: f32 = 1e-6;

#[test]
fn test_chunker_config_default() {
    let config = ChunkerConfig::default();
    assert_eq!(config.target_duration, Duration::from_millis(500));
    assert_eq!(config.max_duration, Duration::from_millis(600));
}

#[test]
fn test_chunker_config_validation() {
    // Zero target duration should fail
    let result = ChunkerConfig::new(
        Duration::from_millis(0),
        Duration::from_millis(600),
        Duration::from_millis(100),
        Duration::from_millis(100),
        Duration::from_millis(50),
    );
    assert!(result.is_err());

    // max_duration < target_duration should fail
    let result = ChunkerConfig::new(
        Duration::from_millis(500),
        Duration::from_millis(400),
        Duration::from_millis(100),
        Duration::from_millis(100),
        Duration::from_millis(50),
    );
    assert!(result.is_err());

    // overlap_duration < 20ms should fail
    let result = ChunkerConfig::new(
        Duration::from_millis(500),
        Duration::from_millis(600),
        Duration::from_millis(100),
        Duration::from_millis(100),
        Duration::from_millis(10),
    );
    assert!(result.is_err());

    // overlap_duration > 80ms should fail
    let result = ChunkerConfig::new(
        Duration::from_millis(500),
        Duration::from_millis(600),
        Duration::from_millis(100),
        Duration::from_millis(100),
        Duration::from_millis(100),
    );
    assert!(result.is_err());

    // Valid configuration should succeed
    let result = ChunkerConfig::new(
        Duration::from_millis(500),
        Duration::from_millis(600),
        Duration::from_millis(100),
        Duration::from_millis(100),
        Duration::from_millis(50),
    );
    assert!(result.is_ok());
}

#[test]
fn test_empty_audio_returns_error() {
    let chunker = Chunker::default();
    let result = chunker.chunk(&[], 16000, &[]);
    assert!(result.is_err());
}

#[test]
fn test_zero_sample_rate_returns_error() {
    let chunker = Chunker::default();
    let audio = vec![0.0; 1000];
    let result = chunker.chunk(&audio, 0, &[]);
    assert!(result.is_err());
}

#[test]
fn test_silence_chunk_creation() {
    let chunker = Chunker::default();
    let audio = vec![0.0; 16000]; // 1 second of silence @ 16kHz

    let chunks = chunker.chunk(&audio, 16000, &[]).expect("chunking failed");

    assert_eq!(chunks.len(), 1);
    assert_eq!(chunks[0].start_boundary, ChunkBoundary::Silence);
    assert_eq!(chunks[0].end_boundary, ChunkBoundary::Silence);
    assert!(
        (chunks[0].speech_ratio - 0.0).abs() < EPSILON,
        "silence speech_ratio"
    );
    assert!(chunks[0].energy < EPSILON);
}

#[test]
fn test_single_short_speech_segment() {
    let chunker = Chunker::default();
    let audio = vec![0.5; 8000]; // 500ms of audio @ 16kHz

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(500)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 25,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking failed");

    assert_eq!(chunks.len(), 1);
    assert_eq!(chunks[0].start_boundary, ChunkBoundary::SpeechStart);
    assert_eq!(chunks[0].end_boundary, ChunkBoundary::SpeechEnd);
    assert!(
        (chunks[0].speech_ratio - 1.0).abs() < EPSILON,
        "speech ratio for single segment"
    );
    assert!(chunks[0].energy > 0.0);
}

#[test]
fn test_long_speech_segment_splits_into_chunks() {
    let chunker = Chunker::default();
    let audio = vec![0.5; 16000]; // 1 second @ 16kHz

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_secs(1)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 50,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking failed");

    assert_eq!(chunks.len(), 2); // 1s split into 2x 500ms chunks
    assert_eq!(chunks[0].start_boundary, ChunkBoundary::SpeechStart);
    assert_eq!(chunks[0].end_boundary, ChunkBoundary::Continuation);
    assert_eq!(chunks[1].start_boundary, ChunkBoundary::Continuation);
    assert_eq!(chunks[1].end_boundary, ChunkBoundary::SpeechEnd);
}

#[test]
fn test_long_speech_segment_merges_small_tail() {
    let chunker = Chunker::default();
    let audio = vec![0.5; 16800]; // 1.05 seconds @ 16kHz

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1050)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 52,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking failed");

    assert_eq!(
        chunks.len(),
        2,
        "Trailing fragment should merge into previous chunk"
    );
    for (i, chunk) in chunks.iter().enumerate() {
        let duration_ms = chunk.duration().unwrap_or_default().as_millis() as u64;
        assert!(
            duration_ms >= 100,
            "Chunk {} duration {}ms should respect min_duration",
            i,
            duration_ms
        );
    }
}

#[test]
fn test_chunk_duration_respects_tolerance_upper_bound() {
    let config = ChunkerConfig::new(
        Duration::from_millis(500),
        Duration::from_millis(600),
        Duration::from_millis(10),
        Duration::from_millis(100),
        Duration::from_millis(50),
    )
    .expect("config should be valid");
    let chunker = Chunker::new(config);
    let sample_rate = 16000;
    let audio = vec![0.5; (sample_rate as usize * 6) / 10]; // 600ms @ 16kHz

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(600)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 60,
    }];

    let chunks = chunker
        .chunk(&audio, sample_rate, &vad_segments)
        .expect("chunking failed");
    assert_eq!(
        chunks.len(),
        2,
        "Should split 600ms segment when tolerance is ±10ms"
    );

    let max_duration_ms = (config.target_duration + config.duration_tolerance).as_millis() as u64;

    for (i, chunk) in chunks.iter().enumerate() {
        let duration_ms = chunk.duration().unwrap_or_default().as_millis() as u64;
        assert!(
            duration_ms <= max_duration_ms,
            "Chunk {} duration {}ms exceeds tolerance cap {}ms",
            i,
            duration_ms,
            max_duration_ms
        );
    }
}

#[test]
fn test_speech_with_silence_gaps() {
    let chunker = Chunker::default();
    let audio = vec![0.5; 24000]; // 1.5 seconds @ 16kHz

    // Two 400ms speech segments with 700ms gap
    let vad_segments = vec![
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH,
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(400)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1100)),
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1500)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
    ];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking failed");

    assert_eq!(chunks.len(), 3); // speech + silence + speech
    assert_eq!(chunks[0].start_boundary, ChunkBoundary::SpeechStart);
    assert_eq!(chunks[1].start_boundary, ChunkBoundary::Silence);
    assert_eq!(chunks[2].start_boundary, ChunkBoundary::SpeechStart);
}

#[test]
fn test_overlap_metadata_matches_actual_samples() {
    let config = ChunkerConfig::new(
        Duration::from_millis(20),
        Duration::from_millis(30),
        Duration::from_millis(10),
        Duration::from_millis(10),
        Duration::from_millis(40),
    )
    .expect("config");
    let chunker = Chunker::new(config);
    let sample_rate = 16000;
    let audio = vec![0.5; (sample_rate / 50) as usize * 2]; // 40ms total @ 16kHz

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(40)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 4,
    }];

    let chunks = chunker
        .chunk(&audio, sample_rate, &vad_segments)
        .expect("chunking failed");
    assert_eq!(chunks.len(), 2, "Should produce two short chunks");

    let first_overlap = chunks[0]
        .overlap_next
        .as_ref()
        .expect("first chunk should expose overlap");
    assert_eq!(
        first_overlap.len(),
        320,
        "First chunk overlap should match chunk length"
    );
    assert_eq!(
        chunks[0].overlap_ms, 20,
        "Overlap metadata should reflect actual samples"
    );

    let second_overlap = chunks[1]
        .overlap_prev
        .as_ref()
        .expect("second chunk should receive overlap");
    assert_eq!(
        second_overlap.len(),
        320,
        "Second chunk overlap should match chunk length"
    );
    assert_eq!(
        chunks[1].overlap_ms, 20,
        "Overlap metadata should reflect actual samples"
    );
}

#[test]
fn test_chunk_duration_calculation() {
    let chunk = ProcessedChunk {
        samples: vec![0.0; 8000],
        start_boundary: ChunkBoundary::SpeechStart,
        end_boundary: ChunkBoundary::SpeechEnd,
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(500)),
        speech_ratio: 1.0,
        energy: 0.5,
        snr_db: None,
        has_clipping: false,
        overlap_prev: None,
        overlap_next: None,
        overlap_ms: 0,
    };

    let duration = chunk.duration().unwrap_or_default();
    assert_eq!(duration, Duration::from_millis(500));
}

#[test]
fn test_is_speech_threshold() {
    let mut chunk = ProcessedChunk {
        samples: vec![],
        start_boundary: ChunkBoundary::SpeechStart,
        end_boundary: ChunkBoundary::SpeechEnd,
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(500)),
        speech_ratio: 0.6,
        energy: 0.5,
        snr_db: None,
        has_clipping: false,
        overlap_prev: None,
        overlap_next: None,
        overlap_ms: 0,
    };

    assert!(chunk.is_speech());

    chunk.speech_ratio = 0.4;
    assert!(!chunk.is_speech());
}

#[test]
fn test_rms_energy_computation() {
    // Silence should have near-zero energy
    let silence = vec![0.0; 1000];
    let energy = Chunker::compute_rms_energy(&silence);
    assert!(energy < EPSILON);

    // Constant signal should have known RMS
    let signal = vec![0.5; 1000];
    let energy = Chunker::compute_rms_energy(&signal);
    assert!((energy - 0.5).abs() < EPSILON);
}

#[test]
fn test_overlap_generation_two_chunks() {
    let chunker = Chunker::default(); // 50ms overlap
    let audio = vec![0.5f32; 16000]; // 1s @ 16kHz
    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_secs(1)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 50,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Should produce 2 chunks (500ms each from 1s audio)
    assert_eq!(chunks.len(), 2);

    // First chunk: no overlap_prev, has overlap_next
    assert!(chunks[0].overlap_prev.is_none());
    assert!(chunks[0].overlap_next.is_some());
    let overlap_next = chunks[0]
        .overlap_next
        .as_ref()
        .expect("overlap_next should exist");
    // 50ms @ 16kHz = 800 samples
    assert_eq!(overlap_next.len(), 800);
    assert_eq!(chunks[0].overlap_ms, 50);

    // Second chunk: has overlap_prev, no overlap_next (last chunk)
    assert!(chunks[1].overlap_prev.is_some());
    assert!(chunks[1].overlap_next.is_none());
    let overlap_prev = chunks[1]
        .overlap_prev
        .as_ref()
        .expect("overlap_prev should exist");
    assert_eq!(overlap_prev.len(), 800);
    assert_eq!(chunks[1].overlap_ms, 50);

    // Verify overlap_prev of chunk[1] matches overlap_next of chunk[0]
    assert_eq!(overlap_prev, overlap_next);
}

#[test]
fn test_overlap_generation_single_chunk() {
    let chunker = Chunker::default();
    let audio = vec![0.5f32; 8000]; // 500ms @ 16kHz (single chunk)
    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(500)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 25,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Single chunk has no overlaps
    assert_eq!(chunks.len(), 1);
    assert!(chunks[0].overlap_prev.is_none());
    assert!(chunks[0].overlap_next.is_none());
    assert_eq!(chunks[0].overlap_ms, 0); // No overlap data recorded
}

#[test]
fn test_overlap_streaming_config() {
    let chunker = Chunker::new(ChunkerConfig::streaming()); // 250ms chunks, 50ms overlap
    let audio = vec![0.5f32; 16000]; // 1s @ 16kHz
    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_secs(1)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 50,
    }];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Streaming config should produce ~4 chunks (250ms each from 1s)
    assert!(chunks.len() >= 3);

    // All chunks should have overlap metadata
    for chunk in &chunks {
        assert_eq!(chunk.overlap_ms, 50);
    }

    // Intermediate chunks should have both overlaps
    if chunks.len() > 2 {
        for chunk in chunks.iter().take(chunks.len() - 1).skip(1) {
            assert!(chunk.overlap_prev.is_some());
            assert!(chunk.overlap_next.is_some());
        }
    }
}

#[test]
fn test_overlap_with_silence_gaps() {
    let chunker = Chunker::default();
    let audio = vec![0.5f32; 24000]; // 1.5s @ 16kHz
    let vad_segments = vec![
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH,
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(400)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1100)),
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1500)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
    ];

    let chunks = chunker
        .chunk(&audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Should have 3 chunks: speech1 + silence + speech2
    assert_eq!(chunks.len(), 3);

    // speech1 → silence: overlap exists
    assert!(chunks[0].overlap_next.is_some());
    assert!(chunks[1].overlap_prev.is_some());

    // silence → speech2: overlap exists
    assert!(chunks[1].overlap_next.is_some());
    assert!(chunks[2].overlap_prev.is_some());
}

#[test]
fn test_dedupe_utilities() {
    let chunk = ProcessedChunk {
        samples: vec![1.0, 2.0, 3.0, 4.0, 5.0],
        start_boundary: ChunkBoundary::SpeechStart,
        end_boundary: ChunkBoundary::Continuation,
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(300)),
        speech_ratio: 1.0,
        energy: 0.5,
        snr_db: None,
        has_clipping: false,
        overlap_prev: Some(vec![0.5]),
        overlap_next: Some(vec![5.0]),
        overlap_ms: 10,
    };

    // samples_without_overlap returns core samples
    assert_eq!(chunk.samples_without_overlap(), &[1.0, 2.0, 3.0, 4.0, 5.0]);

    // total_samples_with_overlap calculates total including overlaps
    let total = chunk.total_samples_with_overlap();
    // Core: 5 samples, overlaps contain 1 sample each (explicit vectors)
    assert_eq!(total, 7);
}

#[test]
fn test_reconstruction_from_deduplicated_chunks() {
    // Test that concatenating deduplicated chunks reproduces original audio
    let chunker = Chunker::default();

    // Create distinctive test audio pattern (sine-like pattern for easy
    // verification)
    let mut original_audio = Vec::new();
    for i in 0..16000 {
        // 1s @ 16kHz
        let t = i as f32 / 16000.0;
        original_audio.push((t * 10.0).sin() * 0.5); // Distinctive pattern
    }

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH,
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_secs(1)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 50,
    }];

    let chunks = chunker
        .chunk(&original_audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Reconstruct audio by concatenating deduplicated chunks
    let mut reconstructed = Vec::new();
    for chunk in &chunks {
        let core_samples = chunk.samples_without_overlap();
        reconstructed.extend_from_slice(core_samples);
    }

    // Verify reconstruction matches original
    assert_eq!(
        reconstructed.len(),
        original_audio.len(),
        "Reconstructed length should match original"
    );

    // Verify sample-by-sample equality (within floating point precision)
    for (i, (&original, &reconstructed)) in
        original_audio.iter().zip(reconstructed.iter()).enumerate()
    {
        assert!(
            (original - reconstructed).abs() < EPSILON,
            "Sample {} differs: original={}, reconstructed={}",
            i,
            original,
            reconstructed
        );
    }
}

#[test]
fn test_reconstruction_with_silence_gaps() {
    // Test reconstruction with speech + silence + speech pattern
    let chunker = Chunker::default();

    // Create test audio: 400ms speech + 700ms silence + 400ms speech = 1.5s
    let mut original_audio = Vec::new();

    // Speech 1: 400ms (6400 samples)
    for i in 0..6400 {
        let t = i as f32 / 16000.0;
        original_audio.push((t * 20.0).sin() * 0.5);
    }

    // Silence: 700ms (11200 samples)
    for _ in 0..11200 {
        original_audio.push(0.0);
    }

    // Speech 2: 400ms (6400 samples)
    for i in 0..6400 {
        let t = (i + 6400) as f32 / 16000.0;
        original_audio.push((t * 20.0).cos() * 0.5);
    }

    let vad_segments = vec![
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH,
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(400)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
        SpeechChunk {
            start_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1100)),
            end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1500)),
            confidence: 0.9,
            avg_energy: 0.5,
            frame_count: 20,
        },
    ];

    let chunks = chunker
        .chunk(&original_audio, 16000, &vad_segments)
        .expect("chunking should succeed");

    // Reconstruct
    let mut reconstructed = Vec::new();
    for chunk in &chunks {
        reconstructed.extend_from_slice(chunk.samples_without_overlap());
    }

    // Verify
    assert_eq!(reconstructed.len(), original_audio.len());
    for (i, (&orig, &recon)) in original_audio.iter().zip(reconstructed.iter()).enumerate() {
        assert!(
            (orig - recon).abs() < EPSILON,
            "Sample {} mismatch at {:.3}s: orig={:.6}, recon={:.6}",
            i,
            i as f32 / 16000.0,
            orig,
            recon
        );
    }
}

#[test]
fn test_quality_metrics_in_speech_chunks() {
    // Integration test: Verify quality metrics are present in speech chunks
    let chunker = Chunker::default();

    // Audio with known characteristics:
    // - Leading silence (noise baseline)
    // - Speech with moderate amplitude (good SNR)
    // - No clipping
    let sample_rate = 16000;
    let mut audio = Vec::new();

    // Leading silence: 200ms (3200 samples) with noise
    for _ in 0..3200 {
        audio.push(0.01); // Noise floor
    }

    // Speech: 800ms (12800 samples) with higher amplitude
    for i in 0..12800 {
        let t = i as f32 / sample_rate as f32;
        audio.push((t * 10.0).sin() * 0.5); // No clipping
    }

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(200)),
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1000)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 40,
    }];

    let chunks = chunker
        .chunk(&audio, sample_rate, &vad_segments)
        .expect("chunking should succeed");

    // Verify all speech chunks have quality metrics
    let speech_chunks: Vec<_> = chunks.iter().filter(|c| c.is_speech()).collect();

    assert!(
        !speech_chunks.is_empty(),
        "Should have at least one speech chunk"
    );

    for (i, chunk) in speech_chunks.iter().enumerate() {
        // Verify energy is positive
        assert!(
            chunk.energy > 0.0,
            "Chunk {} should have positive energy, got {:.6}",
            i,
            chunk.energy
        );

        // Verify SNR is present (we have silence for noise baseline)
        assert!(
            chunk.snr_db.is_some(),
            "Chunk {} should have SNR (silence regions available)",
            i
        );

        let snr = chunk.snr_db.expect("SNR should be Some");
        assert!(
            snr > 0.0,
            "Chunk {} should have positive SNR, got {:.2} dB",
            i,
            snr
        );

        // Verify no clipping
        assert!(
            !chunk.has_clipping,
            "Chunk {} should not have clipping (max amplitude 0.5)",
            i
        );
    }
}

#[test]
fn test_quality_metrics_with_clipped_audio() {
    // Integration test: Verify clipping detection works in real chunks
    let chunker = Chunker::default();

    // Audio with clipping
    let sample_rate = 16000;
    let mut audio = Vec::new();

    // Leading silence: 200ms (3200 samples)
    for _ in 0..3200 {
        audio.push(0.01);
    }

    // Speech with clipping: 800ms (12800 samples)
    for i in 0..12800 {
        let t = i as f32 / sample_rate as f32;
        let sample = (t * 10.0).sin() * 1.5; // Intentionally exceed [-1.0, 1.0]
        audio.push(sample.clamp(-1.0, 1.0)); // Clamp to simulate clipping
    }

    let vad_segments = vec![SpeechChunk {
        start_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(200)),
        end_time: AudioTimestamp::EPOCH.add_duration(AudioDuration::from_millis(1000)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 40,
    }];

    let chunks = chunker
        .chunk(&audio, sample_rate, &vad_segments)
        .expect("chunking should succeed");

    // Verify at least one speech chunk detected clipping
    let speech_chunks: Vec<_> = chunks.iter().filter(|c| c.is_speech()).collect();

    let clipped_chunks: Vec<_> = speech_chunks.iter().filter(|c| c.has_clipping).collect();

    assert!(
        !clipped_chunks.is_empty(),
        "Should detect clipping in at least one chunk (>99% accuracy requirement)"
    );
}

#[test]
fn test_wall_clock_timestamps() {
    // P0 Bug Fix: Verify chunker works with wall-clock timestamps (production
    // streaming) Previously, the chunker assumed EPOCH-based timestamps,
    // causing sample index calculations to produce values far beyond audio
    // buffer bounds
    let chunker = Chunker::default();

    // Simulate real streaming: VAD starts at current wall-clock time
    let stream_start = AudioTimestamp::ZERO;

    // Audio: 1 second @ 16kHz
    let sample_rate = 16000;
    let mut audio = Vec::new();

    // Silence: 200ms (3200 samples)
    for _ in 0..3200 {
        audio.push(0.001);
    }

    // Speech: 600ms (9600 samples)
    for i in 0..9600 {
        let t = i as f32 / sample_rate as f32;
        audio.push((t * 10.0).sin() * 0.5);
    }

    // Silence: 200ms (3200 samples)
    for _ in 0..3200 {
        audio.push(0.001);
    }

    // VAD segments with wall-clock timestamps (absolute times)
    let vad_segments = vec![SpeechChunk {
        start_time: stream_start.add_duration(AudioDuration::from_millis(200)),
        end_time: stream_start.add_duration(AudioDuration::from_millis(800)),
        confidence: 0.9,
        avg_energy: 0.5,
        frame_count: 30,
    }];

    // This should work without error (previously would fail with InvalidInput)
    let chunks = chunker
        .chunk_with_stream_start(&audio, sample_rate, &vad_segments, stream_start)
        .expect("chunker should handle wall-clock timestamps");

    // Verify chunks were created correctly
    assert!(
        !chunks.is_empty(),
        "Should produce chunks with wall-clock timestamps"
    );

    // Verify we produce the expected speech chunk (~600ms duration)
    let speech_chunk = chunks
        .iter()
        .find(|chunk| chunk.is_speech())
        .expect("Expected speech chunk with wall-clock timestamps");
    let speech_duration = speech_chunk.duration().expect("speech duration");
    assert!(
        (550..=650).contains(&speech_duration.as_millis()),
        "Speech chunk duration {}ms outside expected range",
        speech_duration.as_millis()
    );

    // Verify chunk timestamps reflect wall-clock origin
    assert!(
        speech_chunk.start_time >= stream_start,
        "Chunk timestamps should be wall-clock based"
    );

    // Verify samples were extracted correctly from audio buffer
    let total_samples: usize = chunks.iter().map(|c| c.samples.len()).sum();
    assert_eq!(
        total_samples,
        audio.len(),
        "Total samples across chunks should match audio buffer"
    );
}