speccoder_runtime/

inbox.rs

//! `speccoder inbox`: what waits for a person across the project's
//! features — blocked on them (oldest first), ready to review (riskiest
//! evidence first), working, idle. Read-only; every item carries the
//! actions that decide it.

use std::path::Path;

use speccoder_core::actions::{Action, Runnable};
use speccoder_core::{
    ApprovalsReport, CommandData, CommandResult, CommandStatus, InboxItem, InboxReport,
    StatusReport,
};

use crate::actions::action;

/// The kinds, most urgent first: what blocks a run, what questions the
/// evidence, what stops a task, what blocks a hand-off — derived from the
/// one registry, `speccoder_core::inbox::Kind`.
pub const KINDS: [&str; Kind::ALL.len()] = {
    let mut out = [""; Kind::ALL.len()];
    let mut i = 0;
    while i < out.len() {
        out[i] = Kind::ALL[i].as_str();
        i += 1;
    }
    out
};

use speccoder_core::inbox::Kind;

/// `speccoder inbox [--feature]`: the decisions waiting in every feature of
/// the project at `path`, or in `feature` only.
#[must_use]
pub fn inbox(path: &Path, feature: Option<&str>) -> CommandResult {
    inbox_with(path, feature, crate::worktree::state_dir().as_deref())
}

/// [`inbox`] with an explicit state directory (where waiting calls and
/// held attempts are kept).
#[must_use]
pub fn inbox_with(path: &Path, feature: Option<&str>, state: Option<&Path>) -> CommandResult {
    let listed = crate::current::list(path, None);
    let Some(CommandData::Features(f)) = listed.data() else {
        return CommandResult::carried("inbox", &listed);
    };
    // `--feature` takes a name or a number, as everywhere: the one it selects.
    let only = match feature {
        Some(_) => match crate::current::list(path, feature).data() {
            Some(CommandData::Features(one)) => one.current.clone(),
            _ => None,
        },
        None => None,
    };
    if feature.is_some() && only.is_none() {
        return CommandResult::carried("inbox", &crate::status::report(path, feature));
    }
    let names: Vec<String> = f
        .features
        .iter()
        .map(|e| e.name.clone())
        .filter(|n| only.as_ref().is_none_or(|o| o == n))
        .collect();
    let several = names.len() > 1;
    let mut items = Vec::new();
    for name in &names {
        items.extend(of_feature(path, name, state, several));
    }
    // Bugs of the format's own bug structure: no feature lists them.
    if only.is_none()
        && let Some(s) = state
        && let Some(project) = crate::format::at(path).detect(path)
    {
        let plane = crate::worktree::project_state_dir(s, &project);
        items.extend(
            crate::bug::state::all(&plane)
                .iter()
                .filter(|b| b.home.kind.native())
                // A bug the person dropped waits for nobody.
                .filter(|b| !crate::controls::skipped(&project, &b.unit).contains_key(&b.task))
                .filter_map(|b| bug_item(b, &|c| c)),
        );
    }
    sort(&mut items);
    let working = working(path, state);
    let idle: Vec<String> = names
        .iter()
        .filter(|n| !items.iter().any(|i| &i.feature == *n))
        .filter(|n| !working.iter().any(|w| &w.feature == *n))
        .cloned()
        .collect();
    let groups = speccoder_core::inbox::Group::ALL
        .iter()
        .map(|g| speccoder_core::GroupCount {
            group: g.as_str().to_owned(),
            title: g.title().to_owned(),
            count: match g {
                speccoder_core::inbox::Group::Working => working.len(),
                speccoder_core::inbox::Group::Idle => idle.len(),
                _ => items.iter().filter(|i| i.group == g.as_str()).count(),
            },
        })
        .collect();
    let message = summary(&items, names.len());
    CommandResult::new("inbox", CommandStatus::Ok, &message).with_data(CommandData::Inbox(
        Box::new(InboxReport {
            items,
            features: names.len(),
            groups,
            working,
            idle,
        }),
    ))
}

/// Needs You's order: *Blocked on you* first — a journal that could not be
/// read, then the oldest, then the kind's urgency — then *Ready to review*,
/// the riskiest first.
fn sort(items: &mut [InboxItem]) {
    let rank = |k: &str| KINDS.iter().position(|x| *x == k).unwrap_or(KINDS.len());
    let blocked = |i: &InboxItem| i.group != "ready_to_review";
    items.sort_by(|a, b| {
        let by_group = blocked(b).cmp(&blocked(a));
        let within = if blocked(a) {
            (a.kind != "unknown")
                .cmp(&(b.kind != "unknown"))
                .then(
                    a.since
                        .unwrap_or(u64::MAX)
                        .cmp(&b.since.unwrap_or(u64::MAX)),
                )
                .then(rank(&a.kind).cmp(&rank(&b.kind)))
        } else {
            review_rank(a)
                .cmp(&review_rank(b))
                .then(rank(&a.kind).cmp(&rank(&b.kind)))
                .then(
                    a.since
                        .unwrap_or(u64::MAX)
                        .cmp(&b.since.unwrap_or(u64::MAX)),
                )
        };
        by_group
            .then(within)
            .then(a.feature.cmp(&b.feature))
            .then(a.task.cmp(&b.task))
    });
}

/// The project's run in progress, or one whose process is gone before it
/// finished (its state unknown, never idle).
fn working(path: &Path, state: Option<&Path>) -> Vec<speccoder_core::WorkingRun> {
    let Some((live, running)) = state.and_then(|s| crate::progress::read_live(path, s)) else {
        return Vec::new();
    };
    if live.finished.is_some() {
        return Vec::new();
    }
    vec![speccoder_core::WorkingRun {
        feature: live.feature,
        task: (!live.task.is_empty()).then_some(live.task),
        started: live.started_at,
        pid: live.pid,
        state: if running { "running" } else { "unknown" }.to_owned(),
    }]
}

/// `n` with the word for one or for many: `1 tick`, `2 ticks`.
fn count(n: usize, one: &str, many: &str) -> String {
    format!("{n} {}", if n == 1 { one } else { many })
}

/// A kind counted in words: `2 approvals`, `1 open question`.
fn counted(kind: &str, n: usize) -> String {
    let (one, many) = match kind {
        "unknown" => (
            "feature whose waiting calls could not be read",
            "features whose waiting calls could not be read",
        ),
        "approval" => ("approval", "approvals"),
        "approval_batch" => (
            "run whose calls wait together",
            "runs whose calls wait together",
        ),
        "ruling" => ("ruling", "rulings"),
        "gaming" => ("suspected shortcut", "suspected shortcuts"),
        "unverified" => (
            "feature little was verified in",
            "features little was verified in",
        ),
        "stale" => (
            "tick the spec changed under",
            "ticks the spec changed under",
        ),
        "question" => ("open question", "open questions"),
        "ambiguous" => ("scenario read two ways", "scenarios read two ways"),
        "autopilot_denied" => ("call autopilot refused", "calls autopilot refused"),
        "review" => ("spec to review", "specs to review"),
        "revise" => ("change request", "change requests"),
        "stuck" => ("task that did not pass", "tasks that did not pass"),
        "yours" => ("step only you can take", "steps only you can take"),
        "aside" => ("set-aside change", "set-aside changes"),
        "commit" => ("plan to commit", "plans to commit"),
        "handoff" => ("branch to hand off", "branches to hand off"),
        "bug_confirm" => (
            "bug reproduction to confirm",
            "bug reproductions to confirm",
        ),
        "bug_cannot_reproduce" => (
            "bug that could not be reproduced",
            "bugs that could not be reproduced",
        ),
        "bug_unchanged_not_holding" => (
            "bug whose Unchanged statement does not hold",
            "bugs whose Unchanged statements do not hold",
        ),
        "bug_repro_weak" => ("bug reproduction too weak", "bug reproductions too weak"),
        "bug_already_satisfied" => ("bug already fixed", "bugs already fixed"),
        k => (k, k),
    };
    count(n, one, many)
}

/// `3 decisions waiting in 2 features: 1 approval, 2 tasks that did not pass`.
fn summary(items: &[InboxItem], features: usize) -> String {
    if items.is_empty() {
        return format!(
            "nothing waits for you in {}: the agents can work",
            count(features, "feature", "features")
        );
    }
    let mut in_features: Vec<&str> = items.iter().map(|i| i.feature.as_str()).collect();
    in_features.sort_unstable();
    in_features.dedup();
    let parts: Vec<String> = KINDS
        .iter()
        .filter_map(|k| {
            let n = items.iter().filter(|i| i.kind == *k).count();
            (n > 0).then(|| counted(k, n))
        })
        .collect();
    format!(
        "{} waiting in {}: {}",
        count(items.len(), "decision", "decisions"),
        count(in_features.len(), "feature", "features"),
        parts.join(", ")
    )
}

/// One feature's items. `several`: commands name the feature.
fn of_feature(path: &Path, feature: &str, state: Option<&Path>, several: bool) -> Vec<InboxItem> {
    let report = crate::status::report(path, Some(feature));
    let Some(CommandData::Report(r)) = report.data() else {
        return Vec::new();
    };
    let approvals: Option<ApprovalsReport> =
        state.and_then(
            |s| match crate::approvals::list_with(path, Some(feature), s).data() {
                Some(CommandData::Approvals(a)) => Some((**a).clone()),
                _ => None,
            },
        );
    let flag = |command: String| {
        if several {
            format!("{command} --feature {feature}")
        } else {
            command
        }
    };
    let item = |kind: &str, task: Option<&str>, title: String, detail: String, actions| InboxItem {
        kind: kind.to_owned(),
        group: Kind::named(kind)
            .map_or("blocked_on_you", |k| k.group().as_str())
            .to_owned(),
        feature: feature.to_owned(),
        task: task.map(str::to_owned),
        title,
        detail,
        since: None,
        actions,
        unverified: None,
        risk: Vec::new(),
        tool: None,
    };
    let mut out = Vec::new();
    let waiting: Vec<&str> = approvals
        .iter()
        .flat_map(|a| &a.pending)
        .map(|p| p.task.as_str())
        .collect();

    // The journal could not be read: what waits there is unknown, and the
    // person is told so rather than shown an empty list.
    if let Some(why) = approvals.as_ref().and_then(|a| a.unreadable.as_ref()) {
        out.push(item(
            "unknown",
            None,
            format!("Calls waiting in {feature} could not be read"),
            format!("{why} — some may be waiting for you"),
            Vec::new(),
        ));
    }

    // A run that used its asking budget: its waiting calls are one item,
    // decided together.
    let batched_runs: Vec<String> = approvals
        .iter()
        .flat_map(|a| &a.batch)
        .map(|b| b.run.clone())
        .collect();
    for b in approvals.iter().flat_map(|a| &a.batch) {
        let calls: Vec<String> = b.groups.iter().flat_map(|g| g.calls.clone()).collect();
        let of_run: Vec<&speccoder_core::PendingCall> = approvals
            .iter()
            .flat_map(|a| &a.pending)
            .filter(|p| p.run.as_deref() == Some(b.run.as_str()))
            .collect();
        let detail: Vec<String> = b
            .groups
            .iter()
            .map(|g| {
                let shown: Vec<String> = of_run
                    .iter()
                    .filter(|p| p.object.as_ref().map_or("write", |o| o.class.as_str()) == g.class)
                    .map(|p| {
                        let what = p
                            .object
                            .as_ref()
                            .map_or(p.covers.clone(), |o| o.short.clone());
                        let risk = p.presentation.as_ref().map_or("", |v| v.risk.as_str());
                        let copied = if p.sources.is_empty() {
                            ""
                        } else {
                            ", copied from content"
                        };
                        format!("{what} ({}, {risk}{copied})", p.task)
                    })
                    .collect();
                format!("{}: {}", g.class, shown.join("; "))
            })
            .collect();
        let decide = |verdict, resume_asking| Runnable::DecideBatch {
            run: b.run.clone(),
            verdict,
            calls: calls.clone(),
            digest: b.digest.clone(),
            resume_asking,
        };
        let command = |verb: &str| {
            flag(format!(
                "speccoder approvals batch {} {verb} --digest {}",
                b.run, b.digest
            ))
        };
        let yes = action(
            "next",
            format!("approve the {} waiting call(s) once", calls.len()),
            "each listed call runs once; the run keeps waiting at its next call",
            command("approve"),
        )
        .with_run(decide(
            speccoder_core::actions::BatchVerdict::Approve,
            false,
        ));
        let again = action(
            "next",
            "approve once and resume asking",
            "each listed call runs once, and the run prompts you again",
            format!("{} --resume-asking", command("approve")),
        )
        .with_run(decide(speccoder_core::actions::BatchVerdict::Approve, true));
        let mut no = action(
            "next",
            format!("reject the {} waiting call(s)", calls.len()),
            "the model is told your reason for each",
            format!("{} --reason \"…\"", command("reject")),
        )
        .with_run(decide(speccoder_core::actions::BatchVerdict::Reject, false));
        no.input = Some("Why (the model is told)".to_owned());
        let mut i = item(
            "approval_batch",
            None,
            format!(
                "{} call(s) wait for you in run {} (its approval budget is used)",
                calls.len(),
                b.run
            ),
            detail.join(" · "),
            vec![yes, again, no],
        );
        i.since = of_run.iter().filter_map(|p| p.waiting_since).min();
        out.push(i);
    }

    // A run waits on these.
    for p in approvals
        .iter()
        .flat_map(|a| &a.pending)
        .filter(|p| p.run.as_ref().is_none_or(|r| !batched_runs.contains(r)))
    {
        let question = p.kind == "question";
        let mut yes = action(
            "next",
            if question {
                format!("answer {}", p.task)
            } else {
                format!("approve {}", p.task)
            },
            if question {
                "the attempt resumes with your answer".to_owned()
            } else {
                format!("allow {} for the task", p.covers)
            },
            flag(format!("speccoder task approve {}", p.task)),
        );
        yes = yes.with_run(Runnable::Approve {
            task: p.task.clone(),
            call: p.id(),
            digest: p.digest.clone(),
        });
        if question {
            yes.input = Some("Your answer".to_owned());
        }
        let mut no = action(
            "next",
            format!("reject {}", p.task),
            "the model is told your reason",
            flag(format!("speccoder task reject {} --reason \"…\"", p.task)),
        );
        no = no.with_run(Runnable::Reject {
            task: p.task.clone(),
            call: p.id(),
            digest: p.digest.clone(),
        });
        no.input = Some("Why (the model is told)".to_owned());
        let mut i = item(
            "approval",
            Some(&p.task),
            if question {
                format!("{} asks you", p.task)
            } else {
                format!("{} waits for your approval", p.task)
            },
            p.question
                .clone()
                .filter(|_| question)
                .unwrap_or_else(|| format!("{} — {}", p.covers, p.reason)),
            vec![yes, no],
        );
        i.since = p.waiting_since;
        i.tool = (!question).then(|| p.tool.clone());
        out.push(i);
    }

    let root = Path::new(path);
    let project_state = state.and_then(|s| {
        crate::format::at(root)
            .detect(root)
            .map(|project| crate::worktree::project_state_dir(s, &project))
    });
    for t in &r.tasks {
        let done = matches!(
            t.state.as_str(),
            "verified" | "regression_only" | "attested" | "ticked_without_evidence" | "skipped"
        );
        if done || waiting.contains(&t.id.as_str()) {
            continue;
        }
        if let Some(i) = project_state
            .as_deref()
            .and_then(|s| crate::bug::state::load(s, feature, &t.id))
            .and_then(|b| bug_item(&b, &flag))
        {
            out.push(i);
            continue;
        }
        let held = project_state
            .as_deref()
            .and_then(|s| crate::strength::held(&crate::strength::dir(s, feature, &t.id)));
        if let Some(held) = held {
            let mut rule = action(
                "task",
                format!("rule on {}", t.id),
                "the tests are right: the flagged alternatives are not what the spec allows",
                flag(format!(
                    "speccoder task rule {} --tests-right --reason \"…\"",
                    t.id
                )),
            );
            rule = rule.with_run(Runnable::Rule { task: t.id.clone() });
            rule.input = Some("Why the tests are right".to_owned());
            let findings: Vec<String> = held
                .findings
                .iter()
                .map(|p| format!("{} ({})", p.scenario, p.rationale))
                .collect();
            out.push(item(
                "ruling",
                Some(&t.id),
                format!("{}'s tests reject an alternative the spec may allow", t.id),
                findings.join("; "),
                vec![rule, nudge(t, &flag), skip(t, &flag)],
            ));
            continue;
        }
        // A step only a person can take — a `[YOU]` task that is ready, or
        // an honest stop: the agent's reason as its claim, and three ways on.
        if t.lane == speccoder_core::lane::Lane::Yours
            && t.last_attempt
                .as_ref()
                .map_or(t.state == "ready", |a| a.outcome == "blocked")
        {
            let (title, detail) = match &t.last_attempt {
                Some(a) => (
                    format!("{} needs you: the agent stopped", t.id),
                    a.reason.clone(),
                ),
                // Marked `[YOU]`: no claim to show.
                None => (format!("{} is yours: {}", t.id, t.title), String::new()),
            };
            out.push(item(
                "yours",
                Some(&t.id),
                title,
                detail,
                yours_actions(
                    t,
                    &dependents(&r.tasks, &t.id),
                    retry_blocked(r, &waiting),
                    &flag,
                ),
            ));
            continue;
        }
        let Some(a) = &t.last_attempt else {
            continue;
        };
        if a.outcome == "suspected_gaming" {
            out.push(item(
                "gaming",
                Some(&t.id),
                format!("{}: the monitor suspects a shortcut", t.id),
                a.reason.clone(),
                vec![nudge(t, &flag), skip(t, &flag), accept(t, &flag)],
            ));
            continue;
        }
        let mut actions = Vec::new();
        if t.state == "ready" {
            let mut again = action(
                "work",
                format!("run {} again", t.id),
                "with what the last attempt left: its facts and your notes",
                flag(format!("speccoder run --task {}", t.id)),
            );
            again = again.with_run(Runnable::Run {
                task: Some(t.id.clone()),
                agent: None,
            });
            again.blocked = retry_blocked(r, &waiting);
            let other = try_with(&t.id, a, &flag, crate::acp::agent::on_path);
            actions.push(again);
            if let Some(mut other) = other {
                other.blocked = retry_blocked(r, &waiting);
                actions.push(other);
            }
        }
        actions.extend([nudge(t, &flag), skip(t, &flag), accept(t, &flag)]);
        out.push(item(
            "stuck",
            Some(&t.id),
            format!("{}'s last attempt: {}", t.id, a.outcome.replace('_', " ")),
            a.reason.clone(),
            actions,
        ));
    }

    // Changes a run found and set aside: kept on the branch, or let go.
    for t in &r.tasks {
        let Some(a) = &t.set_aside else { continue };
        let n = a.files.len();
        let mut keep = action(
            "task",
            format!("keep the changes set aside before {}", t.id),
            "committed onto the feature's branch as yours",
            flag(format!("speccoder task restore {}", t.id)),
        );
        keep = keep.with_run(Runnable::KeepSetAside { task: t.id.clone() });
        let mut drop = action(
            "task",
            format!("discard the changes set aside before {}", t.id),
            "deleted; the branch stays as it is",
            flag(format!("speccoder task drop {}", t.id)),
        );
        drop = drop.with_run(Runnable::DropSetAside { task: t.id.clone() });
        drop.confirm = Some(format!(
            "Discard the {n} changed file(s) set aside before {}? They are deleted, not kept anywhere.",
            t.id
        ));
        out.push(item(
            "aside",
            Some(&t.id),
            format!("Changes were set aside before {} ran", t.id),
            format!(
                "{n} file(s) were changed in the worktree when the run started — your edits, or an interrupted run's: {}",
                a.files.iter().take(4).cloned().collect::<Vec<_>>().join(", ")
                    + if n > 4 { ", …" } else { "" }
            ),
            vec![keep, drop],
        ));
    }

    let stale: Vec<String> = r
        .tasks
        .iter()
        .filter_map(|t| {
            let d = t.drift.as_ref().filter(|d| d.stale())?;
            let ids: Vec<&str> = d.requirements.iter().map(|q| q.id.as_str()).collect();
            Some(format!("{} ({})", t.id, ids.join(", ")))
        })
        .collect();
    if !stale.is_empty() {
        let mut a = action(
            "next",
            "re-check against the spec",
            "convergence assesses the code against the spec as it is now",
            flag("speccoder run --converge".to_owned()),
        );
        a = a.with_run(Runnable::Converge);
        out.push(item(
            "stale",
            None,
            format!(
                "the spec changed under {}",
                count(stale.len(), "tick", "ticks")
            ),
            format!("proven against an earlier wording: {}", stale.join(", ")),
            vec![a],
        ));
    }

    // Most ticks regression-only: one diagnosis, never stored, never a stop.
    if let Some(u) = unverified(r, path) {
        let dominant = u
            .counts
            .first()
            .map(|c| c.reason.clone())
            .unwrap_or_default();
        let mut actions = Vec::new();
        let checks = action(
            "next",
            "show the plan checks",
            "deterministic checks of the task list: where the plan leaves nothing to show",
            flag("speccoder doctor".to_owned()),
        );
        match dominant.as_str() {
            "no_scenarios" => {
                if let Some(skill) = crate::format::at(path).planning().revises {
                    let mut a = action(
                        "plan",
                        "add scenarios",
                        "the format's clarify skill asks for the examples a test is written from",
                        flag(format!("speccoder spec {skill}")),
                    );
                    a = a.with_run(Runnable::Skill {
                        name: skill.to_owned(),
                        arguments: String::new(),
                    });
                    actions.push(a);
                } else {
                    actions.push(checks.clone());
                }
            }
            // The plan put the behaviour early or outside a story: the
            // preset changes how future plans are written.
            "already_passing" | "no_story"
                if crate::format::at(path).kind() == speccoder_core::spec::FormatKind::Speckit
                    && crate::preset::state(path).installed.is_none() =>
            {
                let mut a = action(
                    "plan",
                    "add the speccoder preset",
                    "future task lists keep a story's behaviour inside its story; no spec file changes",
                    "speccoder preset add --yes".to_owned(),
                );
                a = a.with_run(Runnable::PresetAdd { update: false });
                // Refused anyway without Spec Kit: say why, never offer it bare.
                if !crate::preset::speckit_version().is_some_and(|v| v >= crate::preset::NEEDS) {
                    a.blocked =
                        Some("needs Spec Kit's `specify` 1.2.0 or newer on PATH".to_owned());
                }
                a.confirm = Some(
                    "Install the speccoder preset with the spec tool's own preset command? It writes the spec tool's preset directory and registry; no spec file changes.".to_owned(),
                );
                actions.push(a);
            }
            _ => actions.push(checks.clone()),
        }
        let mut converge = action(
            "next",
            "converge",
            "assess the code against the spec as it is now and append what remains",
            flag("speccoder converge".to_owned()),
        );
        converge = converge.with_run(Runnable::Converge);
        actions.push(converge);
        actions.push(action(
            "review",
            "open the report",
            "each task's evidence and why",
            flag("speccoder report".to_owned()),
        ));
        let mut it = item(
            "unverified",
            None,
            format!(
                "Little was verified in `{}`: {} of {} ticks are regression-only",
                r.feature, u.regression_only, u.ticks
            ),
            u.counts
                .iter()
                .map(|c| format!("{} · {}", c.text, c.tasks.join(" ")))
                .collect::<Vec<_>>()
                .join("; "),
            actions,
        );
        it.unverified = Some(u);
        out.push(it);
    }

    // What the last autopilot run refused instead of asking.
    let denied = project_state
        .as_deref()
        .map(|s| crate::oracle::last_denials(s, feature))
        .unwrap_or_default();
    if !denied.is_empty() {
        let read = action(
            "work",
            "see what autopilot refused",
            "each call was refused for that run; approve one when you run again, or allow it in Settings",
            flag("speccoder run --json".to_owned()),
        );
        out.push(item(
            "autopilot_denied",
            None,
            count(
                denied.len(),
                "call autopilot refused instead of asking",
                "calls autopilot refused instead of asking",
            ),
            denied
                .iter()
                .take(4)
                .map(|d| format!("{}: {}", d.task, d.object))
                .collect::<Vec<_>>()
                .join("; "),
            vec![read],
        ));
    }

    // The spec, reviewed requirement by requirement.
    if let Some(rv) = crate::review::summary(path, Some(feature)).as_ref() {
        let t = rv.totals;
        // The documents' open questions: answered before anything is built.
        if !rv.questions.is_empty() {
            let read = action(
                "plan",
                "answer the open questions",
                "your words replace each question where it stands",
                flag("speccoder review".to_owned()),
            );
            let mut actions = vec![read];
            if let Some(skill) = &rv.revise_with {
                let mut a = action(
                    "plan",
                    format!("clarify with {skill}"),
                    "the format's skill asks you the questions and writes the answers in",
                    flag(format!("speccoder spec {skill}")),
                );
                a = a
                    .with_run(Runnable::Skill {
                        name: skill.clone(),
                        arguments: String::new(),
                    })
                    .with_role(crate::format::at(path).planning().role_of(skill));
                actions.push(a);
            }
            out.push(item(
                "question",
                None,
                count(
                    rv.questions.len(),
                    "open question in the spec",
                    "open questions in the spec",
                ),
                rv.questions
                    .iter()
                    .take(3)
                    .map(|q| format!("{}: {}", q.id, q.text))
                    .collect::<Vec<_>>()
                    .join("; "),
                actions,
            ));
        }
        // Two test authors read a requirement two ways.
        let requirements = match crate::inspect(path, Some(feature)).data() {
            Some(CommandData::Inspect(snap)) => crate::format::of(snap).oracle_requirements(snap),
            _ => Vec::new(),
        };
        let ambiguous = match project_state
            .as_deref()
            .map(|s| crate::oracle::open_ambiguities(s, feature, &requirements))
        {
            Some(Ok(a)) => a,
            None => Vec::new(),
            // Unknown is never "nothing read two ways": a person looks.
            Some(Err(t)) => {
                out.push(item(
                    "ambiguous",
                    None,
                    "a test draft cannot be read".to_owned(),
                    format!("{} — Approve and Run waits until it is written again", t.0),
                    vec![action(
                        "review",
                        "see the tests",
                        "write the requirement's tests again",
                        flag("speccoder review".to_owned()),
                    )],
                ));
                Vec::new()
            }
        };
        if let Some((req, scenario)) = ambiguous.first() {
            let mut a = action(
                "review",
                "reading A is meant",
                "the first author's tests stay",
                flag(format!(
                    "speccoder review tests {req} --reading A {scenario}"
                )),
            );
            a = a.with_run(Runnable::OracleTests {
                req: req.clone(),
                op: speccoder_core::oracle::OracleOp::Reading,
                path: None,
                scenario: Some(scenario.clone()),
                reading: Some(speccoder_core::oracle::Reading::A),
            });
            let mut b = action(
                "review",
                "reading B is meant",
                "its tests are written again with that reading",
                flag(format!(
                    "speccoder review tests {req} --reading B {scenario}"
                )),
            );
            b = b.with_run(Runnable::OracleTests {
                req: req.clone(),
                op: speccoder_core::oracle::OracleOp::Reading,
                path: None,
                scenario: Some(scenario.clone()),
                reading: Some(speccoder_core::oracle::Reading::B),
            });
            out.push(item(
                "ambiguous",
                None,
                count(
                    ambiguous.len(),
                    "scenario read two ways",
                    "scenarios read two ways",
                ),
                ambiguous
                    .iter()
                    .map(|(r, s)| format!("{r}/{s}"))
                    .collect::<Vec<_>>()
                    .join(", ")
                    + " — Approve and Run waits until you choose a reading or reword",
                vec![a, b],
            ));
        }
        if t.open + t.lapsed > 0 {
            let pending: Vec<&str> = rv
                .requirements
                .iter()
                .filter(|i| i.state == "open" || i.state == "lapsed")
                .map(|i| i.id.as_str())
                .collect();
            let read = action(
                "plan",
                "read the requirements",
                "each one, as the result will be judged against it",
                flag("speccoder review".to_owned()),
            );
            let mut all = action(
                "plan",
                format!(
                    "approve {}",
                    count(pending.len(), "requirement", "requirements")
                ),
                "on their current wording, as you",
                flag("speccoder review approve".to_owned()),
            );
            all = all.with_run(Runnable::Review {
                ids: Vec::new(),
                verdict: "approve".to_owned(),
            });
            out.push(item(
                "review",
                None,
                if pending.len() == 1 {
                    "1 requirement waits for your review".to_owned()
                } else {
                    format!("{} requirements wait for your review", pending.len())
                },
                if t.lapsed > 0 {
                    format!(
                        "{}; {} changed since you decided",
                        pending.join(", "),
                        t.lapsed
                    )
                } else {
                    pending.join(", ")
                },
                vec![read, all],
            ));
        }
        if t.changes_requested > 0 {
            let asked: Vec<String> = rv
                .requirements
                .iter()
                .filter(|i| i.state == "changes_requested")
                .map(|i| format!("{}: {}", i.id, i.comment.as_deref().unwrap_or_default()))
                .collect();
            let mut actions = Vec::new();
            if let Some(skill) = &rv.revise_with {
                let mut a = action(
                    "plan",
                    format!("revise the spec ({skill})"),
                    "the format's skill rewrites what you asked; you review the result",
                    flag(format!("speccoder spec {skill} \"…\"")),
                );
                a = a
                    .with_run(Runnable::Skill {
                        name: skill.clone(),
                        arguments: rv.revision.clone().unwrap_or_default(),
                    })
                    .with_role(crate::format::at(path).planning().role_of(skill));
                actions.push(a);
            }
            actions.push(action(
                "plan",
                "edit the spec yourself",
                "then approve the new wording",
                flag("speccoder review".to_owned()),
            ));
            out.push(item(
                "revise",
                None,
                format!(
                    "{} on the spec",
                    count(t.changes_requested, "change request", "change requests")
                ),
                asked.join("; "),
                actions,
            ));
        }
    }

    if !r.uncommitted.is_empty() {
        let mut a = action(
            "next",
            format!("commit the planning files ({})", r.uncommitted.len()),
            "a run reads committed files only",
            format!(
                "git add {0} && git commit -m \"spec: …\" -- {0}",
                r.uncommitted.join(" ")
            ),
        );
        a = a.with_run(Runnable::Commit {
            paths: r.uncommitted.clone(),
        });
        out.push(item(
            "commit",
            None,
            "planning files not committed yet".to_owned(),
            format!("read them, then commit: {}", r.uncommitted.join(", ")),
            vec![a],
        ));
    }

    if handoff(r) && stale.is_empty() {
        let mut pr = action(
            "review",
            "open a draft pull request",
            "push the branch and its evidence; open (or update) the draft",
            flag("speccoder pr --yes".to_owned()),
        );
        pr = pr.with_run(Runnable::PullRequest);
        pr.confirm = Some(
            "Push the feature's speccoder branch and its attestation notes to `origin`, and open (or update) its draft pull request on GitHub, as you (your token).".to_owned(),
        );
        out.push(item(
            "handoff",
            None,
            format!("every task is done: review {} and hand it off", r.feature),
            format!(
                "{} on {} not merged",
                count(r.unmerged_commits, "commit", "commits"),
                r.branch.as_deref().unwrap_or_default()
            ),
            vec![pr],
        ));
    }
    if out.iter().any(|i| EVIDENCED.contains(&i.kind.as_str())) {
        let risk = risk_of(path, r);
        for i in out
            .iter_mut()
            .filter(|i| EVIDENCED.contains(&i.kind.as_str()))
        {
            i.risk.clone_from(&risk);
        }
    }
    out
}

/// The kinds about finished work, whose order follows its evidence.
const EVIDENCED: [&str; 3] = ["handoff", "unverified", "stale"];

/// What a feature's ticks leave to the person, the riskiest first: their
/// states, drift and strength from the report, and the tick commits'
/// `Scope-Outside:` and `Executor:` trailers (one `git show` for all).
fn risk_of(path: &Path, r: &speccoder_core::StatusReport) -> Vec<speccoder_core::RiskReason> {
    use speccoder_core::inbox::Risk;
    let target = crate::oracle::ViewConfig::at(path)
        .strength_target
        .map(|t| f64::from(t) / 100.0);
    let mut n = [0usize; Risk::ALL.len()];
    let mut bump = |risk: Risk| n[Risk::ALL.iter().position(|x| *x == risk).unwrap_or(0)] += 1;
    for t in &r.tasks {
        match t.state.as_str() {
            "regression_only" => bump(Risk::RegressionOnly),
            "attested" => bump(Risk::Attested),
            _ => {}
        }
        if t.drift.is_some() {
            bump(Risk::Stale);
        }
        let strength = t
            .strength
            .as_deref()
            .and_then(|s| s.split_whitespace().next())
            .and_then(|v| v.parse::<f64>().ok());
        if t.state == "verified"
            && let (Some(s), Some(min)) = (strength, target)
            && s < min
        {
            bump(Risk::StrengthBelowTarget);
        }
    }
    let commits: Vec<&str> = r.tasks.iter().filter_map(|t| t.commit.as_deref()).collect();
    if !commits.is_empty() {
        // One call; a commit that is gone (rebased, squashed, shallow) is
        // left out, never the reason the others are not read.
        let mut args = vec![
            "log",
            "--no-walk=unsorted",
            "--ignore-missing",
            "--format=%(trailers:key=Scope-Outside,key=Executor,separator=%x01)%x1e",
        ];
        args.extend(commits.iter().copied());
        if let Ok(out) = crate::git::Git::at(path).run(&args) {
            for block in String::from_utf8_lossy(&out).split('\u{1e}') {
                if block.contains("Scope-Outside:") {
                    bump(Risk::ScopeOutside);
                }
                if block.contains("Executor:") {
                    bump(Risk::ExternalExecutor);
                }
            }
        }
    }
    Risk::ALL
        .iter()
        .zip(n)
        .filter(|(_, count)| *count > 0)
        .map(|(risk, count)| speccoder_core::RiskReason {
            reason: risk.as_str().to_owned(),
            count,
            text: risk.chip(count),
        })
        .collect()
}

/// An item's place in *Ready to review*: its riskiest reason; then work
/// with no evidence to weigh (a spec to review, set-aside changes); strong
/// verified work last.
fn review_rank(i: &InboxItem) -> usize {
    use speccoder_core::inbox::Risk;
    match i.risk.first() {
        Some(r) => Risk::ALL
            .iter()
            .position(|x| x.as_str() == r.reason)
            .unwrap_or(0),
        None if EVIDENCED.contains(&i.kind.as_str()) => Risk::ALL.len() + 1,
        None => Risk::ALL.len(),
    }
}

/// The feature's diagnosis when it has at least 3 speccoder ticks and more
/// than half are regression-only, and it has not been handed off (its
/// branch pushed, or merged with every task done).
fn unverified(r: &StatusReport, path: &Path) -> Option<speccoder_core::Unverified> {
    use speccoder_core::ReasonCount;
    let ticks = r.totals.verified + r.totals.regression_only;
    let regression = r.totals.regression_only;
    if ticks < 3 || regression * 2 <= ticks || handed_off(r, path) {
        return None;
    }
    let mut counts: Vec<ReasonCount> = Vec::new();
    for t in r.tasks.iter().filter(|t| t.state == "regression_only") {
        let reason = t
            .regression
            .as_ref()
            .map(|g| g.reason.clone())
            .unwrap_or(speccoder_core::regression::RegressionReason::Unrecorded);
        let name = reason.name().to_owned();
        let by = match &reason {
            speccoder_core::regression::RegressionReason::AlreadyPassing {
                implemented_by: Some(speccoder_core::regression::ImplementedBy::Task { task, .. }),
            } => Some(task.clone()),
            _ => None,
        };
        let c = match counts.iter_mut().position(|c| c.reason == name) {
            Some(i) => &mut counts[i],
            None => {
                counts.push(ReasonCount {
                    reason: name,
                    n: 0,
                    tasks: Vec::new(),
                    implemented_by: Vec::new(),
                    text: String::new(),
                });
                let last = counts.len() - 1;
                &mut counts[last]
            }
        };
        c.n += 1;
        c.tasks.push(t.id.clone());
        if let Some(b) = by.filter(|b| !c.implemented_by.contains(b)) {
            c.implemented_by.push(b);
        }
    }
    counts.sort_by(|a, b| b.n.cmp(&a.n).then(a.reason.cmp(&b.reason)));
    for c in &mut counts {
        c.text = reason_count_words(c);
    }
    Some(speccoder_core::Unverified {
        ticks,
        regression_only: regression,
        counts,
    })
}

/// `7 had no user story`, `7 were already passing — implemented by T003`.
fn reason_count_words(c: &speccoder_core::ReasonCount) -> String {
    let n = c.n;
    let were = if n == 1 { "was" } else { "were" };
    let what = match c.reason.as_str() {
        "no_story" => "had no user story".to_owned(),
        "no_scenarios" => "had a story with no acceptance scenario".to_owned(),
        "acceptance_off" => format!("{were} ticked with acceptance tests off"),
        "author_wrote_none" => "got no test from the test author".to_owned(),
        "author_failed" => "had acceptance tests that could not be used".to_owned(),
        "already_passing" if c.implemented_by.is_empty() => format!("{were} already passing"),
        "already_passing" => format!(
            "{were} already passing — implemented by {}",
            c.implemented_by.join(", ")
        ),
        "not_red" => "had acceptance tests that did not fail first".to_owned(),
        "tests_not_collected" => "had acceptance tests that never ran".to_owned(),
        "planning_work" => format!("{were} planning work (design documents)"),
        _ => format!("{were} ticked before reasons were recorded"),
    };
    format!("{n} {what}")
}

/// The feature was handed off: its speccoder branch was pushed, or it is
/// merged with every task done.
fn handed_off(r: &StatusReport, path: &Path) -> bool {
    let merged = !r.tasks.is_empty()
        && r.totals.ready == 0
        && r.totals.blocked == 0
        && r.unmerged_commits == 0
        && r.branch.is_some();
    let pushed = r.branch.as_deref().is_some_and(|b| {
        crate::git::Git::at(path)
            .line(&[
                "for-each-ref",
                "--format=%(refname)",
                &format!("refs/remotes/*/{b}"),
            ])
            .is_ok_and(|l| !l.trim().is_empty())
    });
    merged || pushed
}

/// Every task finished and the branch carries work not merged.
fn handoff(r: &StatusReport) -> bool {
    !r.tasks.is_empty()
        && r.totals.ready == 0
        && r.totals.blocked == 0
        && r.unmerged_commits > 0
        && r.branch.is_some()
}

fn with_input(
    t: &speccoder_core::TaskStatus,
    verb: &str,
    why: &str,
    prompt: &str,
    run: Runnable,
    flag: &dyn Fn(String) -> String,
) -> Action {
    let option = if verb == "nudge" {
        "--note"
    } else {
        "--reason"
    };
    let mut a = action(
        "task",
        format!("{verb} {}", t.id),
        why,
        flag(format!("speccoder task {verb} {} {option} \"…\"", t.id)),
    );
    a = a.with_run(run);
    a.input = Some(prompt.to_owned());
    a
}

/// The Needs You item of a bug that stopped for the person, if it did.
fn bug_item(
    b: &speccoder_core::bug::BugReport,
    flag: &dyn Fn(String) -> String,
) -> Option<InboxItem> {
    use speccoder_core::bug::Outcome;
    let key = b.key();
    let kind = match b.outcome {
        Outcome::AwaitingConfirmation => Kind::BugConfirm,
        Outcome::CannotReproduce => Kind::BugCannotReproduce,
        Outcome::UnchangedNotHolding => Kind::BugUnchangedNotHolding,
        // Kept as a regression test: decided.
        Outcome::AlreadySatisfied if b.commit.is_some() => return None,
        Outcome::AlreadySatisfied => Kind::BugAlreadySatisfied,
        _ if b.code.as_deref() == Some("BUG-REPRO-WEAK") => Kind::BugReproWeak,
        _ => return None,
    };
    let task = || b.task.clone();
    let mut actions = Vec::new();
    match kind {
        Kind::BugConfirm => {
            let digest = b.confirm_digest.clone().unwrap_or_default();
            let mut yes = action(
                "next",
                format!("confirm {}'s reproductions", b.task),
                "they show the bug: they are frozen and the fix runs",
                format!("speccoder bug confirm {key} --digest {digest}"),
            );
            yes = yes.with_run(Runnable::BugConfirm {
                task: key.clone(),
                digest: digest.clone(),
                reject: false,
            });
            let mut no = action(
                "next",
                format!("reject {}'s reproductions", b.task),
                "the author tries again, told why",
                format!("speccoder bug confirm {key} --reject --reason \"…\""),
            );
            no = no.with_run(Runnable::BugConfirm {
                task: key.clone(),
                digest,
                reject: true,
            });
            no.input = Some("Why they do not show the bug".to_owned());
            actions.extend([yes, no]);
        }
        Kind::BugAlreadySatisfied => {
            let mut keep = action(
                "next",
                format!("keep {}'s reproduction as a regression test", b.task),
                "the reproduction is committed and the task accepted on your word: attested, not verified",
                format!("speccoder bug keep {key} --reason \"kept as a regression test\""),
            );
            keep = keep.with_run(Runnable::BugKeep { task: key.clone() });
            keep.input = Some("Why it is kept".to_owned());
            let mut drop = action(
                "task",
                format!("drop {}", b.task),
                "it is fixed already",
                flag(format!("speccoder task skip {} --reason \"…\"", b.task)),
            );
            drop = drop.with_run(Runnable::Skip { task: task() });
            drop.input = Some("Why it is dropped".to_owned());
            actions.extend([keep, drop]);
        }
        Kind::BugReproWeak => {
            let mut rule = action(
                "task",
                format!("rule on {}", b.task),
                "the tests are right: the special case is not a fix",
                flag(format!(
                    "speccoder task rule {} --tests-right --reason \"…\"",
                    b.task
                )),
            );
            rule = rule.with_run(Runnable::Rule { task: task() });
            rule.input = Some("Why the tests are right".to_owned());
            actions.push(rule);
            actions.push(action(
                "task",
                "bring your own test",
                "one per Expected statement",
                format!(
                    "speccoder bug \"{}\" --expected \"…\" --test <file>::<test>",
                    b.triad.current.text
                ),
            ));
        }
        _ => {
            let mut again = action(
                "next",
                format!("reproduce {} again", b.task),
                "a fresh set of tries",
                format!("speccoder bug run --task {key}"),
            );
            again = again.with_run(Runnable::BugRun {
                slug: None,
                task: Some(key.clone()),
            });
            actions.push(again);
            actions.push(action(
                "task",
                "bring your own test",
                "one per Expected statement",
                format!(
                    "speccoder bug \"{}\" --expected \"…\" --test <file>::<test>",
                    b.triad.current.text
                ),
            ));
            if !b.home.kind.native() {
                actions.push(action(
                    "task",
                    format!("reword {}", b.requirement),
                    "the triad in other words (what was confirmed lapses)",
                    format!(
                        "speccoder review edit {} \"…\" --feature {}",
                        b.requirement, b.unit
                    ),
                ));
                let mut drop = action(
                    "task",
                    format!("drop {}", b.task),
                    "nothing is fixed",
                    flag(format!("speccoder task skip {} --reason \"…\"", b.task)),
                );
                drop = drop.with_run(Runnable::Skip { task: task() });
                drop.input = Some("Why it is dropped".to_owned());
                actions.push(drop);
            }
        }
    }
    let detail = b
        .handoff
        .as_ref()
        .map(|h| {
            format!(
                "{} tries; reproduced: {}; not reproduced: {}; already passing: {}",
                h.tries.len(),
                if h.statements.reproduced.is_empty() {
                    "none".to_owned()
                } else {
                    h.statements.reproduced.join(", ")
                },
                if h.statements.not_reproduced.is_empty() {
                    "none".to_owned()
                } else {
                    h.statements.not_reproduced.join(", ")
                },
                if h.statements.satisfied.is_empty() {
                    "none".to_owned()
                } else {
                    h.statements.satisfied.join(", ")
                },
            )
        })
        .unwrap_or_else(|| format!("{} — {}", b.title, b.outcome.as_str().replace('_', " ")));
    Some(InboxItem {
        unverified: None,
        risk: Vec::new(),
        tool: None,
        kind: kind.as_str().to_owned(),
        group: kind.group().as_str().to_owned(),
        feature: b.unit.clone(),
        task: Some(b.task.clone()),
        title: match kind {
            Kind::BugConfirm => format!(
                "{}: {} reproduction(s) wait for your confirmation",
                b.task,
                b.reproductions.iter().filter(|r| r.reproduces()).count()
            ),
            Kind::BugAlreadySatisfied => format!(
                "{}: already fixed — keep the reproduction or drop it",
                b.task
            ),
            Kind::BugReproWeak => {
                format!("{}: a special-case fix passes the reproductions", b.task)
            }
            Kind::BugUnchangedNotHolding => {
                format!("{}: an Unchanged statement does not hold today", b.task)
            }
            _ => format!("{}: could not be reproduced", b.task),
        },
        detail,
        since: b.confirmation.as_ref().map(|c| c.at),
        actions,
    })
}

/// Why a new attempt cannot start now: planning files a run cannot read
/// yet, or a waiting call's attempt that holds the worktree.
fn retry_blocked(r: &StatusReport, waiting: &[&str]) -> Option<String> {
    if !r.uncommitted.is_empty() {
        Some("commit the planning files first".to_owned())
    } else {
        waiting
            .first()
            .map(|w| format!("{w} waits for your decision and holds the worktree: decide it first"))
    }
}

/// The open tasks that wait on `id`, directly or through another.
fn dependents(tasks: &[speccoder_core::TaskStatus], id: &str) -> Vec<String> {
    let mut waiting: Vec<&str> = vec![id];
    loop {
        let more: Vec<&str> = tasks
            .iter()
            .filter(|t| !waiting.contains(&t.id.as_str()))
            .filter(|t| t.blocked_by.iter().any(|b| waiting.contains(&b.as_str())))
            .map(|t| t.id.as_str())
            .collect();
        if more.is_empty() {
            break;
        }
        waiting.extend(more);
    }
    tasks
        .iter()
        .filter(|t| t.id != id && waiting.contains(&t.id.as_str()))
        .map(|t| t.id.clone())
        .collect()
}

/// I did it, Hint & retry, Skip: the three ways on from a task that needs
/// the person.
fn yours_actions(
    t: &speccoder_core::TaskStatus,
    waiting: &[String],
    retry: Option<String>,
    flag: &dyn Fn(String) -> String,
) -> Vec<Action> {
    let mut done = action(
        "task",
        format!("I did it: {}", t.id),
        "tick it on your word (attested, never shown as verified)",
        flag(format!("speccoder task done {}", t.id)),
    );
    done = done.with_run(Runnable::Done { task: t.id.clone() });
    let mut hint = action(
        "task",
        format!("hint & retry {}", t.id),
        "a note the agent reads, then a new attempt now",
        flag(format!("speccoder task hint {} \"…\"", t.id)),
    );
    hint = hint.with_run(Runnable::Hint { task: t.id.clone() });
    hint.input = Some("The hint".to_owned());
    hint.blocked = retry;
    let mut skip = skip(t, flag);
    if !waiting.is_empty() {
        let stay = if waiting.len() == 1 { "stays" } else { "stay" };
        skip.why = format!("runs pass it by; {} {stay} blocked", waiting.join(", "));
    }
    vec![done, hint, skip]
}

fn nudge(t: &speccoder_core::TaskStatus, flag: &dyn Fn(String) -> String) -> Action {
    with_input(
        t,
        "nudge",
        "a note its next attempts read",
        "The note",
        Runnable::Nudge { task: t.id.clone() },
        flag,
    )
}

fn skip(t: &speccoder_core::TaskStatus, flag: &dyn Fn(String) -> String) -> Action {
    with_input(
        t,
        "skip",
        "runs pass it by; what depends on it stays blocked",
        "Why it is skipped",
        Runnable::Skip { task: t.id.clone() },
        flag,
    )
}

fn accept(t: &speccoder_core::TaskStatus, flag: &dyn Fn(String) -> String) -> Action {
    with_input(
        t,
        "accept",
        "tick it on your word (attested, never shown as verified)",
        "Why it is done",
        Runnable::Accept { task: t.id.clone() },
        flag,
    )
}

/// The same task with the next agent that can start here: one attempt,
/// judged as every attempt is. Offered after an external agent's attempt
/// (its run is `external_<agent>_…`), never after a native one.
fn try_with(
    task: &str,
    last: &speccoder_core::LastAttempt,
    flag: &dyn Fn(String) -> String,
    on_path: impl Fn(&str) -> bool,
) -> Option<Action> {
    let current = last
        .run_id
        .as_deref()
        .and_then(|r| r.strip_prefix("external_"))
        .and_then(|r| r.split('_').next())
        .filter(|a| *a != "command")?;
    let next = crate::acp::ready::next_after(Some(current), &on_path)?;
    Some(
        action(
            "work",
            format!("try {task} with {}", next.name),
            "the same task, another agent: one attempt, judged the same way",
            flag(format!("speccoder run --task {task} --agent {}", next.id)),
        )
        .with_run(Runnable::Run {
            task: Some(task.to_owned()),
            agent: Some(next.id.to_owned()),
        }),
    )
}

#[cfg(test)]
mod try_with_tests {
    use super::*;

    #[test]
    fn a_failed_agent_attempt_offers_the_next_agent_and_a_native_one_does_not() {
        let t = "T005";
        let last = |run: &str| speccoder_core::LastAttempt {
            outcome: "verification_failed".to_owned(),
            reason: String::new(),
            run_id: Some(run.to_owned()),
            reference: String::new(),
        };
        let flag = |c: String| c;
        let both = |x: &str| x == "copilot" || x == "opencode";
        let a = try_with(t, &last("external_copilot_1"), &flag, both)
            .unwrap_or_else(|| panic!("offered"));
        assert_eq!(a.command, "speccoder run --task T005 --agent opencode");
        assert_eq!(
            a.run,
            Some(Runnable::Run {
                task: Some("T005".to_owned()),
                agent: Some("opencode".to_owned())
            })
        );
        assert!(try_with(t, &last("run_01ABC"), &flag, both).is_none());
        assert!(try_with(t, &last("external_command_1"), &flag, both).is_none());
        let alone = |x: &str| x == "copilot";
        assert!(try_with(t, &last("external_copilot_1"), &flag, alone).is_none());
    }
}

#[cfg(test)]
mod order_tests {
    use super::*;

    fn at(kind: &str, feature: &str, since: Option<u64>, risk: &[(&str, usize)]) -> InboxItem {
        InboxItem {
            kind: kind.to_owned(),
            group: Kind::named(kind)
                .map_or("blocked_on_you", |k| k.group().as_str())
                .to_owned(),
            feature: feature.to_owned(),
            task: None,
            title: String::new(),
            detail: String::new(),
            since,
            actions: Vec::new(),
            unverified: None,
            tool: None,
            risk: risk
                .iter()
                .map(|(r, n)| speccoder_core::RiskReason {
                    reason: (*r).to_owned(),
                    count: *n,
                    text: String::new(),
                })
                .collect(),
        }
    }

    #[test]
    fn blocked_comes_first_oldest_first_and_review_riskiest_first() {
        let mut items = vec![
            at("handoff", "strong", None, &[]),
            at("review", "spec", None, &[]),
            at("handoff", "attested", None, &[("attested", 1)]),
            at("question", "q", Some(20), &[]),
            at(
                "unverified",
                "regression",
                None,
                &[("regression_only", 3), ("attested", 1)],
            ),
            at("approval", "a", Some(30), &[]),
            at("stale", "stale", None, &[("stale", 2)]),
            at("unknown", "unreadable", None, &[]),
            at("stuck", "s", Some(10), &[]),
        ];
        sort(&mut items);
        let order: Vec<&str> = items.iter().map(|i| i.feature.as_str()).collect();
        assert_eq!(
            order,
            [
                // Blocked on you: the unreadable journal, then the oldest.
                "unreadable",
                "s",
                "q",
                "a",
                // Ready to review: the riskiest reason first, strong verified last.
                "regression",
                "attested",
                "stale",
                "spec",
                "strong",
            ]
        );
    }
}