sparse_ir_capi/

funcs.rs

//! Functions API for C
//!
//! This module provides C-compatible functions for working with basis functions.

use crate::types::spir_funcs;
use sparse_ir::traits::Statistics;
use std::sync::Arc;

/// Manual release function (replaces macro-generated one)
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_release(funcs: *mut spir_funcs) {
    if !funcs.is_null() {
        unsafe {
            let _ = Box::from_raw(funcs);
        }
    }
}

/// Manual clone function (replaces macro-generated one)
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_clone(src: *const spir_funcs) -> *mut spir_funcs {
    if src.is_null() {
        return std::ptr::null_mut();
    }

    let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| unsafe {
        let src_ref = &*src;
        let cloned = (*src_ref).clone();
        Box::into_raw(Box::new(cloned))
    }));

    result.unwrap_or(std::ptr::null_mut())
}

/// Check if the funcs pointer is non-null.
///
/// Note: This only performs a null check. It cannot detect dangling
/// pointers; dereferencing an arbitrary non-null pointer would be
/// undefined behaviour that `catch_unwind` cannot reliably catch.
///
/// # Returns
/// 1 if the pointer is non-null, 0 otherwise
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_is_assigned(obj: *const spir_funcs) -> i32 {
    if obj.is_null() { 0 } else { 1 }
}

/// Compute the n-th derivative of basis functions
///
/// Creates a new funcs object representing the n-th derivative of the input functions.
/// For n=0, returns a clone of the input. For n=1, returns the first derivative, etc.
///
/// # Arguments
/// * `funcs` - Pointer to the input funcs object
/// * `n` - Order of derivative (0 = no derivative, 1 = first derivative, etc.)
/// * `status` - Pointer to store the status code
///
/// # Returns
/// Pointer to the newly created derivative funcs object, or NULL if computation fails
///
/// # Safety
/// Caller must ensure `funcs` is a valid pointer and `status` is non-null
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_deriv(
    funcs: *const spir_funcs,
    n: libc::c_int,
    status: *mut crate::StatusCode,
) -> *mut spir_funcs {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if status.is_null() {
        return std::ptr::null_mut();
    }

    if funcs.is_null() {
        unsafe {
            *status = SPIR_INVALID_ARGUMENT;
        }
        return std::ptr::null_mut();
    }

    if n < 0 {
        unsafe {
            *status = SPIR_INVALID_ARGUMENT;
        }
        return std::ptr::null_mut();
    }

    let result = catch_unwind(|| unsafe {
        let funcs_ref = &*funcs;
        let inner = funcs_ref.inner_type();

        // Only PolyVector types support derivatives
        match inner {
            crate::types::FuncsType::PolyVector(poly_funcs) => {
                // Apply deriv to each polynomial in the vector
                let deriv_polyvec: Vec<_> = poly_funcs
                    .poly
                    .polyvec
                    .iter()
                    .map(|poly| poly.deriv(n as usize))
                    .collect();

                let deriv_poly = sparse_ir::poly::PiecewiseLegendrePolyVector::new(deriv_polyvec);
                let deriv_arc = Arc::new(deriv_poly);

                // Create appropriate funcs based on domain
                let deriv_funcs = match poly_funcs.domain {
                    crate::types::FunctionDomain::Tau(Statistics::Fermionic) => {
                        spir_funcs::from_u_fermionic(deriv_arc, funcs_ref.beta)
                    }
                    crate::types::FunctionDomain::Tau(Statistics::Bosonic) => {
                        spir_funcs::from_u_bosonic(deriv_arc, funcs_ref.beta)
                    }
                    crate::types::FunctionDomain::Omega => {
                        spir_funcs::from_v(deriv_arc, funcs_ref.beta)
                    }
                };
                Box::into_raw(Box::new(deriv_funcs))
            }
            crate::types::FuncsType::FTVector(_) => {
                // FT vectors don't support derivatives in the current implementation
                *status = SPIR_NOT_SUPPORTED;
                std::ptr::null_mut()
            }
            _ => {
                // Other types don't support derivatives
                *status = SPIR_NOT_SUPPORTED;
                std::ptr::null_mut()
            }
        }
    });

    match result {
        Ok(ptr) if !ptr.is_null() => {
            unsafe {
                *status = SPIR_COMPUTATION_SUCCESS;
            }
            ptr
        }
        Ok(_) => {
            // Null pointer returned - status was already set above (e.g. SPIR_NOT_SUPPORTED)
            std::ptr::null_mut()
        }
        Err(_) => {
            unsafe {
                *status = SPIR_INTERNAL_ERROR;
            }
            std::ptr::null_mut()
        }
    }
}

/// Create a spir_funcs object from piecewise Legendre polynomial coefficients
///
/// Constructs a continuous function object from segments and Legendre polynomial
/// expansion coefficients. The coefficients are organized per segment, with each
/// segment containing nfuncs coefficients (degrees 0 to nfuncs-1).
///
/// # Arguments
/// * `segments` - Array of segment boundaries (n_segments+1 elements). Must be monotonically increasing.
/// * `n_segments` - Number of segments (must be >= 1)
/// * `coeffs` - Array of Legendre coefficients. Layout: contiguous per segment,
///              coefficients for segment i are stored at indices [i*nfuncs, (i+1)*nfuncs).
///              Each segment has nfuncs coefficients for Legendre degrees 0 to nfuncs-1.
/// * `nfuncs` - Number of basis functions per segment (Legendre polynomial degrees 0 to nfuncs-1)
/// * `order` - Order parameter (currently unused, reserved for future use)
/// * `status` - Pointer to store the status code
///
/// # Returns
/// Pointer to the newly created funcs object, or NULL if creation fails
///
/// # Note
/// The function creates a single piecewise Legendre polynomial function.
/// To create multiple functions, call this function multiple times.
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_from_piecewise_legendre(
    segments: *const f64,
    n_segments: libc::c_int,
    coeffs: *const f64,
    nfuncs: libc::c_int,
    _order: libc::c_int,
    status: *mut crate::StatusCode,
) -> *mut spir_funcs {
    use crate::{SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT};
    use sparse_ir::poly::{PiecewiseLegendrePoly, PiecewiseLegendrePolyVector};
    use std::panic::catch_unwind;
    use std::sync::Arc;

    if status.is_null() {
        return std::ptr::null_mut();
    }

    if segments.is_null() || coeffs.is_null() {
        unsafe {
            *status = SPIR_INVALID_ARGUMENT;
        }
        return std::ptr::null_mut();
    }

    if n_segments < 1 || nfuncs < 1 {
        unsafe {
            *status = SPIR_INVALID_ARGUMENT;
        }
        return std::ptr::null_mut();
    }

    let result = catch_unwind(std::panic::AssertUnwindSafe(|| {
        // Convert segments to Vec
        let segments_slice =
            unsafe { std::slice::from_raw_parts(segments, (n_segments + 1) as usize) };
        let knots = segments_slice.to_vec();

        // Verify segments are monotonically increasing
        for i in 1..knots.len() {
            if knots[i] <= knots[i - 1] {
                unsafe {
                    *status = SPIR_INVALID_ARGUMENT;
                }
                return std::ptr::null_mut();
            }
        }

        // Create coefficient matrix: data is (nfuncs, n_segments)
        // Each column represents one segment's coefficients
        let n_segments_usize = n_segments as usize;
        let nfuncs_usize = nfuncs as usize;
        let mut data = mdarray::DTensor::<f64, 2>::zeros([nfuncs_usize, n_segments_usize]);

        // Copy coefficients from C array
        // Layout: coeffs[seg * nfuncs + deg]
        let coeffs_slice =
            unsafe { std::slice::from_raw_parts(coeffs, (n_segments * nfuncs) as usize) };
        for seg in 0..n_segments_usize {
            for deg in 0..nfuncs_usize {
                data[[deg, seg]] = coeffs_slice[seg * nfuncs_usize + deg];
            }
        }

        // Note: knots.len() is guaranteed to be n_segments + 1 because knots is created
        // from segments_slice which has (n_segments + 1) elements

        // Create PiecewiseLegendrePoly (l=-1 means not specified)
        let poly = match std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
            PiecewiseLegendrePoly::new(data, knots.clone(), -1, None, 0)
        })) {
            Ok(p) => p,
            Err(_) => {
                unsafe {
                    *status = SPIR_INTERNAL_ERROR;
                }
                return std::ptr::null_mut();
            }
        };

        // Create PiecewiseLegendrePolyVector (single function)
        let polyvec = match std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
            PiecewiseLegendrePolyVector::new(vec![poly])
        })) {
            Ok(pv) => pv,
            Err(_) => {
                unsafe {
                    *status = SPIR_INTERNAL_ERROR;
                }
                return std::ptr::null_mut();
            }
        };
        let poly_arc = Arc::new(polyvec);

        // Create spir_funcs with Omega domain (generic continuous function)
        // Note: order parameter is currently unused, so we default to Omega domain
        // Use beta=1.0 as default (not used for Omega domain functions)
        let funcs = spir_funcs::from_v(poly_arc, 1.0);
        Box::into_raw(Box::new(funcs))
    }));

    match result {
        Ok(ptr) => {
            // If ptr is null, status was already set to an error value inside catch_unwind
            // (e.g., SPIR_INVALID_ARGUMENT for non-monotonic segments)
            // Don't overwrite the error status in that case
            if ptr.is_null() {
                return std::ptr::null_mut();
            }
            unsafe {
                *status = SPIR_COMPUTATION_SUCCESS;
            }
            ptr
        }
        Err(_) => {
            unsafe {
                *status = SPIR_INTERNAL_ERROR;
            }
            std::ptr::null_mut()
        }
    }
}

/// Extract a subset of functions by indices
///
/// # Arguments
/// * `funcs` - Pointer to the source funcs object
/// * `nslice` - Number of functions to select (length of indices array)
/// * `indices` - Array of indices specifying which functions to include
/// * `status` - Pointer to store the status code
///
/// # Returns
/// Pointer to a new funcs object containing only the selected functions, or null on error
///
/// # Safety
/// The caller must ensure that `funcs` and `indices` are valid pointers.
/// The returned pointer must be freed with `spir_funcs_release()`.
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_get_slice(
    funcs: *const spir_funcs,
    nslice: i32,
    indices: *const i32,
    status: *mut crate::StatusCode,
) -> *mut spir_funcs {
    use crate::{SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT};

    if funcs.is_null() || indices.is_null() || status.is_null() {
        if !status.is_null() {
            unsafe {
                *status = SPIR_INVALID_ARGUMENT;
            }
        }
        return std::ptr::null_mut();
    }

    if nslice < 0 {
        unsafe {
            *status = SPIR_INVALID_ARGUMENT;
        }
        return std::ptr::null_mut();
    }

    let result = std::panic::catch_unwind(|| {
        let funcs_ref = unsafe { &*funcs };

        // Convert C indices to Rust Vec<usize>
        let indices_slice = unsafe { std::slice::from_raw_parts(indices, nslice as usize) };
        let mut rust_indices = Vec::with_capacity(nslice as usize);

        for &i in indices_slice {
            if i < 0 {
                unsafe {
                    *status = SPIR_INVALID_ARGUMENT;
                }
                return std::ptr::null_mut();
            }
            rust_indices.push(i as usize);
        }

        // Get the slice
        match funcs_ref.get_slice(&rust_indices) {
            Some(sliced_funcs) => {
                unsafe {
                    *status = SPIR_COMPUTATION_SUCCESS;
                }
                Box::into_raw(Box::new(sliced_funcs))
            }
            None => {
                unsafe {
                    *status = SPIR_INVALID_ARGUMENT;
                }
                std::ptr::null_mut()
            }
        }
    });

    result.unwrap_or_else(|_| {
        unsafe {
            *status = SPIR_INTERNAL_ERROR;
        }
        std::ptr::null_mut()
    })
}

/// Gets the number of basis functions
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `size` - Pointer to store the number of functions
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success)
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_get_size(
    funcs: *const spir_funcs,
    size: *mut libc::c_int,
) -> crate::StatusCode {
    use crate::{SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT};
    use std::panic::catch_unwind;

    if funcs.is_null() || size.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        *size = f.size() as libc::c_int;
        SPIR_COMPUTATION_SUCCESS
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Gets the number of knots for continuous functions
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `n_knots` - Pointer to store the number of knots
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not continuous)
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_get_n_knots(
    funcs: *const spir_funcs,
    n_knots: *mut libc::c_int,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || n_knots.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        match f.knots() {
            Some(knots) => {
                *n_knots = knots.len() as libc::c_int;
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Gets the knot positions for continuous functions
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `knots` - Pre-allocated array to store knot positions
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not continuous)
///
/// # Safety
/// The caller must ensure that `knots` has size >= `spir_funcs_get_n_knots(funcs)`
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_get_knots(
    funcs: *const spir_funcs,
    knots: *mut f64,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || knots.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        match f.knots() {
            Some(knot_vec) => {
                std::ptr::copy_nonoverlapping(knot_vec.as_ptr(), knots, knot_vec.len());
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Evaluate functions at a single point (continuous functions only)
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `x` - Point to evaluate at (tau coordinate in [-1, 1])
/// * `out` - Pre-allocated array to store function values
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not continuous)
///
/// # Safety
/// The caller must ensure that `out` has size >= `spir_funcs_get_size(funcs)`
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_eval(
    funcs: *const spir_funcs,
    x: f64,
    out: *mut f64,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || out.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        match f.eval_continuous(x) {
            Some(values) => {
                std::ptr::copy_nonoverlapping(values.as_ptr(), out, values.len());
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Evaluate functions at a single Matsubara frequency
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `n` - Matsubara frequency index
/// * `out` - Pre-allocated array to store complex function values
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not Matsubara type)
///
/// # Safety
/// The caller must ensure that `out` has size >= `spir_funcs_get_size(funcs)`
/// Complex numbers are laid out as [real, imag] pairs
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_eval_matsu(
    funcs: *const spir_funcs,
    n: i64,
    out: *mut num_complex::Complex64,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || out.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        match f.eval_matsubara(n) {
            Some(values) => {
                std::ptr::copy_nonoverlapping(values.as_ptr(), out, values.len());
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Batch evaluate functions at multiple points (continuous functions only)
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `order` - Memory layout: 0 for row-major, 1 for column-major
/// * `num_points` - Number of evaluation points
/// * `xs` - Array of points to evaluate at
/// * `out` - Pre-allocated array to store results
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not continuous)
///
/// # Safety
/// - `xs` must have size >= `num_points`
/// - `out` must have size >= `num_points * spir_funcs_get_size(funcs)`
/// - Layout: row-major = out\[point\]\[func\], column-major = out\[func\]\[point\]
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_batch_eval(
    funcs: *const spir_funcs,
    order: libc::c_int,
    num_points: libc::c_int,
    xs: *const f64,
    out: *mut f64,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || xs.is_null() || out.is_null() || num_points <= 0 {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        let xs_slice = std::slice::from_raw_parts(xs, num_points as usize);

        match f.batch_eval_continuous(xs_slice) {
            Some(result_matrix) => {
                // result_matrix is Vec<Vec<f64>> where outer index is function, inner is point
                let n_funcs = result_matrix.len();
                let n_points = num_points as usize;

                if order == 0 {
                    // Row-major: out[point][func]
                    for i in 0..n_points {
                        for j in 0..n_funcs {
                            *out.add(i * n_funcs + j) = result_matrix[j][i];
                        }
                    }
                } else {
                    // Column-major: out[func][point]
                    for j in 0..n_funcs {
                        for i in 0..n_points {
                            *out.add(j * n_points + i) = result_matrix[j][i];
                        }
                    }
                }
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Batch evaluate functions at multiple Matsubara frequencies
///
/// # Arguments
/// * `funcs` - Pointer to the funcs object
/// * `order` - Memory layout: 0 for row-major, 1 for column-major
/// * `num_freqs` - Number of Matsubara frequencies
/// * `ns` - Array of Matsubara frequency indices
/// * `out` - Pre-allocated array to store complex results
///
/// # Returns
/// Status code (SPIR_COMPUTATION_SUCCESS on success, SPIR_NOT_SUPPORTED if not Matsubara type)
///
/// # Safety
/// - `ns` must have size >= `num_freqs`
/// - `out` must have size >= `num_freqs * spir_funcs_get_size(funcs)`
/// - Complex numbers are laid out as [real, imag] pairs
/// - Layout: row-major = out\[freq\]\[func\], column-major = out\[func\]\[freq\]
#[unsafe(no_mangle)]
pub extern "C" fn spir_funcs_batch_eval_matsu(
    funcs: *const spir_funcs,
    order: libc::c_int,
    num_freqs: libc::c_int,
    ns: *const i64,
    out: *mut num_complex::Complex64,
) -> crate::StatusCode {
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use std::panic::catch_unwind;

    if funcs.is_null() || ns.is_null() || out.is_null() || num_freqs <= 0 {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*funcs;
        let ns_slice = std::slice::from_raw_parts(ns, num_freqs as usize);

        match f.batch_eval_matsubara(ns_slice) {
            Some(result_matrix) => {
                // result_matrix is Vec<Vec<Complex64>> where outer index is function, inner is freq
                let n_funcs = result_matrix.len();
                let n_freqs = num_freqs as usize;

                if order == 0 {
                    // Row-major: out[freq][func]
                    for i in 0..n_freqs {
                        for j in 0..n_funcs {
                            *out.add(i * n_funcs + j) = result_matrix[j][i];
                        }
                    }
                } else {
                    // Column-major: out[func][freq]
                    for j in 0..n_funcs {
                        for i in 0..n_freqs {
                            *out.add(j * n_freqs + i) = result_matrix[j][i];
                        }
                    }
                }
                SPIR_COMPUTATION_SUCCESS
            }
            None => SPIR_NOT_SUPPORTED,
        }
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

/// Get default Matsubara sampling points from a Matsubara-space spir_funcs
///
/// This function computes default sampling points in Matsubara frequencies (iωn) from
/// a spir_funcs object that represents Matsubara-space basis functions (e.g., uhat or uhat_full).
/// The statistics type (Fermionic/Bosonic) is automatically detected from the spir_funcs object type.
///
/// This extracts the PiecewiseLegendreFTVector from spir_funcs and calls
/// `FiniteTempBasis::default_matsubara_sampling_points_impl` from `basis.rs` (lines 332-387)
/// to compute default sampling points.
///
/// The implementation uses the same algorithm as defined in `sparseir-rust/src/basis.rs`,
/// which selects sampling points based on sign changes or extrema of the Matsubara basis functions.
///
/// # Arguments
/// * `uhat` - Pointer to a spir_funcs object representing Matsubara-space basis functions
/// * `l` - Number of requested sampling points
/// * `positive_only` - If true, only positive frequencies are used
/// * `mitigate` - If true, enable mitigation (fencing) to improve conditioning by adding oversampling points
/// * `points` - Pre-allocated array to store the sampling points. The size of the array must be sufficient for the returned points (may exceed L if mitigate is true).
/// * `n_points_returned` - Pointer to store the number of sampling points returned (may exceed L if mitigate is true, or approximately L/2 when positive_only=true).
///
/// # Returns
/// Status code:
/// - SPIR_COMPUTATION_SUCCESS (0) on success
/// - SPIR_INVALID_ARGUMENT if uhat, points, or n_points_returned is null
/// - SPIR_NOT_SUPPORTED if uhat is not a Matsubara-space function
///
/// # Note
/// This function is only available for spir_funcs objects representing Matsubara-space basis functions
/// The statistics type is automatically detected from the spir_funcs object type
/// The default sampling points are chosen to provide near-optimal conditioning
#[unsafe(no_mangle)]
pub extern "C" fn spir_uhat_get_default_matsus(
    uhat: *const spir_funcs,
    l: libc::c_int,
    positive_only: bool,
    mitigate: bool,
    points: *mut i64,
    n_points_returned: *mut libc::c_int,
) -> crate::StatusCode {
    use crate::types::FuncsType;
    use crate::{
        SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR, SPIR_INVALID_ARGUMENT, SPIR_NOT_SUPPORTED,
    };
    use sparse_ir::basis::FiniteTempBasis;
    use sparse_ir::kernel::LogisticKernel;
    use sparse_ir::traits::{Bosonic, Fermionic};
    use std::panic::catch_unwind;

    if uhat.is_null() || points.is_null() || n_points_returned.is_null() {
        return SPIR_INVALID_ARGUMENT;
    }

    let result = catch_unwind(|| unsafe {
        let f = &*uhat;
        let inner = f.inner_type();

        let points_vec: Vec<i64> = match inner {
            FuncsType::FTVector(ft_funcs) => {
                let fence = mitigate;
                let l_usize = l as usize;

                // Handle Fermionic case
                // Uses FiniteTempBasis::default_matsubara_sampling_points_impl from basis.rs (332-387)
                if let Some(ref ft_fermionic) = ft_funcs.ft_fermionic {
                    let matsubara_points = FiniteTempBasis::<LogisticKernel, Fermionic>::default_matsubara_sampling_points_impl(
                        ft_fermionic,
                        l_usize,
                        fence,
                        positive_only,
                    );
                    matsubara_points
                        .iter()
                        .map(|freq| freq.into_i64())
                        .collect()
                }
                // Handle Bosonic case
                // Uses FiniteTempBasis::default_matsubara_sampling_points_impl from basis.rs (332-387)
                else if let Some(ref ft_bosonic) = ft_funcs.ft_bosonic {
                    let matsubara_points = FiniteTempBasis::<LogisticKernel, Bosonic>::default_matsubara_sampling_points_impl(
                        ft_bosonic,
                        l_usize,
                        fence,
                        positive_only,
                    );
                    matsubara_points
                        .iter()
                        .map(|freq| freq.into_i64())
                        .collect()
                } else {
                    return SPIR_INVALID_ARGUMENT;
                }
            }
            _ => return SPIR_NOT_SUPPORTED,
        };

        let n_points = points_vec.len();
        std::ptr::copy_nonoverlapping(points_vec.as_ptr(), points, n_points);
        *n_points_returned = n_points as libc::c_int;
        SPIR_COMPUTATION_SUCCESS
    });

    result.unwrap_or(SPIR_INTERNAL_ERROR)
}

#[cfg(test)]
mod tests {
    use super::*;

    use crate::{SPIR_COMPUTATION_SUCCESS, SPIR_INTERNAL_ERROR};
    use std::ptr;

    #[test]
    fn test_funcs_basic_lifecycle() {
        use crate::basis::*;
        use crate::kernel::*;

        // Create a kernel
        let mut kernel_status = SPIR_INTERNAL_ERROR;
        let kernel = spir_logistic_kernel_new(10.0, &mut kernel_status);
        assert_eq!(kernel_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!kernel.is_null());

        // Create a basis
        let mut basis_status = SPIR_INTERNAL_ERROR;
        let basis = spir_basis_new(
            1,    // Fermionic
            10.0, // beta
            1.0,  // omega_max
            1e-6, // epsilon
            kernel,
            ptr::null(), // no SVE
            -1,          // no max_size
            &mut basis_status,
        );
        assert_eq!(basis_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!basis.is_null());

        // Get u funcs
        let mut u_status = crate::SPIR_INTERNAL_ERROR;
        let u_funcs = unsafe { spir_basis_get_u(basis, &mut u_status) };
        assert_eq!(u_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!u_funcs.is_null());
        debug_println!("✓ Created u funcs");

        // Get v funcs
        let mut v_status = crate::SPIR_INTERNAL_ERROR;
        let v_funcs = unsafe { spir_basis_get_v(basis, &mut v_status) };
        assert_eq!(v_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!v_funcs.is_null());
        debug_println!("✓ Created v funcs");

        // Get uhat funcs
        let mut uhat_status = crate::SPIR_INTERNAL_ERROR;
        let uhat_funcs = unsafe { spir_basis_get_uhat(basis, &mut uhat_status) };
        assert_eq!(uhat_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!uhat_funcs.is_null());
        debug_println!("✓ Created uhat funcs");

        // Clean up
        unsafe {
            spir_funcs_release(u_funcs);
            spir_funcs_release(v_funcs);
            spir_funcs_release(uhat_funcs);
            spir_basis_release(basis);
            spir_kernel_release(kernel);
        }

        debug_println!("✓ All funcs released successfully");
    }

    #[test]
    fn test_funcs_introspection() {
        use crate::basis::*;
        use crate::kernel::*;

        // Create a kernel and basis
        let mut kernel_status = crate::SPIR_INTERNAL_ERROR;
        let kernel = spir_logistic_kernel_new(10.0, &mut kernel_status);
        assert_eq!(kernel_status, SPIR_COMPUTATION_SUCCESS);

        let mut basis_status = crate::SPIR_INTERNAL_ERROR;
        let basis = spir_basis_new(
            1,
            10.0,
            1.0,
            1e-6,
            kernel,
            ptr::null(),
            -1,
            &mut basis_status,
        );
        assert_eq!(basis_status, SPIR_COMPUTATION_SUCCESS);

        // Get u funcs
        let mut u_status = crate::SPIR_INTERNAL_ERROR;
        let u_funcs = unsafe { spir_basis_get_u(basis, &mut u_status) };
        assert_eq!(u_status, SPIR_COMPUTATION_SUCCESS);

        // Test get_size
        let mut size = 0;
        let status = spir_funcs_get_size(u_funcs, &mut size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        assert!(size > 0);
        debug_println!("✓ Funcs size: {}", size);

        // Test get_n_knots
        let mut n_knots = 0;
        let status = spir_funcs_get_n_knots(u_funcs, &mut n_knots);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        assert!(n_knots > 0);
        debug_println!("✓ Number of knots: {}", n_knots);

        // Test get_knots
        let mut knots = vec![0.0; n_knots as usize];
        let status = spir_funcs_get_knots(u_funcs, knots.as_mut_ptr());
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ First 5 knots:");
        for i in 0..std::cmp::min(5, knots.len()) {
            debug_println!("  knot[{}] = {}", i, knots[i]);
        }

        // Test with uhat funcs (should return NOT_SUPPORTED for knots)
        let mut uhat_status = crate::SPIR_INTERNAL_ERROR;
        let uhat_funcs = unsafe { spir_basis_get_uhat(basis, &mut uhat_status) };
        assert_eq!(uhat_status, SPIR_COMPUTATION_SUCCESS);

        let mut n_knots_uhat = 0;
        let status = spir_funcs_get_n_knots(uhat_funcs, &mut n_knots_uhat);
        assert_eq!(status, crate::SPIR_NOT_SUPPORTED);
        debug_println!("✓ uhat funcs correctly returns NOT_SUPPORTED for knots");

        // Cleanup
        unsafe {
            spir_funcs_release(u_funcs);
            spir_funcs_release(uhat_funcs);
            spir_basis_release(basis);
            spir_kernel_release(kernel);
        }
    }

    #[test]
    fn test_funcs_evaluation() {
        use crate::basis::*;
        use crate::kernel::*;
        use num_complex::Complex64;

        // Create a kernel and basis
        let mut kernel_status = crate::SPIR_INTERNAL_ERROR;
        let kernel = spir_logistic_kernel_new(10.0, &mut kernel_status);
        assert_eq!(kernel_status, SPIR_COMPUTATION_SUCCESS);

        let mut basis_status = crate::SPIR_INTERNAL_ERROR;
        let basis = spir_basis_new(
            1,
            10.0,
            1.0,
            1e-6,
            kernel,
            ptr::null(),
            -1,
            &mut basis_status,
        );
        assert_eq!(basis_status, SPIR_COMPUTATION_SUCCESS);

        // Get u funcs
        let mut u_status = crate::SPIR_INTERNAL_ERROR;
        let u_funcs = unsafe { spir_basis_get_u(basis, &mut u_status) };
        assert_eq!(u_status, SPIR_COMPUTATION_SUCCESS);

        // Test single point eval
        let mut size = 0;
        let status = spir_funcs_get_size(u_funcs, &mut size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);

        let mut values = vec![0.0; size as usize];
        let status = spir_funcs_eval(u_funcs, 0.0, values.as_mut_ptr());
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Evaluated u at x=0: {} functions", size);
        debug_println!("  u[0](0) = {}", values[0]);

        // Test batch eval
        let xs = [-0.5, 0.0, 0.5];
        let mut batch_out = vec![0.0; (size as usize) * xs.len()];
        let status = spir_funcs_batch_eval(
            u_funcs,
            1, // column-major
            xs.len() as i32,
            xs.as_ptr(),
            batch_out.as_mut_ptr(),
        );
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Batch evaluated u at 3 points (column-major)");

        // Get uhat funcs
        let mut uhat_status = crate::SPIR_INTERNAL_ERROR;
        let uhat_funcs = unsafe { spir_basis_get_uhat(basis, &mut uhat_status) };
        assert_eq!(uhat_status, SPIR_COMPUTATION_SUCCESS);

        // Test Matsubara eval
        let mut matsu_values = vec![Complex64::new(0.0, 0.0); size as usize];
        let status = spir_funcs_eval_matsu(uhat_funcs, 1, matsu_values.as_mut_ptr());
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Evaluated uhat at n=1");
        debug_println!("  uhat[0](iω_1) = {}", matsu_values[0]);

        // Test batch Matsubara eval
        let matsu_ns = [1i64, 3, 5];
        let mut batch_matsu_out = vec![Complex64::new(0.0, 0.0); (size as usize) * matsu_ns.len()];
        let status = spir_funcs_batch_eval_matsu(
            uhat_funcs,
            1, // column-major
            matsu_ns.len() as i32,
            matsu_ns.as_ptr(),
            batch_matsu_out.as_mut_ptr(),
        );
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Batch evaluated uhat at 3 Matsubara frequencies");

        // Cleanup
        unsafe {
            spir_funcs_release(u_funcs);
            spir_funcs_release(uhat_funcs);
            spir_basis_release(basis);
            spir_kernel_release(kernel);
        }
    }

    #[test]
    fn test_funcs_clone_and_slice() {
        use crate::basis::*;
        use crate::kernel::*;
        use crate::{SPIR_COMPUTATION_SUCCESS, SPIR_INVALID_ARGUMENT};
        use std::ptr;

        // Create a kernel and basis
        let mut kernel_status = crate::SPIR_INTERNAL_ERROR;
        let kernel = spir_logistic_kernel_new(10.0, &mut kernel_status);
        assert_eq!(kernel_status, SPIR_COMPUTATION_SUCCESS);

        let mut basis_status = crate::SPIR_INTERNAL_ERROR;
        let basis = spir_basis_new(
            1,
            10.0,
            1.0,
            1e-6,
            kernel,
            ptr::null(),
            -1,
            &mut basis_status,
        );
        assert_eq!(basis_status, SPIR_COMPUTATION_SUCCESS);

        // Get u funcs
        let mut u_status = crate::SPIR_INTERNAL_ERROR;
        let u_funcs = unsafe { spir_basis_get_u(basis, &mut u_status) };
        assert_eq!(u_status, SPIR_COMPUTATION_SUCCESS);

        let mut size = 0;
        let status = spir_funcs_get_size(u_funcs, &mut size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Original funcs size: {}", size);

        // Test is_assigned
        let assigned = spir_funcs_is_assigned(u_funcs);
        assert_eq!(assigned, 1);
        debug_println!("✓ is_assigned returned 1 for valid object");

        let null_assigned = spir_funcs_is_assigned(ptr::null());
        assert_eq!(null_assigned, 0);
        debug_println!("✓ is_assigned returned 0 for null pointer");

        // Test clone
        let cloned_funcs = unsafe { spir_funcs_clone(u_funcs) };
        assert!(!cloned_funcs.is_null());
        debug_println!("✓ Cloned funcs successfully");

        let mut cloned_size = 0;
        let status = spir_funcs_get_size(cloned_funcs, &mut cloned_size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        assert_eq!(cloned_size, size);
        debug_println!("✓ Cloned funcs has same size as original");

        // Test get_slice
        let indices = [0i32, 2, 4]; // Select first, third, fifth functions
        let mut slice_status = crate::SPIR_INTERNAL_ERROR;
        let sliced_funcs = unsafe {
            spir_funcs_get_slice(
                u_funcs,
                indices.len() as i32,
                indices.as_ptr(),
                &mut slice_status,
            )
        };
        assert_eq!(slice_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!sliced_funcs.is_null());
        debug_println!("✓ Created slice with {} functions", indices.len());

        let mut sliced_size = 0;
        let status = spir_funcs_get_size(sliced_funcs, &mut sliced_size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        assert_eq!(sliced_size, indices.len() as i32);
        debug_println!("✓ Sliced funcs has correct size");

        // Test that sliced functions evaluate correctly
        let mut sliced_values = vec![0.0; sliced_size as usize];
        let status = spir_funcs_eval(sliced_funcs, 0.0, sliced_values.as_mut_ptr());
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
        debug_println!("✓ Sliced funcs evaluates correctly");

        // Test error case: invalid indices
        let bad_indices = [-1i32];
        let mut bad_status = SPIR_COMPUTATION_SUCCESS;
        let bad_slice = unsafe {
            spir_funcs_get_slice(
                u_funcs,
                bad_indices.len() as i32,
                bad_indices.as_ptr(),
                &mut bad_status,
            )
        };
        assert_eq!(bad_status, SPIR_INVALID_ARGUMENT);
        assert!(bad_slice.is_null());
        debug_println!("✓ Invalid indices correctly rejected");

        // Test error case: out of range indices
        let oor_indices = [0i32, size]; // size is out of range (0-indexed)
        let mut oor_status = SPIR_COMPUTATION_SUCCESS;
        let oor_slice = unsafe {
            spir_funcs_get_slice(
                u_funcs,
                oor_indices.len() as i32,
                oor_indices.as_ptr(),
                &mut oor_status,
            )
        };
        assert_eq!(oor_status, SPIR_INVALID_ARGUMENT);
        assert!(oor_slice.is_null());
        debug_println!("✓ Out-of-range indices correctly rejected");

        // Cleanup
        unsafe {
            spir_funcs_release(sliced_funcs);
            spir_funcs_release(cloned_funcs);
            spir_funcs_release(u_funcs);
            spir_basis_release(basis);
            spir_kernel_release(kernel);
        }
        debug_println!("✓ All objects released successfully");
    }

    #[test]
    fn test_funcs_from_piecewise_legendre() {
        // Create a simple piecewise polynomial: constant function = 1.0 on [-1, 1]
        // Single segment, nfuncs=1 (only degree 0 Legendre polynomial)
        {
            let n_segments = 1;
            let segments = [-1.0, 1.0];
            let coeffs = [1.0]; // Only constant term
            let nfuncs = 1;
            let order = 0;

            let mut status = SPIR_INTERNAL_ERROR;
            let funcs = spir_funcs_from_piecewise_legendre(
                segments.as_ptr(),
                n_segments,
                coeffs.as_ptr(),
                nfuncs,
                order,
                &mut status,
            );
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(!funcs.is_null());

            // Test evaluation at x=0 (should be normalized, so value depends on normalization)
            let mut size = 0;
            let status = spir_funcs_get_size(funcs, &mut size);
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert_eq!(size, 1);

            // Evaluate at x=0
            let x = 0.0;
            let mut values = vec![0.0; size as usize];
            let status = spir_funcs_eval(funcs, x, values.as_mut_ptr());
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            // Value should be approximately 1.0 * normalization factor
            assert!((values[0] - 1.0).abs() < 1e-10);

            unsafe {
                spir_funcs_release(funcs);
            }
        }

        // Create a linear function: f(x) = x on [-1, 1]
        // Single segment, nfuncs=2 (degrees 0 and 1)
        {
            let n_segments = 1;
            let segments = [-1.0, 1.0];
            // Legendre expansion: P0(x) = 1, P1(x) = x
            // For f(x) = x, we need coefficient 0 for P0 and 1 for P1
            // But normalization affects the actual values
            let coeffs = [0.0, 1.0]; // Constant=0, linear=1
            let nfuncs = 2;
            let order = 0;

            let mut status = SPIR_INTERNAL_ERROR;
            let funcs = spir_funcs_from_piecewise_legendre(
                segments.as_ptr(),
                n_segments,
                coeffs.as_ptr(),
                nfuncs,
                order,
                &mut status,
            );
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(!funcs.is_null());

            // Evaluate at x=0.5
            let x = 0.5;
            let mut size = 0;
            let status = spir_funcs_get_size(funcs, &mut size);
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            let mut values = vec![0.0; size as usize];
            let status = spir_funcs_eval(funcs, x, values.as_mut_ptr());
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            // Value should be approximately 0.5 (with normalization)
            // Note: PiecewiseLegendrePoly applies normalization, so the actual value may differ
            // We just check that evaluation succeeds and returns a reasonable value
            assert!(values[0].abs() < 10.0); // Reasonable bound

            unsafe {
                spir_funcs_release(funcs);
            }
        }

        // Test error handling: invalid arguments
        {
            let mut status = SPIR_INTERNAL_ERROR;
            let funcs =
                spir_funcs_from_piecewise_legendre(ptr::null(), 1, ptr::null(), 1, 0, &mut status);
            assert_ne!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(funcs.is_null());
        }

        // Test error handling: n_segments < 1
        {
            let segments = [-1.0, 1.0];
            let coeffs = [1.0];
            let mut status = SPIR_INTERNAL_ERROR;
            let funcs = spir_funcs_from_piecewise_legendre(
                segments.as_ptr(),
                0,
                coeffs.as_ptr(),
                1,
                0,
                &mut status,
            );
            assert_ne!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(funcs.is_null());
        }

        // Test error handling: non-monotonic segments
        {
            let segments = [1.0, -1.0]; // Wrong order
            let coeffs = [1.0];
            let mut status = SPIR_INTERNAL_ERROR;
            let funcs = spir_funcs_from_piecewise_legendre(
                segments.as_ptr(),
                1,
                coeffs.as_ptr(),
                1,
                0,
                &mut status,
            );
            assert_ne!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(funcs.is_null());
        }
    }

    #[test]
    fn test_uhat_get_default_matsus() {
        use crate::basis::*;
        use crate::kernel::*;

        // Create a kernel and basis
        let mut kernel_status = SPIR_INTERNAL_ERROR;
        let kernel = spir_logistic_kernel_new(10.0, &mut kernel_status);
        assert_eq!(kernel_status, SPIR_COMPUTATION_SUCCESS);

        let mut basis_status = SPIR_INTERNAL_ERROR;
        let basis = spir_basis_new(
            1,    // Fermionic
            10.0, // beta
            1.0,  // omega_max
            1e-6, // epsilon
            kernel,
            ptr::null(),
            -1,
            &mut basis_status,
        );
        assert_eq!(basis_status, SPIR_COMPUTATION_SUCCESS);

        // Get uhat funcs
        let mut uhat_status = SPIR_INTERNAL_ERROR;
        let uhat_funcs = unsafe { spir_basis_get_uhat(basis, &mut uhat_status) };
        assert_eq!(uhat_status, SPIR_COMPUTATION_SUCCESS);
        assert!(!uhat_funcs.is_null());

        // Get basis size
        let mut basis_size = 0;
        let status = spir_basis_get_size(basis, &mut basis_size);
        assert_eq!(status, SPIR_COMPUTATION_SUCCESS);

        // Test without mitigation (mitigate = false)
        {
            let l = basis_size;
            let positive_only = false;
            let mitigate = false;
            let mut points = vec![0i64; (l + 10) as usize];
            let mut n_points_returned = 0;

            let status = spir_uhat_get_default_matsus(
                uhat_funcs,
                l,
                positive_only,
                mitigate,
                points.as_mut_ptr(),
                &mut n_points_returned,
            );
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(n_points_returned > 0);

            // Verify points are valid fermionic frequencies (odd integers)
            for i in 0..(n_points_returned as usize) {
                assert!(points[i].abs() % 2 == 1);
            }
        }

        // Test with mitigation (mitigate = true)
        {
            let l = basis_size;
            let positive_only = false;
            let mitigate = true;
            let mut points = vec![0i64; (l + 20) as usize];
            let mut n_points_returned = 0;

            let status = spir_uhat_get_default_matsus(
                uhat_funcs,
                l,
                positive_only,
                mitigate,
                points.as_mut_ptr(),
                &mut n_points_returned,
            );
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(n_points_returned > 0);

            // Verify points are valid fermionic frequencies (odd integers)
            for i in 0..(n_points_returned as usize) {
                assert!(points[i].abs() % 2 == 1);
            }
        }

        // Test positive_only = true with mitigation
        {
            let l = basis_size;
            let positive_only = true;
            let mitigate = true;
            let mut points = vec![0i64; (l + 20) as usize];
            let mut n_points_returned = 0;

            let status = spir_uhat_get_default_matsus(
                uhat_funcs,
                l,
                positive_only,
                mitigate,
                points.as_mut_ptr(),
                &mut n_points_returned,
            );
            assert_eq!(status, SPIR_COMPUTATION_SUCCESS);
            assert!(n_points_returned > 0);

            // Verify all points are positive and odd
            for i in 0..(n_points_returned as usize) {
                assert!(points[i] > 0);
                assert!(points[i] % 2 == 1);
            }

            assert_eq!(points[n_points_returned as usize - 1], 15);
        }

        // Test error handling
        {
            let mut n_points_returned = 0;
            let status = spir_uhat_get_default_matsus(
                ptr::null(),
                10,
                false,
                false,
                ptr::null_mut(),
                &mut n_points_returned,
            );
            assert_ne!(status, SPIR_COMPUTATION_SUCCESS);
        }

        unsafe {
            spir_funcs_release(uhat_funcs);
            spir_basis_release(basis);
            spir_kernel_release(kernel);
        }
    }
}