spark-cryptography 0.1.11

Cryptography module for Spark Rust SDK
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
use std::collections::BTreeMap;
use std::collections::BTreeSet;
use std::collections::HashMap;

use frost_core_unofficial::round1::Nonce;
use frost_core_unofficial::round1::NonceCommitment;
use frost_secp256k1_tr_unofficial::keys::EvenY;
use frost_secp256k1_tr_unofficial::keys::KeyPackage as FrostKeyPackage;
use frost_secp256k1_tr_unofficial::keys::PublicKeyPackage;
use frost_secp256k1_tr_unofficial::keys::SigningShare;
use frost_secp256k1_tr_unofficial::keys::Tweak;
use frost_secp256k1_tr_unofficial::keys::VerifyingShare;
use frost_secp256k1_tr_unofficial::round1::SigningCommitments as FrostSigningCommitments;
use frost_secp256k1_tr_unofficial::round1::SigningNonces as FrostSigningNonces;
use frost_secp256k1_tr_unofficial::round2::SignatureShare;
use frost_secp256k1_tr_unofficial::Identifier;
use frost_secp256k1_tr_unofficial::SigningPackage;
use frost_secp256k1_tr_unofficial::VerifyingKey;

use spark_protos::common::*;
use spark_protos::frost::*;

use crate::error::FrostOperationError;
use crate::error::InvalidCommitmentError;
use crate::error::InvalidIdentifierError;
use crate::error::InvalidKeyError;
use crate::error::InvalidKeyPackageError;
use crate::error::InvalidNonceError;
use crate::error::InvalidRoleError;
use crate::error::InvalidSignatureShareError;
use crate::error::SparkCryptographyError;

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_nonce_from_proto(
    nonce: &SigningNonce,
) -> Result<FrostSigningNonces, SparkCryptographyError> {
    let hiding_bytes = nonce.hiding.as_slice();
    let binding_bytes = nonce.binding.as_slice();
    let hiding = Nonce::deserialize(hiding_bytes)
        .map_err(|_| SparkCryptographyError::InvalidNonce(InvalidNonceError::InvalidFormat))?;
    let binding = Nonce::deserialize(binding_bytes)
        .map_err(|_| SparkCryptographyError::InvalidNonce(InvalidNonceError::InvalidFormat))?;
    Ok(FrostSigningNonces::from_nonces(hiding, binding))
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_commitments_from_proto(
    commitments: &SigningCommitment,
) -> Result<FrostSigningCommitments, SparkCryptographyError> {
    let hiding_bytes = commitments.hiding.as_slice();
    let binding_bytes = commitments.binding.as_slice();

    let hiding_commitment = NonceCommitment::deserialize(hiding_bytes).map_err(|_| {
        SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::InvalidFormat)
    })?;
    let binding_commitment = NonceCommitment::deserialize(binding_bytes).map_err(|_| {
        SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::InvalidFormat)
    })?;

    Ok(FrostSigningCommitments::new(
        hiding_commitment,
        binding_commitment,
    ))
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_signing_commitments_map_from_proto(
    map: &HashMap<String, SigningCommitment>,
) -> Result<BTreeMap<Identifier, FrostSigningCommitments>, SparkCryptographyError> {
    map.iter()
        .map(
            |(k, v)| -> Result<(Identifier, FrostSigningCommitments), SparkCryptographyError> {
                let identifier = hex_string_to_identifier(k).map_err(|_| {
                    SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError)
                })?;
                let commitments = frost_commitments_from_proto(v)?;
                Ok((identifier, commitments))
            },
        )
        .collect::<Result<BTreeMap<_, _>, SparkCryptographyError>>()
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn verifying_key_from_bytes(bytes: Vec<u8>) -> Result<VerifyingKey, SparkCryptographyError> {
    VerifyingKey::deserialize(bytes.as_slice())
        .map_err(|_| SparkCryptographyError::InvalidKey(InvalidKeyError::InvalidVerifyingKey))
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_build_signin_package(
    signing_commitments: BTreeMap<Identifier, FrostSigningCommitments>,
    message: &[u8],
    signing_participants_groups: Option<Vec<BTreeSet<Identifier>>>,
    adaptor_public_key: &[u8],
) -> SigningPackage {
    let adaptor_public_key = VerifyingKey::deserialize(adaptor_public_key).ok();
    SigningPackage::new_with_adaptor(
        signing_commitments,
        signing_participants_groups,
        message,
        adaptor_public_key,
    )
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_signature_shares_from_proto(
    shares: &HashMap<String, Vec<u8>>,
    user_identifier: Identifier,
    user_signature_share: &Vec<u8>,
) -> Result<BTreeMap<Identifier, SignatureShare>, SparkCryptographyError> {
    let mut shares_map = shares
        .iter()
        .map(
            |(k, v)| -> Result<(Identifier, SignatureShare), SparkCryptographyError> {
                let identifier = hex_string_to_identifier(k).map_err(|_| {
                    SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError)
                })?;
                let share = SignatureShare::deserialize(v).map_err(|_| {
                    SparkCryptographyError::InvalidSignatureShare(
                        InvalidSignatureShareError::InvalidFormat,
                    )
                })?;
                Ok((identifier, share))
            },
        )
        .collect::<Result<BTreeMap<_, _>, SparkCryptographyError>>()?;

    if !user_signature_share.is_empty() {
        shares_map.insert(
            user_identifier,
            SignatureShare::deserialize(user_signature_share).map_err(|_| {
                SparkCryptographyError::InvalidSignatureShare(
                    InvalidSignatureShareError::InvalidFormat,
                )
            })?,
        );
    }
    Ok(shares_map)
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_public_package_from_proto(
    public_shares: &HashMap<String, Vec<u8>>,
    user_identifier: Identifier,
    user_public_key: Vec<u8>,
    verifying_key: VerifyingKey,
) -> Result<PublicKeyPackage, SparkCryptographyError> {
    let mut final_shares = public_shares
        .iter()
        .map(
            |(k, v)| -> Result<(Identifier, VerifyingShare), SparkCryptographyError> {
                let identifier = hex_string_to_identifier(k).map_err(|_| {
                    SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError)
                })?;
                let share = VerifyingShare::deserialize(v).map_err(|_| {
                    SparkCryptographyError::InvalidSignatureShare(
                        InvalidSignatureShareError::InvalidFormat,
                    )
                })?;
                Ok((identifier, share))
            },
        )
        .collect::<Result<BTreeMap<_, _>, SparkCryptographyError>>()?;

    if !user_public_key.is_empty() {
        final_shares.insert(
            user_identifier,
            VerifyingShare::deserialize(user_public_key.as_slice()).map_err(|_| {
                SparkCryptographyError::InvalidSignatureShare(
                    InvalidSignatureShareError::InvalidFormat,
                )
            })?,
        );
    }
    let public_key_package = PublicKeyPackage::new(final_shares, verifying_key);
    Ok(public_key_package)
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_key_package_from_proto(
    key_package: &KeyPackage,
    identifier_override: Option<Identifier>,
    verifying_key: VerifyingKey,
    role: i32,
) -> Result<FrostKeyPackage, SparkCryptographyError> {
    let signing_share =
        SigningShare::deserialize(key_package.secret_share.as_slice()).map_err(|_| {
            SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::InvalidFormat)
        })?;

    let verifying_share = VerifyingShare::deserialize(
        key_package
            .public_shares
            .get(&key_package.identifier)
            .ok_or(SparkCryptographyError::InvalidSignatureShare(
                InvalidSignatureShareError::InvalidFormat,
            ))?
            .as_slice(),
    )
    .map_err(|_| {
        SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::InvalidFormat)
    })?;

    let identifier =
        identifier_override.unwrap_or(hex_string_to_identifier(&key_package.identifier).map_err(
            |_| SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError),
        )?);

    let result = FrostKeyPackage::new(
        identifier,
        signing_share,
        verifying_share,
        verifying_key,
        key_package.min_signers as u16,
    );

    if role == 1 {
        let merkle_root = vec![];
        let result_tweaked = result.clone().tweak(Some(&merkle_root));
        let result_even_y = result.clone().into_even_y(Some(verifying_key.has_even_y()));
        let final_result = FrostKeyPackage::new(
            *result_even_y.identifier(),
            *result_even_y.signing_share(),
            *result_even_y.verifying_share(),
            *result_tweaked.verifying_key(),
            *result_tweaked.min_signers(),
        );
        Ok(final_result)
    } else {
        Ok(result)
    }
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn frost_nonce(req: &FrostNonceRequest) -> Result<FrostNonceResponse, SparkCryptographyError> {
    let mut results = Vec::new();

    for key_package in req.key_packages.iter() {
        let verifying_key = verifying_key_from_bytes(key_package.public_key.clone())?;

        let key_package = frost_key_package_from_proto(key_package, None, verifying_key, 0)
            .map_err(|_| {
                SparkCryptographyError::InvalidKeyPackage(InvalidKeyPackageError::InvalidContent)
            })?;

        let rng = &mut rand::thread_rng();
        let (nonce, commitment) =
            frost_secp256k1_tr_unofficial::round1::commit(key_package.signing_share(), rng);

        let pb_nonce = SigningNonce {
            hiding: nonce.hiding().serialize().to_vec(),
            binding: nonce.binding().serialize().to_vec(),
        };

        let pb_commitment = SigningCommitment {
            hiding: commitment.hiding().serialize().map_err(|_| {
                SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::InvalidFormat)
            })?,
            binding: commitment.binding().serialize().map_err(|_| {
                SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::InvalidFormat)
            })?,
        };

        results.push(SigningNonceResult {
            nonces: Some(pb_nonce),
            commitments: Some(pb_commitment),
        });
    }

    Ok(FrostNonceResponse { results })
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn sign_frost(req: &SignFrostRequest) -> Result<SignFrostResponse, SparkCryptographyError> {
    let mut results = HashMap::new();
    for job in req.signing_jobs.iter() {
        let mut commitments =
            frost_signing_commitments_map_from_proto(&job.commitments).map_err(|_| {
                SparkCryptographyError::InvalidCommitment(
                    InvalidCommitmentError::InvalidCommitmentMap,
                )
            })?;

        let user_identifier =
            Identifier::derive("user".as_bytes()).expect("Failed to derive user identifier");

        let mut signing_participants_groups = Vec::new();
        signing_participants_groups.push(commitments.keys().cloned().collect());

        if let Some(c) = &job.user_commitments {
            let user_commitments = frost_commitments_from_proto(c).map_err(|_| {
                SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::ParseError)
            })?;
            commitments.insert(user_identifier, user_commitments);
            signing_participants_groups.push(BTreeSet::from([user_identifier]));
        };

        let nonce = match &job.nonce {
            Some(nonce) => frost_nonce_from_proto(nonce)
                .map_err(|_| SparkCryptographyError::InvalidNonce(InvalidNonceError::ParseError))?,
            None => {
                return Err(SparkCryptographyError::InvalidNonce(
                    InvalidNonceError::InvalidFormat,
                ))
            }
        };

        let verifying_key = verifying_key_from_bytes(job.verifying_key.clone())?;

        let identifier_override = match req.role {
            0 => None,
            1 => Some(user_identifier),
            _ => {
                return Err(SparkCryptographyError::InvalidRole(
                    InvalidRoleError::UnsupportedRole,
                ))
            }
        };

        let key_package = match &job.key_package {
            Some(key_package) => frost_key_package_from_proto(
                key_package,
                identifier_override,
                verifying_key,
                req.role,
            )
            .map_err(|_| {
                SparkCryptographyError::InvalidKeyPackage(InvalidKeyPackageError::InvalidContent)
            })?,
            None => {
                return Err(SparkCryptographyError::InvalidKeyPackage(
                    InvalidKeyPackageError::MissingKeyPackage,
                ))
            }
        };

        let signing_package = frost_build_signin_package(
            commitments,
            &job.message,
            Some(signing_participants_groups),
            &job.adaptor_public_key,
        );

        let tweak = vec![];
        let signature_share = match req.role {
            0 => frost_secp256k1_tr_unofficial::round2::sign_with_tweak(
                &signing_package,
                &nonce,
                &key_package,
                Some(tweak.as_slice()),
            )
            .map_err(|_| {
                SparkCryptographyError::InvalidSignatureShare(
                    InvalidSignatureShareError::InvalidFormat,
                )
            })?,
            _ => {
                frost_secp256k1_tr_unofficial::round2::sign(&signing_package, &nonce, &key_package)
                    .map_err(|_| {
                        SparkCryptographyError::InvalidSignatureShare(
                            InvalidSignatureShareError::InvalidFormat,
                        )
                    })?
            }
        };

        results.insert(
            job.job_id.clone(),
            SigningResult {
                signature_share: signature_share.serialize().to_vec(),
            },
        );
    }

    Ok(SignFrostResponse { results })
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn aggregate_frost(
    req: &AggregateFrostRequest,
) -> Result<AggregateFrostResponse, SparkCryptographyError> {
    let mut commitments =
        frost_signing_commitments_map_from_proto(&req.commitments).map_err(|_| {
            SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::ParseError)
        })?;

    let mut signing_participants_groups = Vec::new();
    signing_participants_groups.push(commitments.keys().cloned().collect());

    let user_identifier =
        Identifier::derive("user".as_bytes()).expect("Failed to derive user identifier");

    if let Some(c) = &req.user_commitments {
        let user_commitments = frost_commitments_from_proto(c).map_err(|_| {
            SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::ParseError)
        })?;
        commitments.insert(user_identifier, user_commitments);
    };

    let verifying_key = verifying_key_from_bytes(req.verifying_key.clone())?;

    signing_participants_groups.push(BTreeSet::from([user_identifier]));

    let signing_package = frost_build_signin_package(
        commitments,
        &req.message,
        Some(signing_participants_groups),
        &req.adaptor_public_key,
    );

    let signature_shares = frost_signature_shares_from_proto(
        &req.signature_shares,
        user_identifier,
        &req.user_signature_share,
    )
    .map_err(|_| {
        SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::ParseError)
    })?;

    let public_package = frost_public_package_from_proto(
        &req.public_shares,
        user_identifier,
        req.user_public_key.clone(),
        verifying_key,
    )
    .map_err(|_| SparkCryptographyError::FrostOperation(FrostOperationError::ParseError))?;

    let tweak = vec![];

    let signature = frost_secp256k1_tr_unofficial::aggregate_with_tweak(
        &signing_package,
        &signature_shares,
        &public_package,
        Some(&tweak),
    )
    .map_err(|_| SparkCryptographyError::FrostOperation(FrostOperationError::AggregationError))?;

    Ok(AggregateFrostResponse {
        signature: signature.serialize().map_err(|_| {
            SparkCryptographyError::FrostOperation(FrostOperationError::SerializationError)
        })?,
    })
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
pub fn validate_signature_share(
    req: &ValidateSignatureShareRequest,
) -> Result<(), SparkCryptographyError> {
    let identifier = match req.role {
        0 => hex_string_to_identifier(&req.identifier).map_err(|_| {
            SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError)
        })?,
        1 => Identifier::derive("user".as_bytes()).expect("Failed to derive user identifier"),
        _ => {
            return Err(SparkCryptographyError::InvalidRole(
                InvalidRoleError::UnsupportedRole,
            ))
        }
    };

    let signature_share =
        SignatureShare::deserialize(req.signature_share.as_slice()).map_err(|_| {
            SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::InvalidFormat)
        })?;
    let verifying_key = verifying_key_from_bytes(req.verifying_key.clone())?;

    let mut commitments =
        frost_signing_commitments_map_from_proto(&req.commitments).map_err(|_| {
            SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::ParseError)
        })?;

    let user_identifier =
        Identifier::derive("user".as_bytes()).expect("Failed to derive user identifier");

    let mut signing_participants_groups = Vec::new();
    signing_participants_groups.push(commitments.keys().cloned().collect());

    if let Some(c) = &req.user_commitments {
        let user_commitments = frost_commitments_from_proto(c).map_err(|_| {
            SparkCryptographyError::InvalidCommitment(InvalidCommitmentError::ParseError)
        })?;
        commitments.insert(user_identifier, user_commitments);
        signing_participants_groups.push(BTreeSet::from([user_identifier]));
    }

    let public_share = VerifyingShare::deserialize(req.public_share.as_slice()).map_err(|_| {
        SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::InvalidFormat)
    })?;

    let adaptor_key: Vec<u8> = vec![];

    let signing_package = frost_build_signin_package(
        commitments,
        &req.message,
        Some(signing_participants_groups),
        &adaptor_key,
    );

    let dummy_signing_share = SigningShare::deserialize(&[0; 32]).map_err(|_| {
        SparkCryptographyError::InvalidSignatureShare(InvalidSignatureShareError::InvalidFormat)
    })?;

    let result = FrostKeyPackage::new(
        identifier,
        dummy_signing_share,
        public_share,
        verifying_key,
        2,
    );
    let merkle_root = vec![];
    let result_tweaked = result.clone().tweak(Some(&merkle_root));
    let result_even_y = result.clone().into_even_y(Some(verifying_key.has_even_y()));

    let verifying_share = match req.role {
        0 => result_tweaked.verifying_share(),
        1 => result_even_y.verifying_share(),
        _ => {
            return Err(SparkCryptographyError::InvalidRole(
                InvalidRoleError::UnsupportedRole,
            ))
        }
    };

    let verify_identifier = match req.role {
        0 => identifier,
        1 => user_identifier,
        _ => {
            return Err(SparkCryptographyError::InvalidRole(
                InvalidRoleError::UnsupportedRole,
            ))
        }
    };

    frost_secp256k1_tr_unofficial::verify_signature_share(
        verify_identifier,
        verifying_share,
        &signature_share,
        &signing_package,
        result_tweaked.verifying_key(),
    )
    .map_err(|_| {
        SparkCryptographyError::InvalidSignatureShare(
            InvalidSignatureShareError::VerificationFailed,
        )
    })?;

    Ok(())
}

/// Convert a hex string to an identifier.
pub fn hex_string_to_identifier(identifier: &str) -> Result<Identifier, SparkCryptographyError> {
    let id_bytes: [u8; 32] = hex::decode(identifier)
        .map_err(|_| SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::ParseError))?
        .try_into()
        .map_err(|_| {
            SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::InvalidLength)
        })?;
    Identifier::deserialize(&id_bytes).map_err(|_| {
        SparkCryptographyError::InvalidIdentifier(InvalidIdentifierError::InvalidFormat)
    })
}

// Convert an identifier to a hex string.
pub fn identifier_to_hex_string(identifier: &Identifier) -> String {
    hex::encode(identifier.serialize())
}

#[cfg(test)]
mod tests {

    use super::*;

    #[test]
    fn test_frost_nonce_from_proto() {
        // Test valid nonce
        let valid_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![0; 32],
            binding: vec![0; 32],
        });

        // Test invalid nonce with empty hiding
        let empty_hiding_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![],
            binding: vec![0; 32],
        });

        // Test invalid nonce with empty binding
        let empty_binding_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![0; 32],
            binding: vec![],
        });

        // Test invalid nonce with empty hiding and binding
        let empty_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![],
            binding: vec![],
        });

        // Test invalid length nonce
        let invalid_hiding_length_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![0; 31],
            binding: vec![0; 32],
        });

        let invalid_binding_length_result = frost_nonce_from_proto(&SigningNonce {
            hiding: vec![0; 32],
            binding: vec![0; 31],
        });

        // Valid nonce should be ok
        assert!(valid_result.is_ok());

        // Invalid nonces should be err
        assert!(empty_hiding_result.is_err());
        assert!(empty_binding_result.is_err());
        assert!(invalid_hiding_length_result.is_err());
        assert!(invalid_binding_length_result.is_err());
        assert!(empty_result.is_err());
    }

    #[test]
    fn test_frost_commitments_from_proto() {
        // Test valid commitments
        let rng = &mut rand::thread_rng();
        let dummy_signing_share = SigningShare::deserialize(&[0; 32]).unwrap();
        let (_, commitment) =
            frost_secp256k1_tr_unofficial::round1::commit(&dummy_signing_share, rng);

        let valid_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: commitment.hiding().serialize().unwrap(),
            binding: commitment.binding().serialize().unwrap(),
        });

        // Test commitments in non-scalar field
        let nonscalar_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: vec![0; 32],
            binding: vec![0; 32],
        });

        // Test invalid commitments with empty hiding
        let empty_hiding_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: vec![],
            binding: vec![0; 32],
        });

        // Test invalid commitments with empty binding
        let empty_binding_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: vec![0; 32],
            binding: vec![],
        });

        // Test invalid length commitments
        let invalid_hiding_length_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: vec![0; 31],
            binding: vec![0; 32],
        });

        let invalid_binding_length_result = frost_commitments_from_proto(&SigningCommitment {
            hiding: vec![0; 32],
            binding: vec![0; 31],
        });

        // Valid commitments should be ok
        assert!(valid_result.is_ok());

        // Invalid commitments should be err
        assert!(nonscalar_result.is_err());
        assert!(empty_hiding_result.is_err());
        assert!(empty_binding_result.is_err());
        assert!(invalid_hiding_length_result.is_err());
        assert!(invalid_binding_length_result.is_err());
    }

    #[test]
    fn test_verifying_key_from_bytes() {
        // Test valid verifying key
        let rng = &mut rand::thread_rng();
        let dummy_signing_share = SigningShare::deserialize(&[0; 32]).unwrap();
        let (_, commitment) =
            frost_secp256k1_tr_unofficial::round1::commit(&dummy_signing_share, rng);

        let valid_result = verifying_key_from_bytes(commitment.hiding().serialize().unwrap());

        // Test invalid verifying key
        let invalid_result = verifying_key_from_bytes(vec![0; 32]);

        // Test invalid length verifying key
        let invalid_length_result = verifying_key_from_bytes(vec![0; 31]);

        // Test empty verifying key
        let empty_result = verifying_key_from_bytes(vec![]);

        assert!(valid_result.is_ok());
        assert!(invalid_result.is_err());
        assert!(invalid_length_result.is_err());
        assert!(empty_result.is_err());
    }
}