sp1-recursion-circuit 6.0.0

Recursion circuit for SP1 proof aggregation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
#![cfg(test)]
use std::{iter, marker::PhantomData};

use crate::{
    basefold::tcs::{RecursiveMerkleTreeTcs, RecursiveTensorCsOpening},
    challenger::{CanObserveVariable, CanSampleBitsVariable, FieldChallengerVariable},
    hash::FieldHasherVariable,
    sumcheck::{evaluate_mle_ext, evaluate_mle_ext_batch},
    symbolic::IntoSymbolic,
    witness::Witnessable,
    CircuitConfig, SP1FieldConfigVariable,
};
use slop_algebra::{AbstractField, UnivariatePolynomial};
use slop_challenger::{GrindingChallenger, IopCtx};
use slop_commit::Rounds;
use slop_merkle_tree::MerkleTreeOpeningAndProof;
use slop_multilinear::{Mle, Point};
use slop_whir::{map_to_pow, ParsedCommitment, SumcheckPoly, WhirProof, WhirProofShape};
use sp1_primitives::{SP1ExtensionField, SP1Field};
use sp1_recursion_compiler::{
    circuit::CircuitV2Builder,
    ir::{Builder, Ext, ExtensionOperand, Felt, SymbolicExt},
};

#[derive(Clone)]
pub struct RecursiveWhirVerifier<C: CircuitConfig, SC: SP1FieldConfigVariable<C>> {
    config: WhirProofShape<SP1Field>,
    _config: PhantomData<(C, SC)>,
}

impl<C: CircuitConfig> IntoSymbolic<C> for SumcheckPoly<Ext<SP1Field, SP1ExtensionField>> {
    type Output = SumcheckPoly<SymbolicExt<SP1Field, SP1ExtensionField>>;

    fn as_symbolic(&self) -> Self::Output {
        SumcheckPoly(self.0.map(SymbolicExt::from))
    }
}

#[derive(Clone)]
pub struct RecursiveParsedCommitment<C: CircuitConfig, SC: FieldHasherVariable<C>> {
    pub(crate) commitment: Rounds<<SC as FieldHasherVariable<C>>::DigestVariable>,
    pub(crate) ood_points: Vec<Point<Ext<SP1Field, SP1ExtensionField>>>,
    pub(crate) ood_answers: Vec<Ext<SP1Field, SP1ExtensionField>>,
}

pub type RecursiveProverMessage = (SumcheckPoly<Ext<SP1Field, SP1ExtensionField>>, Felt<SP1Field>);
pub type MerkleProofRounds<C, SC> =
    Rounds<RecursiveTensorCsOpening<<SC as FieldHasherVariable<C>>::DigestVariable>>;

type PointAndEval<F> = (Point<F>, F);
pub struct RecursiveWhirProof<C, SC>
where
    C: CircuitConfig,
    SC: FieldHasherVariable<C>,
    <SC as FieldHasherVariable<C>>::DigestVariable: Copy,
{
    // First sumcheck
    pub initial_sumcheck_polynomials: Vec<RecursiveProverMessage>,

    // For internal rounds
    pub commitments: Vec<RecursiveParsedCommitment<C, SC>>,
    pub merkle_proofs: Vec<MerkleProofRounds<C, SC>>,
    pub query_proof_of_works: Vec<Felt<SP1Field>>,
    pub sumcheck_polynomials: Vec<Vec<RecursiveProverMessage>>,

    // Final round
    pub final_polynomial: Vec<Ext<SP1Field, SP1ExtensionField>>,
    pub final_merkle_proof:
        RecursiveTensorCsOpening<<SC as FieldHasherVariable<C>>::DigestVariable>,
    pub final_sumcheck_polynomials: Vec<RecursiveProverMessage>,
    pub final_pow: Felt<SP1Field>,
    pub _config: PhantomData<C>,
}

impl<C: CircuitConfig, SC: SP1FieldConfigVariable<C>> RecursiveWhirVerifier<C, SC> {
    pub(crate) fn observe_commitment(
        &self,
        builder: &mut Builder<C>,
        commitments: &Rounds<<SC as FieldHasherVariable<C>>::DigestVariable>,
        challenger: &mut SC::FriChallengerVariable,
    ) {
        for round_commitment in commitments.iter() {
            challenger.observe(builder, *round_commitment);
        }
    }

    pub(crate) fn verify_whir(
        &self,
        builder: &mut Builder<C>,
        claim: Ext<SP1Field, SP1ExtensionField>,
        num_variables: usize,
        proof: &RecursiveWhirProof<C, SC>,
        challenger: &mut SC::FriChallengerVariable,
    ) -> PointAndEval<Ext<SP1Field, SP1ExtensionField>> {
        let n_rounds = self.config.round_parameters.len();

        let ood_points: Vec<Point<Ext<SP1Field, SP1ExtensionField>>> =
            (0..self.config.starting_ood_samples)
                .map(|_| {
                    (0..num_variables)
                        .map(|_| challenger.sample_ext(builder))
                        .collect::<Vec<Ext<SP1Field, SP1ExtensionField>>>()
                        .into()
                })
                .collect();

        let commitment = &proof.commitments[0];

        for (ood_point, commitment_ood_point) in ood_points.iter().zip(commitment.ood_points.iter())
        {
            for (a, b) in ood_point.iter().zip(commitment_ood_point.iter()) {
                builder.assert_ext_eq(*a, *b);
            }
        }

        challenger.observe_ext_element_slice(builder, &commitment.ood_answers);

        // Batch the initial claim with the OOD claims of the commitment
        let claim_batching_randomness: Ext<SP1Field, SP1ExtensionField> =
            challenger.sample_ext(builder);
        let claimed_sum: Ext<SP1Field, SP1ExtensionField> = builder.eval(
            IntoSymbolic::<C>::as_symbolic(&claim_batching_randomness)
                .powers()
                .zip(iter::once(&claim).chain(&commitment.ood_answers))
                .map(|(r, &v)| v * r)
                .sum::<SymbolicExt<_, _>>(),
        );

        // Initialize the collection of points at which we will need to compute the monomial basis
        // polynomial evaluations.
        let mut final_evaluation_points = vec![commitment.ood_points.clone()];

        // Check the initial sumcheck.
        let (mut folding_randomness, mut claimed_sum) = self.verify_whir_sumcheck(
            builder,
            &proof.initial_sumcheck_polynomials,
            claimed_sum,
            num_variables - self.config.starting_interleaved_log_height,
            &self.config.starting_folding_pow_bits,
            challenger,
        );

        // This contains all the sumcheck randomnesses (these are the alphas)
        let mut concatenated_folding_randomness = folding_randomness.clone();

        // This contains all the batching randomness for sumcheck (these are the epsilons) for
        // batching in- and out-of-domain claims from round to round.
        let mut all_claim_batching_randomness = vec![claim_batching_randomness];

        // This is relative to the previous commitment (i.e. prev_commitment has a domain size of
        // this size)
        let mut domain_size =
            self.config.starting_interleaved_log_height + self.config.starting_log_inv_rate;
        let mut generator: Felt<SP1Field> = builder.constant(self.config.domain_generator);
        let mut prev_commitment = commitment;

        let mut prev_folding_factor = num_variables - self.config.starting_interleaved_log_height;
        let mut num_variables = num_variables;

        for round_index in 0..n_rounds {
            let round_params = &self.config.round_parameters[round_index];
            let new_commitment = &proof.commitments[round_index];

            // Observe the round commitments
            for round_commitment in new_commitment.commitment.iter() {
                challenger.observe(builder, *round_commitment);
            }

            // Squeeze the ood points
            let ood_points: Vec<Point<Ext<SP1Field, SP1ExtensionField>>> = (0..round_params
                .ood_samples)
                .map(|_| {
                    (0..num_variables)
                        .map(|_| challenger.sample_ext(builder))
                        .collect::<Vec<Ext<SP1Field, SP1ExtensionField>>>()
                        .into()
                })
                .collect();

            for (ood_point, commitment_ood_point) in
                ood_points.iter().zip(&new_commitment.ood_points)
            {
                for (ood_elem, commitment_ood_elem) in
                    ood_point.iter().zip(commitment_ood_point.iter())
                {
                    builder.assert_ext_eq(*ood_elem, *commitment_ood_elem);
                }
            }

            // Absorb the OOD answers
            challenger.observe_ext_element_slice(builder, &new_commitment.ood_answers);

            // Squeeze the STIR queries
            let id_query_indices = (0..round_params.num_queries)
                .map(|_| challenger.sample_bits(builder, domain_size))
                .collect::<Vec<_>>();
            let id_query_values: Vec<Felt<SP1Field>> = id_query_indices
                .iter()
                .map(|val| C::exp_reverse_bits(builder, generator, val.clone()))
                .collect();
            let claim_batching_randomness: Ext<SP1Field, SP1ExtensionField> =
                challenger.sample_ext(builder);

            challenger.check_witness(
                builder,
                round_params.queries_pow_bits.ceil() as usize,
                proof.query_proof_of_works[round_index],
            );

            let merkle_proofs = &proof.merkle_proofs[round_index];

            for (merkle_proof, commitment) in
                merkle_proofs.iter().zip(prev_commitment.commitment.iter())
            {
                RecursiveMerkleTreeTcs::<C, SC>::verify_tensor_openings(
                    builder,
                    commitment,
                    &id_query_indices,
                    merkle_proof,
                );
            }

            // Chunk the Merkle openings into chunks of size `1<<prev_folding_factor`
            // so that the verifier can induce in-domain evaluation claims about the next codeword.
            // Except in the first round, the opened values in the Merkle proof are secretly
            // extension field elements, so we have to reinterpret them as such. (The
            // Merkle tree API commits to and opens only base-field values.)
            let merkle_read_values: Vec<Mle<Ext<SP1Field, SP1ExtensionField>>> = if round_index != 0
            {
                merkle_proofs
                    .iter()
                    .flat_map(|merkle_proof| {
                        merkle_proof
                            .values
                            .clone()
                            .into_buffer()
                            .into_vec()
                            .chunks_exact(sp1_recursion_executor::D)
                            .map(|felt_chunk| C::felt2ext(builder, felt_chunk.try_into().unwrap()))
                            .collect::<Vec<_>>()
                            .chunks_exact(1 << prev_folding_factor)
                            .map(|v| Mle::new(v.to_vec().into()))
                            .collect::<Vec<_>>()
                    })
                    .collect()
            } else {
                merkle_proofs
                    .iter()
                    .flat_map(|merkle_proof| {
                        merkle_proof
                            .values
                            .clone()
                            .into_buffer()
                            .to_vec()
                            .into_iter()
                            .map(|f| {
                                let e: SymbolicExt<SP1Field, SP1ExtensionField> = f.into();
                                builder.eval(e)
                            })
                            .collect::<Vec<_>>()
                            .chunks_exact(1 << prev_folding_factor)
                            .map(|v| Mle::new(v.to_vec().into()))
                            .collect::<Vec<_>>()
                    })
                    .collect()
            };
            // Compute the STIR values by reading the merkle values and folding across the column.
            let stir_values: Vec<Ext<SP1Field, SP1ExtensionField>> =
                evaluate_mle_ext_batch(builder, merkle_read_values, folding_randomness.clone())
                    .iter()
                    .map(|eval| eval[0])
                    .collect();

            if round_index == 0 {
                builder.cycle_tracker_v2_enter("first round stir values");
            }
            if round_index == 0 {
                builder.cycle_tracker_v2_exit();
            }

            // Update the claimed sum using the STIR values and the OOD answers.
            claimed_sum = builder.eval(
                IntoSymbolic::<C>::as_symbolic(&claim_batching_randomness)
                    .powers()
                    .zip(
                        iter::once(&claimed_sum)
                            .chain(&new_commitment.ood_answers)
                            .chain(&stir_values),
                    )
                    .map(|(r, &v)| r * v)
                    .sum::<SymbolicExt<SP1Field, SP1ExtensionField>>(),
            );

            (folding_randomness, claimed_sum) = self.verify_whir_sumcheck(
                builder,
                &proof.sumcheck_polynomials[round_index],
                claimed_sum,
                round_params.folding_factor,
                &round_params.pow_bits,
                challenger,
            );

            // Prepend the folding randomness from the sumcheck into the combined folding
            // randomness.
            concatenated_folding_randomness = folding_randomness
                .iter()
                .cloned()
                .chain(concatenated_folding_randomness.iter().cloned())
                .collect();

            all_claim_batching_randomness.push(claim_batching_randomness);

            // Add both the in-domain and out-of-domain claims to the set of final evaluation
            // points.
            final_evaluation_points.push(
                [
                    ood_points.clone(),
                    id_query_values
                        .into_iter()
                        .map(|point| {
                            map_to_pow(IntoSymbolic::<C>::as_symbolic(&point), num_variables)
                                .iter()
                                .cloned()
                                .map(|el| {
                                    let ext = el.to_operand().symbolic();
                                    builder.eval(ext)
                                })
                                .collect()
                        })
                        .collect(),
                ]
                .concat(),
            );

            domain_size = round_params.evaluation_domain_log_size;
            prev_commitment = new_commitment;
            prev_folding_factor = round_params.folding_factor;
            generator = builder.eval(IntoSymbolic::<C>::as_symbolic(&generator).square());
            num_variables -= round_params.folding_factor;
        }

        // Now, we want to verify the final evaluations
        challenger.observe_ext_element_slice(builder, &proof.final_polynomial);

        let final_poly = proof.final_polynomial.clone();
        let final_poly_uv = UnivariatePolynomial::new(IntoSymbolic::<C>::as_symbolic(&final_poly));

        let final_id_indices = (0..self.config.final_queries)
            .map(|_| challenger.sample_bits(builder, domain_size))
            .collect::<Vec<_>>();
        let final_id_values: Vec<Felt<SP1Field>> = final_id_indices
            .iter()
            .map(|val| <C as CircuitConfig>::exp_reverse_bits(builder, generator, val.clone()))
            .collect();

        RecursiveMerkleTreeTcs::<C, SC>::verify_tensor_openings(
            builder,
            &prev_commitment.commitment[0],
            &final_id_indices,
            &proof.final_merkle_proof,
        );

        let final_merkle_read_values: Vec<Mle<Ext<SP1Field, SP1ExtensionField>>> = proof
            .final_merkle_proof
            .values
            .clone()
            .into_buffer()
            .into_vec()
            .chunks_exact(sp1_recursion_executor::D)
            .map(|felt_slice| {
                <C as CircuitConfig>::felt2ext(builder, felt_slice.try_into().unwrap())
            })
            .collect::<Vec<_>>()
            .chunks_exact(1 << prev_folding_factor)
            .map(|v| Mle::new(v.to_vec().into()))
            .collect();

        let final_stir_values: Vec<Ext<_, _>> =
            evaluate_mle_ext_batch(builder, final_merkle_read_values, folding_randomness.clone())
                .iter()
                .map(|eval| eval[0])
                .collect();

        for (final_stir_val, final_id_val) in final_stir_values.iter().zip(final_id_values.iter()) {
            builder.assert_ext_eq(
                *final_stir_val,
                final_poly_uv.eval_at_point((*final_id_val).into()),
            );
        }

        challenger.check_witness(
            builder,
            self.config.final_pow_bits.ceil() as usize,
            proof.final_pow,
        );

        (folding_randomness, claimed_sum) = self.verify_whir_sumcheck(
            builder,
            &proof.final_sumcheck_polynomials,
            claimed_sum,
            self.config.final_poly_log_degree,
            &self.config.final_folding_pow_bits,
            challenger,
        );

        concatenated_folding_randomness = folding_randomness
            .iter()
            .cloned()
            .chain(concatenated_folding_randomness.iter().cloned())
            .collect();

        let f: Ext<_, _> = evaluate_mle_ext(
            builder,
            proof.final_polynomial.clone().into(),
            folding_randomness.clone(),
        )[0];

        builder.cycle_tracker_v2_enter("compute summand");
        let mut summand = SymbolicExt::<SP1Field, SP1ExtensionField>::zero();
        for (i, eval_points) in final_evaluation_points.into_iter().enumerate() {
            let combination_randomness = all_claim_batching_randomness[i];
            let len = eval_points[0].len();
            let eval_randomness: Point<Ext<SP1Field, SP1ExtensionField>> =
                concatenated_folding_randomness.split_at(len).0;

            let sum_modification = IntoSymbolic::<C>::as_symbolic(&combination_randomness)
                .powers()
                .skip(1)
                .zip(eval_points)
                .map(|(r, point)| {
                    r * Mle::<SymbolicExt<SP1Field, SP1ExtensionField>>::full_monomial_basis_eq(
                        &IntoSymbolic::<C>::as_symbolic(&point),
                        &IntoSymbolic::<C>::as_symbolic(&eval_randomness),
                    )
                })
                .sum::<SymbolicExt<SP1Field, SP1ExtensionField>>();

            summand += sum_modification;
        }

        let summand: Ext<_, _> = builder.eval(summand);

        builder.cycle_tracker_v2_exit();

        // This is the claimed value of the query vector. It is trusted and assumed to be easily
        // computable by the verifier.
        let claimed_value = claimed_sum / f - summand;

        let claimed_value = builder.eval(claimed_value);
        (concatenated_folding_randomness, claimed_value)
    }

    pub(crate) fn verify_whir_sumcheck(
        &self,
        builder: &mut Builder<C>,
        sumcheck_polynomials: &[RecursiveProverMessage],
        mut claimed_sum: Ext<SP1Field, SP1ExtensionField>,
        rounds: usize,
        pow_bits: &[f64],
        challenger: &mut SC::FriChallengerVariable,
    ) -> PointAndEval<Ext<SP1Field, SP1ExtensionField>> {
        let mut randomness = Vec::with_capacity(rounds);
        for i in 0..rounds {
            let (sumcheck_poly, pow_witness) = &sumcheck_polynomials[i];
            challenger.observe_ext_element_slice(builder, &sumcheck_poly.0);

            let sum = IntoSymbolic::<C>::as_symbolic(sumcheck_poly).sum_over_hypercube();

            builder.assert_ext_eq(claimed_sum, sum);

            let folding_randomness_single: Ext<SP1Field, SP1ExtensionField> =
                challenger.sample_ext(builder);
            randomness.push(folding_randomness_single);

            challenger.check_witness(builder, pow_bits[i].ceil() as usize, *pow_witness);
            claimed_sum = builder.eval(
                IntoSymbolic::<C>::as_symbolic(sumcheck_poly)
                    .evaluate_at_point(IntoSymbolic::<C>::as_symbolic(&folding_randomness_single)),
            );
        }

        randomness.reverse();
        (randomness.into(), claimed_sum)
    }
}

impl<C: CircuitConfig, GC: IopCtx> Witnessable<C> for ParsedCommitment<GC>
where
    GC: SP1FieldConfigVariable<C>,
    <GC as IopCtx>::Digest:
        Witnessable<C, WitnessVariable = <GC as FieldHasherVariable<C>>::DigestVariable>,
    GC::F: Witnessable<C, WitnessVariable = Felt<SP1Field>>,
    GC::EF: Witnessable<C, WitnessVariable = Ext<SP1Field, SP1ExtensionField>>,
{
    type WitnessVariable = RecursiveParsedCommitment<C, GC>;

    fn read(&self, builder: &mut Builder<C>) -> Self::WitnessVariable {
        let commitment_variable = self.commitment.read(builder);
        let ood_point_variable = self.ood_points.iter().map(|point| point.read(builder)).collect();
        let ood_answer_variable =
            self.ood_answers.iter().map(|answer| answer.read(builder)).collect();
        RecursiveParsedCommitment {
            commitment: commitment_variable,
            ood_points: ood_point_variable,
            ood_answers: ood_answer_variable,
        }
    }

    fn write(&self, witness: &mut impl crate::witness::WitnessWriter<C>) {
        self.commitment.write(witness);
        for point in &self.ood_points {
            point.write(witness);
        }
        for answer in &self.ood_answers {
            answer.write(witness);
        }
    }
}

impl<C: CircuitConfig> Witnessable<C> for SumcheckPoly<SP1ExtensionField> {
    type WitnessVariable = SumcheckPoly<Ext<SP1Field, SP1ExtensionField>>;

    fn read(&self, builder: &mut Builder<C>) -> Self::WitnessVariable {
        let coeffs = std::array::from_fn(|i| self.0[i].read(builder));
        SumcheckPoly(coeffs)
    }

    fn write(&self, witness: &mut impl crate::witness::WitnessWriter<C>) {
        for coeff in &self.0 {
            coeff.write(witness);
        }
    }
}

type DigestVariable<SC, C> = <SC as FieldHasherVariable<C>>::DigestVariable;

impl<
        GC: IopCtx<F = SP1Field, EF = SP1ExtensionField> + SP1FieldConfigVariable<C>,
        C: CircuitConfig,
    > Witnessable<C> for WhirProof<GC>
where
    <GC as IopCtx>::Digest:
        Witnessable<C, WitnessVariable = <GC as FieldHasherVariable<C>>::DigestVariable>,
    <GC::Challenger as GrindingChallenger>::Witness:
        Witnessable<C, WitnessVariable = Felt<SP1Field>>,
    GC::FriChallengerVariable:
        CanObserveVariable<C, <GC as FieldHasherVariable<C>>::DigestVariable>,
    <GC as FieldHasherVariable<C>>::DigestVariable: Copy,
    MerkleTreeOpeningAndProof<GC>:
        Witnessable<C, WitnessVariable = RecursiveTensorCsOpening<DigestVariable<GC, C>>>,
    SP1Field: Witnessable<C, WitnessVariable = Felt<SP1Field>>,
    SP1ExtensionField: Witnessable<C, WitnessVariable = Ext<SP1Field, SP1ExtensionField>>,
{
    type WitnessVariable = RecursiveWhirProof<C, GC>;

    fn read(&self, builder: &mut Builder<C>) -> Self::WitnessVariable {
        let initial_sumcheck_polynomials = self
            .initial_sumcheck_polynomials
            .iter()
            .map(|(poly, pow)| (poly.read(builder), pow.read(builder)))
            .collect();
        let commitments = self.commitments.iter().map(|comm| comm.read(builder)).collect();
        let merkle_proofs = self.merkle_proofs.iter().map(|proof| proof.read(builder)).collect();
        let query_proof_of_works =
            self.query_proofs_of_work.iter().map(|pow| pow.read(builder)).collect();
        let sumcheck_polynomials = self
            .sumcheck_polynomials
            .iter()
            .map(|round| {
                round.iter().map(|(poly, pow)| (poly.read(builder), pow.read(builder))).collect()
            })
            .collect();
        let final_polynomial = self.final_polynomial.read(builder);
        let final_merkle_proof = self.final_merkle_opening_and_proof.read(builder);
        let final_sumcheck_polynomials = self
            .final_sumcheck_polynomials
            .iter()
            .map(|(poly, pow)| (poly.read(builder), pow.read(builder)))
            .collect();
        let final_pow = self.final_pow.read(builder);
        RecursiveWhirProof {
            initial_sumcheck_polynomials,
            commitments,
            merkle_proofs,
            query_proof_of_works,
            sumcheck_polynomials,
            final_polynomial,
            final_merkle_proof,
            final_sumcheck_polynomials,
            final_pow,
            _config: PhantomData,
        }
    }

    fn write(&self, witness: &mut impl crate::witness::WitnessWriter<C>) {
        for (poly, pow) in &self.initial_sumcheck_polynomials {
            poly.write(witness);
            pow.write(witness);
        }
        for comm in &self.commitments {
            comm.write(witness);
        }
        for proof in &self.merkle_proofs {
            proof.write(witness);
        }
        for pow in &self.query_proofs_of_work {
            pow.write(witness);
        }
        for round in &self.sumcheck_polynomials {
            for (poly, pow) in round {
                poly.write(witness);
                pow.write(witness);
            }
        }
        self.final_polynomial.write(witness);
        self.final_merkle_opening_and_proof.write(witness);
        for (poly, pow) in &self.final_sumcheck_polynomials {
            poly.write(witness);
            pow.write(witness);
        }
        self.final_pow.write(witness);
    }
}

#[cfg(test)]
mod tests {
    use rand::SeedableRng;
    use slop_basefold::FriConfig;
    use slop_challenger::IopCtx;
    use slop_dft::p3::Radix2DitParallel;
    use slop_merkle_tree::{FieldMerkleTreeProver, MerkleTreeTcs, Poseidon2KoalaBear16Prover};
    use slop_whir::{Prover, Verifier};
    use sp1_core_machine::utils::setup_logger;
    use sp1_hypercube::{prover::simple_prover, MachineProof, MachineVerifier, ShardVerifier};
    use sp1_primitives::SP1GlobalContext;
    use sp1_recursion_compiler::{circuit::AsmConfig, config::InnerConfig};
    use sp1_recursion_machine::RecursionAir;
    use std::{collections::VecDeque, marker::PhantomData, sync::Arc};

    use slop_algebra::extension::BinomialExtensionField;
    use sp1_primitives::SP1DiffusionMatrix;

    use crate::{challenger::DuplexChallengerVariable, witness::Witnessable};

    use super::*;

    use slop_multilinear::MultilinearPcsProver;

    use slop_multilinear::Mle;
    use sp1_hypercube::inner_perm;
    use sp1_recursion_compiler::circuit::{AsmBuilder, AsmCompiler};
    use sp1_recursion_executor::Executor;

    use sp1_primitives::SP1Field;
    type F = SP1Field;
    type EF = BinomialExtensionField<SP1Field, 4>;

    #[tokio::test]
    #[ignore = "todo: fix to work with the multi-round, padded version of WHIR"]
    async fn test_whir() {
        setup_logger();
        let config = WhirProofShape::default_whir_config();
        type C = InnerConfig;
        type SC = SP1GlobalContext;

        let mut rng = rand::rngs::StdRng::seed_from_u64(42);

        let num_variables = 16;

        let mut challenger_prover = SC::default_challenger();
        let mut challenger_verifier = SC::default_challenger();

        let merkle_prover: Poseidon2KoalaBear16Prover = FieldMerkleTreeProver::default();

        let prover = Prover::<_, _, _>::new(Radix2DitParallel, merkle_prover, config.clone());
        let merkle_verifier = MerkleTreeTcs::default();
        let verifier = Verifier::<SC>::new(merkle_verifier, config.clone(), 1);
        let polynomial: Mle<SP1Field> = Mle::rand(&mut rng, 1, num_variables);
        let query_vector: Mle<EF> = Mle::<EF>::rand(&mut rng, 1, num_variables);

        let claim: EF = polynomial
            .hypercube_iter()
            .zip(query_vector.hypercube_iter())
            .map(|(a, b)| b[0] * a[0])
            .sum();

        tracing::debug!("claimed: {:?}", claim);

        let (commitment, prover_data, _) =
            prover.commit_multilinear(vec![polynomial].into()).unwrap();

        let proof = prover.prove(
            query_vector,
            vec![prover_data].into_iter().collect(),
            claim,
            &mut challenger_prover,
            &config,
        );

        verifier.observe_commitment(&[commitment], &mut challenger_verifier).unwrap();

        let (point, value) = verifier
            .verify(
                &[commitment],
                &[],
                num_variables as usize,
                claim,
                &proof,
                &mut challenger_verifier,
            )
            .unwrap();

        let mut builder = AsmBuilder::default();
        let mut witness_stream = Vec::new();
        let mut challenger_variable = DuplexChallengerVariable::new(&mut builder);

        Witnessable::<AsmConfig>::write(&commitment, &mut witness_stream);
        let commitment = commitment.read(&mut builder);

        let recursive_verifier =
            RecursiveWhirVerifier::<C, SC> { config: config.clone(), _config: PhantomData };

        recursive_verifier.observe_commitment(
            &mut builder,
            &[commitment].into_iter().collect(),
            &mut challenger_variable,
        );

        Witnessable::<AsmConfig>::write(&point, &mut witness_stream);
        let point = point.read(&mut builder);

        Witnessable::<AsmConfig>::write(&value, &mut witness_stream);
        let value = value.read(&mut builder);

        Witnessable::<AsmConfig>::write(&proof, &mut witness_stream);
        let proof = proof.read(&mut builder);

        Witnessable::<AsmConfig>::write(&claim, &mut witness_stream);
        let eval_claim = claim.read(&mut builder);

        let (point_var, claim_var) = recursive_verifier.verify_whir(
            &mut builder,
            eval_claim,
            num_variables as usize,
            &proof,
            &mut challenger_variable,
        );

        for (coord, coord_var) in point_var.iter().zip(point.iter()) {
            builder.assert_ext_eq(*coord, *coord_var);
        }

        builder.assert_ext_eq(claim_var, value);

        let mut buf = VecDeque::<u8>::new();
        let block = builder.into_root_block();
        let mut compiler = AsmCompiler::default();
        let program = Arc::new(compiler.compile_inner(block).validate().unwrap());
        let mut executor =
            Executor::<F, EF, SP1DiffusionMatrix>::new(program.clone(), inner_perm());
        executor.witness_stream = witness_stream.into();
        executor.debug_stdout = Box::new(&mut buf);
        executor.run().unwrap();

        type A = RecursionAir<SP1Field, 3, 2>;
        let machine = A::compress_machine();
        let log_stacking_height = 22;
        let max_log_row_count = 21;
        let verifier = ShardVerifier::from_basefold_parameters(
            FriConfig::default_fri_config(),
            log_stacking_height,
            max_log_row_count,
            machine,
        );
        let prover = simple_prover(verifier.clone());

        let (pk, vk) = prover.setup(program).await;

        let records = vec![executor.record.clone()];

        let pk = unsafe { pk.into_inner() };
        let mut shard_proofs = Vec::with_capacity(records.len());
        for record in records {
            let proof = prover.prove_shard(pk.clone(), record).await;
            shard_proofs.push(proof);
        }

        assert!(shard_proofs.len() == 1);

        let proof = MachineProof { shard_proofs };

        let machine_verifier = MachineVerifier::new(verifier);
        tracing::debug_span!("verify the proof")
            .in_scope(|| machine_verifier.verify(&vk, &proof))
            .unwrap();
    }
}