1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
use NUM_SYSCALL_INSTR_COLS;
use BaseAir;
;
// #[cfg(test)]
// mod tests {
// use std::borrow::BorrowMut;
// use sp1_primitives::SP1Field;
// use slop_algebra::AbstractField;
// use slop_matrix::dense::RowMajorMatrix;
// use sp1_core_executor::{ExecutionRecord, Instruction, Opcode, Program};
// use sp1_hypercube::{
// air::MachineAir, koala_bear_poseidon2::SP1InnerPcs, chip_name, CpuProver,
// MachineProver, Val,
// };
// use sp1_zkvm::syscalls::{COMMIT, COMMIT_DEFERRED_PROOFS, HALT, SHA_EXTEND};
// use crate::{
// cpu::{columns::CpuCols, CpuChip},
// io::SP1Stdin,
// riscv::RiscvAir,
// syscall::instructions::{columns::SyscallInstrColumns, SyscallInstrsChip},
// utils::run_malicious_test,
// };
// #[test]
// fn test_malicious_next_pc() {
// struct TestCase {
// program: Vec<Instruction>,
// incorrect_next_pc: u64,
// }
// let test_cases = vec![
// TestCase {
// program: vec![
// Instruction::new(Opcode::ADD, 5, 0, HALT, false, true), // Set the syscall
// code in register x5. Instruction::new(Opcode::ECALL, 5, 10, 11, false,
// false), // Call the syscall. Instruction::new(Opcode::ADD, 30, 0, 100, false,
// true), ],
// incorrect_next_pc: 8, // The correct next_pc is 0.
// },
// TestCase {
// program: vec![
// Instruction::new(Opcode::ADD, 5, 0, SHA_EXTEND, false, true), // Set the
// syscall code in register x5. Instruction::new(Opcode::ADD, 10, 0, 40, false,
// true), // Set the syscall arg1 to 40. Instruction::new(Opcode::ECALL, 5, 10,
// 11, false, false), // Call the syscall. Instruction::new(Opcode::ADD, 30, 0,
// 100, false, true), ],
// incorrect_next_pc: 0, // The correct next_pc is 12.
// },
// ];
// for test_case in test_cases {
// let program = Program::new(test_case.program, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// move |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// // Create a malicious record where the next pc is set to the incorrect value.
// let mut malicious_record = record.clone();
// // There can be multiple shards for programs with syscalls, so need to figure
// out which // record is for a CPU shard.
// if !malicious_record.cpu_events.is_empty() {
// malicious_record.syscall_events[0].next_pc =
// test_case.incorrect_next_pc; }
// prover.generate_traces(&malicious_record)
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// }
// }
// #[test]
// fn test_malicious_extra_cycles() {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 5, 0, SHA_EXTEND, false, true), // Set the syscall code
// in register x5. Instruction::new(Opcode::ADD, 10, 0, 40, false, true), // Set the
// syscall arg1 to 40. Instruction::new(Opcode::ECALL, 5, 10, 11, false, false), // Call
// the syscall. Instruction::new(Opcode::ADD, 30, 20, 100, true, true),
// ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// let mut traces = prover.generate_traces(record);
// let cpu_chip_name = chip_name!(CpuChip, SP1Field);
// let syscall_chip_name = chip_name!(SyscallInstrsChip, SP1Field);
// for (chip_name, trace) in traces.iter_mut() {
// if *chip_name == cpu_chip_name {
// let third_row = trace.row_mut(2);
// let third_row: &mut CpuCols<SP1Field> = third_row.borrow_mut();
// assert!(third_row.is_syscall == SP1Field::one());
// third_row.num_extra_cycles = SP1Field::from_canonical_usize(8);
// // Correct value is 48.
// let fourth_row = trace.row_mut(3);
// let fourth_row: &mut CpuCols<SP1Field> = fourth_row.borrow_mut();
// fourth_row.clk_16bit_limb = SP1Field::from_canonical_usize(20);
// // Correct value is 60.
// }
// if *chip_name == syscall_chip_name {
// let first_row = trace.row_mut(0);
// let first_row: &mut SyscallInstrColumns<SP1Field> =
// first_row.borrow_mut(); first_row.num_extra_cycles =
// SP1Field::from_canonical_usize(4); // Correct value is 48.
// }
// }
// traces
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// }
// #[test]
// fn test_malicious_commit() {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 5, 0, COMMIT, false, true), // Set the syscall code in
// register x5. Instruction::new(Opcode::ADD, 10, 0, 0, false, false), // Set the
// syscall code in register x5. Instruction::new(Opcode::ADD, 11, 0, 40, false, true),
// // Set the syscall arg1 to 40. Instruction::new(Opcode::ECALL, 5, 10, 11, false,
// false), // Call the syscall. ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// record.public_values.committed_value_digest[0] = 10; // The correct value is 40.
// prover.generate_traces(record)
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// }
// #[test]
// fn test_malicious_commit_deferred() {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 5, 0, COMMIT_DEFERRED_PROOFS, false, true), // Set the
// syscall code in register x5. Instruction::new(Opcode::ADD, 10, 0, 0, false, false),
// // Set the syscall code in register x5. Instruction::new(Opcode::ADD, 11, 0, 40,
// false, true), // Set the syscall arg1 to 40. Instruction::new(Opcode::ECALL, 5, 10,
// 11, false, false), // Call the syscall. ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// record.public_values.deferred_proofs_digest[0] = 10; // The correct value is 40.
// prover.generate_traces(record)
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// }
// }