1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
// #[cfg(test)]
// mod tests {
// use std::borrow::BorrowMut;
// use sp1_primitives::SP1Field;
// use slop_algebra::AbstractField;
// use slop_matrix::dense::RowMajorMatrix;
// use sp1_core_executor::{
// events::MemoryRecordEnum, ExecutionRecord, Instruction, Opcode, Program,
// };
// use sp1_hypercube::{
// air::MachineAir, koala_bear_poseidon2::SP1InnerPcs, chip_name, CpuProver,
// MachineProver, Val,
// };
// use crate::{
// io::SP1Stdin,
// memory::{columns::MemoryInstructionsColumns, MemoryInstructionsChip},
// riscv::RiscvAir,
// utils::run_malicious_test,
// };
// enum FailureType {
// ConstraintsFailing,
// // TODO: Re-enable when we LOGUP-GKR working.
// // CumulativeSumFailing,
// }
// struct TestCase {
// opcode: Opcode,
// incorrect_value: u32,
// failure_type: FailureType,
// }
// #[test]
// fn test_malicious_stores() {
// let test_cases = vec![
// TestCase {
// opcode: Opcode::SW,
// incorrect_value: 8,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xDEADBEEF.
// TestCase {
// opcode: Opcode::SH,
// incorrect_value: 0xDEADBEEF,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xBEEF.
// TestCase {
// opcode: Opcode::SB,
// incorrect_value: 0xDEADBEEF,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xEF.
// ];
// for test_case in test_cases {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 29, 0, 0xDEADBEEF, false, true), // Set the stored
// value to 5. Instruction::new(Opcode::ADD, 30, 0, 100, false, true), // Set the
// address to 100. Instruction::new(test_case.opcode, 29, 30, 0, false, true),
// ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// move |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// // Create a malicious record where the incorrect value is saved to memory.
// let mut malicious_record = record.clone();
// if let MemoryRecordEnum::Write(mem_write_record) =
// &mut malicious_record.memory_instr_events[0].mem_access
// {
// mem_write_record.value = test_case.incorrect_value;
// }
// prover.generate_traces(&malicious_record)
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// match test_case.failure_type {
// FailureType::ConstraintsFailing => {
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// } // TODO: Re-enable when we LOGUP-GKR working.
// // FailureType::CumulativeSumFailing => {
// // assert!(
// // result.is_err() &&
// result.unwrap_err().is_local_cumulative_sum_failing() // );
// // }
// }
// }
// }
// #[test]
// fn test_malicious_loads() {
// let test_cases = vec![
// TestCase {
// opcode: Opcode::LW,
// incorrect_value: 8,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xDEADBEEF.
// // TODO: Re-enable when we LOGUP-GKR working v6.
// // TestCase {
// // opcode: Opcode::LH,
// // incorrect_value: 0xDEADBEEF,
// // failure_type: FailureType::CumulativeSumFailing,
// // }, // The correct value is 0xFFFFBEEF.
// TestCase {
// opcode: Opcode::LHU,
// incorrect_value: 0xDEADBEEF,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xBEEF.
// // TODO: Re-enable when we LOGUP-GKR working v6.
// // TestCase {
// // opcode: Opcode::LB,
// // incorrect_value: 0xDEADBEEF,
// // failure_type: FailureType::CumulativeSumFailing,
// // }, // The correct value is 0xEF.
// TestCase {
// opcode: Opcode::LBU,
// incorrect_value: 0xDEADBEEF,
// failure_type: FailureType::ConstraintsFailing,
// }, // The correct value is 0xFFFFEF.
// ];
// for test_case in test_cases {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 29, 0, 0xDEADBEEF, false, true), // Set the stored
// value to 0xDEADBEEF. Instruction::new(Opcode::ADD, 30, 0, 100, false, true), //
// Set the address to 100. Instruction::new(Opcode::SW, 29, 30, 0, false, true), //
// Store the value to memory. Instruction::new(test_case.opcode, 25, 30, 0, false,
// true), // Load the value from memory. ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// move |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// // Create a malicious record where the incorrect value is loaded from memory.
// let mut malicious_record = record.clone();
// malicious_record.cpu_events[3].a = test_case.incorrect_value;
// malicious_record.memory_instr_events[1].a = test_case.incorrect_value;
// prover.generate_traces(&malicious_record)
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// match test_case.failure_type {
// FailureType::ConstraintsFailing => {
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// } // TODO: Re-enable when we LOGUP-GKR working.
// // FailureType::CumulativeSumFailing => {
// // assert!(
// // result.is_err() &&
// result.unwrap_err().is_local_cumulative_sum_failing() // );
// // }
// }
// }
// }
// #[test]
// fn test_malicious_multiple_opcode_flags() {
// let instructions = vec![
// Instruction::new(Opcode::ADD, 29, 0, 5, false, true), // Set the stored value to 5.
// Instruction::new(Opcode::ADD, 30, 0, 100, false, true), // Set the address to 100.
// Instruction::new(Opcode::SW, 29, 30, 0, false, true),
// ];
// let program = Program::new(instructions, 0, 0);
// let stdin = SP1Stdin::new();
// type P = CpuProver<SP1InnerPcs, RiscvAir<SP1Field>>;
// let malicious_trace_pv_generator =
// |prover: &P,
// record: &mut ExecutionRecord|
// -> Vec<(String, RowMajorMatrix<Val<SP1InnerPcs>>)> {
// // Modify the branch chip to have a row that has multiple opcode flags set.
// let mut traces = prover.generate_traces(record);
// let memory_instr_chip_name = chip_name!(MemoryInstructionsChip, SP1Field);
// for (chip_name, trace) in traces.iter_mut() {
// if *chip_name == memory_instr_chip_name {
// let first_row: &mut [SP1Field] = trace.row_mut(0);
// let first_row: &mut MemoryInstructionsColumns<SP1Field> =
// first_row.borrow_mut();
// assert!(first_row.is_sw == SP1Field::one());
// first_row.is_lw = SP1Field::one();
// }
// }
// traces
// };
// let result =
// run_malicious_test::<P>(program, stdin, Box::new(malicious_trace_pv_generator));
// assert!(result.is_err() && result.unwrap_err().is_constraints_failing());
// }
// }