sofie-client 0.2.0

The one way out: outgoing requests of gateway adapters, traced, bounded and held to their vendor's hosts.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
//! `Outgoing` against a local TLS server whose certificate only the test's own root signs.

use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};

use bytes::Bytes;
use http_body_util::Full;
use hyper::body::Incoming;
use hyper::service::service_fn;
use hyper::{Request, Response, StatusCode};
use hyper_util::rt::TokioIo;
use rustls::ServerConfig;
use rustls::pki_types::{CertificateDer, PrivateKeyDer, PrivatePkcs8KeyDer};
use serde_json::{Value, json};
use sofie_client::{Outgoing, Vendor};
use sofie_core::{Error, unpoisoned};
use sofie_db::Work;
use tokio::net::TcpListener;
use tokio_rustls::TlsAcceptor;

const ROOT: &[u8] = include_bytes!("certificates/root.der");
const SERVER_CERTIFICATE: &[u8] = include_bytes!("certificates/server.der");
const SERVER_KEY: &[u8] = include_bytes!("certificates/server.key.der");

#[derive(Default)]
struct Seen {
    flaky: AtomicUsize,
    keys: Mutex<Vec<String>>,
}

struct Server {
    port: u16,
    seen: Arc<Seen>,
}

impl Server {
    async fn start() -> Self {
        let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
        let port = listener.local_addr().unwrap().port();
        let acceptor = TlsAcceptor::from(Arc::new(server_config()));
        let seen = Arc::new(Seen::default());
        let serving = Arc::clone(&seen);
        tokio::spawn(async move {
            loop {
                let (stream, _) = listener.accept().await.unwrap();
                let (acceptor, seen) = (acceptor.clone(), Arc::clone(&serving));
                tokio::spawn(async move {
                    let Ok(stream) = acceptor.accept(stream).await else {
                        return;
                    };
                    let service = service_fn(move |request| answer(request, Arc::clone(&seen)));
                    let _ = hyper::server::conn::http1::Builder::new()
                        .serve_connection(TokioIo::new(stream), service)
                        .await;
                });
            }
        });
        Self { port, seen }
    }

    fn base_url(&self) -> String {
        format!("https://localhost:{}", self.port)
    }

    fn outgoing(&self, settings: Vendor) -> Outgoing {
        outgoing(Vendor {
            base_url: Some(self.base_url()),
            private: Some(true),
            ..settings
        })
    }
}

fn outgoing(settings: Vendor) -> Outgoing {
    sofie_client::testing::outgoing("vendor", settings, ROOT).unwrap()
}

fn server_config() -> ServerConfig {
    let provider = Arc::new(rustls::crypto::ring::default_provider());
    let key = PrivateKeyDer::Pkcs8(PrivatePkcs8KeyDer::from(SERVER_KEY.to_vec()));
    ServerConfig::builder_with_provider(provider)
        .with_safe_default_protocol_versions()
        .unwrap()
        .with_no_client_auth()
        .with_single_cert(vec![CertificateDer::from(SERVER_CERTIFICATE.to_vec())], key)
        .unwrap()
}

async fn answer(
    request: Request<Incoming>,
    seen: Arc<Seen>,
) -> Result<Response<Full<Bytes>>, std::convert::Infallible> {
    if let Some(key) = request.headers().get("idempotency-key") {
        let key = key.to_str().unwrap().to_owned();
        unpoisoned::lock(&seen.keys).push(key);
    }
    let reply = |status: StatusCode, body: &str| {
        let mut response = Response::new(Full::new(Bytes::from(body.to_owned())));
        *response.status_mut() = status;
        response
    };
    let path = request.uri().path();
    let lookup = path.starts_with("/_sofie/lookups/");
    let still_failing =
        (path == "/flaky" || lookup) && seen.flaky.fetch_add(1, Ordering::SeqCst) < 2;
    let response = match path {
        "/flaky" if still_failing => reply(StatusCode::SERVICE_UNAVAILABLE, ""),
        _ if lookup && still_failing => reply(StatusCode::SERVICE_UNAVAILABLE, ""),
        _ if lookup => reply(StatusCode::OK, "[]"),
        "/account"
            if request
                .headers()
                .get("authorization")
                .is_some_and(|value| value == "Bearer sk_test") =>
        {
            reply(StatusCode::OK, r#"{"ok":true}"#)
        }
        "/ok" | "/flaky" => reply(StatusCode::OK, r#"{"ok":true}"#),
        "/big" => reply(StatusCode::OK, &"x".repeat(4096)),
        "/agent" => {
            let agent = request.headers()["user-agent"].to_str().unwrap();
            reply(StatusCode::OK, agent)
        }
        "/slow" => {
            tokio::time::sleep(Duration::from_secs(5)).await;
            reply(StatusCode::OK, "late")
        }
        "/down" => reply(StatusCode::SERVICE_UNAVAILABLE, ""),
        "/redirect" => {
            let mut response = reply(StatusCode::FOUND, "");
            let location = request.headers()["x-location"].clone();
            response.headers_mut().insert("location", location);
            response
        }
        _ => reply(StatusCode::NOT_FOUND, ""),
    };
    Ok(response)
}

#[tokio::test]
async fn a_request_reaches_its_vendor_over_tls_trusting_the_test_s_root_only() {
    let server = Server::start().await;

    let answer: Value = server
        .outgoing(Vendor::default())
        .get("/account")
        .bearer("sk_test")
        .send()
        .await
        .unwrap()
        .json()
        .unwrap();
    let public_roots = sofie_client::for_vendor(
        "vendor",
        Vendor {
            base_url: Some(server.base_url()),
            private: Some(true),
            ..Vendor::default()
        },
    )
    .unwrap();
    let untrusted_certificate = public_roots.get("/ok").send().await.unwrap_err();

    assert_eq!(answer, json!({ "ok": true }));
    assert!(
        matches!(&untrusted_certificate, Error::Unavailable(message) if message.contains("certificate")),
        "{untrusted_certificate:?}"
    );
}

#[tokio::test]
async fn an_answer_using_a_vendor_s_reply_has_no_fingerprint() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor::default());

    let (sent, fingerprint) = sofie_db::track_reads(1, outgoing.get("/ok").send()).await;

    assert!(sent.is_ok(), "{sent:?}");
    assert_eq!(fingerprint, None);
}

#[tokio::test]
async fn internal_addresses_are_refused_unless_the_vendor_allows_them() {
    let server = Server::start().await;
    let public_only = outgoing(Vendor {
        base_url: Some(server.base_url()),
        ..Vendor::default()
    });
    let allowed = server.outgoing(Vendor::default());

    let refused = public_only.get("/ok").send().await.unwrap_err();
    let plain_http = Vendor {
        base_url: Some("http://vendor.test".to_owned()),
        ..Vendor::default()
    };
    let Err(plain) = sofie_client::testing::outgoing("vendor", plain_http, ROOT) else {
        panic!("a plain HTTP base URL is refused when read");
    };

    assert!(
        matches!(&refused, Error::Internal { context, .. } if context.contains("internal address")),
        "{refused:?}"
    );
    assert!(
        matches!(&plain, Error::Internal { context, .. } if context.contains("not HTTPS")),
        "{plain:?}"
    );
    assert_eq!(allowed.get("/ok").send().await.unwrap().status(), 200);
}

#[tokio::test]
async fn untrusted_urls_get_no_exception_and_no_redirect() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        redirects: Some(3),
        ..Vendor::default()
    });
    let untrusted = outgoing.untrusted();

    for url in [
        format!("{}/ok", server.base_url()),
        "https://169.254.169.254/latest/meta-data".to_owned(),
        "https://[::ffff:127.0.0.1]/".to_owned(),
        "http://example.com/".to_owned(),
        "https://user:secret@example.com/".to_owned(),
    ] {
        let refused = untrusted.post(&url).send().await.unwrap_err();
        assert!(
            matches!(refused, Error::BadRequest(_)),
            "{url}: {refused:?}"
        );
    }
}

#[tokio::test]
async fn an_untrusted_host_is_refused_alike_whatever_it_resolves_to() {
    let server = Server::start().await;
    let untrusted = server.outgoing(Vendor::default());

    for host in [
        "127.0.0.1",
        "10.0.0.1",
        "169.254.169.254",
        "nothing.invalid",
    ] {
        let refused = untrusted
            .untrusted()
            .get(&format!("https://{host}/"))
            .send()
            .await
            .unwrap_err();
        let expected = format!(
            "the outgoing request to `{host}` is refused: it does not resolve to a public address"
        );
        assert!(
            matches!(&refused, Error::BadRequest(message) if *message == expected),
            "{host}: {refused:?}"
        );
    }
}

#[tokio::test]
async fn redirects_are_not_followed_unless_allowed_and_then_only_to_the_vendor_s_hosts() {
    let server = Server::start().await;
    let off = server.outgoing(Vendor::default());
    let on = server.outgoing(Vendor {
        redirects: Some(1),
        ..Vendor::default()
    });

    let kept = redirect(&off, "localhost", server.port).await.unwrap();
    let followed = redirect(&on, "localhost", server.port).await.unwrap();
    let elsewhere = redirect(&on, "127.0.0.1", server.port).await.unwrap_err();

    assert_eq!(kept.status(), 302);
    assert_eq!(followed.status(), 200);
    assert!(
        matches!(&elsewhere, Error::Internal { context, .. } if context.contains("not one the vendor uses")),
        "{elsewhere:?}"
    );
}

#[tokio::test]
async fn a_redirect_to_another_origin_leaves_the_caller_s_headers_behind() {
    let server = Server::start().await;
    let other = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        redirects: Some(1),
        ..Vendor::default()
    });
    let to = |port: u16| format!("https://localhost:{port}/account");

    let same = outgoing
        .get("/redirect")
        .bearer("sk_test")
        .header("x-location", &to(server.port))
        .send()
        .await
        .unwrap();
    let elsewhere = outgoing
        .get("/redirect")
        .bearer("sk_test")
        .header("x-location", &to(other.port))
        .send()
        .await
        .unwrap();

    assert_eq!(same.status(), 200);
    assert_eq!(elsewhere.status(), 404, "the bearer token did not travel");
}

async fn redirect(
    outgoing: &Outgoing,
    host: &str,
    port: u16,
) -> sofie_core::Result<sofie_client::Response> {
    let location = format!("https://{host}:{port}/ok");
    outgoing
        .get("/redirect")
        .header("x-location", &location)
        .send()
        .await
}

#[tokio::test]
async fn a_caller_s_user_agent_is_kept_and_a_bad_content_type_is_returned_by_send() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor::default());

    let agent = outgoing
        .get("/agent")
        .header("user-agent", "shop/1.0")
        .send()
        .await
        .unwrap();
    let refused = outgoing
        .post("/ok")
        .body("text/plain\n", "hello")
        .send()
        .await
        .unwrap_err();

    assert_eq!(agent.body(), b"shop/1.0");
    assert!(
        matches!(&refused, Error::Internal { context, .. } if context.contains("content type")),
        "{refused:?}"
    );
}

#[tokio::test]
async fn timeouts_and_the_response_size_cap_bound_a_request() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        timeout_ms: Some(300),
        max_response_bytes: Some(1024),
        ..Vendor::default()
    });

    let started = Instant::now();
    let late = outgoing.get("/slow").send().await.unwrap_err();
    let elapsed = started.elapsed();
    let big = outgoing.get("/big").send().await.unwrap_err();

    assert!(matches!(late, Error::Unavailable(_)), "{late:?}");
    assert!(elapsed < Duration::from_secs(2), "{elapsed:?}");
    assert!(
        matches!(&big, Error::Internal { context, .. } if context.contains("larger than 1024 bytes")),
        "{big:?}"
    );
}

#[tokio::test]
async fn only_an_idempotent_request_is_tried_again_and_its_key_is_sent() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        retries: Some(2),
        ..Vendor::default()
    });
    let key = Work::new("charge-7".to_owned(), "fingerprint".to_owned()).key();

    let once = outgoing
        .post("/flaky")
        .json(&json!({}))
        .send()
        .await
        .unwrap();
    let tries_after_once = server.seen.flaky.load(Ordering::SeqCst);
    server.seen.flaky.store(0, Ordering::SeqCst);
    let keyed = outgoing
        .post("/flaky")
        .idempotency(&key)
        .send()
        .await
        .unwrap();

    assert_eq!((once.status(), tries_after_once), (503, 1));
    assert_eq!(keyed.status(), 200);
    assert_eq!(server.seen.flaky.load(Ordering::SeqCst), 3);
    let keys = server.seen.keys.lock().unwrap().clone();
    assert_eq!(keys, ["charge-7", "charge-7", "charge-7"]);
}

#[cfg(feature = "remote-contracts")]
#[tokio::test]
async fn a_remote_lookup_is_a_read_tried_again() {
    use sofie_db::Lookup as _;

    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        retries: Some(2),
        ..Vendor::default()
    });
    let keys = sofie_auth::SigningKeys::generate().unwrap();
    let lookup = sofie_client::RemoteLookup::<Value>::new(sofie_client::RemoteApp::new(
        "vendor", outgoing, keys,
    ));

    let found = lookup
        .get_many(&[sofie_core::Uuid::now_v7().unwrap()])
        .await;

    assert_eq!(found.unwrap(), Vec::<Value>::new());
    assert_eq!(server.seen.flaky.load(Ordering::SeqCst), 3);
}

#[tokio::test]
async fn a_request_counts_once_against_its_circuit_and_a_refusal_not_at_all() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        retries: Some(2),
        max_response_bytes: Some(1024),
        ..Vendor::default()
    });

    for _ in 0..4 {
        let down = outgoing.get("/down").send().await.unwrap();
        assert_eq!(down.status(), 503);
    }
    let refused = outgoing.get("/big").send().await.unwrap_err();
    let fifth = outgoing.get("/down").send().await.unwrap();
    let open = outgoing.get("/ok").send().await.unwrap_err();

    assert!(matches!(refused, Error::Internal { .. }), "{refused:?}");
    assert_eq!(fifth.status(), 503);
    assert!(
        matches!(&open, Error::Unavailable(message) if message.contains("circuit")),
        "{open:?}"
    );
}

#[tokio::test]
async fn a_circuit_is_one_port_of_a_host() {
    let failing = Server::start().await;
    let other = Server::start().await;
    let outgoing = failing.outgoing(Vendor {
        retries: Some(0),
        ..Vendor::default()
    });
    for _ in 0..5 {
        outgoing.get("/down").send().await.unwrap();
    }

    let other_port = outgoing
        .get_url(&format!("{}/ok", other.base_url()))
        .send()
        .await
        .unwrap();

    assert_eq!(other_port.status(), 200);
}

#[tokio::test]
async fn a_request_that_runs_out_of_time_counts_against_its_circuit() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        timeout_ms: Some(100),
        ..Vendor::default()
    });

    for _ in 0..5 {
        let late = outgoing.get("/slow").send().await.unwrap_err();
        assert!(matches!(late, Error::Unavailable(_)), "{late:?}");
    }
    let open = outgoing.get("/ok").send().await.unwrap_err();

    assert!(
        matches!(&open, Error::Unavailable(message) if message.contains("circuit")),
        "{open:?}"
    );
}

#[tokio::test]
async fn an_open_circuit_is_an_operation_s_outcome_but_not_a_new_failure() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor {
        retries: Some(0),
        ..Vendor::default()
    });
    for _ in 0..5 {
        outgoing.get("/down").send().await.unwrap();
    }

    for _ in 0..5 {
        let host_open = outgoing
            .operation("check", async {
                outgoing.get("/ok").send().await.map(drop)
            })
            .await;
        assert!(
            matches!(host_open, Err(Error::Unavailable(_))),
            "{host_open:?}"
        );
    }
    let operation = outgoing.operation("check", async { Ok(7) }).await;

    assert_eq!(operation.unwrap(), 7);
}

#[tokio::test]
async fn an_operation_is_bounded_by_the_vendor_s_timeout_and_breaker() {
    let outgoing = outgoing(Vendor {
        timeout_ms: Some(100),
        ..Vendor::default()
    });

    let sent = outgoing.operation("send", async { Ok(7) }).await;
    for _ in 0..5 {
        let late = outgoing
            .operation("send", async {
                tokio::time::sleep(Duration::from_secs(5)).await;
                Ok(())
            })
            .await;
        assert!(matches!(late, Err(Error::Unavailable(_))), "{late:?}");
    }
    let telemetry = sofie_telemetry::capture();
    let refused = outgoing
        .operation("send", async { Ok(()) })
        .await
        .unwrap_err();
    let no_base = outgoing.get("/ok").send().await.unwrap_err();

    let spans = telemetry.spans();
    let span = spans.iter().find(|span| span.name == "outgoing").unwrap();
    assert_eq!(sent.unwrap(), 7);
    assert!(matches!(&refused, Error::Unavailable(message) if message.contains("circuit")));
    assert_eq!(
        span.fields["outcome"], "error",
        "the refusal still finishes its span"
    );
    assert!(matches!(&no_base, Error::Internal { context, .. } if context.contains("BASE_URL")));
}

#[tokio::test]
async fn a_request_is_a_client_span_inside_its_gateway_call() {
    let server = Server::start().await;
    let outgoing = server.outgoing(Vendor::default());
    let telemetry = sofie_telemetry::capture();

    let status = sofie_client::call("vendor", "check", async {
        Ok(outgoing.get("/ok").send().await?.status())
    })
    .await
    .unwrap();

    let spans = telemetry.spans();
    let gateway = spans.iter().find(|span| span.name == "gateway").unwrap();
    let client = spans
        .iter()
        .find(|span| span.name == "http.client")
        .unwrap();
    assert_eq!(status, 200);
    assert_eq!(gateway.fields["otel.name"], "vendor.check");
    assert_eq!(gateway.fields["outcome"], "ok");
    assert_eq!(client.parent, Some(gateway.id));
    assert_eq!(client.fields["server.address"], "localhost");
    assert_eq!(client.fields["http.response.status_code"], "200");
}