1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
use crate::queue::{ArcJobProcessorFn, QueueInterface};
use crate::webhook::sender::JobProcessorFnAsync;
use crate::webhook::types::JobData;
use async_trait::async_trait;
use redis::aio::MultiplexedConnection;
use redis::{AsyncCommands, RedisResult};
use serde::Serialize;
use serde::de::DeserializeOwned;
use std::sync::Arc;
use std::time::Duration;
use tokio::sync::Mutex;
use tracing::{error, info};
pub struct RedisQueueManager {
redis_connection: Arc<Mutex<MultiplexedConnection>>,
// Store Arc'd callbacks to allow cloning them into worker tasks safely
job_processors: dashmap::DashMap<String, ArcJobProcessorFn, ahash::RandomState>,
prefix: String,
concurrency: usize,
}
impl RedisQueueManager {
/// Creates a new RedisQueueManager instance.
/// Connects to Redis and returns a Result.
pub async fn new(
redis_url: &str,
prefix: &str,
concurrency: usize,
) -> crate::error::Result<Self> {
let client = redis::Client::open(redis_url).map_err(|e| {
crate::error::Error::Config(format!("Failed to open Redis client: {}", e))
})?; // Use custom error type
let connection = client
.get_multiplexed_async_connection()
.await
.map_err(|e| {
crate::error::Error::Connection(format!("Failed to get Redis connection: {}", e))
})?; // Use custom error type
Ok(Self {
redis_connection: Arc::new(Mutex::new(connection)),
job_processors: dashmap::DashMap::with_hasher(ahash::RandomState::new()),
prefix: prefix.to_string(),
concurrency,
})
}
// Note: start_processing is effectively done within process_queue for Redis
#[allow(dead_code)]
pub fn start_processing(&self) {
// This method is not strictly needed for Redis as workers start in process_queue.
// Could be used for other setup if required in the future.
}
async fn format_key(&self, queue_name: &str) -> String {
format!("{}:queue:{}", self.prefix, queue_name)
}
}
#[async_trait]
impl QueueInterface for RedisQueueManager {
/// Adds a job to the specified Redis queue (list).
/// Serializes the job data to JSON.
async fn add_to_queue(&self, queue_name: &str, data: JobData) -> crate::error::Result<()>
where
JobData: Serialize, // Ensure JobData can be serialized
{
let queue_key = self.format_key(queue_name).await;
let data_json = serde_json::to_string(&data)?; // Propagate serialization error
let mut conn = self.redis_connection.lock().await;
// Perform RPUSH and handle potential Redis errors
conn.rpush::<_, _, ()>(&queue_key, data_json)
.await
.map_err(|e| {
crate::error::Error::Queue(format!(
"Redis RPUSH failed for queue {}: {}",
queue_name, e
))
})?; // Use custom error type
// info!("{}", format!("Added job to Redis queue: {}", queue_name)); // Optional: reduce log verbosity
Ok(())
}
/// Registers a callback for a queue and starts worker tasks to process jobs.
async fn process_queue(
&self,
queue_name: &str,
callback: JobProcessorFnAsync,
) -> crate::error::Result<()>
where
JobData: DeserializeOwned + Send + 'static, // Ensure JobData can be deserialized and sent across threads
{
let queue_key = self.format_key(queue_name).await;
// Wrap the callback in an Arc to share it safely with multiple worker tasks
let processor_arc: ArcJobProcessorFn = Arc::from(callback);
// Store the Arc'd callback
self.job_processors
.insert(queue_name.to_string(), processor_arc.clone());
info!(
"{}",
format!(
"Registered processor and starting workers for Redis queue: {}",
queue_name
)
);
// Start worker tasks
for i in 0..self.concurrency {
let worker_queue_key = queue_key.clone();
let worker_redis_conn = self.redis_connection.clone();
let worker_processor = processor_arc.clone(); // Clone the Arc for this worker
let worker_queue_name = queue_name.to_string(); // Clone queue name for logging
tokio::spawn(async move {
info!(
"{}",
format!(
"Starting Redis queue worker {} for queue: {}",
i, worker_queue_name
)
);
loop {
let blpop_result: RedisResult<Option<(String, String)>> = {
// Type hint for clarity
let mut conn = worker_redis_conn.lock().await;
// Use BLPOP with a timeout (e.g., 1 second)
conn.blpop(&worker_queue_key, 0.01).await
};
match blpop_result {
// Successfully received a job
Ok(Some((_key, job_data_str))) => {
match serde_json::from_str::<JobData>(&job_data_str) {
Ok(job_data) => {
// Execute the job processing callback
match worker_processor(job_data).await {
Ok(_) => {
info!("{}", "Worker finished".to_string());
}
Err(e) => {
error!("{}", format!("Worker error: {}", e));
}
}
}
Err(e) => {
// Failed to deserialize the job data
error!(
"{}",
format!(
"[Worker {}] Error deserializing job data from Redis queue {}: {}. Data: '{}'",
i, worker_queue_name, e, job_data_str
)
);
// Potential: Move corrupted data to a specific place?
}
}
}
// BLPOP timed out, no job available
Ok(None) => {
// Continue loop to wait again
continue;
}
// Redis error during BLPOP
Err(e) => {
error!(
"{}",
format!(
"[Worker {}] Redis BLPOP error on queue {}: {}",
i, worker_queue_name, e
)
);
// Avoid hammering Redis on persistent errors
tokio::time::sleep(Duration::from_secs(1)).await;
}
}
}
});
}
Ok(())
}
async fn disconnect(&self) -> crate::error::Result<()> {
let mut conn = self.redis_connection.lock().await;
let keys: Vec<String> = conn
.keys(format!("{}:queue:*", self.prefix))
.await
.expect("Error fetching keys");
for key in keys {
conn.del::<_, ()>(&key).await.expect("Error deleting key");
}
Ok(())
}
}