socket-patch-core 3.1.0

Core library for socket-patch: manifest, hash, crawlers, patch engine, API client
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
//! Integration coverage for `crawlers::nuget_crawler`. The
//! apply-CLI suite drives the global-cache `find_by_purls` happy
//! path with `SOCKET_EXPERIMENTAL_NUGET=1`; everything else here —
//! legacy `Packages/<Name>.<Version>` layout, case-insensitive
//! lookup, `crawl_all` directory scanning, `scan_package_dir`'s
//! hidden-dir skip, `get_nuget_package_paths` discovery branches —
//! goes uncovered without these tests.

#![cfg(feature = "nuget")]

use std::path::Path;

use serial_test::serial;
use socket_patch_core::crawlers::types::CrawlerOptions;
use socket_patch_core::crawlers::NuGetCrawler;

const ORG_PURL_A: &str = "pkg:nuget/Newtonsoft.Json@13.0.3";
const ORG_PURL_B: &str = "pkg:nuget/Serilog@4.0.0";

fn options_at(root: &Path) -> CrawlerOptions {
    CrawlerOptions {
        cwd: root.to_path_buf(),
        global: false,
        global_prefix: None,
        batch_size: 100,
    }
}

/// Stage a global-cache layout: <root>/<lowercase>/<version>/ with
/// a minimal `.nuspec` so verify_nuget_package returns true.
async fn stage_global_cache_pkg(root: &Path, name: &str, version: &str) -> std::path::PathBuf {
    let pkg_dir = root.join(name.to_lowercase()).join(version);
    tokio::fs::create_dir_all(&pkg_dir).await.unwrap();
    tokio::fs::write(
        pkg_dir.join(format!("{}.nuspec", name.to_lowercase())),
        format!(
            r#"<?xml version="1.0"?><package><metadata><id>{name}</id><version>{version}</version></metadata></package>"#
        ),
    )
    .await
    .unwrap();
    pkg_dir
}

/// Stage a legacy <Name>.<Version> layout. Used by older
/// `packages.config` projects.
async fn stage_legacy_pkg(root: &Path, name: &str, version: &str) -> std::path::PathBuf {
    let pkg_dir = root.join(format!("{name}.{version}"));
    tokio::fs::create_dir_all(pkg_dir.join("lib")).await.unwrap();
    tokio::fs::write(
        pkg_dir.join(format!("{name}.nuspec")),
        format!(
            r#"<?xml version="1.0"?><package><metadata><id>{name}</id><version>{version}</version></metadata></package>"#
        ),
    )
    .await
    .unwrap();
    pkg_dir
}

// ── find_by_purls ──────────────────────────────────────────────

#[tokio::test]
async fn find_by_purls_global_cache_layout_finds_package() {
    let tmp = tempfile::tempdir().unwrap();
    let pkg_dir = stage_global_cache_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;

    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert_eq!(result.len(), 1);
    let pkg = result.get(ORG_PURL_A).expect("must find by purl");
    assert_eq!(pkg.path, pkg_dir);
    assert_eq!(pkg.name, "Newtonsoft.Json");
    assert_eq!(pkg.version, "13.0.3");
}

#[tokio::test]
async fn find_by_purls_legacy_layout_finds_package() {
    let tmp = tempfile::tempdir().unwrap();
    let pkg_dir = stage_legacy_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;

    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert_eq!(result.len(), 1);
    assert_eq!(result.get(ORG_PURL_A).unwrap().path, pkg_dir);
}

/// PURL with a case-mismatched name. NuGet package names are
/// case-insensitive — the case-insensitive legacy scan must locate
/// the package even when only a differently-cased dir exists.
///
/// On case-insensitive filesystems (default macOS APFS), this exercises
/// the same fast-path `legacy_dir` branch since the filesystem itself
/// folds names. On case-sensitive filesystems (Linux ext4), the
/// case-insensitive scan branch fires.
#[tokio::test]
async fn find_by_purls_case_insensitive_legacy_layout() {
    let tmp = tempfile::tempdir().unwrap();
    let _pkg_dir = stage_legacy_pkg(tmp.path(), "newtonsoft.json", "13.0.3").await;

    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert_eq!(result.len(), 1, "package must be found via either fast or case-insensitive path");
    let found = result.get(ORG_PURL_A).unwrap();
    // Either casing is acceptable; the contract is "matched something".
    assert!(found.path.exists(), "returned path must exist; got {:?}", found.path);
}

#[tokio::test]
async fn find_by_purls_no_match_returns_empty() {
    let tmp = tempfile::tempdir().unwrap();
    // Empty dir — no packages.
    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert!(result.is_empty());
}

#[tokio::test]
async fn find_by_purls_invalid_purl_skipped() {
    let tmp = tempfile::tempdir().unwrap();
    stage_global_cache_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;
    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(
            tmp.path(),
            &["pkg:not-nuget/Foo@1.0".to_string()],
        )
        .await
        .unwrap();
    assert!(result.is_empty(), "non-nuget PURLs must be skipped");
}

// ── crawl_all (scan_package_dir) ───────────────────────────────

#[tokio::test]
async fn crawl_all_discovers_global_cache_layout() {
    let tmp = tempfile::tempdir().unwrap();
    stage_global_cache_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;
    stage_global_cache_pkg(tmp.path(), "Serilog", "4.0.0").await;

    let crawler = NuGetCrawler;
    // Use --global-prefix to point at our staged root.
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    assert_eq!(result.len(), 2);
    // The crawler lowercases the discovered name from the directory.
    let purls: Vec<String> = result
        .iter()
        .map(|p| p.purl.to_ascii_lowercase())
        .collect();
    assert!(purls.iter().any(|p| p.contains("newtonsoft.json")));
    assert!(purls.iter().any(|p| p.contains("serilog")));
}

#[tokio::test]
async fn crawl_all_discovers_legacy_layout() {
    let tmp = tempfile::tempdir().unwrap();
    stage_legacy_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;
    stage_legacy_pkg(tmp.path(), "Serilog", "4.0.0").await;

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    assert!(result.len() >= 2, "legacy layout must be discovered; got {result:?}");
}

#[tokio::test]
async fn crawl_all_skips_hidden_directories() {
    let tmp = tempfile::tempdir().unwrap();
    // Real package.
    stage_global_cache_pkg(tmp.path(), "Newtonsoft.Json", "13.0.3").await;
    // Hidden dir that mimics a package layout — must be skipped.
    let hidden = tmp.path().join(".cache").join("13.0.3");
    tokio::fs::create_dir_all(&hidden).await.unwrap();
    tokio::fs::write(hidden.join(".cache.nuspec"), b"<package/>").await.unwrap();

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    // Only the real package should show up.
    assert_eq!(result.len(), 1);
    assert!(
        result[0].purl.to_ascii_lowercase().contains("newtonsoft.json"),
        "expected newtonsoft.json; got {:?}",
        result[0].purl
    );
}

// ── get_nuget_package_paths ─────────────────────────────────────

#[tokio::test]
#[serial]
async fn get_nuget_package_paths_with_global_prefix_returns_only_prefix() {
    let tmp = tempfile::tempdir().unwrap();
    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let paths = crawler.get_nuget_package_paths(&opts).await.unwrap();
    assert_eq!(paths, vec![tmp.path().to_path_buf()]);
}

#[tokio::test]
#[serial]
async fn get_nuget_package_paths_local_discovers_packages_dir() {
    let tmp = tempfile::tempdir().unwrap();
    let pkg = tmp.path().join("packages");
    tokio::fs::create_dir_all(&pkg).await.unwrap();

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();
    assert!(paths.iter().any(|p| p == &pkg), "packages/ must be discovered; got {paths:?}");
}

#[tokio::test]
#[serial]
async fn get_nuget_package_paths_local_with_csproj_falls_back_to_global() {
    let tmp = tempfile::tempdir().unwrap();
    // Marker file that triggers .NET-project detection.
    tokio::fs::write(
        tmp.path().join("MyProj.csproj"),
        r#"<Project Sdk="Microsoft.NET.Sdk"></Project>"#,
    )
    .await
    .unwrap();
    // Stub NUGET_PACKAGES to a writable temp location.
    let nuget_root = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert!(
        paths.iter().any(|p| p == nuget_root.path()),
        "csproj must trigger global-cache fallback; got {paths:?}"
    );
}

#[tokio::test]
#[serial]
async fn get_nuget_package_paths_local_no_project_returns_empty() {
    let tmp = tempfile::tempdir().unwrap();
    // No `packages/`, no `.csproj`, no `.sln`, no `obj/`.
    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();
    assert!(paths.is_empty(), "non-.NET dir must return empty paths");
}

#[tokio::test]
#[serial]
async fn get_nuget_package_paths_with_sln_falls_back_to_global() {
    let tmp = tempfile::tempdir().unwrap();
    tokio::fs::write(tmp.path().join("MySolution.sln"), b"Microsoft Visual Studio Solution File")
        .await
        .unwrap();
    let nuget_root = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert!(
        paths.iter().any(|p| p == nuget_root.path()),
        ".sln must trigger global-cache fallback"
    );
}

// ── verify_nuget_package indirectly via find_by_purls ───────────

#[tokio::test]
async fn find_by_purls_rejects_dir_without_nuspec_or_lib() {
    let tmp = tempfile::tempdir().unwrap();
    // Create a global-cache-shaped dir but with neither .nuspec nor lib/ — verify fails.
    let pkg_dir = tmp.path().join("newtonsoft.json").join("13.0.3");
    tokio::fs::create_dir_all(&pkg_dir).await.unwrap();
    // No .nuspec, no lib/ — just an unrelated file.
    tokio::fs::write(pkg_dir.join("README.md"), b"hello").await.unwrap();

    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert!(result.is_empty(), "dir without nuspec or lib/ must not match");
}

#[tokio::test]
async fn find_by_purls_with_lib_dir_marker_succeeds() {
    let tmp = tempfile::tempdir().unwrap();
    let pkg_dir = tmp.path().join("newtonsoft.json").join("13.0.3");
    tokio::fs::create_dir_all(pkg_dir.join("lib")).await.unwrap();
    // No .nuspec but lib/ is present — verify accepts it.

    let crawler = NuGetCrawler;
    let result = crawler
        .find_by_purls(tmp.path(), &[ORG_PURL_A.to_string()])
        .await
        .unwrap();
    assert_eq!(result.len(), 1);
}

#[path = "common/mod.rs"]
mod common;

/// `scan_package_dir` short-circuits when read_dir returns Err.
#[cfg(unix)]
#[tokio::test]
async fn crawl_all_handles_unreadable_pkg_path() {
    if common::uid_is_root() {
        eprintln!("SKIP: chmod 000 is a no-op under root");
        return;
    }
    let tmp = tempfile::tempdir().unwrap();
    let pkg = tmp.path().join("blocked");
    tokio::fs::create_dir(&pkg).await.unwrap();
    let _ = stage_global_cache_pkg(&pkg, "newtonsoft.json", "13.0.3").await;
    common::chmod_unreadable(&pkg);

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(pkg.clone()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    common::chmod_readable(&pkg);

    assert!(result.is_empty(), "unreadable pkg_path must yield empty");
}

/// `scan_global_cache_package` returns None when the per-name version
/// directory is unreadable — drives the inner read_dir Err arm at
/// nuget_crawler.rs:236.
#[cfg(unix)]
#[tokio::test]
async fn crawl_all_handles_unreadable_version_dir() {
    if common::uid_is_root() {
        eprintln!("SKIP: chmod 000 is a no-op under root");
        return;
    }
    let tmp = tempfile::tempdir().unwrap();
    let pkg_name_dir = tmp.path().join("blocked-name");
    tokio::fs::create_dir(&pkg_name_dir).await.unwrap();
    common::chmod_unreadable(&pkg_name_dir);

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    common::chmod_readable(&pkg_name_dir);

    assert!(result.is_empty(), "unreadable version dir must yield empty");
}

/// `scan_package_dir` skips entries that are not directories — covers
/// the `if !ft.is_dir()` continue arm at L183. Drive this by staging
/// a plain file alongside a valid global-cache package.
#[tokio::test]
async fn crawl_all_skips_files_at_top_level() {
    let tmp = tempfile::tempdir().unwrap();
    // Stage a real package so the scan actually runs.
    let _pkg = stage_global_cache_pkg(tmp.path(), "newtonsoft.json", "13.0.3").await;
    // Plain file at the top level — must be skipped.
    tokio::fs::write(tmp.path().join("readme.txt"), b"not a package").await.unwrap();

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: Some(tmp.path().to_path_buf()),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    let names: Vec<&str> = result.iter().map(|p| p.name.as_str()).collect();
    assert!(names.iter().any(|n| n.eq_ignore_ascii_case("newtonsoft.json")));
    assert_eq!(result.len(), 1, "plain file must be skipped");
}

/// `scan_package_dir` short-circuits when the package dir doesn't
/// exist — covers `read_dir(...).await` Err arm at L169.
#[tokio::test]
async fn crawl_all_missing_pkg_path_returns_empty() {
    let tmp = tempfile::tempdir().unwrap();
    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        // Point global_prefix at a non-existent dir.
        global_prefix: Some(tmp.path().join("does-not-exist")),
        batch_size: 100,
    };
    let result = crawler.crawl_all(&opts).await;
    assert!(result.is_empty());
}

// Marker so ORG_PURL_B import isn't unused.
#[allow(dead_code)]
fn _used_in_doc() -> &'static str {
    ORG_PURL_B
}

// ── NuGetCrawler construction ─────────────────────────────────

#[test]
fn nuget_crawler_default_and_new_construct_cleanly() {
    let _a = NuGetCrawler::default();
    let _b = NuGetCrawler::new();
}

// ── global mode ────────────────────────────────────────────────

/// `global=true` with no `global_prefix` falls through to `nuget_home`
/// which honors NUGET_PACKAGES. When the resulting home exists, the
/// crawler returns it as the only path (line 38-39).
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_global_mode_returns_nuget_home() {
    let tmp = tempfile::tempdir().unwrap();
    let nuget_root = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: None,
        batch_size: 100,
    };
    let paths = crawler.get_nuget_package_paths(&opts).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert_eq!(paths, vec![nuget_root.path().to_path_buf()]);
}

/// `global=true` but NUGET_PACKAGES points at a non-existent dir →
/// `is_dir` check fails and the crawler returns an empty list
/// (line 41).
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_global_mode_missing_home_returns_empty() {
    let tmp = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    let prev_home = std::env::var("HOME").ok();
    // Point both at a path that does not exist.
    let missing = tmp.path().join("does-not-exist");
    std::env::set_var("NUGET_PACKAGES", &missing);
    // HOME also pointed somewhere without .nuget — but NUGET_PACKAGES wins.
    std::env::set_var("HOME", tmp.path());

    let crawler = NuGetCrawler;
    let opts = CrawlerOptions {
        cwd: tmp.path().to_path_buf(),
        global: true,
        global_prefix: None,
        batch_size: 100,
    };
    let paths = crawler.get_nuget_package_paths(&opts).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }
    if let Some(v) = prev_home {
        std::env::set_var("HOME", v);
    } else {
        std::env::remove_var("HOME");
    }

    assert!(paths.is_empty(), "missing global cache dir must yield empty; got {paths:?}");
}

/// `is_dotnet_project` accepts a NuGet.Config marker without any
/// project file extensions — covers the L355 `if name == "NuGet.Config"`
/// branch.
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_with_nuget_config_falls_back_to_global() {
    let tmp = tempfile::tempdir().unwrap();
    tokio::fs::write(tmp.path().join("NuGet.Config"), b"<configuration/>").await.unwrap();
    let nuget_root = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert!(
        paths.iter().any(|p| p == nuget_root.path()),
        "NuGet.Config must trigger global-cache fallback"
    );
}

// ── project.assets.json discovery ─────────────────────────────

/// A staged `obj/project.assets.json` with a `packageFolders` map
/// must surface those folders alongside the global cache. Covers
/// `discover_paths_from_assets` and `parse_project_assets_package_folders`.
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_discovers_assets_json_package_folders() {
    let tmp = tempfile::tempdir().unwrap();
    let extra_packages = tempfile::tempdir().unwrap();
    let obj = tmp.path().join("obj");
    tokio::fs::create_dir_all(&obj).await.unwrap();
    // Build the assets.json body via serde_json so the path value is
    // properly escaped — on Windows, raw `format!`-embedded paths
    // contain unescaped backslashes that make the file invalid JSON,
    // which the production parser then silently drops.
    let mut folders = serde_json::Map::new();
    folders.insert(
        extra_packages.path().display().to_string(),
        serde_json::Value::Object(serde_json::Map::new()),
    );
    let assets = serde_json::json!({ "packageFolders": folders }).to_string();
    tokio::fs::write(obj.join("project.assets.json"), assets).await.unwrap();
    // Also need a project marker to satisfy is_dotnet_project (so the
    // global-cache fallback path runs as well) — but assets discovery
    // is independent, so this test exercises the obj-path branch even
    // without a csproj.
    let nuget_root = tempfile::tempdir().unwrap();
    let prev = std::env::var("NUGET_PACKAGES").ok();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert!(
        paths.iter().any(|p| p == extra_packages.path()),
        "assets.json packageFolders must be discovered; got {paths:?}"
    );
}

/// `project.assets.json` exists in a subdirectory (multi-project
/// solution) — `discover_paths_from_assets` walks one level deep.
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_discovers_assets_json_in_subproject() {
    let tmp = tempfile::tempdir().unwrap();
    let extra = tempfile::tempdir().unwrap();
    let sub_obj = tmp.path().join("WebApp").join("obj");
    tokio::fs::create_dir_all(&sub_obj).await.unwrap();
    // See companion test above — raw `format!` with Path::display()
    // produces invalid JSON on Windows.
    let mut folders = serde_json::Map::new();
    folders.insert(
        extra.path().display().to_string(),
        serde_json::Value::Object(serde_json::Map::new()),
    );
    let assets = serde_json::json!({ "packageFolders": folders }).to_string();
    tokio::fs::write(sub_obj.join("project.assets.json"), assets).await.unwrap();

    let prev = std::env::var("NUGET_PACKAGES").ok();
    let nuget_root = tempfile::tempdir().unwrap();
    std::env::set_var("NUGET_PACKAGES", nuget_root.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }

    assert!(
        paths.iter().any(|p| p == extra.path()),
        "subproject obj/project.assets.json must be discovered; got {paths:?}"
    );
}

/// Empty `packageFolders` object in assets.json must not surface any
/// paths (line 447-448 `if result.is_empty()` arm).
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_assets_json_empty_packagefolders_yields_no_paths() {
    let tmp = tempfile::tempdir().unwrap();
    let obj = tmp.path().join("obj");
    tokio::fs::create_dir_all(&obj).await.unwrap();
    tokio::fs::write(obj.join("project.assets.json"), br#"{"packageFolders":{}}"#).await.unwrap();

    let prev = std::env::var("NUGET_PACKAGES").ok();
    let prev_home = std::env::var("HOME").ok();
    std::env::set_var("NUGET_PACKAGES", tmp.path().join("nonexistent-cache"));
    std::env::set_var("HOME", tmp.path());

    let crawler = NuGetCrawler;
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }
    if let Some(v) = prev_home {
        std::env::set_var("HOME", v);
    } else {
        std::env::remove_var("HOME");
    }

    assert!(paths.is_empty(), "empty packageFolders must yield no paths");
}

/// Malformed JSON in project.assets.json must not crash — discovery
/// just skips it (line 442 `from_str.ok()?` arm).
#[tokio::test]
#[serial]
async fn get_nuget_package_paths_assets_json_malformed_skipped() {
    let tmp = tempfile::tempdir().unwrap();
    let obj = tmp.path().join("obj");
    tokio::fs::create_dir_all(&obj).await.unwrap();
    tokio::fs::write(obj.join("project.assets.json"), b"this is not json").await.unwrap();

    let prev = std::env::var("NUGET_PACKAGES").ok();
    let prev_home = std::env::var("HOME").ok();
    std::env::set_var("NUGET_PACKAGES", tmp.path().join("nonexistent-cache"));
    std::env::set_var("HOME", tmp.path());

    let crawler = NuGetCrawler;
    // Must succeed with no panic, returning empty.
    let paths = crawler.get_nuget_package_paths(&options_at(tmp.path())).await.unwrap();

    std::env::remove_var("NUGET_PACKAGES");
    if let Some(v) = prev {
        std::env::set_var("NUGET_PACKAGES", v);
    }
    if let Some(v) = prev_home {
        std::env::set_var("HOME", v);
    } else {
        std::env::remove_var("HOME");
    }

    assert!(paths.is_empty(), "malformed assets.json must be skipped; got {paths:?}");
}