sochdb-storage 2.0.8

SochDB storage engine (WAL, block store, compaction, sync-first I/O)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
// SPDX-License-Identifier: AGPL-3.0-or-later
// SochDB - LLM-Optimized Embedded Database
// Copyright (C) 2026 Sushanth Reddy Vanagala (https://github.com/sushanthpy)
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.

//! Pluggable Filter Policy
//!
//! This module provides an abstract filter interface supporting multiple
//! filter implementations:
//!
//! - **Bloom Filter**: Classic probabilistic filter, good for general use
//! - **Ribbon Filter**: Near-optimal space, better for memory-constrained scenarios
//! - **Xor Filter**: Simple, fast, but requires all keys upfront
//!
//! ## Information-Theoretic Analysis
//!
//! For a filter with false positive rate p:
//! - Information-theoretic minimum: log₂(1/p) bits per key
//! - Bloom filter: ~1.44 × log₂(1/p) bits per key (44% overhead)
//! - Ribbon filter: ~1.0 × log₂(1/p) bits per key (near optimal)
//!
//! ## Performance Characteristics
//!
//! | Filter    | Build Time | Query Time | Space Efficiency |
//! |-----------|------------|------------|------------------|
//! | Bloom     | O(n×k)     | O(k)       | ~1.44× minimum   |
//! | Ribbon    | O(n)       | O(1)       | ~1.0× minimum    |
//! | Xor       | O(n)       | O(1)       | ~1.23× minimum   |
//!
//! Where n = number of keys, k = number of hash functions.

use std::hash::{Hash, Hasher};

/// False positive rate for filters
pub type FPR = f64;

/// Default false positive rate (1%)
pub const DEFAULT_FPR: FPR = 0.01;

/// Filter policy trait for pluggable filter implementations
pub trait FilterPolicy: Send + Sync + std::fmt::Debug {
    /// Name of the filter policy
    fn name(&self) -> &str;

    /// Create a filter builder
    fn create_builder(&self, num_keys: usize) -> Box<dyn FilterBuilder>;

    /// Create a filter from raw bytes
    fn create_filter(&self, data: Vec<u8>) -> Box<dyn Filter>;

    /// Bits per key for this filter (approximate)
    fn bits_per_key(&self) -> f64;

    /// Target false positive rate
    fn target_fpr(&self) -> FPR;
}

/// Filter builder trait
pub trait FilterBuilder: Send {
    /// Add a key to the filter
    fn add_key(&mut self, key: &[u8]);

    /// Finish building and return filter bytes
    fn finish(&mut self) -> Vec<u8>;

    /// Get number of keys added
    fn num_keys(&self) -> usize;
}

/// Filter trait for querying
pub trait Filter: Send + Sync {
    /// Check if key may be present
    ///
    /// Returns:
    /// - `false`: Key is definitely NOT present
    /// - `true`: Key MIGHT be present (with FPR probability of false positive)
    fn may_contain(&self, key: &[u8]) -> bool;

    /// Get filter size in bytes
    fn size_bytes(&self) -> usize;
}

/// Filter reader for reading filters from bytes
#[derive(Debug)]
pub struct FilterReader {
    /// Filter data
    data: Vec<u8>,
    /// Number of hash functions (for Bloom)
    num_hashes: usize,
}

impl FilterReader {
    /// Create a filter reader from bytes
    pub fn from_bytes(data: &[u8]) -> Option<Self> {
        if data.len() < 2 {
            return None;
        }
        // Last byte is number of hash functions
        let num_hashes = data[data.len() - 1] as usize;
        if num_hashes == 0 || num_hashes > 30 {
            return None;
        }
        Some(Self {
            data: data.to_vec(),
            num_hashes,
        })
    }

    /// Check if key may be present
    pub fn may_contain(&self, key: &[u8]) -> bool {
        if self.data.len() < 2 {
            return true; // Degenerate case
        }

        let bits_len = (self.data.len() - 1) * 8;
        if bits_len == 0 {
            return true;
        }

        // Use xxHash-style double hashing
        let mut h1 = 0u64;
        let mut h2 = 0u64;
        for (i, &b) in key.iter().enumerate() {
            h1 = h1.wrapping_mul(31).wrapping_add(b as u64);
            h2 = h2
                .wrapping_mul(37)
                .wrapping_add(b as u64)
                .wrapping_add(i as u64);
        }

        for i in 0..self.num_hashes {
            let bit_pos = h1.wrapping_add(h2.wrapping_mul(i as u64)) % (bits_len as u64);
            let byte_idx = (bit_pos / 8) as usize;
            let bit_idx = (bit_pos % 8) as u8;

            if byte_idx < self.data.len() - 1 {
                if self.data[byte_idx] & (1 << bit_idx) == 0 {
                    return false;
                }
            }
        }
        true
    }

    /// Get filter size in bytes
    pub fn size_bytes(&self) -> usize {
        self.data.len()
    }
}

// =============================================================================
// Bloom Filter Implementation
// =============================================================================

/// Bloom filter policy
#[derive(Debug)]
pub struct BloomFilterPolicy {
    /// Target false positive rate
    fpr: FPR,
    /// Bits per key (computed from FPR)
    bits_per_key: f64,
    /// Number of hash functions
    num_hashes: usize,
}

impl BloomFilterPolicy {
    /// Create a new Bloom filter policy with target FPR
    pub fn new(fpr: FPR) -> Self {
        // Optimal bits per key: -log₂(p) / ln(2) ≈ -1.44 × log₂(p)
        let bits_per_key = -fpr.log2() / 2.0_f64.ln();
        // Optimal number of hash functions: bits_per_key × ln(2) ≈ 0.693 × bits_per_key
        let num_hashes = (bits_per_key * 2.0_f64.ln()).round() as usize;

        Self {
            fpr,
            bits_per_key,
            num_hashes: num_hashes.max(1).min(30), // Clamp to reasonable range
        }
    }

    /// Create with specific bits per key
    pub fn with_bits_per_key(bits_per_key: f64) -> Self {
        let num_hashes = (bits_per_key * 2.0_f64.ln()).round() as usize;
        // FPR ≈ (1 - e^(-k×n/m))^k ≈ (0.6185)^bits_per_key for optimal k
        let fpr = 0.6185_f64.powf(bits_per_key);

        Self {
            fpr,
            bits_per_key,
            num_hashes: num_hashes.max(1).min(30),
        }
    }
}

impl FilterPolicy for BloomFilterPolicy {
    fn name(&self) -> &str {
        "bloom"
    }

    fn create_builder(&self, num_keys: usize) -> Box<dyn FilterBuilder> {
        Box::new(BloomFilterBuilder::new(
            num_keys,
            self.bits_per_key,
            self.num_hashes,
        ))
    }

    fn create_filter(&self, data: Vec<u8>) -> Box<dyn Filter> {
        Box::new(BloomFilter::new(data, self.num_hashes))
    }

    fn bits_per_key(&self) -> f64 {
        self.bits_per_key
    }

    fn target_fpr(&self) -> FPR {
        self.fpr
    }
}

/// Bloom filter builder
struct BloomFilterBuilder {
    bits: Vec<u64>,
    num_bits: usize,
    num_hashes: usize,
    num_keys: usize,
}

impl BloomFilterBuilder {
    fn new(expected_keys: usize, bits_per_key: f64, num_hashes: usize) -> Self {
        let num_bits = ((expected_keys as f64 * bits_per_key).ceil() as usize).max(64);
        let num_words = num_bits.div_ceil(64);

        Self {
            bits: vec![0; num_words],
            num_bits,
            num_hashes,
            num_keys: 0,
        }
    }
}

impl FilterBuilder for BloomFilterBuilder {
    fn add_key(&mut self, key: &[u8]) {
        let h1 = hash1(key);
        let h2 = hash2(key);

        for i in 0..self.num_hashes {
            let h = h1.wrapping_add((i as u64).wrapping_mul(h2));
            let bit_idx = (h as usize) % self.num_bits;
            let word_idx = bit_idx / 64;
            let bit_pos = bit_idx % 64;
            self.bits[word_idx] |= 1u64 << bit_pos;
        }

        self.num_keys += 1;
    }

    fn finish(&mut self) -> Vec<u8> {
        use byteorder::{LittleEndian, WriteBytesExt};

        let mut result = Vec::with_capacity(self.bits.len() * 8 + 8);

        // Write bits
        for &word in &self.bits {
            result.write_u64::<LittleEndian>(word).unwrap();
        }

        // Write metadata
        result
            .write_u32::<LittleEndian>(self.num_hashes as u32)
            .unwrap();
        result
            .write_u32::<LittleEndian>(self.num_bits as u32)
            .unwrap();

        result
    }

    fn num_keys(&self) -> usize {
        self.num_keys
    }
}

/// Bloom filter for queries
struct BloomFilter {
    bits: Vec<u64>,
    num_bits: usize,
    num_hashes: usize,
}

impl BloomFilter {
    fn new(data: Vec<u8>, default_num_hashes: usize) -> Self {
        use byteorder::{LittleEndian, ReadBytesExt};
        use std::io::Cursor;

        if data.len() < 8 {
            return Self {
                bits: Vec::new(),
                num_bits: 0,
                num_hashes: default_num_hashes,
            };
        }

        // Read metadata from end
        let mut cursor = Cursor::new(&data[data.len() - 8..]);
        let num_hashes = cursor
            .read_u32::<LittleEndian>()
            .unwrap_or(default_num_hashes as u32) as usize;
        let num_bits = cursor.read_u32::<LittleEndian>().unwrap_or(0) as usize;

        // Read bits
        let bits_data = &data[..data.len() - 8];
        let mut bits = Vec::with_capacity(bits_data.len() / 8);
        let mut cursor = Cursor::new(bits_data);
        while let Ok(word) = cursor.read_u64::<LittleEndian>() {
            bits.push(word);
        }

        Self {
            bits,
            num_bits,
            num_hashes,
        }
    }
}

impl Filter for BloomFilter {
    fn may_contain(&self, key: &[u8]) -> bool {
        if self.bits.is_empty() || self.num_bits == 0 {
            return true; // Empty filter = must check data
        }

        let h1 = hash1(key);
        let h2 = hash2(key);

        for i in 0..self.num_hashes {
            let h = h1.wrapping_add((i as u64).wrapping_mul(h2));
            let bit_idx = (h as usize) % self.num_bits;
            let word_idx = bit_idx / 64;
            let bit_pos = bit_idx % 64;

            if word_idx >= self.bits.len() || self.bits[word_idx] & (1u64 << bit_pos) == 0 {
                return false;
            }
        }

        true
    }

    fn size_bytes(&self) -> usize {
        self.bits.len() * 8 + 8
    }
}

// =============================================================================
// Ribbon Filter Implementation (Near-Optimal Space)
// =============================================================================

/// Ribbon filter policy
///
/// Ribbon filters use a banded matrix construction to achieve near-optimal
/// space efficiency. They approach the information-theoretic minimum of
/// log₂(1/p) bits per key.
#[derive(Debug)]
pub struct RibbonFilterPolicy {
    /// Target false positive rate
    fpr: FPR,
    /// Bits per key (computed from FPR)
    bits_per_key: f64,
}

impl RibbonFilterPolicy {
    /// Create a new Ribbon filter policy with target FPR
    pub fn new(fpr: FPR) -> Self {
        // Ribbon achieves ~log₂(1/p) bits per key
        let bits_per_key = -fpr.log2();

        Self { fpr, bits_per_key }
    }
}

impl FilterPolicy for RibbonFilterPolicy {
    fn name(&self) -> &str {
        "ribbon"
    }

    fn create_builder(&self, num_keys: usize) -> Box<dyn FilterBuilder> {
        Box::new(RibbonFilterBuilder::new(num_keys, self.bits_per_key))
    }

    fn create_filter(&self, data: Vec<u8>) -> Box<dyn Filter> {
        Box::new(RibbonFilter::new(data))
    }

    fn bits_per_key(&self) -> f64 {
        self.bits_per_key
    }

    fn target_fpr(&self) -> FPR {
        self.fpr
    }
}

/// Ribbon filter builder
///
/// Uses a simplified ribbon construction. A full implementation would use
/// banded matrix solving for optimal space.
struct RibbonFilterBuilder {
    /// Fingerprints for each key
    fingerprints: Vec<u64>,
    /// Bits per fingerprint
    fingerprint_bits: usize,
    /// Number of slots (keys × overhead)
    num_slots: usize,
}

impl RibbonFilterBuilder {
    fn new(expected_keys: usize, bits_per_key: f64) -> Self {
        let fingerprint_bits = bits_per_key.ceil() as usize;
        // Add some overhead for the ribbon construction
        let num_slots = ((expected_keys as f64) * 1.05).ceil() as usize;

        Self {
            fingerprints: Vec::with_capacity(expected_keys),
            fingerprint_bits,
            num_slots,
        }
    }
}

impl FilterBuilder for RibbonFilterBuilder {
    fn add_key(&mut self, key: &[u8]) {
        // Compute fingerprint
        let h = hash1(key);
        let fingerprint = h & ((1u64 << self.fingerprint_bits) - 1);
        self.fingerprints.push(fingerprint);
    }

    fn finish(&mut self) -> Vec<u8> {
        use byteorder::{LittleEndian, WriteBytesExt};

        // Simplified: store fingerprints directly
        // A full ribbon would solve a banded matrix

        let mut result = Vec::new();

        // Write metadata
        result
            .write_u32::<LittleEndian>(self.fingerprints.len() as u32)
            .unwrap();
        result
            .write_u32::<LittleEndian>(self.fingerprint_bits as u32)
            .unwrap();

        // Write fingerprints (simplified - could pack more efficiently)
        for &fp in &self.fingerprints {
            result.write_u64::<LittleEndian>(fp).unwrap();
        }

        result
    }

    fn num_keys(&self) -> usize {
        self.fingerprints.len()
    }
}

/// Ribbon filter for queries
struct RibbonFilter {
    fingerprints: Vec<u64>,
    fingerprint_bits: usize,
}

impl RibbonFilter {
    fn new(data: Vec<u8>) -> Self {
        use byteorder::{LittleEndian, ReadBytesExt};
        use std::io::Cursor;

        if data.len() < 8 {
            return Self {
                fingerprints: Vec::new(),
                fingerprint_bits: 0,
            };
        }

        let mut cursor = Cursor::new(&data[..8]);
        let num_keys = cursor.read_u32::<LittleEndian>().unwrap_or(0) as usize;
        let fingerprint_bits = cursor.read_u32::<LittleEndian>().unwrap_or(0) as usize;

        let mut fingerprints = Vec::with_capacity(num_keys);
        let mut cursor = Cursor::new(&data[8..]);
        while let Ok(fp) = cursor.read_u64::<LittleEndian>() {
            fingerprints.push(fp);
        }

        Self {
            fingerprints,
            fingerprint_bits,
        }
    }
}

impl Filter for RibbonFilter {
    fn may_contain(&self, key: &[u8]) -> bool {
        if self.fingerprints.is_empty() {
            return true;
        }

        let h = hash1(key);
        let fingerprint = h & ((1u64 << self.fingerprint_bits) - 1);

        // Simplified: linear search (full ribbon would use hash to index)
        // This is placeholder - real ribbon uses banded matrix lookup
        self.fingerprints.iter().any(|&fp| fp == fingerprint)
    }

    fn size_bytes(&self) -> usize {
        8 + self.fingerprints.len() * 8
    }
}

// =============================================================================
// Xor Filter Implementation
// =============================================================================

/// Xor filter policy
///
/// Xor filters are simple and fast to query, but require all keys to be known
/// upfront during construction.
#[derive(Debug)]
pub struct XorFilterPolicy {
    /// Target false positive rate
    fpr: FPR,
    /// Bits per key
    bits_per_key: f64,
}

impl XorFilterPolicy {
    /// Create a new Xor filter policy with target FPR
    pub fn new(fpr: FPR) -> Self {
        // Xor filters achieve ~1.23 × log₂(1/p) bits per key
        let bits_per_key = -fpr.log2() * 1.23;

        Self { fpr, bits_per_key }
    }
}

impl FilterPolicy for XorFilterPolicy {
    fn name(&self) -> &str {
        "xor"
    }

    fn create_builder(&self, num_keys: usize) -> Box<dyn FilterBuilder> {
        Box::new(XorFilterBuilder::new(num_keys, self.bits_per_key))
    }

    fn create_filter(&self, data: Vec<u8>) -> Box<dyn Filter> {
        Box::new(XorFilter::new(data))
    }

    fn bits_per_key(&self) -> f64 {
        self.bits_per_key
    }

    fn target_fpr(&self) -> FPR {
        self.fpr
    }
}

/// Xor filter builder
struct XorFilterBuilder {
    keys: Vec<Vec<u8>>,
    fingerprint_bits: usize,
}

impl XorFilterBuilder {
    fn new(_expected_keys: usize, bits_per_key: f64) -> Self {
        Self {
            keys: Vec::new(),
            fingerprint_bits: bits_per_key.ceil() as usize,
        }
    }
}

impl FilterBuilder for XorFilterBuilder {
    fn add_key(&mut self, key: &[u8]) {
        self.keys.push(key.to_vec());
    }

    fn finish(&mut self) -> Vec<u8> {
        use byteorder::{LittleEndian, WriteBytesExt};

        // Simplified: store all key hashes
        // A real xor filter would use the 3-wise xor construction

        let mut result = Vec::new();

        result
            .write_u32::<LittleEndian>(self.keys.len() as u32)
            .unwrap();
        result
            .write_u32::<LittleEndian>(self.fingerprint_bits as u32)
            .unwrap();

        for key in &self.keys {
            let h = hash1(key);
            let fp = h & ((1u64 << self.fingerprint_bits) - 1);
            result.write_u64::<LittleEndian>(fp).unwrap();
        }

        result
    }

    fn num_keys(&self) -> usize {
        self.keys.len()
    }
}

/// Xor filter for queries
struct XorFilter {
    fingerprints: Vec<u64>,
    fingerprint_bits: usize,
}

impl XorFilter {
    fn new(data: Vec<u8>) -> Self {
        use byteorder::{LittleEndian, ReadBytesExt};
        use std::io::Cursor;

        if data.len() < 8 {
            return Self {
                fingerprints: Vec::new(),
                fingerprint_bits: 0,
            };
        }

        let mut cursor = Cursor::new(&data[..8]);
        let num_keys = cursor.read_u32::<LittleEndian>().unwrap_or(0) as usize;
        let fingerprint_bits = cursor.read_u32::<LittleEndian>().unwrap_or(0) as usize;

        let mut fingerprints = Vec::with_capacity(num_keys);
        let mut cursor = Cursor::new(&data[8..]);
        while let Ok(fp) = cursor.read_u64::<LittleEndian>() {
            fingerprints.push(fp);
        }

        Self {
            fingerprints,
            fingerprint_bits,
        }
    }
}

impl Filter for XorFilter {
    fn may_contain(&self, key: &[u8]) -> bool {
        if self.fingerprints.is_empty() {
            return true;
        }

        let h = hash1(key);
        let fingerprint = h & ((1u64 << self.fingerprint_bits) - 1);

        // Simplified: linear search
        self.fingerprints.iter().any(|&fp| fp == fingerprint)
    }

    fn size_bytes(&self) -> usize {
        8 + self.fingerprints.len() * 8
    }
}

// =============================================================================
// Hash Functions
// =============================================================================

/// First hash function (xxHash)
fn hash1(key: &[u8]) -> u64 {
    twox_hash::xxh3::hash64(key)
}

/// Second hash function (using different seed/algorithm)
fn hash2(key: &[u8]) -> u64 {
    use std::collections::hash_map::DefaultHasher;
    let mut hasher = DefaultHasher::new();
    key.hash(&mut hasher);
    hasher.finish()
}

// =============================================================================
// Multi-Level Filter Cascade
// =============================================================================

/// Multi-level filter cascade for combined FPR
///
/// Combines multiple filters in cascade to achieve very low false positive rates
/// while maintaining space efficiency.
///
/// Combined FPR = FPR₁ × FPR₂ × ... × FPRₙ
///
/// Example: Two 10% FPR filters in cascade = 1% combined FPR
pub struct FilterCascade {
    filters: Vec<Box<dyn Filter>>,
    combined_fpr: FPR,
}

impl FilterCascade {
    /// Create a new filter cascade
    pub fn new() -> Self {
        Self {
            filters: Vec::new(),
            combined_fpr: 1.0,
        }
    }

    /// Add a filter level
    pub fn add_level(&mut self, filter: Box<dyn Filter>, fpr: FPR) {
        self.filters.push(filter);
        self.combined_fpr *= fpr;
    }

    /// Check if key may be present (must pass all levels)
    pub fn may_contain(&self, key: &[u8]) -> bool {
        self.filters.iter().all(|f| f.may_contain(key))
    }

    /// Get combined false positive rate
    pub fn combined_fpr(&self) -> FPR {
        self.combined_fpr
    }

    /// Get number of levels
    pub fn num_levels(&self) -> usize {
        self.filters.len()
    }
}

impl Default for FilterCascade {
    fn default() -> Self {
        Self::new()
    }
}

// =============================================================================
// Tests
// =============================================================================

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_bloom_filter_basic() {
        let policy = BloomFilterPolicy::new(0.01);
        let mut builder = policy.create_builder(1000);

        for i in 0..1000 {
            let key = format!("key{}", i);
            builder.add_key(key.as_bytes());
        }

        let data = builder.finish();
        let filter = policy.create_filter(data);

        // All inserted keys should return true
        for i in 0..1000 {
            let key = format!("key{}", i);
            assert!(filter.may_contain(key.as_bytes()));
        }

        // Some non-inserted keys may return true (false positives)
        // but rate should be approximately 1%
        let mut false_positives = 0;
        for i in 1000..2000 {
            let key = format!("key{}", i);
            if filter.may_contain(key.as_bytes()) {
                false_positives += 1;
            }
        }

        // Allow up to 5% (due to statistical variation on small sample)
        assert!(
            false_positives < 50,
            "Too many false positives: {}",
            false_positives
        );
    }

    #[test]
    fn test_bloom_bits_per_key() {
        let policy = BloomFilterPolicy::with_bits_per_key(10.0);
        assert!((policy.bits_per_key() - 10.0).abs() < 0.01);
    }

    #[test]
    fn test_filter_cascade() {
        let policy1 = BloomFilterPolicy::new(0.1);
        let policy2 = BloomFilterPolicy::new(0.1);

        // Build filters
        let mut builder1 = policy1.create_builder(100);
        let mut builder2 = policy2.create_builder(100);

        for i in 0..100 {
            let key = format!("key{}", i);
            builder1.add_key(key.as_bytes());
            builder2.add_key(key.as_bytes());
        }

        let filter1 = policy1.create_filter(builder1.finish());
        let filter2 = policy2.create_filter(builder2.finish());

        let mut cascade = FilterCascade::new();
        cascade.add_level(filter1, 0.1);
        cascade.add_level(filter2, 0.1);

        // Combined FPR should be ~0.01
        assert!((cascade.combined_fpr() - 0.01).abs() < 0.001);

        // All inserted keys should pass
        for i in 0..100 {
            let key = format!("key{}", i);
            assert!(cascade.may_contain(key.as_bytes()));
        }
    }

    #[test]
    fn test_empty_filter() {
        let policy = BloomFilterPolicy::new(0.01);
        let filter = policy.create_filter(Vec::new());

        // Empty filter should return true (conservative)
        assert!(filter.may_contain(b"any_key"));
    }
}