snmp_rust_agent 0.4.0

A framework for building SNMP v3 Agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
//! Implementation of Agent
//!
//! Agent is the basic run time service.  See main.rs for a simple example of how
//! it might be used.

use crate::keeper;
use crate::keeper::OidErr;
use crate::notifier;
use crate::oidmap::{ContextMap, OidMap};
use crate::perms::FlagPerm;
use crate::privacy;
use crate::usm;
use log::{debug, error, warn};
use rasn;
use rasn::types::{Integer, ObjectIdentifier, OctetString};
use rasn_smi::v2::{ObjectSyntax, SimpleSyntax};
use rasn_snmp::v2::{Pdu, Report, VarBind};
use rasn_snmp::v3::VarBindValue;
use rasn_snmp::v3::{GetBulkRequest, GetNextRequest, GetRequest, SetRequest};
use rasn_snmp::v3::{HeaderData, Message, Pdus, ScopedPdu, USMSecurityParameters};
use rasn_snmp::v3::{Response, ScopedPduData};
use std::collections::HashSet;
use std::fmt::Display;
use std::fs::{read_to_string, write};
use std::net::{SocketAddr, UdpSocket};
use std::str::FromStr;
use std::sync::mpsc::Sender;
use std::thread::sleep;
use std::time::{Duration, Instant};

const BOOT_CNT_FILENAME: &str = "boot-cnt.txt";
const Z12: OctetString = OctetString::from_static(&[0u8; 12]);
const Z16: OctetString = OctetString::from_static(&[0u8; 16]);
const Z24: OctetString = OctetString::from_static(&[0u8; 24]);
const Z32: OctetString = OctetString::from_static(&[0u8; 32]);
const Z48: OctetString = OctetString::from_static(&[0u8; 48]);
const ZB: OctetString = OctetString::from_static(b"");

const ARC_COLD_START: [u32; 10] = [1, 3, 6, 1, 6, 3, 1, 1, 5, 1];
const ARC_AUTHENTICATION_FAILURE: [u32; 10] = [1, 3, 6, 1, 6, 3, 1, 1, 5, 5];
/// Get the boot count from non-volatile storage, creating file if it does not exist.
/// Panic if the file cannot be parsed or updated, as that indicates tampering or hardware failure.
/// This function is not really thread safe, but the retry makes it robust in practice for testing
/// and actual normal use is strictly single threaded.
fn get_increment_boot_cnt() -> isize {
    let mut boots: isize = 0;
    let mut retry_counter = 0;
    loop {
        let cnt_res: Result<String, std::io::Error> = read_to_string(BOOT_CNT_FILENAME);
        if let Ok(string) = cnt_res {
            if let Ok(parse) = isize::from_str(string.trim()) {
                boots = parse;
                break;
            }
        } else {
            break;
        }
        retry_counter += 1;
        sleep(Duration::new(0, 10000)); // 10ms sleep, long enough for other thread to clear off
        if retry_counter > 10 {
            panic!("Boot count not parsed after 10 retries - probably corrupted file or hardware failure.");
        }
    }
    boots += 1;
    write(BOOT_CNT_FILENAME, boots.to_string().as_bytes()).unwrap(); // Startup, panic if write fails
    boots
}

/// Utility struct used to group related arguments together
struct PduArg {
    error_index: u32,
    error_status: u32,
    vb_cnt: u32,
}

/// Main Agent object.
pub struct Agent {
    socket: UdpSocket,
    engine_id: OctetString,
    pub start_time: Instant,
    boots: isize,
    pub in_pkts: u64,
    pub unknown_users: u32,
    pub wrong_digests: u32,
    pub not_in_time_window: u32,
    pub unknown_engine_ids: u32,
    pub decode_error_cnt: u32,
    pub decryption_errors: u32,
    pub unknown_contexts: u32,
    notifier: Option<Sender<notifier::Notification>>,
    send_auth_fails: bool,
}

impl Agent {
    /// Constructor for Agent
    ///
    /// eid is the engine id.
    ///
    /// addr_str is the address to listen on - often "0.0.0.0:161" can be a good choice
    /// But systems with multiple interfaces (like a firewall, router or crypto) might only listen
    /// on an internal address.
    pub fn build(eid: OctetString, addr_str: &str, send_auth_fails: bool) -> Self {
        let sock = UdpSocket::bind(addr_str).expect("Couldn't bind to address");

        Agent {
            socket: sock,
            engine_id: eid,
            start_time: Instant::now(),
            boots: get_increment_boot_cnt(),
            in_pkts: 0u64,
            unknown_users: 0u32,
            wrong_digests: 0u32,
            not_in_time_window: 0u32,
            unknown_engine_ids: 0u32,
            decode_error_cnt: 0u32,
            decryption_errors: 0u32,
            unknown_contexts: 0u32,
            notifier: None,
            send_auth_fails,
        }
    }

    /// Create a notifier thread.
    pub fn start_notifier(&mut self, sink: &str, community: &str) {
        let not = notifier::Notification {
            name: ObjectIdentifier::new(&ARC_COLD_START).unwrap(), // Checked , known good ARC
            vb: vec![],
        };
        let notifier =
            notifier::Notifier::start(sink, community, self.engine_id.clone(), self.start_time);
        notifier.send(not).expect("Send failure"); // ??? should we fail, or just warn and carry on??
        self.notifier = Some(notifier);
    }

    /// Internal method for supporting engine ID discovery by managers
    fn id_response(&self, request_id: i32, message_id: Integer) -> Message {
        let vb: Vec<VarBind> = vec![VarBind {
            name: ObjectIdentifier::new_unchecked(vec![1, 3, 6, 1, 6, 3, 15, 1, 1, 4].into()),
            value: VarBindValue::Unspecified,
        }];
        self.report(request_id, message_id, vb)
    }

    /// Internal method for supporting engine ID discovery by managers
    fn unknown_user(&self, request_id: i32, message_id: Integer) -> Message {
        let vb: Vec<VarBind> = vec![VarBind {
            name: ObjectIdentifier::new_unchecked(vec![1, 3, 6, 1, 6, 3, 15, 1, 1, 3, 0].into()),
            value: VarBindValue::Value(ObjectSyntax::Simple(SimpleSyntax::Integer(Integer::from(
                1,
            )))),
        }];
        self.report(request_id, message_id, vb)
    }

    /// Internal method for supporting engine ID discovery by managers
    fn auth_failure(&self, request_id: i32, message_id: Integer) -> Message {
        let vb: Vec<VarBind> = vec![VarBind {
            name: ObjectIdentifier::new_unchecked(vec![1, 3, 6, 1, 6, 3, 15, 1, 1, 5, 0].into()),
            value: VarBindValue::Value(ObjectSyntax::Simple(SimpleSyntax::Integer(Integer::from(
                1,
            )))),
        }];
        self.report(request_id, message_id, vb)
    }
    /// Utility method for sending reports
    ///
    fn report(&self, request_id: i32, message_id: Integer, vb: Vec<VarBind>) -> Message {
        let pdu = Pdu {
            request_id,
            error_index: 0,
            error_status: 0,
            variable_bindings: vb,
        };
        let report: Report = Report(pdu);
        let head = HeaderData {
            flags: OctetString::from_static(b"\x00"),
            message_id,
            max_size: Integer::from(65000),
            security_model: Integer::from(3),
        };
        let scpd: ScopedPdu = ScopedPdu {
            engine_id: self.engine_id.clone(),
            name: OctetString::from_static(b""),
            data: Pdus::Report(report),
        };
        let spd: ScopedPduData = ScopedPduData::CleartextPdu(scpd);
        let run_time: isize = self
            .start_time
            .elapsed()
            .as_secs()
            .try_into()
            .unwrap_or(isize::MAX);
        let usm: USMSecurityParameters = USMSecurityParameters {
            authoritative_engine_boots: Integer::from(self.boots),
            authoritative_engine_id: self.engine_id.clone(),
            authoritative_engine_time: Integer::from(run_time),
            user_name: ZB,
            authentication_parameters: ZB,
            privacy_parameters: ZB,
        };
        let mut message: Message = Message {
            version: Integer::from(3),
            global_data: head,
            scoped_data: spd,
            security_parameters: ZB,
        };
        _ = message.encode_security_parameters(rasn::Codec::Ber, &usm);
        message
    }

    /// Internal method that builds response packets.
    fn prepare_back(
        &self,
        message_id: Integer,
        resp: Response,
        user: &usm::User,
        usp: USMSecurityParameters,
        encrypted: bool,
    ) -> Message {
        // Return message with matching ids etc.
        let head = HeaderData {
            flags: OctetString::from_static(b"\x00"),
            message_id,
            max_size: Integer::from(65000),
            security_model: Integer::from(3),
        };
        let scpd: ScopedPdu = ScopedPdu {
            engine_id: self.engine_id.clone(),
            name: ZB,
            data: Pdus::Response(resp),
        };
        let user_name = OctetString::from_slice(&user.name);

        let mut spd: ScopedPduData = ScopedPduData::CleartextPdu(scpd);
        let run_time: isize = self
            .start_time
            .elapsed()
            .as_secs()
            .try_into()
            .unwrap_or(isize::MAX);
        let mut usm: USMSecurityParameters = USMSecurityParameters {
            authoritative_engine_boots: Integer::from(self.boots),
            authoritative_engine_id: self.engine_id.clone(),
            authoritative_engine_time: Integer::from(run_time),
            user_name,
            authentication_parameters: ZB,
            privacy_parameters: ZB,
        };
        if encrypted {
            usm.privacy_parameters = usp.privacy_parameters.clone();
            let key = &user.priv_key.borrow();
            let enc_octs = rasn::ber::encode(&spd).unwrap(); // Checked spd constructed by safe rust code, so should encode
            let value: Vec<u8> = privacy::encrypt(&mut enc_octs.to_vec(), usp, key);
            spd = ScopedPduData::EncryptedPdu(OctetString::from(value));
        }
        let mut output: Message = Message {
            version: Integer::from(3),
            global_data: head,
            scoped_data: spd,
            security_parameters: ZB,
        };

        _ = output.encode_security_parameters(rasn::Codec::Ber, &usm); // FIXME Should check return value
        output
    }

    fn get(
        &self,
        oid_map: &mut OidMap,
        r: GetRequest,
        vb: &mut Vec<VarBind>,
        perm: &FlagPerm,
    ) -> (u32, u32, i32) {
        let mut error_status = Pdu::ERROR_STATUS_NO_ERROR;
        let mut error_index = 0;
        let request_id = r.0.request_id;
        let mut vb_cnt = 0;
        for vbind in r.0.variable_bindings {
            let roid = vbind.name.clone();
            if !perm.check(false, &roid) {
                error_status = Pdu::ERROR_STATUS_NO_ACCESS;
                error_index = vb_cnt;
                return (error_status, error_index, request_id);
            }
            let opt_get: Result<usize, usize> = oid_map.search(&roid);
            match opt_get {
                Err(insert_point) => {
                    debug!("Get miss case {insert_point}");
                    error_status = Pdu::ERROR_STATUS_NO_SUCH_NAME;
                    vb.push(VarBind {
                        name: roid,
                        value: VarBindValue::NoSuchObject,
                    });
                    error_index = vb_cnt;
                    break;
                }
                Ok(which) => {
                    vb_cnt += 1;
                    let okeep = &mut oid_map.idx(which);
                    let value_res = okeep.get(roid.clone());
                    if let Ok(value) = value_res {
                        vb.push(VarBind {
                            name: roid.clone(),
                            value,
                        });
                    } else {
                        error_status = Pdu::ERROR_STATUS_NO_SUCH_NAME;
                        vb.push(VarBind {
                            name: roid,
                            value: VarBindValue::NoSuchInstance,
                        });
                        error_index = vb_cnt;
                        break;
                    }
                }
            }
        }
        (error_status, error_index, request_id)
    }

    /// Internal utility function used by get_next and get_bulk
    ///
    /// Simplified algorithm, gets more error cases correct.
    fn do_next(
        &self,
        roid: ObjectIdentifier,
        oid_map: &mut OidMap,
        vb: &mut Vec<VarBind>,
        //error_status: &mut u32,
        //error_index: &mut u32,
        //vb_cnt: u32,
        parg: &mut PduArg,
        perm: &FlagPerm,
    ) {
        // From RFC3416:
        //
        //   The variable is located which is in the lexicographically
        //   ordered list of the names of all variables which are
        //   accessible by this request and whose name is the first
        //   lexicographic successor of the variable binding's name in
        //   the incoming GetNextRequest-PDU.  The corresponding variable
        //   binding's name and value fields in the Response-PDU are set
        //   to the name and value of the located variable.
        //
        // In other words, we need to look at permissions and the object access,
        // and skip over anything we cannot read. The complication arises for tables,
        // which have internal content and access.
        let opt_get: Result<usize, usize> = oid_map.search(&roid);
        let mut oid1 = roid.clone();
        debug!(
            "Perm group is {}",
            String::from_utf8(perm.perm.group_name.clone()).expect("nasty")
        );

        let mut cnt;
        match opt_get {
            Err(insert_point) => {
                if insert_point >= oid_map.len() {
                    debug!("miss case {insert_point} >= oid_map.len()");
                    vb.push(VarBind {
                        name: roid.clone(),
                        value: VarBindValue::EndOfMibView,
                    });
                    return;
                }
                cnt = insert_point;
            }
            Ok(which) => {
                if oid_map.idx(which).is_scalar(roid.clone()) {
                    cnt = which + 1;
                    oid1 = oid_map.oid(cnt).clone();
                } else {
                    cnt = which;
                }
            }
        }
        debug!("Entering loop oid is {oid1:?}");
        loop {
            //let oid1 = oid_map.oid(cnt).clone();
            if perm.check(false, &oid1) {
                let keep = oid_map.idx(cnt);

                let acc = if keep.is_scalar(oid1.clone()) {
                    keep.access(oid1.clone())
                } else {
                    keeper::Access::ReadOnly
                };

                if (acc == keeper::Access::ReadOnly
                    || acc == keeper::Access::ReadWrite
                    || acc == keeper::Access::ReadCreate)
                    && !keep.is_empty()
                {
                    if keep.is_scalar(oid1.clone()) {
                        let value_res = keep.get(oid1.clone());
                        match value_res {
                            Ok(value) => {
                                vb.push(VarBind {
                                    name: oid_map.oid(cnt).clone(),
                                    value,
                                });
                                return;
                            }
                            Err(_err) => {
                                // FIXME map errors
                                parg.error_index = parg.vb_cnt;
                                parg.error_status = Pdu::ERROR_STATUS_GEN_ERR;
                                vb.push(VarBind {
                                    name: oid1.clone(),
                                    value: VarBindValue::Unspecified,
                                });
                                return;
                            }
                        };
                    } else {
                        match keep.get_next(oid1.clone()) {
                            Ok(bind) => {
                                vb.push(bind);
                                return;
                            }
                            // FIXME, map errors here - could be empty table!
                            Err(_) => {
                                /*  vb.push(VarBind {
                                    name: oid1.clone(),
                                    value: VarBindValue::EndOfMibView,
                                });
                                return; */
                            }
                        }
                    }
                }
            }
            cnt += 1;
            if cnt >= oid_map.len() {
                vb.push(VarBind {
                    name: oid1.clone(),
                    value: VarBindValue::EndOfMibView,
                });
                return;
            }
            oid1 = oid_map.oid(cnt).clone();
            debug!("After increment {} {:?}", cnt, oid1);
        }
    }

    fn getnext(
        &self,
        oid_map: &mut OidMap,
        r: GetNextRequest,
        vb: &mut Vec<VarBind>,
        perm: &FlagPerm,
    ) -> (u32, u32, i32) {
        let error_status = Pdu::ERROR_STATUS_NO_ERROR;
        let error_index = 0u32;
        let request_id = r.0.request_id;
        for (vb_cnt, vbind) in r.0.variable_bindings.iter().enumerate() {
            let roid = vbind.name.clone();
            let mut parg = PduArg {
                error_index,
                error_status,
                vb_cnt: vb_cnt.try_into().unwrap(), // Checked, Varbinds hve to fit in 65K, so can't be more than a few thousand at very most.
            };
            self.do_next(roid, oid_map, vb, &mut parg, perm);
            if parg.error_status != Pdu::ERROR_STATUS_NO_ERROR {
                return (parg.error_status, parg.error_index, request_id);
            }
        }
        (error_status, error_index, request_id)
    }

    /// Make changes!
    ///
    /// Current implementation does not return full set of errors.
    ///
    /// Changes are performed in a transaction.
    ///
    fn set(
        &self,
        oid_map: &mut OidMap,
        r: SetRequest,
        vb: &mut Vec<VarBind>,
        perm: &FlagPerm,
        user: &usm::User,
    ) -> (u32, u32, i32) {
        let mut keeps = HashSet::<usize>::new();
        let mut error_status = Pdu::ERROR_STATUS_NO_ERROR;
        let mut error_index = 0;
        let request_id = r.0.request_id;
        let mut vb_cnt = 0;
        for vbind in &r.0.variable_bindings {
            let roid = vbind.name.clone();
            let opt_set: Result<usize, usize> = oid_map.search(&roid);
            match opt_set {
                Err(_) => debug!("Miss gathering handlers"),
                Ok(indx) => {
                    keeps.insert(indx);
                }
            }
        }
        for indx in &keeps {
            let okeep = oid_map.idx(*indx);
            let _ = okeep.begin_transaction();
        }
        for vbind in r.0.variable_bindings {
            let roid = vbind.name.clone();

            if !perm.check(true, &roid) {
                error_status = Pdu::ERROR_STATUS_NO_ACCESS;
                error_index = vb_cnt;
                break;
            }
            let opt_set: Result<usize, usize> = oid_map.search(&roid);
            match opt_set {
                Err(insert_point) => {
                    debug!("Set miss case {insert_point}");
                    let okeep = &mut oid_map.idx(insert_point - 1);
                    if okeep.is_scalar(roid.clone()) {
                        debug!("Scalar set miss"); // This should error and generate a report?
                        error_status = Pdu::ERROR_STATUS_NO_SUCH_NAME;
                        error_index = vb_cnt;
                        vb.push(VarBind {
                            name: roid,
                            value: VarBindValue::NoSuchObject,
                        });
                        break;
                    } else {
                        debug!("Table set ");
                        let set_res = okeep.set(roid.clone(), vbind.value, user);
                        debug!("Table set {set_res:?}");
                        match set_res {
                            Ok(res) => vb.push(VarBind {
                                name: roid.clone(),
                                value: res,
                            }),
                            Err(_) => {
                                error_status = Pdu::ERROR_STATUS_NO_SUCH_NAME;
                                vb.push(VarBind {
                                    name: roid,
                                    value: VarBindValue::NoSuchObject,
                                });
                            }
                        }
                    }
                }
                Ok(which) => {
                    vb_cnt += 1;
                    let okeep = &mut oid_map.idx(which);
                    let set_result = (**okeep).set(roid.clone(), vbind.value.clone(), user);
                    if let Err(OidErr::WrongType) = set_result {
                        // FIXME Need to catch size, data type etc
                        error_status = Pdu::ERROR_STATUS_WRONG_TYPE;
                        vb.push(VarBind {
                            name: roid.clone(),
                            value: vbind.value,
                        });
                    } else {
                        let svalue = set_result.unwrap(); // Checked, Error caught above

                        vb.push(VarBind {
                            name: roid.clone(),
                            value: svalue,
                        });
                    }
                }
            }
        }
        for indx in &keeps {
            let keep = oid_map.idx(*indx);
            if error_status == Pdu::ERROR_STATUS_NO_ERROR {
                let cres = keep.commit(user);
                if cres.is_err() {
                    error_status = Pdu::ERROR_STATUS_COMMIT_FAILED;
                    break;
                }
            } else {
                let rres = keep.rollback();
                if rres.is_err() {
                    error_status = Pdu::ERROR_STATUS_UNDO_FAILED;
                }
            }
        }
        (error_status, error_index, request_id)
    }

    fn bulk(
        &self,
        oid_map: &mut OidMap,
        r: GetBulkRequest,
        vb: &mut Vec<VarBind>,
        perm: &FlagPerm,
    ) -> (u32, u32, i32) {
        let error_status = Pdu::ERROR_STATUS_NO_ERROR;
        let error_index = 0;
        let mut vb_cnt = 0u32;
        let request_id = r.0.request_id;
        // FIXME should error if unreasonably big -
        let non_repeaters: usize = r.0.non_repeaters.try_into().unwrap(); // Checked U32 fits into usize execpt on microcontrollers
        let max_repeats = r.0.max_repetitions;
        let mut rep_oids: Vec<ObjectIdentifier> = vec![];
        for (n, vbind) in r.0.variable_bindings.iter().enumerate() {
            if n < non_repeaters {
                let roid = vbind.name.clone();
                let mut parg = PduArg {
                    error_index,
                    error_status,
                    vb_cnt,
                }; // Checked Packet is 65K max, so at most a few thousand Varbinds, easily fits in u32
                self.do_next(roid, oid_map, vb, &mut parg, perm);
                if parg.error_status != Pdu::ERROR_STATUS_NO_ERROR {
                    return (parg.error_status, parg.error_index, request_id);
                }
                vb_cnt += 1;
            } else {
                // construct repeater row
                debug!("Repeat {vbind:?}");
                rep_oids.push(vbind.name.clone());
            }
        }
        // Now do repeating rows
        for i in 0..max_repeats {
            let mut new_oids: Vec<ObjectIdentifier> = vec![];
            let mut parg = PduArg {
                error_index,
                error_status,
                vb_cnt,
            }; // Checked Packet is 65K max, so at most a few thousand Varbinds, easily fits in u32
            for roid in &rep_oids {
                self.do_next(roid.clone(), oid_map, vb, &mut parg, perm);
                if parg.error_status != Pdu::ERROR_STATUS_NO_ERROR {
                    return (parg.error_status, parg.error_index, request_id);
                }
                let last = vb.last().unwrap(); // Checked. do_next will have appended, unless Error caught above
                new_oids.push(last.name.clone());
                vb_cnt += 1;
            }
            debug!("{i}th the repetition");
            for (n, oid) in new_oids.iter().enumerate() {
                rep_oids[n] = oid.clone();
            }
        }
        (error_status, error_index, request_id)
    }

    /// Process a Scoped PDU, returning an Option<Response>
    ///
    /// Returns None on unsupported PDU types, like Notify
    ///
    /// When everything is supported, remove Option
    fn do_scoped_pdu(
        &self,
        flags: u8,
        user: &usm::User,
        scoped_pdu: &ScopedPdu,
        oid_map: &mut OidMap,
    ) -> Option<Response> {
        //
        let mut skip_pdu = false;
        let mut vb: Vec<VarBind> = Vec::new();
        let mut error_status = Pdu::ERROR_STATUS_NO_ERROR;
        let mut error_index = 0;
        let mut request_id = 0;
        let context_name = &scoped_pdu.name;
        let fperm = FlagPerm::new(flags, context_name, &user.perm);

        match &scoped_pdu.data {
            Pdus::GetRequest(r) => {
                (error_status, error_index, request_id) =
                    self.get(oid_map, r.clone(), &mut vb, &fperm);
            }
            Pdus::GetNextRequest(r) => {
                (error_status, error_index, request_id) =
                    self.getnext(oid_map, r.clone(), &mut vb, &fperm);
            }
            Pdus::SetRequest(r) => {
                (error_status, error_index, request_id) =
                    self.set(oid_map, r.clone(), &mut vb, &fperm, user);
            }
            Pdus::GetBulkRequest(r) => {
                (error_status, error_index, request_id) =
                    self.bulk(oid_map, r.clone(), &mut vb, &fperm);
            }
            _ => skip_pdu = true,
        }
        if skip_pdu {
            warn!["skip_pdu is true"];
            None
        } else {
            let pdu = Pdu {
                request_id,
                error_index,
                error_status,
                variable_bindings: vb,
            };
            Some(Response(pdu))
        }
    }

    /// Send Message back to originator at addr
    fn send(&self, addr: SocketAddr, message: Message) {
        let buf_res = rasn::ber::encode(&message);
        match buf_res {
            Ok(buf) => {
                let _ = self.socket.send_to(&buf, addr);
            }
            Err(err) => error!("encodeError on returned Message{err:?}, dropping packet"),
        }
    }

    /// Process a single message. Returns options for return message and user if found.
    ///
    /// In some cases the message is simply dropped, as no sane processing is possible, and
    /// then None, None is returned.
    ///
    /// As a side effect various statistical counters in the Agent struct can be incremented.
    fn process_message<'a>(
        &mut self,
        context_map: &'a mut ContextMap,
        users: &'a usm::Users,
        message: &mut Message,
        // src: SocketAddr,
    ) -> (Option<Message>, Option<&'a usm::User>) {
        let resp_opt: Option<Response>;
        let mut out_message: Message;
        let opt_user: Option<&usm::User>;
        let message_id = message.global_data.message_id.to_owned();
        if message.global_data.flags.is_empty() {
            return (None, None);
        }
        let flags: u8 = *message.global_data.flags.first().unwrap(); // Checked not empty, guard above

        // Now do inner decode of security parameters
        let r_sp: Result<USMSecurityParameters, Box<dyn Display>> =
            message.decode_security_parameters(rasn::Codec::Ber);
        // Simply ignore packets that do not decode
        // In theory, should send decode error
        if r_sp.is_err() {
            self.decode_error_cnt += 1;
            return (None, None);
        }
        let usp: USMSecurityParameters = r_sp.ok().expect("Errors caught above");

        if !usp.user_name.is_empty() {
            opt_user = users.lookup_user(usp.user_name.to_vec());
            if opt_user.is_none() {
                self.unknown_users += 1;
                if self.send_auth_fails {
                    if let Some(sender) = &self.notifier {
                        let auth_fail = notifier::Notification {
                            name: ObjectIdentifier::new(&ARC_AUTHENTICATION_FAILURE).unwrap(), // Checked ARC is OK
                            vb: vec![],
                        };
                        let _ = sender.send(auth_fail);
                    }
                }
                if let ScopedPduData::CleartextPdu(scp) = &message.scoped_data {
                    let request_id = match &scp.data {
                        Pdus::GetRequest(r) => r.0.request_id,
                        Pdus::GetNextRequest(r) => r.0.request_id,
                        Pdus::SetRequest(r) => r.0.request_id,
                        Pdus::GetBulkRequest(r) => r.0.request_id,
                        _ => 1,
                    };
                    return (Some(self.unknown_user(request_id, message_id)), None);
                }

                return (None, None);
            }
        } else {
            if let ScopedPduData::CleartextPdu(ref scoped_pdu) = message.scoped_data {
                // FIXME Add extra conditions here on engine_id discovery
                if scoped_pdu.engine_id.to_vec() == b"" {
                    // Return EngineId if manager does not know it yet.
                    // This has to be in clear, as engine_id is used in the
                    // encryption.
                    if let Pdus::GetRequest(r) = &scoped_pdu.data {
                        let request_id = r.0.request_id;
                        self.unknown_engine_ids += 1;
                        return (Some(self.id_response(request_id, message_id)), None);
                    }
                }
            }
            return (None, None);
        }
        let user = opt_user.unwrap(); // Checked - None case handled above
                                      // Check the authentication
        if flags & 1 == 1 && self.wrong_auth(message, user, usp.clone()) {
            warn!("Wrong auth, dropping");
            if self.send_auth_fails {
                if let Some(sender) = &self.notifier {
                    let auth_fail = notifier::Notification {
                        name: ObjectIdentifier::new(&ARC_AUTHENTICATION_FAILURE).unwrap(), // Checked, ARC is OK
                        vb: vec![],
                    };
                    let _ = sender.send(auth_fail);
                }
            }
            if let ScopedPduData::CleartextPdu(scp) = &message.scoped_data {
                let request_id = match &scp.data {
                    Pdus::GetRequest(r) => r.0.request_id,
                    Pdus::GetNextRequest(r) => r.0.request_id,
                    Pdus::SetRequest(r) => r.0.request_id,
                    Pdus::GetBulkRequest(r) => r.0.request_id,
                    _ => 1,
                };
                // Could return Some((self.auth_failure(request_id, message_id), user);
                // and let caller do send, but would be only case we can do this
                return (Some(self.auth_failure(request_id, message_id)), None);
            }
            return (None, None);
        }
        match &message.scoped_data {
            ScopedPduData::CleartextPdu(scoped_pdu) => {
                let map_opt = context_map.lookup(&scoped_pdu.name);
                if let Some(oid_map) = map_opt {
                    resp_opt = self.do_scoped_pdu(flags, user, scoped_pdu, oid_map);
                } else {
                    resp_opt = None // FIXme - wrong context
                }
            }
            ScopedPduData::EncryptedPdu(enc_octs) => {
                let key = &user.priv_key.borrow();
                let buf2: Vec<u8> = privacy::decrypt(&mut enc_octs.to_vec(), usp.clone(), key);
                let pdu_decode_res: Result<ScopedPdu, rasn::error::DecodeError> =
                    rasn::ber::decode(&buf2);
                if pdu_decode_res.is_err() {
                    // Should return decode error
                    self.decryption_errors += 1;
                    warn!("Decode error {pdu_decode_res:?}");
                    return (None, None);
                }
                let scoped_pdu: ScopedPdu = pdu_decode_res.unwrap(); // Checked Error case above
                let map_opt = context_map.lookup(&scoped_pdu.name);
                if let Some(oid_map) = map_opt {
                    resp_opt = self.do_scoped_pdu(flags, user, &scoped_pdu, oid_map);
                } else {
                    resp_opt = None; //FIXME what is wrong context?
                }
            }
        }

        if resp_opt.is_none() {
            warn!("No response, discarding");
            self.unknown_contexts += 1;
            return (None, None);
        }
        let resp = resp_opt.unwrap(); // Checked None case above
        out_message = self.prepare_back(message_id, resp, user, usp, flags & 2 == 2);
        out_message.global_data.flags = message.global_data.flags.clone();
        if flags & 1 == 1 {
            self.set_auth(&mut out_message, user);
        }
        (Some(out_message), Some(user))
    }

    /// Main server loop entry point
    ///
    /// context_map is Vec of tuples of (&[u8], &mut OidMap), associates context names with OidMaps
    ///
    /// This can be populated in any order, as it is sorted on the context names, then Oids before the loop starts.
    ///
    pub fn loop_forever<'a>(&mut self, context_map: &'a mut ContextMap, users: &'a usm::Users) {
        let mut buf = [0; 65100];
        // Sort by oid, the lookups use binary search.
        context_map.sort();
        loop {
            let recv_res = self.socket.recv_from(&mut buf);
            // If the socket read fails, there is nothing much we can do.
            if recv_res.is_err() {
                continue;
            }

            self.in_pkts += 1;
            let (amt, src) = recv_res.unwrap(); // Checked OK, error handled above

            // Redeclare `buf` as slice of the received data
            let buf = &mut buf[..amt];
            let decode_res: Result<Message, rasn::error::DecodeError> = rasn::ber::decode(buf);
            // Simply ignore packets that do not decode
            // In theory, should send decode error in a report, but manager must be broken!
            if decode_res.is_err() {
                self.decode_error_cnt += 1;
                continue;
            }

            let mut message: Message = decode_res.unwrap(); // Checked - error case handled above
            let (out_opt, user_opt) = self.process_message(context_map, users, &mut message);

            if let Some(out_message) = out_opt {
                self.send(src, out_message);
            }
            if let Some(user) = user_opt {
                if !*user.clean.borrow() && users.save_to_file().is_err() {
                    error!("Error saving passwpord file, changes may not be persistent and file might be corrupted");
                }
            }
        }
    }

    fn set_auth(&self, message: &mut Message, usr: &usm::User) -> Vec<u8> {
        // FIXME this should be a Result
        let r_sp: Result<USMSecurityParameters, Box<dyn Display>> =
            message.decode_security_parameters(rasn::Codec::Ber);
        if r_sp.is_err() {
            warn!("Decode security parameters failed");
            return vec![];
        }
        let mut usp: USMSecurityParameters = r_sp.ok().expect("Errors caught above");
        usp.authentication_parameters = match usr.auth_length {
            12 => Z12,
            16 => Z16,
            24 => Z24,
            32 => Z32,
            _ => Z48,
        };
        let enc_res = message.encode_security_parameters(rasn::Codec::Ber, &usp);
        if enc_res.is_err() {
            warn!("Encode security parameters failed");
            return vec![];
        }
        let buf_res = rasn::ber::encode(message);
        if buf_res.is_err() {
            warn!("Encode message failed");
            return vec![];
        }
        let buf = buf_res.unwrap(); // Checked, error case handled above
        let auth = usr.auth_from_bytes(&buf);
        usp.authentication_parameters = OctetString::from_slice(&auth);
        let _ = message.encode_security_parameters(rasn::Codec::Ber, &usp);
        auth
    }

    /// Return true if the auth is wrong
    fn wrong_auth(
        &mut self,
        message: &mut Message,
        user: &usm::User,
        usp: USMSecurityParameters,
    ) -> bool {
        if usp.authentication_parameters.len() != user.auth_length {
            // In this case, no point checking anything else.
            warn!(
                "Authentication parameters must be {} bytes",
                user.auth_length
            );
            return true;
        }
        let boots: isize = usp
            .authoritative_engine_boots
            .try_into()
            .unwrap_or(isize::MAX);
        if boots != self.boots {
            self.not_in_time_window += 1;
            return true;
        }
        let run_time: i32 = self
            .start_time
            .elapsed()
            .as_secs()
            .try_into()
            .unwrap_or(i32::MAX);
        let man_time: i32 = usp.authoritative_engine_time.try_into().unwrap_or(i32::MAX);
        let delta_t: i32 = man_time - run_time;
        if !(-150..=150).contains(&delta_t) {
            self.not_in_time_window += 1;
            return true;
        }

        let hmac = usp.authentication_parameters.clone().to_vec();
        let our_hmac = self.set_auth(message, user);
        // Actually check the auth
        if hmac != our_hmac {
            warn!("Message hmac {hmac:?} ours {our_hmac:?} ");
            self.wrong_digests += 1;
            return true;
        }
        false
    }
}

#[cfg(test)]
mod tests {
    use rasn_snmp::v2::BulkPdu;

    use super::*;
    use crate::engine_id::static_engine_id;
    use crate::keeper::{Access, OType, OidKeeper};
    use crate::oidmap;
    use crate::perms::{Perm, Rule};
    use crate::table::TableMemOid;
    use crate::usm::User;
    use crate::utils::*;
    use std::env;

    fn make_agent(port: &str) -> Agent {
        env::set_var("RUST_LOG", "info");
        //env_logger::init();
        let eid = OctetString::from_static(b"test");
        let addr = "127.0.0.1:".to_owned() + port;
        Agent::build(eid, &addr, false)
    }

    fn get_pdu(arg: &'static [u32]) -> GetRequest {
        let vb = vec![VarBind {
            name: ObjectIdentifier::new(arg).unwrap(), // Checked cfg Test
            value: VarBindValue::Unspecified,
        }];
        let pdu = Pdu {
            request_id: 1,
            error_status: 0,
            error_index: 0,
            variable_bindings: vb,
        };
        GetRequest(pdu)
    }

    fn get_next_pdu(arg: &'static [u32]) -> GetNextRequest {
        let vb = vec![VarBind {
            name: ObjectIdentifier::new(arg).unwrap(), // Checked cfg Test
            value: VarBindValue::Unspecified,
        }];
        let pdu = Pdu {
            request_id: 1,
            error_status: 0,
            error_index: 0,
            variable_bindings: vb,
        };
        GetNextRequest(pdu)
    }

    fn set_pdu(arg: &'static [u32], val: ObjectSyntax) -> SetRequest {
        let vb = vec![VarBind {
            name: ObjectIdentifier::new(arg).unwrap(), // Checked cfg Test
            value: VarBindValue::Value(val),
        }];
        let pdu = Pdu {
            request_id: 1,
            error_status: 0,
            error_index: 0,
            variable_bindings: vb,
        };
        SetRequest(pdu)
    }

    fn get_bulk_pdu(arg: &'static [u32]) -> GetBulkRequest {
        let oid = ObjectIdentifier::new(arg).unwrap(); // Checked cfg Test
        let vb = vec![
            VarBind {
                name: oid.clone(),
                value: VarBindValue::Unspecified,
            },
            VarBind {
                name: oid.clone(),
                value: VarBindValue::Unspecified,
            },
        ];
        let pdu = BulkPdu {
            non_repeaters: 1,
            max_repetitions: 1,
            request_id: 1,
            variable_bindings: vb,
        };
        GetBulkRequest(pdu)
    }

    const ARC2: [u32; 2] = [1, 6];
    // const ARC3: [u32; 5] = [1, 6, 1, 2, 1];

    fn tab_fixture() -> Box<dyn OidKeeper> {
        let oid2: ObjectIdentifier = ObjectIdentifier::new(&ARC2).unwrap(); // Checked #[test]
        let first = simple_from_str(b"abc");
        let last = simple_from_str(b"xyz");
        let blank = simple_from_str(b"");
        let s0 = simple_from_int(0);
        let s42 = simple_from_int(42);
        let s41 = simple_from_int(41);
        let s4 = simple_from_int(4);
        let s5 = simple_from_int(5);
        let mut tab = Box::new(TableMemOid::new(
            /*    */
            vec![blank.clone(), s0.clone(), s0.clone()],
            3,
            &oid2,
            vec![OType::String, OType::Integer, OType::Integer],
            vec![Access::ReadOnly, Access::ReadOnly, Access::ReadWrite],
            vec![1usize, 2usize],
            false,
        ));
        tab.set_data(vec![
            vec![first.clone(), s4.clone(), s41.clone()],
            vec![last.clone(), s5.clone(), s42.clone()],
        ]);
        tab
    }

    fn make_oid_map() -> OidMap {
        let mut om = oidmap::OidMap::new();
        let tab = tab_fixture();
        let oid = ObjectIdentifier::new(&ARC2).unwrap(); // Checked #[test]
        om.push(oid, tab);
        om
    }

    fn perms() -> Vec<Perm> {
        let rules = vec![Rule {
            read: true,
            write: true,
            context: None,
            include: vec![vec![1u32]],
            exclude: vec![],
        }];
        vec![Perm {
            rules,
            security_level: 1u8, // Just flags
            group_name: "test".as_bytes().to_vec(),
        }]
    }

    fn user_fixture<'a>(pv: &'a Vec<Perm>) -> User {
        let s ="test test sha1 0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b aes 0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c";
        let u = User::from_str(s, pv).unwrap(); // Checked #test
        u
    }

    fn users_fixture<'a>(pv: &'a Vec<Perm>) -> usm::Users {
        let mut u = usm::Users::new();
        let s ="test test sha1 0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b aes 0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c0c";
        u.load_from_str(pv, s);
        u
    }

    #[test]
    fn test_get() {
        let agent = make_agent("3161");
        let gp = get_pdu(&ARC2);
        let mut vb: Vec<VarBind> = vec![];
        let mut oid_map = make_oid_map();
        let perm = &perms()[0];
        let context = [];
        let fperm = FlagPerm::new(3, &context, perm);
        let (status, idx, r_id) = agent.get(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 1);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_SUCH_NAME);
        assert_eq!(vb.len(), 1);
        vb.clear();
        let gp = get_pdu(&[1, 7, 1, 3, 4]);
        let (status, idx, r_id) = agent.get(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_SUCH_NAME);
        assert_eq!(vb.len(), 1);
        vb.clear();
        let gp = get_pdu(&[1, 6, 1, 2, 3, 120, 121, 122, 5]);
        let (status, idx, r_id) = agent.get(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        assert_eq!(vb[0].value, VarBindValue::Value(simple_from_int(5)));
    }

    #[test]
    fn test_get_next() {
        let agent = make_agent("3162");
        let gp = get_next_pdu(&ARC2);
        let mut vb: Vec<VarBind> = vec![];
        let mut oid_map = make_oid_map();
        let perm = &perms()[0];
        let context = [];
        let fperm = FlagPerm::new(3, &context, perm);
        let (status, idx, r_id) = agent.getnext(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        vb.clear();
        let gp = get_next_pdu(&[1, 6, 1, 2, 3, 120, 121, 122, 5]);
        let (status, idx, r_id) = agent.getnext(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        assert_eq!(vb[0].value, VarBindValue::Value(simple_from_int(41)));
        vb.clear();
        // Miss case
        let gp = get_next_pdu(&[1, 5, 1]);
        let (status, idx, r_id) = agent.getnext(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        assert_eq!(vb[0].value, VarBindValue::Value(simple_from_str(b"abc")));
    }

    #[test]
    fn test_set() {
        let agent = make_agent("3163");
        let sp = set_pdu(&[1, 6, 1, 3, 3, 120, 121, 122, 5], simple_from_int(4));
        let mut vb: Vec<VarBind> = vec![];
        let mut oid_map = make_oid_map();
        let perm = &perms()[0];
        let context = [];
        let fperm = FlagPerm::new(3, &context, perm);
        let pv = perms();
        let user = user_fixture(&pv);
        let (status, idx, r_id) = agent.set(&mut oid_map, sp, &mut vb, &fperm, &user);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        vb.clear();
        let gp = get_pdu(&[1, 6, 1, 2, 3, 120, 121, 122, 5]);
        let (status, idx, r_id) = agent.get(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 1);
        // assert_eq!(vb[0].value, VarBindValue::Value(simple_from_int(4)));
    }

    #[test]
    fn test_bulk() {
        let agent = make_agent("3164");
        let gp = get_bulk_pdu(&ARC2);
        let mut vb: Vec<VarBind> = vec![];
        let mut oid_map = make_oid_map();
        let perm = &perms()[0];
        let context = [];
        let fperm = FlagPerm::new(3, &context, perm);
        let (status, idx, r_id) = agent.bulk(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 2);
        vb.clear();
        let gp = get_bulk_pdu(&[1, 6, 1, 2, 3, 120, 121, 122, 5]);
        let (status, idx, r_id) = agent.bulk(&mut oid_map, gp, &mut vb, &fperm);
        assert_eq!(r_id, 1);
        assert_eq!(idx, 0);
        assert_eq!(status, Pdu::ERROR_STATUS_NO_ERROR);
        assert_eq!(vb.len(), 2);
        assert_eq!(vb[0].value, VarBindValue::Value(simple_from_int(41)));
    }

    #[test]
    fn test_do_scoped_pdu_get() {
        let pv = perms();
        let user = user_fixture(&pv);
        let agent = make_agent("3165");
        let message_id = Integer::from(213);
        let zb = OctetString::from_static(b"");
        let gp = get_pdu(&ARC2);
        let eid = static_engine_id(1, b"besttest");
        let scoped_pdu = ScopedPdu {
            engine_id: eid.clone(),
            name: zb.clone(),
            data: Pdus::GetRequest(gp),
        };
        let mut oid_map = make_oid_map();
        let opt_resp = agent.do_scoped_pdu(2u8, &user, &scoped_pdu, &mut oid_map);
        assert!(opt_resp.is_some());
        if let Some(resp) = opt_resp {
            let usp: USMSecurityParameters = USMSecurityParameters {
                authoritative_engine_id: eid,
                authoritative_engine_boots: Integer::from(7),
                authoritative_engine_time: Integer::from(8),
                user_name: zb.clone(),
                authentication_parameters: zb.clone(),
                privacy_parameters: zb,
            };
            let message = agent.prepare_back(message_id, resp, &user, usp, false);
            assert_eq!(message.version, Integer::from(3));
        }
    }
    #[test]
    fn test_reports() {
        let agent = make_agent("3166");
        let id_message = agent.id_response(7, Integer::from(8));
        assert_eq!(id_message.version, Integer::from(3));
        let auth_message = agent.auth_failure(8, Integer::from(9));
        assert_eq!(auth_message.version, Integer::from(3));
        let use_message = agent.unknown_user(8, Integer::from(9));
        assert_eq!(use_message.version, Integer::from(3));
    }

    #[test]
    fn test_wrong_and_good_auth() {
        let mut agent = make_agent("3167");
        let pv = perms();
        let user = user_fixture(&pv);
        let zb = OctetString::from_static(b"");
        let name = OctetString::from_static(b"test");
        let gp = get_pdu(&ARC2);
        let eid = static_engine_id(1, b"besttest");
        let usp: USMSecurityParameters = USMSecurityParameters {
            authoritative_engine_id: eid.clone(),
            authoritative_engine_boots: Integer::from(agent.boots),
            authoritative_engine_time: Integer::from(8),
            user_name: name.clone(),
            authentication_parameters: OctetString::from_static(&[0u8; 12]),
            privacy_parameters: zb.clone(),
        };
        let scpl = ScopedPdu {
            engine_id: eid.clone(),
            name: zb.clone(),
            data: Pdus::GetRequest(gp),
        };
        let hd = HeaderData {
            message_id: Integer::from(7),
            max_size: Integer::from(7650),
            flags: OctetString::from_static(&[1]),
            security_model: Integer::from(3),
        };
        let mut message = Message {
            version: Integer::from(3),
            global_data: hd,
            security_parameters: OctetString::from_static(&[0u8; 12]),
            scoped_data: ScopedPduData::CleartextPdu(scpl),
        };
        let auth = agent.wrong_auth(&mut message, &user, usp.clone());
        assert!(auth);
        let _ = message.encode_security_parameters(rasn::Codec::Ber, &usp);
        let sauth = agent.set_auth(&mut message, &user);
        println!("Set auth returned {sauth:?}");
        let r_sp: Result<USMSecurityParameters, Box<dyn Display>> =
            message.decode_security_parameters(rasn::Codec::Ber);
        let usp: USMSecurityParameters = r_sp.ok().expect("Errors caught above");

        let auth = agent.wrong_auth(&mut message, &user, usp); //("Should decode usp"));
        assert!(!auth);
    }

    #[test]
    fn test_process_message() {
        let mut agent = make_agent("3168");
        let pv = perms();
        let users = users_fixture(&pv);
        let zb = OctetString::from_static(b"");
        let gp = get_pdu(&ARC2);
        let eid = static_engine_id(1, b"besttest");
        let usp: USMSecurityParameters = USMSecurityParameters {
            authoritative_engine_id: eid.clone(),
            authoritative_engine_boots: Integer::from(0),
            authoritative_engine_time: Integer::from(8),
            user_name: OctetString::from_static(b"test"),
            authentication_parameters: OctetString::from_static(&[0u8; 16]),
            privacy_parameters: zb.clone(),
        };
        let scpl = ScopedPdu {
            engine_id: eid.clone(),
            name: zb.clone(),
            data: Pdus::GetRequest(gp),
        };
        let hd = HeaderData {
            message_id: Integer::from(7),
            max_size: Integer::from(7650),
            flags: OctetString::from_static(&[3]),
            security_model: Integer::from(3),
        };
        let mut message = Message {
            version: Integer::from(3),
            global_data: hd,
            security_parameters: OctetString::from_static(&[0u8; 16]),
            scoped_data: ScopedPduData::CleartextPdu(scpl),
        };
        let _ = message.encode_security_parameters(rasn::Codec::Ber, &usp);
        let mut oid_map = make_oid_map();
        let mut context_map = ContextMap::new();
        context_map.insert(b"", &mut oid_map);

        let (msg, usr) = agent.process_message(&mut context_map, &users, &mut message);
        assert!(usr.is_none());
        assert!(msg.is_some());
    }
    // FIXME add tests for more set cases
}