sniff-cli 0.1.2

An exhaustive LLM-backed slop finder for codebases
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92

use crate::roles::{
    is_analysis_explanation_support_module, is_analysis_finding_helper_module,
    is_analysis_finding_support_module, is_analysis_finding_workspace_module,
    is_analysis_findings_facade_module, is_analysis_reexports_module, is_support_plumbing_module,
    is_utility_surface_module,
};
use crate::types::FileRecord;

fn small_analysis_helper_noise(file: &FileRecord, lower_reason: &str) -> bool {
    is_analysis_finding_helper_module(&file.file_path)
        && !file.methods.is_empty()
        && file.methods.len() <= 12
        && file.methods.iter().all(|method| method.loc <= 80)
        && (lower_reason.contains("helper surface")
            || lower_reason.contains("sprawling helper surface")
            || lower_reason.contains("too much")
            || lower_reason.contains("mixes")
            || lower_reason.contains("mixing concerns")
            || lower_reason.contains("single responsibility")
            || lower_reason.contains("functions vary widely"))
}

fn analysis_support_noise(file: &FileRecord, lower_reason: &str) -> bool {
    (is_analysis_reexports_module(&file.file_path)
        || is_analysis_finding_support_module(&file.file_path)
        || is_analysis_finding_workspace_module(&file.file_path))
        && (lower_reason.contains("filename is vague")
            || lower_reason.contains("vague filename")
            || lower_reason.contains("helper surface")
            || lower_reason.contains("sprawling helper surface")
            || lower_reason.contains("file does too much")
            || lower_reason.contains("functions vary widely")
            || lower_reason.contains("branchy control flow")
            || lower_reason.contains("control flow is tangled")
            || lower_reason.contains("name is vague")
            || lower_reason.contains("too much"))
}

fn analysis_facade_noise(file: &FileRecord, lower_reason: &str) -> bool {
    is_analysis_findings_facade_module(&file.file_path)
        && (lower_reason.contains("module does too much")
            || lower_reason.contains("module mixes public surface and orchestration")
            || lower_reason.contains("sprawling helper surface")
            || lower_reason.contains("vague facade")
            || lower_reason.contains("duplicate method body")
            || lower_reason.contains("copy-pasted method body")
            || lower_reason.contains("filename is vague")
            || lower_reason.contains("file does too much"))
}

fn explanation_support_noise(file: &FileRecord, lower_reason: &str) -> bool {
    is_analysis_explanation_support_module(&file.file_path)
        && (lower_reason.contains("trivial wrapper") || lower_reason.contains("tiny wrapper"))
}

fn support_plumbing_noise(file: &FileRecord, lower_reason: &str) -> bool {
    is_support_plumbing_module(&file.file_path)
        && (lower_reason.contains("branchy control flow")
            || lower_reason.contains("control flow is tangled")
            || lower_reason.contains("file does too much")
            || lower_reason.contains("module mixes public surface and orchestration")
            || lower_reason.contains("sprawling helper surface")
            || lower_reason.contains("copy-pasted method body")
            || lower_reason.contains("near-duplicate method body")
            || lower_reason.contains("filename is vague")
            || lower_reason.contains("name is vague")
            || lower_reason.contains("mixes"))
}

fn utility_surface_noise(file: &FileRecord, lower_reason: &str) -> bool {
    is_utility_surface_module(file)
        && (lower_reason.contains("filename is vague")
            || lower_reason.contains("vague filename")
            || lower_reason.contains("name is vague")
            || lower_reason.contains("too narrow")
            || lower_reason.contains("delegates to another module")
            || lower_reason.contains("fallback chain")
            || lower_reason.contains("message mapper"))
}

pub(crate) fn should_clear_analysis_verdict(
    file: &FileRecord,
    _reason: &str,
    lower_reason: &str,
) -> bool {
    small_analysis_helper_noise(file, lower_reason)
        || analysis_support_noise(file, lower_reason)
        || analysis_facade_noise(file, lower_reason)
        || explanation_support_noise(file, lower_reason)
        || support_plumbing_noise(file, lower_reason)
        || utility_surface_noise(file, lower_reason)
}