smix-driver 1.0.7

//! v3.1 c9 — wiremock-based driver integration tests.

use smix_driver::{HttpRunnerClient, SimctlDriver};
use smix_error::FailureCode;
use smix_input::{KeyName, SwipeDirection};
use smix_screen::Role;
use smix_screen::{A11yNode, Rect};
use smix_selector::{Modifiers, Pattern, Selector};
use std::time::Duration;
use wiremock::matchers::{body_json, body_partial_json, method, path};
use wiremock::{Mock, MockServer, ResponseTemplate};

fn mk_node(label: Option<&str>, bounds: Rect, children: Vec<A11yNode>) -> A11yNode {
    A11yNode {
        raw_type: "other".into(),
        role: None,
        identifier: None,
        label: label.map(String::from),
        title: None,
        placeholder_value: None,
        value: None,
        text: None,
        bounds,
        enabled: true,
        selected: false,
        has_focus: false,
        visible: true,
        children,
    }
}

fn rect(x: f64, y: f64, w: f64, h: f64) -> Rect {
    Rect { x, y, w, h }
}

fn tree_with_login() -> A11yNode {
    let mut root = mk_node(
        None,
        rect(0.0, 0.0, 390.0, 844.0),
        vec![mk_node(
            Some("Login"),
            rect(50.0, 100.0, 200.0, 40.0),
            vec![],
        )],
    );
    root.raw_type = "application".into();
    root
}

fn text_sel(t: &str) -> Selector {
    Selector::Text {
        text: Pattern::text(t),
        modifiers: Modifiers::default(),
    }
}

fn driver_for(server: &MockServer) -> SimctlDriver {
    SimctlDriver::new(HttpRunnerClient::with_base(server.uri()))
}

#[tokio::test]
async fn tree_passthrough() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let t = d.tree(None).await.expect("tree");
    assert_eq!(t.children.len(), 1);
    assert_eq!(t.children[0].label.as_deref(), Some("Login"));
}

#[tokio::test]
async fn describe_returns_visible_summaries() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let desc = d.describe().await.expect("describe");
    // The root + the Login child are both enabled+visible.
    assert_eq!(desc.elements.len(), 2);
    assert_eq!(desc.elements[1].name.as_deref(), Some("Login"));
}

#[tokio::test]
async fn find_one_resolves_via_tree() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let node = d.find_one(&text_sel("Login"), None).await.expect("ok");
    assert!(node.is_some());
}

#[tokio::test]
async fn find_one_returns_none_when_missing() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let node = d
        .find_one(&text_sel("DoesNotExist"), None)
        .await
        .expect("ok");
    assert!(node.is_none());
}

#[tokio::test]
async fn find_quick_probe_passthrough() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/find"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "exists": true
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    assert!(d.find(&text_sel("X"), None).await.unwrap());
}

#[tokio::test]
async fn tap_resolves_then_tap_at_norm_coord() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/tap-at-norm-coord"))
        // Login bounds (50,100,200,40), root (0,0,390,844).
        // centroid = (150, 120), normalized = (~0.385, ~0.142)
        .and(body_partial_json(serde_json::json!({})))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "ok": true
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.tap(&text_sel("Login"), None).await.expect("tap ok");
}

#[tokio::test]
async fn tap_miss_returns_element_not_found_after_implicit_wait() {
    let server = MockServer::start().await;
    // Empty tree — selector "DoesNotExist" never resolves.
    let empty_tree = mk_node(None, rect(0.0, 0.0, 390.0, 844.0), vec![]);
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(empty_tree))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    // Override implicit wait via clock: 5s default. Since timer is real,
    // we shorten by calling tap with a selector that fast-fails (root
    // tree empty → all candidates fail). The poll loop sleeps 250ms but
    // returns ELEMENT_NOT_FOUND after the 5s budget; we accept that wall
    // time here (test takes ~5s).
    let err = d.tap(&text_sel("DoesNotExist"), None).await.unwrap_err();
    assert_eq!(err.code, FailureCode::ElementNotFound);
    assert!(err.message.contains("element not found"));
}

#[tokio::test]
async fn fill_chunks_one_char_per_post() {
    // v3.6 c1 G1 fix — driver.fill splits multi-char text into 1-char
    // chunks, posting each to runner /fill separately so the RN
    // TextInput onChangeText debounce on the main thread can flush
    // between keystrokes. Verify the mock receives exactly N posts for
    // an N-character fill — body_json per char would over-constrain
    // (we'd have to enumerate all 7); body_partial_json on the
    // selector field is sufficient because every chunk posts the
    // same selector.
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/fill"))
        .and(body_partial_json(serde_json::json!({
            "selector": {"text": "Email"}
        })))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .expect(7) // chars in "u@x.com"
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.fill(&text_sel("Email"), "u@x.com", None).await.unwrap();
}

#[tokio::test]
async fn fill_with_id_selector_focus_taps_then_fills_focused() {
    // v3.6 c2 — runner /fill only accepts text selectors (or the
    // _focused_ magic). For id/label/role/anchor selectors, driver.fill
    // host-resolves + taps the target first (to give it keyboard focus),
    // then issues chunked /fill posts with `selector: {focused: true}`.
    // This test verifies the dispatch end-to-end via wiremock route
    // coverage: a single /tap-at-norm-coord (focus tap), then N chunked
    // /fill posts each carrying the focused-magic selector.
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/tap-at-norm-coord"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null
        })))
        .expect(1)
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/fill"))
        .and(body_partial_json(serde_json::json!({
            "selector": {"focused": true}
        })))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .expect(5) // "Hello" — 5 chars
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.fill(&id_sel("login-btn"), "Hello", None).await.unwrap();
}

#[tokio::test]
async fn fill_single_char_takes_fast_path() {
    // 1-char fills bypass the chunking loop — a single POST with the
    // whole text. Verifies the fast-path branch stays intact.
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/fill"))
        .and(body_json(serde_json::json!({
            "selector": {"text": "Email"},
            "text": "x"
        })))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .expect(1)
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.fill(&text_sel("Email"), "x", None).await.unwrap();
}

#[tokio::test]
async fn clear_with_text_selector_takes_fast_path() {
    // v3.7 c1 — pure Text selector hits /clear directly (mirroring fill
    // fast path). No /tree, no /tap.
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/clear"))
        .and(body_partial_json(serde_json::json!({
            "selector": {"text": "Email"}
        })))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .expect(1)
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.clear(&text_sel("Email"), None).await.unwrap();
}

#[tokio::test]
async fn clear_with_id_selector_focus_taps_then_clears_focused() {
    // v3.7 c1 — runner /clear only accepts text selectors (or the
    // `_focused_` magic); id-selector clear returns missingText. Mirror
    // the v3.6 c2 fill dispatch: host-resolve + tap the id target for
    // focus, then issue /clear with `selector: {focused: true}`.
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/tap-at-norm-coord"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null
        })))
        .expect(1)
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/clear"))
        .and(body_partial_json(serde_json::json!({
            "selector": {"focused": true}
        })))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .expect(1)
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.clear(&id_sel("login-btn"), None).await.unwrap();
}

#[tokio::test]
async fn press_key_passthrough() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/press-key"))
        .and(body_json(serde_json::json!({"key": "return"})))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "tree": null, "stages": null
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.press_key(KeyName::Return).await.unwrap();
}

#[tokio::test]
async fn swipe_once_passthrough() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/swipe-once"))
        .and(body_json(serde_json::json!({"direction": "up"})))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "ok": true
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.swipe_once(SwipeDirection::Up).await.unwrap();
}

#[tokio::test]
async fn back_and_hide_keyboard_passthroughs() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/back"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "ok": true
        })))
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/hide-keyboard"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "ok": true
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.back().await.unwrap();
    d.hide_keyboard().await.unwrap();
}

#[tokio::test]
async fn wait_for_resolves_immediately_on_hit() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let node = d
        .wait_for(&text_sel("Login"), Duration::from_millis(500), None)
        .await
        .expect("wait_for");
    assert_eq!(node.label.as_deref(), Some("Login"));
}

#[tokio::test]
async fn wait_for_times_out_when_never_appears() {
    let server = MockServer::start().await;
    let empty_tree = mk_node(None, rect(0.0, 0.0, 390.0, 844.0), vec![]);
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(empty_tree))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let err = d
        .wait_for(&text_sel("Never"), Duration::from_millis(300), None)
        .await
        .unwrap_err();
    assert_eq!(err.code, FailureCode::Timeout);
}

#[tokio::test]
async fn dispose_idempotent_noop() {
    let server = MockServer::start().await;
    let d = driver_for(&server);
    d.dispose().await.unwrap();
    d.dispose().await.unwrap();
}

// ---- v3.5 c2 — find() selector-type dispatch -----------------------------

fn id_sel(s: &str) -> Selector {
    Selector::Id {
        id: s.to_string(),
        modifiers: Modifiers::default(),
    }
}

fn label_sel(s: &str) -> Selector {
    Selector::Label {
        label: s.to_string(),
        modifiers: Modifiers::default(),
    }
}

fn role_sel(name: &str) -> Selector {
    Selector::Role {
        role: Role::Button,
        name: Some(Pattern::text(name)),
        modifiers: Modifiers::default(),
    }
}

fn tree_with_id_and_role() -> A11yNode {
    let mut button = mk_node(Some("Login"), rect(50.0, 100.0, 200.0, 40.0), vec![]);
    button.raw_type = "button".into();
    button.identifier = Some("login-btn".into());
    // v3.5 c3 — DO NOT set `role` manually here. The Swift /tree route
    // never emits `role` on the wire, only `rawType`; runner-client's
    // `get_tree` runs `derive_roles_recursive` post-deser to lift
    // `raw_type = "button"` into `role = Some(Role::Button)`. This test
    // proves that wire-level round-trip works end-to-end.
    let mut root = mk_node(None, rect(0.0, 0.0, 390.0, 844.0), vec![button]);
    root.raw_type = "application".into();
    root
}

#[tokio::test]
async fn find_with_id_selector_falls_back_to_host_resolve() {
    let server = MockServer::start().await;
    // No /find mock — driver must NOT call /find for id selectors.
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    assert!(d.find(&id_sel("login-btn"), None).await.unwrap());
    assert!(!d.find(&id_sel("missing-btn"), None).await.unwrap());
}

#[tokio::test]
async fn find_with_label_selector_falls_back_to_host_resolve() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    assert!(d.find(&label_sel("Login"), None).await.unwrap());
    assert!(!d.find(&label_sel("Logout"), None).await.unwrap());
}

#[tokio::test]
async fn find_with_role_selector_falls_back_to_host_resolve() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    assert!(d.find(&role_sel("Login"), None).await.unwrap());
}

#[tokio::test]
async fn find_with_text_plus_index_modifier_falls_back_to_host_resolve() {
    // text + first: Some(true) → host-resolve, not /find route.
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let sel = Selector::Text {
        text: Pattern::text("Login"),
        modifiers: Modifiers {
            first: Some(true),
            ..Default::default()
        },
    };
    assert!(d.find(&sel, None).await.unwrap());
}

#[tokio::test]
async fn find_with_text_plus_ancestor_modifier_falls_back_to_host_resolve() {
    // v3.14 c1.5 — text + Modifiers::ancestor MUST fall back to host-resolve
    // (via /tree GET) because runner /find route is Apple element query
    // which has no parent-chain semantic. If dispatch wrongly hits /find,
    // wiremock 404 makes this fail. Only the /tree mock is registered.
    let server = MockServer::start().await;
    let mut tab_bar = mk_node(
        None,
        rect(0.0, 760.0, 390.0, 80.0),
        vec![mk_node(Some("Same"), rect(50.0, 780.0, 80.0, 40.0), vec![])],
    );
    tab_bar.raw_type = "tabBar".into();
    tab_bar.role = Some(Role::TabBar);
    let mut root = mk_node(None, rect(0.0, 0.0, 390.0, 844.0), vec![tab_bar]);
    root.raw_type = "application".into();
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(root))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let sel = Selector::Text {
        text: Pattern::text("Same"),
        modifiers: Modifiers {
            ancestor: Some(Box::new(Selector::Role {
                role: Role::TabBar,
                name: None,
                modifiers: Modifiers::default(),
            })),
            ..Default::default()
        },
    };
    assert!(
        d.find(&sel, None)
            .await
            .expect("ancestor selector should dispatch to host-resolve via /tree")
    );
}

#[tokio::test]
async fn tap_at_norm_coord_passthrough() {
    // v3.16 c1 S1 — SimctlDriver::tap_at_norm_coord(nx, ny) thin
    // wrapper on runner. wiremock only mounts POST /tap-at-norm-coord;
    // any other route (e.g. /tree) is wiremock 404 → test fail. Body
    // must contain {nx, ny} per swift-bridge TapAtNormCoordRoute wire
    // shape.
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/tap-at-norm-coord"))
        .and(body_partial_json(
            serde_json::json!({ "nx": 0.5, "ny": 0.95 }),
        ))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({ "ok": true })))
        .expect(1)
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.tap_at_norm_coord(0.5, 0.95)
        .await
        .expect("tap_at_norm_coord should pass through to runner");
}

// ---- v4.1 c1 — find / find_one / find_all transient /tree (or /find)
// transport retry. Mirrors the v3.17 c1 wait_for transient-retry pattern
// — sim still launching / runner attached app context switching can
// return a transient `/tree 500 snapshot_unavailable` (or `/find 500`)
// that the original `find*` impl surfaced as `DriverError` instead of
// polling within the standard 5s implicit-wait budget. v4.1 c1 closes
// the asymmetry: host-side polish, capability unchanged.

#[tokio::test]
async fn find_host_resolve_retries_transient_tree_500() {
    let server = MockServer::start().await;
    // First call returns 500 snapshot_unavailable (transient sim state),
    // subsequent calls return the populated tree. Driver must retry
    // within the 5s budget and resolve to Ok(true).
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(
            ResponseTemplate::new(500)
                .set_body_json(serde_json::json!({"ok": false, "error": "snapshot_unavailable"})),
        )
        .up_to_n_times(1)
        .mount(&server)
        .await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let present = d
        .find(&id_sel("login-btn"), None)
        .await
        .expect("find host-resolve branch must retry transient /tree 500");
    assert!(present, "Login id node is present after retry");
}

#[tokio::test]
async fn find_runner_route_retries_transient_find_500() {
    let server = MockServer::start().await;
    // First /find returns 500 (transient), second returns present=true.
    Mock::given(method("POST"))
        .and(path("/find"))
        .respond_with(
            ResponseTemplate::new(500)
                .set_body_json(serde_json::json!({"ok": false, "error": "transient"})),
        )
        .up_to_n_times(1)
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/find"))
        .respond_with(
            ResponseTemplate::new(200)
                .set_body_json(serde_json::json!({"exists": true, "ok": true})),
        )
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let present = d
        .find(&text_sel("Login"), None)
        .await
        .expect("find runner-route branch must retry transient /find 500");
    assert!(present, "/find returns exists=true after retry");
}

#[tokio::test]
async fn tap_retries_transient_tree_500() {
    let server = MockServer::start().await;
    // First /tree call returns transient 500, second returns the populated
    // tree containing the "Login" text node. tap() must retry within budget
    // and proceed to /tap-at-norm-coord (v4.1 c4 parity with wait_for).
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(
            ResponseTemplate::new(500)
                .set_body_json(serde_json::json!({"ok": false, "error": "snapshot_unavailable"})),
        )
        .up_to_n_times(1)
        .mount(&server)
        .await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_login()))
        .mount(&server)
        .await;
    Mock::given(method("POST"))
        .and(path("/tap-at-norm-coord"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({"ok": true})))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    d.tap(&text_sel("Login"), None)
        .await
        .expect("tap must retry transient /tree 500 and proceed");
}

#[tokio::test]
async fn find_one_and_find_all_retry_transient_tree_500() {
    let server = MockServer::start().await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(
            ResponseTemplate::new(500)
                .set_body_json(serde_json::json!({"ok": false, "error": "snapshot_unavailable"})),
        )
        .up_to_n_times(2) // 2 transient errors: 1 for find_one, 1 for find_all
        .mount(&server)
        .await;
    Mock::given(method("GET"))
        .and(path("/tree"))
        .respond_with(ResponseTemplate::new(200).set_body_json(tree_with_id_and_role()))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let one = d
        .find_one(&id_sel("login-btn"), None)
        .await
        .expect("find_one must retry transient /tree 500");
    assert!(one.is_some(), "find_one should resolve after retry");
    let all = d
        .find_all(&id_sel("login-btn"), None)
        .await
        .expect("find_all must retry transient /tree 500");
    assert_eq!(all.len(), 1, "find_all should match 1 node after retry");
}

// -------------------- /system-popup-action passthru (v4.2 c2) ------------
//
// G9 act side — Ok(true) on 200 + `{"ok":true}` envelope; Ok(false) on
// 404 `not_found` from the runner (popup or button id stale). camelCase
// request body (`popupId` / `buttonId`) is byte-identical to the swift
// SystemPopupActionRoute.Request decoder.

#[tokio::test]
async fn system_popup_action_returns_true_on_runner_ok() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/system-popup-action"))
        .and(body_partial_json(
            serde_json::json!({"popupId": "p-1", "buttonId": "b-open"}),
        ))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({"ok": true})))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let ok = d
        .system_popup_action("p-1", "b-open")
        .await
        .expect("system_popup_action ok path");
    assert!(ok);
}

#[tokio::test]
async fn system_popup_action_returns_false_on_runner_404_not_found() {
    let server = MockServer::start().await;
    Mock::given(method("POST"))
        .and(path("/system-popup-action"))
        .respond_with(ResponseTemplate::new(404).set_body_json(serde_json::json!({
            "ok": false,
            "error": "not_found",
            "popupId": "p-x",
            "buttonId": "b-x"
        })))
        .mount(&server)
        .await;
    let d = driver_for(&server);
    let ok = d
        .system_popup_action("p-x", "b-x")
        .await
        .expect("system_popup_action 404 surfaces as Ok(false)");
    assert!(!ok);
}