smelt-validator 0.1.0

Validation engine for Smelt semantic version control
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148

//! Complexity threshold checking

use super::ValidationRule;
use crate::config::ComplexityConfig;
use crate::validator::{ValidationSeverity, Violation};
use smelt_core::{IntentRecord, SemanticDelta};

/// Checks for complexity threshold violations
pub struct ComplexityChecker {
    config: ComplexityConfig,
}

impl ComplexityChecker {
    /// Create a new complexity checker
    pub fn new(config: ComplexityConfig) -> Self {
        Self { config }
    }
}

impl ValidationRule for ComplexityChecker {
    fn name(&self) -> &'static str {
        "complexity"
    }

    fn validate(&self, delta: &SemanticDelta, _intent: Option<&IntentRecord>) -> Vec<Violation> {
        let mut violations = Vec::new();

        // Check overall complexity increase
        let complexity_delta = delta.impact_summary.complexity_delta;
        if complexity_delta > self.config.max_complexity_increase {
            violations.push(Violation {
                rule: "complexity-increase".to_string(),
                severity: if self.config.complexity_error {
                    ValidationSeverity::Error
                } else {
                    ValidationSeverity::Warning
                },
                message: format!(
                    "Complexity increased by {} (threshold: {})",
                    complexity_delta, self.config.max_complexity_increase
                ),
                location: None,
                suggestion: Some(
                    "Consider refactoring to reduce complexity or splitting into smaller functions"
                        .to_string(),
                ),
            });
        }

        // Check individual function complexity from changes
        // Note: Full complexity analysis would require AST access
        // This checks complexity_delta in BodyModified changes
        for change in &delta.changes {
            if let smelt_core::SemanticChange::BodyModified {
                name,
                file,
                complexity_delta: func_delta,
            } = change
            {
                if *func_delta > self.config.max_complexity_increase {
                    violations.push(Violation {
                        rule: "function-complexity".to_string(),
                        severity: if self.config.complexity_error {
                            ValidationSeverity::Error
                        } else {
                            ValidationSeverity::Warning
                        },
                        message: format!(
                            "Function '{}' complexity increased by {}",
                            name, func_delta
                        ),
                        location: Some(file.clone()),
                        suggestion: Some(
                            "Extract helper functions or simplify control flow".to_string(),
                        ),
                    });
                }
            }
        }

        violations
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use chrono::Utc;
    use smelt_core::{ImpactSummary, SemanticChange};
    use uuid::Uuid;

    fn make_delta_with_complexity(complexity_delta: i32) -> SemanticDelta {
        SemanticDelta {
            id: Uuid::new_v4(),
            intent_id: Uuid::new_v4(),
            timestamp: Utc::now(),
            from_snapshot: Uuid::new_v4(),
            to_snapshot: Uuid::new_v4(),
            changes: Vec::new(),
            impact_summary: ImpactSummary {
                complexity_delta,
                ..Default::default()
            },
        }
    }

    #[test]
    fn test_complexity_under_threshold() {
        let checker = ComplexityChecker::new(ComplexityConfig::default());

        let delta = make_delta_with_complexity(5);
        let violations = checker.validate(&delta, None);
        assert!(violations.is_empty());
    }

    #[test]
    fn test_complexity_over_threshold() {
        let checker = ComplexityChecker::new(ComplexityConfig::default());

        let delta = make_delta_with_complexity(15);
        let violations = checker.validate(&delta, None);
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule, "complexity-increase");
    }

    #[test]
    fn test_function_complexity_change() {
        let checker = ComplexityChecker::new(ComplexityConfig::default());

        let delta = SemanticDelta {
            id: Uuid::new_v4(),
            intent_id: Uuid::new_v4(),
            timestamp: Utc::now(),
            from_snapshot: Uuid::new_v4(),
            to_snapshot: Uuid::new_v4(),
            changes: vec![SemanticChange::BodyModified {
                name: "complex_function".to_string(),
                file: "lib.rs".to_string(),
                complexity_delta: 15,
            }],
            impact_summary: ImpactSummary::default(),
        };

        let violations = checker.validate(&delta, None);
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule, "function-complexity");
    }
}