skyway 0.7.1

A command-line OpenStreetMap file converter
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
use quick_xml::events::{BytesStart, Event};
use quick_xml::name::QName;
use rayon::prelude::*;
use std::collections::VecDeque;
use std::io::BufRead;
use std::mem;

use std::path::PathBuf;
use std::str::from_utf8;
use std::sync::mpsc::Sender;

use crate::SkywayError;
use crate::elements::{Element, ElementBuilder, ElementTypeBuilder, Member};
use crate::{
    chunks::{ChunkBuilder, ElementChunk},
    elements::{Metadata, SimpleElementType},
    readers::Reader,
};

/// XML-specific reading errors
#[derive(Debug)]
enum XmlReadError {
    MissingAttribute(String),
    InvalidAttributeValue { attr: String, value: String },
    ParsingError(String),
    UnexpectedElement(String),
}

impl From<XmlReadError> for SkywayError {
    fn from(err: XmlReadError) -> SkywayError {
        match err {
            XmlReadError::MissingAttribute(attr) => SkywayError::InvalidInputFile,
            // FIXME: InvalidInputFile should support a message
            // Once that fix is made across the rest of the library,
            // I'll add better messages here
            XmlReadError::InvalidAttributeValue { attr, value } => SkywayError::UnexpectedError(
                format!("Invalid value '{}' for attribute '{}'", value, attr),
            ),
            XmlReadError::ParsingError(msg) => SkywayError::InvalidInputFile,
            XmlReadError::UnexpectedElement(elem) => SkywayError::InvalidInputFile,
        }
    }
}

// Convert a BytesStart event for an <osm> tag into a Metadata object
fn generate_metadata(osm_event: BytesStart) -> Metadata {
    let mut metadata = Metadata::default();

    for attr in osm_event.attributes() {
        if let Ok(attr) = attr {
            match attr.key.into_inner() {
                b"version" => {
                    metadata.version = attr_value_to_str(attr.value.as_ref())
                        .ok()
                        .map(|s| s.to_string())
                }

                b"generator" => {
                    metadata.generator = attr_value_to_str(attr.value.as_ref())
                        .ok()
                        .map(|s| s.to_string());
                }
                // TODO: Add other metadata attributes...
                _ => {}
            }
        }
    }
    metadata
}

struct ElementBuffer {
    builder: ChunkBuilder,
    current_elements: Vec<Element>,
    completed_chunks: VecDeque<ElementChunk>,
}

impl ElementBuffer {
    fn new(builder: ChunkBuilder) -> Self {
        Self {
            current_elements: Vec::with_capacity(builder.max_size),
            completed_chunks: VecDeque::new(),
            builder,
        }
    }

    // Add a new element to the buffer, potentially creating new chunks
    fn push(&mut self, element: Element) {
        self.current_elements.push(element);

        if self.current_elements.len() >= self.builder.max_size {
            self.flush();
        }
    }

    // Force creation of a chunk from current elements
    fn flush(&mut self) {
        if !self.current_elements.is_empty() {
            let elements = std::mem::replace(
                &mut self.current_elements,
                Vec::with_capacity(self.builder.max_size),
            );
            let chunk = self.builder.build_next_chunk(elements.into_boxed_slice());
            self.completed_chunks.push_back(chunk);
        }
    }

    // Convert buffer into a parallel iterator
    fn into_iter(mut self) -> impl ParallelIterator<Item = ElementChunk> {
        self.flush();
        self.completed_chunks.into_iter().par_bridge()
    }
}

struct ParseMachine {
    read_buffer: Vec<u8>,
    reader: quick_xml::reader::Reader<Box<dyn BufRead + Send>>,
    element_buffer: ElementBuffer,
    element_builder: ElementBuilder,
    in_osm: bool,
    current_element: Option<SimpleElementType>,
    metadata_sender: Sender<Metadata>,
}

impl ParseMachine {
    fn new(
        reader: quick_xml::reader::Reader<Box<dyn BufRead + Send>>,
        chunk_builder: ChunkBuilder,
        metadata_sender: Sender<Metadata>,
    ) -> Self {
        Self {
            read_buffer: Vec::new(),
            reader,
            element_buffer: ElementBuffer::new(chunk_builder),
            element_builder: ElementBuilder::default(),
            in_osm: false,
            current_element: None,
            metadata_sender,
        }
    }

    fn handle_tag(&mut self, tag: BytesStart) -> Result<(), SkywayError> {
        let mut k = None;
        let mut v = None;

        for attr in tag.attributes() {
            let attr = attr.map_err(|e| XmlReadError::ParsingError(e.to_string()))?;
            match attr.key.into_inner() {
                b"k" => k = attr_value_to_str(attr.value.as_ref())?.parse().ok(),
                b"v" => v = attr_value_to_str(attr.value.as_ref())?.parse().ok(),
                _ => {}
            }
        }

        if let (Some(key), Some(value)) = (k, v) {
            self.element_builder.tags.insert(key, value);
        }

        Ok(())
    }

    fn process_event(&mut self, event: Event) -> Result<(), SkywayError> {
        match event {
            Event::Start(s) => match s.name() {
                QName(b"osm") => {
                    self.in_osm = true;
                    self.metadata_sender
                        .send(generate_metadata(s))
                        .expect("Unable to send metadata out of reader process");
                    Ok(())
                }
                QName(b"node") | QName(b"way") | QName(b"relation") => {
                    if let Ok(Some(element_type)) = self.start_element(s) {
                        self.current_element = Some(element_type);
                    }
                    Ok(())
                }
                _ => Ok(()),
            },
            Event::End(_) => {
                if let Ok(Some(element)) = self.finish_element() {
                    self.element_buffer.push(element);
                    self.current_element = None;
                }
                Ok(())
            }
            Event::Empty(e) => match e.name() {
                QName(b"node") => {
                    // <node ... /> elements are registered as "empty" because they
                    // don't have separate <node> and </node> events.
                    // FIXME: make this more concise, this logic is not all necessary, we know it's a node
                    if let Ok(Some(element_type)) = self.start_element(e) {
                        self.current_element = Some(element_type);
                    }
                    if let Ok(Some(element)) = self.finish_element() {
                        self.element_buffer.push(element);
                        self.current_element = None;
                    }
                    Ok(())
                }
                QName(b"tag") => self.handle_tag(e),
                _ => self.handle_empty_element(e),
            },
            _ => Ok(()),
        }
    }

    fn into_chunk_iter(
        mut self,
    ) -> Result<impl ParallelIterator<Item = ElementChunk>, SkywayError> {
        loop {
            let event = self
                .reader
                .read_event_into(&mut self.read_buffer)
                .map_err(|e| {
                    XmlReadError::ParsingError(format!(
                        "Error at position {}: {:?}",
                        self.reader.buffer_position(),
                        e
                    ))
                })?;

            // Convert event to owned data that doesn't reference the buffer
            let owned_event = event.into_owned();

            // Check for EOF before processing
            if let Event::Eof = owned_event {
                break;
            }

            // Now we can process the owned event
            self.process_event(owned_event)?;

            // Clear the buffer after we're done
            self.read_buffer.clear();
        }

        // Verify we found and processed an OSM document
        if !self.in_osm {
            return Err(XmlReadError::ParsingError("No OSM document found".to_string()).into());
        }

        // Ensure any remaining elements are processed
        self.element_buffer.flush();

        Ok(self.element_buffer.into_iter())
    }

    fn start_element(
        &mut self,
        start: BytesStart,
    ) -> Result<Option<SimpleElementType>, XmlReadError> {
        for attr in start.attributes() {
            let attr = attr.map_err(|e| XmlReadError::ParsingError(e.to_string()))?;
            match attr.key.into_inner() {
                b"id" => {
                    self.element_builder.id = attr_value_to_str(attr.value.as_ref())?.parse().ok()
                }
                b"version" => {
                    self.element_builder.version =
                        attr_value_to_str(attr.value.as_ref())?.parse().ok()
                }
                b"timestamp" => {
                    self.element_builder.timestamp =
                        Some(attr_value_to_str(attr.value.as_ref())?.to_string())
                }
                b"changeset" => {
                    self.element_builder.changeset =
                        attr_value_to_str(attr.value.as_ref())?.parse().ok()
                }
                b"uid" => {
                    self.element_builder.uid = attr_value_to_str(attr.value.as_ref())?.parse().ok()
                }
                b"user" => {
                    self.element_builder.user =
                        Some(attr_value_to_str(attr.value.as_ref())?.to_string())
                }
                b"visible" => {
                    self.element_builder.visible =
                        Some(attr_value_to_str(attr.value.as_ref())? == "true")
                }
                _ => (),
            }
        }

        let element_type = match start.name().into_inner() {
            b"node" => {
                let mut lat = None;
                let mut lon = None;

                for attr in start.attributes() {
                    let attr = attr.map_err(|e| XmlReadError::ParsingError(e.to_string()))?;
                    match attr.key.into_inner() {
                        b"lat" => lat = attr_value_to_str(attr.value.as_ref())?.parse().ok(),
                        b"lon" => lon = attr_value_to_str(attr.value.as_ref())?.parse().ok(),
                        _ => {}
                    }
                }

                // Required attributes for nodes
                if lat.is_none() || lon.is_none() {
                    return Err(XmlReadError::MissingAttribute("lat/lon".to_string()));
                }

                self.element_builder.element_type =
                    Some(ElementTypeBuilder::NodeBuilder { lat, lon });

                Some(SimpleElementType::Node)
            }
            b"way" => {
                self.element_builder.element_type =
                    Some(ElementTypeBuilder::WayBuilder { nodes: Vec::new() });

                Some(SimpleElementType::Way)
            }
            b"relation" => {
                self.element_builder.element_type = Some(ElementTypeBuilder::RelationBuilder {
                    members: Vec::new(),
                });

                Some(SimpleElementType::Relation)
            }
            _ => None,
        };

        Ok(element_type)
    }

    fn finish_element(&mut self) -> Result<Option<Element>, SkywayError> {
        if self.element_builder.element_type.is_some() && self.element_builder.id.is_some() {
            let temp_builder = mem::replace(&mut self.element_builder, ElementBuilder::default());
            match temp_builder.build() {
                element @ Element { .. } => Ok(Some(element)),
                #[allow(unreachable_patterns)]
                _ => Err(XmlReadError::ParsingError("Failed to build element".to_string()).into()),
            }
        } else {
            Ok(None)
        }
    }

    fn handle_empty_element(&mut self, empty: BytesStart) -> Result<(), SkywayError> {
        match empty.name().into_inner() {
            b"nd" => {
                if let Some(SimpleElementType::Way) = self.current_element {
                    if let Some(ElementTypeBuilder::WayBuilder { nodes }) =
                        &mut self.element_builder.element_type
                    {
                        for attr in empty.attributes() {
                            let attr =
                                attr.map_err(|e| XmlReadError::ParsingError(e.to_string()))?;
                            if attr.key.into_inner() == b"ref" {
                                if let Ok(node_ref) =
                                    attr_value_to_str(attr.value.as_ref())?.parse::<i64>()
                                {
                                    nodes.push(node_ref);
                                    return Ok(());
                                }
                            }
                        }
                    }
                }
            }
            b"member" => {
                if let Some(SimpleElementType::Relation) = self.current_element {
                    if let Some(ElementTypeBuilder::RelationBuilder { members }) =
                        &mut self.element_builder.element_type
                    {
                        let mut role = None;
                        let mut ref_id = None;
                        let mut type_ = None;

                        for attr in empty.attributes() {
                            let attr =
                                attr.map_err(|e| XmlReadError::ParsingError(e.to_string()))?;
                            match attr.key.into_inner() {
                                b"role" => {
                                    role = Some(attr_value_to_str(attr.value.as_ref())?.to_string())
                                }
                                b"ref" => {
                                    ref_id = attr_value_to_str(attr.value.as_ref())?.parse().ok()
                                }
                                b"type" => {
                                    type_ = match attr_value_to_str(attr.value.as_ref())? {
                                        "node" => Some(SimpleElementType::Node),
                                        "way" => Some(SimpleElementType::Way),
                                        "relation" => Some(SimpleElementType::Relation),
                                        _ => None,
                                    }
                                }
                                _ => {}
                            }
                        }

                        if let (Some(id), Some(t)) = (ref_id, type_) {
                            members.push(Member {
                                role,
                                id,
                                t: Some(t),
                            });
                        }
                    }
                }
            }
            _ => {}
        }
        Ok(())
    }
}

fn attr_value_to_str(value: &[u8]) -> Result<&str, XmlReadError> {
    from_utf8(value).map_err(|e| XmlReadError::ParsingError(e.to_string()))
}

#[derive(Clone)]
pub struct XmlReader {}

impl XmlReader {
    pub fn new() -> Self {
        XmlReader {}
    }
}

impl Reader for XmlReader {
    fn read_file(
        self,
        src: Option<PathBuf>,
        metadata_sender: Sender<Metadata>,
        chunk_builder: ChunkBuilder,
    ) -> impl ParallelIterator<Item = ElementChunk> {
        let reader = quick_xml::reader::Reader::from_reader(super::get_reader(src));
        let parse_machine = ParseMachine::new(reader, chunk_builder, metadata_sender);
        match parse_machine.into_chunk_iter() {
            Ok(result) => result,
            Err(e) => {
                panic!("Failed to parse XML: {}", e)
            }
        }
    }
}