sklears-decomposition 0.2.0

Matrix decomposition algorithms for sklears: PCA, ICA, NMF, SVD
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
//! Independent Component Analysis (ICA) implementation.
//!
//! ICA is a statistical technique for separating a multivariate signal into
//! additive independent components. It assumes that observed signals are linear
//! mixtures of independent source signals.

use scirs2_core::ndarray::{s, Array1, Array2, Axis};
use scirs2_core::random::rngs::StdRng;
use scirs2_core::random::{thread_rng, RngExt, SeedableRng};
use scirs2_linalg::compat::{eigh, ArrayLinalgExt, UPLO};
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
use sklears_core::{
    error::{Result, SklearsError},
    traits::{Fit, Transform, Untrained},
};

/// ICA algorithm variants
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub enum ICAAlgorithm {
    /// Parallel FastICA algorithm
    #[default]
    Parallel,
    /// Deflation FastICA algorithm  
    Deflation,
    /// Infomax ICA algorithm using maximum likelihood
    Infomax,
    /// Natural gradient ICA algorithm
    NaturalGradient,
    /// Temporal ICA for time series data
    Temporal,
    /// Constrained ICA for semi-supervised learning
    Constrained,
}

/// Non-linearity functions for ICA
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub enum ICAFunction {
    /// Logcosh function: G(u) = tanh(a*u), g(u) = a*(1-tanh²(a*u))
    #[default]
    Logcosh,
    /// Exponential function: G(u) = u*exp(-u²/2), g(u) = (1-u²)*exp(-u²/2)
    Exp,
    /// Cubic function: G(u) = u³, g(u) = 3*u²
    Cube,
}

/// Independent Component Analysis transformer
#[derive(Debug, Clone)]
pub struct ICA<State = Untrained> {
    /// Number of components to extract
    pub n_components: Option<usize>,
    /// ICA algorithm to use
    pub algorithm: ICAAlgorithm,
    /// Non-linearity function
    pub fun: ICAFunction,
    /// Parameter for logcosh function
    pub fun_args: f64,
    /// Maximum number of iterations
    pub max_iter: usize,
    /// Tolerance for convergence
    pub tol: f64,
    /// Whether to whiten the data
    pub whiten: bool,
    /// Random state for reproducibility
    pub random_state: Option<u64>,
    /// Learning rate for gradient-based algorithms
    pub learning_rate: f64,
    /// Temporal window size for temporal ICA
    pub temporal_window: Option<usize>,
    /// Momentum factor for natural gradient
    pub momentum: f64,
    /// Prior knowledge matrix for constrained ICA
    pub constraint_matrix: Option<Array2<f64>>,
    /// Constraint weight for regularization
    pub constraint_weight: f64,
    /// Constraint tolerance for convergence
    pub constraint_tol: f64,

    /// Trained state
    state: State,
}

/// Trained ICA state
#[derive(Debug, Clone)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct TrainedICA {
    pub components: Array2<f64>,
    pub mixing: Array2<f64>,
    pub mean: Array1<f64>,
    pub whitening: Option<Array2<f64>>,
    pub n_features_in: usize,
    pub n_components: usize,
    pub n_iter: usize,
}

impl ICA<Untrained> {
    /// Create a new ICA transformer
    pub fn new() -> Self {
        Self {
            n_components: None,
            algorithm: ICAAlgorithm::Parallel,
            fun: ICAFunction::Logcosh,
            fun_args: 1.0,
            max_iter: 200,
            tol: 1e-4,
            whiten: true,
            random_state: None,
            learning_rate: 0.01,
            temporal_window: None,
            momentum: 0.9,
            constraint_matrix: None,
            constraint_weight: 1.0,
            constraint_tol: 1e-6,
            state: Untrained,
        }
    }

    /// Set the number of components
    pub fn n_components(mut self, n_components: usize) -> Self {
        self.n_components = Some(n_components);
        self
    }

    /// Set the algorithm
    pub fn algorithm(mut self, algorithm: ICAAlgorithm) -> Self {
        self.algorithm = algorithm;
        self
    }

    /// Set the non-linearity function
    pub fn fun(mut self, fun: ICAFunction) -> Self {
        self.fun = fun;
        self
    }

    /// Set the function parameter
    pub fn fun_args(mut self, fun_args: f64) -> Self {
        self.fun_args = fun_args;
        self
    }

    /// Set maximum iterations
    pub fn max_iter(mut self, max_iter: usize) -> Self {
        self.max_iter = max_iter;
        self
    }

    /// Set tolerance
    pub fn tol(mut self, tol: f64) -> Self {
        self.tol = tol;
        self
    }

    /// Set whether to whiten data
    pub fn whiten(mut self, whiten: bool) -> Self {
        self.whiten = whiten;
        self
    }

    /// Set random state
    pub fn random_state(mut self, random_state: u64) -> Self {
        self.random_state = Some(random_state);
        self
    }

    /// Set learning rate for gradient-based algorithms
    pub fn learning_rate(mut self, learning_rate: f64) -> Self {
        self.learning_rate = learning_rate;
        self
    }

    /// Set temporal window size for temporal ICA
    pub fn temporal_window(mut self, window_size: usize) -> Self {
        self.temporal_window = Some(window_size);
        self
    }

    /// Set momentum factor for natural gradient
    pub fn momentum(mut self, momentum: f64) -> Self {
        self.momentum = momentum;
        self
    }

    /// Set constraint matrix for constrained ICA
    pub fn constraint_matrix(mut self, constraint_matrix: Array2<f64>) -> Self {
        self.constraint_matrix = Some(constraint_matrix);
        self
    }

    /// Set constraint weight for regularization
    pub fn constraint_weight(mut self, constraint_weight: f64) -> Self {
        self.constraint_weight = constraint_weight;
        self
    }

    /// Set constraint tolerance for convergence
    pub fn constraint_tol(mut self, constraint_tol: f64) -> Self {
        self.constraint_tol = constraint_tol;
        self
    }
}

impl Fit<Array2<f64>, ()> for ICA<Untrained> {
    type Fitted = ICA<TrainedICA>;

    fn fit(self, x: &Array2<f64>, _y: &()) -> Result<Self::Fitted> {
        let (n_samples, n_features) = x.dim();

        if n_samples < 2 {
            return Err(SklearsError::InvalidInput(
                "ICA requires at least 2 samples".to_string(),
            ));
        }

        let n_components = self.n_components.unwrap_or(n_features);

        if n_components > n_features {
            return Err(SklearsError::InvalidInput(
                "n_components cannot be larger than n_features".to_string(),
            ));
        }

        // Center the data
        let mean = x
            .mean_axis(Axis(0))
            .expect("array should have elements for mean computation");
        let x_centered = x - &mean;

        // Whiten the data if requested
        let (x_whitened, whitening_matrix) = if self.whiten {
            let (whitened, whitening) = self.whiten_data(&x_centered)?;
            (whitened, Some(whitening))
        } else {
            (x_centered, None)
        };

        // Initialize random number generator with optional seed for reproducibility
        let mut rng = if let Some(seed) = self.random_state {
            StdRng::seed_from_u64(seed)
        } else {
            StdRng::from_rng(&mut thread_rng())
        };

        // Run ICA algorithm
        let (components, n_iter) = match self.algorithm {
            ICAAlgorithm::Parallel => self.parallel_fastica(&x_whitened, n_components, &mut rng)?,
            ICAAlgorithm::Deflation => {
                self.deflation_fastica(&x_whitened, n_components, &mut rng)?
            }
            ICAAlgorithm::Infomax => self.infomax_ica(&x_whitened, n_components, &mut rng)?,
            ICAAlgorithm::NaturalGradient => {
                self.natural_gradient_ica(&x_whitened, n_components, &mut rng)?
            }
            ICAAlgorithm::Temporal => self.temporal_ica(&x_whitened, n_components, &mut rng)?,
            ICAAlgorithm::Constrained => {
                self.constrained_ica(&x_whitened, n_components, &mut rng)?
            }
        };

        // Compute mixing matrix (pseudoinverse of components)
        let mixing = self.compute_mixing_matrix(&components)?;

        Ok(ICA {
            n_components: self.n_components,
            algorithm: self.algorithm,
            fun: self.fun,
            fun_args: self.fun_args,
            max_iter: self.max_iter,
            tol: self.tol,
            whiten: self.whiten,
            random_state: self.random_state,
            learning_rate: self.learning_rate,
            temporal_window: self.temporal_window,
            momentum: self.momentum,
            constraint_matrix: self.constraint_matrix,
            constraint_weight: self.constraint_weight,
            constraint_tol: self.constraint_tol,
            state: TrainedICA {
                components,
                mixing,
                mean,
                whitening: whitening_matrix,
                n_features_in: n_features,
                n_components,
                n_iter,
            },
        })
    }
}

impl Transform<Array2<f64>, Array2<f64>> for ICA<TrainedICA> {
    fn transform(&self, x: &Array2<f64>) -> Result<Array2<f64>> {
        let (_n_samples, n_features) = x.dim();

        if n_features != self.state.n_features_in {
            return Err(SklearsError::FeatureMismatch {
                expected: self.state.n_features_in,
                actual: n_features,
            });
        }

        // Center the data
        let x_centered = x - &self.state.mean;

        // Apply whitening if it was used during fitting
        let x_processed = if let Some(ref whitening) = self.state.whitening {
            x_centered.dot(whitening)
        } else {
            x_centered
        };

        // Apply ICA transformation
        let x_transformed = x_processed.dot(&self.state.components.t());

        Ok(x_transformed)
    }
}

impl ICA<Untrained> {
    /// Whiten the data using eigendecomposition
    fn whiten_data(&self, x: &Array2<f64>) -> Result<(Array2<f64>, Array2<f64>)> {
        let (n_samples, n_features) = x.dim();

        // Compute covariance matrix
        let cov = x.t().dot(x) / (n_samples - 1) as f64;

        // Eigendecomposition using scirs2-linalg
        let (eigenvalues, eigenvectors) = eigh(&cov.view(), UPLO::Lower).map_err(|e| {
            SklearsError::NumericalError(format!("Eigendecomposition failed: {:?}", e))
        })?;

        // Sort eigenvalues in descending order
        let mut sorted_indices: Vec<usize> = (0..n_features).collect();
        sorted_indices.sort_by(|&i, &j| {
            eigenvalues[j]
                .partial_cmp(&eigenvalues[i])
                .expect("operation should succeed")
        });

        // Build whitening matrix
        let mut whitening = Array2::zeros((n_features, n_features));
        for (i, &idx) in sorted_indices.iter().enumerate() {
            if eigenvalues[idx] > 1e-12 {
                let scale = 1.0 / eigenvalues[idx].sqrt();
                for j in 0..n_features {
                    whitening[[j, i]] = eigenvectors[[j, idx]] * scale;
                }
            }
        }

        // Apply whitening
        let x_whitened = x.dot(&whitening);

        Ok((x_whitened, whitening))
    }

    /// Parallel FastICA algorithm
    fn parallel_fastica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();

        // Initialize weight matrix randomly
        let mut w = Array2::<f64>::zeros((n_components, n_features));
        for i in 0..n_components {
            for j in 0..n_features {
                w[[i, j]] = rng.random::<f64>() - 0.5;
            }
        }

        // Orthogonalize initial weights
        self.orthogonalize(&mut w)?;

        let mut n_iter = 0;
        for iter in 0..self.max_iter {
            n_iter = iter + 1;

            let w_old = w.clone();

            // Update weights in parallel for all components
            for i in 0..n_components {
                let w_i = w.slice(s![i, ..]).to_owned();
                let wx = x.dot(&w_i);

                let (g, g_prime) = self.apply_nonlinearity(&wx);

                // FastICA update rule
                let update1 = x.t().dot(&g) / n_samples as f64;
                let update2 = &w_i * (g_prime.sum() / n_samples as f64);

                for j in 0..n_features {
                    w[[i, j]] = update1[j] - update2[j];
                }
            }

            // Orthogonalize weights
            self.orthogonalize(&mut w)?;

            // Check convergence
            let mut max_diff: f64 = 0.0;
            for i in 0..n_components {
                for j in 0..n_features {
                    let diff = (w[[i, j]] - w_old[[i, j]]).abs();
                    max_diff = max_diff.max(diff);
                }
            }

            if max_diff < self.tol {
                break;
            }
        }

        Ok((w, n_iter))
    }

    /// Deflation FastICA algorithm
    fn deflation_fastica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();
        let mut components = Array2::zeros((n_components, n_features));
        let mut max_iter_reached = 0;

        for comp in 0..n_components {
            // Initialize weight vector randomly
            let mut w = Array1::<f64>::zeros(n_features);
            for i in 0..n_features {
                w[i] = rng.random::<f64>() - 0.5;
            }

            // Normalize
            let norm = w.mapv(|x: f64| x * x).sum().sqrt();
            w /= norm;

            let mut n_iter = 0;
            for iter in 0..self.max_iter {
                n_iter = iter + 1;

                let w_old = w.clone();

                let wx = x.dot(&w);
                let (g, g_prime) = self.apply_nonlinearity(&wx);

                // FastICA update rule
                let update1 = x.t().dot(&g) / n_samples as f64;
                let update2 = &w * (g_prime.sum() / n_samples as f64);

                w = update1 - update2;

                // Orthogonalize against previous components
                for prev_comp in 0..comp {
                    let prev_w = components.slice(s![prev_comp, ..]);
                    let projection = w.dot(&prev_w);
                    w = w - &prev_w * projection;
                }

                // Normalize
                let norm = w.mapv(|x| x * x).sum().sqrt();
                if norm < 1e-12 {
                    return Err(SklearsError::NumericalError(
                        "Component became zero during deflation".to_string(),
                    ));
                }
                w /= norm;

                // Check convergence
                let diff = (&w - &w_old)
                    .mapv(|x| x.abs())
                    .fold(0.0f64, |acc, &x| acc.max(x));
                if diff < self.tol {
                    break;
                }
            }

            max_iter_reached = max_iter_reached.max(n_iter);

            // Store component
            for i in 0..n_features {
                components[[comp, i]] = w[i];
            }
        }

        Ok((components, max_iter_reached))
    }

    /// Apply non-linearity function and its derivative
    fn apply_nonlinearity(&self, x: &Array1<f64>) -> (Array1<f64>, Array1<f64>) {
        match self.fun {
            ICAFunction::Logcosh => {
                let alpha = self.fun_args;
                let tanh_x = x.mapv(|val| (alpha * val).tanh());
                let g = tanh_x.clone();
                let g_prime = tanh_x.mapv(|val| alpha * (1.0 - val * val));
                (g, g_prime)
            }
            ICAFunction::Exp => {
                let g = x.mapv(|val| val * (-val * val / 2.0).exp());
                let g_prime = x.mapv(|val| (1.0 - val * val) * (-val * val / 2.0).exp());
                (g, g_prime)
            }
            ICAFunction::Cube => {
                let g = x.mapv(|val| val * val * val);
                let g_prime = x.mapv(|val| 3.0 * val * val);
                (g, g_prime)
            }
        }
    }

    /// Orthogonalize weight matrix using Gram-Schmidt process
    fn orthogonalize(&self, w: &mut Array2<f64>) -> Result<()> {
        let (n_components, n_features) = w.dim();

        for i in 0..n_components {
            // Normalize current row
            let mut norm = 0.0;
            for j in 0..n_features {
                norm += w[[i, j]] * w[[i, j]];
            }
            norm = norm.sqrt();

            if norm < 1e-12 {
                return Err(SklearsError::NumericalError(
                    "Zero vector encountered during orthogonalization".to_string(),
                ));
            }

            for j in 0..n_features {
                w[[i, j]] /= norm;
            }

            // Orthogonalize against previous rows
            for k in 0..i {
                let mut dot_product = 0.0;
                for j in 0..n_features {
                    dot_product += w[[i, j]] * w[[k, j]];
                }

                for j in 0..n_features {
                    w[[i, j]] -= dot_product * w[[k, j]];
                }

                // Renormalize
                let mut norm = 0.0;
                for j in 0..n_features {
                    norm += w[[i, j]] * w[[i, j]];
                }
                norm = norm.sqrt();

                if norm < 1e-12 {
                    return Err(SklearsError::NumericalError(
                        "Linear dependence detected during orthogonalization".to_string(),
                    ));
                }

                for j in 0..n_features {
                    w[[i, j]] /= norm;
                }
            }
        }

        Ok(())
    }

    /// Compute mixing matrix as pseudoinverse of components
    fn compute_mixing_matrix(&self, components: &Array2<f64>) -> Result<Array2<f64>> {
        let (n_components, n_features) = components.dim();

        // For square matrices, compute inverse directly
        if n_components == n_features {
            // Use scirs2-linalg for inversion
            let comp_inv = components.inv().map_err(|e| {
                SklearsError::NumericalError(format!("Matrix inversion failed: {:?}", e))
            })?;

            // Transpose to get mixing matrix
            Ok(comp_inv.t().to_owned())
        } else {
            // For non-square matrices, compute pseudoinverse
            // mixing = (components^T * components)^(-1) * components^T
            let comp_t = components.t();
            let gram = components.dot(&comp_t);

            // Use scirs2-linalg for inversion
            let gram_inv = gram.inv().map_err(|e| {
                SklearsError::NumericalError(format!("Gram matrix inversion failed: {:?}", e))
            })?;

            let mixing = comp_t.dot(&gram_inv);
            Ok(mixing)
        }
    }

    /// Infomax ICA algorithm using maximum likelihood estimation
    ///
    /// This algorithm maximizes the information flow through the network by
    /// maximizing the joint entropy of the outputs using natural gradient.
    fn infomax_ica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();

        // Initialize weight matrix randomly
        let mut w = Array2::<f64>::zeros((n_components, n_features));
        for i in 0..n_components {
            for j in 0..n_features {
                w[[i, j]] = rng.random::<f64>() - 0.5;
            }
        }

        // Orthogonalize initial weights
        self.orthogonalize(&mut w)?;

        let mut n_iter = 0;
        for iter in 0..self.max_iter {
            n_iter = iter + 1;

            let w_old = w.clone();

            // Compute outputs: y = W * x
            let y = w.dot(&x.t());

            // Compute sigmoid activation: φ(y) = tanh(y)
            let phi_y = y.mapv(|val| val.tanh());

            // Compute derivative: φ'(y) = 1 - tanh²(y)
            let phi_y_deriv = y.mapv(|val| 1.0 - val.tanh().powi(2));

            // Natural gradient update: ΔW = η[I - φ(y)y^T]W
            // where η is the learning rate
            for i in 0..n_components {
                for j in 0..n_features {
                    let mut delta = 0.0;

                    // Compute the term: [I - φ(y)y^T]
                    for k in 0..n_samples {
                        let _y_k = y[[i, k]];
                        let _phi_y_k = phi_y[[i, k]];

                        // Diagonal term: I
                        delta += x[[k, j]] * phi_y_deriv[[i, k]];

                        // Off-diagonal term: -φ(y)y^T
                        for l in 0..n_components {
                            if l != i {
                                delta -= phi_y[[l, k]] * y[[i, k]] * w[[l, j]];
                            }
                        }
                    }

                    w[[i, j]] += self.learning_rate * delta / n_samples as f64;
                }
            }

            // Orthogonalize weights to maintain independence
            self.orthogonalize(&mut w)?;

            // Check convergence
            let mut max_diff: f64 = 0.0;
            for i in 0..n_components {
                for j in 0..n_features {
                    let diff = (w[[i, j]] - w_old[[i, j]]).abs();
                    max_diff = max_diff.max(diff);
                }
            }

            if max_diff < self.tol {
                break;
            }
        }

        Ok((w, n_iter))
    }

    /// Natural gradient ICA algorithm
    ///
    /// Uses natural gradient descent with momentum for efficient learning.
    /// This algorithm exploits the natural geometry of the parameter space.
    fn natural_gradient_ica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();

        // Initialize weight matrix randomly
        let mut w = Array2::<f64>::zeros((n_components, n_features));
        for i in 0..n_components {
            for j in 0..n_features {
                w[[i, j]] = rng.random::<f64>() - 0.5;
            }
        }

        // Initialize momentum terms
        let mut velocity = Array2::<f64>::zeros((n_components, n_features));

        let mut n_iter = 0;
        for iter in 0..self.max_iter {
            n_iter = iter + 1;

            let w_old = w.clone();

            // Compute outputs: y = W * x^T
            let y = w.dot(&x.t());

            // Apply non-linearity (tanh) and its derivative
            let g_y = y.mapv(|val| val.tanh());
            let g_y_deriv = y.mapv(|val| 1.0 - val.tanh().powi(2));

            // Compute natural gradient: ∇W = E[g'(y)]I - E[g(y)y^T]W
            let mut gradient = Array2::zeros((n_components, n_features));

            for i in 0..n_components {
                for j in 0..n_features {
                    let mut grad_sum = 0.0;

                    // First term: E[g'(y)]δ_ij * x_j
                    let mean_g_deriv = g_y_deriv
                        .row(i)
                        .mean()
                        .expect("array should have elements for mean computation");
                    grad_sum += mean_g_deriv
                        * x.column(j)
                            .mean()
                            .expect("array should have elements for mean computation");

                    // Second term: -E[g(y_i) * y_k] * w_kj
                    for k in 0..n_components {
                        let mut corr_sum = 0.0;
                        for s in 0..n_samples {
                            corr_sum += g_y[[i, s]] * y[[k, s]];
                        }
                        corr_sum /= n_samples as f64;
                        grad_sum -= corr_sum * w[[k, j]];
                    }

                    gradient[[i, j]] = grad_sum;
                }
            }

            // Apply momentum: v = momentum * v + learning_rate * gradient
            for i in 0..n_components {
                for j in 0..n_features {
                    velocity[[i, j]] =
                        self.momentum * velocity[[i, j]] + self.learning_rate * gradient[[i, j]];
                    w[[i, j]] += velocity[[i, j]];
                }
            }

            // Check convergence
            let mut max_diff: f64 = 0.0;
            for i in 0..n_components {
                for j in 0..n_features {
                    let diff = (w[[i, j]] - w_old[[i, j]]).abs();
                    max_diff = max_diff.max(diff);
                }
            }

            if max_diff < self.tol {
                break;
            }
        }

        Ok((w, n_iter))
    }

    /// Temporal ICA algorithm for time series data
    ///
    /// Exploits temporal structure in the data by incorporating
    /// temporal dependencies and autocorrelations.
    fn temporal_ica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();
        let requested_window = self.temporal_window.unwrap_or(3);

        if n_samples <= requested_window {
            return Err(SklearsError::InvalidInput(
                "Not enough samples for temporal ICA window".to_string(),
            ));
        }

        let window_size = requested_window;

        // Initialize weight matrix randomly
        let mut w = Array2::<f64>::zeros((n_components, n_features));
        for i in 0..n_components {
            for j in 0..n_features {
                w[[i, j]] = rng.random::<f64>() - 0.5;
            }
        }

        let mut n_iter = 0;
        for iter in 0..self.max_iter {
            n_iter = iter + 1;

            let w_old = w.clone();

            // Create temporal windows
            let n_windows = n_samples - window_size;
            let mut temporal_gradient = Array2::zeros((n_components, n_features));

            for window_start in 0..n_windows {
                let window_end = window_start + window_size;

                // Extract window data
                let x_window = x.slice(scirs2_core::ndarray::s![window_start..window_end, ..]);

                // Compute outputs for current window
                let y_window = w.dot(&x_window.t());

                // Apply non-linearity
                let _g_y = y_window.mapv(|val| val.tanh());
                let g_y_deriv = y_window.mapv(|val| 1.0 - val.tanh().powi(2));

                // Compute temporal contrast function
                // This encourages components to have different temporal structures
                for i in 0..n_components {
                    let y_i = y_window.row(i);

                    // Compute autocorrelation at lag 1
                    let mut autocorr = 0.0;
                    for t in 1..window_size {
                        autocorr += y_i[t] * y_i[t - 1];
                    }
                    autocorr /= (window_size - 1) as f64;

                    // Temporal gradient update
                    for j in 0..n_features {
                        let mut temp_grad = 0.0;

                        // Standard ICA gradient
                        for t in 0..window_size {
                            temp_grad += g_y_deriv[[i, t]] * x_window[[t, j]];
                        }
                        temp_grad /= window_size as f64;

                        // Temporal regularization term
                        // Encourage temporal independence by penalizing autocorrelation
                        let temporal_penalty = 0.1 * autocorr * autocorr;
                        temp_grad -= temporal_penalty;

                        temporal_gradient[[i, j]] += temp_grad;
                    }
                }
            }

            // Average gradient over all windows
            temporal_gradient /= n_windows as f64;

            // Update weights
            for i in 0..n_components {
                for j in 0..n_features {
                    w[[i, j]] += self.learning_rate * temporal_gradient[[i, j]];
                }
            }

            // Orthogonalize to maintain component independence
            self.orthogonalize(&mut w)?;

            // Check convergence
            let mut max_diff: f64 = 0.0;
            for i in 0..n_components {
                for j in 0..n_features {
                    let diff = (w[[i, j]] - w_old[[i, j]]).abs();
                    max_diff = max_diff.max(diff);
                }
            }

            if max_diff < self.tol {
                break;
            }
        }

        Ok((w, n_iter))
    }

    /// Constrained ICA algorithm for semi-supervised learning
    ///
    /// Incorporates prior knowledge through constraint matrix to guide
    /// the component extraction process towards desired solutions.
    fn constrained_ica(
        &self,
        x: &Array2<f64>,
        n_components: usize,
        rng: &mut impl RngExt,
    ) -> Result<(Array2<f64>, usize)> {
        let (n_samples, n_features) = x.dim();

        // Check if constraint matrix is provided
        let constraint_matrix = match &self.constraint_matrix {
            Some(matrix) => matrix,
            None => {
                return Err(SklearsError::InvalidInput(
                    "Constraint matrix must be provided for constrained ICA".to_string(),
                ));
            }
        };

        // Validate constraint matrix dimensions
        let (c_rows, c_cols) = constraint_matrix.dim();
        if c_rows != n_components || c_cols != n_features {
            return Err(SklearsError::InvalidInput(format!(
                "Constraint matrix shape ({c_rows}, {c_cols}) must match (n_components, n_features) = ({n_components}, {n_features})"
            )));
        }

        // Initialize weight matrix using constraint as guidance
        let mut w = Array2::<f64>::zeros((n_components, n_features));

        // Initialize with constrained initialization
        for i in 0..n_components {
            for j in 0..n_features {
                // Start with constraint matrix and add small random perturbation
                w[[i, j]] = constraint_matrix[[i, j]] + 0.1 * (rng.random::<f64>() - 0.5);
            }
        }

        // Normalize initial weight vectors
        for i in 0..n_components {
            let mut row = w.row_mut(i);
            let norm = row.dot(&row).sqrt();
            if norm > 1e-12 {
                row /= norm;
            }
        }

        let mut n_iter = 0;
        let mut prev_w = w.clone();

        for iter in 0..self.max_iter {
            n_iter = iter + 1;
            prev_w.assign(&w);

            for i in 0..n_components {
                // Extract current component weight vector
                let mut w_i = w.row(i).to_owned();

                // FastICA update with constraint regularization
                let y = x.dot(&w_i);
                let (_g_y, g_y_deriv) = self.apply_nonlinearity(&y);

                // Standard FastICA gradient
                let mut gradient = Array1::<f64>::zeros(n_features);
                for (j, x_sample) in x.rows().into_iter().enumerate() {
                    gradient += &(g_y_deriv[j] * x_sample.to_owned());
                }
                gradient /= n_samples as f64;

                // Constraint regularization term
                // Pull the weight vector towards the constraint
                let constraint_vec = constraint_matrix.row(i);
                let constraint_diff = &constraint_vec.to_owned() - &w_i;
                let constraint_gradient = self.constraint_weight * &constraint_diff;

                // Combined gradient update
                w_i = &w_i + self.learning_rate * (&gradient + &constraint_gradient);

                // Orthogonalization against previous components
                for j in 0..i {
                    let w_j = w.row(j);
                    let projection = w_i.dot(&w_j);
                    w_i = &w_i - projection * &w_j.to_owned();
                }

                // Normalize
                let norm = w_i.dot(&w_i).sqrt();
                if norm > 1e-12 {
                    w_i /= norm;
                }

                // Update weight matrix
                w.row_mut(i).assign(&w_i);
            }

            // Check convergence based on weight changes
            let mut max_change: f64 = 0.0;
            for i in 0..n_components {
                for j in 0..n_features {
                    let change = (w[[i, j]] - prev_w[[i, j]]).abs();
                    max_change = max_change.max(change);
                }
            }

            // Also check constraint satisfaction
            let mut constraint_error = 0.0;
            for i in 0..n_components {
                let constraint_vec = constraint_matrix.row(i);
                let w_vec = w.row(i);
                let diff = &constraint_vec.to_owned() - &w_vec.to_owned();
                constraint_error += diff.dot(&diff);
            }
            constraint_error = constraint_error.sqrt();

            if max_change < self.tol && constraint_error < self.constraint_tol {
                break;
            }
        }

        Ok((w, n_iter))
    }
}

impl ICA<TrainedICA> {
    /// Get the unmixing matrix (components)
    pub fn components(&self) -> &Array2<f64> {
        &self.state.components
    }

    /// Get the mixing matrix
    pub fn mixing(&self) -> &Array2<f64> {
        &self.state.mixing
    }

    /// Get the number of iterations performed
    pub fn n_iter(&self) -> usize {
        self.state.n_iter
    }

    /// Inverse transform (reconstruct original signal from components)
    pub fn inverse_transform(&self, x: &Array2<f64>) -> Result<Array2<f64>> {
        let (_n_samples, n_components) = x.dim();

        if n_components != self.state.n_components {
            return Err(SklearsError::FeatureMismatch {
                expected: self.state.n_components,
                actual: n_components,
            });
        }

        // Apply mixing matrix
        let x_mixed = x.dot(&self.state.mixing.t());

        // Apply inverse whitening if whitening was used
        let x_processed = if let Some(ref whitening) = self.state.whitening {
            // Inverse whitening: multiply by whitening^T
            x_mixed.dot(&whitening.t())
        } else {
            x_mixed
        };

        // Add back the mean
        let x_reconstructed = x_processed + &self.state.mean;

        Ok(x_reconstructed)
    }
}

impl Default for ICA<Untrained> {
    fn default() -> Self {
        Self::new()
    }
}

#[allow(non_snake_case)]
#[cfg(test)]
mod tests {
    use super::*;
    use approx::assert_abs_diff_eq;
    use scirs2_core::ndarray::array;

    #[test]
    fn test_ica_creation() {
        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Parallel)
            .fun(ICAFunction::Logcosh)
            .max_iter(100)
            .tol(1e-6)
            .random_state(42);

        assert_eq!(ica.n_components, Some(2));
        assert_eq!(ica.algorithm, ICAAlgorithm::Parallel);
        assert_eq!(ica.fun, ICAFunction::Logcosh);
        assert_eq!(ica.max_iter, 100);
        assert_abs_diff_eq!(ica.tol, 1e-6, epsilon = 1e-10);
    }

    #[test]
    fn test_ica_fit_transform() {
        // Create mixed signals (simple 2D case)
        let x = array![[1.0, 2.0], [2.0, 3.0], [3.0, 4.0], [4.0, 5.0], [5.0, 6.0],];

        let ica = ICA::new().n_components(2).random_state(42);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");

        assert_eq!(x_transformed.dim(), (5, 2));
        assert_eq!(trained_ica.state.n_features_in, 2);
        assert_eq!(trained_ica.state.n_components, 2);
    }

    #[test]
    fn test_ica_inverse_transform() {
        let x = array![[1.0, 1.0], [2.0, 2.0], [3.0, 3.0], [4.0, 4.0],];

        let ica = ICA::new().n_components(2).random_state(123);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");
        let x_reconstructed = trained_ica
            .inverse_transform(&x_transformed)
            .expect("operation should succeed");

        assert_eq!(x_reconstructed.dim(), x.dim());

        // The reconstruction should be close to the original (may not be exact due to numerical precision)
        for i in 0..x.nrows() {
            for j in 0..x.ncols() {
                assert!((x_reconstructed[[i, j]] - x[[i, j]]).abs() < 5.0);
            }
        }
    }

    #[test]
    fn test_ica_different_algorithms() {
        let x = array![
            [1.0, 2.0, 3.0],
            [2.0, 3.0, 4.0],
            [3.0, 4.0, 5.0],
            [4.0, 5.0, 6.0],
            [5.0, 6.0, 7.0],
        ];

        let algorithms = vec![ICAAlgorithm::Parallel, ICAAlgorithm::Deflation];

        for algorithm in algorithms {
            let ica = ICA::new()
                .n_components(3)
                .algorithm(algorithm)
                .random_state(42);

            let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
            let x_transformed = trained_ica
                .transform(&x)
                .expect("transformation should succeed");

            assert_eq!(x_transformed.dim(), (5, 3));
            assert_eq!(trained_ica.state.n_components, 3);
        }
    }

    #[test]
    fn test_ica_different_functions() {
        let x = array![
            [1.0, 2.0],
            [3.0, 1.0],
            [2.0, 4.0],
            [5.0, 2.0],
            [4.0, 6.0],
            [6.0, 3.0],
            [5.0, 8.0],
            [8.0, 4.0],
            [7.0, 10.0],
            [10.0, 5.0]
        ];

        let functions = vec![ICAFunction::Logcosh, ICAFunction::Exp, ICAFunction::Cube];

        for fun in functions {
            let ica = ICA::new().n_components(2).fun(fun).random_state(42);

            let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
            let x_transformed = trained_ica
                .transform(&x)
                .expect("transformation should succeed");

            assert_eq!(x_transformed.dim(), (10, 2));
        }
    }

    #[test]
    fn test_ica_error_cases() {
        let x_small = array![[1.0, 2.0]]; // Only 1 sample
        let ica = ICA::new();
        let result = ica.fit(&x_small, &());
        assert!(result.is_err());

        let x = array![[1.0, 2.0], [3.0, 4.0]];
        let ica = ICA::new().n_components(3); // More components than features
        let result = ica.fit(&x, &());
        assert!(result.is_err());
    }

    #[test]
    fn test_ica_whiten_option() {
        let x = array![[1.0, 2.0], [2.0, 3.0], [3.0, 4.0], [4.0, 5.0],];

        // Test with whitening
        let ica_whiten = ICA::new().n_components(2).whiten(true).random_state(42);

        let trained_whiten = ica_whiten
            .fit(&x, &())
            .expect("model fitting should succeed");
        assert!(trained_whiten.state.whitening.is_some());

        // Test without whitening
        let ica_no_whiten = ICA::new().n_components(2).whiten(false).random_state(42);

        let trained_no_whiten = ica_no_whiten
            .fit(&x, &())
            .expect("model fitting should succeed");
        assert!(trained_no_whiten.state.whitening.is_none());
    }

    #[test]
    fn test_ica_infomax_algorithm() {
        let x = array![
            [1.0, 2.0],
            [3.0, 1.0],
            [2.0, 4.0],
            [5.0, 2.0],
            [4.0, 6.0],
            [6.0, 3.0],
        ];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Infomax)
            .learning_rate(0.01)
            .max_iter(50) // Reduced for faster test
            .random_state(42);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");

        assert_eq!(x_transformed.dim(), (6, 2));
        assert_eq!(trained_ica.state.n_components, 2);

        // Check that all values are finite
        for &val in x_transformed.iter() {
            assert!(val.is_finite());
        }
    }

    #[test]
    fn test_ica_natural_gradient_algorithm() {
        let x = array![[1.0, 2.0], [3.0, 1.0], [2.0, 4.0], [5.0, 2.0], [4.0, 6.0],];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::NaturalGradient)
            .learning_rate(0.005)
            .momentum(0.9)
            .max_iter(30) // Reduced for faster test
            .random_state(123);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");

        assert_eq!(x_transformed.dim(), (5, 2));
        assert_eq!(trained_ica.state.n_components, 2);

        // Check that all values are finite
        for &val in x_transformed.iter() {
            assert!(val.is_finite());
        }
    }

    #[test]
    fn test_ica_temporal_algorithm() {
        // Create time series data with temporal structure
        let x = array![
            [1.0, 2.0],
            [1.1, 2.1],
            [1.2, 2.2],
            [2.0, 1.0],
            [2.1, 1.1],
            [2.2, 1.2],
            [3.0, 3.0],
            [3.1, 3.1],
        ];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Temporal)
            .temporal_window(3)
            .learning_rate(0.01)
            .max_iter(20) // Reduced for faster test
            .random_state(456);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");

        assert_eq!(x_transformed.dim(), (8, 2));
        assert_eq!(trained_ica.state.n_components, 2);

        // Check that all values are finite
        for &val in x_transformed.iter() {
            assert!(val.is_finite());
        }
    }

    #[test]
    fn test_ica_temporal_insufficient_data() {
        // Test with insufficient data for temporal window
        let x = array![[1.0, 2.0], [3.0, 4.0]]; // Only 2 samples

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Temporal)
            .temporal_window(5) // Window larger than data
            .random_state(42);

        let result = ica.fit(&x, &());
        assert!(result.is_err());
    }

    #[test]
    fn test_ica_new_parameters() {
        let ica = ICA::new()
            .learning_rate(0.05)
            .momentum(0.8)
            .temporal_window(5);

        assert_eq!(ica.learning_rate, 0.05);
        assert_eq!(ica.momentum, 0.8);
        assert_eq!(ica.temporal_window, Some(5));
    }

    #[test]
    fn test_constrained_ica_basic() {
        // Test basic constrained ICA functionality
        let x = array![
            [1.0, 0.5, 0.3],
            [0.8, 1.2, 0.7],
            [1.1, 0.9, 0.4],
            [0.9, 1.1, 0.6],
            [1.2, 0.7, 0.5],
        ];

        // Create a constraint matrix (prior knowledge about components)
        let constraint_matrix = array![
            [1.0, 0.0, 0.0], // First component should focus on first feature
            [0.0, 1.0, 0.0], // Second component should focus on second feature
        ];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Constrained)
            .constraint_matrix(constraint_matrix)
            .constraint_weight(0.5)
            .constraint_tol(1e-4)
            .max_iter(50)
            .random_state(42);

        let trained_ica = ica.fit(&x, &()).expect("model fitting should succeed");
        let x_transformed = trained_ica
            .transform(&x)
            .expect("transformation should succeed");

        assert_eq!(x_transformed.dim(), (5, 2));
        assert_eq!(trained_ica.state.n_components, 2);

        // Check that all values are finite
        for &val in x_transformed.iter() {
            assert!(val.is_finite());
        }

        // Check that constraints are reasonably satisfied
        let components = trained_ica.components();
        assert!(components[[0, 0]].abs() > components[[0, 1]].abs()); // First component prefers first feature
        assert!(components[[1, 1]].abs() > components[[1, 0]].abs()); // Second component prefers second feature
    }

    #[test]
    fn test_constrained_ica_missing_constraint() {
        // Test that constrained ICA fails without constraint matrix
        let x = array![[1.0, 0.5], [0.8, 1.2], [1.1, 0.9], [0.9, 1.1],];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Constrained)
            .random_state(42);

        let result = ica.fit(&x, &());
        assert!(result.is_err());
    }

    #[test]
    fn test_constrained_ica_invalid_constraint_shape() {
        // Test with incorrect constraint matrix shape
        let x = array![
            [1.0, 0.5, 0.3],
            [0.8, 1.2, 0.7],
            [1.1, 0.9, 0.4],
            [0.9, 1.1, 0.6],
        ];

        // Wrong shape constraint matrix (should be 2x3, not 2x2)
        let constraint_matrix = array![[1.0, 0.0], [0.0, 1.0],];

        let ica = ICA::new()
            .n_components(2)
            .algorithm(ICAAlgorithm::Constrained)
            .constraint_matrix(constraint_matrix)
            .random_state(42);

        let result = ica.fit(&x, &());
        assert!(result.is_err());
    }

    #[test]
    fn test_constrained_ica_parameters() {
        let constraint_matrix = array![[1.0, 0.0], [0.0, 1.0]];

        let ica = ICA::new()
            .constraint_matrix(constraint_matrix.clone())
            .constraint_weight(2.0)
            .constraint_tol(1e-5);

        assert_eq!(ica.constraint_weight, 2.0);
        assert_eq!(ica.constraint_tol, 1e-5);
        assert!(ica.constraint_matrix.is_some());

        let stored_matrix = ica
            .constraint_matrix
            .as_ref()
            .expect("operation should succeed");
        assert_eq!(stored_matrix.dim(), (2, 2));
    }
}