skiff-rs 0.1.2

An embedded Raft consensus library backed by sled
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
use std::fs;
use std::path::Path;
use std::time::Duration;

use serde::{Deserialize, Serialize};
use serial_test::serial;
use skiff_rs::Client;
use skiff_rs::ElectionState;
use skiff_rs::Skiff;
use skiff_rs::Subscriber;

/// Build a fresh node at `address`, optionally joining a cluster via `peers`.
/// Always wipes the data directory first for a clean start.
fn build_node(address: &str, peers: Vec<&str>) -> Skiff {
    let dir = format!("target/tmp/test/{}", address);
    if Path::exists(Path::new(&dir)) {
        fs::remove_dir_all(&dir).unwrap();
    }
    build_node_persist(address, peers)
}

/// Build a node re-using an existing data directory (for restart tests).
fn build_node_persist(address: &str, peers: Vec<&str>) -> Skiff {
    let dir = format!("target/tmp/test/{}", address);
    let peer_addrs: Vec<std::net::Ipv4Addr> = peers.iter().map(|p| p.parse().unwrap()).collect();
    let mut builder = skiff_rs::Builder::new()
        .set_dir(&dir)
        .bind(address.parse().unwrap());
    if !peer_addrs.is_empty() {
        builder = builder.join_cluster(peer_addrs);
    }
    builder.build().unwrap()
}

fn get_leader() -> Result<Skiff, Box<dyn std::error::Error>> {
    let dir = String::from("target/tmp/test/127.0.0.1");
    if Path::exists(Path::new(&dir)) {
        fs::remove_dir_all(&dir)?;
    }

    Ok(skiff_rs::Builder::new()
        .set_dir(dir.as_str())
        .bind("127.0.0.1".parse()?)
        .build()?)
}

fn get_follower(address: &str) -> Result<Skiff, Box<dyn std::error::Error>> {
    let dir = format!("target/tmp/test/{}", &address);
    if Path::exists(Path::new(&dir)) {
        fs::remove_dir_all(&dir)?;
    }

    Ok(skiff_rs::Builder::new()
        .set_dir(dir.as_str())
        .join_cluster(vec!["127.0.0.1".parse()?])
        .bind(address.parse()?)
        .build()?)
}

/// Connect a client to 127.0.0.1. Call `wait_for_leader` on the node first
/// to guarantee the server is up and a leader exists before connecting.
async fn get_client() -> Result<Client, Box<dyn std::error::Error>> {
    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await?;
    Ok(client)
}

#[tokio::test]
#[serial]
async fn start_server() {
    let leader = get_leader().unwrap();
    let _handle = tokio::spawn(async move {
        let _ = leader.start().await;
    });
}

#[tokio::test]
#[serial]
async fn leader_election() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    assert!(!(leader.is_leader_elected().await));
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    assert!(leader.is_leader_elected().await);
}

#[tokio::test]
#[serial]
async fn client_get() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    assert_eq!(None, client.get::<String>("nil").await.unwrap());
}

#[tokio::test]
#[serial]
async fn client_insert() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    client.insert::<String>("foo", "bar".into()).await.unwrap();
    assert_eq!(
        Some(String::from("bar")),
        client.get::<String>("foo").await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn client_remove() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    client
        .insert::<String>("foo2", "bar2".into())
        .await
        .unwrap();
    assert_eq!(
        Some(String::from("bar2")),
        client.get::<String>("foo2").await.unwrap()
    );
    client.remove("foo2").await.unwrap();
    assert_eq!(None, client.get::<String>("foo2").await.unwrap());
}

#[tokio::test]
#[serial]
async fn drop_tree() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    client
        .insert::<String>("parent/foo", "bar".into())
        .await
        .unwrap();
    assert_eq!(vec!["parent"], client.get_prefixes().await.unwrap());
    client.remove("parent/foo").await.unwrap();
    assert_eq!(Vec::<String>::new(), client.get_prefixes().await.unwrap());
}

#[tokio::test]
#[serial]
async fn two_node_cluster() {
    let leader = get_leader().unwrap();
    let leader_ref = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();

    let follower = get_follower("127.0.0.2").unwrap();
    let follower_clone = follower.clone();
    let _ = tokio::spawn(async move {
        let _ = follower_clone.start().await;
    });

    // Wait for the follower to join and the cluster config to replicate.
    tokio::time::sleep(Duration::from_millis(300)).await;

    let leader_cluster = leader.get_cluster().await.unwrap();
    let follower_cluster = follower.get_cluster().await.unwrap();

    assert_eq!(leader_cluster, follower_cluster);
    assert_eq!(2, leader_cluster.len());
}

#[derive(Debug, Serialize, Deserialize, PartialEq, Clone)]
struct MyStruct {
    enabled: bool,
    name: String,
    age: u8,
    height: f32,
}

#[tokio::test]
#[serial]
async fn custom_struct() {
    let leader = get_leader().unwrap();
    let leader_clone = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();

    let my_struct = MyStruct {
        enabled: true,
        name: "foo".into(),
        age: 100,
        height: 32.456789,
    };

    let mut client = get_client().await.unwrap();
    assert_eq!(None, client.get::<MyStruct>("mystruct").await.unwrap());

    // Insert and check
    client
        .insert::<MyStruct>("mystruct", my_struct.clone())
        .await
        .unwrap();
    assert_eq!(
        Some(my_struct),
        client.get::<MyStruct>("mystruct").await.unwrap()
    );

    // Delete
    client.remove("mystruct").await.unwrap();
    assert_eq!(None, client.get::<MyStruct>("mystruct").await.unwrap());
}

#[tokio::test]
#[serial]
async fn get_prefixes() {
    let leader = get_leader().unwrap();
    let leader_clone = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    assert_eq!(Vec::<String>::new(), client.get_prefixes().await.unwrap());
    client.insert::<String>("parent/foo", "bar".into()).await;
    assert_eq!(vec!["parent"], client.get_prefixes().await.unwrap());
    client
        .insert::<String>("grandparent/parent/foo", "bar".into())
        .await;
    assert_eq!(
        vec!["parent", "grandparent/parent"],
        client.get_prefixes().await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn list_prefixes() {
    let leader = get_leader().unwrap();
    let leader_clone = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client = get_client().await.unwrap();
    assert_eq!(Vec::<String>::new(), client.list_keys("").await.unwrap());

    client.insert::<String>("foo", "bar".into()).await;
    client.insert::<String>("parent/foo", "bar".into()).await;
    client
        .insert::<String>("parent/child/foo", "bar".into())
        .await;
    client
        .insert::<String>("grandparent/parent/foo", "bar".into())
        .await;
    assert_eq!(
        vec![
            "foo",
            "parent/foo",
            "parent/child/foo",
            "grandparent/parent/foo"
        ],
        client.list_keys("").await.unwrap()
    );
    assert_eq!(
        vec!["parent/foo", "parent/child/foo"],
        client.list_keys("parent/").await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn watch_prefix() {
    let leader = get_leader().unwrap();
    let leader_clone = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });

    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let mut client1 = get_client().await.unwrap();
    let mut client2: Client = get_client().await.unwrap();

    tokio::spawn(async move {
        client1.insert::<String>("foo", "bar".into()).await;
        client1.insert::<String>("parent/foo", "bar".into()).await;
        client1
            .insert::<String>("parent/child/foo", "bar".into())
            .await;
        client1
            .insert::<String>("grandparent/parent/foo", "bar".into())
            .await;
    });

    let mut subscriber: Subscriber = client2.watch("parent/").await.unwrap();
    let mut recvd = Vec::new();
    for _ in 0..2 {
        let (key, _) = subscriber.recv::<String>().await.unwrap();
        recvd.push(key);
    }

    assert_eq!(
        vec!["parent/foo".to_string(), "parent/child/foo".to_string()],
        recvd
    );
}

// ── multi-node / failure tests ────────────────────────────────────────────────

#[tokio::test]
#[serial]
async fn three_node_cluster() {
    let leader = build_node("127.0.0.1", vec![]);
    let follower1 = build_node("127.0.0.2", vec!["127.0.0.1"]);
    let follower2 = build_node("127.0.0.3", vec!["127.0.0.1"]);

    let leader_ref = leader.clone();
    let follower1_ref = follower1.clone();
    let follower2_ref = follower2.clone();

    tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    tokio::spawn(async move {
        let _ = follower1_ref.start().await;
    });
    tokio::spawn(async move {
        let _ = follower2_ref.start().await;
    });
    // Wait for both followers to join and the cluster config to replicate.
    tokio::time::sleep(Duration::from_millis(600)).await;

    assert_eq!(3, leader.get_cluster().await.unwrap().len());
    assert_eq!(3, follower1.get_cluster().await.unwrap().len());
    assert_eq!(3, follower2.get_cluster().await.unwrap().len());

    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await.unwrap();
    client
        .insert::<String>("replicated", "value".into())
        .await
        .unwrap();

    tokio::time::sleep(Duration::from_millis(200)).await;

    // All three nodes carry the insert (reads are forwarded to leader)
    for addr in &["127.0.0.1", "127.0.0.2", "127.0.0.3"] {
        let mut c = skiff_rs::Client::new(vec![addr.parse().unwrap()]);
        c.connect().await.unwrap();
        assert_eq!(
            Some("value".to_string()),
            c.get::<String>("replicated").await.unwrap()
        );
    }
}

#[tokio::test]
#[serial]
async fn leader_failure_reelection() {
    let leader = build_node("127.0.0.1", vec![]);
    let follower1 = build_node("127.0.0.2", vec!["127.0.0.1"]);
    let follower2 = build_node("127.0.0.3", vec!["127.0.0.1"]);

    let leader_ref = leader.clone();
    let follower1_ref = follower1.clone();
    let follower2_ref = follower2.clone();

    let leader_handle = tokio::spawn(async move {
        let _ = leader.start().await;
    });
    leader_ref
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    tokio::spawn(async move {
        let _ = follower1_ref.start().await;
    });
    tokio::spawn(async move {
        let _ = follower2_ref.start().await;
    });
    // Wait for both followers to join.
    tokio::time::sleep(Duration::from_millis(600)).await;

    assert_eq!(3, follower1.get_cluster().await.unwrap().len());

    // Shut down the leader: stop its election_manager first so it stops
    // sending heartbeats, then kill the gRPC server. Followers will time
    // out and re-elect.
    leader_ref.shutdown();
    tokio::time::sleep(Duration::from_millis(100)).await;
    leader_handle.abort();

    // Poll until one of the remaining nodes wins an election (up to 2s).
    let mut new_leader_elected = false;
    for _ in 0..20 {
        tokio::time::sleep(Duration::from_millis(100)).await;
        let f1 = follower1.get_election_state().await;
        let f2 = follower2.get_election_state().await;
        if matches!(f1, ElectionState::Leader) || matches!(f2, ElectionState::Leader) {
            new_leader_elected = true;
            break;
        }
    }
    assert!(
        new_leader_elected,
        "no new leader elected after old leader died"
    );

    // New cluster of 2 can still commit (2 > 3/2 = 1).
    let mut client = skiff_rs::Client::new(vec![
        "127.0.0.2".parse().unwrap(),
        "127.0.0.3".parse().unwrap(),
    ]);
    client.connect().await.unwrap();
    client
        .insert::<String>("post_failover", "ok".into())
        .await
        .unwrap();
    assert_eq!(
        Some("ok".to_string()),
        client.get::<String>("post_failover").await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn follower_crash_and_rejoin() {
    let leader = build_node("127.0.0.1", vec![]);
    let follower1 = build_node("127.0.0.2", vec!["127.0.0.1"]);
    let follower2 = build_node("127.0.0.3", vec!["127.0.0.1"]);

    let leader_ref = leader.clone();
    let follower1_ref = follower1.clone();

    tokio::spawn(async move {
        let _ = leader_ref.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    tokio::spawn(async move {
        let _ = follower1_ref.start().await;
    });
    let follower2_handle = {
        let f = follower2.clone();
        tokio::spawn(async move {
            let _ = f.start().await;
        })
    };
    // Wait for both followers to join.
    tokio::time::sleep(Duration::from_millis(600)).await;

    // Insert before crash.
    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await.unwrap();
    client
        .insert::<String>("before_crash", "yes".into())
        .await
        .unwrap();

    // Kill follower2: stop its election_manager, then kill the gRPC server, then release sled.
    let follower2_id = follower2.get_id();
    follower2.shutdown();
    follower2_handle.abort();
    drop(follower2);
    tokio::time::sleep(Duration::from_millis(200)).await;

    // Insert while follower2 is down (leader + follower1 = majority).
    client
        .insert::<String>("during_crash", "yes".into())
        .await
        .unwrap();

    // Restart follower2 from its existing data directory.
    tokio::time::sleep(Duration::from_millis(300)).await;
    let follower2_restart = build_node_persist("127.0.0.3", vec!["127.0.0.1"]);
    let f2_id = follower2_restart.get_id();
    assert_eq!(
        follower2_id, f2_id,
        "node id must be stable across restarts"
    );

    let f2_ref = follower2_restart.clone();
    tokio::spawn(async move {
        let _ = f2_ref.start().await;
    });

    // Wait until follower2 is back in a known-cluster state.
    follower2_restart
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();

    // Both keys are readable (forwarded to leader).
    let mut c = skiff_rs::Client::new(vec!["127.0.0.3".parse().unwrap()]);
    c.connect().await.unwrap();
    assert_eq!(
        Some("yes".to_string()),
        c.get::<String>("before_crash").await.unwrap()
    );
    assert_eq!(
        Some("yes".to_string()),
        c.get::<String>("during_crash").await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn concurrent_inserts() {
    let leader = get_leader().unwrap();
    let leader_clone = leader.clone();
    let _handle = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();

    let mut tasks = vec![];
    for i in 0u32..10 {
        tasks.push(tokio::spawn(async move {
            let mut c = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
            c.insert::<u32>(&format!("concurrent_{}", i), i)
                .await
                .unwrap();
        }));
    }
    for t in tasks {
        t.await.unwrap();
    }

    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    for i in 0u32..10 {
        assert_eq!(
            Some(i),
            client
                .get::<u32>(&format!("concurrent_{}", i))
                .await
                .unwrap()
        );
    }
}

#[tokio::test]
#[serial]
async fn remove_server_from_cluster() {
    let leader = get_leader().unwrap();
    let follower = get_follower("127.0.0.2").unwrap();

    let leader_clone = leader.clone();
    let follower_clone = follower.clone();
    let _lh = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let _fh = tokio::spawn(async move {
        let _ = follower_clone.start().await;
    });
    // Wait for the follower to join.
    tokio::time::sleep(Duration::from_millis(400)).await;

    assert_eq!(2, leader.get_cluster().await.unwrap().len());

    let follower_id = follower.get_id();
    let follower_addr = follower.get_address();

    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await.unwrap();
    client
        .remove_node(follower_id, follower_addr)
        .await
        .unwrap();

    // Allow the Configure entry to commit and apply.
    tokio::time::sleep(Duration::from_millis(300)).await;

    assert_eq!(1, leader.get_cluster().await.unwrap().len());
}

#[tokio::test]
#[serial]
async fn restart_persistence() {
    let dir = "target/tmp/test/persist";
    if Path::exists(Path::new(dir)) {
        fs::remove_dir_all(dir).unwrap();
    }

    // First run: insert data.
    let node = skiff_rs::Builder::new()
        .set_dir(dir)
        .bind("127.0.0.1".parse().unwrap())
        .build()
        .unwrap();
    let id_before = node.get_id();
    let node_clone = node.clone();
    let handle = tokio::spawn(async move {
        let _ = node_clone.start().await;
    });
    node.wait_for_leader(Duration::from_secs(2)).await.unwrap();

    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await.unwrap();
    client
        .insert::<String>("persistent_key", "persistent_value".into())
        .await
        .unwrap();
    tokio::time::sleep(Duration::from_millis(100)).await;

    // Simulate crash: stop background tasks, kill gRPC server, release sled lock.
    node.shutdown();
    handle.abort();
    drop(node);
    tokio::time::sleep(Duration::from_millis(300)).await;

    // Second run: restart from same directory.
    let node2 = skiff_rs::Builder::new()
        .set_dir(dir)
        .bind("127.0.0.1".parse().unwrap())
        .build()
        .unwrap();

    assert_eq!(id_before, node2.get_id(), "node id must survive restart");

    let node2_ref = node2.clone();
    tokio::spawn(async move {
        let _ = node2_ref.start().await;
    });
    node2.wait_for_leader(Duration::from_secs(2)).await.unwrap();

    let mut client2 = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client2.connect().await.unwrap();
    assert_eq!(
        Some("persistent_value".to_string()),
        client2.get::<String>("persistent_key").await.unwrap()
    );
}

#[tokio::test]
#[serial]
async fn subscriber_replication() {
    let leader = build_node("127.0.0.1", vec![]);
    let follower1 = build_node("127.0.0.2", vec!["127.0.0.1"]);
    let follower2 = build_node("127.0.0.3", vec!["127.0.0.1"]);

    let l = leader.clone();
    let f1 = follower1.clone();
    let f2 = follower2.clone();

    tokio::spawn(async move {
        let _ = l.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    tokio::spawn(async move {
        let _ = f1.start().await;
    });
    tokio::spawn(async move {
        let _ = f2.start().await;
    });
    // Wait for both followers to join.
    tokio::time::sleep(Duration::from_millis(600)).await;

    // Subscribe from follower2.
    let mut sub_client = skiff_rs::Client::new(vec!["127.0.0.3".parse().unwrap()]);
    sub_client.connect().await.unwrap();
    let mut sub = sub_client.watch("repl/").await.unwrap();

    // Insert from leader.
    let mut write_client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    write_client.connect().await.unwrap();
    write_client
        .insert::<String>("repl/key1", "val1".into())
        .await
        .unwrap();

    let (key, val) = tokio::time::timeout(Duration::from_secs(5), sub.recv::<String>())
        .await
        .expect("subscriber recv timed out")
        .unwrap();

    assert_eq!("repl/key1", key);
    assert_eq!("val1", val);
}

/// Verifies that a client insert returns an error when the cluster cannot reach quorum.
/// A 2-node cluster requires both nodes; killing the follower makes commit impossible.
/// NOTE: this test takes ~5 seconds due to the server-side commit timeout.
#[tokio::test]
#[serial]
async fn insert_timeout_leader_loss() {
    let leader = get_leader().unwrap();
    let follower = get_follower("127.0.0.2").unwrap();

    let leader_clone = leader.clone();
    let follower_clone = follower.clone();
    let _lh = tokio::spawn(async move {
        let _ = leader_clone.start().await;
    });
    leader
        .wait_for_leader(Duration::from_secs(2))
        .await
        .unwrap();
    let follower_handle = tokio::spawn(async move {
        let _ = follower_clone.start().await;
    });
    // Wait for the follower to join.
    tokio::time::sleep(Duration::from_millis(400)).await;

    assert_eq!(2, leader.get_cluster().await.unwrap().len());

    // Kill follower — leader now can't reach quorum (needs 2/2).
    // shutdown() closes the gRPC server (via serve_with_shutdown) and the election_manager.
    follower.shutdown();
    follower_handle.abort();
    tokio::time::sleep(Duration::from_millis(200)).await;

    let mut client = skiff_rs::Client::new(vec!["127.0.0.1".parse().unwrap()]);
    client.connect().await.unwrap();
    let result = client.insert::<String>("no_quorum", "x".into()).await;
    assert!(result.is_err(), "insert should fail when quorum is lost");
}