sirr-server 2.0.54

Sirr server library — axum HTTP server with redb storage and ChaCha20Poly1305 encryption
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
//! Integration tests for the Sirr HTTP API — Phase 3.
//!
//! Each endpoint has multiple test cases covering the authorization matrix
//! from spec §6. Uses `axum_test::TestServer` against the real router.

use std::sync::Arc;

use axum::http::{header, Method, StatusCode};
use axum_test::TestServer;
use serde_json::{json, Value};
use sirr_server::{
    router,
    store::{crypto, Store, Visibility},
    AppState, WebhookSender,
};
use tempfile::tempdir;

// ── Test helpers ──────────────────────────────────────────────────────────────

struct Setup {
    server: TestServer,
    store: Arc<Store>,
}

fn setup() -> Setup {
    setup_with_visibility(Visibility::Public)
}

fn setup_with_visibility(vis: Visibility) -> Setup {
    let dir = tempdir().unwrap();
    let store = Arc::new(Store::open(dir.path().join("test.db")).unwrap());

    let key = Arc::new(crypto::generate_key());
    let visibility = Arc::new(tokio::sync::RwLock::new(vis));
    let state = AppState {
        store: store.clone(),
        encryption_key: key,
        visibility,
        webhook_sender: WebhookSender::new(),
    };
    let server = TestServer::new(router(state));
    Setup { server, store }
}

/// Create an API key in the store and return (record, bearer token hex).
fn create_key(store: &Store) -> (sirr_server::KeyRecord, String) {
    store.create_key("test-key", None, None, None).unwrap()
}

// Helper to add a Bearer token to a request.
fn auth_header(token: &str) -> (header::HeaderName, header::HeaderValue) {
    (
        header::AUTHORIZATION,
        format!("Bearer {token}").parse().unwrap(),
    )
}

// ── POST /secret ──────────────────────────────────────────────────────────────

#[tokio::test]
async fn post_public_anon_creates_ok() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "hello"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert!(!body["hash"].as_str().unwrap().is_empty());
    assert!(body["url"].as_str().unwrap().contains("/secret/"));
    assert_eq!(body["owned"], json!(false));
}

#[tokio::test]
async fn post_public_keyed_returns_400() {
    let s = setup(); // public mode
    let (_key_record, token) = create_key(&s.store);
    let (name, value) = auth_header(&token);
    let resp = s
        .server
        .post("/secret")
        .add_header(name, value)
        .json(&json!({"value": "hello"}))
        .await;
    resp.assert_status(StatusCode::BAD_REQUEST);
}

#[tokio::test]
async fn post_private_anon_returns_401() {
    let s = setup_with_visibility(Visibility::Private);
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "hello"}))
        .await;
    resp.assert_status(StatusCode::UNAUTHORIZED);
}

#[tokio::test]
async fn post_private_keyed_creates_ok_with_owned_true() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key_record, token) = create_key(&s.store);
    let (name, value) = auth_header(&token);
    let resp = s
        .server
        .post("/secret")
        .add_header(name, value)
        .json(&json!({"value": "owned-secret"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["owned"], json!(true));
}

#[tokio::test]
async fn post_both_anon_ok() {
    let s = setup_with_visibility(Visibility::Both);
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "anon-in-both"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["owned"], json!(false));
}

#[tokio::test]
async fn post_both_keyed_ok() {
    let s = setup_with_visibility(Visibility::Both);
    let (_key_record, token) = create_key(&s.store);
    let (name, value) = auth_header(&token);
    let resp = s
        .server
        .post("/secret")
        .add_header(name, value)
        .json(&json!({"value": "keyed-in-both"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["owned"], json!(true));
}

#[tokio::test]
async fn post_none_returns_503() {
    let s = setup_with_visibility(Visibility::None);
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "blocked"}))
        .await;
    resp.assert_status(StatusCode::SERVICE_UNAVAILABLE);
}

#[tokio::test]
async fn post_with_prefix_hash_starts_with_prefix() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "hi", "prefix": "db1_"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    let hash = body["hash"].as_str().unwrap();
    assert!(
        hash.starts_with("db1_"),
        "hash should start with prefix: {hash}"
    );
}

#[tokio::test]
async fn post_with_ttl_sets_expires_at() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "ttl-secret", "ttl_seconds": 3600}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert!(
        body["expires_at"].is_number(),
        "expires_at should be a number"
    );
}

#[tokio::test]
async fn post_with_reads_sets_reads_remaining() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "read-limit", "reads": 3}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["reads_remaining"], json!(3));
}

#[tokio::test]
async fn post_invalid_prefix_returns_400() {
    let s = setup();
    // Prefix with uppercase — invalid per [a-z0-9_-]{1,16}
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "hi", "prefix": "DB1_"}))
        .await;
    resp.assert_status(StatusCode::BAD_REQUEST);
}

#[tokio::test]
async fn post_prefix_length_boundary() {
    let s = setup();
    // 15 chars — valid
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "hi", "prefix": "aaaaaaaaaaaaa__"}))
        .await;
    resp.assert_status_success();

    // 16 chars — at the limit, valid
    let resp2 = s
        .server
        .post("/secret")
        .json(&json!({"value": "hi", "prefix": "aaaaaaaaaaaaa___"}))
        .await;
    resp2.assert_status_success();

    // 17 chars — over limit
    let resp3 = s
        .server
        .post("/secret")
        .json(&json!({"value": "hi", "prefix": "aaaaaaaaaaaaa____"}))
        .await;
    resp3.assert_status(StatusCode::BAD_REQUEST);
}

// ── GET /secret/{hash} ────────────────────────────────────────────────────────

async fn create_and_get_hash(setup: &Setup, value: &str) -> String {
    let resp = setup
        .server
        .post("/secret")
        .json(&json!({"value": value}))
        .await;
    resp.assert_status_success();
    resp.json::<Value>()["hash"].as_str().unwrap().to_string()
}

#[tokio::test]
async fn get_returns_value_as_plain_text() {
    let s = setup();
    let hash = create_and_get_hash(&s, "my-secret-value").await;
    let resp = s.server.get(&format!("/secret/{hash}")).await;
    resp.assert_status_success();
    assert_eq!(resp.text(), "my-secret-value");
}

#[tokio::test]
async fn get_with_accept_json_returns_json() {
    let s = setup();
    let hash = create_and_get_hash(&s, "json-value").await;
    let resp = s
        .server
        .get(&format!("/secret/{hash}"))
        .add_header(
            header::ACCEPT,
            "application/json".parse::<header::HeaderValue>().unwrap(),
        )
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["value"], json!("json-value"));
}

#[tokio::test]
async fn get_consumes_read_counter() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "countable", "reads": 3}))
        .await;
    resp.assert_status_success();
    let hash = resp.json::<Value>()["hash"].as_str().unwrap().to_string();

    for _ in 0..3 {
        s.server
            .get(&format!("/secret/{hash}"))
            .await
            .assert_status_success();
    }
    // Fourth read — burned.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn get_last_read_burns_secret() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "burn-me", "reads": 1}))
        .await;
    resp.assert_status_success();
    let hash = resp.json::<Value>()["hash"].as_str().unwrap().to_string();

    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status_success();
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn get_nonexistent_hash_returns_410() {
    let s = setup();
    // Existence oracle defense: hashes that never existed also return 410.
    s.server
        .get("/secret/deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef")
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn get_none_visibility_returns_503() {
    let s = setup_with_visibility(Visibility::None);
    s.server
        .get("/secret/deadbeef")
        .await
        .assert_status(StatusCode::SERVICE_UNAVAILABLE);
}

#[tokio::test]
async fn get_unlimited_reads_does_not_burn() {
    let s = setup();
    let hash = create_and_get_hash(&s, "unlimited").await;
    for _ in 0..5 {
        s.server
            .get(&format!("/secret/{hash}"))
            .await
            .assert_status_success();
    }
}

// ── HEAD /secret/{hash} ───────────────────────────────────────────────────────

#[tokio::test]
async fn head_returns_200_with_sirr_headers() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "head-me", "reads": 5, "ttl_seconds": 3600}))
        .await;
    resp.assert_status_success();
    let hash = resp.json::<Value>()["hash"].as_str().unwrap().to_string();

    let resp = s
        .server
        .method(Method::HEAD, &format!("/secret/{hash}"))
        .await;
    resp.assert_status_success();

    let headers = resp.headers();
    assert!(
        headers.contains_key("x-sirr-created"),
        "missing x-sirr-created"
    );
    assert!(
        headers.contains_key("x-sirr-ttl-expires"),
        "missing x-sirr-ttl-expires"
    );
    assert!(
        headers.contains_key("x-sirr-reads-remaining"),
        "missing x-sirr-reads-remaining"
    );
    assert!(headers.contains_key("x-sirr-owned"), "missing x-sirr-owned");
}

#[tokio::test]
async fn head_does_not_consume_read() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "headonly", "reads": 1}))
        .await;
    resp.assert_status_success();
    let hash = resp.json::<Value>()["hash"].as_str().unwrap().to_string();

    // HEAD three times — should never burn the secret.
    for _ in 0..3 {
        s.server
            .method(Method::HEAD, &format!("/secret/{hash}"))
            .await
            .assert_status_success();
    }
    // GET should still work (reads=1 not consumed by HEAD).
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status_success();
    // Now burned.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn head_burned_returns_410_no_sirr_headers() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "burnme", "reads": 1}))
        .await;
    resp.assert_status_success();
    let hash = resp.json::<Value>()["hash"].as_str().unwrap().to_string();

    // Burn via GET.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status_success();

    // HEAD should now 410 with no X-Sirr-* headers.
    let resp = s
        .server
        .method(Method::HEAD, &format!("/secret/{hash}"))
        .await;
    resp.assert_status(StatusCode::GONE);
    assert!(
        !resp.headers().contains_key("x-sirr-created"),
        "tombstone should not leak x-sirr-created"
    );
}

#[tokio::test]
async fn head_nonexistent_returns_410() {
    let s = setup();
    s.server
        .method(
            Method::HEAD,
            "/secret/0000000000000000000000000000000000000000000000000000000000000000",
        )
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn head_anonymous_secret_shows_owned_false() {
    let s = setup();
    let hash = create_and_get_hash(&s, "anon-head").await;
    let resp = s
        .server
        .method(Method::HEAD, &format!("/secret/{hash}"))
        .await;
    resp.assert_status_success();
    let owned_header = resp.headers().get("x-sirr-owned").unwrap();
    assert_eq!(owned_header, "false");
}

// ── GET /secret/{hash}/audit ──────────────────────────────────────────────────

async fn create_keyed_secret(setup: &Setup, value: &str, token: &str) -> String {
    let (name, val) = auth_header(token);
    let resp = setup
        .server
        .post("/secret")
        .add_header(name, val)
        .json(&json!({"value": value}))
        .await;
    resp.assert_status_success();
    resp.json::<Value>()["hash"].as_str().unwrap().to_string()
}

#[tokio::test]
async fn audit_owner_gets_200_with_events() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "audit-me", &token).await;

    let (name, val) = auth_header(&token);
    let resp = s
        .server
        .get(&format!("/secret/{hash}/audit"))
        .add_header(name, val)
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    assert_eq!(body["hash"], json!(hash));
    assert!(body["events"].is_array());
    assert!(!body["events"].as_array().unwrap().is_empty());
}

#[tokio::test]
async fn audit_anonymous_secret_returns_404() {
    let s = setup(); // public mode
    let hash = create_and_get_hash(&s, "anon-secret").await;

    let resp = s.server.get(&format!("/secret/{hash}/audit")).await;
    resp.assert_status(StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn audit_keyed_no_auth_returns_401() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "auth-required", &token).await;

    let resp = s.server.get(&format!("/secret/{hash}/audit")).await;
    resp.assert_status(StatusCode::UNAUTHORIZED);
}

#[tokio::test]
async fn audit_keyed_wrong_key_returns_404() {
    let s = setup_with_visibility(Visibility::Both);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "mine", &token).await;

    // Second key — doesn't own the secret.
    let (_key2, token2) = s.store.create_key("other-key", None, None, None).unwrap();
    let (name, val) = auth_header(&token2);
    let resp = s
        .server
        .get(&format!("/secret/{hash}/audit"))
        .add_header(name, val)
        .await;
    resp.assert_status(StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn audit_events_include_read_event_after_get() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "readable", &token).await;

    // Trigger a read.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status_success();

    let (name, val) = auth_header(&token);
    let resp = s
        .server
        .get(&format!("/secret/{hash}/audit"))
        .add_header(name, val)
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    let events = body["events"].as_array().unwrap();
    let types: Vec<&str> = events.iter().map(|e| e["type"].as_str().unwrap()).collect();
    assert!(
        types.contains(&"secret.read"),
        "should include read event: {types:?}"
    );
}

// ── PATCH /secret/{hash} ──────────────────────────────────────────────────────

#[tokio::test]
async fn patch_owner_succeeds_and_value_updates() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "original", &token).await;

    let (name, val) = auth_header(&token);
    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .add_header(name, val)
        .json(&json!({"value": "updated"}))
        .await;
    resp.assert_status_success();

    // Read back the updated value.
    assert_eq!(
        s.server.get(&format!("/secret/{hash}")).await.text(),
        "updated"
    );
}

#[tokio::test]
async fn patch_frozen_ttl_and_reads_unchanged_by_default() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);

    let (name, val) = auth_header(&token);
    let create_resp = s
        .server
        .post("/secret")
        .add_header(name, val)
        .json(&json!({"value": "v1", "reads": 5, "ttl_seconds": 9999}))
        .await;
    create_resp.assert_status_success();
    let hash = create_resp.json::<Value>()["hash"]
        .as_str()
        .unwrap()
        .to_string();

    // Patch value only.
    let (name2, val2) = auth_header(&token);
    let patch_resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .add_header(name2, val2)
        .json(&json!({"value": "v2"}))
        .await;
    patch_resp.assert_status_success();
    let body: Value = patch_resp.json();
    assert_eq!(body["reads_remaining"], json!(5));
    assert!(body["expires_at"].is_number());
}

#[tokio::test]
async fn patch_with_new_reads_resets_counter() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "resetme", &token).await;

    let (name, val) = auth_header(&token);
    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .add_header(name, val)
        .json(&json!({"value": "newval", "reads": 2}))
        .await;
    resp.assert_status_success();
    assert_eq!(resp.json::<Value>()["reads_remaining"], json!(2));
}

#[tokio::test]
async fn patch_wrong_key_returns_404() {
    let s = setup_with_visibility(Visibility::Both);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "notmine", &token).await;
    let (_key2, token2) = s.store.create_key("attacker", None, None, None).unwrap();

    let (name, val) = auth_header(&token2);
    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .add_header(name, val)
        .json(&json!({"value": "hack"}))
        .await;
    resp.assert_status(StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn patch_anonymous_secret_returns_405() {
    let s = setup(); // public mode — anonymous secrets
    let hash = create_and_get_hash(&s, "anon-immutable").await;

    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .json(&json!({"value": "nope"}))
        .await;
    resp.assert_status(StatusCode::METHOD_NOT_ALLOWED);
}

#[tokio::test]
async fn patch_no_auth_on_keyed_secret_returns_401() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "needsauth", &token).await;

    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .json(&json!({"value": "nope"}))
        .await;
    resp.assert_status(StatusCode::UNAUTHORIZED);
}

#[tokio::test]
async fn patch_burned_secret_returns_410() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);

    let (name, val) = auth_header(&token);
    let create_resp = s
        .server
        .post("/secret")
        .add_header(name, val)
        .json(&json!({"value": "burnable", "reads": 1}))
        .await;
    create_resp.assert_status_success();
    let hash = create_resp.json::<Value>()["hash"]
        .as_str()
        .unwrap()
        .to_string();

    // Burn by reading.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status_success();

    let (name2, val2) = auth_header(&token);
    let resp = s
        .server
        .patch(&format!("/secret/{hash}"))
        .add_header(name2, val2)
        .json(&json!({"value": "too-late"}))
        .await;
    resp.assert_status(StatusCode::GONE);
}

// ── DELETE /secret/{hash} ─────────────────────────────────────────────────────

#[tokio::test]
async fn delete_anonymous_secret_returns_204() {
    let s = setup();
    let hash = create_and_get_hash(&s, "anon-delete").await;
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::NO_CONTENT);
}

#[tokio::test]
async fn delete_anonymous_anyone_can_burn() {
    // Capability model: anyone with the hash can burn an anonymous secret.
    let s = setup();
    let hash = create_and_get_hash(&s, "cap-burn").await;

    // No auth header.
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::NO_CONTENT);

    // Confirm gone.
    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn delete_keyed_owner_ok() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "mine", &token).await;

    let (name, val) = auth_header(&token);
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .add_header(name, val)
        .await
        .assert_status(StatusCode::NO_CONTENT);
}

#[tokio::test]
async fn delete_keyed_no_auth_returns_401() {
    let s = setup_with_visibility(Visibility::Private);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "locked", &token).await;

    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::UNAUTHORIZED);
}

#[tokio::test]
async fn delete_keyed_wrong_key_returns_404() {
    let s = setup_with_visibility(Visibility::Both);
    let (_key, token) = create_key(&s.store);
    let hash = create_keyed_secret(&s, "notmine", &token).await;
    let (_key2, token2) = s.store.create_key("intruder", None, None, None).unwrap();

    let (name, val) = auth_header(&token2);
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .add_header(name, val)
        .await
        .assert_status(StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn delete_already_burned_returns_410() {
    let s = setup();
    let hash = create_and_get_hash(&s, "burn-twice").await;

    // First delete.
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::NO_CONTENT);

    // Second delete — already gone.
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn delete_confirmed_via_subsequent_get() {
    let s = setup();
    let hash = create_and_get_hash(&s, "confirm-burn").await;

    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::NO_CONTENT);

    s.server
        .get(&format!("/secret/{hash}"))
        .await
        .assert_status(StatusCode::GONE);
}

// ── Cross-endpoint invariants ─────────────────────────────────────────────────

#[tokio::test]
async fn get_head_return_410_for_nonexistent_hash() {
    let s = setup_with_visibility(Visibility::Both);
    let fake = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

    // GET → 410
    s.server
        .get(&format!("/secret/{fake}"))
        .await
        .assert_status(StatusCode::GONE);

    // HEAD → 410
    s.server
        .method(Method::HEAD, &format!("/secret/{fake}"))
        .await
        .assert_status(StatusCode::GONE);
}

#[tokio::test]
async fn patch_delete_return_404_for_nonexistent_hash() {
    let s = setup_with_visibility(Visibility::Both);
    let fake = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

    // PATCH → 404 (authorize returns NotFound for None secret + Patch)
    s.server
        .patch(&format!("/secret/{fake}"))
        .json(&json!({"value": "x"}))
        .await
        .assert_status(StatusCode::NOT_FOUND);

    // DELETE → 404 (authorize returns NotFound for None secret + Burn)
    s.server
        .method(Method::DELETE, &format!("/secret/{fake}"))
        .await
        .assert_status(StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn bearer_token_wrong_scheme_falls_back_to_anon() {
    // "Basic ..." should silently fall back to anonymous, not 400.
    // In public mode, anonymous creates succeed.
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .add_header(
            header::AUTHORIZATION,
            "Basic dXNlcjpwYXNz".parse::<header::HeaderValue>().unwrap(),
        )
        .json(&json!({"value": "basic-auth-fallback"}))
        .await;
    // Falls back to anonymous — succeeds in public mode.
    resp.assert_status_success();
}

#[tokio::test]
async fn two_keys_have_different_tokens() {
    let s = setup_with_visibility(Visibility::Both);
    let (_k1, t1) = s.store.create_key("alice", None, None, None).unwrap();
    let (_k2, t2) = s.store.create_key("bob", None, None, None).unwrap();
    assert_ne!(t1, t2);
}

#[tokio::test]
async fn url_in_create_response_contains_hash() {
    let s = setup();
    let resp = s
        .server
        .post("/secret")
        .json(&json!({"value": "url-check"}))
        .await;
    resp.assert_status_success();
    let body: Value = resp.json();
    let hash = body["hash"].as_str().unwrap();
    let url = body["url"].as_str().unwrap();
    assert!(url.contains(hash), "url should contain the hash");
}

// ── GET /secrets ──────────────────────────────────────────────────────────────

/// Helper: create a secret in the store via POST and return its hash.
async fn create_owned_secret(s: &Setup, token: &str) -> String {
    let (name, value) = auth_header(token);
    let resp = s
        .server
        .post("/secret")
        .add_header(name, value)
        .json(&json!({"value": "owned-secret"}))
        .await;
    resp.assert_status_success();
    resp.json::<Value>()["hash"].as_str().unwrap().to_string()
}

#[tokio::test]
async fn list_my_secrets_returns_owned_only() {
    let s = setup_with_visibility(Visibility::Both);
    let (_k_a, tok_a) = s.store.create_key("alice", None, None, None).unwrap();
    let (_k_b, tok_b) = s.store.create_key("bob", None, None, None).unwrap();

    let hash_a1 = create_owned_secret(&s, &tok_a).await;
    let hash_a2 = create_owned_secret(&s, &tok_a).await;
    let _hash_b = create_owned_secret(&s, &tok_b).await;

    let (name, value) = auth_header(&tok_a);
    let resp = s.server.get("/secrets").add_header(name, value).await;
    resp.assert_status_success();

    let items: Vec<Value> = resp.json();
    assert_eq!(items.len(), 2, "should only see Alice's secrets");
    let returned_hashes: Vec<&str> = items.iter().map(|v| v["hash"].as_str().unwrap()).collect();
    assert!(returned_hashes.contains(&hash_a1.as_str()));
    assert!(returned_hashes.contains(&hash_a2.as_str()));
}

#[tokio::test]
async fn list_my_secrets_requires_auth() {
    let s = setup_with_visibility(Visibility::Both);
    let resp = s.server.get("/secrets").await;
    resp.assert_status(StatusCode::UNAUTHORIZED);
}

#[tokio::test]
async fn list_my_secrets_includes_burned() {
    let s = setup_with_visibility(Visibility::Both);
    let (_k, tok) = s.store.create_key("owner", None, None, None).unwrap();

    let hash = create_owned_secret(&s, &tok).await;

    // Burn the secret.
    let (name, value) = auth_header(&tok);
    s.server
        .method(Method::DELETE, &format!("/secret/{hash}"))
        .add_header(name, value)
        .await
        .assert_status(StatusCode::NO_CONTENT);

    // List should still include the burned tombstone.
    let (name, value) = auth_header(&tok);
    let resp = s.server.get("/secrets").add_header(name, value).await;
    resp.assert_status_success();

    let items: Vec<Value> = resp.json();
    assert_eq!(items.len(), 1);
    assert_eq!(items[0]["burned"], json!(true));
    assert!(items[0]["burned_at"].is_number());
}

#[tokio::test]
async fn list_my_secrets_excludes_values() {
    let s = setup_with_visibility(Visibility::Both);
    let (_k, tok) = s.store.create_key("owner", None, None, None).unwrap();

    create_owned_secret(&s, &tok).await;

    let (name, value) = auth_header(&tok);
    let resp = s.server.get("/secrets").add_header(name, value).await;
    resp.assert_status_success();

    let items: Vec<Value> = resp.json();
    assert_eq!(items.len(), 1);
    // Must not contain any value-related fields.
    assert!(items[0].get("value_ciphertext").is_none());
    assert!(items[0].get("value").is_none());
    assert!(items[0].get("nonce").is_none());
    assert!(items[0].get("owner_key_id").is_none());
    assert!(items[0].get("created_by_ip").is_none());
    // Must contain expected metadata fields.
    assert!(items[0]["hash"].is_string());
    assert!(items[0]["created_at"].is_number());
    assert_eq!(items[0]["owned"], json!(true));
}

#[tokio::test]
async fn list_my_secrets_empty_for_new_key() {
    let s = setup_with_visibility(Visibility::Both);
    let (_k, tok) = s.store.create_key("fresh", None, None, None).unwrap();

    let (name, value) = auth_header(&tok);
    let resp = s.server.get("/secrets").add_header(name, value).await;
    resp.assert_status_success();

    let items: Vec<Value> = resp.json();
    assert!(items.is_empty(), "new key should have no secrets");
}

#[tokio::test]
async fn list_my_secrets_503_when_locked() {
    let s = setup_with_visibility(Visibility::None);
    let resp = s.server.get("/secrets").await;
    resp.assert_status(StatusCode::SERVICE_UNAVAILABLE);
}