shoes 0.3.2

A multi-protocol proxy server.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
use bytes::{Bytes, BytesMut};
use futures::ready;
use std::io;
use std::pin::Pin;
use std::task::{Context, Poll};
use tokio::io::{AsyncRead, ReadBuf};

/// TLS record header size (ContentType + ProtocolVersion + Length)
const TLS_RECORD_HEADER_SIZE: usize = 5;

/// Maximum TLS ciphertext payload size per RFC specifications
///
/// The TLS record header's `length` field specifies the size of the ENCRYPTED payload (ciphertext).
/// Per RFC 8446 (TLS 1.3) and RFC 5246 (TLS 1.2), the limits are:
///
/// - TLS 1.3: Plaintext limit = 16,384 bytes (2^14)
///   Encryption overhead allowance = 256 bytes
///   Ciphertext limit = 16,384 + 256 = 16,640 bytes
///
/// - TLS 1.2: Plaintext limit = 16,384 bytes (2^14)
///   Encryption overhead allowance = 2,048 bytes
///   Ciphertext limit = 16,384 + 2,048 = 18,432 bytes
///
/// We use the TLS 1.2 limit for maximum compatibility with both protocol versions.
/// See /shoes/VISION_TLS_RECORD_SIZE.md for detailed analysis and RFC references.
const MAX_TLS_CIPHERTEXT_LEN: usize = 16384 + 2048; // 18,432 bytes (TLS 1.2 limit)

/// Maximum TLS record size (ciphertext + header)
pub const TLS_MAX_RECORD_SIZE: usize = MAX_TLS_CIPHERTEXT_LEN + TLS_RECORD_HEADER_SIZE;

/// TLS protocol versions we expect (0x0303 = TLS 1.2 for compatibility)
const TLS_PROTOCOL_VERSION_MAJOR: u8 = 0x03;
const TLS_PROTOCOL_VERSION_MINOR_MIN: u8 = 0x01;
const TLS_PROTOCOL_VERSION_MINOR_MAX: u8 = 0x03;

/// Deframer that reassembles TLS records from partial reads/writes
///
/// ```ignore
/// let mut deframer = TlsDeframer::new();
///
/// // Feed data as it arrives (may be partial)
/// deframer.feed(&chunk1);
/// deframer.feed(&chunk2);
///
/// // Extract complete records
/// while let Some(record) = deframer.next_record()? {
///     process_tls_record(record);
/// }
/// ```
#[derive(Debug, PartialEq)]
pub struct TlsDeframer {
    /// Buffer holding partial TLS record data
    buffer: BytesMut,

    /// Current parsing state
    state: DeframerState,
}

#[derive(Debug, Clone, Copy, PartialEq)]
enum DeframerState {
    /// Waiting for or reading the 5-byte TLS record header
    ReadingHeader,

    /// Reading payload of known length
    /// Stores the expected payload length
    ReadingPayload { payload_len: usize },
}

impl TlsDeframer {
    pub fn new() -> Self {
        Self {
            buffer: BytesMut::with_capacity(TLS_MAX_RECORD_SIZE),
            state: DeframerState::ReadingHeader,
        }
    }

    /// Feed data into the deframer
    ///
    /// This data may contain partial TLS records, complete records, or multiple records.
    /// Call `next_record()` after feeding to extract complete records.
    pub fn feed(&mut self, data: &[u8]) {
        self.buffer.extend_from_slice(data);
    }

    /// Extract the next complete TLS record if available
    ///
    /// This method automatically advances the internal buffer after extracting the record.
    ///
    /// Returns:
    /// - `Ok(Some(Bytes))` if a complete record is available (zero-copy slice)
    /// - `Ok(None)` if more data is needed
    /// - `Err(...)` if the data is malformed
    pub fn next_record(&mut self) -> io::Result<Option<Bytes>> {
        loop {
            match self.state {
                DeframerState::ReadingHeader => {
                    // Need at least 5 bytes for header
                    if self.buffer.len() < TLS_RECORD_HEADER_SIZE {
                        return Ok(None);
                    }

                    // Parse TLS record header
                    let content_type = self.buffer[0];
                    let version_major = self.buffer[1];
                    let version_minor = self.buffer[2];
                    let payload_len = u16::from_be_bytes([self.buffer[3], self.buffer[4]]) as usize;

                    // Validate protocol version (should be 0x03XX for TLS 1.x)
                    // Accept TLS 1.0 (0x0301), TLS 1.1 (0x0302), TLS 1.2 (0x0303), and TLS 1.3 (0x0303)
                    // TLS 1.3 uses 0x0303 in the record layer for backwards compatibility
                    if version_major != TLS_PROTOCOL_VERSION_MAJOR
                        || !(TLS_PROTOCOL_VERSION_MINOR_MIN..=TLS_PROTOCOL_VERSION_MINOR_MAX)
                            .contains(&version_minor)
                    {
                        return Err(io::Error::new(
                            io::ErrorKind::InvalidData,
                            format!(
                                "Invalid TLS protocol version: 0x{:02x}{:02x} (expected 0x0301 to 0x0303)",
                                version_major, version_minor
                            ),
                        ));
                    }

                    // Validate ciphertext payload length
                    // The `payload_len` from the TLS record header specifies encrypted data size.
                    // TLS 1.2 allows up to 18,432 bytes (16,384 plaintext + 2,048 overhead).
                    if payload_len > MAX_TLS_CIPHERTEXT_LEN {
                        return Err(io::Error::new(
                            io::ErrorKind::InvalidData,
                            format!(
                                "TLS record ciphertext length {} exceeds maximum {} (TLS 1.2 limit)",
                                payload_len, MAX_TLS_CIPHERTEXT_LEN
                            ),
                        ));
                    }

                    // Validate content type (basic sanity check)
                    // Valid types: 0x14-0x18 (ChangeCipherSpec, Alert, Handshake, Application Data, Heartbeat)
                    if !(0x14..=0x18).contains(&content_type) {
                        return Err(io::Error::new(
                            io::ErrorKind::InvalidData,
                            format!("Invalid TLS content type: 0x{:02x}", content_type),
                        ));
                    }

                    // Transition to reading payload
                    self.state = DeframerState::ReadingPayload { payload_len };
                }

                DeframerState::ReadingPayload { payload_len } => {
                    let total_len = TLS_RECORD_HEADER_SIZE + payload_len;

                    // Check if we have the complete record
                    if self.buffer.len() < total_len {
                        return Ok(None);
                    }

                    // We have a complete record! Extract it using split_to for zero-copy.
                    // BytesMut::split_to() returns a Bytes object that shares the underlying
                    // buffer without copying, and advances the BytesMut past the split point.
                    let record = self.buffer.split_to(total_len).freeze();

                    // Reset state for next record
                    self.state = DeframerState::ReadingHeader;

                    return Ok(Some(record));
                }
            }
        }
    }

    pub fn poll_read_record<IO: AsyncRead + Unpin + ?Sized>(
        &mut self,
        io: &mut IO,
        cx: &mut Context<'_>,
        scratch: &mut [u8],
        read_ahead: bool,
    ) -> Poll<io::Result<Option<Bytes>>> {
        loop {
            if let Some(record) = self.next_record()? {
                return Poll::Ready(Ok(Some(record)));
            }

            let read_len = if read_ahead {
                scratch.len()
            } else {
                // Finish seeded input at a record boundary before returning to backend reads.
                let record_len = match self.state {
                    DeframerState::ReadingHeader => TLS_RECORD_HEADER_SIZE,
                    DeframerState::ReadingPayload { payload_len } => {
                        TLS_RECORD_HEADER_SIZE + payload_len
                    }
                };
                scratch.len().min(record_len - self.buffer.len())
            };
            let mut buf = ReadBuf::new(&mut scratch[..read_len]);
            ready!(Pin::new(&mut *io).poll_read(cx, &mut buf))?;
            if buf.filled().is_empty() {
                return if self.pending_bytes() == 0 {
                    Poll::Ready(Ok(None))
                } else {
                    Poll::Ready(Err(io::Error::new(
                        io::ErrorKind::UnexpectedEof,
                        "EOF inside a TLS record",
                    )))
                };
            }
            self.feed(buf.filled());
        }
    }

    /// Get the number of bytes currently buffered
    pub fn pending_bytes(&self) -> usize {
        self.buffer.len()
    }

    /// Extract all available complete TLS records
    ///
    /// This is equivalent to calling `next_record()` repeatedly until it returns `Ok(None)`,
    /// but more convenient when you want to process all available records at once.
    ///
    /// Returns a vector of all complete records that can be extracted from the current buffer.
    /// If no complete records are available, returns an empty vector.
    ///
    /// Returns:
    /// - `Ok(Vec<Bytes>)` containing all available complete records (may be empty)
    /// - `Err(...)` if any record is malformed
    pub fn next_records(&mut self) -> io::Result<Vec<Bytes>> {
        let mut records = Vec::new();

        while let Some(record) = self.next_record()? {
            records.push(record);
        }

        Ok(records)
    }

    /// Consume the deframer and return all remaining buffered data
    pub fn into_remaining_data(self) -> Bytes {
        self.buffer.freeze()
    }

    pub fn remaining_data(&self) -> &[u8] {
        &self.buffer
    }

    /// Clear all buffered data
    pub fn clear(&mut self) {
        self.buffer.clear();
        self.state = DeframerState::ReadingHeader;
    }

    pub fn deallocate(&mut self) {
        drop(std::mem::take(&mut self.buffer));
    }
}

impl Default for TlsDeframer {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use futures::task::noop_waker_ref;
    use tokio::io::AsyncWriteExt;

    #[tokio::test]
    async fn poll_read_record_retains_partial_data_across_pending() {
        let record = make_tls_record(0x17, b"payload");
        for split in [2, 8] {
            let (mut reader, mut writer) = tokio::io::duplex(64);
            let mut deframer = TlsDeframer::new();
            let mut scratch = [0; 32];
            let mut cx = Context::from_waker(noop_waker_ref());
            writer.write_all(&record[..split]).await.unwrap();
            assert!(
                deframer
                    .poll_read_record(&mut reader, &mut cx, &mut scratch, true)
                    .is_pending()
            );
            writer.write_all(&record[split..]).await.unwrap();
            let Poll::Ready(Ok(Some(received))) =
                deframer.poll_read_record(&mut reader, &mut cx, &mut scratch, true)
            else {
                panic!("complete record remained pending");
            };
            assert_eq!(received, record);
        }
    }

    #[test]
    fn bounded_record_read_leaves_the_next_record_on_the_transport() {
        let record = make_tls_record(0x17, b"payload");
        for split in [0, 2, 8] {
            let mut deframer = TlsDeframer::new();
            deframer.feed(&record[..split]);
            let data = [&record[split..], b"opaque tail"].concat();
            let mut reader = data.as_slice();
            let mut scratch = [0; 64];
            let mut cx = Context::from_waker(noop_waker_ref());
            let Poll::Ready(Ok(Some(received))) =
                deframer.poll_read_record(&mut reader, &mut cx, &mut scratch, false)
            else {
                panic!("complete record remained pending");
            };
            assert_eq!(received, record);
            assert_eq!(reader, b"opaque tail");
            assert_eq!(deframer.pending_bytes(), 0);
        }
    }

    #[test]
    fn poll_read_record_distinguishes_clean_and_truncated_eof() {
        let record = make_tls_record(0x17, b"payload");
        for length in 0..record.len() {
            let mut reader = &record[..length];
            let mut deframer = TlsDeframer::new();
            let mut scratch = [0; 32];
            let mut cx = Context::from_waker(noop_waker_ref());
            let result = deframer.poll_read_record(&mut reader, &mut cx, &mut scratch, true);
            if length == 0 {
                assert!(matches!(result, Poll::Ready(Ok(None))));
            } else {
                assert!(
                    matches!(result, Poll::Ready(Err(e)) if e.kind() == io::ErrorKind::UnexpectedEof)
                );
            }
        }
    }

    /// Helper to create a TLS record with given content type and payload
    fn make_tls_record(content_type: u8, payload: &[u8]) -> Vec<u8> {
        let mut record = Vec::new();
        record.push(content_type);
        record.push(0x03); // Version major
        record.push(0x03); // Version minor
        let len = payload.len() as u16;
        record.extend_from_slice(&len.to_be_bytes());
        record.extend_from_slice(payload);
        record
    }

    #[test]
    fn test_single_complete_packet() {
        let mut deframer = TlsDeframer::new();

        let payload = b"Hello, TLS!";
        let record = make_tls_record(0x17, payload); // Application Data

        deframer.feed(&record);

        let read_record = deframer.next_record().unwrap();
        assert!(read_record.is_some());
        let read_record = read_record.unwrap();
        assert_eq!(read_record, &record[..]);

        // Verify no more packets
        assert!(deframer.next_record().unwrap().is_none());
    }

    #[test]
    fn test_partial_packet_split_header() {
        let mut deframer = TlsDeframer::new();

        let payload = b"Partial header test";
        let record = make_tls_record(0x16, payload); // Handshake

        // Feed first 3 bytes (partial header)
        deframer.feed(&record[..3]);
        assert!(deframer.next_record().unwrap().is_none());

        // Feed rest of header
        deframer.feed(&record[3..5]);
        assert!(deframer.next_record().unwrap().is_none());

        // Feed payload
        deframer.feed(&record[5..]);
        let extracted_record = deframer.next_record().unwrap();
        assert!(extracted_record.is_some());
        assert_eq!(extracted_record.unwrap(), &record[..]);
    }

    #[test]
    fn test_partial_packet_split_payload() {
        let mut deframer = TlsDeframer::new();

        let payload = vec![0x42; 100]; // 100 bytes of 0x42
        let record = make_tls_record(0x17, &payload);

        // Feed header + half payload
        let split_point = 5 + 50;
        deframer.feed(&record[..split_point]);
        assert!(deframer.next_record().unwrap().is_none());

        // Feed rest of payload
        deframer.feed(&record[split_point..]);
        let extracted_record = deframer.next_record().unwrap();
        assert!(extracted_record.is_some());
        assert_eq!(extracted_record.unwrap(), &record[..]);
    }

    #[test]
    fn test_multiple_packets_at_once() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"First");
        let record2 = make_tls_record(0x17, b"Second");
        let record3 = make_tls_record(0x16, b"Third");

        // Feed all three at once
        let mut combined = Vec::new();
        combined.extend_from_slice(&record1);
        combined.extend_from_slice(&record2);
        combined.extend_from_slice(&record3);

        deframer.feed(&combined);

        // Extract all three (automatically consumed)
        let rec1 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec1, &record1[..]);

        let rec2 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec2, &record2[..]);

        let rec3 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec3, &record3[..]);

        assert!(deframer.next_record().unwrap().is_none());
    }

    #[test]
    fn test_multiple_packets_partial_boundary() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"Record One");
        let record2 = make_tls_record(0x17, b"Record Two");

        let mut combined = Vec::new();
        combined.extend_from_slice(&record1);
        combined.extend_from_slice(&record2);

        // Feed up to middle of second record
        let split = record1.len() + 8;
        deframer.feed(&combined[..split]);

        // Should get first record (automatically consumed)
        let rec1 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec1, &record1[..]);

        // Second record not complete yet
        assert!(deframer.next_record().unwrap().is_none());

        // Feed rest
        deframer.feed(&combined[split..]);
        let rec2 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec2, &record2[..]);
    }

    #[test]
    fn test_tls10_accepted() {
        let mut deframer = TlsDeframer::new();

        let mut record = vec![0x16, 0x03, 0x01, 0x00, 0x05]; // TLS 1.0
        record.extend_from_slice(b"Hello");

        deframer.feed(&record);

        let result = deframer.next_record();
        assert!(result.is_ok());
        assert_eq!(result.unwrap().unwrap(), &record[..]);
    }

    #[test]
    fn test_invalid_protocol_version() {
        let mut deframer = TlsDeframer::new();

        let mut record = vec![0x16, 0x02, 0x00, 0x00, 0x05]; // SSL 2.0 (invalid)
        record.extend_from_slice(b"Hello");

        deframer.feed(&record);

        let result = deframer.next_record();
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Invalid TLS protocol version")
        );
    }

    #[test]
    fn test_invalid_content_type() {
        let mut deframer = TlsDeframer::new();

        let mut record = vec![0xFF, 0x03, 0x03, 0x00, 0x05]; // Invalid content type
        record.extend_from_slice(b"Hello");

        deframer.feed(&record);

        let result = deframer.next_record();
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Invalid TLS content type")
        );
    }

    #[test]
    fn test_excessive_payload_length() {
        let mut deframer = TlsDeframer::new();

        // Payload length > 18432 (TLS 1.2 max ciphertext)
        let record = vec![0x17, 0x03, 0x03, 0xFF, 0xFF]; // 65535 bytes

        deframer.feed(&record);

        let result = deframer.next_record();
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("exceeds maximum"));
    }

    #[test]
    fn test_byte_by_byte_feed() {
        let mut deframer = TlsDeframer::new();

        let record = make_tls_record(0x16, b"Byte by byte");

        // Feed one byte at a time
        for byte in &record[..record.len() - 1] {
            deframer.feed(&[*byte]);
            assert!(deframer.next_record().unwrap().is_none());
        }

        // Feed last byte
        deframer.feed(&[record[record.len() - 1]]);
        let extracted_record = deframer.next_record().unwrap().unwrap();
        assert_eq!(extracted_record, &record[..]);
    }

    #[test]
    fn test_clear() {
        let mut deframer = TlsDeframer::new();

        let record = make_tls_record(0x16, b"Test");
        deframer.feed(&record[..3]); // Partial

        assert_eq!(deframer.pending_bytes(), 3);

        deframer.clear();

        assert_eq!(deframer.pending_bytes(), 0);
        assert!(deframer.next_record().unwrap().is_none());
    }

    #[test]
    fn test_empty_payload() {
        let mut deframer = TlsDeframer::new();

        let record = make_tls_record(0x16, b""); // Empty payload

        deframer.feed(&record);

        let extracted_record = deframer.next_record().unwrap().unwrap();
        assert_eq!(extracted_record.len(), 5); // Just the header
        assert_eq!(extracted_record, &record[..]);
    }

    #[test]
    fn test_max_size_payload() {
        let mut deframer = TlsDeframer::new();

        // Test with maximum TLS 1.2 ciphertext size (18,432 bytes)
        let payload = vec![0xAA; 18432];
        let record = make_tls_record(0x17, &payload);

        deframer.feed(&record);

        let extracted_record = deframer.next_record().unwrap().unwrap();
        assert_eq!(extracted_record, &record[..]);
    }

    #[test]
    fn test_reuse_after_consume() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"First");
        let record2 = make_tls_record(0x17, b"Second");

        // First packet (automatically consumed)
        deframer.feed(&record1);
        let rec1 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec1, &record1[..]);

        // Second packet (automatically consumed)
        deframer.feed(&record2);
        let rec2 = deframer.next_record().unwrap().unwrap();
        assert_eq!(rec2, &record2[..]);

        assert_eq!(deframer.pending_bytes(), 0);
    }

    #[test]
    fn test_next_records_empty() {
        let mut deframer = TlsDeframer::new();

        let records = deframer.next_records().unwrap();
        assert!(records.is_empty());
    }

    #[test]
    fn test_next_records_single() {
        let mut deframer = TlsDeframer::new();

        let record = make_tls_record(0x16, b"Single");
        deframer.feed(&record);

        let records = deframer.next_records().unwrap();
        assert_eq!(records.len(), 1);
        assert_eq!(records[0], &record[..]);
    }

    #[test]
    fn test_next_records_multiple() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"First");
        let record2 = make_tls_record(0x17, b"Second");
        let record3 = make_tls_record(0x16, b"Third");

        let mut combined = Vec::new();
        combined.extend_from_slice(&record1);
        combined.extend_from_slice(&record2);
        combined.extend_from_slice(&record3);

        deframer.feed(&combined);

        let records = deframer.next_records().unwrap();
        assert_eq!(records.len(), 3);
        assert_eq!(records[0], &record1[..]);
        assert_eq!(records[1], &record2[..]);
        assert_eq!(records[2], &record3[..]);

        assert_eq!(deframer.pending_bytes(), 0);
    }

    #[test]
    fn test_next_records_partial_remaining() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"Complete");
        let record2 = make_tls_record(0x17, b"Incomplete");

        let mut combined = Vec::new();
        combined.extend_from_slice(&record1);
        combined.extend_from_slice(&record2[..10]); // Only partial second record

        deframer.feed(&combined);

        let records = deframer.next_records().unwrap();
        assert_eq!(records.len(), 1);
        assert_eq!(records[0], &record1[..]);

        // Should still have partial data
        assert_eq!(deframer.pending_bytes(), 10);
    }

    #[test]
    fn test_next_records_error_propagation() {
        let mut deframer = TlsDeframer::new();

        // Invalid record with bad content type
        let mut bad_record = vec![0xFF, 0x03, 0x03, 0x00, 0x05];
        bad_record.extend_from_slice(b"Hello");

        deframer.feed(&bad_record);

        let result = deframer.next_records();
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Invalid TLS content type")
        );
    }

    #[test]
    fn test_next_records_mixed_complete_and_partial() {
        let mut deframer = TlsDeframer::new();

        let record1 = make_tls_record(0x16, b"First");
        let record2 = make_tls_record(0x17, b"Second");

        // Feed first complete record and partial second
        deframer.feed(&record1);
        deframer.feed(&record2[..8]);

        let records = deframer.next_records().unwrap();
        assert_eq!(records.len(), 1);
        assert_eq!(records[0], &record1[..]);

        // Complete the second record
        deframer.feed(&record2[8..]);

        let records = deframer.next_records().unwrap();
        assert_eq!(records.len(), 1);
        assert_eq!(records[0], &record2[..]);
    }
}