shepherd-cli 6.5.9 

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

use shepherd_cli::shepherd::dispatch::{
    LaneId, ReviewMode, ReviewResult, ReviewVerdict, Role, RunId,
};
use shepherd_cli::{
    REVIEW_REQUEST_SCHEMA, ReviewValidationRequest, validate_review_result_request,
};

fn review(mode: ReviewMode, role: Role, verdict: ReviewVerdict) -> ReviewResult {
    ReviewResult {
        schema: "shepherd.review-result/1".into(),
        run: RunId::new("v657").expect("run"),
        lane: Some(LaneId::new("l1-engine").expect("lane")),
        mode,
        reviewer_role: role,
        candidate_commit: "0123456789abcdef0123456789abcdef01234567".into(),
        input_digest: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa".into(),
        startup_skill: "reviewing".into(),
        skill_bundle_digest: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
            .into(),
        result_channel: "native-result".into(),
        verdict,
        findings: vec![],
        report_path: None,
    }
}

#[test]
fn cli_accepts_only_typed_role_correct_review_results() {
    let result = validate_review_result_request(ReviewValidationRequest {
        schema: REVIEW_REQUEST_SCHEMA.into(),
        review: review(ReviewMode::CriticPrehoc, Role::Critic, ReviewVerdict::Green),
    })
    .expect("Critic result validates");
    assert_eq!(result.reviewer_role, Role::Critic);

    let mut invalid = review(ReviewMode::CriticPrehoc, Role::Critic, ReviewVerdict::Green);
    invalid.report_path = Some("runs/v657/critic.md".into());
    assert!(
        validate_review_result_request(ReviewValidationRequest {
            schema: REVIEW_REQUEST_SCHEMA.into(),
            review: invalid,
        })
        .is_err()
    );

    let mut auditor = review(
        ReviewMode::AuditorPosthoc,
        Role::Auditor,
        ReviewVerdict::Pass,
    );
    auditor.report_path = Some("runs/v657/auditor.md".into());
    validate_review_result_request(ReviewValidationRequest {
        schema: REVIEW_REQUEST_SCHEMA.into(),
        review: auditor.clone(),
    })
    .expect("Auditor report path with observed report-write validates");
    auditor.report_path = None;
    assert!(
        validate_review_result_request(ReviewValidationRequest {
            schema: REVIEW_REQUEST_SCHEMA.into(),
            review: auditor,
        })
        .is_err()
    );
}