shep-core 0.8.3

//! On-disk layout of `$SHEP_HOME`
//!
//! One resolver, no hidden `std::env` reads: the environment comes in as a
//! closure so tests and the daemon share one code path.

use std::ffi::OsString;
use std::path::{Path, PathBuf};

/// Drops the `\\?\` extended-length prefix Windows' `canonicalize` adds
///
/// For paths leaving shep: written to config, shown to an operator, or
/// handed to another program. Paths compared against each other internally,
/// such as `serve`'s docroot containment check, must stay canonical on both
/// sides and must not go through this.
///
/// Only unwraps `\\?\C:\`; a verbatim UNC path (`\\?\UNC\server\share`)
/// passes through unchanged. Not for paths above `MAX_PATH`, where the
/// prefix is load-bearing rather than decorative.
#[cfg(windows)]
#[must_use]
pub fn strip_verbatim_prefix(path: &Path) -> std::borrow::Cow<'_, Path> {
    use std::path::{Component, Prefix};

    let mut components = path.components();
    let Some(Component::Prefix(prefix)) = components.next() else {
        return std::borrow::Cow::Borrowed(path);
    };
    let Prefix::VerbatimDisk(letter) = prefix.kind() else {
        return std::borrow::Cow::Borrowed(path);
    };

    let mut rebuilt = PathBuf::from(format!("{}:\\", char::from(letter)));
    rebuilt.extend(components.filter(|part| !matches!(part, Component::RootDir)));
    std::borrow::Cow::Owned(rebuilt)
}

/// Passes the path through: only Windows' `canonicalize` prefixes its output
///
/// See the Windows sibling for what this exists to undo.
#[cfg(not(windows))]
#[must_use]
pub fn strip_verbatim_prefix(path: &Path) -> std::borrow::Cow<'_, Path> {
    std::borrow::Cow::Borrowed(path)
}

/// The user's home directory, read through `var` rather than the process
/// environment
///
/// The base [`ShepPaths::resolve`] joins `.shep` onto when nothing names a
/// `$SHEP_HOME`. A variable set to the empty string counts as unset.
///
/// # Platform
///
/// Unix reads `HOME` alone. Windows reads `HOME`, then `USERPROFILE`, then
/// `HOMEDRIVE` and `HOMEPATH` concatenated. Windows sets none of the first:
/// PowerShell's `$HOME` is a shell variable no child process inherits, and
/// `cmd.exe` has no such variable at all, so a `HOME`-only lookup resolves
/// nothing on a stock Windows session.
#[must_use]
pub fn user_home(var: &dyn Fn(&str) -> Option<OsString>) -> Option<PathBuf> {
    let named = |key: &str| var(key).filter(|value| !value.is_empty());
    #[cfg(not(windows))]
    {
        named("HOME").map(PathBuf::from)
    }
    #[cfg(windows)]
    {
        // `HOMEDRIVE` is `C:` and `HOMEPATH` is `\Users\name`: two halves of
        // one string, not a directory and a child inside it.
        let split = || {
            let mut joined = named("HOMEDRIVE")?;
            joined.push(named("HOMEPATH")?);
            Some(joined)
        };
        named("HOME")
            .or_else(|| named("USERPROFILE"))
            .or_else(split)
            .map(PathBuf::from)
    }
}

/// How an operator on this platform spells the variable behind
/// [`user_home`], for a refusal that has to say what to set.
#[cfg(not(windows))]
pub(crate) const HOME_DIR_VAR: &str = "$HOME";

/// Names `%USERPROFILE%` rather than `HOME`: although [`user_home`] reads
/// `HOME` first, a stock Windows session sets none, so `%USERPROFILE%` is
/// the first of the three that answers.
#[cfg(windows)]
pub(crate) const HOME_DIR_VAR: &str = "%USERPROFILE%";

/// How an operator on this platform spells `SHEP_HOME`, for a refusal that
/// has to say what to set.
#[cfg(not(windows))]
pub(crate) const SHEP_HOME_VAR: &str = "$SHEP_HOME";

/// How an operator on this platform spells `SHEP_HOME`, for a refusal that
/// has to say what to set.
#[cfg(windows)]
pub(crate) const SHEP_HOME_VAR: &str = "%SHEP_HOME%";

/// The directory a shep home defaults to, under the user's own home.
const DEFAULT_HOME_DIR: &str = ".shep";

/// The shep home directory `$SHEP_HOME` names, or the default under
/// `home_dir`
///
/// `None` only when nothing names a `$SHEP_HOME` and `home_dir` is `None`
/// too, which is the same condition that leaves a `~/` path unexpandable.
///
/// Unlike [`user_home`], an empty `$SHEP_HOME` is taken at its word rather
/// than read as unset, which is what [`ShepPaths::resolve`] has always done.
/// No operator reaches that: the CLI refuses an empty `--home` or
/// `$SHEP_HOME` before either function runs. It matters to a library caller
/// passing its own lookup, who gets one answer from here and from the
/// layout rather than two.
#[must_use]
pub fn shep_home(env: &dyn Fn(&str) -> Option<String>, home_dir: Option<&Path>) -> Option<PathBuf> {
    match home_dir {
        Some(dir) => Some(home_under(env, dir)),
        None => env("SHEP_HOME").map(PathBuf::from),
    }
}

/// [`shep_home`] for a caller that has a home directory, so the answer is
/// total.
///
/// The rule lives here rather than in [`shep_home`] so that
/// [`ShepPaths::resolve`], which always has one, reaches it without an
/// `Option` it would have to unwrap through a branch that can never fire.
fn home_under(env: &dyn Fn(&str) -> Option<String>, home_dir: &Path) -> PathBuf {
    env("SHEP_HOME")
        .map(PathBuf::from)
        .unwrap_or_else(|| home_dir.join(DEFAULT_HOME_DIR))
}

/// Resolved filesystem layout for one shep home
///
/// All paths are derived from `$SHEP_HOME` (default `<home>/.shep`); nothing
/// here touches the filesystem. The root itself is created by the CLI's own
/// `ensure_home`, for the commands that need it before any daemon exists
/// (`startup` above all), and everything under it by
/// `shep_daemon::boot::init_dirs` on each boot.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ShepPaths {
    /// Root: `$SHEP_HOME`
    pub home: PathBuf,
    /// Daemon config: `shep.toml`
    pub daemon_config: PathBuf,
    /// A dog's own settings: `dogs.toml`
    ///
    /// Separate from [`Self::daemon_config`] rather than a section inside
    /// it, so lookout can write a dog's config without writing into the
    /// daemon's own hand-authored file.
    pub dogs_config: PathBuf,
    /// Flock snapshot (muster roll): `flock.json`
    pub snapshot: PathBuf,
    /// Log directory
    pub logs: PathBuf,
    /// Pid-file directory
    pub pids: PathBuf,
    /// Runtime dir (sockets; created 0700)
    pub run: PathBuf,
    /// The control address the client dials and the daemon answers on.
    ///
    /// Unix: a filesystem path, `run/shep.sock`, naming a real AF_UNIX
    /// socket file. Windows: [`Self::pipe_name`], path-shaped but naming an
    /// object in the kernel's pipe namespace, not a file on any volume.
    /// Never derive a directory from this field: `socket.parent()` is
    /// meaningless on Windows. A pipe has no directory entry to watch, so
    /// "has the daemon gone" needs a connect attempt there, not
    /// `Path::exists`.
    pub socket: PathBuf,
    /// Bark history ring: `barks.jsonl`
    pub barks: PathBuf,
    /// Key/value store: `kv.json`
    pub kv: PathBuf,
    /// Operator override store: `overrides.json`
    pub overrides: PathBuf,
    /// Secret store: `secrets.json`
    pub secrets: PathBuf,
    /// Cached provider values: `secrets-cache.json`
    ///
    /// Derived and safe to delete, unlike [`Self::secrets`]: a provider dog
    /// rewrites it on its next push.
    pub secrets_cache: PathBuf,
}

/// FNV-1a, 64-bit, over `bytes`
///
/// Hand-rolled rather than reached for from `std`: [`std::hash::DefaultHasher`]
/// does not promise a stable value across toolchains, and the daemon and a
/// client built separately have to derive one pipe name and agree on it.
fn fnv1a64(bytes: &[u8]) -> u64 {
    bytes.iter().fold(0xcbf2_9ce4_8422_2325, |hash, &byte| {
        (hash ^ u64::from(byte)).wrapping_mul(0x0000_0100_0000_01b3)
    })
}

impl ShepPaths {
    /// Windows named-pipe identity for this home:
    /// `\\.\pipe\shep-<sanitized>-<digest>`
    ///
    /// The sanitized stem is not unique alone: `\`, `:`, `.`, `_` and a
    /// literal `-` all collapse to `-`, so `C:\a\b` and `C:\a-b` sanitize to
    /// one string. The digest of the full home path is what keeps two homes
    /// distinct; without it a collision would not error, it would refuse the
    /// second daemon as already running and let its CLI drive the first
    /// home's flock.
    ///
    /// Changing this derivation breaks any already-running daemon: it stays
    /// bound under a name a client built afterward would never dial.
    #[must_use]
    pub fn pipe_name(&self) -> String {
        // Bounds the readable half; a pipe name may be 256 characters.
        const MAX_STEM: usize = 64;

        let home = self.home.to_string_lossy();
        let sanitized: String = home
            .chars()
            .map(|c| if c.is_ascii_alphanumeric() { c } else { '-' })
            .collect();
        let trimmed = sanitized.trim_matches('-');
        // Every character above is ASCII, so this cut cannot split one.
        let stem = trimmed[..trimmed.len().min(MAX_STEM)].trim_end_matches('-');
        let digest = fnv1a64(home.as_bytes());
        format!(r"\\.\pipe\shep-{stem}-{digest:016x}")
    }

    /// Resolves the layout from an environment lookup and the user's home dir
    ///
    /// [`Self::socket`] resolves per-platform: a socket file under `run/` on
    /// unix, [`Self::pipe_name`] on Windows. Everything else is identical.
    ///
    /// # Why `String` and not `OsString`
    ///
    /// [`user_home`] takes an `OsString` lookup and this takes a `String`
    /// one, which reads like an oversight and is not. A home path does not
    /// stay a path: it reaches the `{{SHEP_HOME}}` template, [`Self::pipe_name`]
    /// and every log path on the wire as text, and each of those conversions
    /// is lossy. Widening this signature would move the loss rather than
    /// remove it, and it would break every caller of a published crate to do
    /// so.
    ///
    /// The CLI refuses a home that is not valid UTF-8 instead, at the one
    /// door an operator can name one through, so nothing lossy reaches here.
    /// A library caller supplying its own lookup has already chosen its
    /// encoding by building a `String`.
    #[must_use]
    pub fn resolve(env: &dyn Fn(&str) -> Option<String>, home_dir: &Path) -> Self {
        let home = home_under(env, home_dir);
        let run = home.join("run");
        // `mut` is read only by the `cfg(windows)` block below; on unix the
        // value is returned exactly as built.
        #[cfg_attr(not(windows), allow(unused_mut))]
        let mut paths = Self {
            daemon_config: home.join("shep.toml"),
            dogs_config: home.join("dogs.toml"),
            snapshot: home.join("flock.json"),
            logs: home.join("logs"),
            pids: home.join("pids"),
            socket: run.join("shep.sock"),
            barks: home.join("barks.jsonl"),
            kv: home.join("kv.json"),
            overrides: home.join("overrides.json"),
            secrets: home.join("secrets.json"),
            secrets_cache: home.join("secrets-cache.json"),
            run,
            home,
        };
        // Computed here, not inlined above: `pipe_name` reads `self.home`,
        // and duplicating the sanitizer here would let the two drift.
        #[cfg(windows)]
        {
            paths.socket = PathBuf::from(paths.pipe_name());
        }
        paths
    }
}

#[cfg(test)]
mod tests {
    /// The one rule `ShepPaths::resolve` and the `{{SHEP_HOME}}` token both
    /// read, so a value rendered into a log path names the directory the
    /// rest of the layout was built under.
    #[test]
    fn shep_home_prefers_the_variable_and_falls_back_to_the_default() {
        use std::path::{Path, PathBuf};

        let named = |_: &str| Some("/srv/shep".to_string());
        let unset = |_: &str| None;
        let ada = Path::new("/home/ada");

        assert_eq!(
            super::shep_home(&named, Some(ada)),
            Some(PathBuf::from("/srv/shep")),
            "the variable wins over the default"
        );
        assert_eq!(
            super::shep_home(&named, None),
            Some(PathBuf::from("/srv/shep")),
            "and needs no home directory of its own"
        );
        assert_eq!(
            super::shep_home(&unset, Some(ada)),
            Some(ada.join(".shep")),
            "the default hangs off the user's home"
        );
        assert_eq!(
            super::shep_home(&unset, None),
            None,
            "with neither, there is nothing to name"
        );
        // The one behaviour that differs from `user_home`, which reads an
        // empty value as unset. Untested, a regression that filtered
        // `Some("")` the same way would leave the token and the layout
        // pointing at different directories and nothing would say so.
        assert_eq!(
            super::shep_home(&|_| Some(String::new()), Some(ada)),
            Some(PathBuf::new()),
            "an empty value is taken at its word rather than read as unset"
        );
        assert_eq!(
            super::ShepPaths::resolve(&named, ada).home,
            super::shep_home(&named, Some(ada)).expect("a home directory was given"),
            "and the layout is built from the same answer"
        );
    }

    /// Unit-level because no end-to-end case can pin this reliably: Node's
    /// handling of a `\\?\` path differs by version.
    #[cfg(windows)]
    #[test]
    fn a_verbatim_prefix_is_stripped() {
        let rewritten = super::strip_verbatim_prefix(std::path::Path::new(r"\\?\C:\tmp\flock.js"));
        assert_eq!(
            rewritten.as_os_str(),
            std::ffi::OsStr::new(r"C:\tmp\flock.js"),
            "node reads the leading `\\\\` as a UNC share and lstats `C:`, so \
             the verbatim prefix must not reach it"
        );

        let plain = std::path::Path::new(r"C:\tmp\flock.js");
        assert_eq!(
            super::strip_verbatim_prefix(plain).as_os_str(),
            plain.as_os_str(),
            "a path with no verbatim prefix must pass through untouched"
        );
    }

    /// Guards the assumption that `canonicalize` really prefixes the path.
    /// If a future Windows or std stops adding it, this stays green and the
    /// strip becomes a no-op rather than a wrong answer.
    #[cfg(windows)]
    #[test]
    fn a_real_canonicalized_path_comes_back_free_of_the_prefix() {
        let dir = tempfile::tempdir().expect("temp dir");
        let file = dir.path().join("dog.exe");
        std::fs::write(&file, b"not really an exe").expect("write file");

        let canonical = std::fs::canonicalize(&file).expect("canonicalize");
        let rewritten = super::strip_verbatim_prefix(&canonical);
        let shown = rewritten.display().to_string();

        assert!(
            !shown.starts_with(r"\\?\"),
            "the path an operator will read still carries a verbatim prefix: {shown}"
        );
        assert!(
            std::path::Path::new(&shown).is_file(),
            "stripping the prefix must not break the path: {shown}"
        );
    }

    #[cfg(not(windows))]
    #[test]
    fn a_unix_path_passes_through_untouched() {
        let plain = std::path::Path::new("/tmp/flock.js");
        assert_eq!(
            super::strip_verbatim_prefix(plain).as_os_str(),
            plain.as_os_str(),
            "the non-Windows arm must be an identity"
        );
    }

    use super::*;
    use std::path::Path;

    fn no_env(_: &str) -> Option<String> {
        None
    }

    #[test]
    fn default_layout_under_home_dir() {
        let p = ShepPaths::resolve(&no_env, Path::new("/home/ada"));
        assert_eq!(p.home, Path::new("/home/ada/.shep"));
        assert_eq!(p.daemon_config, Path::new("/home/ada/.shep/shep.toml"));
        assert_eq!(p.dogs_config, Path::new("/home/ada/.shep/dogs.toml"));
        assert_eq!(p.snapshot, Path::new("/home/ada/.shep/flock.json"));
        assert_eq!(p.logs, Path::new("/home/ada/.shep/logs"));
        assert_eq!(p.pids, Path::new("/home/ada/.shep/pids"));
        assert_eq!(p.run, Path::new("/home/ada/.shep/run"));
        assert_eq!(p.barks, Path::new("/home/ada/.shep/barks.jsonl"));
        assert_eq!(p.kv, Path::new("/home/ada/.shep/kv.json"));
        assert_eq!(p.overrides, Path::new("/home/ada/.shep/overrides.json"));
        assert_eq!(p.secrets, Path::new("/home/ada/.shep/secrets.json"));
        assert_eq!(
            p.secrets_cache,
            Path::new("/home/ada/.shep/secrets-cache.json")
        );
    }

    /// Asserted per-platform rather than skipped on Windows: a silent
    /// fallback to `run/shep.sock` there would leave a daemon bound to a
    /// pipe and a client dialing a file that does not exist.
    #[test]
    fn the_control_address_is_a_socket_file_on_unix_and_a_pipe_name_on_windows() {
        let p = ShepPaths::resolve(&no_env, Path::new("/home/ada"));
        #[cfg(unix)]
        assert_eq!(p.socket, Path::new("/home/ada/.shep/run/shep.sock"));
        #[cfg(windows)]
        assert_eq!(
            p.socket,
            Path::new(r"\\.\pipe\shep-home-ada--shep-fd394cfc5c93ad12")
        );
        #[cfg(windows)]
        assert_eq!(
            p.socket,
            Path::new(&p.pipe_name()),
            "the resolved address and `pipe_name` must not drift"
        );
    }

    #[test]
    fn shep_home_env_overrides_root() {
        let env = |key: &str| (key == "SHEP_HOME").then(|| "/srv/shep".to_string());
        let p = ShepPaths::resolve(&env, Path::new("/home/ada"));
        assert_eq!(p.home, Path::new("/srv/shep"));
        #[cfg(unix)]
        assert_eq!(p.socket, Path::new("/srv/shep/run/shep.sock"));
        #[cfg(windows)]
        assert_eq!(
            p.socket,
            Path::new(r"\\.\pipe\shep-srv-shep-23b467803966a71a")
        );
    }

    #[test]
    fn pipe_name_is_per_home_and_sanitized() {
        // Both homes come from the env, not the default join: its separator
        // is host-specific and would give the digest a different value per
        // platform.
        let env = |key: &str| (key == "SHEP_HOME").then(|| "/home/ada/.shep".to_string());
        let p = ShepPaths::resolve(&env, Path::new("/home/ada"));
        assert_eq!(
            p.pipe_name(),
            r"\\.\pipe\shep-home-ada--shep-626b4d544f86fe95"
        );
        let env = |key: &str| (key == "SHEP_HOME").then(|| "/srv/shep".to_string());
        let q = ShepPaths::resolve(&env, Path::new("/home/ada"));
        assert_eq!(q.pipe_name(), r"\\.\pipe\shep-srv-shep-23b467803966a71a");
    }

    /// The truncation, and the trim that has to follow it.
    ///
    /// Both cases above use a home far under the 64-byte stem cap, so
    /// nothing reached the slice or the second `trim_end_matches`. This home
    /// is built so the cut lands exactly on a separator: without that second
    /// trim the stem would end in a dash and the name would carry a double
    /// one before its digest.
    #[test]
    fn a_stem_longer_than_the_cap_is_cut_and_retrimmed() {
        let long = format!("/{}/bbbb", "a".repeat(63));
        let env = |key: &str| (key == "SHEP_HOME").then(|| long.clone());
        let name = ShepPaths::resolve(&env, Path::new("/home/ada")).pipe_name();

        let stem = name
            .strip_prefix(r"\\.\pipe\shep-")
            .expect("the fixed prefix")
            .rsplit_once('-')
            .expect("a digest after the stem")
            .0;
        assert_eq!(
            stem,
            "a".repeat(63),
            "cut at the cap, then the dash removed"
        );
        assert!(
            !name.contains("--"),
            "a dash left by the cut would double against the digest's own: {name}"
        );
    }

    /// Two homes that differ only past the cut still get their own pipe.
    ///
    /// The stem cannot tell them apart by construction, so this is the
    /// digest's job alone, and the digest is taken over the whole home
    /// rather than the truncated stem.
    #[test]
    fn two_homes_differing_only_past_the_cap_stay_distinct() {
        let base = "a".repeat(70);
        let one = format!("/{base}/one");
        let two = format!("/{base}/two");
        let env_one = |key: &str| (key == "SHEP_HOME").then(|| one.clone());
        let env_two = |key: &str| (key == "SHEP_HOME").then(|| two.clone());
        let a = ShepPaths::resolve(&env_one, Path::new("/home/ada")).pipe_name();
        let b = ShepPaths::resolve(&env_two, Path::new("/home/ada")).pipe_name();
        assert_ne!(a, b, "two homes, two pipes, whatever the cut discarded");
    }

    /// The sanitizer is not injective: `\`, `:` and `-` all become `-`. A
    /// collision would not error; it would refuse the second daemon as
    /// already running.
    #[test]
    fn two_homes_that_sanitize_alike_get_distinct_pipe_names() {
        let nested = |key: &str| (key == "SHEP_HOME").then(|| r"C:\a\b".to_string());
        let dashed = |key: &str| (key == "SHEP_HOME").then(|| r"C:\a-b".to_string());
        let n = ShepPaths::resolve(&nested, Path::new("/home/ada"));
        let d = ShepPaths::resolve(&dashed, Path::new("/home/ada"));
        assert!(
            n.pipe_name().starts_with(r"\\.\pipe\shep-C--a-b-")
                && d.pipe_name().starts_with(r"\\.\pipe\shep-C--a-b-"),
            "the readable stem is what collides, and it stays readable: {} vs {}",
            n.pipe_name(),
            d.pipe_name()
        );
        assert_ne!(
            n.pipe_name(),
            d.pipe_name(),
            "only the digest keeps two homes that sanitize alike off one pipe"
        );
    }

    /// A fake environment, so nothing here touches the process's own.
    fn os_env(pairs: &[(&str, &str)]) -> impl Fn(&str) -> Option<OsString> + use<> {
        let owned: Vec<(String, OsString)> = pairs
            .iter()
            .map(|(k, v)| ((*k).to_string(), OsString::from(*v)))
            .collect();
        move |key: &str| owned.iter().find(|(k, _)| k == key).map(|(_, v)| v.clone())
    }

    #[test]
    fn home_is_read_first_on_every_platform() {
        assert_eq!(
            user_home(&os_env(&[
                ("HOME", "/home/ada"),
                ("USERPROFILE", r"C:\Users\Ada")
            ])),
            Some(PathBuf::from("/home/ada"))
        );
    }

    #[test]
    fn nothing_named_resolves_nothing() {
        assert_eq!(user_home(&os_env(&[])), None);
    }

    /// An exported-but-empty `HOME` would otherwise resolve `.shep` relative
    /// to the working directory, which is a different flock per `cd`.
    #[test]
    fn an_empty_value_counts_as_unset() {
        assert_eq!(user_home(&os_env(&[("HOME", "")])), None);
    }

    /// The bug this fallback exists for: a stock Windows session exports
    /// `USERPROFILE` and no `HOME` at all, so `shep` refused every command
    /// with "none of --home, %SHEP_HOME%, or %USERPROFILE% resolves a root
    /// directory" until 0.7.1.
    #[cfg(windows)]
    #[test]
    fn windows_falls_back_to_userprofile_then_to_the_homedrive_pair() {
        assert_eq!(
            user_home(&os_env(&[("USERPROFILE", r"C:\Users\Ada")])),
            Some(PathBuf::from(r"C:\Users\Ada"))
        );
        assert_eq!(
            user_home(&os_env(&[("HOMEDRIVE", "C:"), ("HOMEPATH", r"\Users\Ada")])),
            Some(PathBuf::from(r"C:\Users\Ada")),
            "the two halves concatenate into one path, they do not nest"
        );
        assert_eq!(
            user_home(&os_env(&[("HOMEDRIVE", "C:")])),
            None,
            "half the pair names no directory"
        );
    }

    /// Unix reads `HOME` alone: a Windows-only fallback firing there would
    /// resolve a home on a host that deliberately unset one.
    #[cfg(not(windows))]
    #[test]
    fn unix_ignores_the_windows_variables() {
        assert_eq!(
            user_home(&os_env(&[
                ("USERPROFILE", r"C:\Users\Ada"),
                ("HOMEDRIVE", "C:"),
                ("HOMEPATH", r"\Users\Ada"),
            ])),
            None
        );
    }
}