1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
//! Representations of commands, elements that can be executed in the shell context.
use std::{collections::HashMap, sync::OnceLock};
use crate::{
commands::args::{ArgumentKind, BasicArgument, parse_string_argument},
errors::ShellError,
};
use flags::FlagDefinition;
use strum::IntoEnumIterator;
pub use args::Argument;
pub use flags::Flags;
pub use list::Commands;
mod args;
mod flags;
mod list;
static COMMANDS: OnceLock<HashMap<&str, Commands>> = OnceLock::new();
pub fn get_commands() -> &'static HashMap<&'static str, Commands> {
COMMANDS.get_or_init(|| Commands::iter().map(|cmd| (cmd.name(), cmd)).collect())
}
#[enum_dispatch::enum_dispatch(Commands)]
pub trait ExecutableCommand {
/// The name of the command
fn name(&self) -> &'static str;
/// The flags of the command
fn flags(&self) -> FlagDefinition;
/// The arguments of the command
fn args(&self) -> Option<ArgumentKind>;
/// Executes a command
///
/// # Returns
///
/// - `Ok(CommandOutput)` on successful execution, where the output contains
/// the command's result or any user-facing error messages.
/// - `Err` when an unexpected internal error occurs that prevents command execution.
fn execute(
&self,
flags: Flags,
args: Option<Argument>,
shell: &mut crate::shell::Shell,
) -> Result<CommandOutput, ShellError>;
}
#[derive(Debug)]
pub struct CommandOutput(pub Option<String>);
pub struct Command {
pub command: Commands,
pub flags: Flags,
pub args: Option<Argument>,
}
impl Command {
pub fn from_tokens(tokens: Vec<String>) -> Result<Self, Error> {
let (cmd_str, args) = tokens
.split_first()
.ok_or_else(|| Error::Internal("Failed to get command from tokens".to_string()))?;
let command = get_commands()
.get(cmd_str.as_str())
.ok_or_else(|| Error::UnknownCommand(cmd_str.to_string()))?;
let command_parser =
CommandParser::new(command, command.flags(), command.args(), args.to_vec());
command_parser.parse()
}
}
pub struct CommandParser {
command: &'static Commands,
flag_defs: FlagDefinition,
arg_defs: Option<ArgumentKind>,
args: Vec<String>,
parsed_flags: Flags,
parsed_args: Option<Argument>,
}
impl CommandParser {
pub fn new(
command: &'static Commands,
flag_defs: FlagDefinition,
flag_args: Option<ArgumentKind>,
args: Vec<String>,
) -> Self {
Self {
command,
flag_defs,
arg_defs: flag_args,
args,
parsed_flags: Flags::new(),
parsed_args: None,
}
}
pub fn parse(mut self) -> Result<Command, Error> {
let mut args_iter = self.args.iter().peekable();
while let Some(arg) = args_iter.next() {
match arg_kind(arg) {
ArgKind::ShorthandFlag => {
let mut flag_iter = arg.chars().skip(1).peekable();
while let Some(flag) = flag_iter.next() {
let has_next_flag = flag_iter.peek().is_some();
let has_next_arg = args_iter.peek().is_some();
match self.flag_defs.get_flag_shorthand(flag) {
Some(flag_spec) => match &flag_spec.arg_type {
ArgumentKind::Basic(_) => {
if has_next_flag {
// Technically this means that we combined flags but this
// one expected an argument.
// TODO: Search up what is the proper sanction for this.
return Err(Error::InvalidFlagArgument(
flag.to_string(),
"No argument provided".to_string(),
));
}
if !has_next_arg {
return Err(Error::InvalidFlagArgument(
flag.to_string(),
"No argument provided".to_string(),
));
}
let flag_arg = args_iter.next().ok_or_else(|| {
Error::InvalidFlagArgument(
flag.to_string(),
"No argument provided".to_string(),
)
})?;
let parsed_arg =
parse_string_argument(flag_arg, &flag_spec.arg_type)
.map_err(|e| {
Error::ArgumentParsing(
flag_arg.to_string(),
e.to_string(),
)
})?;
self.parsed_flags
.insert(flag_spec.name, Argument::Basic(parsed_arg));
}
ArgumentKind::List(_) | ArgumentKind::Enumeration(_) => {
return Err(Error::Internal(
"A list or enumeration is not a valid flag argument"
.to_string(),
));
}
ArgumentKind::Flag => {
self.parsed_flags.insert(flag_spec.name, Argument::Flag);
}
},
None => return Err(Error::UnknownFlag(flag.to_string())),
}
}
}
ArgKind::LonghandFlag => {
let flag_name = arg
.strip_prefix("--")
.expect("A longhand flag should start with --");
match self.flag_defs.get_flag_longhand(flag_name) {
Some(flag_spec) => match &flag_spec.arg_type {
ArgumentKind::Basic(_) => {
match args_iter.peek() {
Some(arg) if arg.starts_with('-') => {
return Err(Error::InvalidFlagArgument(
flag_name.to_string(),
"No argument provided".to_string(),
));
}
None => {
return Err(Error::MissingCommandArgument(0));
}
_ => {}
}
let flag_arg = args_iter.next().ok_or_else(|| {
Error::InvalidFlagArgument(
flag_name.to_string(),
"No argument provided".to_string(),
)
})?;
let parsed_arg = parse_string_argument(
flag_arg,
&flag_spec.arg_type,
)
.map_err(|e| {
Error::ArgumentParsing(flag_arg.to_string(), e.to_string())
})?;
self.parsed_flags
.insert(flag_name, Argument::Basic(parsed_arg));
}
ArgumentKind::List(argument_kinds) => {
let mut list_args: Vec<BasicArgument> = Vec::new();
for (i, argument_kind) in argument_kinds.iter().enumerate() {
let arg = args_iter
.next()
.ok_or(Error::MissingCommandArgument(i as u32))?;
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(argument_kind.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
}
self.parsed_flags
.insert(flag_name, Argument::List(list_args));
}
ArgumentKind::Enumeration(argument_kind) => {
let mut list_args: Vec<BasicArgument> = Vec::new();
for arg in args_iter.by_ref() {
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(argument_kind.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
}
self.parsed_flags
.insert(flag_name, Argument::List(list_args));
}
ArgumentKind::Flag => {
self.parsed_flags.insert(flag_name, Argument::Flag);
}
},
None => return Err(Error::UnknownFlag(flag_name.to_string())),
}
}
ArgKind::Argument => {
if let Some(arg_defs) = &self.arg_defs {
match arg_defs {
ArgumentKind::Basic(_) => match self.parsed_args {
Some(_) => {
return Err(Error::TooManyArguments);
}
None => {
let argument =
parse_string_argument(arg, arg_defs).map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
self.parsed_args = Some(Argument::Basic(argument));
}
},
ArgumentKind::List(argument_kinds) => {
let mut list_args: Vec<BasicArgument> = Vec::new();
let mut arg_kinds = argument_kinds.iter().enumerate();
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(arg_kinds.next().unwrap().1.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
for (i, argument_kind) in arg_kinds {
let arg = args_iter
.next()
.ok_or(Error::MissingCommandArgument(i as u32))?;
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(argument_kind.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
}
self.parsed_args = Some(Argument::List(list_args));
}
ArgumentKind::Enumeration(argument_kind) => {
let mut list_args: Vec<BasicArgument> = Vec::new();
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(argument_kind.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
for arg in args_iter.by_ref() {
let argument = parse_string_argument(
arg,
&ArgumentKind::Basic(argument_kind.clone()),
)
.map_err(|e| {
Error::ArgumentParsing(arg.to_string(), e.to_string())
})?;
list_args.push(argument);
}
self.parsed_args = Some(Argument::List(list_args));
}
ArgumentKind::Flag => {
panic!(
"A flag argument should not be present in the argument list"
);
}
}
}
// TODO : If we didn't expect any arguments, what sanction should we give?
// Like `pwd` just ignores it so?
}
}
}
Ok(Command {
command: *self.command,
flags: self.parsed_flags,
args: self.parsed_args,
})
}
}
enum ArgKind {
ShorthandFlag,
LonghandFlag,
Argument,
}
fn arg_kind(arg: &str) -> ArgKind {
if arg.starts_with("--") {
ArgKind::LonghandFlag
} else if arg.starts_with('-') && arg.len() > 1 {
ArgKind::ShorthandFlag
} else {
ArgKind::Argument
}
}
#[derive(Debug, thiserror::Error)]
pub enum Error {
#[error("Unknown command: {0}")]
UnknownCommand(String),
#[error("Unknown flag: {0}")]
UnknownFlag(String),
#[error("Invalid flag argument: {0} - {1}")]
InvalidFlagArgument(String, String),
#[error("Internal error: {0}")]
Internal(String),
#[error("Argument parsing error: {0} - {1}")]
ArgumentParsing(String, String),
#[error("Missing command argument: {0}")]
MissingCommandArgument(u32),
#[error("Too many arguments")]
TooManyArguments,
}