sharedstate 2.0.2

Sync heavily read state across many servers
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
use std::{
    collections::BTreeMap,
    future::pending,
    io,
    sync::{
        atomic::{AtomicUsize, Ordering},
        Arc,
    },
    time::{Duration, Instant},
};

use message_encoding::MessageEncoding;
use sharedstate::{
    protocol::{
        framing::{
            read_message_opt, read_message_to_vec, send_message, MessageSizeHeader, ReadMessageError, ReadMessageResult,
        },
        messages::{SyncRequest, SyncResponse, PROTOCOL_VERSION},
    },
    state::{
        deterministic_state::DeterministicState,
        recoverable_state::{RecoverableState, RecoverableStateAction},
    },
    transport::{
        channels::NetIoSettings,
        traits::{SyncConnection, SyncIO, SyncIOListener},
    },
    SharedState, SharedStateConfig, SharedStateSettings,
};
use tokio::{
    io::{duplex, split, AsyncWriteExt, DuplexStream, ReadHalf, WriteHalf},
    net::{
        tcp::{OwnedReadHalf, OwnedWriteHalf},
        TcpListener, TcpStream,
    },
};

const PROCESS_TIMEOUT: Duration = Duration::from_millis(75);
const MESSAGE_TIMEOUT: Duration = Duration::from_millis(150);
const ASSERT_TIMEOUT: Duration = Duration::from_secs(3);

type TcpSyncRequest = SyncRequest<u16, TestState>;
type TcpSyncResponse = SyncResponse<u16, TestState>;

#[derive(Clone)]
struct LocalhostTcpIo {
    address: u16,
    listener: Arc<TcpListener>,
}

impl LocalhostTcpIo {
    async fn bind_ephemeral() -> io::Result<Self> {
        let listener = TcpListener::bind(("127.0.0.1", 0)).await?;
        let address = listener.local_addr()?.port();
        Ok(Self {
            address,
            listener: Arc::new(listener),
        })
    }
}

impl SyncIO for LocalhostTcpIo {
    type Address = u16;
    type Read = OwnedReadHalf;
    type Write = OwnedWriteHalf;

    async fn connect(&self, remote: &Self::Address) -> io::Result<SyncConnection<Self>> {
        let stream = TcpStream::connect(("127.0.0.1", *remote)).await?;
        let (read, write) = stream.into_split();
        Ok(SyncConnection {
            remote: *remote,
            read,
            write,
        })
    }
}

impl SyncIOListener for LocalhostTcpIo {
    async fn next_client(&self) -> io::Result<SyncConnection<Self>> {
        let (stream, peer) = self.listener.accept().await?;
        let (read, write) = stream.into_split();
        Ok(SyncConnection {
            remote: peer.port(),
            read,
            write,
        })
    }
}

#[derive(Clone, Debug, Default)]
struct TestState {
    seq: u64,
    values: BTreeMap<String, String>,
}

impl DeterministicState for TestState {
    type Action = (String, String);
    type AuthorityAction = (String, String);

    fn accept_seq(&self) -> u64 {
        self.seq
    }

    fn authority(&self, action: Self::Action) -> Self::AuthorityAction {
        action
    }

    fn update(&mut self, (key, value): &Self::AuthorityAction) {
        self.values.insert(key.clone(), value.clone());
        self.seq += 1;
    }
}

impl MessageEncoding for TestState {
    fn write_to<T: io::Write>(&self, out: &mut T) -> io::Result<usize> {
        let mut sum = self.seq.write_to(out)?;
        sum += (self.values.len() as u64).write_to(out)?;
        for (key, value) in &self.values {
            sum += key.write_to(out)?;
            sum += value.write_to(out)?;
        }
        Ok(sum)
    }

    fn read_from<T: io::Read>(read: &mut T) -> io::Result<Self> {
        let seq = MessageEncoding::read_from(read)?;
        let len = u64::read_from(read)? as usize;
        let mut values = BTreeMap::new();
        for _ in 0..len {
            values.insert(MessageEncoding::read_from(read)?, MessageEncoding::read_from(read)?);
        }
        Ok(Self { seq, values })
    }
}

fn test_settings() -> SharedStateSettings {
    SharedStateSettings {
        net: NetIoSettings {
            process_timeout: PROCESS_TIMEOUT,
            message_timeout: MESSAGE_TIMEOUT,
        },
        sync_timing: sharedstate::cluster::state_sync::StateSyncTiming {
            retry_delay: Duration::from_millis(50),
            ..Default::default()
        },
        ..SharedStateSettings::default()
    }
}

async fn start_tcp_leader() -> (SharedState<LocalhostTcpIo, TestState>, u16) {
    let io = LocalhostTcpIo::bind_ephemeral().await.unwrap();
    let address = io.address;
    let node = SharedState::start(SharedStateConfig {
        io: Arc::new(io),
        my_address: address,
        leader_address: address,
        available_peers: vec![address],
        initial_state: RecoverableState::new(address as u64, TestState::default()),
        settings: test_settings(),
    })
    .unwrap();

    wait_until(|| node.is_leader(), "node never became leader").await;
    (node, address)
}

async fn read_handshake_rejection(stream: &mut TcpStream) -> Option<TcpSyncResponse> {
    let mut buffer = Vec::new();
    match read_message_opt::<TcpSyncResponse, _>(&mut buffer, stream, PROCESS_TIMEOUT, Some(ASSERT_TIMEOUT)).await {
        Ok(ReadMessageResult::Message(response)) => Some(response),
        Ok(ReadMessageResult::Close) => None,
        Ok(ReadMessageResult::KeepAlive) => panic!("server sent keepalive instead of rejecting handshake"),
        Err(error) if error.is_disconnect() => None,
        Err(error) => panic!("handshake rejection did not close cleanly: {error:?}"),
    }
}

async fn assert_rejected(response: Option<TcpSyncResponse>) {
    if let Some(response) = response {
        assert!(
            matches!(response, SyncResponse::NotConnected),
            "expected NotConnected or clean close, got {}",
            response.name(),
        );
    }
}

async fn read_response(stream: &mut TcpStream) -> TcpSyncResponse {
    let mut buffer = Vec::new();
    match read_message_opt::<TcpSyncResponse, _>(&mut buffer, stream, PROCESS_TIMEOUT, Some(ASSERT_TIMEOUT))
        .await
        .unwrap()
    {
        ReadMessageResult::Message(response) => response,
        ReadMessageResult::Close => panic!("server closed before response"),
        ReadMessageResult::KeepAlive => panic!("server sent keepalive instead of response"),
    }
}

async fn request_rpc(address: u16, request: TcpSyncRequest) -> TcpSyncResponse {
    let mut stream = TcpStream::connect(("127.0.0.1", address)).await.unwrap();
    let mut buffer = Vec::new();

    send_message(&mut buffer, &TcpSyncRequest::ProtocolVersion(PROTOCOL_VERSION), &mut stream, PROCESS_TIMEOUT)
        .await
        .unwrap();
    assert!(matches!(read_response(&mut stream).await, SyncResponse::Ok));

    send_message(&mut buffer, &request, &mut stream, PROCESS_TIMEOUT)
        .await
        .unwrap();
    read_response(&mut stream).await
}

#[tokio::test(flavor = "multi_thread")]
async fn handshake_rejects_wrong_protocol_version() {
    let (_node, address) = start_tcp_leader().await;
    let mut stream = TcpStream::connect(("127.0.0.1", address)).await.unwrap();
    let mut buffer = Vec::new();

    send_message(&mut buffer, &TcpSyncRequest::ProtocolVersion(PROTOCOL_VERSION + 1), &mut stream, PROCESS_TIMEOUT)
        .await
        .unwrap();

    assert_rejected(read_handshake_rejection(&mut stream).await).await;
}

#[tokio::test(flavor = "multi_thread")]
async fn ping_rpc_returns_pong_after_handshake() {
    let (_node, address) = start_tcp_leader().await;
    let mut stream = TcpStream::connect(("127.0.0.1", address)).await.unwrap();
    let mut buffer = Vec::new();

    send_message(&mut buffer, &TcpSyncRequest::ProtocolVersion(PROTOCOL_VERSION), &mut stream, PROCESS_TIMEOUT)
        .await
        .unwrap();
    assert!(matches!(read_response(&mut stream).await, SyncResponse::Ok));

    send_message(&mut buffer, &TcpSyncRequest::Ping(42), &mut stream, PROCESS_TIMEOUT)
        .await
        .unwrap();
    assert!(matches!(read_response(&mut stream).await, SyncResponse::Pong(42)));
}

#[tokio::test(flavor = "multi_thread")]
async fn status_leader_and_recovery_details_rpcs_return_current_values() {
    let (node, address) = start_tcp_leader().await;

    match request_rpc(address, TcpSyncRequest::GetNodeStatus).await {
        SyncResponse::NodeStatus(status) => {
            assert_eq!(status.my_address, address);
            assert_eq!(status.leader_address, address);
            assert_eq!(status.available_peers, vec![address]);
            assert!(status.is_leader());
        }
        response => panic!("expected node status, got {}", response.name()),
    }

    assert!(matches!(
        request_rpc(address, TcpSyncRequest::GetCurrentLeader).await,
        SyncResponse::CurrentLeader(current) if current == address
    ));

    let details = match request_rpc(address, TcpSyncRequest::GetCurrentStateRecoverDetails).await {
        SyncResponse::CurrentStateRecoverDetails(details) => details,
        response => panic!("expected recovery details, got {}", response.name()),
    };
    let mut handle = node.state_handle();
    assert_eq!(details, handle.recover_details());
}

#[tokio::test(flavor = "multi_thread")]
async fn set_leader_and_available_peers_rpcs_update_node_watches() {
    let (node, address) = start_tcp_leader().await;
    let next_leader = address.wrapping_add(1);
    let next_peers = vec![address, next_leader];

    assert!(matches!(
        request_rpc(address, TcpSyncRequest::SetAvailablePeers(next_peers.clone())).await,
        SyncResponse::Ok
    ));
    assert_eq!(node.debug_info().available_peers, next_peers);

    assert!(matches!(request_rpc(address, TcpSyncRequest::SetLeader(next_leader)).await, SyncResponse::Ok));
    assert_eq!(node.leader_address(), next_leader);
    assert!(matches!(
        request_rpc(address, TcpSyncRequest::GetCurrentLeader).await,
        SyncResponse::CurrentLeader(current) if current == next_leader
    ));
}

#[tokio::test(flavor = "multi_thread")]
async fn handshake_rejects_missing_protocol_message() {
    let (_node, address) = start_tcp_leader().await;
    let mut stream = TcpStream::connect(("127.0.0.1", address)).await.unwrap();

    assert_rejected(read_handshake_rejection(&mut stream).await).await;
}

#[tokio::test(flavor = "multi_thread")]
async fn handshake_rejects_unexpected_initial_request() {
    let (_node, address) = start_tcp_leader().await;
    let mut stream = TcpStream::connect(("127.0.0.1", address)).await.unwrap();
    let mut buffer = Vec::new();

    send_message(
        &mut buffer,
        &TcpSyncRequest::Action(("before-handshake".to_owned(), "bad".to_owned())),
        &mut stream,
        PROCESS_TIMEOUT,
    )
    .await
    .unwrap();

    assert_rejected(read_handshake_rejection(&mut stream).await).await;
}

#[derive(Clone)]
struct OutOfSequenceLeaderIo {
    follower: u64,
    leader: u64,
    connects: Arc<AtomicUsize>,
}

impl SyncIO for OutOfSequenceLeaderIo {
    type Address = u64;
    type Read = ReadHalf<DuplexStream>;
    type Write = WriteHalf<DuplexStream>;

    async fn connect(&self, remote: &Self::Address) -> io::Result<SyncConnection<Self>> {
        assert_eq!(*remote, self.leader);
        self.connects.fetch_add(1, Ordering::SeqCst);

        let (client, server) = duplex(64 * 1024);
        let (client_read, client_write) = split(client);
        let (server_read, server_write) = split(server);
        let settings = NetIoSettings {
            process_timeout: PROCESS_TIMEOUT,
            message_timeout: MESSAGE_TIMEOUT,
        };

        tokio::spawn(serve_out_of_sequence_subscription(self.follower, server_read, server_write, settings));

        Ok(SyncConnection {
            remote: *remote,
            read: client_read,
            write: client_write,
        })
    }
}

impl SyncIOListener for OutOfSequenceLeaderIo {
    async fn next_client(&self) -> io::Result<SyncConnection<Self>> {
        pending().await
    }
}

async fn serve_out_of_sequence_subscription(
    remote: u64,
    read: ReadHalf<DuplexStream>,
    write: WriteHalf<DuplexStream>,
    settings: NetIoSettings,
) {
    let connection = SyncConnection::<OutOfSequenceLeaderIo> { remote, read, write };
    let (_remote, responses, mut requests) = connection.server_channels::<TestState>(settings);

    let Some(SyncRequest::ProtocolVersion(PROTOCOL_VERSION)) = requests.recv().await else {
        return;
    };
    if responses.send(SyncResponse::Ok).await.is_err() {
        return;
    }

    let Some(SyncRequest::Subscribe(_details)) = requests.recv().await else {
        return;
    };
    if responses.send(SyncResponse::Ok).await.is_err() {
        return;
    }

    let _ = responses
        .send(SyncResponse::Action {
            seq: 999,
            action: RecoverableStateAction::StateAction {
                action: ("out-of-sequence".to_owned(), "must-not-apply".to_owned()),
            },
        })
        .await;
}

#[tokio::test(flavor = "multi_thread")]
async fn follower_retries_and_does_not_apply_out_of_sequence_leader_stream() {
    let connects = Arc::new(AtomicUsize::new(0));
    let io = Arc::new(OutOfSequenceLeaderIo {
        follower: 10,
        leader: 20,
        connects: connects.clone(),
    });
    let follower = SharedState::start(SharedStateConfig {
        io,
        my_address: 10,
        leader_address: 20,
        available_peers: vec![20],
        initial_state: RecoverableState::new(10, TestState::default()),
        settings: test_settings(),
    })
    .unwrap();

    wait_until(|| connects.load(Ordering::SeqCst) >= 2, "follower did not retry after out-of-sequence stream").await;

    let mut handle = follower.state_handle();
    assert!(
        !handle.read_with(|state| state.state().values.contains_key("out-of-sequence")),
        "follower applied an action from an out-of-sequence leader stream",
    );
}

#[tokio::test]
async fn framing_rejects_partial_header_with_timeout() {
    let (mut writer, mut reader) = duplex(64);
    writer.write_all(&[0, 0]).await.unwrap();

    let mut buffer = Vec::new();
    let error = read_message_to_vec(&mut buffer, &mut reader, PROCESS_TIMEOUT, Some(Duration::from_millis(25)))
        .await
        .unwrap_err();

    assert!(matches!(error, ReadMessageError::NextMessageTimeout(_)));
}

#[tokio::test]
async fn framing_rejects_partial_payload_with_timeout() {
    let (mut writer, mut reader) = duplex(64);
    writer.write_all(&(8 as MessageSizeHeader).to_be_bytes()).await.unwrap();
    writer.write_all(&[1, 2]).await.unwrap();

    let mut buffer = Vec::new();
    let error = read_message_to_vec(&mut buffer, &mut reader, Duration::from_millis(25), Some(PROCESS_TIMEOUT))
        .await
        .unwrap_err();

    assert!(matches!(error, ReadMessageError::MessageReadTimeout));
}

#[tokio::test]
async fn framing_rejects_invalid_encoded_body() {
    let (mut writer, mut reader) = duplex(64);
    writer.write_all(&(2 as MessageSizeHeader).to_be_bytes()).await.unwrap();
    writer.write_all(&999u16.to_be_bytes()).await.unwrap();

    let mut buffer = Vec::new();
    let error = read_message_opt::<TcpSyncRequest, _>(&mut buffer, &mut reader, PROCESS_TIMEOUT, Some(PROCESS_TIMEOUT))
        .await
        .unwrap_err();

    assert!(matches!(error, ReadMessageError::EncodingError(_)));
}

#[tokio::test]
async fn framing_large_declared_length_times_out_without_accepting_message() {
    let (mut writer, mut reader) = duplex(64);
    writer.write_all(&(1024 * 1024_u32).to_be_bytes()).await.unwrap();

    let mut buffer = Vec::new();
    let error = read_message_to_vec(&mut buffer, &mut reader, Duration::from_millis(25), Some(PROCESS_TIMEOUT))
        .await
        .unwrap_err();

    assert!(matches!(error, ReadMessageError::MessageReadTimeout));
    assert_eq!(buffer.len(), 1024 * 1024);
}

async fn wait_until(mut condition: impl FnMut() -> bool, failure: &'static str) {
    let deadline = Instant::now() + ASSERT_TIMEOUT;
    loop {
        if condition() {
            return;
        }
        assert!(Instant::now() < deadline, "{failure}");
        tokio::time::sleep(Duration::from_millis(20)).await;
    }
}