1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
//! Pattern checking - verifying if values match patterns
use crate::bytecode::{Constant, Instruction, OpCode, Operand};
use crate::executor::typed_object_ops::field_type_to_tag;
use crate::type_tracking::VariableTypeInfo;
use shape_ast::ast::{Literal, Pattern, PatternConstructorFields};
use shape_ast::error::{Result, ShapeError};
use crate::compiler::BytecodeCompiler;
use super::helpers::typed_eq_opcode_for_literal;
// Reserved schema fields for TypedObject enum layout
// __variant at offset 0, __payload_N at offsets 8, 16, etc.
impl BytecodeCompiler {
fn resolve_typed_field_operand_checking(
&self,
schema_id: u32,
field_name: &str,
) -> Option<Operand> {
if schema_id > u16::MAX as u32 {
return None;
}
self.type_tracker
.schema_registry()
.get_by_id(schema_id)
.and_then(|schema| {
schema
.get_field(field_name)
.map(|field| Operand::TypedField {
type_id: schema_id as u16,
field_idx: field.index as u16,
field_type_tag: field_type_to_tag(&field.field_type),
})
})
}
pub(in crate::compiler) fn compile_pattern_check(
&mut self,
pattern: &Pattern,
hint_span: Option<shape_ast::ast::Span>,
) -> Result<()> {
self.push_scope();
let value_local = self.declare_temp_local("__pattern_value_")?;
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(value_local)),
));
if let Some(schema_id) = self.last_expr_schema {
self.type_tracker.set_local_type(
value_local,
VariableTypeInfo::known(schema_id, format!("__typed_obj_{}", schema_id)),
);
}
let mut fail_jumps = Vec::new();
self.compile_pattern_check_local(pattern, value_local, &mut fail_jumps, hint_span)?;
self.emit_bool(true);
let end_jump = self.emit_jump(OpCode::Jump, 0);
for jump in fail_jumps {
self.patch_jump(jump);
}
self.emit_bool(false);
self.patch_jump(end_jump);
self.pop_scope();
Ok(())
}
pub(in crate::compiler) fn compile_pattern_check_local(
&mut self,
pattern: &Pattern,
value_local: u16,
fail_jumps: &mut Vec<usize>,
hint_span: Option<shape_ast::ast::Span>,
) -> Result<()> {
match pattern {
Pattern::Wildcard | Pattern::Identifier(_) => Ok(()),
Pattern::Typed {
type_annotation, ..
} => {
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
let type_const = self
.program
.add_constant(Constant::TypeAnnotation(type_annotation.clone()));
self.emit(Instruction::new(
OpCode::TypeCheck,
Some(Operand::Const(type_const)),
));
let jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(jump);
Ok(())
}
Pattern::Literal(lit) => {
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
// Bool patterns desugar to a direct conditional jump — no
// equality opcode at all. The loaded scrutinee is itself
// the bool we want to test.
if let Literal::Bool(b) = lit {
let jump_op = if *b {
OpCode::JumpIfFalse
} else {
OpCode::JumpIfTrue
};
let jump = self.emit_jump(jump_op, 0);
fail_jumps.push(jump);
return Ok(());
}
self.compile_literal(lit)?;
let eq_op = typed_eq_opcode_for_literal(lit).ok_or_else(|| {
ShapeError::SemanticError {
message: format!(
"Pattern matching on {} literals is not yet supported",
lit
),
location: None,
}
})?;
self.emit(Instruction::simple(eq_op));
let jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(jump);
Ok(())
}
Pattern::Array(patterns) => {
self.emit_pattern_type_check(value_local, "array", fail_jumps)?;
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
self.emit(Instruction::simple(OpCode::Length));
// Stage 2.6.4: Length pushes int (op_length emits ValueWord::from_i64),
// so use Constant::Int + EqInt for the typed comparison.
let expected_len = self
.program
.add_constant(Constant::Int(patterns.len() as i64));
self.emit(Instruction::new(
OpCode::PushConst,
Some(Operand::Const(expected_len)),
));
self.emit(Instruction::simple(OpCode::EqInt));
let jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(jump);
for (idx, pat) in patterns.iter().enumerate() {
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
let idx_const = self.program.add_constant(Constant::Int(idx as i64));
self.emit(Instruction::new(
OpCode::PushConst,
Some(Operand::Const(idx_const)),
));
self.emit(Instruction::simple(OpCode::GetProp));
let elem_local = self.declare_temp_local("__pattern_elem_")?;
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(elem_local)),
));
self.compile_pattern_check_local(pat, elem_local, fail_jumps, hint_span)?;
}
Ok(())
}
Pattern::Object(fields) => {
self.emit_pattern_type_check(value_local, "object", fail_jumps)?;
let schema_id = self
.type_tracker
.get_local_type(value_local)
.and_then(|info| info.schema_id)
.ok_or_else(|| ShapeError::SemanticError {
message: "Object pattern checking requires compile-time known schema. Runtime property lookup is disabled.".to_string(),
location: hint_span.map(|s| self.span_to_source_location(s)),
})?;
for (key, pat) in fields {
let field_local = self.declare_temp_local("__pattern_field_")?;
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
let operand = self
.resolve_typed_field_operand_checking(schema_id, key)
.ok_or_else(|| ShapeError::SemanticError {
message: format!(
"Field '{}' is not declared in object schema for pattern checking.",
key
),
location: hint_span.map(|s| self.span_to_source_location(s)),
})?;
self.emit(Instruction::new(OpCode::GetFieldTyped, Some(operand)));
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(field_local)),
));
self.compile_pattern_check_local(pat, field_local, fail_jumps, hint_span)?;
}
Ok(())
}
Pattern::Constructor {
enum_name,
variant,
fields,
} => {
match (enum_name.as_deref(), variant.as_str()) {
(Some("Option"), "None") | (None, "None") => {
if !matches!(fields, PatternConstructorFields::Unit) {
fail_jumps.push(self.emit_jump(OpCode::Jump, 0));
return Ok(());
}
// Stage 2.6.5.2: typed IsNull replaces `PushNull; Eq`.
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
self.emit(Instruction::simple(OpCode::IsNull));
let jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(jump);
Ok(())
}
(Some("Option"), "Some") | (None, "Some") => {
let field_pats = match fields {
PatternConstructorFields::Tuple(pats) if pats.len() == 1 => pats,
_ => {
fail_jumps.push(self.emit_jump(OpCode::Jump, 0));
return Ok(());
}
};
// Stage 2.6.5.2: typed IsNull replaces `PushNull; Eq`.
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
self.emit(Instruction::simple(OpCode::IsNull));
let jump = self.emit_jump(OpCode::JumpIfTrue, 0);
fail_jumps.push(jump);
self.compile_pattern_check_local(
&field_pats[0],
value_local,
fail_jumps,
hint_span,
)
}
(Some("Result"), "Ok")
| (None, "Ok")
| (Some("Result"), "Err")
| (None, "Err") => {
let field_pats = match fields {
PatternConstructorFields::Tuple(pats) if pats.len() == 1 => pats,
_ => {
fail_jumps.push(self.emit_jump(OpCode::Jump, 0));
return Ok(());
}
};
let inner_local = self.declare_temp_local("__pattern_inner_")?;
let is_variant_opcode = if variant == "Ok" {
OpCode::IsOk
} else {
OpCode::IsErr
};
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
self.emit(Instruction::simple(is_variant_opcode));
let fail_jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(fail_jump);
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
self.emit(Instruction::simple(if variant == "Ok" {
OpCode::UnwrapOk
} else {
OpCode::UnwrapErr
}));
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(inner_local)),
));
self.compile_pattern_check_local(
&field_pats[0],
inner_local,
fail_jumps,
hint_span,
)?;
Ok(())
}
(Some(enum_name), _) => {
// Look up enum schema - must be registered
let resolved_name = self.resolve_type_name(enum_name);
let schema = self.type_tracker.schema_registry().get(resolved_name.as_str());
let enum_info = schema.and_then(|s| s.get_enum_info());
let variant_info = enum_info.and_then(|e| e.variant_by_name(variant));
if let (Some(schema), Some(variant_info)) = (schema, variant_info) {
self.compile_typed_enum_pattern_check(
value_local,
schema.id,
variant_info.id,
fields,
fail_jumps,
hint_span,
)
} else if schema.is_none() {
Err(ShapeError::SemanticError {
message: format!(
"Unknown enum type '{}'. Make sure it is imported or defined.",
enum_name
),
location: hint_span.map(|s| self.span_to_source_location(s)),
})
} else {
Err(ShapeError::SemanticError {
message: format!(
"Unknown variant '{}' for enum '{}'",
variant, enum_name
),
location: hint_span.map(|s| self.span_to_source_location(s)),
})
}
}
(None, _) => {
// WS-4 4c: a bare `Constructor` pattern with no
// enum-name (`Point { x, y }`) may name a
// registered struct/TypedObject. Resolve
// `variant`; if it is a non-enum schema with a
// struct payload, route to the `Pattern::Object`
// struct-pattern check. Otherwise fail the arm
// (the genuine bare-enum-variant case).
let resolved_name = self.resolve_type_name(variant);
let is_struct_schema = self
.type_tracker
.schema_registry()
.get(resolved_name.as_str())
.map(|s| !s.is_enum())
.unwrap_or(false);
if is_struct_schema {
if let PatternConstructorFields::Struct(field_pats) = fields {
return self.compile_pattern_check_local(
&Pattern::Object(field_pats.clone()),
value_local,
fail_jumps,
hint_span,
);
}
}
fail_jumps.push(self.emit_jump(OpCode::Jump, 0));
Ok(())
}
}
}
}
}
/// Compile pattern check for TypedObject enum (optimized path)
///
/// Uses GetFieldTyped for direct memory access to __variant field,
/// then numeric comparison with expected variant_id.
fn compile_typed_enum_pattern_check(
&mut self,
value_local: u16,
schema_id: u32,
expected_variant_id: u16,
fields: &PatternConstructorFields,
fail_jumps: &mut Vec<usize>,
hint_span: Option<shape_ast::ast::Span>,
) -> Result<()> {
// Load the value
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
// Get __variant field using GetFieldTyped (I64 type)
self.emit(Instruction::new(
OpCode::GetFieldTyped,
Some(Operand::TypedField {
type_id: schema_id as u16,
field_idx: 0,
field_type_tag: crate::executor::typed_object_ops::FIELD_TAG_I64,
}),
));
// Compare to expected variant_id (stored as i64 in __variant).
// Stage 2.6.4: __variant is always i64, so use EqInt directly.
let expected_const = self
.program
.add_constant(Constant::Int(expected_variant_id as i64));
self.emit(Instruction::new(
OpCode::PushConst,
Some(Operand::Const(expected_const)),
));
self.emit(Instruction::simple(OpCode::EqInt));
let jump = self.emit_jump(OpCode::JumpIfFalse, 0);
fail_jumps.push(jump);
// Handle payload fields
match fields {
PatternConstructorFields::Unit => Ok(()),
PatternConstructorFields::Tuple(patterns) => {
// Payload fields are at __payload_0, __payload_1, etc.
for (idx, pat) in patterns.iter().enumerate() {
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
// GetFieldTyped for __payload_{idx} (Any type)
self.emit(Instruction::new(
OpCode::GetFieldTyped,
Some(Operand::TypedField {
type_id: schema_id as u16,
field_idx: (idx + 1) as u16, // field 0 is __variant
field_type_tag: crate::executor::typed_object_ops::FIELD_TAG_ANY,
}),
));
let elem_local = self.declare_temp_local("__typed_enum_elem_")?;
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(elem_local)),
));
self.compile_pattern_check_local(pat, elem_local, fail_jumps, hint_span)?;
}
Ok(())
}
PatternConstructorFields::Struct(patterns) => {
// For struct payloads, we access fields by index
// The order matches the struct definition order
for (idx, (_key, pat)) in patterns.iter().enumerate() {
self.emit(Instruction::new(
OpCode::LoadLocal,
Some(Operand::Local(value_local)),
));
// GetFieldTyped for __payload_{idx} (Any type)
self.emit(Instruction::new(
OpCode::GetFieldTyped,
Some(Operand::TypedField {
type_id: schema_id as u16,
field_idx: (idx + 1) as u16,
field_type_tag: crate::executor::typed_object_ops::FIELD_TAG_ANY,
}),
));
let field_local = self.declare_temp_local("__typed_enum_field_")?;
self.emit(Instruction::new(
OpCode::StoreLocal,
Some(Operand::Local(field_local)),
));
self.compile_pattern_check_local(pat, field_local, fail_jumps, hint_span)?;
}
Ok(())
}
}
}
}