seshat_cli/tui/

app.rs

use std::hash::{DefaultHasher, Hash, Hasher};
use std::sync::{Arc, Mutex};

use rusqlite::params;
use seshat_core::{BranchId, NodeId};
use seshat_graph::{SQL_NOT_REMOVED, compute_description_hash, lock_conn};
use seshat_storage::{
    Decision, DecisionNature, DecisionRepository, DecisionState, DecisionWeight, ExampleEvidence,
    SqliteDecisionRepository,
};

use crate::error::CliError;

#[derive(Debug, Clone)]
pub struct ConventionItem {
    pub node_id: i64,
    pub description: String,
    pub nature: String,
    pub weight: String,
    pub confidence_pct: u32,
    pub adoption_count: u32,
    pub total_count: u32,
    pub adoption_rate_pct: u32,
    pub trend: String,
    pub source: String,
    pub examples: Vec<CodeExample>,
    /// SHA256-style snapshot hash of ext_data at query time.
    /// Used for optimistic concurrency check on reject.
    pub snapshot_hash: u64,
    /// Index into `examples` vector for left/right cycling.
    pub example_index: usize,
    /// SHA256 hash of normalized description for deduplication.
    pub description_hash: Option<String>,
}

#[derive(Debug, Clone)]
pub struct CodeExample {
    pub file: String,
    pub line: u32,
    pub end_line: u32,
    pub snippet: String,
    pub snippet_start_line: u32,
}

#[derive(Debug, Clone)]
pub enum ReviewAction {
    Confirm {
        node_id: i64,
        description: String,
        examples: Vec<CodeExample>,
    },
    Reject {
        node_id: i64,
        snapshot_hash: u64,
    },
    Partial {
        node_id: i64,
        description: String,
        original_node_id: i64,
    },
    Skip {
        node_id: i64,
    },
}

pub struct App {
    pub conventions: Vec<ConventionItem>,
    pub current_index: usize,
    pub results: Vec<ReviewAction>,
    pub quit: bool,
    pub saving: bool,
    pub review_complete: bool,
    /// Tracks which convention indices have already been acted on (y/n/p/s).
    acted_on: Vec<bool>,
    pub search_mode: bool,
    pub search_query: String,
    pub filter_locked: bool,
    pub filtered_indices: Vec<usize>,
}

impl App {
    pub fn new(conventions: Vec<ConventionItem>) -> Self {
        let len = conventions.len();
        let filtered: Vec<usize> = (0..len).collect();
        Self {
            conventions,
            current_index: 0,
            results: Vec::new(),
            quit: false,
            saving: false,
            review_complete: false,
            acted_on: vec![false; len],
            search_mode: false,
            search_query: String::new(),
            filter_locked: false,
            filtered_indices: filtered,
        }
    }

    pub fn filtered_current_index(&self) -> usize {
        self.filtered_indices
            .iter()
            .position(|&i| i == self.current_index)
            .unwrap_or(0)
    }

    pub fn filtered_total(&self) -> usize {
        self.filtered_indices.len()
    }

    pub fn filtered_current(&self) -> Option<&ConventionItem> {
        self.current()
    }

    pub fn filtered_next(&mut self) {
        if let Some(pos) = self
            .filtered_indices
            .iter()
            .position(|&i| i == self.current_index)
        {
            if pos + 1 < self.filtered_indices.len() {
                self.current_index = self.filtered_indices[pos + 1];
            }
        }
    }

    pub fn filtered_previous(&mut self) {
        if let Some(pos) = self
            .filtered_indices
            .iter()
            .position(|&i| i == self.current_index)
        {
            if pos > 0 {
                self.current_index = self.filtered_indices[pos - 1];
            }
        }
    }

    fn rebuild_filtered_indices(&mut self) {
        let query = self.search_query.to_lowercase();
        let previous = self.current_index;
        self.filtered_indices = (0..self.conventions.len())
            .filter(|&i| {
                self.conventions
                    .get(i)
                    .map(|c| c.description.to_lowercase())
                    .map(|desc| fuzzy_match(&query, &desc))
                    .unwrap_or(false)
            })
            .collect();

        if self.filtered_indices.contains(&previous) {
            return;
        }
        if let Some(first_match) = self.filtered_indices.first().copied() {
            self.current_index = first_match;
        }
    }

    pub fn push_search_char(&mut self, ch: char) {
        self.search_query.push(ch);
        self.rebuild_filtered_indices();
    }

    pub fn pop_search_char(&mut self) {
        self.search_query.pop();
        if self.search_query.is_empty() {
            self.cancel_search();
        } else {
            self.rebuild_filtered_indices();
        }
    }

    pub fn lock_filter(&mut self) {
        if self.filtered_indices.is_empty() {
            return;
        }
        self.filter_locked = true;
        self.search_mode = false;
    }

    pub fn cancel_search(&mut self) {
        self.search_query.clear();
        self.search_mode = false;
        self.filter_locked = false;
        self.filtered_indices = (0..self.conventions.len()).collect();
        if !self.filtered_indices.is_empty() {
            self.current_index = self.filtered_indices[0];
        }
    }

    pub fn mark_acted_on(&mut self, index: usize) {
        if index < self.acted_on.len() {
            self.acted_on[index] = true;
        }
    }

    pub fn is_acted_on(&self, index: usize) -> bool {
        self.acted_on.get(index).copied().unwrap_or(true)
    }

    pub fn all_acted_on(&self) -> bool {
        self.acted_on.iter().all(|&b| b)
    }

    /// Advance to the next un-reviewed convention.
    /// Searches forward from current position, then wraps to the start.
    /// If all conventions have been reviewed, sets `quit = true`.
    pub fn advance_to_next_unreviewed(&mut self) {
        let total = self.conventions.len();
        if total == 0 {
            self.quit = true;
            return;
        }

        for offset in 1..=total {
            let idx = (self.current_index + offset) % total;
            if !self.acted_on[idx] {
                self.current_index = idx;
                if let Some(conv) = self.conventions.get_mut(self.current_index) {
                    conv.example_index = 0;
                }
                self.review_complete = false;
                return;
            }
        }

        self.quit = true;
    }

    pub fn current(&self) -> Option<&ConventionItem> {
        self.conventions.get(self.current_index)
    }

    pub fn example_total(&self) -> usize {
        self.current().map(|c| c.examples.len()).unwrap_or(0)
    }

    pub fn next_example(&mut self) {
        let total = self.example_total();
        if total <= 1 {
            return;
        }
        if let Some(c) = self.current() {
            let idx = c.example_index;
            let new_idx = (idx + 1) % total;
            if let Some(conv) = self.conventions.get_mut(self.current_index) {
                conv.example_index = new_idx;
            }
        }
    }

    pub fn previous_example(&mut self) {
        let total = self.example_total();
        if total <= 1 {
            return;
        }
        if let Some(c) = self.current() {
            let idx = c.example_index;
            let new_idx = if idx == 0 { total - 1 } else { idx - 1 };
            if let Some(conv) = self.conventions.get_mut(self.current_index) {
                conv.example_index = new_idx;
            }
        }
    }

    pub fn next(&mut self) {
        if self.current_index < self.conventions.len().saturating_sub(1) {
            self.current_index += 1;
            if let Some(conv) = self.conventions.get_mut(self.current_index) {
                conv.example_index = 0;
            }
        }
        self.review_complete = self.current_index >= self.conventions.len().saturating_sub(1);
    }

    pub fn previous(&mut self) {
        if self.current_index > 0 {
            self.current_index -= 1;
            if let Some(conv) = self.conventions.get_mut(self.current_index) {
                conv.example_index = 0;
            }
        }
        self.review_complete = self.current_index >= self.conventions.len().saturating_sub(1);
    }

    pub fn total(&self) -> usize {
        self.conventions.len()
    }
}

fn compute_snapshot_hash(ext_data: &Option<String>) -> u64 {
    let mut hasher = DefaultHasher::default();
    ext_data.as_deref().unwrap_or("").hash(&mut hasher);
    hasher.finish()
}

pub fn query_conventions_for_review(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    branch_id: &str,
) -> Result<(Vec<ConventionItem>, String), CliError> {
    let guard = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;

    // Auto-detected conventions live in `nodes`. User decisions live in the
    // project-wide `decisions` table keyed by `description_hash`. A LEFT JOIN
    // (post-US-006) hides any node whose description_hash matches a decision
    // row in ANY state — approved/rejected/partial/recorded all suppress the
    // re-prompt. `d.description_hash IS NULL` is the load-bearing predicate
    // (V12 has no `id` column; PK is `description_hash`).
    let sql = format!(
        "SELECT n.id, n.description, n.nature, n.weight, n.confidence,
                n.adoption_count, n.total_count, n.ext_data, n.description_hash
         FROM nodes n
         LEFT JOIN decisions d ON d.description_hash = n.description_hash
         WHERE n.branch_id = ?1
           AND n.nature IN ('convention', 'observation')
           AND {sql_not_removed}
           AND d.description_hash IS NULL
         ORDER BY n.confidence DESC",
        sql_not_removed = SQL_NOT_REMOVED
    );

    let mut stmt = guard
        .prepare(&sql)
        .map_err(|e| CliError::TuiError(e.to_string()))?;

    let rows = stmt
        .query_map(params![branch_id], |row| {
            let id: i64 = row.get(0)?;
            let description: String = row.get(1)?;
            let nature: String = row.get(2)?;
            let weight: String = row.get(3)?;
            let confidence: f64 = row.get(4)?;
            let adoption_count: u32 = row.get(5)?;
            let total_count: u32 = row.get(6)?;
            let ext_data: Option<String> = row.get(7)?;
            let description_hash: Option<String> = row.get(8)?;
            Ok((
                id,
                description,
                nature,
                weight,
                confidence,
                adoption_count,
                total_count,
                ext_data,
                description_hash,
            ))
        })
        .map_err(|e| CliError::TuiError(e.to_string()))?;

    let mut conventions = Vec::new();

    for row_result in rows {
        let (
            id,
            description,
            nature,
            weight,
            confidence,
            adoption_count,
            total_count,
            ext_data,
            description_hash,
        ) = row_result.map_err(|e| CliError::TuiError(e.to_string()))?;

        let ext: Option<serde_json::Value> = ext_data
            .as_deref()
            .and_then(|s| serde_json::from_str(s).ok());

        let source = ext
            .as_ref()
            .and_then(|e| e.get("source"))
            .and_then(|v| v.as_str())
            .unwrap_or("auto_detected")
            .to_owned();
        let trend = ext
            .as_ref()
            .and_then(|e| e.get("trend"))
            .and_then(|v| v.as_str())
            .unwrap_or("unknown")
            .to_owned();
        let examples = parse_evidence(&ext);

        conventions.push(ConventionItem {
            node_id: id,
            description,
            nature,
            weight,
            confidence_pct: (confidence.clamp(0.0, 1.0) * 100.0).round() as u32,
            adoption_count,
            total_count,
            adoption_rate_pct: if total_count > 0 {
                ((adoption_count as f64 / total_count as f64) * 100.0).round() as u32
            } else {
                0
            },
            trend,
            source: source.clone(),
            examples,
            snapshot_hash: compute_snapshot_hash(&ext_data),
            description_hash,
            example_index: 0,
        });
    }

    Ok((conventions, branch_id.to_string()))
}

/// Count project-wide decisions that count toward "this convention is settled
/// knowledge": approved, partial, and recorded states. Rejections are excluded
/// — they're decisions, but they don't represent confirmed conventions.
/// Project-wide (no branch filter): a decision approved on any branch counts
/// once.
pub fn count_confirmed_conventions(conn: &Arc<Mutex<rusqlite::Connection>>) -> usize {
    let guard = match lock_conn(conn) {
        Ok(g) => g,
        Err(e) => {
            tracing::warn!("failed to lock connection for count_confirmed_conventions: {e}");
            return 0;
        }
    };
    guard
        .query_row(
            "SELECT COUNT(*) FROM decisions \
             WHERE state IN ('approved', 'partial', 'recorded')",
            [],
            |row| row.get::<_, i64>(0),
        )
        .unwrap_or(0) as usize
}

fn parse_evidence(ext: &Option<serde_json::Value>) -> Vec<CodeExample> {
    let evidence = match ext
        .as_ref()
        .and_then(|e| e.get("evidence"))
        .and_then(|v| v.as_array())
    {
        Some(arr) => arr,
        None => return Vec::new(),
    };

    let mut examples = Vec::new();
    for item in evidence {
        let file = item
            .get("file")
            .and_then(|v| v.as_str())
            .unwrap_or("")
            .to_owned();
        let line = item.get("line").and_then(|v| v.as_u64()).unwrap_or(0) as u32;
        let end_line = item
            .get("end_line")
            .and_then(|v| v.as_u64())
            .unwrap_or(line as u64) as u32;
        let snippet = item
            .get("snippet")
            .and_then(|v| {
                v.get("content")
                    .and_then(|c| c.as_str())
                    .or_else(|| v.as_str())
            })
            .unwrap_or("")
            .to_owned();
        let snippet_start_line = item
            .get("snippet_start_line")
            .and_then(|v| v.as_u64())
            .unwrap_or(0) as u32;
        // Empty `file` is a valid composite/synthetic evidence row
        // (e.g. the file-level composite produced by aggregate_findings
        // for "98 files match this convention" summaries). Skip only
        // when both file and snippet are empty — those carry no info.
        if file.is_empty() && snippet.is_empty() {
            continue;
        }
        examples.push(CodeExample {
            file,
            line,
            end_line,
            snippet,
            snippet_start_line,
        });
    }
    examples
}

pub fn apply_review_actions(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    branch_id: &str,
    results: &[ReviewAction],
) -> Result<(), CliError> {
    if results.is_empty() {
        return Ok(());
    }

    {
        let guard = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        guard
            .execute_batch("BEGIN IMMEDIATE")
            .map_err(|e| CliError::TuiError(format!("BEGIN transaction: {e}")))?;
    }

    // P28: each action runs inside its own SAVEPOINT. A single Reject
    // is itself a 3-step pipeline (upsert decision → soft-delete node →
    // delete FTS entry); pre-fix a failure between steps could leave the
    // first step committed at the end of the outer transaction while the
    // remaining steps were silently dropped. Savepointing per-action
    // gives all-or-nothing semantics for each ReviewAction without
    // dragging unrelated successful actions down with a single failure.
    let mut fail_count = 0usize;
    for (idx, action) in results.iter().enumerate() {
        let sp = format!("review_action_{idx}");
        {
            let g = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
            g.execute_batch(&format!("SAVEPOINT {sp}"))
                .map_err(|e| CliError::TuiError(format!("SAVEPOINT {sp}: {e}")))?;
        }
        let result = match action {
            ReviewAction::Confirm {
                description,
                examples,
                ..
            } => confirm_convention(conn, branch_id, description, examples),
            ReviewAction::Reject {
                node_id,
                snapshot_hash,
            } => reject_convention(conn, *node_id, branch_id, *snapshot_hash),
            ReviewAction::Partial { description, .. } => {
                partial_convention(conn, branch_id, description)
            }
            ReviewAction::Skip { .. } => Ok(()),
        };
        let g = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        match result {
            Ok(()) => {
                g.execute_batch(&format!("RELEASE {sp}"))
                    .map_err(|e| CliError::TuiError(format!("RELEASE {sp}: {e}")))?;
            }
            Err(e) => {
                tracing::warn!(node_id = ?action.node_id_if_reject(), "action skipped: {e}");
                // Rollback only this action's partial writes. Other
                // actions that already RELEASEd remain pending in the
                // outer transaction.
                let _ = g.execute_batch(&format!("ROLLBACK TO {sp}"));
                let _ = g.execute_batch(&format!("RELEASE {sp}"));
                fail_count += 1;
            }
        }
    }

    if fail_count > 0 && fail_count == results.len() {
        let g = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        let _ = g.execute_batch("ROLLBACK");
        return Err(CliError::TuiError(
            "all review actions failed; no changes applied. \
             Run `seshat review` again to retry."
                .to_owned(),
        ));
    }

    seshat_graph::rebuild_fts_index(conn).map_err(|e| CliError::TuiError(e.to_string()))?;

    {
        let g = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        g.execute_batch("COMMIT")
            .map_err(|e| CliError::TuiError(format!("COMMIT transaction: {e}")))?;
    }

    if fail_count > 0 {
        tracing::info!(
            fail_count,
            success_count = results.len() - fail_count,
            "some actions skipped, rest committed"
        );
    }

    Ok(())
}

trait ReviewActionDebug {
    fn node_id_if_reject(&self) -> Option<i64>;
}

impl ReviewActionDebug for ReviewAction {
    fn node_id_if_reject(&self) -> Option<i64> {
        match self {
            ReviewAction::Confirm { node_id, .. }
            | ReviewAction::Reject { node_id, .. }
            | ReviewAction::Partial { node_id, .. }
            | ReviewAction::Skip { node_id } => Some(*node_id),
        }
    }
}

fn examples_to_evidence(examples: &[CodeExample]) -> Vec<ExampleEvidence> {
    examples
        .iter()
        .map(|e| ExampleEvidence {
            file: e.file.clone(),
            line: e.line,
            end_line: e.end_line,
            snippet: e.snippet.clone(),
        })
        .collect()
}

fn upsert_decision(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    decision: Decision,
) -> Result<(), CliError> {
    let repo = SqliteDecisionRepository::new(conn.clone());
    repo.upsert(&decision)
        .map_err(|e| CliError::TuiError(e.to_string()))
}

fn confirm_convention(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    branch_id: &str,
    description: &str,
    examples: &[CodeExample],
) -> Result<(), CliError> {
    let now = chrono::Utc::now().timestamp();
    let decision = Decision {
        description_hash: compute_description_hash(description),
        description: description.to_owned(),
        state: DecisionState::Approved,
        nature: DecisionNature::Convention,
        weight: DecisionWeight::Strong,
        category: None,
        reason: Some("Confirmed via seshat review TUI".to_owned()),
        examples: examples_to_evidence(examples),
        decided_on_branch: BranchId(branch_id.to_owned()),
        decided_at: now,
        updated_at: now,
    };
    upsert_decision(conn, decision)
}

fn reject_convention(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    node_id: i64,
    branch_id: &str,
    expected_hash: u64,
) -> Result<(), CliError> {
    // Read description + ext_data of the auto-detected node we're rejecting.
    // The optimistic concurrency check operates on the ext_data snapshot;
    // the user-decided row is keyed by description_hash so collisions on
    // the decisions side are not possible.
    let (description, ext_data): (String, Option<String>) = {
        let guard = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        guard
            .query_row(
                "SELECT description, ext_data FROM nodes WHERE id = ?1",
                params![node_id],
                |row| Ok((row.get(0)?, row.get(1)?)),
            )
            .map_err(|e| CliError::TuiError(e.to_string()))?
    };

    let current_hash = compute_snapshot_hash(&ext_data);
    if current_hash != expected_hash {
        return Err(CliError::TuiError(format!(
            "convention {node_id} was modified during review; please retry"
        )));
    }

    let now = chrono::Utc::now().timestamp();
    let decision = Decision {
        description_hash: compute_description_hash(&description),
        description: description.clone(),
        state: DecisionState::Rejected,
        nature: DecisionNature::Convention,
        weight: DecisionWeight::Strong,
        category: None,
        reason: Some("Rejected via seshat review TUI".to_owned()),
        examples: Vec::new(),
        decided_on_branch: BranchId(branch_id.to_owned()),
        decided_at: now,
        updated_at: now,
    };
    upsert_decision(conn, decision)?;

    // Cosmetic: soft-delete the auto-detected node so it disappears from
    // review queues and FTS until the next scan hard-deletes it. Persisting
    // the rejection lives in `decisions`, so this is purely for cleaner
    // snapshot output between scans.
    let mut ext: serde_json::Value = ext_data
        .as_deref()
        .and_then(|s| serde_json::from_str(s).ok())
        .unwrap_or(serde_json::json!({}));
    ext["removed"] = serde_json::json!(1);
    ext["removed_reason"] = serde_json::json!("Rejected via seshat review TUI");
    ext["removed_at"] = serde_json::json!(now);

    {
        let guard = lock_conn(conn).map_err(|e| CliError::TuiError(e.to_string()))?;
        guard
            .execute(
                "UPDATE nodes SET ext_data = ?1 WHERE id = ?2",
                params![ext.to_string(), node_id],
            )
            .map_err(|e| CliError::TuiError(e.to_string()))?;
    }
    seshat_graph::delete_fts_entry(conn, NodeId(node_id))
        .map_err(|e| CliError::TuiError(e.to_string()))?;

    Ok(())
}

fn partial_convention(
    conn: &Arc<Mutex<rusqlite::Connection>>,
    branch_id: &str,
    description: &str,
) -> Result<(), CliError> {
    let now = chrono::Utc::now().timestamp();
    let decision = Decision {
        description_hash: compute_description_hash(description),
        description: description.to_owned(),
        state: DecisionState::Partial,
        nature: DecisionNature::Preference,
        weight: DecisionWeight::Strong,
        category: None,
        reason: Some("Partially confirmed via seshat review TUI".to_owned()),
        examples: Vec::new(),
        decided_on_branch: BranchId(branch_id.to_owned()),
        decided_at: now,
        updated_at: now,
    };
    upsert_decision(conn, decision)
}

pub struct SummaryContext {
    /// Total conventions in the scope returned by the query (excludes already-confirmed and rejected).
    pub total_in_scope: usize,
    /// Project-wide count of decisions already settled before this session.
    /// Counts all rows in `decisions` with state in (approved, partial, recorded);
    /// not branch-filtered (V12 schema makes decisions project-wide).
    pub already_confirmed: usize,
}

/// Display a rich summary with full session context: totals, per-session counts,
/// session precision, and overall coverage including already-confirmed from DB.
///
/// When the user presses q immediately: all session counts are 0, pending = total_in_scope,
/// precision = 0%, coverage = already_confirmed / (total_in_scope + already_confirmed) * 100.
pub fn show_summary(results: &[ReviewAction], context: &SummaryContext) {
    let confirmed = results
        .iter()
        .filter(|r| matches!(r, ReviewAction::Confirm { .. }))
        .count();
    let rejected = results
        .iter()
        .filter(|r| matches!(r, ReviewAction::Reject { .. }))
        .count();
    let partial = results
        .iter()
        .filter(|r| matches!(r, ReviewAction::Partial { .. }))
        .count();
    let skipped = results
        .iter()
        .filter(|r| matches!(r, ReviewAction::Skip { .. }))
        .count();

    let total_decided = confirmed.saturating_add(rejected).saturating_add(partial);

    let still_pending = context
        .total_in_scope
        .saturating_sub(total_decided)
        .saturating_sub(skipped);

    let precision_denom = total_decided.max(1);
    let session_precision = (confirmed as f64 / precision_denom as f64 * 100.0).round() as u32;

    let total_with_db = context
        .total_in_scope
        .saturating_add(context.already_confirmed);
    let overall_coverage = if total_with_db > 0 {
        let val = (context.already_confirmed.saturating_add(confirmed)) as f64
            / total_with_db as f64
            * 100.0;
        val.round() as u32
    } else {
        0
    };

    println!("\n   -- Review Complete ----------------------------------------------------------");
    println!(
        "   {:<24}  {:>4}",
        "Conventions in scope:", context.total_in_scope
    );
    println!(
        "   {:<24}  {:>4}",
        "Already decided (project):", context.already_confirmed
    );
    println!();
    println!("   {:<24}  {:>4}", "+ Confirmed", confirmed);
    println!("   {:<24}  {:>4}", "- Rejected", rejected);
    println!("   {:<24}  {:>4}", "~ Partial", partial);
    println!("   {:<24}  {:>4}", "x Skipped", skipped);
    println!();
    println!("   {:<24}  {:>4}", "Still pending:", still_pending);
    println!("   {:<24}  {:>3}%", "Session precision:", session_precision);
    println!("   {:<24}  {:>3}%", "Overall coverage:", overall_coverage);

    println!();
    if session_precision >= 70 {
        println!("   Precision diagnostic: calibrated — detected conventions are well-aligned");
    } else {
        println!(
            "   Precision diagnostic: low precision — consider re-reviewing flagged conventions"
        );
    }

    if context.already_confirmed > 0 || total_decided > 0 {
        println!("\n   Knowledge graph updated.");
    } else {
        println!("\n   No actions; graph unchanged.");
    }
}

fn levenshtein_distance(a: &str, b: &str) -> usize {
    let a_chars: Vec<char> = a.chars().collect();
    let b_chars: Vec<char> = b.chars().collect();
    let a_len = a_chars.len();
    let b_len = b_chars.len();

    if a_len == 0 {
        return b_len;
    }
    if b_len == 0 {
        return a_len;
    }

    let mut prev: Vec<usize> = (0..=b_len).collect();
    let mut curr = vec![0usize; b_len + 1];

    for i in 1..=a_len {
        curr[0] = i;
        for j in 1..=b_len {
            let cost = if a_chars[i - 1] == b_chars[j - 1] {
                0
            } else {
                1
            };
            curr[j] = (prev[j] + 1).min(curr[j - 1] + 1).min(prev[j - 1] + cost);
        }
        std::mem::swap(&mut prev, &mut curr);
    }

    prev[b_len]
}

pub fn fuzzy_match(query: &str, candidate: &str) -> bool {
    if query.is_empty() {
        return true;
    }

    if candidate.contains(query) {
        return true;
    }

    let candidate_chars: Vec<char> = candidate.chars().collect();
    let query_len = query.chars().count();

    for window_len in query_len.saturating_sub(2)..=(query_len + 2).min(candidate_chars.len()) {
        if window_len == 0 {
            continue;
        }
        for i in 0..=candidate_chars.len().saturating_sub(window_len) {
            let window: String = candidate_chars[i..i + window_len].iter().collect();
            let dist = levenshtein_distance(query, &window);
            if dist <= 2 {
                return true;
            }
        }
    }

    candidate.to_lowercase().contains(&query.to_lowercase())
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_item(node_id: i64, description: &str) -> ConventionItem {
        ConventionItem {
            node_id,
            description: description.to_owned(),
            nature: "convention".to_owned(),
            weight: "strong".to_owned(),
            confidence_pct: 80,
            adoption_count: 8,
            total_count: 10,
            adoption_rate_pct: 80,
            trend: "stable".to_owned(),
            source: "auto_detected".to_owned(),
            examples: Vec::new(),
            snapshot_hash: 0,
            description_hash: None,
            example_index: 0,
        }
    }

    fn make_item_with_examples(
        node_id: i64,
        description: &str,
        n_examples: usize,
    ) -> ConventionItem {
        let mut item = make_item(node_id, description);
        item.examples = (0..n_examples)
            .map(|i| CodeExample {
                file: format!("file_{i}.rs"),
                line: (i as u32) + 1,
                end_line: (i as u32) + 1,
                snippet: format!("snippet_{i}"),
                snippet_start_line: 0,
            })
            .collect();
        item
    }

    fn compute_summary_stats(results: &[ReviewAction]) -> (usize, usize, usize, usize, u32) {
        let confirmed = results
            .iter()
            .filter(|r| matches!(r, ReviewAction::Confirm { .. }))
            .count();
        let rejected = results
            .iter()
            .filter(|r| matches!(r, ReviewAction::Reject { .. }))
            .count();
        let partial = results
            .iter()
            .filter(|r| matches!(r, ReviewAction::Partial { .. }))
            .count();
        let skipped = results
            .iter()
            .filter(|r| matches!(r, ReviewAction::Skip { .. }))
            .count();
        let total_decided = confirmed.saturating_add(rejected).saturating_add(partial);
        let precision = if total_decided > 0 {
            (confirmed as f64 / total_decided as f64 * 100.0).round() as u32
        } else {
            0
        };
        (confirmed, rejected, partial, skipped, precision)
    }

    #[test]
    fn code_example_uses_snippet_start_line_for_line_numbers() {
        // When snippet_start_line is non-zero it should be read from JSON and
        // stored on CodeExample so widgets can compute correct line numbers.
        let ext = Some(serde_json::json!({
            "evidence": [
                {
                    "file": "src/lib.rs",
                    "line": 10,
                    "end_line": 12,
                    "snippet": "fn context_line() {}\nfn target_fn() {\n    do_thing();\n}",
                    "snippet_start_line": 8
                }
            ]
        }));

        let examples = parse_evidence(&ext);
        assert_eq!(examples.len(), 1);
        let ex = &examples[0];
        assert_eq!(ex.snippet_start_line, 8);
        assert_eq!(ex.line, 10);

        // Verify fallback: when snippet_start_line is absent it defaults to 0
        let ext_no_start = Some(serde_json::json!({
            "evidence": [
                {
                    "file": "src/lib.rs",
                    "line": 5,
                    "end_line": 5,
                    "snippet": "let x = 1;"
                }
            ]
        }));
        let examples2 = parse_evidence(&ext_no_start);
        assert_eq!(examples2.len(), 1);
        assert_eq!(examples2[0].snippet_start_line, 0);
    }

    #[test]
    fn app_next_previous_bounds() {
        let conventions = vec![
            ConventionItem {
                node_id: 1,
                description: "A".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 90,
                adoption_count: 10,
                total_count: 10,
                adoption_rate_pct: 100,
                trend: "stable".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 2,
                description: "B".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 80,
                adoption_count: 8,
                total_count: 10,
                adoption_rate_pct: 80,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
        ];
        let mut app = App::new(conventions);

        assert_eq!(app.current_index, 0);
        assert!(!app.review_complete);

        app.previous();
        assert_eq!(app.current_index, 0);

        app.next();
        assert_eq!(app.current_index, 1);
        assert!(app.review_complete);

        app.next();
        assert_eq!(app.current_index, 1);
        assert!(app.review_complete);

        app.previous();
        assert_eq!(app.current_index, 0);
        assert!(!app.review_complete);
    }

    #[test]
    fn app_current_returns_none_when_empty() {
        let app = App::new(Vec::new());
        assert!(app.current().is_none());
        assert_eq!(app.total(), 0);
    }

    #[test]
    fn app_acted_on_tracking() {
        let conventions = vec![
            ConventionItem {
                node_id: 1,
                description: "A".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 90,
                adoption_count: 10,
                total_count: 10,
                adoption_rate_pct: 100,
                trend: "stable".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 2,
                description: "B".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 80,
                adoption_count: 8,
                total_count: 10,
                adoption_rate_pct: 80,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 3,
                description: "C".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 70,
                adoption_count: 7,
                total_count: 10,
                adoption_rate_pct: 70,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
        ];
        let mut app = App::new(conventions);

        assert!(!app.is_acted_on(0));
        assert!(!app.is_acted_on(1));
        assert!(!app.all_acted_on());

        app.mark_acted_on(0);
        assert!(app.is_acted_on(0));
        assert!(!app.is_acted_on(1));
        assert!(!app.all_acted_on());

        app.mark_acted_on(1);
        app.mark_acted_on(2);
        assert!(app.all_acted_on());
    }

    #[test]
    fn app_advance_to_next_unreviewed() {
        let conventions = vec![
            ConventionItem {
                node_id: 1,
                description: "A".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 90,
                adoption_count: 10,
                total_count: 10,
                adoption_rate_pct: 100,
                trend: "stable".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 2,
                description: "B".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 80,
                adoption_count: 8,
                total_count: 10,
                adoption_rate_pct: 80,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 3,
                description: "C".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 70,
                adoption_count: 7,
                total_count: 10,
                adoption_rate_pct: 70,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
        ];
        let mut app = App::new(conventions);

        // Start at index 0, advance wraps to 1
        app.mark_acted_on(0);
        app.advance_to_next_unreviewed();
        assert_eq!(app.current_index, 1);
        assert!(!app.quit);

        // Mark 1 as acted and advance wraps to 2
        app.mark_acted_on(1);
        app.advance_to_next_unreviewed();
        assert_eq!(app.current_index, 2);
        assert!(!app.quit);

        // Mark 2 as acted and advance wraps back to find 0, but 0 is also acted → all acted → quit
        app.mark_acted_on(2);
        app.advance_to_next_unreviewed();
        assert!(app.quit);
    }

    #[test]
    fn app_advance_skips_acted_items() {
        let conventions = vec![
            ConventionItem {
                node_id: 1,
                description: "A".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 90,
                adoption_count: 10,
                total_count: 10,
                adoption_rate_pct: 100,
                trend: "stable".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 2,
                description: "B".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 80,
                adoption_count: 8,
                total_count: 10,
                adoption_rate_pct: 80,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
            ConventionItem {
                node_id: 3,
                description: "C".to_owned(),
                nature: "convention".to_owned(),
                weight: "strong".to_owned(),
                confidence_pct: 70,
                adoption_count: 7,
                total_count: 10,
                adoption_rate_pct: 70,
                trend: "rising".to_owned(),
                source: "auto_detected".to_owned(),
                examples: Vec::new(),
                snapshot_hash: 0,
                description_hash: None,
                example_index: 0,
            },
        ];
        let mut app = App::new(conventions);

        // Act on 0, skip to 1 — but mark 1 as already acted. Should go to 2.
        app.mark_acted_on(0);
        app.mark_acted_on(1);
        app.current_index = 0;
        app.advance_to_next_unreviewed();
        assert_eq!(app.current_index, 2);
        assert!(!app.quit);
    }

    #[test]
    fn review_action_confirm() {
        let action = ReviewAction::Confirm {
            node_id: 42,
            description: "test".to_owned(),
            examples: Vec::new(),
        };
        assert!(matches!(action, ReviewAction::Confirm { node_id: 42, .. }));
    }

    #[test]
    fn review_action_reject() {
        let action = ReviewAction::Reject {
            node_id: 7,
            snapshot_hash: 12345,
        };
        assert!(matches!(action, ReviewAction::Reject { node_id: 7, .. }));
    }

    #[test]
    fn review_action_partial() {
        let action = ReviewAction::Partial {
            node_id: 3,
            description: "test".to_owned(),
            original_node_id: 3,
        };
        assert!(matches!(action, ReviewAction::Partial { node_id: 3, .. }));
    }

    #[test]
    fn review_action_skip() {
        let action = ReviewAction::Skip { node_id: 1 };
        assert!(matches!(action, ReviewAction::Skip { node_id: 1 }));
    }

    #[test]
    fn compute_snapshot_hash_consistent() {
        let ext = Some(r#"{"source":"auto_detected","trend":"stable"}"#.to_owned());
        let h1 = compute_snapshot_hash(&ext);
        let h2 = compute_snapshot_hash(&ext);
        assert_eq!(h1, h2);

        let ext2 = Some(r#"{"source":"auto_detected","trend":"rising"}"#.to_owned());
        let h3 = compute_snapshot_hash(&ext2);
        assert_ne!(h1, h3);
    }

    #[test]
    fn compute_snapshot_hash_null_is_consistent() {
        let h1 = compute_snapshot_hash(&None);
        let h2 = compute_snapshot_hash(&None);
        assert_eq!(h1, h2);
    }

    #[test]
    fn show_summary_empty_results() {
        let results: Vec<ReviewAction> = vec![];
        let (_confirmed, _rejected, _partial, _skipped, precision) =
            compute_summary_stats(&results);
        assert_eq!(precision, 0);
    }

    #[test]
    fn show_summary_all_confirmed() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 3,
                description: "C".to_owned(),
                examples: Vec::new(),
            },
        ];
        let (confirmed, rejected, partial, skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 3);
        assert_eq!(rejected, 0);
        assert_eq!(partial, 0);
        assert_eq!(skipped, 0);
        assert_eq!(precision, 100);
    }

    #[test]
    fn show_summary_mixed_decisions() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 2,
                snapshot_hash: 0,
            },
            ReviewAction::Partial {
                node_id: 3,
                description: "C".to_owned(),
                original_node_id: 3,
            },
            ReviewAction::Skip { node_id: 4 },
        ];
        let (confirmed, rejected, partial, skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 1);
        assert_eq!(rejected, 1);
        assert_eq!(partial, 1);
        assert_eq!(skipped, 1);
        assert_eq!(precision, 33);
    }

    #[test]
    fn show_summary_high_precision_status() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 3,
                snapshot_hash: 0,
            },
        ];
        let (_confirmed, _rejected, _partial, _skipped, precision) =
            compute_summary_stats(&results);
        assert_eq!(precision, 67);
    }

    #[test]
    fn show_summary_low_precision_status() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 2,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 3,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 4,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _partial, _skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 1);
        assert_eq!(rejected, 3);
        assert_eq!(precision, 25);
        assert!(precision < 70);
    }

    #[test]
    fn show_summary_only_skipped() {
        let results = vec![
            ReviewAction::Skip { node_id: 1 },
            ReviewAction::Skip { node_id: 2 },
        ];
        let (confirmed, rejected, partial, skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 0);
        assert_eq!(rejected, 0);
        assert_eq!(partial, 0);
        assert_eq!(skipped, 2);
        assert_eq!(precision, 0);
    }

    #[test]
    fn show_summary_all_rejected() {
        let results = vec![
            ReviewAction::Reject {
                node_id: 1,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 2,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _partial, _skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 0);
        assert_eq!(rejected, 2);
        assert_eq!(precision, 0);
    }

    #[test]
    fn show_summary_precision_rounding() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 3,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 4,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 5,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _partial, _skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 2);
        assert_eq!(rejected, 3);
        assert_eq!(precision, 40);
    }

    #[test]
    fn show_summary_status_threshold_below_70() {
        // 7/12 = 58.3% -> 58% should be low precision
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 3,
                description: "C".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 4,
                description: "D".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 5,
                description: "E".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 6,
                description: "F".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 7,
                description: "G".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 8,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 9,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 10,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 11,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 12,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        // 7/12 = 58.3% -> 58%
        assert_eq!(confirmed, 7);
        assert_eq!(rejected, 5);
        assert_eq!(precision, 58);
        assert!(precision < 70);
    }

    #[test]
    fn show_summary_status_below_70() {
        // 6/9 = 66.7% -> 67% should be below calibrated
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 3,
                description: "C".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 4,
                description: "D".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 5,
                description: "E".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 6,
                description: "F".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 7,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 8,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 9,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        // 6/9 = 66.7% -> 67%
        assert_eq!(confirmed, 6);
        assert_eq!(rejected, 3);
        assert_eq!(precision, 67);
        assert!(precision < 70);
    }

    #[test]
    fn fuzzy_match_exact_substring() {
        assert!(fuzzy_match("error", "error handling"));
        assert!(fuzzy_match("ERROR", "error handling"));
        assert!(fuzzy_match("log", "logging is done via tracing"));
    }

    #[test]
    fn fuzzy_match_fuzzy_typo() {
        assert!(fuzzy_match("err", "error handling"));
        assert!(fuzzy_match("loging", "logging"));
        assert!(fuzzy_match("handlng", "error handling"));
    }

    #[test]
    fn fuzzy_match_no_match() {
        assert!(!fuzzy_match("xyzzy", "error handling"));
        assert!(!fuzzy_match("completelydifferent", "error handling"));
    }

    #[test]
    fn fuzzy_match_empty_query_matches_all() {
        assert!(fuzzy_match("", "anything"));
        assert!(fuzzy_match("", ""));
    }

    #[test]
    fn levenshtein_distance_identical() {
        assert_eq!(levenshtein_distance("abc", "abc"), 0);
    }

    #[test]
    fn levenshtein_distance_one_substitution() {
        assert_eq!(levenshtein_distance("abc", "adc"), 1);
    }

    #[test]
    fn levenshtein_distance_empty() {
        assert_eq!(levenshtein_distance("", "abc"), 3);
        assert_eq!(levenshtein_distance("abc", ""), 3);
    }

    #[test]
    fn precision_all_confirmed() {
        let results: Vec<ReviewAction> = (0..10)
            .map(|i| ReviewAction::Confirm {
                node_id: i,
                description: "ok".to_owned(),
                examples: Vec::new(),
            })
            .collect();
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 10);
        assert_eq!(rejected, 0);
        assert_eq!(precision, 100);
    }

    #[test]
    fn precision_all_rejected() {
        let results: Vec<ReviewAction> = (0..5)
            .map(|i| ReviewAction::Reject {
                node_id: i,
                snapshot_hash: 0,
            })
            .collect();
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 0);
        assert_eq!(rejected, 5);
        assert_eq!(precision, 0);
    }

    #[test]
    fn precision_all_skipped() {
        let results: Vec<ReviewAction> =
            (0..5).map(|i| ReviewAction::Skip { node_id: i }).collect();
        let (confirmed, rejected, _, skipped, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 0);
        assert_eq!(rejected, 0);
        assert_eq!(skipped, 5);
        assert_eq!(precision, 0);
    }

    #[test]
    fn show_summary_status_threshold_at_exactly_70() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 3,
                description: "C".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 4,
                description: "D".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 5,
                description: "E".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 6,
                description: "F".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 7,
                description: "G".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 8,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 9,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 10,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 7);
        assert_eq!(rejected, 3);
        assert_eq!(precision, 70);
    }

    #[test]
    fn show_summary_status_threshold_at_69() {
        let results = vec![
            ReviewAction::Confirm {
                node_id: 1,
                description: "A".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 2,
                description: "B".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 3,
                description: "C".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 4,
                description: "D".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 5,
                description: "E".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 6,
                description: "F".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 7,
                description: "G".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 8,
                description: "H".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Confirm {
                node_id: 9,
                description: "I".to_owned(),
                examples: Vec::new(),
            },
            ReviewAction::Reject {
                node_id: 10,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 11,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 12,
                snapshot_hash: 0,
            },
            ReviewAction::Reject {
                node_id: 13,
                snapshot_hash: 0,
            },
        ];
        let (confirmed, rejected, _, _, precision) = compute_summary_stats(&results);
        assert_eq!(confirmed, 9);
        assert_eq!(rejected, 4);
        assert_eq!(precision, 69);
        assert!(precision < 70);
    }

    // ── levenshtein_distance / fuzzy_match ──────────────────────────

    #[test]
    fn levenshtein_distance_identical_is_zero() {
        assert_eq!(levenshtein_distance("hello", "hello"), 0);
        assert_eq!(levenshtein_distance("", ""), 0);
    }

    #[test]
    fn levenshtein_distance_empty_inputs() {
        assert_eq!(levenshtein_distance("", "abc"), 3);
        assert_eq!(levenshtein_distance("abc", ""), 3);
    }

    #[test]
    fn levenshtein_distance_single_edit() {
        assert_eq!(levenshtein_distance("kitten", "sitten"), 1);
        assert_eq!(levenshtein_distance("kitten", "kittens"), 1);
        assert_eq!(levenshtein_distance("abcd", "abc"), 1);
    }

    #[test]
    fn levenshtein_distance_classic_example() {
        // kitten → sitting: 3 edits (k→s, e→i, +g)
        assert_eq!(levenshtein_distance("kitten", "sitting"), 3);
    }

    #[test]
    fn fuzzy_match_empty_query_matches_anything() {
        assert!(fuzzy_match("", "anything"));
        assert!(fuzzy_match("", ""));
    }

    #[test]
    fn fuzzy_match_substring_matches() {
        assert!(fuzzy_match("error", "error handling"));
        assert!(fuzzy_match("hand", "error handling"));
    }

    #[test]
    fn fuzzy_match_close_typo_matches() {
        // Within 2 edits of substring window.
        assert!(fuzzy_match("eror", "error handling"));
        assert!(fuzzy_match("erorr", "error handling"));
    }

    #[test]
    fn fuzzy_match_far_query_does_not_match() {
        assert!(!fuzzy_match("xyzqq", "error handling"));
    }

    #[test]
    fn fuzzy_match_falls_back_to_lowercase_substring() {
        assert!(fuzzy_match("error", "Error Handling"));
    }

    // ── App search / filter behavior ────────────────────────────────

    fn three_item_app() -> App {
        let conventions = vec![
            make_item(1, "Use thiserror for error handling"),
            make_item(2, "Snake case naming convention"),
            make_item(3, "Always Result<T, Error>"),
        ];
        App::new(conventions)
    }

    #[test]
    fn app_filtered_total_starts_at_full_list() {
        let app = three_item_app();
        assert_eq!(app.filtered_total(), 3);
        assert_eq!(app.filtered_current_index(), 0);
    }

    #[test]
    fn app_filtered_next_and_previous_traverse_all() {
        let mut app = three_item_app();
        assert_eq!(app.current_index, 0);
        app.filtered_next();
        assert_eq!(app.current_index, 1);
        app.filtered_next();
        assert_eq!(app.current_index, 2);
        // At end — must not move past.
        app.filtered_next();
        assert_eq!(app.current_index, 2);

        app.filtered_previous();
        assert_eq!(app.current_index, 1);
        app.filtered_previous();
        assert_eq!(app.current_index, 0);
        // At start — must not move before.
        app.filtered_previous();
        assert_eq!(app.current_index, 0);
    }

    #[test]
    fn app_push_search_char_filters_list() {
        let mut app = three_item_app();
        app.push_search_char('e');
        app.push_search_char('r');
        app.push_search_char('r');
        app.push_search_char('o');
        app.push_search_char('r');
        // "error" matches items 1 and 3.
        assert_eq!(app.search_query, "error");
        assert!(app.filtered_total() >= 1);
        // First filtered match becomes current.
        let cur = app.current().expect("current should be set");
        assert!(cur.description.to_lowercase().contains("error"));
    }

    #[test]
    fn app_pop_search_char_shrinks_query() {
        let mut app = three_item_app();
        for c in "snake".chars() {
            app.push_search_char(c);
        }
        assert_eq!(app.search_query, "snake");
        app.pop_search_char();
        assert_eq!(app.search_query, "snak");
        // Empty pop cancels search and restores full list.
        for _ in 0..app.search_query.chars().count() {
            app.pop_search_char();
        }
        assert!(app.search_query.is_empty());
        assert_eq!(app.filtered_total(), 3);
        assert!(!app.search_mode);
    }

    #[test]
    fn app_lock_filter_locks_when_non_empty() {
        let mut app = three_item_app();
        app.search_mode = true;
        for c in "error".chars() {
            app.push_search_char(c);
        }
        let total_before = app.filtered_total();
        assert!(total_before >= 1);
        app.lock_filter();
        assert!(app.filter_locked);
        assert!(!app.search_mode);
    }

    #[test]
    fn app_lock_filter_no_op_when_filter_empty() {
        let mut app = three_item_app();
        app.search_mode = true;
        // Search query that matches nothing.
        for c in "zzzzzzzz".chars() {
            app.push_search_char(c);
        }
        // If no matches, lock_filter returns without changing state.
        if app.filtered_indices.is_empty() {
            app.lock_filter();
            assert!(!app.filter_locked);
        }
    }

    #[test]
    fn app_cancel_search_resets_state() {
        let mut app = three_item_app();
        app.search_mode = true;
        for c in "snake".chars() {
            app.push_search_char(c);
        }
        app.lock_filter();
        app.cancel_search();
        assert_eq!(app.search_query, "");
        assert!(!app.search_mode);
        assert!(!app.filter_locked);
        assert_eq!(app.filtered_total(), 3);
        assert_eq!(app.current_index, 0);
    }

    #[test]
    fn app_filtered_current_returns_current_item() {
        let app = three_item_app();
        let cur = app.filtered_current().expect("should have current");
        assert_eq!(cur.node_id, 1);
    }

    #[test]
    fn app_filtered_current_none_when_empty() {
        let app = App::new(Vec::new());
        assert!(app.filtered_current().is_none());
    }

    // ── App example navigation ──────────────────────────────────────

    #[test]
    fn app_example_total_reflects_current_item() {
        let mut app = App::new(vec![make_item_with_examples(1, "C", 3)]);
        assert_eq!(app.example_total(), 3);
        app.conventions.clear();
        assert_eq!(app.example_total(), 0);
    }

    #[test]
    fn app_next_example_cycles() {
        let mut app = App::new(vec![make_item_with_examples(1, "C", 3)]);
        assert_eq!(app.current().unwrap().example_index, 0);
        app.next_example();
        assert_eq!(app.current().unwrap().example_index, 1);
        app.next_example();
        assert_eq!(app.current().unwrap().example_index, 2);
        app.next_example();
        // Wraps back to 0.
        assert_eq!(app.current().unwrap().example_index, 0);
    }

    #[test]
    fn app_previous_example_wraps_at_zero() {
        let mut app = App::new(vec![make_item_with_examples(1, "C", 3)]);
        assert_eq!(app.current().unwrap().example_index, 0);
        app.previous_example();
        // Wraps to last.
        assert_eq!(app.current().unwrap().example_index, 2);
        app.previous_example();
        assert_eq!(app.current().unwrap().example_index, 1);
    }

    #[test]
    fn app_next_example_no_op_with_one_example() {
        let mut app = App::new(vec![make_item_with_examples(1, "C", 1)]);
        app.next_example();
        assert_eq!(app.current().unwrap().example_index, 0);
        app.previous_example();
        assert_eq!(app.current().unwrap().example_index, 0);
    }

    #[test]
    fn app_next_example_no_op_with_zero_examples() {
        let mut app = App::new(vec![make_item(1, "C")]);
        app.next_example();
        app.previous_example();
        assert_eq!(app.current().unwrap().example_index, 0);
    }

    #[test]
    fn app_next_resets_example_index() {
        let mut app = App::new(vec![
            make_item_with_examples(1, "A", 3),
            make_item_with_examples(2, "B", 3),
        ]);
        app.next_example();
        app.next_example();
        assert_eq!(app.current().unwrap().example_index, 2);
        app.next();
        assert_eq!(app.current_index, 1);
        // example_index resets when moving between conventions.
        assert_eq!(app.current().unwrap().example_index, 0);
        app.previous();
        assert_eq!(app.current().unwrap().example_index, 0);
    }

    // ── parse_evidence edge cases ────────────────────────────────────

    #[test]
    fn parse_evidence_with_no_ext_returns_empty() {
        let examples = parse_evidence(&None);
        assert!(examples.is_empty());
    }

    #[test]
    fn parse_evidence_no_evidence_key_returns_empty() {
        let ext = Some(serde_json::json!({"source": "auto_detected"}));
        assert!(parse_evidence(&ext).is_empty());
    }

    #[test]
    fn parse_evidence_evidence_not_array_returns_empty() {
        let ext = Some(serde_json::json!({"evidence": "not-an-array"}));
        assert!(parse_evidence(&ext).is_empty());
    }

    #[test]
    fn parse_evidence_skips_rows_with_empty_file_and_snippet() {
        let ext = Some(serde_json::json!({
            "evidence": [
                {"file": "", "snippet": ""},
                {"file": "a.rs", "snippet": "code"},
                {"file": "", "line": 0, "snippet": ""},
            ]
        }));
        let examples = parse_evidence(&ext);
        assert_eq!(examples.len(), 1);
        assert_eq!(examples[0].file, "a.rs");
    }

    #[test]
    fn parse_evidence_keeps_synthetic_composite_when_snippet_present() {
        let ext = Some(serde_json::json!({
            "evidence": [
                {"file": "", "snippet": "98 files match this convention"}
            ]
        }));
        let examples = parse_evidence(&ext);
        assert_eq!(examples.len(), 1);
        assert!(examples[0].file.is_empty());
        assert!(examples[0].snippet.contains("98 files"));
    }

    #[test]
    fn parse_evidence_end_line_defaults_to_line() {
        let ext = Some(serde_json::json!({
            "evidence": [
                {"file": "a.rs", "line": 10, "snippet": "x"}
            ]
        }));
        let examples = parse_evidence(&ext);
        assert_eq!(examples.len(), 1);
        assert_eq!(examples[0].line, 10);
        assert_eq!(examples[0].end_line, 10);
    }

    #[test]
    fn parse_evidence_handles_snippet_object_with_content() {
        let ext = Some(serde_json::json!({
            "evidence": [
                {"file": "a.rs", "line": 1, "snippet": {"content": "x"}}
            ]
        }));
        let examples = parse_evidence(&ext);
        assert_eq!(examples.len(), 1);
        assert_eq!(examples[0].snippet, "x");
    }

    // ── ReviewAction::node_id_if_reject ─────────────────────────────

    #[test]
    fn node_id_if_reject_returns_id_for_all_variants() {
        let confirm = ReviewAction::Confirm {
            node_id: 1,
            description: "x".to_owned(),
            examples: Vec::new(),
        };
        let reject = ReviewAction::Reject {
            node_id: 2,
            snapshot_hash: 0,
        };
        let partial = ReviewAction::Partial {
            node_id: 3,
            description: "x".to_owned(),
            original_node_id: 3,
        };
        let skip = ReviewAction::Skip { node_id: 4 };
        assert_eq!(confirm.node_id_if_reject(), Some(1));
        assert_eq!(reject.node_id_if_reject(), Some(2));
        assert_eq!(partial.node_id_if_reject(), Some(3));
        assert_eq!(skip.node_id_if_reject(), Some(4));
    }

    // ── show_summary direct invocation ──────────────────────────────

    #[test]
    fn show_summary_runs_all_branches() {
        // Empty results, zero context → "No actions; graph unchanged" branch.
        show_summary(
            &[],
            &SummaryContext {
                total_in_scope: 0,
                already_confirmed: 0,
            },
        );

        // High-precision branch with actions and existing confirmed.
        show_summary(
            &[
                ReviewAction::Confirm {
                    node_id: 1,
                    description: "A".to_owned(),
                    examples: Vec::new(),
                },
                ReviewAction::Reject {
                    node_id: 2,
                    snapshot_hash: 0,
                },
            ],
            &SummaryContext {
                total_in_scope: 5,
                already_confirmed: 3,
            },
        );

        // Low-precision branch.
        show_summary(
            &[
                ReviewAction::Reject {
                    node_id: 1,
                    snapshot_hash: 0,
                },
                ReviewAction::Reject {
                    node_id: 2,
                    snapshot_hash: 0,
                },
            ],
            &SummaryContext {
                total_in_scope: 2,
                already_confirmed: 0,
            },
        );
    }

    // ── apply_review_actions ────────────────────────────────────────

    fn open_test_db() -> Arc<Mutex<rusqlite::Connection>> {
        let db = seshat_storage::Database::open(":memory:").expect("in-memory DB");
        db.connection().clone()
    }

    #[test]
    fn apply_review_actions_empty_is_noop() {
        let conn = open_test_db();
        // Should return Ok without touching the DB.
        apply_review_actions(&conn, "main", &[]).unwrap();
    }

    #[test]
    fn apply_review_actions_skip_only_succeeds() {
        let conn = open_test_db();
        // Skip actions are no-ops in the action loop, so the all-failed
        // rollback branch must NOT trigger.
        apply_review_actions(&conn, "main", &[ReviewAction::Skip { node_id: 1 }]).unwrap();
    }

    #[test]
    fn apply_review_actions_confirm_persists_decision() {
        let conn = open_test_db();
        let description = "test confirm";
        let action = ReviewAction::Confirm {
            node_id: 0,
            description: description.to_owned(),
            examples: vec![CodeExample {
                file: "src/main.rs".to_owned(),
                line: 1,
                end_line: 2,
                snippet: "fn main() {}".to_owned(),
                snippet_start_line: 1,
            }],
        };
        apply_review_actions(&conn, "main", &[action]).unwrap();

        // Verify the decisions table now has an approved row keyed by hash.
        let expected_hash = compute_description_hash(description);
        let repo = SqliteDecisionRepository::new(conn.clone());
        let decision = repo
            .get_by_hash(&expected_hash)
            .unwrap()
            .expect("approved decision row should exist");
        assert_eq!(decision.state, DecisionState::Approved);
        assert_eq!(decision.description, description);
        assert_eq!(decision.decided_on_branch, BranchId("main".to_owned()));
        assert_eq!(decision.examples.len(), 1);
        assert_eq!(decision.examples[0].file, "src/main.rs");

        // No user-source node should be created by the TUI confirm path
        // anymore — decisions live in their own table.
        let user_node_count: i64 = {
            let g = lock_conn(&conn).unwrap();
            g.query_row(
                "SELECT COUNT(*) FROM nodes
                 WHERE branch_id = 'main'
                   AND json_extract(ext_data, '$.source') = 'user'",
                [],
                |r| r.get(0),
            )
            .unwrap()
        };
        assert_eq!(user_node_count, 0);
    }

    #[test]
    fn apply_review_actions_partial_persists_decision_with_partial_state() {
        let conn = open_test_db();
        let description = "partial convention example";
        let action = ReviewAction::Partial {
            node_id: 7,
            description: description.to_owned(),
            original_node_id: 7,
        };
        apply_review_actions(&conn, "main", &[action]).unwrap();

        let hash = compute_description_hash(description);
        let repo = SqliteDecisionRepository::new(conn.clone());
        let decision = repo
            .get_by_hash(&hash)
            .unwrap()
            .expect("partial decision row should exist");
        assert_eq!(decision.state, DecisionState::Partial);
        assert_eq!(decision.nature, DecisionNature::Preference);
        // The literal description is stored — no "Partial: ..." prefix anymore;
        // the state column carries that signal.
        assert_eq!(decision.description, description);
    }

    #[test]
    fn count_confirmed_conventions_returns_zero_on_empty_db() {
        let conn = open_test_db();
        assert_eq!(count_confirmed_conventions(&conn), 0);
    }

    #[test]
    fn count_confirmed_conventions_counts_only_approved_partial_recorded() {
        // AC: SELECT COUNT(*) FROM decisions WHERE state IN
        // ('approved','partial','recorded'). Rejected rows must be excluded.
        let conn = open_test_db();
        let mix = [
            ("approved 1", DecisionState::Approved),
            ("approved 2", DecisionState::Approved),
            ("partial 1", DecisionState::Partial),
            ("recorded 1", DecisionState::Recorded),
            ("recorded 2", DecisionState::Recorded),
            ("rejected 1", DecisionState::Rejected),
            ("rejected 2", DecisionState::Rejected),
        ];
        for (description, state) in mix {
            let hash = compute_description_hash(description);
            seed_decision_for_hash(&conn, "main", description, &hash, state);
        }
        // 2 approved + 1 partial + 2 recorded = 5; the 2 rejected are excluded.
        assert_eq!(count_confirmed_conventions(&conn), 5);
    }

    #[test]
    fn count_confirmed_conventions_ignores_branch_filter() {
        // AC: "No branch_id filter" — a decision approved on any branch
        // counts toward the project-wide total once.
        let conn = open_test_db();
        seed_decision_for_hash(
            &conn,
            "main",
            "main convention",
            &compute_description_hash("main convention"),
            DecisionState::Approved,
        );
        seed_decision_for_hash(
            &conn,
            "feature/x",
            "feature convention",
            &compute_description_hash("feature convention"),
            DecisionState::Approved,
        );
        seed_decision_for_hash(
            &conn,
            "feature/y",
            "another feature convention",
            &compute_description_hash("another feature convention"),
            DecisionState::Partial,
        );
        // 3 confirmed across 3 different branches; the count is project-wide.
        assert_eq!(count_confirmed_conventions(&conn), 3);
    }

    #[test]
    fn count_confirmed_conventions_handles_large_count() {
        // AC: "Unit tests cover ... large count". Seed 250 confirmed
        // decisions across the three confirmed-counting states and 50
        // rejected (which must NOT be counted).
        let conn = open_test_db();
        let confirmed_states = [
            DecisionState::Approved,
            DecisionState::Partial,
            DecisionState::Recorded,
        ];
        for i in 0..250 {
            let description = format!("confirmed convention #{i:03}");
            let hash = compute_description_hash(&description);
            seed_decision_for_hash(
                &conn,
                "main",
                &description,
                &hash,
                confirmed_states[i % confirmed_states.len()],
            );
        }
        for i in 0..50 {
            let description = format!("rejected convention #{i:03}");
            let hash = compute_description_hash(&description);
            seed_decision_for_hash(&conn, "main", &description, &hash, DecisionState::Rejected);
        }
        assert_eq!(count_confirmed_conventions(&conn), 250);
    }

    #[test]
    fn query_conventions_for_review_empty_db_returns_empty() {
        let conn = open_test_db();
        let (items, branch) = query_conventions_for_review(&conn, "main").unwrap();
        assert!(items.is_empty());
        assert_eq!(branch, "main");
    }

    /// Insert an auto-detected convention node and return its description_hash
    /// alongside its rowid. Helper for the LEFT JOIN tests below.
    fn seed_auto_convention(
        conn: &Arc<Mutex<rusqlite::Connection>>,
        branch_id: &str,
        description: &str,
        confidence: f64,
    ) -> String {
        let hash = compute_description_hash(description);
        let g = lock_conn(conn).unwrap();
        g.execute(
            "INSERT INTO nodes
                 (branch_id, nature, weight, confidence,
                  adoption_count, total_count, description, ext_data, description_hash)
             VALUES (?1, 'convention', 'strong', ?2, 5, 5, ?3,
                     json('{\"source\":\"auto_detected\"}'), ?4)",
            params![branch_id, confidence, description, hash],
        )
        .unwrap();
        hash
    }

    fn seed_decision_for_hash(
        conn: &Arc<Mutex<rusqlite::Connection>>,
        branch_id: &str,
        description: &str,
        hash: &str,
        state: DecisionState,
    ) {
        let repo = SqliteDecisionRepository::new(conn.clone());
        repo.upsert(&Decision {
            description_hash: hash.to_owned(),
            description: description.to_owned(),
            state,
            nature: DecisionNature::Convention,
            weight: DecisionWeight::Strong,
            category: None,
            reason: None,
            examples: vec![],
            decided_on_branch: BranchId(branch_id.to_owned()),
            decided_at: 1_700_000_000,
            updated_at: 1_700_000_000,
        })
        .unwrap();
    }

    #[test]
    fn query_conventions_for_review_excludes_decided_node() {
        // AC: insert two auto nodes, decide one (any state), only the
        // undecided one returns.
        let conn = open_test_db();
        let _decided_hash = seed_auto_convention(&conn, "main", "decided convention", 0.9);
        let _undecided_hash = seed_auto_convention(&conn, "main", "undecided convention", 0.8);

        seed_decision_for_hash(
            &conn,
            "main",
            "decided convention",
            &compute_description_hash("decided convention"),
            DecisionState::Approved,
        );

        let (items, _) = query_conventions_for_review(&conn, "main").unwrap();
        assert_eq!(
            items.len(),
            1,
            "exactly one undecided convention should remain"
        );
        assert_eq!(items[0].description, "undecided convention");
    }

    #[test]
    fn query_conventions_for_review_excludes_decided_in_any_state() {
        // AC: bulk case — 100 auto nodes, 50 decided across all four states,
        // verify only 50 returned (the undecided ones).
        let conn = open_test_db();
        let states = [
            DecisionState::Approved,
            DecisionState::Rejected,
            DecisionState::Partial,
            DecisionState::Recorded,
        ];
        // Confidences chosen so iteration order is deterministic and the
        // returned sort order is the descending index 99 -> 50.
        for i in 0..100u32 {
            let desc = format!("convention #{i:03}");
            // Confidence decreases as i increases — ORDER BY confidence DESC
            // sorts undecided ascending by index in the result.
            let confidence = 1.0 - (i as f64) / 1000.0;
            let hash = seed_auto_convention(&conn, "main", &desc, confidence);
            if i < 50 {
                seed_decision_for_hash(&conn, "main", &desc, &hash, states[(i as usize) % 4]);
            }
        }

        let (items, _) = query_conventions_for_review(&conn, "main").unwrap();
        assert_eq!(
            items.len(),
            50,
            "expected exactly 50 undecided rows; got {}",
            items.len()
        );

        // The returned descriptions must be exactly indices 50..=99.
        let mut returned: Vec<u32> = items
            .iter()
            .map(|c| {
                c.description
                    .trim_start_matches("convention #")
                    .parse::<u32>()
                    .expect("parseable index")
            })
            .collect();
        returned.sort_unstable();
        let expected: Vec<u32> = (50..100).collect();
        assert_eq!(
            returned, expected,
            "returned set must be exactly the undecided indices 50..=99"
        );
    }

    #[test]
    fn query_conventions_for_review_uses_index_on_decisions() {
        // AC: EXPLAIN QUERY PLAN must show indexed access on decisions
        // (i.e. SEARCH ... USING INDEX, never SCAN decisions).
        let conn = open_test_db();
        let g = lock_conn(&conn).unwrap();

        // Same SQL as the production path, kept inline so the assertion
        // tracks any change to the actual query.
        let sql = format!(
            "EXPLAIN QUERY PLAN
             SELECT n.id, n.description, n.nature, n.weight, n.confidence,
                    n.adoption_count, n.total_count, n.ext_data, n.description_hash
             FROM nodes n
             LEFT JOIN decisions d ON d.description_hash = n.description_hash
             WHERE n.branch_id = ?1
               AND n.nature IN ('convention', 'observation')
               AND {sql_not_removed}
               AND d.description_hash IS NULL
             ORDER BY n.confidence DESC",
            sql_not_removed = SQL_NOT_REMOVED
        );
        let mut stmt = g.prepare(&sql).unwrap();
        let plan_rows: Vec<String> = stmt
            .query_map(params!["main"], |row| row.get::<_, String>(3))
            .unwrap()
            .map(|r| r.unwrap())
            .collect();
        let plan = plan_rows.join("\n");

        // The decisions side of the LEFT JOIN must use indexed access.
        // SQLite spells this "SEARCH d USING COVERING INDEX
        // sqlite_autoindex_decisions_1 (description_hash=?) LEFT-JOIN" —
        // the alias `d` is used in the plan because the FROM clause aliased
        // `decisions` as `d`. The PK auto-index is what keeps this lookup
        // O(log N) instead of O(N).
        assert!(
            plan.contains("sqlite_autoindex_decisions_1"),
            "expected the decisions PK auto-index in the plan; got: {plan}"
        );
        assert!(
            !plan.contains("SCAN d ") && !plan.contains("SCAN decisions"),
            "decisions side of join should be searched via index, not scanned; got: {plan}"
        );
        assert!(
            plan.contains("SEARCH d "),
            "expected SEARCH d (decisions alias) in plan; got: {plan}"
        );
    }

    #[test]
    fn query_conventions_for_review_keeps_undecided_with_null_hash() {
        // Defensive: an auto-detected node whose description_hash is NULL
        // (legacy pre-V8 row, or a row inserted before US-008 backfilled
        // hashes) must NOT be filtered out — there's no decision to match
        // against, so it stays in the queue. SQL semantics: the LEFT JOIN's
        // ON condition `d.description_hash = NULL` is unknown for any row,
        // so the join produces NULL on the decisions side, and the WHERE
        // `d.description_hash IS NULL` predicate keeps the node.
        let conn = open_test_db();
        {
            let g = lock_conn(&conn).unwrap();
            g.execute(
                "INSERT INTO nodes
                     (branch_id, nature, weight, confidence,
                      adoption_count, total_count, description, ext_data, description_hash)
                 VALUES ('main', 'convention', 'strong', 0.9, 5, 5,
                         'legacy null-hash node',
                         json('{\"source\":\"auto_detected\"}'), NULL)",
                [],
            )
            .unwrap();
        }
        let (items, _) = query_conventions_for_review(&conn, "main").unwrap();
        assert_eq!(items.len(), 1);
        assert_eq!(items[0].description, "legacy null-hash node");
        assert!(items[0].description_hash.is_none());
    }
}